[jira] Commented: (OFBIZ-3485) Error in updating party postal address if party has an EftAccount
[ https://issues.apache.org/jira/browse/OFBIZ-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12970344#action_12970344 ] Si Chen commented on OFBIZ-3485: What happened to this? Has it been fixed? Error in updating party postal address if party has an EftAccount -- Key: OFBIZ-3485 URL: https://issues.apache.org/jira/browse/OFBIZ-3485 Project: OFBiz Issue Type: Bug Reporter: Abdullah Shaikh Try to update the party Postal Address, which have an EftAccount, using the Update button in Profile's Contact Information section, you get the below error, The Following Errors Occurred: Error trying to begin transaction, could not process method: The current transaction is marked for rollback, not beginning a new transaction and aborting current operation; the rollbackOnly was caused by: Service [updateEftAccount] threw an unexpected exception/errororg.ofbiz.service.ServiceValidationException: The following required parameter is missing: [updateEftAccount.nameOnAccount] (The following required parameter is missing: [updateEftAccount.nameOnAccount]) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-269) Ajax a form element in ofbiz
[ https://issues.apache.org/jira/browse/OFBIZ-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906086#action_12906086 ] Si Chen commented on OFBIZ-269: --- I am currently out of the office. If you are a client of Open Source Strategies, please contact our support list for help. -- Si Chen Open Source Strategies, Inc. sic...@opensourcestrategies.com http://www.OpenSourceStrategies.com Ajax a form element in ofbiz Key: OFBIZ-269 URL: https://issues.apache.org/jira/browse/OFBIZ-269 Project: OFBiz Issue Type: Improvement Components: party Affects Versions: SVN trunk Environment: Based on svn 7564 Reporter: Marco Risaliti Assignee: Si Chen Priority: Trivial Attachments: ajax.js, AjaxPartyEvents.java, AjaxPartyEvents_2.java, AjaxPartyServices.java, AjaxPartyServices_2.java, diff.log, diff_2.log This is a copy of the old Jira issue http://jira.undersunconsulting.com/browse/OFBIZ-885 from Fred Forester. == This is an exmaple of how to Ajaxize a control in ofbiz. It uses an auto complete event for the last name on the party lookup page. when the last name is selected it fills the partyId on the form. the example does not take any role types or groups into account. AllCommentsWork LogChange History Sort Order: Comment by Fred Forester [16/May/06 10:14 AM] [ Permlink ] patch file Comment by Fred Forester [16/May/06 10:15 AM] [ Permlink ] new file Comment by Fred Forester [16/May/06 10:17 AM] [ Permlink ] a patch and a new file Comment by Fred Forester [16/May/06 10:19 AM] [ Permlink ] Sorry about the duplicate files. the upload made it appear to me that one replaced the other. :) Comment by Si Chen [19/May/06 09:14 AM] [ Permlink ] This is my version of your AjaxPartyServices.java as AjaxPartyEvents.java Comment by Si Chen [19/May/06 09:16 AM] [ Permlink ] Hey everybody - this works! I looked at your code and would like to suggest - 1. AjaxPartyServices.java is really AjaxPartyEvents.java since you have written an Events servlet not a Service. I just changed it and uploaded it for you. 2. I think a lot of the Javascript in findparty.ftl should be moved into an ajax javascript file that could be shared everywhere, since they seem to be pretty standard? 3. Please clean up the formatting of AjaxPartyEvents.java. See http://ofbizwiki.go-integral.com/Wiki.jsp?page=FAQ27 Comment by Si Chen [19/May/06 09:38 AM] [ Permlink ] David and Andy - Can you make a specialized/ajax directory so we can put some ajax-related stuff in there, like this, that all the applications/ can use, but at the same time not mess with framework/? Comment by Fred Forester [19/May/06 09:42 AM] [ Permlink ] I agree 100% with all 3 points and had every intention of getting to 1 and 2. didn't know about 3 till just now :( I found out last night after loading 200,000 users that things got a little slow. a temporary fix was to require at least 5 characters in the lastname. I'm working on 2 other jira things now and can get to this on tuesday. Comment by Si Chen [19/May/06 11:21 AM] [ Permlink ] Great. Also I think it would be nice to change your AjaxPartyEvents.java to a more generic AjaxEvents.java and parametrize the entities and fields, etc., so that it could be used everywhere for auto-completion. We could then integrate it into the form-widget at a later date. Comment by Fred Forester [23/May/06 04:51 PM] [ Permlink ] Here are the new files for the ajax lastname control. I wasnt sure what was wrong with the formatting. maybe a critique of the formatting would give me a better idea of what's wrong. Fred -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-269) Ajax a form element in ofbiz
[ https://issues.apache.org/jira/browse/OFBIZ-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906098#action_12906098 ] Si Chen commented on OFBIZ-269: --- I am currently out of the office. If you are a client of Open Source Strategies, please contact our support list for help. -- Si Chen Open Source Strategies, Inc. sic...@opensourcestrategies.com http://www.OpenSourceStrategies.com Ajax a form element in ofbiz Key: OFBIZ-269 URL: https://issues.apache.org/jira/browse/OFBIZ-269 Project: OFBiz Issue Type: Improvement Components: party Affects Versions: SVN trunk Environment: Based on svn 7564 Reporter: Marco Risaliti Assignee: Si Chen Priority: Trivial Attachments: ajax.js, AjaxPartyEvents.java, AjaxPartyEvents_2.java, AjaxPartyServices.java, AjaxPartyServices_2.java, diff.log, diff_2.log This is a copy of the old Jira issue http://jira.undersunconsulting.com/browse/OFBIZ-885 from Fred Forester. == This is an exmaple of how to Ajaxize a control in ofbiz. It uses an auto complete event for the last name on the party lookup page. when the last name is selected it fills the partyId on the form. the example does not take any role types or groups into account. AllCommentsWork LogChange History Sort Order: Comment by Fred Forester [16/May/06 10:14 AM] [ Permlink ] patch file Comment by Fred Forester [16/May/06 10:15 AM] [ Permlink ] new file Comment by Fred Forester [16/May/06 10:17 AM] [ Permlink ] a patch and a new file Comment by Fred Forester [16/May/06 10:19 AM] [ Permlink ] Sorry about the duplicate files. the upload made it appear to me that one replaced the other. :) Comment by Si Chen [19/May/06 09:14 AM] [ Permlink ] This is my version of your AjaxPartyServices.java as AjaxPartyEvents.java Comment by Si Chen [19/May/06 09:16 AM] [ Permlink ] Hey everybody - this works! I looked at your code and would like to suggest - 1. AjaxPartyServices.java is really AjaxPartyEvents.java since you have written an Events servlet not a Service. I just changed it and uploaded it for you. 2. I think a lot of the Javascript in findparty.ftl should be moved into an ajax javascript file that could be shared everywhere, since they seem to be pretty standard? 3. Please clean up the formatting of AjaxPartyEvents.java. See http://ofbizwiki.go-integral.com/Wiki.jsp?page=FAQ27 Comment by Si Chen [19/May/06 09:38 AM] [ Permlink ] David and Andy - Can you make a specialized/ajax directory so we can put some ajax-related stuff in there, like this, that all the applications/ can use, but at the same time not mess with framework/? Comment by Fred Forester [19/May/06 09:42 AM] [ Permlink ] I agree 100% with all 3 points and had every intention of getting to 1 and 2. didn't know about 3 till just now :( I found out last night after loading 200,000 users that things got a little slow. a temporary fix was to require at least 5 characters in the lastname. I'm working on 2 other jira things now and can get to this on tuesday. Comment by Si Chen [19/May/06 11:21 AM] [ Permlink ] Great. Also I think it would be nice to change your AjaxPartyEvents.java to a more generic AjaxEvents.java and parametrize the entities and fields, etc., so that it could be used everywhere for auto-completion. We could then integrate it into the form-widget at a later date. Comment by Fred Forester [23/May/06 04:51 PM] [ Permlink ] Here are the new files for the ajax lastname control. I wasnt sure what was wrong with the formatting. maybe a critique of the formatting would give me a better idea of what's wrong. Fred -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3790) email password broken
email password broken - Key: OFBIZ-3790 URL: https://issues.apache.org/jira/browse/OFBIZ-3790 Project: OFBiz Issue Type: Bug Reporter: Si Chen Email password feature in party manager is broken. The log shows: 2010-05-28 09:24:58,193 (http-0.0.0.0-8543-14) [ ControlServlet.java:131:INFO ] [[[forgotPassword] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]] 2010-05-28 09:24:58,268 (http-0.0.0.0-8543-14) [ RequestHandler.java:597:INFO ] Ran Event [java:org.ofbiz.securityext.login.LoginEvents#forgotPassword] from [request], result is [success] 2010-05-28 09:24:58,275 (http-0.0.0.0-8543-14) [ RequestHandler.java:704:INFO ] Rendering View [forgotPassword], sessionId=6B88D615C7E15A7F8A3D1238F3447D27.jvm1 2010-05-28 09:24:58,278 (http-0.0.0.0-8543-14) [ ScreenRenderer.java:106:INFO ] render screen: forgotPassword, resource: component://common/widget/CommonScreens.xml 2010-05-28 09:24:58,325 (http-0.0.0.0-8543-14) [ PrimaryKeyFinder.java:142:INFO ] Returning null because found incomplete primary key in find: [GenericEntity:PartyNameView][partyId,null()] 2010-05-28 09:24:58,520 (http-0.0.0.0-8543-14) [ ServerHitBin.java:691:INFO ] Duplicate ServerHit was updated: [GenericEntity:ServerHit][contentId,partymgr.forgotPassword(java.lang.String)][createdStamp,2010-05-28 09:24:58.518(java.sql.Timestamp)][createdTxStamp,2010-05-28 09:24:58.516(java.sql.Timestamp)][hitStartDateTime,2010-05-28 09:24:58.193(java.sql.Timestamp)][hitTypeId,REQUEST(java.lang.String)][lastUpdatedStamp,2010-05-28 09:24:58.518(java.sql.Timestamp)][lastUpdatedTxStamp,2010-05-28 09:24:58.516(java.sql.Timestamp)][referrerUrl,https://ntc:8543/partymgr/control/main(java.lang.String)][requestUrl,https://ntc:8543/partymgr/control/forgotPassword(java.lang.String)][runningTimeMillis,322(java.lang.Long)][serverHostName,domU-12-31-39-00-0F-51(java.lang.String)][serverIpAddress,10.254.31.159(java.lang.String)][visitId,25693(java.lang.String)] 2010-05-28 09:24:58,521 (http-0.0.0.0-8543-14) [ ControlServlet.java:300:INFO ] [[[forgotPassword] Request Done- total:0.327,since last([forgotPassword] ...):0.327]] 2010-05-28 09:25:02,715 (http-0.0.0.0-8543-15) [ ControlServlet.java:131:INFO ] [[[forgotPassword] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]] 2010-05-28 09:25:03,074 (http-0.0.0.0-8543-15) [ UtilProperties.java:871:INFO ] ResourceBundle SecurityextUiLabels (en_US) created in 0.12s with 53 properties 2010-05-28 09:25:03,075 (http-0.0.0.0-8543-15) [ RequestHandler.java:597:INFO ] Ran Event [java:org.ofbiz.securityext.login.LoginEvents#forgotPassword] from [request], result is [error] 2010-05-28 09:25:03,110 (http-0.0.0.0-8543-15) [ RequestHandler.java:400:ERROR] Request forgotPassword caused an error with the following message: Problems with configuration; please contact customer service. 2010-05-28 09:25:03,111 (http-0.0.0.0-8543-15) [ RequestHandler.java:704:INFO ] Rendering View [forgotPassword], sessionId=6B88D615C7E15A7F8A3D1238F3447D27.jvm1 2010-05-28 09:25:03,116 (http-0.0.0.0-8543-15) [ ScreenRenderer.java:106:INFO ] render screen: forgotPassword, resource: component://common/widget/CommonScreens.xml 2010-05-28 09:25:03,141 (http-0.0.0.0-8543-15) [ PrimaryKeyFinder.java:142:INFO ] Returning null because found incomplete primary key in find: [GenericEntity:PartyNameView][partyId,null()] 2010-05-28 09:25:03,380 (http-0.0.0.0-8543-15) [ ServerHitBin.java:691:INFO ] Duplicate ServerHit was updated: [GenericEntity:ServerHit][contentId,partymgr.forgotPassword(java.lang.String)][createdStamp,2010-05-28 09:25:03.378(java.sql.Timestamp)][createdTxStamp,2010-05-28 09:25:03.376(java.sql.Timestamp)][hitStartDateTime,2010-05-28 09:25:02.715(java.sql.Timestamp)][hitTypeId,REQUEST(java.lang.String)][lastUpdatedStamp,2010-05-28 09:25:03.378(java.sql.Timestamp)][lastUpdatedTxStamp,2010-05-28 09:25:03.376(java.sql.Timestamp)][referrerUrl,https://ntc:8543/partymgr/control/forgotPassword(java.lang.String)][requestUrl,https://ntc:8543/partymgr/control/forgotPassword(java.lang.String)][runningTimeMillis,660(java.lang.Long)][serverHostName,domU-12-31-39-00-0F-51(java.lang.String)][serverIpAddress,10.254.31.159(java.lang.String)][visitId,25693(java.lang.String)] 2010-05-28 09:25:03,381 (http-0.0.0.0-8543-15) [ ControlServlet.java:300:INFO ] [[[forgotPassword] Request Done- total:0.665,since last([forgotPassword] ...):0.665]] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3790) email password broken
[ https://issues.apache.org/jira/browse/OFBIZ-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen updated OFBIZ-3790: --- Attachment: Screen shot 2010-05-28 at 9.25.05 AM.png email password broken - Key: OFBIZ-3790 URL: https://issues.apache.org/jira/browse/OFBIZ-3790 Project: OFBiz Issue Type: Bug Reporter: Si Chen Attachments: Screen shot 2010-05-28 at 9.25.05 AM.png Email password feature in party manager is broken. The log shows: 2010-05-28 09:24:58,193 (http-0.0.0.0-8543-14) [ ControlServlet.java:131:INFO ] [[[forgotPassword] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]] 2010-05-28 09:24:58,268 (http-0.0.0.0-8543-14) [ RequestHandler.java:597:INFO ] Ran Event [java:org.ofbiz.securityext.login.LoginEvents#forgotPassword] from [request], result is [success] 2010-05-28 09:24:58,275 (http-0.0.0.0-8543-14) [ RequestHandler.java:704:INFO ] Rendering View [forgotPassword], sessionId=6B88D615C7E15A7F8A3D1238F3447D27.jvm1 2010-05-28 09:24:58,278 (http-0.0.0.0-8543-14) [ ScreenRenderer.java:106:INFO ] render screen: forgotPassword, resource: component://common/widget/CommonScreens.xml 2010-05-28 09:24:58,325 (http-0.0.0.0-8543-14) [ PrimaryKeyFinder.java:142:INFO ] Returning null because found incomplete primary key in find: [GenericEntity:PartyNameView][partyId,null()] 2010-05-28 09:24:58,520 (http-0.0.0.0-8543-14) [ ServerHitBin.java:691:INFO ] Duplicate ServerHit was updated: [GenericEntity:ServerHit][contentId,partymgr.forgotPassword(java.lang.String)][createdStamp,2010-05-28 09:24:58.518(java.sql.Timestamp)][createdTxStamp,2010-05-28 09:24:58.516(java.sql.Timestamp)][hitStartDateTime,2010-05-28 09:24:58.193(java.sql.Timestamp)][hitTypeId,REQUEST(java.lang.String)][lastUpdatedStamp,2010-05-28 09:24:58.518(java.sql.Timestamp)][lastUpdatedTxStamp,2010-05-28 09:24:58.516(java.sql.Timestamp)][referrerUrl,https://ntc:8543/partymgr/control/main(java.lang.String)][requestUrl,https://ntc:8543/partymgr/control/forgotPassword(java.lang.String)][runningTimeMillis,322(java.lang.Long)][serverHostName,domU-12-31-39-00-0F-51(java.lang.String)][serverIpAddress,10.254.31.159(java.lang.String)][visitId,25693(java.lang.String)] 2010-05-28 09:24:58,521 (http-0.0.0.0-8543-14) [ ControlServlet.java:300:INFO ] [[[forgotPassword] Request Done- total:0.327,since last([forgotPassword] ...):0.327]] 2010-05-28 09:25:02,715 (http-0.0.0.0-8543-15) [ ControlServlet.java:131:INFO ] [[[forgotPassword] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]] 2010-05-28 09:25:03,074 (http-0.0.0.0-8543-15) [ UtilProperties.java:871:INFO ] ResourceBundle SecurityextUiLabels (en_US) created in 0.12s with 53 properties 2010-05-28 09:25:03,075 (http-0.0.0.0-8543-15) [ RequestHandler.java:597:INFO ] Ran Event [java:org.ofbiz.securityext.login.LoginEvents#forgotPassword] from [request], result is [error] 2010-05-28 09:25:03,110 (http-0.0.0.0-8543-15) [ RequestHandler.java:400:ERROR] Request forgotPassword caused an error with the following message: Problems with configuration; please contact customer service. 2010-05-28 09:25:03,111 (http-0.0.0.0-8543-15) [ RequestHandler.java:704:INFO ] Rendering View [forgotPassword], sessionId=6B88D615C7E15A7F8A3D1238F3447D27.jvm1 2010-05-28 09:25:03,116 (http-0.0.0.0-8543-15) [ ScreenRenderer.java:106:INFO ] render screen: forgotPassword, resource: component://common/widget/CommonScreens.xml 2010-05-28 09:25:03,141 (http-0.0.0.0-8543-15) [ PrimaryKeyFinder.java:142:INFO ] Returning null because found incomplete primary key in find: [GenericEntity:PartyNameView][partyId,null()] 2010-05-28 09:25:03,380 (http-0.0.0.0-8543-15) [ ServerHitBin.java:691:INFO ] Duplicate ServerHit was updated: [GenericEntity:ServerHit][contentId,partymgr.forgotPassword(java.lang.String)][createdStamp,2010-05-28 09:25:03.378(java.sql.Timestamp)][createdTxStamp,2010-05-28 09:25:03.376(java.sql.Timestamp)][hitStartDateTime,2010-05-28 09:25:02.715(java.sql.Timestamp)][hitTypeId,REQUEST(java.lang.String)][lastUpdatedStamp,2010-05-28 09:25:03.378(java.sql.Timestamp)][lastUpdatedTxStamp,2010-05-28 09:25:03.376(java.sql.Timestamp)][referrerUrl,https://ntc:8543/partymgr/control/forgotPassword(java.lang.String)][requestUrl,https://ntc:8543/partymgr/control/forgotPassword(java.lang.String)][runningTimeMillis,660(java.lang.Long)][serverHostName,domU-12-31-39-00-0F-51(java.lang.String)][serverIpAddress,10.254.31.159(java.lang.String)][visitId,25693(java.lang.String)] 2010-05-28 09:25:03,381 (http-0.0.0.0-8543-15) [ ControlServlet.java:300:INFO ] [[[forgotPassword] Request Done- total:0.665,since last([forgotPassword] ...):0.665]] -- This message is automatically generated
[jira] Commented: (OFBIZ-3420) ups rate estimate will not work from non-US warehouses
[ https://issues.apache.org/jira/browse/OFBIZ-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12803372#action_12803372 ] Si Chen commented on OFBIZ-3420: Thanks. Sorry I've been really busy lately, but I've got a few more goodies coming your way :) ups rate estimate will not work from non-US warehouses -- Key: OFBIZ-3420 URL: https://issues.apache.org/jira/browse/OFBIZ-3420 Project: OFBiz Issue Type: Bug Reporter: Si Chen Assignee: Si Chen Fix For: Release Branch 9.04, SVN trunk Attachments: ups.patch upsRateEstimate will not work from non-US warehouses because it's not passing the country code of the ship-from address -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3420) ups rate estimate will not work from non-US warehouses
ups rate estimate will not work from non-US warehouses -- Key: OFBIZ-3420 URL: https://issues.apache.org/jira/browse/OFBIZ-3420 Project: OFBiz Issue Type: Bug Reporter: Si Chen Attachments: ups.patch upsRateEstimate will not work from non-US warehouses because it's not passing the country code of the ship-from address -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3420) ups rate estimate will not work from non-US warehouses
[ https://issues.apache.org/jira/browse/OFBIZ-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen updated OFBIZ-3420: --- Attachment: ups.patch ups rate estimate will not work from non-US warehouses -- Key: OFBIZ-3420 URL: https://issues.apache.org/jira/browse/OFBIZ-3420 Project: OFBiz Issue Type: Bug Reporter: Si Chen Attachments: ups.patch upsRateEstimate will not work from non-US warehouses because it's not passing the country code of the ship-from address -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3299) wsdl generated is not correct for Apache Synapse and Visual Studio
wsdl generated is not correct for Apache Synapse and Visual Studio -- Key: OFBIZ-3299 URL: https://issues.apache.org/jira/browse/OFBIZ-3299 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 9.04, SVN trunk Reporter: Si Chen Fix For: Release Branch 4.0, Release Branch 9.04, SVN trunk Attachments: service-wsdl.patch The WSDL generated by ModelService is not correct for Visual Studio or Apache Synapse, causing Web services not to work properly. The soap:action tag is missing the URI for soapAction and needs to specify that this style is rpc for RPC/literal. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3299) wsdl generated is not correct for Apache Synapse and Visual Studio
[ https://issues.apache.org/jira/browse/OFBIZ-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen updated OFBIZ-3299: --- Attachment: service-wsdl.patch wsdl generated is not correct for Apache Synapse and Visual Studio -- Key: OFBIZ-3299 URL: https://issues.apache.org/jira/browse/OFBIZ-3299 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 9.04, SVN trunk Reporter: Si Chen Fix For: Release Branch 4.0, Release Branch 9.04, SVN trunk Attachments: service-wsdl.patch The WSDL generated by ModelService is not correct for Visual Studio or Apache Synapse, causing Web services not to work properly. The soap:action tag is missing the URI for soapAction and needs to specify that this style is rpc for RPC/literal. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3300) soap wsdl and action should be consistent
soap wsdl and action should be consistent - Key: OFBIZ-3300 URL: https://issues.apache.org/jira/browse/OFBIZ-3300 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 9.04, SVN trunk Reporter: Si Chen Fix For: Release Branch 4.0, Release Branch 9.04, SVN trunk Currently, the WSDL for a soap service is obtained by http://localhost:8080/webtools/control/SOAPService/serviceName?wsdl, but the service is called at URL http://localhost:8080/webtools/control/SOAPService/, and the service name is inferred from the soap message, rather than from the URL. It is a trivial fix for the soap event handler to get the service name from the URL as well, so that you can call the service at http://localhost:8080/webtools/control/SOAPService/serviceName Please let me know if you agree, and I will make you a patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3126) quantities incorrect when canceling partially shipped items
quantities incorrect when canceling partially shipped items Key: OFBIZ-3126 URL: https://issues.apache.org/jira/browse/OFBIZ-3126 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Release Branch 9.04, SVN trunk Reporter: Si Chen Fix For: Release Branch 9.04, SVN trunk if you create a sales order for quantity 5 of a product, and then partially pack and ship 2 of this item, then go back and cancel all the item, the quantity canceled its 5 but should be 3 because 2 had already been shipped. See enclosed screenshot. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3126) quantities incorrect when canceling partially shipped items
[ https://issues.apache.org/jira/browse/OFBIZ-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen updated OFBIZ-3126: --- Attachment: Picture 9.png quantities incorrect when canceling partially shipped items Key: OFBIZ-3126 URL: https://issues.apache.org/jira/browse/OFBIZ-3126 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Release Branch 9.04, SVN trunk Reporter: Si Chen Fix For: Release Branch 9.04, SVN trunk Attachments: Picture 9.png if you create a sales order for quantity 5 of a product, and then partially pack and ship 2 of this item, then go back and cancel all the item, the quantity canceled its 5 but should be 3 because 2 had already been shipped. See enclosed screenshot. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2729) special security should be required for setting passwords
[ https://issues.apache.org/jira/browse/OFBIZ-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12743473#action_12743473 ] Si Chen commented on OFBIZ-2729: Jacques, Why has this been reclassified as a subtask instead of bug? special security should be required for setting passwords -- Key: OFBIZ-2729 URL: https://issues.apache.org/jira/browse/OFBIZ-2729 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Release Branch 4.0, Release Branch 9.04, SVN trunk Reporter: Si Chen This issue was first brought up here: https://sourceforge.net/forum/message.php?msg_id=7496877 Basically, any user with PARTYMGR_CREATE/UPDATE permissions can set the password of another user. This creates opportunity for Malfeasance. For example, a customer service rep could set the password of the admin user. A simple solution would be to create a new security permission PARTYMGR_PASSWD and require that permission for setting or changing password of a different user, instead of using PARTYMGR_UPDATE. PARTYMGR_PASSWD could then be associated with the administrative user. An alternative is to use the SECURITY_UPDATE permission instead of PARTYMGR_UPDATE or a new PARTYMGR_PASSWD permission. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2729) special security should be required for setting passwords
[ https://issues.apache.org/jira/browse/OFBIZ-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733292#action_12733292 ] Si Chen commented on OFBIZ-2729: A couple of other security enhancements which I think should be made: 1. the user's password should be checked, even if he is changing his own password 2. the admin user's password should be checked as well before he is allowed to change any passwords Otherwise, there is the risk of a low-tech coffee break attack: the user or the admin user steps out for a five-minute coffee break, and somebody comes in, sits down at his terminal, and starts changing passwords special security should be required for setting passwords -- Key: OFBIZ-2729 URL: https://issues.apache.org/jira/browse/OFBIZ-2729 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 9.04, SVN trunk Reporter: Si Chen This issue was first brought up here: https://sourceforge.net/forum/message.php?msg_id=7496877 Basically, any user with PARTYMGR_CREATE/UPDATE permissions can set the password of another user. This creates opportunity for Malfeasance. For example, a customer service rep could set the password of the admin user. A simple solution would be to create a new security permission PARTYMGR_PASSWD and require that permission for setting or changing password of a different user, instead of using PARTYMGR_UPDATE. PARTYMGR_PASSWD could then be associated with the administrative user. An alternative is to use the SECURITY_UPDATE permission instead of PARTYMGR_UPDATE or a new PARTYMGR_PASSWD permission. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2729) special security should be required for setting passwords
[ https://issues.apache.org/jira/browse/OFBIZ-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12731548#action_12731548 ] Si Chen commented on OFBIZ-2729: Somebody can use a CSR's credentials to try to reset a password, such as for an administrative user, either by a scripted attack or URL hacking. Or, if that part of the system is made available to Web services, that's another way to access the backend of the system without having to use the form in your party manager. For how a simple fix is required to address this issue, it would make sense to do it to prevent this kind of risk. special security should be required for setting passwords -- Key: OFBIZ-2729 URL: https://issues.apache.org/jira/browse/OFBIZ-2729 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 9.04, SVN trunk Reporter: Si Chen This issue was first brought up here: https://sourceforge.net/forum/message.php?msg_id=7496877 Basically, any user with PARTYMGR_CREATE/UPDATE permissions can set the password of another user. This creates opportunity for Malfeasance. For example, a customer service rep could set the password of the admin user. A simple solution would be to create a new security permission PARTYMGR_PASSWD and require that permission for setting or changing password of a different user, instead of using PARTYMGR_UPDATE. PARTYMGR_PASSWD could then be associated with the administrative user. An alternative is to use the SECURITY_UPDATE permission instead of PARTYMGR_UPDATE or a new PARTYMGR_PASSWD permission. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2729) special security should be required for setting passwords
special security should be required for setting passwords -- Key: OFBIZ-2729 URL: https://issues.apache.org/jira/browse/OFBIZ-2729 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 9.04, SVN trunk Reporter: Si Chen This issue was first brought up here: https://sourceforge.net/forum/message.php?msg_id=7496877 Basically, any user with PARTYMGR_CREATE/UPDATE permissions can set the password of another user. This creates opportunity for Malfeasance. For example, a customer service rep could set the password of the admin user. A simple solution would be to create a new security permission PARTYMGR_PASSWD and require that permission for setting or changing password of a different user, instead of using PARTYMGR_UPDATE. PARTYMGR_PASSWD could then be associated with the administrative user. An alternative is to use the SECURITY_UPDATE permission instead of PARTYMGR_UPDATE or a new PARTYMGR_PASSWD permission. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: any plans for release soon?
So Will this be actively maintained and become a release with version numbers? From: Jacques Le Roux jacques.le.r...@les7arts.com To: dev@ofbiz.apache.org Sent: Friday, April 17, 2009 10:11:37 AM Subject: Re: any plans for release soon? From: Tim Ruppert tim.rupp...@hotwaxmedia.com The branch was all over the mailing lists last night - surprised everyone is surprised :) You're right about getting the goods up on the main site - but I honestly can't help you there. Yes, this can't happen by magic, you knoowww... I'll put in a patch to have that download button take them to http://build.ofbiz.org instead of doing a straight download - and I'll work on some new copy there. As for how you handle this stuff, make your changes in the trunk - and apply your patch to the branch - that's it. Exactly Jacques Cheers, Tim -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801..649.6595 - Adam Heath doo...@brainfood.com wrote: Tim Ruppert wrote: Happened last night ... It did? I don't see mention on ofbiz.apache.org. Additionally, the Download Ofbiz big huge button should not really link to a snapshot build, but a nicer page that describes what versions of ofbiz can be downloaded.. Hmm, and I have some things that really need to be in this release. I guess I need to look up how to do that. Namely: * a webslinger update(the classloader it uses is broken, it doesn't always compile things). * fixing WebslingerContextMapper, with the recent broken 'fix' that removed WebAppDispatcher. * debian packaging(I really want this to be part of the next release). I've got almost all this ready to go, should be available in a few hours.
any plans for release soon?
Do you have any plans for making a release in the next few months?
[jira] Closed: (OFBIZ-1266) EntityOperator.IN will crash on some databases with empty list
[
https://issues.apache.org/jira/browse/OFBIZ-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Si Chen closed OFBIZ-1266.
--
Resolution: Fixed
EntityOperator.IN will crash on some databases with empty list
--
Key: OFBIZ-1266
URL: https://issues.apache.org/jira/browse/OFBIZ-1266
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Environment: derby, unkown other databases
Reporter: Leon Torres
Assignee: Adam Heath
Attachments: 1266.patch
If you use the following entity exr,
new EntityExpr(orderId, EntityOperator.IN, new ArrayList());
It will crash on at least Derby. The reason is that this condition evaluates
to the keyword FALSE, which apparently is not supported on Derby. The
problem code is in EntityComparisonOperator.java:
// if this is an IN operator and the rhs Object isEmpty, add FALSE
instead of the normal SQL
if (this.idInt == EntityOperator.ID_IN UtilValidate.isEmpty(rhs)) {
sql.append(FALSE);
return;
}
Perhaps this is over engineered? What happens if we just leave this out and
let it generate an IN () SQL?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1266) EntityOperator.IN will crash on some databases with empty list
[
https://issues.apache.org/jira/browse/OFBIZ-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12681845#action_12681845
]
Si Chen commented on OFBIZ-1266:
would anybody be opposed if I committed Jeremy's patch?
EntityOperator.IN will crash on some databases with empty list
--
Key: OFBIZ-1266
URL: https://issues.apache.org/jira/browse/OFBIZ-1266
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Environment: derby, unkown other databases
Reporter: Leon Torres
Assignee: Adam Heath
Attachments: 1266.patch
If you use the following entity exr,
new EntityExpr(orderId, EntityOperator.IN, new ArrayList());
It will crash on at least Derby. The reason is that this condition evaluates
to the keyword FALSE, which apparently is not supported on Derby. The
problem code is in EntityComparisonOperator.java:
// if this is an IN operator and the rhs Object isEmpty, add FALSE
instead of the normal SQL
if (this.idInt == EntityOperator.ID_IN UtilValidate.isEmpty(rhs)) {
sql.append(FALSE);
return;
}
Perhaps this is over engineered? What happens if we just leave this out and
let it generate an IN () SQL?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
We're Hiring :)
Hi there, Just wanted to let everybody knows that our company is looking for more developers who are familiar with the ofbiz and other open-source Java frameworks. You'll have a chance to work with ofbiz, Spring, hibernate, Jasper, Kettle, Pentaho, and GWT for both opentaps and our client projects. For an example of what we've been working on, see http://opensourcestrategies.blogspot.com/ We are based in Los Angeles but can work with developers from all the world. If you are interested, please e-mail me at sichen AT opensourcestrategies DOT com Si
[jira] Commented: (OFBIZ-1607) let the ofbiz work with db2
[ https://issues.apache.org/jira/browse/OFBIZ-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12623842#action_12623842 ] Si Chen commented on OFBIZ-1607: Weizhan, I spent some time looking at this, and I've posted my comments here: http://www.opentaps.org/docs/index.php/Database_Tips#DB2_Tips You are correct--that wiki page does not solve the problem, nor do the other mailing list posts I've seen. There is no solution per se, but there are a few workarounds. let the ofbiz work with db2 --- Key: OFBIZ-1607 URL: https://issues.apache.org/jira/browse/OFBIZ-1607 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Environment: db2 v9.1.0.356 Reporter: WeizhanGuo Fix For: SVN trunk Attachments: contentForm.diff, entityFordb2.diff Original Estimate: 0.67h Remaining Estimate: 0.67h create the db2filedtype file ; change the seed/demo data to fixed the db2 requirement; change some relation define if needed; others -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1915) Improving request redirects
[ https://issues.apache.org/jira/browse/OFBIZ-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen closed OFBIZ-1915. -- Resolution: Fixed Improving request redirects --- Key: OFBIZ-1915 URL: https://issues.apache.org/jira/browse/OFBIZ-1915 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Wickersheimer Jeremy Assignee: Si Chen Priority: Minor Fix For: SVN trunk Attachments: redirect.patch There are some issues with request-redirect and request-redirect-noparam, the former does not work very well with service multi and most of the time we do not need all the parameters to be in the redirected query, the later is a bit too radical. This is something that i have been thinking for a while when running into these two kind of issues: - when i want to redirect to a viewXXX page, i just want to have the XXXId in my redirect - after i create an entity i want to redirect to the viewXXX page with the XXXId visible in the query This patch i how we dealt with those in Opentaps, so maybe you are interested in applying to Ofbiz as well. The end result is nicer and more user friendly redirects. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1915) Improving request redirects
[ https://issues.apache.org/jira/browse/OFBIZ-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622378#action_12622378 ] Si Chen commented on OFBIZ-1915: do you want me to put some more comments into the xsd file then? Improving request redirects --- Key: OFBIZ-1915 URL: https://issues.apache.org/jira/browse/OFBIZ-1915 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Wickersheimer Jeremy Assignee: Si Chen Priority: Minor Fix For: SVN trunk Attachments: redirect.patch There are some issues with request-redirect and request-redirect-noparam, the former does not work very well with service multi and most of the time we do not need all the parameters to be in the redirected query, the later is a bit too radical. This is something that i have been thinking for a while when running into these two kind of issues: - when i want to redirect to a viewXXX page, i just want to have the XXXId in my redirect - after i create an entity i want to redirect to the viewXXX page with the XXXId visible in the query This patch i how we dealt with those in Opentaps, so maybe you are interested in applying to Ofbiz as well. The end result is nicer and more user friendly redirects. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1915) Improving request redirects
[ https://issues.apache.org/jira/browse/OFBIZ-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen reassigned OFBIZ-1915: -- Assignee: Si Chen Improving request redirects --- Key: OFBIZ-1915 URL: https://issues.apache.org/jira/browse/OFBIZ-1915 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Wickersheimer Jeremy Assignee: Si Chen Priority: Minor Fix For: SVN trunk Attachments: redirect.patch There are some issues with request-redirect and request-redirect-noparam, the former does not work very well with service multi and most of the time we do not need all the parameters to be in the redirected query, the later is a bit too radical. This is something that i have been thinking for a while when running into these two kind of issues: - when i want to redirect to a viewXXX page, i just want to have the XXXId in my redirect - after i create an entity i want to redirect to the viewXXX page with the XXXId visible in the query This patch i how we dealt with those in Opentaps, so maybe you are interested in applying to Ofbiz as well. The end result is nicer and more user friendly redirects. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1915) Improving request redirects
[ https://issues.apache.org/jira/browse/OFBIZ-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12621498#action_12621498 ] Si Chen commented on OFBIZ-1915: I will commit this if nobody has any comments Improving request redirects --- Key: OFBIZ-1915 URL: https://issues.apache.org/jira/browse/OFBIZ-1915 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Wickersheimer Jeremy Assignee: Si Chen Priority: Minor Fix For: SVN trunk Attachments: redirect.patch There are some issues with request-redirect and request-redirect-noparam, the former does not work very well with service multi and most of the time we do not need all the parameters to be in the redirected query, the later is a bit too radical. This is something that i have been thinking for a while when running into these two kind of issues: - when i want to redirect to a viewXXX page, i just want to have the XXXId in my redirect - after i create an entity i want to redirect to the viewXXX page with the XXXId visible in the query This patch i how we dealt with those in Opentaps, so maybe you are interested in applying to Ofbiz as well. The end result is nicer and more user friendly redirects. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1847) Enhancing DropDown widget with Ajax Autocompletion feature
[ https://issues.apache.org/jira/browse/OFBIZ-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12618767#action_12618767 ] Si Chen commented on OFBIZ-1847: is this where I could see how this works? https://demo.hotwaxmedia.com/example/control/authview/findExampleAjax Enhancing DropDown widget with Ajax Autocompletion feature -- Key: OFBIZ-1847 URL: https://issues.apache.org/jira/browse/OFBIZ-1847 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Mridul Pathak Assignee: Anil K Patel Fix For: SVN trunk Attachments: AjaxAutoCompleteDropDown.patch, AjaxAutoCompleteDropDown.patch, AjaxAutoCompleteDropDown_Improvements.patch, AjaxAutoCompleteDropDown_Improvements.patch, AjaxAutoCompleteDropDown_Improvements.patch, AjaxAutoCompleteDropDown_Improvements.patch Enhance DropDown Field of Form Widget to use Autocompleter. After this enhancement a developer will have two options: Either use a traditional dropdown or an auto-completed text field instead of a dropdown. Please refer to the following document for more details: http://docs.ofbiz.org/display/OFBIZ/Enhancing+DropDown+Widget+with+Ajax+Autocompletion+Feature -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-811) Authentication using LDAP
[ https://issues.apache.org/jira/browse/OFBIZ-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12606838#action_12606838 ] Si Chen commented on OFBIZ-811: --- is there any documentation for this? Authentication using LDAP - Key: OFBIZ-811 URL: https://issues.apache.org/jira/browse/OFBIZ-811 Project: OFBiz Issue Type: New Feature Components: framework Environment: all Reporter: Mohamed Amine AZZI Assignee: Adrian Crum Priority: Trivial Attachments: ldap_authentication.patch, ldap_authentication.patch, LoginServices.java, LoginServices.java.diff, security.properties.diff this feature, would enable Ofbiz users to authenticate their users using an LDAP. I developed that change in response to a customer request who wanted his employees to use the same passwords they use when openning a windows session. the solution was to recreate the same usernames in the Party manager with an unused password. and redirect the authentication to the LDAP when needed. The choice is made in the security.properties file. all parameters needed to connect to the LDAP are there also. After authentication all authorizations are taken out from the Party manager. This would give the same feature used by SharePoint, which is called cross privileges the change is minor as you would see, but very helpfull for people needing the same feature. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1826) Allow EntityListIterator to be created from JDBC ResultSet
Allow EntityListIterator to be created from JDBC ResultSet -- Key: OFBIZ-1826 URL: https://issues.apache.org/jira/browse/OFBIZ-1826 Project: OFBiz Issue Type: Bug Components: framework Reporter: Si Chen Priority: Minor EntitylistIterator can only be constructed from a SQLProcessor right now, but in fact, it does not really use the SQLProcessor except to .close(). I have created a new constructor for the EntityListIterator which allows it to be created from a JDBC ResultSet. When it comes to closing the list iterator, the behavior is the same as before, if there is a SQLProcessor. Otherwise, it will call the ResultSet's close method. This would not affect anybody who is already using the delegator, but it would make it more flexible for people who are not using the delegator. Please take a look at this. If nobody opposes it, I will commit it next week -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1826) Allow EntityListIterator to be created from JDBC ResultSet
[ https://issues.apache.org/jira/browse/OFBIZ-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen updated OFBIZ-1826: --- Attachment: ofbiz-1826.patch Allow EntityListIterator to be created from JDBC ResultSet -- Key: OFBIZ-1826 URL: https://issues.apache.org/jira/browse/OFBIZ-1826 Project: OFBiz Issue Type: Bug Components: framework Reporter: Si Chen Priority: Minor Attachments: ofbiz-1826.patch EntitylistIterator can only be constructed from a SQLProcessor right now, but in fact, it does not really use the SQLProcessor except to .close(). I have created a new constructor for the EntityListIterator which allows it to be created from a JDBC ResultSet. When it comes to closing the list iterator, the behavior is the same as before, if there is a SQLProcessor. Otherwise, it will call the ResultSet's close method. This would not affect anybody who is already using the delegator, but it would make it more flexible for people who are not using the delegator. Please take a look at this. If nobody opposes it, I will commit it next week -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1826) Allow EntityListIterator to be created from JDBC ResultSet
[ https://issues.apache.org/jira/browse/OFBIZ-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12603236#action_12603236 ] Si Chen commented on OFBIZ-1826: by the way, I have apply this patch and rerun all the entity unit tests, and they passed Allow EntityListIterator to be created from JDBC ResultSet -- Key: OFBIZ-1826 URL: https://issues.apache.org/jira/browse/OFBIZ-1826 Project: OFBiz Issue Type: Bug Components: framework Reporter: Si Chen Priority: Minor Attachments: ofbiz-1826.patch EntitylistIterator can only be constructed from a SQLProcessor right now, but in fact, it does not really use the SQLProcessor except to .close(). I have created a new constructor for the EntityListIterator which allows it to be created from a JDBC ResultSet. When it comes to closing the list iterator, the behavior is the same as before, if there is a SQLProcessor. Otherwise, it will call the ResultSet's close method. This would not affect anybody who is already using the delegator, but it would make it more flexible for people who are not using the delegator. Please take a look at this. If nobody opposes it, I will commit it next week -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1806) automatically set countyGeoId from postalCode and countryGeoId?
[ https://issues.apache.org/jira/browse/OFBIZ-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen updated OFBIZ-1806: --- Attachment: orderview.PNG screenshot of order in ZIP code 84057 but no Utah county sales tax was assessed automatically set countyGeoId from postalCode and countryGeoId? --- Key: OFBIZ-1806 URL: https://issues.apache.org/jira/browse/OFBIZ-1806 Project: OFBiz Issue Type: Bug Reporter: Si Chen Attachments: orderview.PNG Is there anything which automatically sets countyGeoId from postal code + countryGeoId? If not, how does one calculate county level taxes? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1806) automatically set countyGeoId from postalCode and countryGeoId?
[
https://issues.apache.org/jira/browse/OFBIZ-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12600856#action_12600856
]
Si Chen commented on OFBIZ-1806:
I'm sorry David, but this does not work for me. I could not access the trunk
demo at http://demo.hotwaxmedia.com/ecommerce/control/main but I was able to
use your release 4.0 demo, and since this code is really not changed, I think
it should be more or less the same. I loaded the additional setup for ZIP code
84057 and for the Utah county sales tax in Web tools, and then I created an
order for a new customer in the 84057 zip code. However, as you can see from
the screenshot, no Utah county sales tax was charged. You can also look at
this order here:
https://demo40.hotwaxmedia.com/ordermgr/control/orderview?orderId=WS1
Does anybody get a Utah county sales tax added to orders for DemoCustomer?
Also, looking at the code, TaxAuthorityServices.java seems to be calling:
geoIdSet = GeoWorker.expandGeoRegionDeep(geoIdSet, delegator);
which in turn:
Set geoIdSetTemp = FastSet.newInstance();
Iterator geoIdIter = geoIdSet.iterator();
while (geoIdIter.hasNext()) {
String curGeoId = (String) geoIdIter.next();
List geoAssocList = delegator.findByAndCache(GeoAssoc,
UtilMisc.toMap(geoIdTo, curGeoId, geoAssocTypeId, REGIONS));
Iterator geoAssocIter = geoAssocList.iterator();
while (geoAssocIter.hasNext()) {
GenericValue geoAssoc = (GenericValue) geoAssocIter.next();
geoIdSetTemp.add(geoAssoc.get(geoId));
}
}
geoIdSetTemp = expandGeoRegionDeep(geoIdSetTemp, delegator);
I can see that it is traversing down GeoAssoc recursively, but I don't see
anything that looks for the ST_ZIPCO format here or anywhere else. If you
could just enlighten me as to where this code might be, I'd be happy to go root
around for it.
automatically set countyGeoId from postalCode and countryGeoId?
---
Key: OFBIZ-1806
URL: https://issues.apache.org/jira/browse/OFBIZ-1806
Project: OFBiz
Issue Type: Bug
Reporter: Si Chen
Attachments: orderview.PNG
Is there anything which automatically sets countyGeoId from postal code +
countryGeoId? If not, how does one calculate county level taxes?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1806) automatically set countyGeoId from postalCode and countryGeoId?
[ https://issues.apache.org/jira/browse/OFBIZ-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12600470#action_12600470 ] Si Chen commented on OFBIZ-1806: TaxAuthorityServices will consider countyGeoId in tax calculations, and there is the Geo rollup you describe. However, I can find no code for populating countyGeoId from postal code or anything else, unless users are supposed to enter their county? automatically set countyGeoId from postalCode and countryGeoId? --- Key: OFBIZ-1806 URL: https://issues.apache.org/jira/browse/OFBIZ-1806 Project: OFBiz Issue Type: Bug Reporter: Si Chen Is there anything which automatically sets countyGeoId from postal code + countryGeoId? If not, how does one calculate county level taxes? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1806) automatically set countyGeoId from postalCode and countryGeoId?
automatically set countyGeoId from postalCode and countryGeoId? --- Key: OFBIZ-1806 URL: https://issues.apache.org/jira/browse/OFBIZ-1806 Project: OFBiz Issue Type: Bug Reporter: Si Chen Is there anything which automatically sets countyGeoId from postal code + countryGeoId? If not, how does one calculate county level taxes? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-811) Authentication using LDAP
[ https://issues.apache.org/jira/browse/OFBIZ-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen reassigned OFBIZ-811: - Assignee: (was: Si Chen) Authentication using LDAP - Key: OFBIZ-811 URL: https://issues.apache.org/jira/browse/OFBIZ-811 Project: OFBiz Issue Type: New Feature Components: framework Environment: all Reporter: Mohamed Amine AZZI Priority: Trivial Attachments: ldap_authentication.patch, ldap_properties.patch, LoginServices.java, LoginServices.java.diff, security.properties.diff this feature, would enable Ofbiz users to authenticate their users using an LDAP. I developed that change in response to a customer request who wanted his employees to use the same passwords they use when openning a windows session. the solution was to recreate the same usernames in the Party manager with an unused password. and redirect the authentication to the LDAP when needed. The choice is made in the security.properties file. all parameters needed to connect to the LDAP are there also. After authentication all authorizations are taken out from the Party manager. This would give the same feature used by SharePoint, which is called cross privileges the change is minor as you would see, but very helpfull for people needing the same feature. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1795) OrderServices checkDigitalFulfillment should not invoice items which have not been fulfilled
OrderServices checkDigitalFulfillment should not invoice items which have not been fulfilled Key: OFBIZ-1795 URL: https://issues.apache.org/jira/browse/OFBIZ-1795 Project: OFBiz Issue Type: Bug Components: order Reporter: Si Chen I just looked at OrderServices.checkDigitalItemFulfillment and saw that it created the invoice first for digital items before trying to fulfill them. Thus, if there's a problem with the fulfillment, the customer has already been invoiced for it. This seems to be backwards of how it should be, which is that the items should be run through fulfillment first, and if the fulfillment is successful, then it's passed to the list of items to be invoiced. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1766) problem with creating a shipment after a canceled shipment on the Input status
[ https://issues.apache.org/jira/browse/OFBIZ-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12594613#action_12594613 ] Si Chen commented on OFBIZ-1766: Jacopo, that means that you would not be able to cancel a shipment even in the input state, which is the initial state of a shipment. This means that you would never be to cancel any shipments. The problem is that item issuance is created when the shipment is first created and in the input state, when order items are assigned to a shipment, but item issuance is the only way right now to record items which have been placed onto a shipment. problem with creating a shipment after a canceled shipment on the Input status -- Key: OFBIZ-1766 URL: https://issues.apache.org/jira/browse/OFBIZ-1766 Project: OFBiz Issue Type: Bug Components: order, product Affects Versions: SVN trunk Environment: Windows, Linux Reporter: Fabien Carrion After a shipment in the input status has been canceled, the creation of a new shipment cannot be done successfully because the OISGIR and ItemIssuance are not cleared out. I created an order on https://demo.hotwaxmedia.com/ordermgr/control/changeOrderStatus/orderview?statusId=ORDER_APPROVEDsetItemStatus=YorderId=WSCO10002 called shippingCancelled. I created the shipment in input state and then cancelled it. If we look in the database, there is no oisgir for the shipment, and the itemissuance still exists. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1766) problem with creating a shipment after a canceled shipment on the Input status
[ https://issues.apache.org/jira/browse/OFBIZ-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12594619#action_12594619 ] Si Chen commented on OFBIZ-1766: where is the shipment plan screen, and what entity does it affect? problem with creating a shipment after a canceled shipment on the Input status -- Key: OFBIZ-1766 URL: https://issues.apache.org/jira/browse/OFBIZ-1766 Project: OFBiz Issue Type: Bug Components: order, product Affects Versions: SVN trunk Environment: Windows, Linux Reporter: Fabien Carrion After a shipment in the input status has been canceled, the creation of a new shipment cannot be done successfully because the OISGIR and ItemIssuance are not cleared out. I created an order on https://demo.hotwaxmedia.com/ordermgr/control/changeOrderStatus/orderview?statusId=ORDER_APPROVEDsetItemStatus=YorderId=WSCO10002 called shippingCancelled. I created the shipment in input state and then cancelled it. If we look in the database, there is no oisgir for the shipment, and the itemissuance still exists. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1021) Ofbiz hang on startup ModelReader Patch
[ https://issues.apache.org/jira/browse/OFBIZ-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12572314#action_12572314 ] Si Chen commented on OFBIZ-1021: This seems fairly straightforward and I will commit a version of it which is cleaned up. Ofbiz hang on startup ModelReader Patch --- Key: OFBIZ-1021 URL: https://issues.apache.org/jira/browse/OFBIZ-1021 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: WinXP Reporter: Karl Eilebrecht Assignee: Si Chen Priority: Minor Fix For: SVN trunk Attachments: patch9655.patch This issue is part of Key-Work Ofbiz Contribution Proposal. http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal Based on Release: 540035 Includes: - Required: - Recommended: - Classes: ModelReader.java Description: Patch for ModelReader class to catch a RuntimeException to avoid Ofbiz hang on startup when reading bad model data. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1021) Ofbiz hang on startup ModelReader Patch
[ https://issues.apache.org/jira/browse/OFBIZ-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen reassigned OFBIZ-1021: -- Assignee: Si Chen Ofbiz hang on startup ModelReader Patch --- Key: OFBIZ-1021 URL: https://issues.apache.org/jira/browse/OFBIZ-1021 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: WinXP Reporter: Karl Eilebrecht Assignee: Si Chen Priority: Minor Fix For: SVN trunk Attachments: patch9655.patch This issue is part of Key-Work Ofbiz Contribution Proposal. http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal Based on Release: 540035 Includes: - Required: - Recommended: - Classes: ModelReader.java Description: Patch for ModelReader class to catch a RuntimeException to avoid Ofbiz hang on startup when reading bad model data. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1029) TransactionUtil Refactoring
[ https://issues.apache.org/jira/browse/OFBIZ-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen reassigned OFBIZ-1029: -- Assignee: Si Chen TransactionUtil Refactoring --- Key: OFBIZ-1029 URL: https://issues.apache.org/jira/browse/OFBIZ-1029 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Environment: Win XP Reporter: Karl Eilebrecht Assignee: Si Chen Priority: Minor Fix For: SVN trunk Attachments: OfbizTransactionHandlingEn.pdf, patch9671.patch This issue is part of Key-Work Ofbiz Contribution Proposal. http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal Based on Release: 540035 Includes: - Required: JIRA-1016 Recommended: Classes: TransactionUtil.java, OfbizTransactionState.java, DebugXaResource.java, TxDelegate.java, CommonServices.java Description: Refactoring of TransactionUtil and helper for wrapping single operations in a new transaction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1029) TransactionUtil Refactoring
[ https://issues.apache.org/jira/browse/OFBIZ-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12572316#action_12572316 ] Si Chen commented on OFBIZ-1029: Has anybody looked at this? I think this would be a good feature. TransactionUtil Refactoring --- Key: OFBIZ-1029 URL: https://issues.apache.org/jira/browse/OFBIZ-1029 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Environment: Win XP Reporter: Karl Eilebrecht Assignee: Si Chen Priority: Minor Fix For: SVN trunk Attachments: OfbizTransactionHandlingEn.pdf, patch9671.patch This issue is part of Key-Work Ofbiz Contribution Proposal. http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal Based on Release: 540035 Includes: - Required: JIRA-1016 Recommended: Classes: TransactionUtil.java, OfbizTransactionState.java, DebugXaResource.java, TxDelegate.java, CommonServices.java Description: Refactoring of TransactionUtil and helper for wrapping single operations in a new transaction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1016) Tunnel-Exceptions simplification
[ https://issues.apache.org/jira/browse/OFBIZ-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12572317#action_12572317 ] Si Chen commented on OFBIZ-1016: I was interested in OFBIZ-1029 which depends on this. This seems just to be a few new classes. Tunnel-Exceptions simplification Key: OFBIZ-1016 URL: https://issues.apache.org/jira/browse/OFBIZ-1016 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Environment: WinXP Reporter: Karl Eilebrecht Assignee: Si Chen Priority: Minor Fix For: SVN trunk Attachments: patch9648.patch This issue is part of Key-Work Ofbiz Contribution Proposal. http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal Based on Release: 540035 Includes: - Required: - Recommended: - Classes: WrappingException.java, WrappingRuntimeException, WrappingGenericEntityException Description: These classes were introduced to have a standard way of exception tunneling. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1016) Tunnel-Exceptions simplification
[ https://issues.apache.org/jira/browse/OFBIZ-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen reassigned OFBIZ-1016: -- Assignee: Si Chen Tunnel-Exceptions simplification Key: OFBIZ-1016 URL: https://issues.apache.org/jira/browse/OFBIZ-1016 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Environment: WinXP Reporter: Karl Eilebrecht Assignee: Si Chen Priority: Minor Fix For: SVN trunk Attachments: patch9648.patch This issue is part of Key-Work Ofbiz Contribution Proposal. http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal Based on Release: 540035 Includes: - Required: - Recommended: - Classes: WrappingException.java, WrappingRuntimeException, WrappingGenericEntityException Description: These classes were introduced to have a standard way of exception tunneling. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
We're Hiring: Software Developers and Project Manager
Hi everybody, We (Open Source Strategies) are looking to hire for at least two additional full-time positions: 1. Software developer: we're looking for someone with significant Java web applications development experience to help with Web 2.0 user interfaces and business intelligence for opentaps. 2. Project manager: someone with ERP and CRM implementation project management experience who will be involved with both implementing opentaps and charting a direction for it. For the project manager position, we need some who would be based out of Los Angeles and be able to travel to client sites. If you are interested, please e-mail me directly at sichen AT opensourcestrategies DOT com Thanks. Si
[jira] Commented: (OFBIZ-1030) Ofbiz SQL-Logging Extension
[ https://issues.apache.org/jira/browse/OFBIZ-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12570732#action_12570732 ] Si Chen commented on OFBIZ-1030: I like this feature as well and would like to commit it into the trunk if that's okay with everybody else Ofbiz SQL-Logging Extension --- Key: OFBIZ-1030 URL: https://issues.apache.org/jira/browse/OFBIZ-1030 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Environment: Win XP Reporter: Karl Eilebrecht Priority: Minor Fix For: SVN trunk Attachments: OfbizLoggingDbAccessEn.pdf, patch9672.patch This issue is part of Key-Work Ofbiz Contribution Proposal. http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal Based on Release: 540035 Includes: - Required: JIRA-1029, JIRA-1017, JIRA-1016 Recommended: - Classes: DBAccessLog.java, DBAccessLogEventFactory.java, DBAccessLogProcessor.java, DefaultSqlLogOutputStrategy.java, SqlLogNamedArgsMap.java, SqlLogOutputStrategy.java, SqlLogReplacements.java, SqlLogStatementInterceptor.java, SqlLogUtils.java, SQLProcessor.java Description: This patch adds enhanced logging support for all sql statements including arguments ofbiz sends to the DBMS. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1030) Ofbiz SQL-Logging Extension
[ https://issues.apache.org/jira/browse/OFBIZ-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen reassigned OFBIZ-1030: -- Assignee: Si Chen Ofbiz SQL-Logging Extension --- Key: OFBIZ-1030 URL: https://issues.apache.org/jira/browse/OFBIZ-1030 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Environment: Win XP Reporter: Karl Eilebrecht Assignee: Si Chen Priority: Minor Fix For: SVN trunk Attachments: OfbizLoggingDbAccessEn.pdf, patch9672.patch This issue is part of Key-Work Ofbiz Contribution Proposal. http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal Based on Release: 540035 Includes: - Required: JIRA-1029, JIRA-1017, JIRA-1016 Recommended: - Classes: DBAccessLog.java, DBAccessLogEventFactory.java, DBAccessLogProcessor.java, DefaultSqlLogOutputStrategy.java, SqlLogNamedArgsMap.java, SqlLogOutputStrategy.java, SqlLogReplacements.java, SqlLogStatementInterceptor.java, SqlLogUtils.java, SQLProcessor.java Description: This patch adds enhanced logging support for all sql statements including arguments ofbiz sends to the DBMS. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1030) Ofbiz SQL-Logging Extension
[ https://issues.apache.org/jira/browse/OFBIZ-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen reassigned OFBIZ-1030: -- Assignee: (was: Si Chen) sorry everybody, I assigned the wrong issue to myself. In fact, I've not looked at this and don't have an opinion either way. Ofbiz SQL-Logging Extension --- Key: OFBIZ-1030 URL: https://issues.apache.org/jira/browse/OFBIZ-1030 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Environment: Win XP Reporter: Karl Eilebrecht Priority: Minor Fix For: SVN trunk Attachments: OfbizLoggingDbAccessEn.pdf, patch9672.patch This issue is part of Key-Work Ofbiz Contribution Proposal. http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal Based on Release: 540035 Includes: - Required: JIRA-1029, JIRA-1017, JIRA-1016 Recommended: - Classes: DBAccessLog.java, DBAccessLogEventFactory.java, DBAccessLogProcessor.java, DefaultSqlLogOutputStrategy.java, SqlLogNamedArgsMap.java, SqlLogOutputStrategy.java, SqlLogReplacements.java, SqlLogStatementInterceptor.java, SqlLogUtils.java, SQLProcessor.java Description: This patch adds enhanced logging support for all sql statements including arguments ofbiz sends to the DBMS. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1033) Ofbiz SQL Integration Features
[ https://issues.apache.org/jira/browse/OFBIZ-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12570818#action_12570818 ] Si Chen commented on OFBIZ-1033: would it be okay if I committed this to the trunk? Ofbiz SQL Integration Features -- Key: OFBIZ-1033 URL: https://issues.apache.org/jira/browse/OFBIZ-1033 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Environment: Win XP Reporter: Karl Eilebrecht Assignee: Si Chen Priority: Minor Fix For: SVN trunk Attachments: OfbizSqlEn.pdf, patch9676.patch This issue is part of Key-Work Ofbiz Contribution Proposal. http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal Based on Release: 540035 Includes: - Required: JIRA-1016 Recommended: JIRA-1030 Classes: MapResultSetIterator.java, OfbizResultSet.java, OfbizResultSetWrapper.java, PaSqlUtils.java, ResultSetAccessException.java, ResultSetIndexInterceptor.java, Sql2EntityUtils.java, SqlHelper.java, SqlUtils.java, ExtEntityListIterator.java Description: This patch provides enhanced features to access the database with plain sql. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1033) Ofbiz SQL Integration Features
[ https://issues.apache.org/jira/browse/OFBIZ-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen reassigned OFBIZ-1033: -- Assignee: Si Chen Ofbiz SQL Integration Features -- Key: OFBIZ-1033 URL: https://issues.apache.org/jira/browse/OFBIZ-1033 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Environment: Win XP Reporter: Karl Eilebrecht Assignee: Si Chen Priority: Minor Fix For: SVN trunk Attachments: OfbizSqlEn.pdf, patch9676.patch This issue is part of Key-Work Ofbiz Contribution Proposal. http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal Based on Release: 540035 Includes: - Required: JIRA-1016 Recommended: JIRA-1030 Classes: MapResultSetIterator.java, OfbizResultSet.java, OfbizResultSetWrapper.java, PaSqlUtils.java, ResultSetAccessException.java, ResultSetIndexInterceptor.java, Sql2EntityUtils.java, SqlHelper.java, SqlUtils.java, ExtEntityListIterator.java Description: This patch provides enhanced features to access the database with plain sql. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1636) delegator.getNextSubSeqId does not guarantee primary key uniqueness
delegator.getNextSubSeqId does not guarantee primary key uniqueness --- Key: OFBIZ-1636 URL: https://issues.apache.org/jira/browse/OFBIZ-1636 Project: OFBiz Issue Type: Bug Components: framework Reporter: Si Chen Priority: Critical The delegator.getNextSubSeqId method currently will look into the table for all rows which shared the same primary key values except the subsequence ID field and returned the next available subsequence ID field value. However, if another process came in to ask for the same subsequence ID value, it will give the same value back again. It does not guarantee primary key uniqueness. For example, if you are reserving inventory for inventory item ID 1, delegator.getNextSubSeqId might return the next inventoryItemSeqId of 10. If you are reserving inventory for many items on a large order, however, your transaction would not be closed until all the inventory reservations are completed. In the meantime, if another order came in and inventory has to be reserved against inventory item ID 1 again, delegator.getNextSubSeqId will give inventoryItemSeqId of 10 again. When both transactions try to commit, one of them will inevitably run into a foreign key collision. We can think of two possible solutions for this problem: 1. Make inventoryItemSeqId the primary key of InventoryItemDetail table, and use delegator.getNextSeqId and SequenceValueItem to generate its values. InventoryItemDetail was still have an inventoryItemId and be related to InventoryItem. 2. Create a cache for subsequence ID values. The key of the cache would be a Map of the primary key fields for InventoryItemDetail minus inventoryItemSeqId, and the value of the cache would be the maximum available inventoryItemSeqId. The cache would be set to timeout or clear, every 30 minutes or so, and during that time it would be able to tell delegator.getNextSubSeqId what the maximum available value would be based on both what's in the database and what other processes may have been assigned. This method is more complicated and not as sure, but it would still allow us to have subsequence IDs of 1, 2, 3, 4, etc. If anyone has other suggestions, please let me know. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1594) support for running services while disabling secas
[ https://issues.apache.org/jira/browse/OFBIZ-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen closed OFBIZ-1594. -- Resolution: Fixed support for running services while disabling secas -- Key: OFBIZ-1594 URL: https://issues.apache.org/jira/browse/OFBIZ-1594 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Si Chen Attachments: ofbiz-1594.patch We would like to implement a support to run services with secas disabled. I'm not sure if we'll either add a method to the dispatcher to disable and re-enable SECAs or if we'll add a runSync(...) method for doing so. This could significantly boost performance. if anyone has comments/suggestions please post them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1592) Database spikes lead to permanent user privilege loss
[ https://issues.apache.org/jira/browse/OFBIZ-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12561899#action_12561899 ] Si Chen commented on OFBIZ-1592: If there are no objections I will commit it. Database spikes lead to permanent user privilege loss - Key: OFBIZ-1592 URL: https://issues.apache.org/jira/browse/OFBIZ-1592 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Torres Priority: Critical Fix For: SVN trunk Attachments: permanent-security-loss.patch We found a critical bug in OFBiz security where temporary database spikes can lead to permanent privilege loss for users trying to log in or do something during the spike. The loss lasts until a cache refresh or a restart. A symptom is customers not being able to log in to do a checkout, not being able to create new accounts, and backend users not being able to perform their duties due to privilege loss. The reason for the bug was found to be in the caching of UserLoginSecurityGroup in OFBizSecurity. When there's an SQL exception, such as during a lag spike, an empty list will be stored in the cache. Subsequent security checks will retrieve this empty list and never ask the database again what the actual security groups are. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1592) Database spikes lead to permanent user privilege loss
[ https://issues.apache.org/jira/browse/OFBIZ-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen reassigned OFBIZ-1592: -- Assignee: Si Chen Database spikes lead to permanent user privilege loss - Key: OFBIZ-1592 URL: https://issues.apache.org/jira/browse/OFBIZ-1592 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Torres Assignee: Si Chen Priority: Critical Fix For: SVN trunk Attachments: permanent-security-loss.patch We found a critical bug in OFBiz security where temporary database spikes can lead to permanent privilege loss for users trying to log in or do something during the spike. The loss lasts until a cache refresh or a restart. A symptom is customers not being able to log in to do a checkout, not being able to create new accounts, and backend users not being able to perform their duties due to privilege loss. The reason for the bug was found to be in the caching of UserLoginSecurityGroup in OFBizSecurity. When there's an SQL exception, such as during a lag spike, an empty list will be stored in the cache. Subsequent security checks will retrieve this empty list and never ask the database again what the actual security groups are. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1594) support for running services while disabling secas
support for running services while disabling secas -- Key: OFBIZ-1594 URL: https://issues.apache.org/jira/browse/OFBIZ-1594 Project: OFBiz Issue Type: Improvement Reporter: Si Chen We would like to implement a support to run services with secas disabled. I'm not sure if we'll either add a method to the dispatcher to disable and re-enable SECAs or if we'll add a runSync(...) method for doing so. This could significantly boost performance. if anyone has comments/suggestions please post them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1594) support for running services while disabling secas
[ https://issues.apache.org/jira/browse/OFBIZ-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen updated OFBIZ-1594: --- Attachment: (was: ofbiz-1594.patch) support for running services while disabling secas -- Key: OFBIZ-1594 URL: https://issues.apache.org/jira/browse/OFBIZ-1594 Project: OFBiz Issue Type: Improvement Reporter: Si Chen Attachments: ofbiz-1594.patch We would like to implement a support to run services with secas disabled. I'm not sure if we'll either add a method to the dispatcher to disable and re-enable SECAs or if we'll add a runSync(...) method for doing so. This could significantly boost performance. if anyone has comments/suggestions please post them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1594) support for running services while disabling secas
[ https://issues.apache.org/jira/browse/OFBIZ-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen updated OFBIZ-1594: --- Attachment: ofbiz-1594.patch support for running services while disabling secas -- Key: OFBIZ-1594 URL: https://issues.apache.org/jira/browse/OFBIZ-1594 Project: OFBiz Issue Type: Improvement Reporter: Si Chen Attachments: ofbiz-1594.patch We would like to implement a support to run services with secas disabled. I'm not sure if we'll either add a method to the dispatcher to disable and re-enable SECAs or if we'll add a runSync(...) method for doing so. This could significantly boost performance. if anyone has comments/suggestions please post them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1594) support for running services while disabling secas
[ https://issues.apache.org/jira/browse/OFBIZ-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen updated OFBIZ-1594: --- Attachment: ofbiz-1594.patch Here's one way to do it. Let me know if anyone has issues/suggestions. Otherwise I'll commit it. support for running services while disabling secas -- Key: OFBIZ-1594 URL: https://issues.apache.org/jira/browse/OFBIZ-1594 Project: OFBiz Issue Type: Improvement Reporter: Si Chen Attachments: ofbiz-1594.patch We would like to implement a support to run services with secas disabled. I'm not sure if we'll either add a method to the dispatcher to disable and re-enable SECAs or if we'll add a runSync(...) method for doing so. This could significantly boost performance. if anyone has comments/suggestions please post them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1592) Database spikes lead to permanent user privilege loss
[ https://issues.apache.org/jira/browse/OFBIZ-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12561915#action_12561915 ] Si Chen commented on OFBIZ-1592: Why do you think so? Database spikes lead to permanent user privilege loss - Key: OFBIZ-1592 URL: https://issues.apache.org/jira/browse/OFBIZ-1592 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Torres Assignee: Si Chen Priority: Critical Fix For: SVN trunk Attachments: permanent-security-loss.patch We found a critical bug in OFBiz security where temporary database spikes can lead to permanent privilege loss for users trying to log in or do something during the spike. The loss lasts until a cache refresh or a restart. A symptom is customers not being able to log in to do a checkout, not being able to create new accounts, and backend users not being able to perform their duties due to privilege loss. The reason for the bug was found to be in the caching of UserLoginSecurityGroup in OFBizSecurity. When there's an SQL exception, such as during a lag spike, an empty list will be stored in the cache. Subsequent security checks will retrieve this empty list and never ask the database again what the actual security groups are. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1571) Product keyword search SQL error (patch)
[ https://issues.apache.org/jira/browse/OFBIZ-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen closed OFBIZ-1571. -- Resolution: Fixed thanks. Product keyword search SQL error (patch) Key: OFBIZ-1571 URL: https://issues.apache.org/jira/browse/OFBIZ-1571 Project: OFBiz Issue Type: Bug Components: product Affects Versions: SVN trunk Environment: postgres SQL 8.2 Reporter: Wickersheimer Jeremy Assignee: Si Chen Fix For: SVN trunk Attachments: 1571.patch It seems the way the SQL query is built is incorrect when there are both And and Or sets for keywords. For this you need a Thesaurus rule that expand one keyword into 2 (ex foo = bar1 bar2) Then if you search for foo foobar, the query will be like this: SELECT DISTINCT (PK2.RELEVANCY_WEIGHT + SUM(PK3.RELEVANCY_WEIGHT)), PROD.PRODUCT_ID FROM public.PRODUCT PROD LEFT OUTER JOIN public.PRODUCT_CALCULATED_INFO PRODCI ON PROD.PRODUCT_ID = PRODCI.PRODUCT_ID) INNER JOIN public.PRODUCT_CATEGORY_MEMBER PCM1 ON PROD.PRODUCT_ID = PCM1.PRODUCT_ID) INNER JOIN public.PRODUCT_PRICE PSPP2 ON PROD.PRODUCT_ID = PSPP2.PRODUCT_ID) INNER JOIN public.PRODUCT_KEYWORD PK2 ON PROD.PRODUCT_ID = PK2.PRODUCT_ID) INNER JOIN public.PRODUCT_KEYWORD PK3 ON PROD.PRODUCT_ID = PK3.PRODUCT_ID WHERE (PCM1.PRODUCT_CATEGORY_ID IN ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? ) AND (PCM1.THRU_DATE IS NULL OR PCM1.THRU_DATE ?) AND PCM1.FROM_DATE ? AND PSPP2.PRODUCT_PRICE_TYPE_ID = ? AND PSPP2.PRODUCT_PRICE_PURPOSE_ID = ? AND PSPP2.CURRENCY_UOM_ID = ? AND PSPP2.PRODUCT_STORE_GROUP_ID = ? AND (PSPP2.THRU_DATE IS NULL OR PSPP2.THRU_DATE ?) AND PSPP2.FROM_DATE ? AND PROD.IS_VARIANT ? AND (PROD.INTRODUCTION_DATE IS NULL OR PROD.INTRODUCTION_DATE = ?) AND (PROD.SALES_DISCONTINUATION_DATE IS NULL OR PROD.SALES_DISCONTINUATION_DATE ?) AND PK2.KEYWORD LIKE ? AND (PK3.KEYWORD LIKE ? OR PK3.KEYWORD LIKE ?)) GROUP BY PROD.PRODUCT_ID ORDER BY (PK2.RELEVANCY_WEIGHT + SUM(PK3.RELEVANCY_WEIGHT)) DESC And the error is: (ERROR: column pk2.relevancy_weight must appear in the GROUP BY clause or be used in an aggregate function) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1572) Product keyword search doesn't search in all child categories (patch)
[ https://issues.apache.org/jira/browse/OFBIZ-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12558185#action_12558185 ] Si Chen commented on OFBIZ-1572: I think it's a bug. If you only show products in the top-level categories, the result is very counterintuitive. Product keyword search doesn't search in all child categories (patch) - Key: OFBIZ-1572 URL: https://issues.apache.org/jira/browse/OFBIZ-1572 Project: OFBiz Issue Type: Bug Components: product Affects Versions: SVN trunk Reporter: Wickersheimer Jeremy Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: 1572.patch The keyword search doesn't search in the child categories below one level. I'll attach a patch that get the categories recursively. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1571) Product keyword search SQL error (patch)
[ https://issues.apache.org/jira/browse/OFBIZ-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen reassigned OFBIZ-1571: -- Assignee: Si Chen Product keyword search SQL error (patch) Key: OFBIZ-1571 URL: https://issues.apache.org/jira/browse/OFBIZ-1571 Project: OFBiz Issue Type: Bug Components: product Affects Versions: SVN trunk Environment: postgres SQL 8.2 Reporter: Wickersheimer Jeremy Assignee: Si Chen Fix For: SVN trunk Attachments: 1571.patch It seems the way the SQL query is built is incorrect when there are both And and Or sets for keywords. For this you need a Thesaurus rule that expand one keyword into 2 (ex foo = bar1 bar2) Then if you search for foo foobar, the query will be like this: SELECT DISTINCT (PK2.RELEVANCY_WEIGHT + SUM(PK3.RELEVANCY_WEIGHT)), PROD.PRODUCT_ID FROM public.PRODUCT PROD LEFT OUTER JOIN public.PRODUCT_CALCULATED_INFO PRODCI ON PROD.PRODUCT_ID = PRODCI.PRODUCT_ID) INNER JOIN public.PRODUCT_CATEGORY_MEMBER PCM1 ON PROD.PRODUCT_ID = PCM1.PRODUCT_ID) INNER JOIN public.PRODUCT_PRICE PSPP2 ON PROD.PRODUCT_ID = PSPP2.PRODUCT_ID) INNER JOIN public.PRODUCT_KEYWORD PK2 ON PROD.PRODUCT_ID = PK2.PRODUCT_ID) INNER JOIN public.PRODUCT_KEYWORD PK3 ON PROD.PRODUCT_ID = PK3.PRODUCT_ID WHERE (PCM1.PRODUCT_CATEGORY_ID IN ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? ) AND (PCM1.THRU_DATE IS NULL OR PCM1.THRU_DATE ?) AND PCM1.FROM_DATE ? AND PSPP2.PRODUCT_PRICE_TYPE_ID = ? AND PSPP2.PRODUCT_PRICE_PURPOSE_ID = ? AND PSPP2.CURRENCY_UOM_ID = ? AND PSPP2.PRODUCT_STORE_GROUP_ID = ? AND (PSPP2.THRU_DATE IS NULL OR PSPP2.THRU_DATE ?) AND PSPP2.FROM_DATE ? AND PROD.IS_VARIANT ? AND (PROD.INTRODUCTION_DATE IS NULL OR PROD.INTRODUCTION_DATE = ?) AND (PROD.SALES_DISCONTINUATION_DATE IS NULL OR PROD.SALES_DISCONTINUATION_DATE ?) AND PK2.KEYWORD LIKE ? AND (PK3.KEYWORD LIKE ? OR PK3.KEYWORD LIKE ?)) GROUP BY PROD.PRODUCT_ID ORDER BY (PK2.RELEVANCY_WEIGHT + SUM(PK3.RELEVANCY_WEIGHT)) DESC And the error is: (ERROR: column pk2.relevancy_weight must appear in the GROUP BY clause or be used in an aggregate function) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1571) Product keyword search SQL error (patch)
[ https://issues.apache.org/jira/browse/OFBIZ-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12558184#action_12558184 ] Si Chen commented on OFBIZ-1571: If there are no objections I will be committing this. Product keyword search SQL error (patch) Key: OFBIZ-1571 URL: https://issues.apache.org/jira/browse/OFBIZ-1571 Project: OFBiz Issue Type: Bug Components: product Affects Versions: SVN trunk Environment: postgres SQL 8.2 Reporter: Wickersheimer Jeremy Assignee: Si Chen Fix For: SVN trunk Attachments: 1571.patch It seems the way the SQL query is built is incorrect when there are both And and Or sets for keywords. For this you need a Thesaurus rule that expand one keyword into 2 (ex foo = bar1 bar2) Then if you search for foo foobar, the query will be like this: SELECT DISTINCT (PK2.RELEVANCY_WEIGHT + SUM(PK3.RELEVANCY_WEIGHT)), PROD.PRODUCT_ID FROM public.PRODUCT PROD LEFT OUTER JOIN public.PRODUCT_CALCULATED_INFO PRODCI ON PROD.PRODUCT_ID = PRODCI.PRODUCT_ID) INNER JOIN public.PRODUCT_CATEGORY_MEMBER PCM1 ON PROD.PRODUCT_ID = PCM1.PRODUCT_ID) INNER JOIN public.PRODUCT_PRICE PSPP2 ON PROD.PRODUCT_ID = PSPP2.PRODUCT_ID) INNER JOIN public.PRODUCT_KEYWORD PK2 ON PROD.PRODUCT_ID = PK2.PRODUCT_ID) INNER JOIN public.PRODUCT_KEYWORD PK3 ON PROD.PRODUCT_ID = PK3.PRODUCT_ID WHERE (PCM1.PRODUCT_CATEGORY_ID IN ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? ) AND (PCM1.THRU_DATE IS NULL OR PCM1.THRU_DATE ?) AND PCM1.FROM_DATE ? AND PSPP2.PRODUCT_PRICE_TYPE_ID = ? AND PSPP2.PRODUCT_PRICE_PURPOSE_ID = ? AND PSPP2.CURRENCY_UOM_ID = ? AND PSPP2.PRODUCT_STORE_GROUP_ID = ? AND (PSPP2.THRU_DATE IS NULL OR PSPP2.THRU_DATE ?) AND PSPP2.FROM_DATE ? AND PROD.IS_VARIANT ? AND (PROD.INTRODUCTION_DATE IS NULL OR PROD.INTRODUCTION_DATE = ?) AND (PROD.SALES_DISCONTINUATION_DATE IS NULL OR PROD.SALES_DISCONTINUATION_DATE ?) AND PK2.KEYWORD LIKE ? AND (PK3.KEYWORD LIKE ? OR PK3.KEYWORD LIKE ?)) GROUP BY PROD.PRODUCT_ID ORDER BY (PK2.RELEVANCY_WEIGHT + SUM(PK3.RELEVANCY_WEIGHT)) DESC And the error is: (ERROR: column pk2.relevancy_weight must appear in the GROUP BY clause or be used in an aggregate function) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1455) order requirements should only be created when orders are approved
[ https://issues.apache.org/jira/browse/OFBIZ-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen closed OFBIZ-1455. -- Resolution: Fixed order requirements should only be created when orders are approved -- Key: OFBIZ-1455 URL: https://issues.apache.org/jira/browse/OFBIZ-1455 Project: OFBiz Issue Type: Bug Reporter: Si Chen currently requirements are created when orders are created, even if the order is in the Created state. This is not a good practice as the order may not be completed. The requirements secas should be changed so that only when order status is changed to Approved are the requirements created. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1199) makeLoginUrl doesn't URL encode the strings
[ https://issues.apache.org/jira/browse/OFBIZ-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547323 ] Si Chen commented on OFBIZ-1199: Well, BJ, do you have any suggestions? makeLoginUrl doesn't URL encode the strings --- Key: OFBIZ-1199 URL: https://issues.apache.org/jira/browse/OFBIZ-1199 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Wickersheimer Jeremy Assignee: Si Chen Priority: Minor Attachments: ofbiz-1199.patch The makeLoginUrl method in LoginWorker simply appends all parameters names and values to make an URL string, without using URLEncode. This will make broken URLs when specials characters or Unicode characters are present. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1455) order requirements should only be created when orders are approved
[ https://issues.apache.org/jira/browse/OFBIZ-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547308 ] Si Chen commented on OFBIZ-1455: Yes, but I believe that should be a separate issue and could be pretty involved. Do you have time to work on it? If so I'll write up a jira issue for it. order requirements should only be created when orders are approved -- Key: OFBIZ-1455 URL: https://issues.apache.org/jira/browse/OFBIZ-1455 Project: OFBiz Issue Type: Bug Reporter: Si Chen currently requirements are created when orders are created, even if the order is in the Created state. This is not a good practice as the order may not be completed. The requirements secas should be changed so that only when order status is changed to Approved are the requirements created. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1455) order requirements should only be created when orders are approved
order requirements should only be created when orders are approved -- Key: OFBIZ-1455 URL: https://issues.apache.org/jira/browse/OFBIZ-1455 Project: OFBiz Issue Type: Bug Reporter: Si Chen currently requirements are created when orders are created, even if the order is in the Created state. This is not a good practice as the order may not be completed. The requirements secas should be changed so that only when order status is changed to Approved are the requirements created. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1203) Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
[ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546342 ] Si Chen commented on OFBIZ-1203: our commit r 598723 should complete the drop ship po's Drop Ship sales and purchase orders, move items to completed when items are shipped and received. - Key: OFBIZ-1203 URL: https://issues.apache.org/jira/browse/OFBIZ-1203 Project: OFBiz Issue Type: Improvement Components: accounting, order Environment: All systems, all enviornments Reporter: Karl Pieleck Assignee: Jacopo Cappellato Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as will drop ship. Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped. Action to Correct: Add code and services to close Drop Ship Type PO's and Sales Orders when they are actually completed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1199) makeLoginUrl doesn't URL encode the strings
[ https://issues.apache.org/jira/browse/OFBIZ-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen reassigned OFBIZ-1199: -- Assignee: Si Chen makeLoginUrl doesn't URL encode the strings --- Key: OFBIZ-1199 URL: https://issues.apache.org/jira/browse/OFBIZ-1199 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Wickersheimer Jeremy Assignee: Si Chen Priority: Minor Attachments: ofbiz-1199.patch The makeLoginUrl method in LoginWorker simply appends all parameters names and values to make an URL string, without using URLEncode. This will make broken URLs when specials characters or Unicode characters are present. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1199) makeLoginUrl doesn't URL encode the strings
[ https://issues.apache.org/jira/browse/OFBIZ-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545956 ] Si Chen commented on OFBIZ-1199: If there are no objections I will be committing this patch. makeLoginUrl doesn't URL encode the strings --- Key: OFBIZ-1199 URL: https://issues.apache.org/jira/browse/OFBIZ-1199 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Wickersheimer Jeremy Assignee: Si Chen Priority: Minor Attachments: ofbiz-1199.patch The makeLoginUrl method in LoginWorker simply appends all parameters names and values to make an URL string, without using URLEncode. This will make broken URLs when specials characters or Unicode characters are present. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1418) ofbizContentUrl does not fetch https:// when the request is https://
[ https://issues.apache.org/jira/browse/OFBIZ-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen closed OFBIZ-1418. -- Resolution: Fixed You are right! I completely forgot about that. Thanks for looking into it. ofbizContentUrl does not fetch https:// when the request is https:// Key: OFBIZ-1418 URL: https://issues.apache.org/jira/browse/OFBIZ-1418 Project: OFBiz Issue Type: Bug Reporter: Si Chen ofbizContentUrl is not correctly handing https:// requests -- even when the request is https:// it is still generating http:// The easiest way to see this is to use IE to access any ofbiz page such as https://demo1.opentaps.org/crmsfa/ you will see it prompt you about non-secure content which includes the logo and the css files generated with ofbizContentUrl. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1315) POS does not do itemIssuance
[ https://issues.apache.org/jira/browse/OFBIZ-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545087 ] Si Chen commented on OFBIZ-1315: Hey there: I just saw this message on the commit list: As explained Bilgin it was not really a problem (RetailStore has no inventory) I disagree with this statement--the retail store does have inventory and uses the inventory in the Retail Store's warehouse. I think you should reopen this issue. POS does not do itemIssuance Key: OFBIZ-1315 URL: https://issues.apache.org/jira/browse/OFBIZ-1315 Project: OFBiz Issue Type: Bug Components: pos Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Critical Fix For: SVN trunk Attachments: fix.patch One of the problems is that the POS does not do itemIssuance so the general ledger accounting will not handle it correctly. This is most critical. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1260) reserve inventory not accounting for inventory transfers
[ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544537 ] Si Chen commented on OFBIZ-1260: Hey guys, reserving inventory for products with negative atp or 0 atp is the desired behavior. This is how the system takes back orders and when inventory is received balanceInventoryItems will set it off against a positive item. In any case, it's a totally different issue than what this issue is about: here the issue is that even when an inventory item is pending transfer, it will still be reserved against orders. reserve inventory not accounting for inventory transfers Key: OFBIZ-1260 URL: https://issues.apache.org/jira/browse/OFBIZ-1260 Project: OFBiz Issue Type: Bug Components: product Reporter: Si Chen Attachments: ofbiz-inv-xfer-res.zip It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers. I think it should be. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1418) ofbizContentUrl does not fetch https:// when the request is https://
ofbizContentUrl does not fetch https:// when the request is https:// Key: OFBIZ-1418 URL: https://issues.apache.org/jira/browse/OFBIZ-1418 Project: OFBiz Issue Type: Bug Reporter: Si Chen ofbizContentUrl is not correctly handing https:// requests -- even when the request is https:// it is still generating http:// The easiest way to see this is to use IE to access any ofbiz page such as https://demo1.opentaps.org/crmsfa/ you will see it prompt you about non-secure content which includes the logo and the css files generated with ofbizContentUrl. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1260) reserve inventory not accounting for inventory transfers
[ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543993 ] Si Chen commented on OFBIZ-1260: I am able to replicate the scenario, and what happens is the item waiting for a transfer is reserved against a new order. You can try it yourself: 1. Receive 1.0 of GZ-1001 into WebStoreWarehouse 2. Create a pending inventory transfer to My Retail Warehouse 3. Create sales order for 1 GZ-1001 for the Demo Ecommerce Store. You will see that the same item which is awaiting inventory transfer is reserved for your sales order. Please take a look at the video I just uploaded. I'm not sure that IID is the answer or if the reserveProductInventory method should check for pending transfers manually. Si reserve inventory not accounting for inventory transfers Key: OFBIZ-1260 URL: https://issues.apache.org/jira/browse/OFBIZ-1260 Project: OFBiz Issue Type: Bug Components: product Reporter: Si Chen Attachments: ofbiz-inv-xfer-res.zip It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers. I think it should be. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1260) reserve inventory not accounting for inventory transfers
[ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen updated OFBIZ-1260: --- Attachment: ofbiz-inv-xfer-res.zip video showing this reserve inventory not accounting for inventory transfers Key: OFBIZ-1260 URL: https://issues.apache.org/jira/browse/OFBIZ-1260 Project: OFBiz Issue Type: Bug Components: product Reporter: Si Chen Attachments: ofbiz-inv-xfer-res.zip It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers. I think it should be. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1260) reserve inventory not accounting for inventory transfers
[ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544100 ] Si Chen commented on OFBIZ-1260: Hi Bilgin, Yes, thanks for pointing that out, but that's not quite the same thing. I think we should be able to support taking the back order, but it should not reserve against an item waiting to be transferred. reserve inventory not accounting for inventory transfers Key: OFBIZ-1260 URL: https://issues.apache.org/jira/browse/OFBIZ-1260 Project: OFBiz Issue Type: Bug Components: product Reporter: Si Chen Attachments: ofbiz-inv-xfer-res.zip It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers. I think it should be. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1260) reserve inventory not accounting for inventory transfers
[ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543613 ] Si Chen commented on OFBIZ-1260: The ATP is decreased, but is the inventory item considered reserved? For example, if you create a sales order for the same item, I think the system would reserve the inventory item which should be transferred against the sales order. reserve inventory not accounting for inventory transfers Key: OFBIZ-1260 URL: https://issues.apache.org/jira/browse/OFBIZ-1260 Project: OFBiz Issue Type: Bug Components: product Reporter: Si Chen It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers. I think it should be. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1260) reserve inventory not accounting for inventory transfers
[ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543136 ] Si Chen commented on OFBIZ-1260: Well that would be nice... Where does it do that? Did I miss it in the code? reserve inventory not accounting for inventory transfers Key: OFBIZ-1260 URL: https://issues.apache.org/jira/browse/OFBIZ-1260 Project: OFBiz Issue Type: Bug Components: product Reporter: Si Chen It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers. I think it should be. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1394) Lots of log errors related to AcctgTransServices.xml and GeneralLedgerServices.xml
[
https://issues.apache.org/jira/browse/OFBIZ-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542816
]
Si Chen commented on OFBIZ-1394:
Hey there, how come the BigDecimal typecasting was removed?
-calcop operator=get field-name=debitTotal
type=BigDecimal/
-calcop operator=negative field-name=creditTotal
type=BigDecimal/
+calcop operator=get field-name=debitTotal/
+calcop operator=negative field-name=creditTotal/
Lots of log errors related to AcctgTransServices.xml and
GeneralLedgerServices.xml
--
Key: OFBIZ-1394
URL: https://issues.apache.org/jira/browse/OFBIZ-1394
Project: OFBiz
Issue Type: Bug
Components: accounting
Reporter: Skip Dever
Assignee: Jacopo Cappellato
Priority: Trivial
I am getting lots of xml parsing errors like this:
UtilXml.java:652:ERROR] XmlFileLoader: File
file:/G:/JavaProjects/opentaps1.5Work/hot-deploy/opentaps-common/webapp/common/WEB-INF/common-controller.xml
process error. Line: 27. Error message: cvc-complex-type.2.4.a: Invalid
content was found starting with element 'include'. One of '{errorpage,
handler, firstvisit, preprocessor, postprocessor, after-login, before-logout,
default-request, request-map, view-map}' is expected.
and
UtilXml.java:652:ERROR] XmlFileLoader: File
file:/G:/JavaProjects/opentaps1.5Work/applications/accounting/script/org/ofbiz/accounting/ledger/AcctgTransServices.xml
process error. Line: 118. Error message: cvc-enumeration-valid: Value
'${ledgerRounding}' is not facet-valid with respect to enumeration '[Ceiling,
Floor, Up, Down, HalfUp, HalfDown, HalfEven, Unnecessary]'. It must be a
value from the enumeration.
and
UtilXml.java:652:ERROR] XmlFileLoader: File
file:/G:/JavaProjects/opentaps1.5Work/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
process error. Line: 322. Error message: cvc-enumeration-valid: Value
'${ledgerRounding}' is not facet-valid with respect to enumeration '[Ceiling,
Floor, Up, Down, HalfUp, HalfDown, HalfEven, Unnecessary]'. It must be a
value from the enumeration.
Things seem to run ok, but it clutters up the log file when you are looking
for real errors. Can someone point me in the right direction to fix this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1390) framework/base and framework/common translation to portuguese
[ https://issues.apache.org/jira/browse/OFBIZ-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen reassigned OFBIZ-1390: -- Assignee: Si Chen framework/base and framework/common translation to portuguese - Key: OFBIZ-1390 URL: https://issues.apache.org/jira/browse/OFBIZ-1390 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Paulo Cristo Assignee: Si Chen Priority: Minor Attachments: framework-base_config.tar.gz, framework-common_config.tar.gz framework/base and framework/common translation to portuguese -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1141) More user friendly error messages
[ https://issues.apache.org/jira/browse/OFBIZ-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534340 ] Si Chen commented on OFBIZ-1141: Hey guys - I think this is something which would be very helpful, but maybe we should take a look at the Spring Framework's data access exception methods: http://www.theserverside.com/tt/articles/article.tss?l=SpringFramework More user friendly error messages - Key: OFBIZ-1141 URL: https://issues.apache.org/jira/browse/OFBIZ-1141 Project: OFBiz Issue Type: Improvement Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Wickersheimer Jeremy Priority: Minor Attachments: ofbiz-1141-example1.patch, ofbiz-1141-example2.patch, ofbiz-1141-example3.patch A lot of error messages in Ofbiz are cryptic for normal users. For example sometimes a user would trigger a database foreign key violation and as a result will have a quite big error message thrown at him. This would happen for example when you create an Agreement then gives both a Party Id To and a Role Type Id To that doesn't match. In that case the error is something like: ERROR: Could not complete the Create an Agreement [file:/home/jeremy/bertelsmann/dgerp/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml#createAgreement] process [problem creating the newEntity value: Exception while inserting the following entity: [GenericEntity:Agreement][agreementDate,null()][agreementId,10076(java.lang.String)][agreementTypeId,null()][createdStamp,2007-07-12 12:33:38.285(java.sql.Timestamp)][createdTxStamp,2007-07-12 12:33:38.283(java.sql.Timestamp)][defaultCurrencyUomId,null()][description,null()][fromDate,2007-07-12 12:33:38.285(java.sql.Timestamp)][fromPartyClassGroupId,null()][lastUpdatedStamp,2007-07-12 12:33:38.285(java.sql.Timestamp)][lastUpdatedTxStamp,2007-07-12 12:33:38.283(java.sql.Timestamp)][partyIdFrom,null()][partyIdTo,Admin(java.lang.String)][productId,null()][roleTypeIdFrom,null()][roleTypeIdTo,PERSON_ROLE(java.lang.String)][statusId,null()][textData,null()][thruDate,null()][toPartyClassGroupId,null()] (while inserting: [GenericEntity:Agreement][agreementDate,null()][agreementId,10076(java.lang.String)][agreementTypeId,null()][createdStamp,2007-07-12 12:33:38.285(java.sql.Timestamp)][createdTxStamp,2007-07-12 12:33:38.283(java.sql.Timestamp)][defaultCurrencyUomId,null()][description,null()][fromDate,2007-07-12 12:33:38.285(java.sql.Timestamp)][fromPartyClassGroupId,null()][lastUpdatedStamp,2007-07-12 12:33:38.285(java.sql.Timestamp)][lastUpdatedTxStamp,2007-07-12 12:33:38.283(java.sql.Timestamp)][partyIdFrom,null()][partyIdTo,Admin(java.lang.String)][productId,null()][roleTypeIdFrom,null()][roleTypeIdTo,PERSON_ROLE(java.lang.String)][statusId,null()][textData,null()][thruDate,null()][toPartyClassGroupId,null()] (SQL Exception while executing the following:INSERT INTO public.AGREEMENT (AGREEMENT_ID, PRODUCT_ID, PARTY_ID_FROM, PARTY_ID_TO, ROLE_TYPE_ID_FROM, ROLE_TYPE_ID_TO, AGREEMENT_TYPE_ID, AGREEMENT_DATE, FROM_DATE, THRU_DATE, DESCRIPTION, TEXT_DATA, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP, STATUS_ID, DEFAULT_CURRENCY_UOM_ID, FROM_PARTY_CLASS_GROUP_ID, TO_PARTY_CLASS_GROUP_ID) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (ERROR: insert or update on table agreement violates foreign key constraint agrmnt_tprtyrle Detail: Key (party_id_to,role_type_id_to)=(Admin,PERSON_ROLE) is not present in table party_role.)))] It is fine for a developer who can understand that, but not for a user. I agree that with some hacking or better design in the forms it would be possible to avoid that kind of error, but the idea would be to be able to catch that and replace the error we something more understandable, for example: ERROR: the Party Id To doesn't have the Role Type To Id you entered. Or better: ERROR: the Party Id To: Admin doesn't have the Role Type To Id: Person. Possible values for the Role Type are : ... I know that such a feature cannot be implemented in the framework directly because errors are context sensitive, so it would have to be done in the Service XML definition. Perhaps some new methods could be added in simple-methods to make that task easier ? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1265) cannot create marketing campaign: permission error
[ https://issues.apache.org/jira/browse/OFBIZ-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen closed OFBIZ-1265. -- Resolution: Fixed This was fixed by changes in r 57410 and OFBIZ-1226 cannot create marketing campaign: permission error -- Key: OFBIZ-1265 URL: https://issues.apache.org/jira/browse/OFBIZ-1265 Project: OFBiz Issue Type: Bug Reporter: Si Chen Trying to create a marketing campaign causes the following: 2007-09-26 12:07:07,749 (http-0.0.0.0-8433-Processor2) [FlexibleStringExpander.java:358:WARN ] Could not find value in environment for the name [primaryPermission], inserting nothing. 2007-09-26 12:07:07,749 (http-0.0.0.0-8433-Processor2) [ Log.java:97 :INFO ] Checking for _CREATE 2007-09-26 12:07:07,750 (http-0.0.0.0-8433-Processor2) [FlexibleStringExpander.java:358:WARN ] Could not find value in environment for the name [altPermission], inserting nothing. 2007-09-26 12:07:07,750 (http-0.0.0.0-8433-Processor2) [ Log.java:97 :INFO ] Checking for _CREATE 2007-09-26 12:07:07,752 (http-0.0.0.0-8433-Processor2) [ TransactionUtil.java:294:WARN ] exception report -- [TransactionUtil.setRollbackOnly] Calling transaction setRollbackOnly; this stack trace shows where this is happening: Exception: java.lang.Exception Message: Error in simple-method [Basic Permission check [file:/Users/sichen/IdeaProjects/opentaps-1.0/framework/common/script/org/ofbiz/common/permission/CommonPermissionServices.xml#genericBasePermissionCheck]]: ; [Permission primaryPermission parameter missing!] stack trace --- java.lang.Exception: Error in simple-method [Basic Permission check [file:/Users/sichen/IdeaProjects/opentaps-1.0/framework/common/script/org/ofbiz/common/permission/CommonPermissionServices.xml#genericBasePermissionCheck]]: ; [Permission primaryPermission parameter missing!] org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:294) org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:241) org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:702) Is there any documentation on this new permission-service stuff? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1318) screen widget show where code came from in html
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533911 ] Si Chen commented on OFBIZ-1318: Wow, this is interesting. As far as I'm concerned, it'd be nice to provide deprecated methods of the old parameter signatures, but otherwise it looks OK. What does everybody else think? screen widget show where code came from in html --- Key: OFBIZ-1318 URL: https://issues.apache.org/jira/browse/OFBIZ-1318 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Si Chen Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch This should help debugging a lot: The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML: !-- Begin .Forms.xml#FormA -- !-- End .Forms.xml#FormA -- Similarly, if html-template is called it could put into HTML: !-- Begin applications/XXX/x.ftl -- !-- End applications/XXX/x.ftl -- etc. etc. I think this would be a good debugging tool. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1313) Remove some Visit-related foreign keys
[ https://issues.apache.org/jira/browse/OFBIZ-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533415 ] Si Chen commented on OFBIZ-1313: That's a good idea but you can't null TrackingCodeVisit.visitId because it's part of the primary key and a not null field. Remove some Visit-related foreign keys -- Key: OFBIZ-1313 URL: https://issues.apache.org/jira/browse/OFBIZ-1313 Project: OFBiz Issue Type: Improvement Reporter: Si Chen Assignee: Si Chen Priority: Minor I would recommend that we remove the foreign keys to the Visit entity, so old Visit records can be safely deleted without affecting data in TrackingCodeVisit, which might be useful for statistical and reporting purposes. It should not affect the core entities. The visits would only no longer be available after some time has passed. If no one has any objections I'll take care of this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1332) Move extension field from PartyContactMech to TelecomNumber
Move extension field from PartyContactMech to TelecomNumber --- Key: OFBIZ-1332 URL: https://issues.apache.org/jira/browse/OFBIZ-1332 Project: OFBiz Issue Type: Bug Reporter: Si Chen Priority: Minor It seems that the extension of a phone number is on PartyContactMech when it should be on TelecomNumber. We propose that we move it to TelecomNumber and change the related services, etc. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
We're Hiring!
Hey everybody - Just wanted to remind everybody on this list that we're still looking for more developers with some familiarity with OFBiz. We have paid positions for developers to work on both client projects and the development of the opentaps Open Source ERP + CRM system and ofbiz. Some of the things which you'll be working on include: - Extending business intelligence in opentaps - Upgrading our user interfaces - Building out our applications - Building a comprehensive set of tests and testing procedures You can work at your own schedule, either full-time and part-time, and from anywhere you want. If this is something you're interested in, please send me an email off the list. Thanks! Si Chen
[jira] Commented: (OFBIZ-1318) screen widget show where code came from in html
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533198 ] Si Chen commented on OFBIZ-1318: Yea, Adrian, if you have some time to work on it it'd be great! screen widget show where code came from in html --- Key: OFBIZ-1318 URL: https://issues.apache.org/jira/browse/OFBIZ-1318 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Si Chen This should help debugging a lot: The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML: !-- Begin .Forms.xml#FormA -- !-- End .Forms.xml#FormA -- Similarly, if html-template is called it could put into HTML: !-- Begin applications/XXX/x.ftl -- !-- End applications/XXX/x.ftl -- etc. etc. I think this would be a good debugging tool. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1318) screen widget show where code came from in html
screen widget show where code came from in html --- Key: OFBIZ-1318 URL: https://issues.apache.org/jira/browse/OFBIZ-1318 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Si Chen This should help debugging a lot: The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML: !-- Begin .Forms.xml#FormA -- !-- End .Forms.xml#FormA -- Similarly, if html-template is called it could put into HTML: !-- Begin applications/XXX/x.ftl -- !-- End applications/XXX/x.ftl -- etc. etc. I think this would be a good debugging tool. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1318) screen widget show where code came from in html
[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532807 ] Si Chen commented on OFBIZ-1318: So, anyway, is anybody opposed to this? screen widget show where code came from in html --- Key: OFBIZ-1318 URL: https://issues.apache.org/jira/browse/OFBIZ-1318 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Si Chen This should help debugging a lot: The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML: !-- Begin .Forms.xml#FormA -- !-- End .Forms.xml#FormA -- Similarly, if html-template is called it could put into HTML: !-- Begin applications/XXX/x.ftl -- !-- End applications/XXX/x.ftl -- etc. etc. I think this would be a good debugging tool. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1313) Remove some Visit-related foreign keys
Remove some Visit-related foreign keys -- Key: OFBIZ-1313 URL: https://issues.apache.org/jira/browse/OFBIZ-1313 Project: OFBiz Issue Type: Improvement Reporter: Si Chen Priority: Minor I would recommend that we remove the foreign keys to the Visit entity, so old Visit records can be safely deleted without affecting data in TrackingCodeVisit, which might be useful for statistical and reporting purposes. It should not affect the core entities. The visits would only no longer be available after some time has passed. If no one has any objections I'll take care of this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1313) Remove some Visit-related foreign keys
[ https://issues.apache.org/jira/browse/OFBIZ-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532533 ] Si Chen commented on OFBIZ-1313: Do you think there will be a way to remove old Visits and keep the TrackingCodeVisit tables. Should we just temporarily drop the constraint and readding it later with a SQL script? Remove some Visit-related foreign keys -- Key: OFBIZ-1313 URL: https://issues.apache.org/jira/browse/OFBIZ-1313 Project: OFBiz Issue Type: Improvement Reporter: Si Chen Assignee: Si Chen Priority: Minor I would recommend that we remove the foreign keys to the Visit entity, so old Visit records can be safely deleted without affecting data in TrackingCodeVisit, which might be useful for statistical and reporting purposes. It should not affect the core entities. The visits would only no longer be available after some time has passed. If no one has any objections I'll take care of this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1313) Remove some Visit-related foreign keys
[ https://issues.apache.org/jira/browse/OFBIZ-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen reassigned OFBIZ-1313: -- Assignee: Si Chen Remove some Visit-related foreign keys -- Key: OFBIZ-1313 URL: https://issues.apache.org/jira/browse/OFBIZ-1313 Project: OFBiz Issue Type: Improvement Reporter: Si Chen Assignee: Si Chen Priority: Minor I would recommend that we remove the foreign keys to the Visit entity, so old Visit records can be safely deleted without affecting data in TrackingCodeVisit, which might be useful for statistical and reporting purposes. It should not affect the core entities. The visits would only no longer be available after some time has passed. If no one has any objections I'll take care of this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1276) Cleanup returnReportContactMechs.fo.ftl
[ https://issues.apache.org/jira/browse/OFBIZ-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen closed OFBIZ-1276. -- Resolution: Fixed Thank you. Committed in r 580446. Cleanup returnReportContactMechs.fo.ftl Key: OFBIZ-1276 URL: https://issues.apache.org/jira/browse/OFBIZ-1276 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Walter Vaughan Priority: Minor Fix For: SVN trunk, Release Branch 4.0 Attachments: returnReportContactMechs.fo.ftl.patch Clean up returnReportContactMechs.fo.ftl. Add line break after return to name Align section with line items https://issues.apache.org/jira/browse/OFBIZ-1275 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1275) Cleanup returnReportBody.fo.ftl
[ https://issues.apache.org/jira/browse/OFBIZ-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen closed OFBIZ-1275. -- Resolution: Fixed Thank you. Committed in r 580447. Cleanup returnReportBody.fo.ftl --- Key: OFBIZ-1275 URL: https://issues.apache.org/jira/browse/OFBIZ-1275 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Walter Vaughan Fix For: SVN trunk, Release Branch 4.0 Attachments: returnReportBody.fo.ftl.patch Cleans up the returnReportBody.fo.ftl section of return.pdf This section had a bounding box that wrapped 1/2 wider than content -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1273) fin account unit tests fail
fin account unit tests fail --- Key: OFBIZ-1273 URL: https://issues.apache.org/jira/browse/OFBIZ-1273 Project: OFBiz Issue Type: Bug Reporter: Si Chen Could somebody please do an $ ant run-tests and see if they also get this: [java] org.ofbiz.entity.GenericDataSourceException: SQL Exception while executing the following:INSERT INTO public.FIN_ACCOUNT (FIN_ACCOUNT_ID, FIN_ACCOUNT_TYPE_ID, FIN_ACCOUNT_NAME, FIN_ACCOUNT_CODE, FIN_ACCOUNT_PIN, CURRENCY_UOM_ID, ORGANIZATION_PARTY_ID, OWNER_PARTY_ID, POST_TO_GL_ACCOUNT_ID, FROM_DATE, THRU_DATE, IS_FROZEN, IS_REFUNDABLE, REPLENISH_PAYMENT_ID, REPLENISH_LEVEL, ACTUAL_BALANCE, AVAILABLE_BALANCE, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (ERROR: insert or update on table fin_account violates foreign key constraint finacct_type [java] Detail: Key (fin_account_type_id)=(BALANCE_ACCOUNT) is not present in table fin_account_type.) [java] org.ofbiz.entity.jdbc.SQLProcessor.executeUpdate(SQLProcessor.java:433) [java] org.ofbiz.entity.datasource.GenericDAO.singleInsert(GenericDAO.java:169) [java] org.ofbiz.entity.datasource.GenericDAO.insert(GenericDAO.java:116) [java] org.ofbiz.entity.datasource.GenericHelperDAO.create(GenericHelperDAO.java:68) [java] org.ofbiz.entity.GenericDelegator.create(GenericDelegator.java:562) [java] org.ofbiz.minilang.method.entityops.CreateValue.exec(CreateValue.java:67) [java] org.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:934) [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:571) [java] org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:108) [java] org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:90) [java] org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79) [java] org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:54) [java] org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:339) [java] org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:214) [java] org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:139) [java] org.ofbiz.accounting.test.FinAccountTests.testCreateFinAccount(FinAccountTests.java:64) [java] 2007-09-27 10:46:13,350 (main) [ TestRunContainer.java:99 :INFO ] -- testDeposit(org.ofbiz.accounting.test.FinAccountTests): The following required parameter is missing: [finAccountDeposit.finAccountId] [java] 2007-09-27 10:46:13,350 (main) [ TestRunContainer.java:99 :INFO ] -- testWithdraw(org.ofbiz.accounting.test.FinAccountTests): The following required parameter is missing: [finAccountWithdraw.finAccountId] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1265) cannot create marketing campaign: permission error
cannot create marketing campaign: permission error -- Key: OFBIZ-1265 URL: https://issues.apache.org/jira/browse/OFBIZ-1265 Project: OFBiz Issue Type: Bug Reporter: Si Chen Trying to create a marketing campaign causes the following: 2007-09-26 12:07:07,749 (http-0.0.0.0-8433-Processor2) [FlexibleStringExpander.java:358:WARN ] Could not find value in environment for the name [primaryPermission], inserting nothing. 2007-09-26 12:07:07,749 (http-0.0.0.0-8433-Processor2) [ Log.java:97 :INFO ] Checking for _CREATE 2007-09-26 12:07:07,750 (http-0.0.0.0-8433-Processor2) [FlexibleStringExpander.java:358:WARN ] Could not find value in environment for the name [altPermission], inserting nothing. 2007-09-26 12:07:07,750 (http-0.0.0.0-8433-Processor2) [ Log.java:97 :INFO ] Checking for _CREATE 2007-09-26 12:07:07,752 (http-0.0.0.0-8433-Processor2) [ TransactionUtil.java:294:WARN ] exception report -- [TransactionUtil.setRollbackOnly] Calling transaction setRollbackOnly; this stack trace shows where this is happening: Exception: java.lang.Exception Message: Error in simple-method [Basic Permission check [file:/Users/sichen/IdeaProjects/opentaps-1.0/framework/common/script/org/ofbiz/common/permission/CommonPermissionServices.xml#genericBasePermissionCheck]]: ; [Permission primaryPermission parameter missing!] stack trace --- java.lang.Exception: Error in simple-method [Basic Permission check [file:/Users/sichen/IdeaProjects/opentaps-1.0/framework/common/script/org/ofbiz/common/permission/CommonPermissionServices.xml#genericBasePermissionCheck]]: ; [Permission primaryPermission parameter missing!] org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:294) org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:241) org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:702) Is there any documentation on this new permission-service stuff? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1265) cannot create marketing campaign: permission error
[ https://issues.apache.org/jira/browse/OFBIZ-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530528 ] Si Chen commented on OFBIZ-1265: Same problem with updateMarketingCampaign cannot create marketing campaign: permission error -- Key: OFBIZ-1265 URL: https://issues.apache.org/jira/browse/OFBIZ-1265 Project: OFBiz Issue Type: Bug Reporter: Si Chen Trying to create a marketing campaign causes the following: 2007-09-26 12:07:07,749 (http-0.0.0.0-8433-Processor2) [FlexibleStringExpander.java:358:WARN ] Could not find value in environment for the name [primaryPermission], inserting nothing. 2007-09-26 12:07:07,749 (http-0.0.0.0-8433-Processor2) [ Log.java:97 :INFO ] Checking for _CREATE 2007-09-26 12:07:07,750 (http-0.0.0.0-8433-Processor2) [FlexibleStringExpander.java:358:WARN ] Could not find value in environment for the name [altPermission], inserting nothing. 2007-09-26 12:07:07,750 (http-0.0.0.0-8433-Processor2) [ Log.java:97 :INFO ] Checking for _CREATE 2007-09-26 12:07:07,752 (http-0.0.0.0-8433-Processor2) [ TransactionUtil.java:294:WARN ] exception report -- [TransactionUtil.setRollbackOnly] Calling transaction setRollbackOnly; this stack trace shows where this is happening: Exception: java.lang.Exception Message: Error in simple-method [Basic Permission check [file:/Users/sichen/IdeaProjects/opentaps-1.0/framework/common/script/org/ofbiz/common/permission/CommonPermissionServices.xml#genericBasePermissionCheck]]: ; [Permission primaryPermission parameter missing!] stack trace --- java.lang.Exception: Error in simple-method [Basic Permission check [file:/Users/sichen/IdeaProjects/opentaps-1.0/framework/common/script/org/ofbiz/common/permission/CommonPermissionServices.xml#genericBasePermissionCheck]]: ; [Permission primaryPermission parameter missing!] org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:294) org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:241) org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:702) Is there any documentation on this new permission-service stuff? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
