Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Nicolas Malin

Thanks for your return.

Finally we have no big issue to release it now on the jira, I did it to
didn't forget and realize it in three months :)

Nicolas

On 03/01/2022 11:40, Jacopo Cappellato wrote:
> Thank you Nicolas!
> (BTW it is fine to mark as released in Jira the version 18.12.05 since it
> is now official... however we have to wait some time before we announce and
> update our download page because we need some time to make sure all mirrors
> around the World have received the release files).
>
> Jacopo
>
> On Mon, Jan 3, 2022 at 11:10 AM Nicolas Malin 
> wrote:
>
>> On 03/01/2022 10:31, Nicolas Malin wrote:
>>> Jacopo, I can publish to 18.12.05 on jira and open the 18.12.06 if it's
>>> ok for you
>> I opened the 18.12.06 and I wait your official announce to release the
>> 18.12.05 (and update the date)
>>
>> Cheers,
>> Nicolas
>>



Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Jacopo Cappellato
Thank you Nicolas!
(BTW it is fine to mark as released in Jira the version 18.12.05 since it
is now official... however we have to wait some time before we announce and
update our download page because we need some time to make sure all mirrors
around the World have received the release files).

Jacopo

On Mon, Jan 3, 2022 at 11:10 AM Nicolas Malin 
wrote:

>
> On 03/01/2022 10:31, Nicolas Malin wrote:
> > Jacopo, I can publish to 18.12.05 on jira and open the 18.12.06 if it's
> > ok for you
> I opened the 18.12.06 and I wait your official announce to release the
> 18.12.05 (and update the date)
>
> Cheers,
> Nicolas
>


Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Nicolas Malin


On 03/01/2022 10:31, Nicolas Malin wrote:
> Jacopo, I can publish to 18.12.05 on jira and open the 18.12.06 if it's
> ok for you
I opened the 18.12.06 and I wait your official announce to release the
18.12.05 (and update the date)

Cheers,
Nicolas


Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Nicolas Malin


On 03/01/2022 09:52, Nicolas Malin wrote:
> I detected with log test, that the screen xml handler is down. 
> On https://localhost:8443/webtools/control/WebtoolsLayoutDemoXml :
> ***
>freemarker.core._MiscTemplateException: Macro "renderContainerEnd" has no 
> parameter with name "type"
> ***
Fixed on release18.12 and trunk by OFBIZ-12478 [1]

Jacopo, I can publish to 18.12.05 on jira and open the 18.12.06 if it's
ok for you

Cheers,
Nicolas

[1] https://issues.apache.org/jira/browse/OFBIZ-12478



Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Nicolas Malin
+1

---
Keys Ok
Test Ok

Under OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.292-b10, mixed
mode),  Debian 11.1

I detected with log test, that the screen xml handler is down. 
On https://localhost:8443/webtools/control/WebtoolsLayoutDemoXml :
***
   freemarker.core._MiscTemplateException: Macro "renderContainerEnd" has no 
parameter with name "type"
***

But is also present on the 18.12.04 so no reason to not release this.

Nicoals

On 02/01/2022 12:29, Jacopo Cappellato wrote:
> This is the second vote thread to release a new bug fix release for the
> release18.12 branch. This new release, "Apache OFBiz 18.12.05"
> supersedes all the previous releases from the same branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
> * apache-ofbiz-18.12.05.zip
> * KEYS: text file with keys
> * apache-ofbiz-18.12.05.zip.asc: the detached signature file
> * apache-ofbiz-18.12.05.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for
> instructions on testing the signatures see [*]).
>
> Vote:
>
> [ +1] release as Apache OFBiz 18.12.05
> [ -1] do not release
>
> For more details about this process please read [**].
> [*]
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz#ReleaseManagementGuideforOFBiz-Votingonarelease
> [**] http://www.apache.org/foundation/voting.html
>



Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Gil Portenseigne
+1,

Verifying files...
sha check of file: apache-ofbiz-18.12.05.zip
Using sha file: apache-ofbiz-18.12.05.zip.sha512
apache-ofbiz-18.12.05.zip: F7952ED5 C794357F E730C7DE 404B0B8B 7A123A89 
9DA7A1C1 4D0136ED 64D6FAA3 7645018E 9EDE93FB 88FC27A3 D718DA64 E8636541 
334583ED 606F5516 6D653B2C
apache-ofbiz-18.12.05.zip: F7952ED5 C794357F E730C7DE 404B0B8B 7A123A89 
9DA7A1C1 4D0136ED 64D6FAA3 7645018E 9EDE93FB 88FC27A3 D718DA64 E8636541 
334583ED 606F5516 6D653B2C
sha checksum OK

PGP sigs and integration test ok.

Thanks,

Gil

On Sun, Jan 02, 2022 at 12:29:37PM +0100, Jacopo Cappellato wrote:
> This is the second vote thread to release a new bug fix release for the
> release18.12 branch. This new release, "Apache OFBiz 18.12.05"
> supersedes all the previous releases from the same branch.
> 
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
> 
> and are:
> * apache-ofbiz-18.12.05.zip
> * KEYS: text file with keys
> * apache-ofbiz-18.12.05.zip.asc: the detached signature file
> * apache-ofbiz-18.12.05.zip.sha512: checksum file
> 
> Please download and test the zip file and its signatures (for
> instructions on testing the signatures see [*]).
> 
> Vote:
> 
> [ +1] release as Apache OFBiz 18.12.05
> [ -1] do not release
> 
> For more details about this process please read [**].
> [*]
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz#ReleaseManagementGuideforOFBiz-Votingonarelease
> [**] http://www.apache.org/foundation/voting.html


signature.asc
Description: PGP signature


Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Jacopo Cappellato
+1

Jacopo


On Sun, Jan 2, 2022 at 12:29 PM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> This is the second vote thread to release a new bug fix release for the
> release18.12 branch. This new release, "Apache OFBiz 18.12.05"
> supersedes all the previous releases from the same branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
> * apache-ofbiz-18.12.05.zip
> * KEYS: text file with keys
> * apache-ofbiz-18.12.05.zip.asc: the detached signature file
> * apache-ofbiz-18.12.05.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for
> instructions on testing the signatures see [*]).
>
> Vote:
>
> [ +1] release as Apache OFBiz 18.12.05
> [ -1] do not release
>
> For more details about this process please read [**].
> [*]
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz#ReleaseManagementGuideforOFBiz-Votingonarelease
> [**] http://www.apache.org/foundation/voting.html
>


Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-02 Thread Michael Brohl

+1

Processing files for release: apache-ofbiz-18.12.05...
Downloading files for apache-ofbiz-18.12.05.zip...
Done!

Verifying files...
sha check of file: apache-ofbiz-18.12.05.zip
Using sha file: apache-ofbiz-18.12.05.zip.sha512
apache-ofbiz-18.12.05.zip: F7952ED5 C794357F E730C7DE 404B0B8B 7A123A89 
9DA7A1C1 4D0136ED 64D6FAA3 7645018E 9EDE93FB 88FC27A3 D718DA64 E8636541 
334583ED 606F5516 6D653B2C
apache-ofbiz-18.12.05.zip: F7952ED5 C794357F E730C7DE 404B0B8B 7A123A89 
9DA7A1C1 4D0136ED 64D6FAA3 7645018E 9EDE93FB 88FC27A3 D718DA64 E8636541 
334583ED 606F5516 6D653B2C

sha checksum OK

GPG verification output

Unpacking release file archive apache-ofbiz-18.12.05.zip...
...

Initializing Gradle wrapper...
 === Prepare operation ===
/Users/mbrohl/Projects/apache-ofbiz/dist/apache-ofbiz-18.12.05/gradle/wrapper/gradle-wrapper.jar 
not found, we download it

 === Download gradle-wrapper.jar ===
 === Download gradle-wrapper.properties ===
 === Control downloaded files ===
gradle/wrapper/gradle-wrapper.jar: OK
gradle/wrapper/gradle-wrapper.properties: OK
gradlew: OK

Running tests...
...
BUILD SUCCESSFUL in 4m 32s
27 actionable tasks: 22 executed, 5 up-to-date
Done processing files for release apache-ofbiz-18.12.05

Thanks,

Michael Brohl

ecomify GmbH - www.ecomify.de


Am 02.01.22 um 12:29 schrieb Jacopo Cappellato:


This is the second vote thread to release a new bug fix release for the
release18.12 branch. This new release, "Apache OFBiz 18.12.05"
supersedes all the previous releases from the same branch.

The release files can be downloaded from here:
https://dist.apache.org/repos/dist/dev/ofbiz/

and are:
* apache-ofbiz-18.12.05.zip
* KEYS: text file with keys
* apache-ofbiz-18.12.05.zip.asc: the detached signature file
* apache-ofbiz-18.12.05.zip.sha512: checksum file

Please download and test the zip file and its signatures (for
instructions on testing the signatures see [*]).

Vote:

[ +1] release as Apache OFBiz 18.12.05
[ -1] do not release

For more details about this process please read [**].
[*]
https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz#ReleaseManagementGuideforOFBiz-Votingonarelease
[**] http://www.apache.org/foundation/voting.html



Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-02 Thread Jacques Le Roux

+1

$ ./verify-ofbiz-release.sh apache-ofbiz-18.12.05.zip
sha check of file: apache-ofbiz-18.12.05.zip
Using sha file: apache-ofbiz-18.12.05.zip.sha512
apache-ofbiz-18.12.05.zip: F7952ED5 C794357F E730C7DE 404B0B8B 7A123A89 9DA7A1C1 4D0136ED 64D6FAA3 7645018E 9EDE93FB 88FC27A3 D718DA64 E8636541 
334583ED 606F5516 6D653B2C
apache-ofbiz-18.12.05.zip: F7952ED5 C794357F E730C7DE 404B0B8B 7A123A89 9DA7A1C1 4D0136ED 64D6FAA3 7645018E 9EDE93FB 88FC27A3 D718DA64 E8636541 
334583ED 606F5516 6D653B2C

sha checksum OK

GPG verification output
gpg: Signature made Sun Jan  2 11:57:07 2022
gpg:    using RSA key 7A580908847AF9E0
gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY) 
"

Tests and UIs OK

Jacques

Le 02/01/2022 à 12:29, Jacopo Cappellato a écrit :

This is the second vote thread to release a new bug fix release for the
release18.12 branch. This new release, "Apache OFBiz 18.12.05"
supersedes all the previous releases from the same branch.

The release files can be downloaded from here:
https://dist.apache.org/repos/dist/dev/ofbiz/

and are:
* apache-ofbiz-18.12.05.zip
* KEYS: text file with keys
* apache-ofbiz-18.12.05.zip.asc: the detached signature file
* apache-ofbiz-18.12.05.zip.sha512: checksum file

Please download and test the zip file and its signatures (for
instructions on testing the signatures see [*]).

Vote:

[ +1] release as Apache OFBiz 18.12.05
[ -1] do not release

For more details about this process please read [**].
[*]
https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz#ReleaseManagementGuideforOFBiz-Votingonarelease
[**] http://www.apache.org/foundation/voting.html




Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05

2022-01-02 Thread Jacopo Cappellato
This vote is now canceled (see Jacques' message).

Jacopo

On Sun, Jan 2, 2022 at 8:38 AM Jacopo Cappellato <
jacopo.cappell...@gmail.com> wrote:

> This is the vote thread to release a new bug fix release for the
> release18.12 branch. This new release, "Apache OFBiz 18.12.05"
> supersedes all the previous releases from the same branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
> * apache-ofbiz-18.12.05.zip
> * KEYS: text file with keys
> * apache-ofbiz-18.12.05.zip.asc: the detached signature file
> * apache-ofbiz-18.12.05.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for
> instructions on testing the signatures see [*]).
>
> Vote:
>
> [ +1] release as Apache OFBiz 18.12.05
> [ -1] do not release
>
> For more details about this process please read [**].
> [*]
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz#ReleaseManagementGuideforOFBiz-Votingonarelease
> [**] http://www.apache.org/foundation/voting.html
>


Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05

2022-01-02 Thread Jacques Le Roux

The problem was already fixed in trunk by allowing all types of EOL, ie using
NewlineAtEndOfFile value="lf_cr_crlf"

I just backported to 18.12

Le 02/01/2022 à 10:14, Jacques Le Roux a écrit :

Thanks for waiting, it's OK now (I crossed another Windows quirk due to BOM* 
while wanting to speed using my external editor, Scite)

* https://en.wikipedia.org/wiki/Byte_order_mark

Le 02/01/2022 à 09:49, Jacques Le Roux a écrit :

Thanks Jacopo,

-1

Because of Windows, for "CheckStyleMain Task is Failing in 18.12.04" (OFBIZ-12473), I recently put 39638 in checkstyle maxErrors. That's not 
enough. I guess since then new lines have been added and every new lines is a checkstyle issue on Windows. Note that fortunately we have no longer 
any error on Trunk. But I guess the same issue will appears when we will release our 1st 20.01. I'm not sure why yet it works before releasing and 
not after. I guess because of the format (LF for *nix only vs CR/LF on Win).


I'll rework that to find a definitive solution. I hope it will be easy to simply remove the EOL check, not sure yet. For now I'll simply put 5 
in maxErrors in 18.12 branch.


Sorry for that, I'll let you know when ready ASAP

Jacques


Le 02/01/2022 à 08:38, Jacopo Cappellato a écrit :

This is the vote thread to release a new bug fix release for the
release18.12 branch. This new release, "Apache OFBiz 18.12.05"
supersedes all the previous releases from the same branch.

The release files can be downloaded from here:
https://dist.apache.org/repos/dist/dev/ofbiz/

and are:
* apache-ofbiz-18.12.05.zip
* KEYS: text file with keys
* apache-ofbiz-18.12.05.zip.asc: the detached signature file
* apache-ofbiz-18.12.05.zip.sha512: checksum file

Please download and test the zip file and its signatures (for
instructions on testing the signatures see [*]).

Vote:

[ +1] release as Apache OFBiz 18.12.05
[ -1] do not release

For more details about this process please read [**].
[*]
https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz#ReleaseManagementGuideforOFBiz-Votingonarelease
[**] http://www.apache.org/foundation/voting.html




Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05

2022-01-02 Thread Jacques Le Roux

Thanks for waiting, it's OK now (I crossed another Windows quirk due to BOM* 
while wanting to speed using my external editor, Scite)

* https://en.wikipedia.org/wiki/Byte_order_mark

Le 02/01/2022 à 09:49, Jacques Le Roux a écrit :

Thanks Jacopo,

-1

Because of Windows, for "CheckStyleMain Task is Failing in 18.12.04" (OFBIZ-12473), I recently put 39638 in checkstyle maxErrors. That's not enough. 
I guess since then new lines have been added and every new lines is a checkstyle issue on Windows. Note that fortunately we have no longer any error 
on Trunk. But I guess the same issue will appears when we will release our 1st 20.01. I'm not sure why yet it works before releasing and not after. 
I guess because of the format (LF for *nix only vs CR/LF on Win).


I'll rework that to find a definitive solution. I hope it will be easy to simply remove the EOL check, not sure yet. For now I'll simply put 5 
in maxErrors in 18.12 branch.


Sorry for that, I'll let you know when ready ASAP

Jacques


Le 02/01/2022 à 08:38, Jacopo Cappellato a écrit :

This is the vote thread to release a new bug fix release for the
release18.12 branch. This new release, "Apache OFBiz 18.12.05"
supersedes all the previous releases from the same branch.

The release files can be downloaded from here:
https://dist.apache.org/repos/dist/dev/ofbiz/

and are:
* apache-ofbiz-18.12.05.zip
* KEYS: text file with keys
* apache-ofbiz-18.12.05.zip.asc: the detached signature file
* apache-ofbiz-18.12.05.zip.sha512: checksum file

Please download and test the zip file and its signatures (for
instructions on testing the signatures see [*]).

Vote:

[ +1] release as Apache OFBiz 18.12.05
[ -1] do not release

For more details about this process please read [**].
[*]
https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz#ReleaseManagementGuideforOFBiz-Votingonarelease
[**] http://www.apache.org/foundation/voting.html




Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05

2022-01-02 Thread Jacques Le Roux

Thanks Jacopo,

-1

Because of Windows, for "CheckStyleMain Task is Failing in 18.12.04" (OFBIZ-12473), I recently put 39638 in checkstyle maxErrors. That's not enough. I 
guess since then new lines have been added and every new lines is a checkstyle issue on Windows. Note that fortunately we have no longer any error on 
Trunk. But I guess the same issue will appears when we will release our 1st 20.01. I'm not sure why yet it works before releasing and not after. I 
guess because of the format (LF for *nix only vs CR/LF on Win).


I'll rework that to find a definitive solution. I hope it will be easy to simply remove the EOL check, not sure yet. For now I'll simply put 5 in 
maxErrors in 18.12 branch.


Sorry for that, I'll let you know when ready ASAP

Jacques


Le 02/01/2022 à 08:38, Jacopo Cappellato a écrit :

This is the vote thread to release a new bug fix release for the
release18.12 branch. This new release, "Apache OFBiz 18.12.05"
supersedes all the previous releases from the same branch.

The release files can be downloaded from here:
https://dist.apache.org/repos/dist/dev/ofbiz/

and are:
* apache-ofbiz-18.12.05.zip
* KEYS: text file with keys
* apache-ofbiz-18.12.05.zip.asc: the detached signature file
* apache-ofbiz-18.12.05.zip.sha512: checksum file

Please download and test the zip file and its signatures (for
instructions on testing the signatures see [*]).

Vote:

[ +1] release as Apache OFBiz 18.12.05
[ -1] do not release

For more details about this process please read [**].
[*]
https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz#ReleaseManagementGuideforOFBiz-Votingonarelease
[**] http://www.apache.org/foundation/voting.html