Re: Reserved words
Thanks Michael for the fast reaction. For sure, each database has its own set of reserved words, and there will be commonalities across databases. Also the list of reserved words can change over time with each new version of the database used. And yet, hard coded the solution dictates a one-size-fits-all. Which doesn't hold merit. While many will opt for MySQL as the backend data store, some will make use of the choice offered by the project (PostgreSQL, SQL Server, etc). And the adopter should be able to customise the list of reserved words in accordance with the requirements related to his choice, without having to go through an implementation process of changes to the code. IMO, it would be better if the list of reserved words were to be pulled from the code and captures in a configuration file. Best regards, Pierre Smits ORRTIZ.COM <http://www.orrtiz.com> OFBiz based solutions & services On Thu, Oct 7, 2021 at 5:40 PM Michael Brohl wrote: > Correcting myself: only DATABASE is a reserved name in MySQL, the other > two are keywords. > > Michael Brohl > > ecomify GmbH - www.ecomify.de > > > Am 07.10.21 um 17:28 schrieb Michael Brohl: > > Hi Pierre, > > > > those words are reserved names in different databases, please check > > yourself: > > > https://stackoverflow.com/questions/8339396/all-reserved-words-of-every-dbms#8341855 > > > > To me, the list seems pretty sophisticated for a variety of databases. > > It is not meant to be used only for a specific database. > > > > For MySQL, all three words are reserved. > > > > Regards, > > > > Michael Brohl > > > > ecomify GmbH - www.ecomify.de > > > > > > Am 07.10.21 um 11:06 schrieb Pierre Smits: > >> Hi all, > >> > >> While working on a solution that involves bringing existing tables > >> from a > >> postgresql database into the entity group and model definitions, I > >> noticed > >> that some of the column definitions were not acceptable by OFBiz and > >> thus > >> entities would not get created in the underlying OFBiz database. > >> > >> I found in ModelEntityChecker.java has a list of reserved words, > >> including > >> words like: > >> > >> - password > >> - database > >> - type > >> > >> Many of the words listed there are not reserved according to [1] > >> > >> Does anyone know where these reserved words came from and when they got > >> into the java file? > >> It seems to me that a big brush was used to get to the list, and not > >> much > >> consideration was given to the context (variations in database > >> applicability). > >> > >> What are your thoughts on correcting this? > >> > >> > >> https://www.postgresql.org/docs/8.1/sql-keywords-appendix.html > >> > >> Best regards, > >> Pierre Smits > >> > >> ORRTIZ.COM <http://www.orrtiz.com> > >> OFBiz based solutions & services > >> >
Re: Reserved words
Correcting myself: only DATABASE is a reserved name in MySQL, the other two are keywords. Michael Brohl ecomify GmbH - www.ecomify.de Am 07.10.21 um 17:28 schrieb Michael Brohl: Hi Pierre, those words are reserved names in different databases, please check yourself: https://stackoverflow.com/questions/8339396/all-reserved-words-of-every-dbms#8341855 To me, the list seems pretty sophisticated for a variety of databases. It is not meant to be used only for a specific database. For MySQL, all three words are reserved. Regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 07.10.21 um 11:06 schrieb Pierre Smits: Hi all, While working on a solution that involves bringing existing tables from a postgresql database into the entity group and model definitions, I noticed that some of the column definitions were not acceptable by OFBiz and thus entities would not get created in the underlying OFBiz database. I found in ModelEntityChecker.java has a list of reserved words, including words like: - password - database - type Many of the words listed there are not reserved according to [1] Does anyone know where these reserved words came from and when they got into the java file? It seems to me that a big brush was used to get to the list, and not much consideration was given to the context (variations in database applicability). What are your thoughts on correcting this? https://www.postgresql.org/docs/8.1/sql-keywords-appendix.html Best regards, Pierre Smits ORRTIZ.COM <http://www.orrtiz.com> OFBiz based solutions & services
Re: Reserved words
Hi Pierre, those words are reserved names in different databases, please check yourself: https://stackoverflow.com/questions/8339396/all-reserved-words-of-every-dbms#8341855 To me, the list seems pretty sophisticated for a variety of databases. It is not meant to be used only for a specific database. For MySQL, all three words are reserved. Regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 07.10.21 um 11:06 schrieb Pierre Smits: Hi all, While working on a solution that involves bringing existing tables from a postgresql database into the entity group and model definitions, I noticed that some of the column definitions were not acceptable by OFBiz and thus entities would not get created in the underlying OFBiz database. I found in ModelEntityChecker.java has a list of reserved words, including words like: - password - database - type Many of the words listed there are not reserved according to [1] Does anyone know where these reserved words came from and when they got into the java file? It seems to me that a big brush was used to get to the list, and not much consideration was given to the context (variations in database applicability). What are your thoughts on correcting this? https://www.postgresql.org/docs/8.1/sql-keywords-appendix.html Best regards, Pierre Smits ORRTIZ.COM <http://www.orrtiz.com> OFBiz based solutions & services
Reserved words
Hi all, While working on a solution that involves bringing existing tables from a postgresql database into the entity group and model definitions, I noticed that some of the column definitions were not acceptable by OFBiz and thus entities would not get created in the underlying OFBiz database. I found in ModelEntityChecker.java has a list of reserved words, including words like: - password - database - type Many of the words listed there are not reserved according to [1] Does anyone know where these reserved words came from and when they got into the java file? It seems to me that a big brush was used to get to the list, and not much consideration was given to the context (variations in database applicability). What are your thoughts on correcting this? https://www.postgresql.org/docs/8.1/sql-keywords-appendix.html Best regards, Pierre Smits ORRTIZ.COM <http://www.orrtiz.com> OFBiz based solutions & services
[jira] Commented: (OFBIZ-2888) Reserved words used for field names in PaymentGatewayOrbital
[ https://issues.apache.org/jira/browse/OFBIZ-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772530#action_12772530 ] Jacques Le Roux commented on OFBIZ-2888: Thanks Ashish, Not today. Actually I'm either tired or overexcited, so today I'm overexcited. :) I'm not sure how I did this wrong in fact, fast, fast, fast... :D > Reserved words used for field names in PaymentGatewayOrbital > > > Key: OFBIZ-2888 > URL: https://issues.apache.org/jira/browse/OFBIZ-2888 > Project: OFBiz > Issue Type: Bug >Affects Versions: SVN trunk > Environment: Linux, Java 1.6, Postgresql 8.3 with driver > postgresql-8.3-604.jdbc4.jar >Reporter: Anne Jessel >Assignee: Ashish Vijaywargiya >Priority: Minor > Fix For: SVN trunk > > > On starting Rev 809782 of trunk, I see the following warnings: > 2009-09-02 09:05:03,747 (main) [ DelegatorImpl.java:176:WARN ] =-=-=-=-= > Found 2 warnings when checking the entity definitions: > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name PASSWORD of entity PaymentGatewayOrbital is a > reserved word. > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name CLASS of entity PaymentGatewayOrbital is a reserved > word. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2888) Reserved words used for field names in PaymentGatewayOrbital
[ https://issues.apache.org/jira/browse/OFBIZ-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772526#action_12772526 ] Ashish Vijaywargiya commented on OFBIZ-2888: Correction in previous comment: Fixed at r831899. Jacques *Tired* ;o) ? -- Ashish > Reserved words used for field names in PaymentGatewayOrbital > > > Key: OFBIZ-2888 > URL: https://issues.apache.org/jira/browse/OFBIZ-2888 > Project: OFBiz > Issue Type: Bug >Affects Versions: SVN trunk > Environment: Linux, Java 1.6, Postgresql 8.3 with driver > postgresql-8.3-604.jdbc4.jar >Reporter: Anne Jessel >Assignee: Ashish Vijaywargiya >Priority: Minor > Fix For: SVN trunk > > > On starting Rev 809782 of trunk, I see the following warnings: > 2009-09-02 09:05:03,747 (main) [ DelegatorImpl.java:176:WARN ] =-=-=-=-= > Found 2 warnings when checking the entity definitions: > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name PASSWORD of entity PaymentGatewayOrbital is a > reserved word. > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name CLASS of entity PaymentGatewayOrbital is a reserved > word. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2888) Reserved words used for field names in PaymentGatewayOrbital
[ https://issues.apache.org/jira/browse/OFBIZ-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2888. -- Resolution: Fixed Fix Version/s: SVN trunk Fixed at r749959 > Reserved words used for field names in PaymentGatewayOrbital > > > Key: OFBIZ-2888 > URL: https://issues.apache.org/jira/browse/OFBIZ-2888 > Project: OFBiz > Issue Type: Bug >Affects Versions: SVN trunk > Environment: Linux, Java 1.6, Postgresql 8.3 with driver > postgresql-8.3-604.jdbc4.jar >Reporter: Anne Jessel >Assignee: Ashish Vijaywargiya >Priority: Minor > Fix For: SVN trunk > > > On starting Rev 809782 of trunk, I see the following warnings: > 2009-09-02 09:05:03,747 (main) [ DelegatorImpl.java:176:WARN ] =-=-=-=-= > Found 2 warnings when checking the entity definitions: > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name PASSWORD of entity PaymentGatewayOrbital is a > reserved word. > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name CLASS of entity PaymentGatewayOrbital is a reserved > word. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2888) Reserved words used for field names in PaymentGatewayOrbital
[ https://issues.apache.org/jira/browse/OFBIZ-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769954#action_12769954 ] Ashish Vijaywargiya commented on OFBIZ-2888: Somehow I have missed this jira issue and your comment Jacques. I will take care of this issue in this week. -- Ashish > Reserved words used for field names in PaymentGatewayOrbital > > > Key: OFBIZ-2888 > URL: https://issues.apache.org/jira/browse/OFBIZ-2888 > Project: OFBiz > Issue Type: Bug >Affects Versions: SVN trunk > Environment: Linux, Java 1.6, Postgresql 8.3 with driver > postgresql-8.3-604.jdbc4.jar >Reporter: Anne Jessel >Assignee: Ashish Vijaywargiya >Priority: Minor > > On starting Rev 809782 of trunk, I see the following warnings: > 2009-09-02 09:05:03,747 (main) [ DelegatorImpl.java:176:WARN ] =-=-=-=-= > Found 2 warnings when checking the entity definitions: > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name PASSWORD of entity PaymentGatewayOrbital is a > reserved word. > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name CLASS of entity PaymentGatewayOrbital is a reserved > word. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2888) Reserved words used for field names in PaymentGatewayOrbital
[ https://issues.apache.org/jira/browse/OFBIZ-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-2888: -- Assignee: Ashish Vijaywargiya > Reserved words used for field names in PaymentGatewayOrbital > > > Key: OFBIZ-2888 > URL: https://issues.apache.org/jira/browse/OFBIZ-2888 > Project: OFBiz > Issue Type: Bug >Affects Versions: SVN trunk > Environment: Linux, Java 1.6, Postgresql 8.3 with driver > postgresql-8.3-604.jdbc4.jar >Reporter: Anne Jessel >Assignee: Ashish Vijaywargiya >Priority: Minor > > On starting Rev 809782 of trunk, I see the following warnings: > 2009-09-02 09:05:03,747 (main) [ DelegatorImpl.java:176:WARN ] =-=-=-=-= > Found 2 warnings when checking the entity definitions: > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name PASSWORD of entity PaymentGatewayOrbital is a > reserved word. > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name CLASS of entity PaymentGatewayOrbital is a reserved > word. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2888) Reserved words used for field names in PaymentGatewayOrbital
[ https://issues.apache.org/jira/browse/OFBIZ-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769872#action_12769872 ] Jacques Le Roux commented on OFBIZ-2888: Anybody cares ? Is anybody using this in production ? Else I will simply change the fields names, this is not secure... > Reserved words used for field names in PaymentGatewayOrbital > > > Key: OFBIZ-2888 > URL: https://issues.apache.org/jira/browse/OFBIZ-2888 > Project: OFBiz > Issue Type: Bug >Affects Versions: SVN trunk > Environment: Linux, Java 1.6, Postgresql 8.3 with driver > postgresql-8.3-604.jdbc4.jar >Reporter: Anne Jessel >Priority: Minor > > On starting Rev 809782 of trunk, I see the following warnings: > 2009-09-02 09:05:03,747 (main) [ DelegatorImpl.java:176:WARN ] =-=-=-=-= > Found 2 warnings when checking the entity definitions: > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name PASSWORD of entity PaymentGatewayOrbital is a > reserved word. > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name CLASS of entity PaymentGatewayOrbital is a reserved > word. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2888) Reserved words used for field names in PaymentGatewayOrbital
[ https://issues.apache.org/jira/browse/OFBIZ-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759014#action_12759014 ] Jacques Le Roux commented on OFBIZ-2888: Bump! > Reserved words used for field names in PaymentGatewayOrbital > > > Key: OFBIZ-2888 > URL: https://issues.apache.org/jira/browse/OFBIZ-2888 > Project: OFBiz > Issue Type: Bug >Affects Versions: SVN trunk > Environment: Linux, Java 1.6, Postgresql 8.3 with driver > postgresql-8.3-604.jdbc4.jar >Reporter: Anne Jessel >Priority: Minor > > On starting Rev 809782 of trunk, I see the following warnings: > 2009-09-02 09:05:03,747 (main) [ DelegatorImpl.java:176:WARN ] =-=-=-=-= > Found 2 warnings when checking the entity definitions: > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name PASSWORD of entity PaymentGatewayOrbital is a > reserved word. > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name CLASS of entity PaymentGatewayOrbital is a reserved > word. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2888) Reserved words used for field names in PaymentGatewayOrbital
[ https://issues.apache.org/jira/browse/OFBIZ-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751016#action_12751016 ] Jacques Le Roux commented on OFBIZ-2888: Hi Ashish, Could you please have a look at it (related to r806643) Thanks > Reserved words used for field names in PaymentGatewayOrbital > > > Key: OFBIZ-2888 > URL: https://issues.apache.org/jira/browse/OFBIZ-2888 > Project: OFBiz > Issue Type: Bug >Affects Versions: SVN trunk > Environment: Linux, Java 1.6, Postgresql 8.3 with driver > postgresql-8.3-604.jdbc4.jar >Reporter: Anne Jessel >Priority: Minor > > On starting Rev 809782 of trunk, I see the following warnings: > 2009-09-02 09:05:03,747 (main) [ DelegatorImpl.java:176:WARN ] =-=-=-=-= > Found 2 warnings when checking the entity definitions: > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name PASSWORD of entity PaymentGatewayOrbital is a > reserved word. > 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] > [FieldNameRW] Column name CLASS of entity PaymentGatewayOrbital is a reserved > word. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2888) Reserved words used for field names in PaymentGatewayOrbital
Reserved words used for field names in PaymentGatewayOrbital Key: OFBIZ-2888 URL: https://issues.apache.org/jira/browse/OFBIZ-2888 Project: OFBiz Issue Type: Bug Affects Versions: SVN trunk Environment: Linux, Java 1.6, Postgresql 8.3 with driver postgresql-8.3-604.jdbc4.jar Reporter: Anne Jessel Priority: Minor On starting Rev 809782 of trunk, I see the following warnings: 2009-09-02 09:05:03,747 (main) [ DelegatorImpl.java:176:WARN ] =-=-=-=-= Found 2 warnings when checking the entity definitions: 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] [FieldNameRW] Column name PASSWORD of entity PaymentGatewayOrbital is a reserved word. 2009-09-02 09:05:03,748 (main) [ DelegatorImpl.java:178:WARN ] [FieldNameRW] Column name CLASS of entity PaymentGatewayOrbital is a reserved word. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
