Re: Review Request: RemoteSiteFile doesn't always set RemoteSite
On July 27, 2012, 4:31 a.m., Chris Mattmann wrote: trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/ProtocolHandler.java, line 60 https://reviews.apache.org/r/6166/diff/1/?file=130080#file130080line60 I think making these vars final is orthogonal, but certainly an improvement ;) ya i've setup eclipse to auto-remove trailing whitespace and mark final variables which should be final... does kinda clutter the patch, but in the long run those all this changes will automatically be gradually fixed and won't be orthogonal changes in patches anymore :) On July 27, 2012, 4:31 a.m., Chris Mattmann wrote: trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java, line 57 https://reviews.apache.org/r/6166/diff/1/?file=130083#file130083line57 I don't see a Maven update here, do we need to add the google.common.base dep? ya... must be picking it up from one the of the deps... i added the following to the pom.xml on my client: dependency groupIdcom.google.guava/groupId artifactIdguava/artifactId version10.0.1/version /dependency - brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6166/#review9525 --- On July 27, 2012, 12:15 a.m., brian Foster wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6166/ --- (Updated July 27, 2012, 12:15 a.m.) Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Description --- Causes NullPointerException: SEVERE: Failed to finish downloading per property files /home/yhkang/oodt/cas-pushpull/etc/examples/DirStructXmlParserFiles/RTG_SST.xml : null java.lang.NullPointerException at org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.validate(FileRetrievalSystem.java:367) at org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.changeToDir(FileRetrievalSystem.java:311) at org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.changeToDir(FileRetrievalSystem.java:300) at org.apache.oodt.cas.pushpull.retrievalmethod.RemoteCrawler.processPropFile(RemoteCrawler.java:103) at org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.retrieveFiles(RetrievalSetup.java:109) at org.apache.oodt.cas.pushpull.daemon.Daemon$1.run(Daemon.java:218) at java.lang.Thread.run(Thread.java:662) This addresses bug OODT-476. https://issues.apache.org/jira/browse/OODT-476 Diffs - trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/ProtocolHandler.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/RemoteSiteFile.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalmethod/RemoteCrawler.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/RetrievalSetup.java 1365306 Diff: https://reviews.apache.org/r/6166/diff/ Testing --- Ran test provided by YunHee Thanks, brian Foster
Re: Review Request: RemoteSiteFile doesn't always set RemoteSite
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6166/ --- (Updated July 27, 2012, 12:15 a.m.) Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Description --- Causes NullPointerException: SEVERE: Failed to finish downloading per property files /home/yhkang/oodt/cas-pushpull/etc/examples/DirStructXmlParserFiles/RTG_SST.xml : null java.lang.NullPointerException at org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.validate(FileRetrievalSystem.java:367) at org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.changeToDir(FileRetrievalSystem.java:311) at org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.changeToDir(FileRetrievalSystem.java:300) at org.apache.oodt.cas.pushpull.retrievalmethod.RemoteCrawler.processPropFile(RemoteCrawler.java:103) at org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.retrieveFiles(RetrievalSetup.java:109) at org.apache.oodt.cas.pushpull.daemon.Daemon$1.run(Daemon.java:218) at java.lang.Thread.run(Thread.java:662) This addresses bug OODT-476. https://issues.apache.org/jira/browse/OODT-476 Diffs - trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/ProtocolHandler.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/RemoteSiteFile.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalmethod/RemoteCrawler.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/RetrievalSetup.java 1365306 Diff: https://reviews.apache.org/r/6166/diff/ Testing --- Ran test provided by YunHee Thanks, brian Foster
Re: Review Request: RemoteSiteFile doesn't always set RemoteSite
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6166/#review9526 --- I think we need to add the pom.xml dep update for the Google Preconditions code. LGTM after that. - Chris Mattmann On July 27, 2012, 12:15 a.m., brian Foster wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6166/ --- (Updated July 27, 2012, 12:15 a.m.) Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Description --- Causes NullPointerException: SEVERE: Failed to finish downloading per property files /home/yhkang/oodt/cas-pushpull/etc/examples/DirStructXmlParserFiles/RTG_SST.xml : null java.lang.NullPointerException at org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.validate(FileRetrievalSystem.java:367) at org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.changeToDir(FileRetrievalSystem.java:311) at org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.changeToDir(FileRetrievalSystem.java:300) at org.apache.oodt.cas.pushpull.retrievalmethod.RemoteCrawler.processPropFile(RemoteCrawler.java:103) at org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.retrieveFiles(RetrievalSetup.java:109) at org.apache.oodt.cas.pushpull.daemon.Daemon$1.run(Daemon.java:218) at java.lang.Thread.run(Thread.java:662) This addresses bug OODT-476. https://issues.apache.org/jira/browse/OODT-476 Diffs - trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/ProtocolHandler.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/RemoteSiteFile.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalmethod/RemoteCrawler.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/RetrievalSetup.java 1365306 Diff: https://reviews.apache.org/r/6166/diff/ Testing --- Ran test provided by YunHee Thanks, brian Foster
Re: Review Request: RemoteSiteFile doesn't always set RemoteSite
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6166/#review9525 --- trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/ProtocolHandler.java https://reviews.apache.org/r/6166/#comment20370 I think making these vars final is orthogonal, but certainly an improvement ;) trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java https://reviews.apache.org/r/6166/#comment20372 I don't see a Maven update here, do we need to add the google.common.base dep? trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/RetrievalSetup.java https://reviews.apache.org/r/6166/#comment20371 orthogonal again with finals, but OK :) - Chris Mattmann On July 27, 2012, 12:15 a.m., brian Foster wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6166/ --- (Updated July 27, 2012, 12:15 a.m.) Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Description --- Causes NullPointerException: SEVERE: Failed to finish downloading per property files /home/yhkang/oodt/cas-pushpull/etc/examples/DirStructXmlParserFiles/RTG_SST.xml : null java.lang.NullPointerException at org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.validate(FileRetrievalSystem.java:367) at org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.changeToDir(FileRetrievalSystem.java:311) at org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.changeToDir(FileRetrievalSystem.java:300) at org.apache.oodt.cas.pushpull.retrievalmethod.RemoteCrawler.processPropFile(RemoteCrawler.java:103) at org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.retrieveFiles(RetrievalSetup.java:109) at org.apache.oodt.cas.pushpull.daemon.Daemon$1.run(Daemon.java:218) at java.lang.Thread.run(Thread.java:662) This addresses bug OODT-476. https://issues.apache.org/jira/browse/OODT-476 Diffs - trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/ProtocolHandler.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/RemoteSiteFile.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalmethod/RemoteCrawler.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java 1365306 trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/RetrievalSetup.java 1365306 Diff: https://reviews.apache.org/r/6166/diff/ Testing --- Ran test provided by YunHee Thanks, brian Foster
