[jira] [Commented] (OOZIE-3414) Oozie master does not compile with -Dhadoop.version=2.8.5

2019-01-17 Thread Julia Kinga Marton (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745863#comment-16745863
 ] 

Julia Kinga Marton commented on OOZIE-3414:
---

Thank you [~asalamon74] for the contribution! +1

committed to master

> Oozie master does not compile with -Dhadoop.version=2.8.5
> -
>
> Key: OOZIE-3414
> URL: https://issues.apache.org/jira/browse/OOZIE-3414
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: trunk, 5.1.0
>Reporter: Daniel Becker
>Assignee: Andras Salamon
>Priority: Major
> Fix For: 5.2.0
>
> Attachments: OOZIE-3414-01.patch, compilation_error.txt
>
>
> When trying to compile Oozie with the switch -Dhadoop.version=2.8.5, the 
> compilation fails. This occurs at least for version 5.1.0 and the current 
> master branch. 
> Compiling with Hadoop version 2.8.0 works.
> Compiling Oozie 5.0.0 with Hadoop version 2.8.5 works.
> The exact command used to build Oozie:
> {code:java}
> bin/mkdistro.sh -Puber -Ptez -Dhadoop.version=2.8.5 -DskipTests{code}
>  
> See the full compiler output in the attachment compiler-error.txt.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] Subscription: Oozie Patch Available

2019-01-17 Thread jira 
Issue Subscription
Filter: Oozie Patch Available (95 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-3420  [action] pom.xml fixes
https://issues.apache.org/jira/browse/OOZIE-3420
OOZIE-3417  [FS Action] Optimize code about the command about chose fs action
https://issues.apache.org/jira/browse/OOZIE-3417
OOZIE-3414  Oozie master does not compile with -Dhadoop.version=2.8.5
https://issues.apache.org/jira/browse/OOZIE-3414
OOZIE-3409  Oozie Server : Memory leak in EL evaluation
https://issues.apache.org/jira/browse/OOZIE-3409
OOZIE-3404  The env variable of SPARK_HOME needs to be set when running pySpark
https://issues.apache.org/jira/browse/OOZIE-3404
OOZIE-3375  Can't use empty  in coordinator
https://issues.apache.org/jira/browse/OOZIE-3375
OOZIE-3367  Using && in EL expressions in oozie bundle.xml files generates 
parse errors
https://issues.apache.org/jira/browse/OOZIE-3367
OOZIE-3366  Update workflow status and subworkflow status on suspend command
https://issues.apache.org/jira/browse/OOZIE-3366
OOZIE-3364  Rerunning Oozie bundle jobs starts the coordinators in 
indeterminate order
https://issues.apache.org/jira/browse/OOZIE-3364
OOZIE-3362  When killed, SSH action should kill the spawned processes on target 
host
https://issues.apache.org/jira/browse/OOZIE-3362
OOZIE-3326  Sqoop Action should support tez delegation tokens for hive-import
https://issues.apache.org/jira/browse/OOZIE-3326
OOZIE-3320  Oozie ShellAction should support absolute bash file path
https://issues.apache.org/jira/browse/OOZIE-3320
OOZIE-3319  Log SSH action callback error output
https://issues.apache.org/jira/browse/OOZIE-3319
OOZIE-3301  Update NOTICE file
https://issues.apache.org/jira/browse/OOZIE-3301
OOZIE-3274  Remove slf4j
https://issues.apache.org/jira/browse/OOZIE-3274
OOZIE-3266  Coord action rerun support RERUN_SKIP_NODES option
https://issues.apache.org/jira/browse/OOZIE-3266
OOZIE-3265  properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to 
appear together
https://issues.apache.org/jira/browse/OOZIE-3265
OOZIE-3256  refactor OozieCLI class
https://issues.apache.org/jira/browse/OOZIE-3256
OOZIE-3249  [tools] Instrumentation log parser
https://issues.apache.org/jira/browse/OOZIE-3249
OOZIE-3199  Let system property restriction configurable
https://issues.apache.org/jira/browse/OOZIE-3199
OOZIE-3196  Authorization: restrict world readability by user
https://issues.apache.org/jira/browse/OOZIE-3196
OOZIE-3179  Adding a configurable config-default.xml location to a workflow
https://issues.apache.org/jira/browse/OOZIE-3179
OOZIE-3170  Oozie Diagnostic Bundle tool fails with NPE due to missing service 
class
https://issues.apache.org/jira/browse/OOZIE-3170
OOZIE-3137  Add support for log4j2 in HiveMain
https://issues.apache.org/jira/browse/OOZIE-3137
OOZIE-3135  Configure log4j2 in SqoopMain
https://issues.apache.org/jira/browse/OOZIE-3135
OOZIE-3091  Oozie Sqoop Avro Import fails with "java.lang.NoClassDefFoundError: 
org/apache/avro/mapred/AvroWrapper"
https://issues.apache.org/jira/browse/OOZIE-3091
OOZIE-3071  Oozie 4.3 Spark sharelib ueses a different version of commons-lang3 
than Spark 2.2.0
https://issues.apache.org/jira/browse/OOZIE-3071
OOZIE-3063  Sanitizing variables that are part of openjpa.ConnectionProperties
https://issues.apache.org/jira/browse/OOZIE-3063
OOZIE-3062  Set HADOOP_CONF_DIR for spark action
https://issues.apache.org/jira/browse/OOZIE-3062
OOZIE-2952  Fix Findbugs warnings in oozie-sharelib-oozie
https://issues.apache.org/jira/browse/OOZIE-2952
OOZIE-2949  Escape quotes whitespaces in Sqoop  field
https://issues.apache.org/jira/browse/OOZIE-2949
OOZIE-2927  Append new line character for Hive2 query using query tag
https://issues.apache.org/jira/browse/OOZIE-2927
OOZIE-2834  ParameterVerifier logging non-useful warning for workflow definition
https://issues.apache.org/jira/browse/OOZIE-2834
OOZIE-2833  when using uber mode the regex pattern used in the 
extractHeapSizeMB method does not allow heap sizes specified in bytes.
https://issues.apache.org/jira/browse/OOZIE-2833
OOZIE-2812  SparkConfigurationService should support loading configurations 
from multiple Spark versions
https://issues.apache.org/jira/browse/OOZIE-2812
OOZIE-2795  Create lib directory or symlink for Oozie CLI during packaging
https://issues.apache.org/jira/browse/OOZIE-2795
OOZIE-2784  Include WEEK as a parameter in the Coordinator Expression Language 
Evaulator
https://issues.apache.org/jira/browse/OOZIE-2784
OOZIE-2779  Mask Hive2 action Beeline JDBC password

[jira] [Commented] (OOZIE-3417) [FS Action] Optimize code about the command about chose fs action

2019-01-17 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745197#comment-16745197
 ] 

Hadoop QA commented on OOZIE-3417:
--


Testing JIRA OOZIE-3417

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:red}-1{color} the patch contains 7 line(s) longer than 132 
characters
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [core].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3110
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/977/



> [FS Action] Optimize code about the command about chose fs action
> -
>
> Key: OOZIE-3417
> URL: https://issues.apache.org/jira/browse/OOZIE-3417
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 5.2.0
>Reporter: duan xiong
>Assignee: duan xiong
>Priority: Major
>  Labels: performance
> Attachments: oozie-3417-01.patch, oozie-3417-02.patch, 
> oozie-3417-03.patch
>
>
> When I read FsActionExecutor.java, I found a not good code in this class.  
> When judging which logic to use based on commands, should use "switch/case" 
> replace "if/else":
>  # “if/else” make the code hard to read
>  # “if/else” make the code hard to extend
>  # “if/else” has low  efficience
> So I suggest using “switch/case” instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: OOZIE-3417 PreCommit Build #977

2019-01-17 Thread Apache Jenkins Server 
Jira: https://issues.apache.org/jira/browse/OOZIE-3417
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/977/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.91 MB...]
[DEBUG] There are no new bugs found in [docs].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [tools].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [fluent-job/fluent-job-api].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [server].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [webapp].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [examples].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [core].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2561 bytes
[TRACE] Full summary file size is 1471 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3417

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any star imports
-1 the patch contains 7 line(s) longer than 132 characters
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 Javadoc generation succeeded with the patch
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/git].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [fluent-job/fluent-job-api].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [webapp].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [core].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 3110
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/977/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  32810 0  100  3281  0   3816 --:--:-- --:--:-- --:--:--  
3815{"self":"https://issues.apache.org/jira/rest/api/2/issue/13209132/comment/16745197","id":"16745197","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small=hadoopqa=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall=hadoopqa=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?size=medium=hadoopqa=10393"},"displayName":"Hadoop

[jira] [Created] (OOZIE-3424) Enable definition of admin users on a group membership basis

2019-01-17 Thread Peter Orova (JIRA) 
Peter Orova created OOZIE-3424:
--

 Summary: Enable definition of admin users on a group membership 
basis
 Key: OOZIE-3424
 URL: https://issues.apache.org/jira/browse/OOZIE-3424
 Project: Oozie
  Issue Type: Improvement
Reporter: Peter Orova


As per  [OOZIE-3217|https://issues.apache.org/jira/browse/OOZIE-3217] the 
administrative users are defined on a per user basis. 
Introducing a group based definition of access would be the next step towards a 
role based access control.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3417) [FS Action] Optimize code about the command about chose fs action

2019-01-17 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745054#comment-16745054
 ] 

Hadoop QA commented on OOZIE-3417:
--

PreCommit-OOZIE-Build started


> [FS Action] Optimize code about the command about chose fs action
> -
>
> Key: OOZIE-3417
> URL: https://issues.apache.org/jira/browse/OOZIE-3417
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 5.2.0
>Reporter: duan xiong
>Assignee: duan xiong
>Priority: Major
>  Labels: performance
> Attachments: oozie-3417-01.patch, oozie-3417-02.patch, 
> oozie-3417-03.patch
>
>
> When I read FsActionExecutor.java, I found a not good code in this class.  
> When judging which logic to use based on commands, should use "switch/case" 
> replace "if/else":
>  # “if/else” make the code hard to read
>  # “if/else” make the code hard to extend
>  # “if/else” has low  efficience
> So I suggest using “switch/case” instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3417) [FS Action] Optimize code about the command about chose fs action

2019-01-17 Thread duan xiong (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OOZIE-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

duan xiong updated OOZIE-3417:
--
Attachment: oozie-3417-03.patch

> [FS Action] Optimize code about the command about chose fs action
> -
>
> Key: OOZIE-3417
> URL: https://issues.apache.org/jira/browse/OOZIE-3417
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 5.2.0
>Reporter: duan xiong
>Assignee: duan xiong
>Priority: Major
>  Labels: performance
> Attachments: oozie-3417-01.patch, oozie-3417-02.patch, 
> oozie-3417-03.patch
>
>
> When I read FsActionExecutor.java, I found a not good code in this class.  
> When judging which logic to use based on commands, should use "switch/case" 
> replace "if/else":
>  # “if/else” make the code hard to read
>  # “if/else” make the code hard to extend
>  # “if/else” has low  efficience
> So I suggest using “switch/case” instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Reopened] (OOZIE-3419) [fluent-job] GraphVisualization fails before JDK 1.8.0_u40

2019-01-17 Thread Julia Kinga Marton (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OOZIE-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julia Kinga Marton reopened OOZIE-3419:
---

> [fluent-job] GraphVisualization fails before JDK 1.8.0_u40
> --
>
> Key: OOZIE-3419
> URL: https://issues.apache.org/jira/browse/OOZIE-3419
> Project: Oozie
>  Issue Type: Improvement
>  Components: fluent-job
>Affects Versions: 5.1.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Major
> Fix For: 5.2.0
>
> Attachments: OOZIE-3419.001.patch, OOZIE-3419.002.patch, 
> OOZIE-3419.003.patch
>
>
> When {{GraphVisualization.java}} is called e.g. from integration tests / to 
> generate {{.png}} or {{.dot}} files to visualize {{Graph}} objects, a 
> {{GraphvizException}} occurs when {{JDK1.8.0}} is used before {{u40}}. Let's 
> skip execution for these cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3419) [fluent-job] GraphVisualization fails before JDK 1.8.0_u40

2019-01-17 Thread Julia Kinga Marton (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745037#comment-16745037
 ] 

Julia Kinga Marton commented on OOZIE-3419:
---

[~andras.piros], reopened the issue because of the checkstyle problem.

> [fluent-job] GraphVisualization fails before JDK 1.8.0_u40
> --
>
> Key: OOZIE-3419
> URL: https://issues.apache.org/jira/browse/OOZIE-3419
> Project: Oozie
>  Issue Type: Improvement
>  Components: fluent-job
>Affects Versions: 5.1.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Major
> Fix For: 5.2.0
>
> Attachments: OOZIE-3419.001.patch, OOZIE-3419.002.patch, 
> OOZIE-3419.003.patch
>
>
> When {{GraphVisualization.java}} is called e.g. from integration tests / to 
> generate {{.png}} or {{.dot}} files to visualize {{Graph}} objects, a 
> {{GraphvizException}} occurs when {{JDK1.8.0}} is used before {{u40}}. Let's 
> skip execution for these cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (OOZIE-3424) Enable definition of admin users on a group membership basis

2019-01-17 Thread Peter Orova (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OOZIE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Orova reassigned OOZIE-3424:
--

Assignee: Peter Orova

> Enable definition of admin users on a group membership basis
> 
>
> Key: OOZIE-3424
> URL: https://issues.apache.org/jira/browse/OOZIE-3424
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Peter Orova
>Assignee: Peter Orova
>Priority: Major
>
> As per  [OOZIE-3217|https://issues.apache.org/jira/browse/OOZIE-3217] the 
> administrative users are defined on a per user basis. 
> Introducing a group based definition of access would be the next step towards 
> a role based access control.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: OOZIE-3409 PreCommit Build #976

2019-01-17 Thread Apache Jenkins Server 
Jira: https://issues.apache.org/jira/browse/OOZIE-3409
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/976/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.93 MB...]
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [server].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [webapp].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [examples].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [core].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2560 bytes
[TRACE] Full summary file size is 1471 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3409

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any star imports
+1 the patch does not introduce any line longer than 132
+1 the patch adds/modifies 3 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 Javadoc generation succeeded with the patch
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/git].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [fluent-job/fluent-job-api].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [webapp].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [core].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 3110
Tests failed at first run:
TestPurgeXCommand#testPurgeableBundleUnpurgeableCoordinatorUnpurgeableWorkflow
TestPurgeXCommand#testPurgeableBundleUnpurgeableCoordinatorUnpurgebleWorkflowPurgeableSubWorkflow
TestCoordMaterializeTriggerService#testCoordMaterializeTriggerService3
TestAuthFilterAuthOozieClient#testClientAuthTokenCache
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


+1 Overall result, good!, no -1s

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/976/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  36980 0  100  3698  0   3409  0:00:01  0:00:01 --:--:--

[jira] [Commented] (OOZIE-3409) Oozie Server : Memory leak in EL evaluation

2019-01-17 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745028#comment-16745028
 ] 

Hadoop QA commented on OOZIE-3409:
--


Testing JIRA OOZIE-3409

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [core].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3110
.{color:orange}Tests failed at first run:{color}
TestPurgeXCommand#testPurgeableBundleUnpurgeableCoordinatorUnpurgeableWorkflow
TestPurgeXCommand#testPurgeableBundleUnpurgeableCoordinatorUnpurgebleWorkflowPurgeableSubWorkflow
TestCoordMaterializeTriggerService#testCoordMaterializeTriggerService3
TestAuthFilterAuthOozieClient#testClientAuthTokenCache
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:green}*+1 Overall result, good!, no -1s*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/976/



> Oozie Server : Memory leak in EL evaluation
> ---
>
> Key: OOZIE-3409
> URL: https://issues.apache.org/jira/browse/OOZIE-3409
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.1.0
>Reporter: Praneeth
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-3409-01.patch, OOZIE-3409-02.patch
>
>
> I have noticed that there is a potential memory leak in the Oozie server due 
> to one of its dependencies - {{commons-el:commons-el:1.0}}. Our oozie servers 
> have been running out of memory occasionally. It happens more often when we 
> have more activity. Upon analysis of the heap dump, it seems that the culprit 
> here is the {{org.apache.commons.el.ExpressionEvaluatorImpl}} from 
> {{commons-el}} which is used in the Oozie server through 
> {{org.apache.oozie.util.ELEvaluator}} [1] . {{ExpressionEvaluatorImpl}} uses 
> a static {{Map}} [2] to cache the EL evaluations. This map never gets 
> cleared, eventually taking up all the memory. So, in an environment with 
> heavy

[jira] [Commented] (OOZIE-3418) Upgrade to Guava 27

2019-01-17 Thread Andras Salamon (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744995#comment-16744995
 ] 

Andras Salamon commented on OOZIE-3418:
---

As a quick test I bumped up the guava version to {{24.1.1}} and {{27.0}} and 
tried to compile Oozie, but it failed:
{noformat}
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 01:10 min
[INFO] Finished at: 2019-01-17T13:16:40+01:00
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) 
on project oozie-core: Compilation failure: Compilation failure:
[ERROR] 
/Users/andrassalamon/src/oozie/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java:[1110,27]
 no suitable method found for 
closeQuietly(org.apache.hadoop.yarn.client.api.YarnClient)
[ERROR]     method 
com.google.common.io.Closeables.closeQuietly(java.io.InputStream) is not 
applicable
[ERROR]       (argument mismatch; org.apache.hadoop.yarn.client.api.YarnClient 
cannot be converted to java.io.InputStream)
[ERROR]     method com.google.common.io.Closeables.closeQuietly(java.io.Reader) 
is not applicable
[ERROR]       (argument mismatch; org.apache.hadoop.yarn.client.api.YarnClient 
cannot be converted to java.io.Reader)
[ERROR] 
/Users/andrassalamon/src/oozie/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java:[1874,27]
 no suitable method found for 
closeQuietly(org.apache.hadoop.yarn.client.api.YarnClient)
[ERROR]     method 
com.google.common.io.Closeables.closeQuietly(java.io.InputStream) is not 
applicable
[ERROR]       (argument mismatch; org.apache.hadoop.yarn.client.api.YarnClient 
cannot be converted to java.io.InputStream)
[ERROR]     method com.google.common.io.Closeables.closeQuietly(java.io.Reader) 
is not applicable
[ERROR]       (argument mismatch; org.apache.hadoop.yarn.client.api.YarnClient 
cannot be converted to java.io.Reader)
[ERROR] 
/Users/andrassalamon/src/oozie/core/src/main/java/org/apache/oozie/service/JvmPauseMonitorService.java:[159,28]
 constructor Stopwatch in class com.google.common.base.Stopwatch cannot be 
applied to given types;
[ERROR]   required: com.google.common.base.Ticker
[ERROR]   found: no arguments
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] 
/Users/andrassalamon/src/oozie/core/src/main/java/org/apache/oozie/service/JvmPauseMonitorService.java:[168,41]
 cannot find symbol
[ERROR]   symbol:   method elapsedMillis()
[ERROR]   location: variable sw of type 
com.google.common.base.Stopwatch{noformat}

Switching to a new Guava version would require to fix all the incompatibilities 
one by one. Probably we can just replace some of the Guava code with standard 
java code, for instance {{Closeables.closeQuietly}} has been [removed from 
Guava|https://google.github.io/guava/releases/14.0/api/docs/com/google/common/io/Closeables.html]
 in favor of try-with-resources:

{noformat}@Deprecated
public static void closeQuietly(@Nullable
   Closeable closeable)

Deprecated. Where possible, use the try-with-resources statement if using JDK7 
or Closer on JDK6 to close one or more Closeable objects. This method is 
deprecated because it is easy to misuse and may swallow IO exceptions that 
really should be thrown and handled. See Guava issue 1118 for a more detailed 
explanation of the reasons for deprecation and see Closing Resources for more 
information on the problems with closing Closeable objects and some of the 
preferred solutions for handling it correctly. This method is scheduled to be 
removed in Guava 16.0.
Equivalent to calling close(closeable, true), but with no IOException in the 
signature.
{noformat}

> Upgrade to Guava 27
> ---
>
> Key: OOZIE-3418
> URL: https://issues.apache.org/jira/browse/OOZIE-3418
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.1.0
>Reporter: Andras Salamon
>Priority: Major
>
> There is a guava security issue: 
> [CVE-2018-10237|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-10237]
> Currently we use Guava 11.0.2 which is affected. We need to upgrade to at 
> least guava 24.1.1. Probably the best would be to use Guava 27.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: OOZIE-3414 PreCommit Build #975

2019-01-17 Thread Apache Jenkins Server 
Jira: https://issues.apache.org/jira/browse/OOZIE-3414
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/975/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.91 MB...]
[DEBUG] There are no new bugs found in [docs].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [tools].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [fluent-job/fluent-job-api].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [server].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [webapp].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [examples].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [core].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2561 bytes
[TRACE] Full summary file size is 1471 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3414

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any star imports
+1 the patch does not introduce any line longer than 132
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 Javadoc generation succeeded with the patch
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/git].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [fluent-job/fluent-job-api].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [webapp].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [core].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 3110
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/975/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  32810 0  100  3281  0   3862 --:--:-- --:--:-- --:--:--  
3860{"self":"https://issues.apache.org/jira/rest/api/2/issue/13208001/comment/16744952","id":"16744952","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small=hadoopqa=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall=hadoopqa=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?size=medium=hadoopqa=10393"},"displayName":"Hadoop

[jira] [Commented] (OOZIE-3414) Oozie master does not compile with -Dhadoop.version=2.8.5

2019-01-17 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744952#comment-16744952
 ] 

Hadoop QA commented on OOZIE-3414:
--


Testing JIRA OOZIE-3414

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [core].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3110
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/975/



> Oozie master does not compile with -Dhadoop.version=2.8.5
> -
>
> Key: OOZIE-3414
> URL: https://issues.apache.org/jira/browse/OOZIE-3414
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: trunk, 5.1.0
>Reporter: Daniel Becker
>Assignee: Andras Salamon
>Priority: Major
> Fix For: 5.2.0
>
> Attachments: OOZIE-3414-01.patch, compilation_error.txt
>
>
> When trying to compile Oozie with the switch -Dhadoop.version=2.8.5, the 
> compilation fails. This occurs at least for version 5.1.0 and the current 
> master branch. 
> Compiling with Hadoop version 2.8.0 works.
> Compiling Oozie 5.0.0 with Hadoop version 2.8.5 works.
> The exact command used to build Oozie:
> {code:java}
> bin/mkdistro.sh -Puber -Ptez -Dhadoop.version=2.8.5 -DskipTests{code}
>  
> See the full compiler output in the attachment compiler-error.txt.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3409) Oozie Server : Memory leak in EL evaluation

2019-01-17 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744909#comment-16744909
 ] 

Hadoop QA commented on OOZIE-3409:
--

PreCommit-OOZIE-Build started


> Oozie Server : Memory leak in EL evaluation
> ---
>
> Key: OOZIE-3409
> URL: https://issues.apache.org/jira/browse/OOZIE-3409
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.1.0
>Reporter: Praneeth
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-3409-01.patch, OOZIE-3409-02.patch
>
>
> I have noticed that there is a potential memory leak in the Oozie server due 
> to one of its dependencies - {{commons-el:commons-el:1.0}}. Our oozie servers 
> have been running out of memory occasionally. It happens more often when we 
> have more activity. Upon analysis of the heap dump, it seems that the culprit 
> here is the {{org.apache.commons.el.ExpressionEvaluatorImpl}} from 
> {{commons-el}} which is used in the Oozie server through 
> {{org.apache.oozie.util.ELEvaluator}} [1] . {{ExpressionEvaluatorImpl}} uses 
> a static {{Map}} [2] to cache the EL evaluations. This map never gets 
> cleared, eventually taking up all the memory. So, in an environment with 
> heavy usage and long running oozie servers, this would lead to an OOM. The 
> configurations for workflow actions we have are possibly larger than normal 
> which is worsening the situation as the Map has to maintain larger strings.
>  # 
> [https://github.com/apache/oozie/blob/release-5.1.0/core/src/main/java/org/apache/oozie/util/ELEvaluator.java#L143]
>  # 
> [http://svn.apache.org/viewvc/commons/dormant/el/trunk/src/java/org/apache/commons/el/ExpressionEvaluatorImpl.java?view=markup#l94]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 69783: OOZIE-3409 - Oozie Server : Memory leak in EL evaluation

2019-01-17 Thread Andras Salamon 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69783/
---

Review request for oozie, András Piros and Kinga Marton.


Repository: oozie-git


Description
---

OOZIE-3409 - Oozie Server : Memory leak in EL evaluation


Diffs
-

  core/pom.xml b6c07d345 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
c1c644459 
  core/src/main/java/org/apache/oozie/util/ELEvaluator.java 90d79779f 
  core/src/main/java/org/apache/oozie/util/StringUtils.java 26079be93 
  core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 
519b38406 
  core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 04a869c0b 
  core/src/test/java/org/apache/oozie/util/TestStringUtils.java 423d6be27 
  examples/pom.xml 8900535b2 


Diff: https://reviews.apache.org/r/69783/diff/1/


Testing
---

Using grind to execute unit tests.


Thanks,

Andras Salamon

[jira] [Updated] (OOZIE-3409) Oozie Server : Memory leak in EL evaluation

2019-01-17 Thread Andras Salamon (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OOZIE-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Salamon updated OOZIE-3409:
--
Summary: Oozie Server : Memory leak in EL evaluation  (was: Oozie Server : 
Possible memory leak in EL evaluation)

> Oozie Server : Memory leak in EL evaluation
> ---
>
> Key: OOZIE-3409
> URL: https://issues.apache.org/jira/browse/OOZIE-3409
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.1.0
>Reporter: Praneeth
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-3409-01.patch, OOZIE-3409-02.patch
>
>
> I have noticed that there is a potential memory leak in the Oozie server due 
> to one of its dependencies - {{commons-el:commons-el:1.0}}. Our oozie servers 
> have been running out of memory occasionally. It happens more often when we 
> have more activity. Upon analysis of the heap dump, it seems that the culprit 
> here is the {{org.apache.commons.el.ExpressionEvaluatorImpl}} from 
> {{commons-el}} which is used in the Oozie server through 
> {{org.apache.oozie.util.ELEvaluator}} [1] . {{ExpressionEvaluatorImpl}} uses 
> a static {{Map}} [2] to cache the EL evaluations. This map never gets 
> cleared, eventually taking up all the memory. So, in an environment with 
> heavy usage and long running oozie servers, this would lead to an OOM. The 
> configurations for workflow actions we have are possibly larger than normal 
> which is worsening the situation as the Map has to maintain larger strings.
>  # 
> [https://github.com/apache/oozie/blob/release-5.1.0/core/src/main/java/org/apache/oozie/util/ELEvaluator.java#L143]
>  # 
> [http://svn.apache.org/viewvc/commons/dormant/el/trunk/src/java/org/apache/commons/el/ExpressionEvaluatorImpl.java?view=markup#l94]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3409) Oozie Server : Possible memory leak in EL evaluation

2019-01-17 Thread Andras Salamon (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744906#comment-16744906
 ] 

Andras Salamon commented on OOZIE-3409:
---

DO NOT MERGE YET

This patch fixes the {{TestLocalOozieExample}} problem.

I wanted to move ELEvaluator.checkForExistence method to a separate class, but 
I realized that we already have a {{StringUtils}} class in the package, so I 
moved it to there (and renamed it).

Because this method no longer uses EL evaluation, but only relies on String 
manipulation, I was able to simplify the code a bit.

Still need more testing (the most important one is to heck for memory leaks) 
but I upload the patch as is, because the precommit build might catch more 
problems ignored by my grind tests.

 

> Oozie Server : Possible memory leak in EL evaluation
> 
>
> Key: OOZIE-3409
> URL: https://issues.apache.org/jira/browse/OOZIE-3409
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.1.0
>Reporter: Praneeth
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-3409-01.patch, OOZIE-3409-02.patch
>
>
> I have noticed that there is a potential memory leak in the Oozie server due 
> to one of its dependencies - {{commons-el:commons-el:1.0}}. Our oozie servers 
> have been running out of memory occasionally. It happens more often when we 
> have more activity. Upon analysis of the heap dump, it seems that the culprit 
> here is the {{org.apache.commons.el.ExpressionEvaluatorImpl}} from 
> {{commons-el}} which is used in the Oozie server through 
> {{org.apache.oozie.util.ELEvaluator}} [1] . {{ExpressionEvaluatorImpl}} uses 
> a static {{Map}} [2] to cache the EL evaluations. This map never gets 
> cleared, eventually taking up all the memory. So, in an environment with 
> heavy usage and long running oozie servers, this would lead to an OOM. The 
> configurations for workflow actions we have are possibly larger than normal 
> which is worsening the situation as the Map has to maintain larger strings.
>  # 
> [https://github.com/apache/oozie/blob/release-5.1.0/core/src/main/java/org/apache/oozie/util/ELEvaluator.java#L143]
>  # 
> [http://svn.apache.org/viewvc/commons/dormant/el/trunk/src/java/org/apache/commons/el/ExpressionEvaluatorImpl.java?view=markup#l94]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3409) Oozie Server : Possible memory leak in EL evaluation

2019-01-17 Thread Andras Salamon (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OOZIE-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Salamon updated OOZIE-3409:
--
Attachment: OOZIE-3409-02.patch

> Oozie Server : Possible memory leak in EL evaluation
> 
>
> Key: OOZIE-3409
> URL: https://issues.apache.org/jira/browse/OOZIE-3409
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.1.0
>Reporter: Praneeth
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-3409-01.patch, OOZIE-3409-02.patch
>
>
> I have noticed that there is a potential memory leak in the Oozie server due 
> to one of its dependencies - {{commons-el:commons-el:1.0}}. Our oozie servers 
> have been running out of memory occasionally. It happens more often when we 
> have more activity. Upon analysis of the heap dump, it seems that the culprit 
> here is the {{org.apache.commons.el.ExpressionEvaluatorImpl}} from 
> {{commons-el}} which is used in the Oozie server through 
> {{org.apache.oozie.util.ELEvaluator}} [1] . {{ExpressionEvaluatorImpl}} uses 
> a static {{Map}} [2] to cache the EL evaluations. This map never gets 
> cleared, eventually taking up all the memory. So, in an environment with 
> heavy usage and long running oozie servers, this would lead to an OOM. The 
> configurations for workflow actions we have are possibly larger than normal 
> which is worsening the situation as the Map has to maintain larger strings.
>  # 
> [https://github.com/apache/oozie/blob/release-5.1.0/core/src/main/java/org/apache/oozie/util/ELEvaluator.java#L143]
>  # 
> [http://svn.apache.org/viewvc/commons/dormant/el/trunk/src/java/org/apache/commons/el/ExpressionEvaluatorImpl.java?view=markup#l94]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3417) [FS Action] Optimize code about the command about chose fs action

2019-01-17 Thread Andras Salamon (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744880#comment-16744880
 ] 

Andras Salamon commented on OOZIE-3417:
---

Thanks [~nobigo] for the new patch, and thanks [~kmarton] for uploading it.

I left a comment of the reviewboard, I explaned one of my previous comment in 
more detail. Of course it applies to all of the case statements.

> [FS Action] Optimize code about the command about chose fs action
> -
>
> Key: OOZIE-3417
> URL: https://issues.apache.org/jira/browse/OOZIE-3417
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 5.2.0
>Reporter: duan xiong
>Assignee: duan xiong
>Priority: Major
>  Labels: performance
> Attachments: oozie-3417-01.patch, oozie-3417-02.patch
>
>
> When I read FsActionExecutor.java, I found a not good code in this class.  
> When judging which logic to use based on commands, should use "switch/case" 
> replace "if/else":
>  # “if/else” make the code hard to read
>  # “if/else” make the code hard to extend
>  # “if/else” has low  efficience
> So I suggest using “switch/case” instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 69771: OOZIE-3417 [FS Action] Optimize code about the command about chose fs action

2019-01-17 Thread Andras Salamon 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69771/#review212107
---



I explaned one of my previous comment in more detail. Of course it applies to 
all of the case statements.


core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
Lines 186-190 (original), 191-195 (patched)


My main concern is the code block used in every case statement like this:

 case "mkdir": { 
   Path path = getPath(commandElement, FS_TAG_PATH);
   mkdir(context, fsConf, nameNodePath, path);
   break;
 }
 
I think we should eliminate this and use it like this (of course it means 
that we cannot declare the same variable multiple times): 

case "mkdir":  
   Path path = getPath(commandElement, FS_TAG_PATH);
   mkdir(context, fsConf, nameNodePath, path);
   break;
   
Or maybe it would be even better to create separate methods and use like 
this:

case "mkdir":
  doMkdirOperation(...);
  break;


- Andras Salamon


On Jan. 17, 2019, 8:03 a.m., Kinga Marton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69771/
> ---
> 
> (Updated Jan. 17, 2019, 8:03 a.m.)
> 
> 
> Review request for oozie and Andras Salamon.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> When I read FsActionExecutor.java, I found a not good code in this class.  
> When judging which logic to use based on commands, should use "switch/case" 
> replace "if/else":
> “if/else” make the code hard to read
> “if/else” make the code hard to extend
> “if/else” has low  efficience
> So I suggest using “switch/case” instead.
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 
> de55793c 
> 
> 
> Diff: https://reviews.apache.org/r/69771/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kinga Marton
> 
>

[jira] [Commented] (OOZIE-3414) Oozie master does not compile with -Dhadoop.version=2.8.5

2019-01-17 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744849#comment-16744849
 ] 

Hadoop QA commented on OOZIE-3414:
--

PreCommit-OOZIE-Build started


> Oozie master does not compile with -Dhadoop.version=2.8.5
> -
>
> Key: OOZIE-3414
> URL: https://issues.apache.org/jira/browse/OOZIE-3414
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: trunk, 5.1.0
>Reporter: Daniel Becker
>Assignee: Andras Salamon
>Priority: Major
> Fix For: 5.2.0
>
> Attachments: OOZIE-3414-01.patch, compilation_error.txt
>
>
> When trying to compile Oozie with the switch -Dhadoop.version=2.8.5, the 
> compilation fails. This occurs at least for version 5.1.0 and the current 
> master branch. 
> Compiling with Hadoop version 2.8.0 works.
> Compiling Oozie 5.0.0 with Hadoop version 2.8.5 works.
> The exact command used to build Oozie:
> {code:java}
> bin/mkdistro.sh -Puber -Ptez -Dhadoop.version=2.8.5 -DskipTests{code}
>  
> See the full compiler output in the attachment compiler-error.txt.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3419) [fluent-job] GraphVisualization fails before JDK 1.8.0_u40

2019-01-17 Thread Andras Salamon (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744806#comment-16744806
 ] 

Andras Salamon commented on OOZIE-3419:
---

After this commit it's no longer possible to compile Oozie without turning off 
checkstyle checking:
{noformat}
mvn clean install assembly:single -DskipTests -Dhadoop.version=2.6.0
...
[INFO] --- maven-checkstyle-plugin:2.17:check (default) @ oozie-fluent-job-api 
---
[INFO] Starting audit...
/Users/andrassalamon/src/oozie/fluent-job/fluent-job-api/src/main/java/org/apache/oozie/fluentjob/api/GraphVisualization.java:9:
 error: Line does not match expected header line of ' *'.   
   
Audit done.
[INFO] There is 1 error reported by Checkstyle 6.11.2 with 
src/main/resources/checkstyle.xml ruleset.
[ERROR] 
src/main/java/org/apache/oozie/fluentjob/api/GraphVisualization.java:[9] 
(header) Header: Line does not match expected header line of ' *'.  
  
{noformat}
The 
[commit|https://github.com/apache/oozie/commit/96fcb401f81e1aaee3c3de41e77916af95b0e378#diff-65117e05229a1aa9618b6b13c9482667]
 changed line 9-11 of {{GraphVisualization.java}} but 
[checkstyle-header.txt|https://github.com/apache/oozie/blob/master/fluent-job/fluent-job-api/src/main/resources/checkstyle-header.txt]
 of fluent-job still requires the old style.

We should either create an amend commit which changes back the lines to the 
style, or we should update checkstyle-header.txt of fluent-job and also update 
all the source files to the new style.

> [fluent-job] GraphVisualization fails before JDK 1.8.0_u40
> --
>
> Key: OOZIE-3419
> URL: https://issues.apache.org/jira/browse/OOZIE-3419
> Project: Oozie
>  Issue Type: Improvement
>  Components: fluent-job
>Affects Versions: 5.1.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Major
> Fix For: 5.2.0
>
> Attachments: OOZIE-3419.001.patch, OOZIE-3419.002.patch, 
> OOZIE-3419.003.patch
>
>
> When {{GraphVisualization.java}} is called e.g. from integration tests / to 
> generate {{.png}} or {{.dot}} files to visualize {{Graph}} objects, a 
> {{GraphvizException}} occurs when {{JDK1.8.0}} is used before {{u40}}. Let's 
> skip execution for these cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3401) [test] fix TestPySpark failure

2019-01-17 Thread Julia Kinga Marton (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744774#comment-16744774
 ] 

Julia Kinga Marton commented on OOZIE-3401:
---

Thank you [~asalamon74] and [~andras.piros] for the review.

Committed to master

 

> [test] fix TestPySpark failure
> --
>
> Key: OOZIE-3401
> URL: https://issues.apache.org/jira/browse/OOZIE-3401
> Project: Oozie
>  Issue Type: Bug
>  Components: tests
>Affects Versions: trunk
>Reporter: Andras Salamon
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.2.0
>
> Attachments: OOZIE-3401-01.patch, OOZIE-3401-02.patch
>
>
> [TestPySpark|https://github.com/apache/oozie/blob/master/sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestPyspark.java]
>  fails with the following error:
> {noformat}[INFO] Running org.apache.oozie.action.hadoop.TestPyspark
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
> 131.97 s <<< FAILURE! - in org.apache.oozie.action.hadoop.TestPyspark
> [ERROR] testPyspark(org.apache.oozie.action.hadoop.TestPyspark)  Time 
> elapsed: 131.97 s  <<< FAILURE!
> junit.framework.ComparisonFailure: expected:<[SUCCEED]ED> but 
> was:<[FAILED/KILL]ED>
> at junit.framework.Assert.assertEquals(Assert.java:100)
> at junit.framework.Assert.assertEquals(Assert.java:107)   
>  
> at junit.framework.TestCase.assertEquals(TestCase.java:269)
> at 
> org.apache.oozie.action.hadoop.TestPyspark.testPysparkHelper(TestPyspark.java:107)
> at 
> org.apache.oozie.action.hadoop.TestPyspark.testPyspark(TestPyspark.java:85)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)   
>  
> at junit.framework.TestCase.runTest(TestCase.java:176)
>  
> at junit.framework.TestCase.runBare(TestCase.java:141)
>  
> at junit.framework.TestResult$1.protect(TestResult.java:122)  
>  
> at junit.framework.TestResult.runProtected(TestResult.java:142)   
>  
> at junit.framework.TestResult.run(TestResult.java:125)
>  
> at junit.framework.TestCase.run(TestCase.java:129)
>  
> at junit.framework.TestSuite.runTest(TestSuite.java:255)  
>  
> at junit.framework.TestSuite.run(TestSuite.java:250)  
>  
> at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
> at org.junit.runners.Suite.runChild(Suite.java:127)   
>  
> at org.junit.runners.Suite.runChild(Suite.java:26)
>  
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at org.junit.runners.Suite.runChild(Suite.java:127)
> at org.junit.runners.Suite.runChild(Suite.java:26) 
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at 
> org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:410)
> at 
> org.apache.maven.surefire.junitcore.pc.InvokerStrategy.schedule(InvokerStrategy.java:54)
> at 
> org.apache.maven.surefire.junitcore.pc.Scheduler.schedule(Scheduler.java:367)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)   
>  
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)  
>   
>   
> at 
> org.apache.maven.surefire.junitcore.pc.ParallelComputerBuilder$PC$1.run(ParallelComputerBuilder.java:593)
> at 
> org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)  
>  
> at 
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
>  
> at 
>

[jira] [Updated] (OOZIE-3401) [test] fix TestPySpark failure

2019-01-17 Thread Julia Kinga Marton (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OOZIE-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julia Kinga Marton updated OOZIE-3401:
--
Summary: [test] fix TestPySpark failure  (was: TestPySpark failure)

> [test] fix TestPySpark failure
> --
>
> Key: OOZIE-3401
> URL: https://issues.apache.org/jira/browse/OOZIE-3401
> Project: Oozie
>  Issue Type: Bug
>  Components: tests
>Affects Versions: trunk
>Reporter: Andras Salamon
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.2.0
>
> Attachments: OOZIE-3401-01.patch, OOZIE-3401-02.patch
>
>
> [TestPySpark|https://github.com/apache/oozie/blob/master/sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestPyspark.java]
>  fails with the following error:
> {noformat}[INFO] Running org.apache.oozie.action.hadoop.TestPyspark
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
> 131.97 s <<< FAILURE! - in org.apache.oozie.action.hadoop.TestPyspark
> [ERROR] testPyspark(org.apache.oozie.action.hadoop.TestPyspark)  Time 
> elapsed: 131.97 s  <<< FAILURE!
> junit.framework.ComparisonFailure: expected:<[SUCCEED]ED> but 
> was:<[FAILED/KILL]ED>
> at junit.framework.Assert.assertEquals(Assert.java:100)
> at junit.framework.Assert.assertEquals(Assert.java:107)   
>  
> at junit.framework.TestCase.assertEquals(TestCase.java:269)
> at 
> org.apache.oozie.action.hadoop.TestPyspark.testPysparkHelper(TestPyspark.java:107)
> at 
> org.apache.oozie.action.hadoop.TestPyspark.testPyspark(TestPyspark.java:85)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)   
>  
> at junit.framework.TestCase.runTest(TestCase.java:176)
>  
> at junit.framework.TestCase.runBare(TestCase.java:141)
>  
> at junit.framework.TestResult$1.protect(TestResult.java:122)  
>  
> at junit.framework.TestResult.runProtected(TestResult.java:142)   
>  
> at junit.framework.TestResult.run(TestResult.java:125)
>  
> at junit.framework.TestCase.run(TestCase.java:129)
>  
> at junit.framework.TestSuite.runTest(TestSuite.java:255)  
>  
> at junit.framework.TestSuite.run(TestSuite.java:250)  
>  
> at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
> at org.junit.runners.Suite.runChild(Suite.java:127)   
>  
> at org.junit.runners.Suite.runChild(Suite.java:26)
>  
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at org.junit.runners.Suite.runChild(Suite.java:127)
> at org.junit.runners.Suite.runChild(Suite.java:26) 
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at 
> org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:410)
> at 
> org.apache.maven.surefire.junitcore.pc.InvokerStrategy.schedule(InvokerStrategy.java:54)
> at 
> org.apache.maven.surefire.junitcore.pc.Scheduler.schedule(Scheduler.java:367)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)   
>  
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)  
>   
>   
> at 
> org.apache.maven.surefire.junitcore.pc.ParallelComputerBuilder$PC$1.run(ParallelComputerBuilder.java:593)
> at 
> org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)  
>  
> at 
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
>  
> at 
> org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:107)
> at 
>

[jira] [Commented] (OOZIE-3417) [FS Action] Optimize code about the command about chose fs action

2019-01-17 Thread Julia Kinga Marton (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744773#comment-16744773
 ] 

Julia Kinga Marton commented on OOZIE-3417:
---

I have updated the [reviewBoard|https://reviews.apache.org/r/69771/] with the 
new patch.

> [FS Action] Optimize code about the command about chose fs action
> -
>
> Key: OOZIE-3417
> URL: https://issues.apache.org/jira/browse/OOZIE-3417
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 5.2.0
>Reporter: duan xiong
>Assignee: duan xiong
>Priority: Major
>  Labels: performance
> Attachments: oozie-3417-01.patch, oozie-3417-02.patch
>
>
> When I read FsActionExecutor.java, I found a not good code in this class.  
> When judging which logic to use based on commands, should use "switch/case" 
> replace "if/else":
>  # “if/else” make the code hard to read
>  # “if/else” make the code hard to extend
>  # “if/else” has low  efficience
> So I suggest using “switch/case” instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 69771: OOZIE-3417 [FS Action] Optimize code about the command about chose fs action

2019-01-17 Thread Kinga Marton via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69771/
---

(Updated Jan. 17, 2019, 8:03 a.m.)


Review request for oozie and Andras Salamon.


Repository: oozie-git


Description
---

When I read FsActionExecutor.java, I found a not good code in this class.  When 
judging which logic to use based on commands, should use "switch/case" replace 
"if/else":
“if/else” make the code hard to read
“if/else” make the code hard to extend
“if/else” has low  efficience
So I suggest using “switch/case” instead.


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 
de55793c 


Diff: https://reviews.apache.org/r/69771/diff/2/

Changes: https://reviews.apache.org/r/69771/diff/1-2/


Testing
---


Thanks,

Kinga Marton