[jira] Subscription: Oozie Patch Available

2019-02-26 Thread jira 
Issue Subscription
Filter: Oozie Patch Available (93 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-3441  Spark Action：Jackson version is too old 2.4.2
https://issues.apache.org/jira/browse/OOZIE-3441
OOZIE-3440  Oozie Spark action replaces path symlink # to %23
https://issues.apache.org/jira/browse/OOZIE-3440
OOZIE-3432  When use configuration oozie.service.ProxyUserService.root.hosts, 
oozie-error.log shows Invalid configuration defined
https://issues.apache.org/jira/browse/OOZIE-3432
OOZIE-3418  Upgrade to Guava 27
https://issues.apache.org/jira/browse/OOZIE-3418
OOZIE-3409  Oozie Server : Memory leak in EL evaluation
https://issues.apache.org/jira/browse/OOZIE-3409
OOZIE-3404  The env variable of SPARK_HOME needs to be set when running pySpark
https://issues.apache.org/jira/browse/OOZIE-3404
OOZIE-3395  [build] Migration from FindBugs to SpotBugs
https://issues.apache.org/jira/browse/OOZIE-3395
OOZIE-3375  Can't use empty  in coordinator
https://issues.apache.org/jira/browse/OOZIE-3375
OOZIE-3367  Using && in EL expressions in oozie bundle.xml files generates 
parse errors
https://issues.apache.org/jira/browse/OOZIE-3367
OOZIE-3366  Update workflow status and subworkflow status on suspend command
https://issues.apache.org/jira/browse/OOZIE-3366
OOZIE-3364  Rerunning Oozie bundle jobs starts the coordinators in 
indeterminate order
https://issues.apache.org/jira/browse/OOZIE-3364
OOZIE-3362  When killed, SSH action should kill the spawned processes on target 
host
https://issues.apache.org/jira/browse/OOZIE-3362
OOZIE-3320  Oozie ShellAction should support absolute bash file path
https://issues.apache.org/jira/browse/OOZIE-3320
OOZIE-3319  Log SSH action callback error output
https://issues.apache.org/jira/browse/OOZIE-3319
OOZIE-3301  Update NOTICE file
https://issues.apache.org/jira/browse/OOZIE-3301
OOZIE-3274  Remove slf4j
https://issues.apache.org/jira/browse/OOZIE-3274
OOZIE-3266  Coord action rerun support RERUN_SKIP_NODES option
https://issues.apache.org/jira/browse/OOZIE-3266
OOZIE-3265  properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to 
appear together
https://issues.apache.org/jira/browse/OOZIE-3265
OOZIE-3256  refactor OozieCLI class
https://issues.apache.org/jira/browse/OOZIE-3256
OOZIE-3249  [tools] Instrumentation log parser
https://issues.apache.org/jira/browse/OOZIE-3249
OOZIE-3199  Let system property restriction configurable
https://issues.apache.org/jira/browse/OOZIE-3199
OOZIE-3196  Authorization: restrict world readability by user
https://issues.apache.org/jira/browse/OOZIE-3196
OOZIE-3179  Adding a configurable config-default.xml location to a workflow
https://issues.apache.org/jira/browse/OOZIE-3179
OOZIE-3170  Oozie Diagnostic Bundle tool fails with NPE due to missing service 
class
https://issues.apache.org/jira/browse/OOZIE-3170
OOZIE-3137  Add support for log4j2 in HiveMain
https://issues.apache.org/jira/browse/OOZIE-3137
OOZIE-3135  Configure log4j2 in SqoopMain
https://issues.apache.org/jira/browse/OOZIE-3135
OOZIE-3091  Oozie Sqoop Avro Import fails with "java.lang.NoClassDefFoundError: 
org/apache/avro/mapred/AvroWrapper"
https://issues.apache.org/jira/browse/OOZIE-3091
OOZIE-3071  Oozie 4.3 Spark sharelib ueses a different version of commons-lang3 
than Spark 2.2.0
https://issues.apache.org/jira/browse/OOZIE-3071
OOZIE-3063  Sanitizing variables that are part of openjpa.ConnectionProperties
https://issues.apache.org/jira/browse/OOZIE-3063
OOZIE-3062  Set HADOOP_CONF_DIR for spark action
https://issues.apache.org/jira/browse/OOZIE-3062
OOZIE-2952  Fix Findbugs warnings in oozie-sharelib-oozie
https://issues.apache.org/jira/browse/OOZIE-2952
OOZIE-2927  Append new line character for Hive2 query using query tag
https://issues.apache.org/jira/browse/OOZIE-2927
OOZIE-2834  ParameterVerifier logging non-useful warning for workflow definition
https://issues.apache.org/jira/browse/OOZIE-2834
OOZIE-2833  when using uber mode the regex pattern used in the 
extractHeapSizeMB method does not allow heap sizes specified in bytes.
https://issues.apache.org/jira/browse/OOZIE-2833
OOZIE-2812  SparkConfigurationService should support loading configurations 
from multiple Spark versions
https://issues.apache.org/jira/browse/OOZIE-2812
OOZIE-2795  Create lib directory or symlink for Oozie CLI during packaging
https://issues.apache.org/jira/browse/OOZIE-2795
OOZIE-2784  Include WEEK as a parameter in the Coordinator Expression Language 
Evaulator
https://issues.apache.org/jira/browse/OOZIE-2784
OOZIE-2779  Mask Hive2 action Bee

[jira] [Commented] (OOZIE-3440) Oozie Spark action replaces path symlink # to %23

2019-02-26 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778227#comment-16778227
 ] 

Hadoop QA commented on OOZIE-3440:
--


Testing JIRA OOZIE-3440

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [core].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3140
.{color:orange}Tests failed at first run:{color}
TestPurgeXCommand#testSucceededWorkflowSucceededSubWorkflow
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:green}*+1 Overall result, good!, no -1s*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/1023/



> Oozie Spark action replaces path symlink # to %23
> -
>
> Key: OOZIE-3440
> URL: https://issues.apache.org/jira/browse/OOZIE-3440
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Affects Versions: 4.3.1, 5.1.0
> Environment: Hadoop 2.7.3
> Spark 2 - 2.3.0
>Reporter: Denes Bodo
>Assignee: Denes Bodo
>Priority: Major
> Attachments: OOZIE-3440-001.patch, OOZIE-3440-002.patch, 
> OOZIE-3440-003.patch
>
>
> When we provide in a hive action:
>  * --files /etc/spark2/conf/hive-site.xml#hive-site.xml or
>  * /etc/spark2/conf/hive-site.xml#hive-site.xml or
> * hdfs:///tmp/spark2/conf/hive-site.xml#hive-site.xml or
>  * /etc/spark2/conf/hive-site.xml#hive-site.xml
> we get the following error:
> {code}
> Failing Oozie Launcher, Main class 
> [org.apache.oozie.action.hadoop.SparkMain], main() threw exception, File 
> file:/etc/spark2/conf/hive-site.xml%23hive-site.xml does not exist
> {code}
> The culprit seems to be 
> https://github.com/apache/oozie/blob/master/sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java#L480L489
>  .
> Please help me confirm if this is a bug or not. Meanwhile I am creating

Failed: OOZIE-3440 PreCommit Build #1023

2019-02-26 Thread Apache Jenkins Server 
Jira: https://issues.apache.org/jira/browse/OOZIE-3440
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/1023/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.94 MB...]
[DEBUG] There are no new bugs found in [tools].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [fluent-job/fluent-job-api].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [server].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [webapp].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [examples].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [core].
[INFO] There are no new bugs found totally].
[TRACE] SpotBugs diffs checked and reports created
[TRACE] Summary file size is 2614 bytes
[TRACE] Full summary file size is 1525 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/test-patch/tmp/SPOTBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/test-patch/tmp/SPOTBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3440

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any star imports
+1 the patch does not introduce any line longer than 132
+1 the patch adds/modifies 1 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 Javadoc generation succeeded with the patch
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
+1 There are no new bugs found in [sharelib/hive2].
+1 There are no new bugs found in [sharelib/spark].
+1 There are no new bugs found in [sharelib/oozie].
+1 There are no new bugs found in [sharelib/pig].
+1 There are no new bugs found in [sharelib/streaming].
+1 There are no new bugs found in [sharelib/hive].
+1 There are no new bugs found in [sharelib/distcp].
+1 There are no new bugs found in [sharelib/hcatalog].
+1 There are no new bugs found in [sharelib/sqoop].
+1 There are no new bugs found in [sharelib/git].
+1 There are no new bugs found in [client].
+1 There are no new bugs found in [docs].
+1 There are no new bugs found in [tools].
+1 There are no new bugs found in [fluent-job/fluent-job-api].
+1 There are no new bugs found in [server].
+1 There are no new bugs found in [webapp].
+1 There are no new bugs found in [examples].
+1 There are no new bugs found in [core].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 3140
Tests failed at first run:
TestPurgeXCommand#testSucceededWorkflowSucceededSubWorkflow
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


+1 Overall result, good!, no -1s

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/1023/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
 35070 0  100  3507  0   2820  0:00:01  0:00:01 --:--:--  
2819{"self":"https://issues.apache.org/jira/rest/api/2/issue/13217378/comment/16778227","id":"16778227","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&avatarId=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=hadoopqa&avatarId=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall

[jira] [Commented] (OOZIE-3441) Spark Action：Jackson version is too old 2.4.2

2019-02-26 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778174#comment-16778174
 ] 

Hadoop QA commented on OOZIE-3441:
--


Testing JIRA OOZIE-3441

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [21] new bugs found below threshold in total 
that must be fixed.
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:red}-1{color} There are [15] new bugs found below threshold in 
[tools] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones): 
tools/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At OozieDBCLI.java:[line 578]: This use of 
java/sql/Statement.executeUpdate(Ljava/lang/String;)I can be vulnerable to SQL 
injection
.At OozieDBCLI.java:[line 568]: At OozieDBCLI.java:[line 567]
.At OozieDBCLI.java:[line 571]: At OozieDBCLI.java:[line 569]
.At OozieDBCLI.java:[line 573]: At OozieDBCLI.java:[line 572]
.At OozieDBCLI.java:[line 578]: At OozieDBCLI.java:[line 575]
.{color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:red}-1{color} There are [6] new bugs found below threshold in 
[core] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 207]: This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176]
.At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200]
.This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207]
.At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128]
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3136
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/1022/



>

Failed: OOZIE-3441 PreCommit Build #1022

2019-02-26 Thread Apache Jenkins Server 
Jira: https://issues.apache.org/jira/browse/OOZIE-3441
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/1022/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.93 MB...]
[TRACE] SpotBugs diffs checked and reports created
[TRACE] Summary file size is 4085 bytes
[TRACE] Full summary file size is 9058 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/SPOTBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/SPOTBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3441

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any star imports
+1 the patch does not introduce any line longer than 132
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 Javadoc generation succeeded with the patch
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
-1 There are [21] new bugs found below threshold in total that must be fixed.
+1 There are no new bugs found in [sharelib/hive2].
+1 There are no new bugs found in [sharelib/spark].
+1 There are no new bugs found in [sharelib/oozie].
+1 There are no new bugs found in [sharelib/pig].
+1 There are no new bugs found in [sharelib/streaming].
+1 There are no new bugs found in [sharelib/hive].
+1 There are no new bugs found in [sharelib/distcp].
+1 There are no new bugs found in [sharelib/hcatalog].
+1 There are no new bugs found in [sharelib/sqoop].
+1 There are no new bugs found in [sharelib/git].
+1 There are no new bugs found in [client].
+1 There are no new bugs found in [docs].
-1 There are [15] new bugs found below threshold in [tools] that must be 
fixed, listing only the first [5] ones.
You can find the SpotBugs diff here (look for the red and orange ones): 
tools/findbugs-new.html
The top [5] most important SpotBugs errors are:
At OozieDBCLI.java:[line 578]: This use of 
java/sql/Statement.executeUpdate(Ljava/lang/String;)I can be vulnerable to SQL 
injection
At OozieDBCLI.java:[line 568]: At OozieDBCLI.java:[line 567]
At OozieDBCLI.java:[line 571]: At OozieDBCLI.java:[line 569]
At OozieDBCLI.java:[line 573]: At OozieDBCLI.java:[line 572]
At OozieDBCLI.java:[line 578]: At OozieDBCLI.java:[line 575]
+1 There are no new bugs found in [fluent-job/fluent-job-api].
+1 There are no new bugs found in [server].
+1 There are no new bugs found in [webapp].
+1 There are no new bugs found in [examples].
-1 There are [6] new bugs found below threshold in [core] that must be 
fixed, listing only the first [5] ones.
You can find the SpotBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
The top [5] most important SpotBugs errors are:
At BulkJPAExecutor.java:[line 207]: This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection
At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176]
At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200]
This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207]
At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128]
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 3136
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/1022/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  48200 0  100  4820  0   3649  0:00:01  0:00:01 --:--:--  
3651{"self"

Re: Review Request 70042: Oozie Spark action replaces path symlink # to %23

2019-02-26 Thread Denes Bodo 


> On Feb. 26, 2019, 12:08 p.m., Andras Salamon wrote:
> > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java
> > Lines 461 (patched)
> > 
> >
> > If neither positive nor negative is present, then the assertTrue above 
> > should give us an error.
> > 
> > If I understand correctly we reach this fail if the collection has no 
> > --files / --archives item.

Just in case if --files or --archives changes the test will let us know. I 
tried to provide meaningful error message, I hope I managed to.


- Denes


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70042/#review213221
---


On Feb. 26, 2019, 4:41 p.m., Denes Bodo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70042/
> ---
> 
> (Updated Feb. 26, 2019, 4:41 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-3440
> https://issues.apache.org/jira/browse/OOZIE-3440
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> Failing Oozie Launcher, Main class 
> [org.apache.oozie.action.hadoop.SparkMain], main() threw exception, File 
> file:/etc/spark2/conf/hive-site.xml%23hive-site.xml does not exist
> 
> 
> Diffs
> -
> 
>   
> sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java
>  28d9c5cc4 
>   
> sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java
>  7ccd26ad5 
> 
> 
> Diff: https://reviews.apache.org/r/70042/diff/3/
> 
> 
> Testing
> ---
> 
> Unit tests run
> 
> 
> Thanks,
> 
> Denes Bodo
> 
>

Re: Review Request 70042: Oozie Spark action replaces path symlink # to %23

2019-02-26 Thread Denes Bodo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70042/
---

(Updated Feb. 26, 2019, 4:41 p.m.)


Review request for oozie.


Bugs: OOZIE-3440
https://issues.apache.org/jira/browse/OOZIE-3440


Repository: oozie-git


Description
---

Failing Oozie Launcher, Main class [org.apache.oozie.action.hadoop.SparkMain], 
main() threw exception, File 
file:/etc/spark2/conf/hive-site.xml%23hive-site.xml does not exist


Diffs (updated)
-

  
sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java
 28d9c5cc4 
  
sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java
 7ccd26ad5 


Diff: https://reviews.apache.org/r/70042/diff/3/

Changes: https://reviews.apache.org/r/70042/diff/2-3/


Testing
---

Unit tests run


Thanks,

Denes Bodo

[jira] [Commented] (OOZIE-3440) Oozie Spark action replaces path symlink # to %23

2019-02-26 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778089#comment-16778089
 ] 

Hadoop QA commented on OOZIE-3440:
--

PreCommit-OOZIE-Build started


> Oozie Spark action replaces path symlink # to %23
> -
>
> Key: OOZIE-3440
> URL: https://issues.apache.org/jira/browse/OOZIE-3440
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Affects Versions: 4.3.1, 5.1.0
> Environment: Hadoop 2.7.3
> Spark 2 - 2.3.0
>Reporter: Denes Bodo
>Assignee: Denes Bodo
>Priority: Major
> Attachments: OOZIE-3440-001.patch, OOZIE-3440-002.patch, 
> OOZIE-3440-003.patch
>
>
> When we provide in a hive action:
>  * --files /etc/spark2/conf/hive-site.xml#hive-site.xml or
>  * /etc/spark2/conf/hive-site.xml#hive-site.xml or
> * hdfs:///tmp/spark2/conf/hive-site.xml#hive-site.xml or
>  * /etc/spark2/conf/hive-site.xml#hive-site.xml
> we get the following error:
> {code}
> Failing Oozie Launcher, Main class 
> [org.apache.oozie.action.hadoop.SparkMain], main() threw exception, File 
> file:/etc/spark2/conf/hive-site.xml%23hive-site.xml does not exist
> {code}
> The culprit seems to be 
> https://github.com/apache/oozie/blob/master/sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java#L480L489
>  .
> Please help me confirm if this is a bug or not. Meanwhile I am creating a 
> fix/workaround to this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3440) Oozie Spark action replaces path symlink # to %23

2019-02-26 Thread Denes Bodo (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OOZIE-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denes Bodo updated OOZIE-3440:
--
Attachment: OOZIE-3440-003.patch

> Oozie Spark action replaces path symlink # to %23
> -
>
> Key: OOZIE-3440
> URL: https://issues.apache.org/jira/browse/OOZIE-3440
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Affects Versions: 4.3.1, 5.1.0
> Environment: Hadoop 2.7.3
> Spark 2 - 2.3.0
>Reporter: Denes Bodo
>Assignee: Denes Bodo
>Priority: Major
> Attachments: OOZIE-3440-001.patch, OOZIE-3440-002.patch, 
> OOZIE-3440-003.patch
>
>
> When we provide in a hive action:
>  * --files /etc/spark2/conf/hive-site.xml#hive-site.xml or
>  * /etc/spark2/conf/hive-site.xml#hive-site.xml or
> * hdfs:///tmp/spark2/conf/hive-site.xml#hive-site.xml or
>  * /etc/spark2/conf/hive-site.xml#hive-site.xml
> we get the following error:
> {code}
> Failing Oozie Launcher, Main class 
> [org.apache.oozie.action.hadoop.SparkMain], main() threw exception, File 
> file:/etc/spark2/conf/hive-site.xml%23hive-site.xml does not exist
> {code}
> The culprit seems to be 
> https://github.com/apache/oozie/blob/master/sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java#L480L489
>  .
> Please help me confirm if this is a bug or not. Meanwhile I am creating a 
> fix/workaround to this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3395) [build] Migration from FindBugs to SpotBugs

2019-02-26 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778030#comment-16778030
 ] 

Hadoop QA commented on OOZIE-3395:
--


Testing JIRA OOZIE-3395

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [core].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3136
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/1021/



> [build] Migration from FindBugs to SpotBugs
> ---
>
> Key: OOZIE-3395
> URL: https://issues.apache.org/jira/browse/OOZIE-3395
> Project: Oozie
>  Issue Type: Task
>  Components: build
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Minor
> Fix For: 5.2.0
>
> Attachments: OOZIE-3395-001.patch, OOZIE-3395-002.patch, 
> OOZIE-3395-003.patch, OOZIE-3395-amend-001.patch
>
>
> https://gleclaire.github.io/findbugs-maven-plugin/
> {quote}
> Status: Since Findbugs is no longer maintained, please use Spotbugs which has 
> a Maven plugin.
> {quote}
> The plugin author recommends to migrate to Spotbugs: 
> https://spotbugs.github.io/
> It might  worth to investigate this plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: OOZIE-3395 PreCommit Build #1021

2019-02-26 Thread Apache Jenkins Server 
Jira: https://issues.apache.org/jira/browse/OOZIE-3395
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/1021/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.93 MB...]
[DEBUG] There are no new bugs found in [docs].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [tools].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [fluent-job/fluent-job-api].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [server].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [webapp].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [examples].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [core].
[INFO] There are no new bugs found totally].
[TRACE] SpotBugs diffs checked and reports created
[TRACE] Summary file size is 2615 bytes
[TRACE] Full summary file size is 1525 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/test-patch/tmp/SPOTBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/test-patch/tmp/SPOTBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3395

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any star imports
+1 the patch does not introduce any line longer than 132
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 Javadoc generation succeeded with the patch
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
+1 There are no new bugs found in [sharelib/hive2].
+1 There are no new bugs found in [sharelib/spark].
+1 There are no new bugs found in [sharelib/oozie].
+1 There are no new bugs found in [sharelib/pig].
+1 There are no new bugs found in [sharelib/streaming].
+1 There are no new bugs found in [sharelib/hive].
+1 There are no new bugs found in [sharelib/distcp].
+1 There are no new bugs found in [sharelib/hcatalog].
+1 There are no new bugs found in [sharelib/sqoop].
+1 There are no new bugs found in [sharelib/git].
+1 There are no new bugs found in [client].
+1 There are no new bugs found in [docs].
+1 There are no new bugs found in [tools].
+1 There are no new bugs found in [fluent-job/fluent-job-api].
+1 There are no new bugs found in [server].
+1 There are no new bugs found in [webapp].
+1 There are no new bugs found in [examples].
+1 There are no new bugs found in [core].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 3136
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/1021/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  33360 0  100  3336  0   2870  0:00:01  0:00:01 --:--:--  
2870{"self":"https://issues.apache.org/jira/rest/api/2/issue/13201284/comment/16778030","id":"16778030","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&avatarId=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=hadoopqa&avatarId=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=hadoopqa&avatarId=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?s

[jira] [Commented] (OOZIE-3441) Spark Action：Jackson version is too old 2.4.2

2019-02-26 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778012#comment-16778012
 ] 

Hadoop QA commented on OOZIE-3441:
--

PreCommit-OOZIE-Build started


> Spark Action：Jackson version is too old 2.4.2
> -
>
> Key: OOZIE-3441
> URL: https://issues.apache.org/jira/browse/OOZIE-3441
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Affects Versions: 5.1.0
>Reporter: duan xiong
>Assignee: duan xiong
>Priority: Critical
> Attachments: oozie-3441-001.patch
>
>
> When I install oozie 5.1.0, I run Spark Action Demo.It failed.In Yarn log,It 
> shows:
> {color:#FF}Caused By : 
> com.fasterxml.jackson.databind.JsonMappingException: Jackson version is too 
> old 2.4.2 Failing Oozie Launcher,null{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3441) Spark Action：Jackson version is too old 2.4.2

2019-02-26 Thread duan xiong (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778011#comment-16778011
 ] 

duan xiong commented on OOZIE-3441:
---

[~kmarton]，OK，Thank you very much.

> Spark Action：Jackson version is too old 2.4.2
> -
>
> Key: OOZIE-3441
> URL: https://issues.apache.org/jira/browse/OOZIE-3441
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Affects Versions: 5.1.0
>Reporter: duan xiong
>Assignee: duan xiong
>Priority: Critical
> Attachments: oozie-3441-001.patch
>
>
> When I install oozie 5.1.0, I run Spark Action Demo.It failed.In Yarn log,It 
> shows:
> {color:#FF}Caused By : 
> com.fasterxml.jackson.databind.JsonMappingException: Jackson version is too 
> old 2.4.2 Failing Oozie Launcher,null{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3441) Spark Action：Jackson version is too old 2.4.2

2019-02-26 Thread Julia Kinga Marton (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778004#comment-16778004
 ] 

Julia Kinga Marton commented on OOZIE-3441:
---

The bugs reported by Spotbugs are unrelated. I have to check why it is 
complaining now about those issues, what are present in the pre-patched version 
as well.

> Spark Action：Jackson version is too old 2.4.2
> -
>
> Key: OOZIE-3441
> URL: https://issues.apache.org/jira/browse/OOZIE-3441
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Affects Versions: 5.1.0
>Reporter: duan xiong
>Assignee: duan xiong
>Priority: Critical
> Attachments: oozie-3441-001.patch
>
>
> When I install oozie 5.1.0, I run Spark Action Demo.It failed.In Yarn log,It 
> shows:
> {color:#FF}Caused By : 
> com.fasterxml.jackson.databind.JsonMappingException: Jackson version is too 
> old 2.4.2 Failing Oozie Launcher,null{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3416) Incorporate dbd and dbd testing into Apache Oozie/tools

2019-02-26 Thread Peter Cseh (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777985#comment-16777985
 ] 

Peter Cseh commented on OOZIE-3416:
---

We've successfully made a green run from [~daniel.becker]'s repository:
https://builds.apache.org/job/oozie-master-testing/job/testing/16/
I'd be happy to change the configuration to get the jenkinsfile from the 
Oozie's repository once it's committed.

> Incorporate dbd and dbd testing into Apache Oozie/tools
> ---
>
> Key: OOZIE-3416
> URL: https://issues.apache.org/jira/browse/OOZIE-3416
> Project: Oozie
>  Issue Type: Task
>  Components: tools
>Affects Versions: 5.1.0
>Reporter: Julia Kinga Marton
>Assignee: Julia Kinga Marton
>Priority: Major
>
> [~daniel.becker] implemented a dockerised integration testing framework.
> It consists of two repositories:
>  * dbd - [https://github.com/d-becker/dbd]This tool’s aim is to make it easy 
> to set up a working dockerized big data infrastructure where the versions of 
> the components (Hadoop, Hive, Oozie etc.) can be set individually, and even 
> unreleased snapshot builds can be used.
>  * oozie-dbd-testing - [https://github.com/d-becker/oozie-dbd-testing] This 
> is the repository that contains the scripts and the Jenkins job definition 
> used to test Oozie. It runs the Oozie examples and the fluent job examples 
> and produces a report. To set up a Jenkins job, use the "Multibranch 
> pipeline" project type.
> Now, that this tools are working, we should integrate them in the Apache 
> Oozie repository next to the other tools.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3441) Spark Action：Jackson version is too old 2.4.2

2019-02-26 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777976#comment-16777976
 ] 

Hadoop QA commented on OOZIE-3441:
--


Testing JIRA OOZIE-3441

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [21] new bugs found below threshold in total 
that must be fixed.
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:red}-1{color} There are [15] new bugs found below threshold in 
[tools] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones): 
tools/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At OozieDBCLI.java:[line 578]: This use of 
java/sql/Statement.executeUpdate(Ljava/lang/String;)I can be vulnerable to SQL 
injection
.At OozieDBCLI.java:[line 568]: At OozieDBCLI.java:[line 567]
.At OozieDBCLI.java:[line 571]: At OozieDBCLI.java:[line 569]
.At OozieDBCLI.java:[line 573]: At OozieDBCLI.java:[line 572]
.At OozieDBCLI.java:[line 578]: At OozieDBCLI.java:[line 575]
.{color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:red}-1{color} There are [6] new bugs found below threshold in 
[core] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 207]: This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176]
.At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200]
.This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207]
.At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128]
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3136
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/1020/



>

Failed: OOZIE-3441 PreCommit Build #1020

2019-02-26 Thread Apache Jenkins Server 
Jira: https://issues.apache.org/jira/browse/OOZIE-3441
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/1020/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.94 MB...]
[TRACE] SpotBugs diffs checked and reports created
[TRACE] Summary file size is 4085 bytes
[TRACE] Full summary file size is 9058 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/SPOTBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/SPOTBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3441

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any star imports
+1 the patch does not introduce any line longer than 132
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 Javadoc generation succeeded with the patch
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
-1 There are [21] new bugs found below threshold in total that must be fixed.
+1 There are no new bugs found in [sharelib/hive2].
+1 There are no new bugs found in [sharelib/spark].
+1 There are no new bugs found in [sharelib/oozie].
+1 There are no new bugs found in [sharelib/pig].
+1 There are no new bugs found in [sharelib/streaming].
+1 There are no new bugs found in [sharelib/hive].
+1 There are no new bugs found in [sharelib/distcp].
+1 There are no new bugs found in [sharelib/hcatalog].
+1 There are no new bugs found in [sharelib/sqoop].
+1 There are no new bugs found in [sharelib/git].
+1 There are no new bugs found in [client].
+1 There are no new bugs found in [docs].
-1 There are [15] new bugs found below threshold in [tools] that must be 
fixed, listing only the first [5] ones.
You can find the SpotBugs diff here (look for the red and orange ones): 
tools/findbugs-new.html
The top [5] most important SpotBugs errors are:
At OozieDBCLI.java:[line 578]: This use of 
java/sql/Statement.executeUpdate(Ljava/lang/String;)I can be vulnerable to SQL 
injection
At OozieDBCLI.java:[line 568]: At OozieDBCLI.java:[line 567]
At OozieDBCLI.java:[line 571]: At OozieDBCLI.java:[line 569]
At OozieDBCLI.java:[line 573]: At OozieDBCLI.java:[line 572]
At OozieDBCLI.java:[line 578]: At OozieDBCLI.java:[line 575]
+1 There are no new bugs found in [fluent-job/fluent-job-api].
+1 There are no new bugs found in [server].
+1 There are no new bugs found in [webapp].
+1 There are no new bugs found in [examples].
-1 There are [6] new bugs found below threshold in [core] that must be 
fixed, listing only the first [5] ones.
You can find the SpotBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
The top [5] most important SpotBugs errors are:
At BulkJPAExecutor.java:[line 207]: This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection
At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176]
At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200]
This use of 
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
 can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207]
At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128]
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 3136
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/1020/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  48200 0  100  4820  0   4497  0:00:01  0:00:01 --:--:--  
4500{"self"

[jira] [Commented] (OOZIE-3395) [build] Migration from FindBugs to SpotBugs

2019-02-26 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777904#comment-16777904
 ] 

Hadoop QA commented on OOZIE-3395:
--

PreCommit-OOZIE-Build started


> [build] Migration from FindBugs to SpotBugs
> ---
>
> Key: OOZIE-3395
> URL: https://issues.apache.org/jira/browse/OOZIE-3395
> Project: Oozie
>  Issue Type: Task
>  Components: build
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Minor
> Fix For: 5.2.0
>
> Attachments: OOZIE-3395-001.patch, OOZIE-3395-002.patch, 
> OOZIE-3395-003.patch, OOZIE-3395-amend-001.patch
>
>
> https://gleclaire.github.io/findbugs-maven-plugin/
> {quote}
> Status: Since Findbugs is no longer maintained, please use Spotbugs which has 
> a Maven plugin.
> {quote}
> The plugin author recommends to migrate to Spotbugs: 
> https://spotbugs.github.io/
> It might  worth to investigate this plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (OOZIE-3395) [build] Migration from FindBugs to SpotBugs

2019-02-26 Thread Julia Kinga Marton (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777896#comment-16777896
 ] 

Julia Kinga Marton edited comment on OOZIE-3395 at 2/26/19 1:14 PM:


Thank you [~asalamon74] for pointing this out!

I have uploaded an amend patch with the fix.

I have mixed feelings with the way we download and check the findbugs jar.
 Now we have in our repository the [md5 hash of the 
jar|https://github.com/apache/oozie/blob/master/bin/findbugs-diff-0.1.0-all.jar.md5]
 , we calculate the hash of the downloaded jar and we compare with this value.

I am wondering if anybody has any other nicer idea to solve this. [~asalamon74]?


was (Author: kmarton):
Thank you [~asalamon74] for pointing this out!

I have uploaded an amend patch with the fix.

I have mixed feelings with the way we download and check the findbugs jar.
 Now we have in our repository the [md5 hash of the 
jar|https://github.com/apache/oozie/blob/master/bin/findbugs-diff-0.1.0-all.jar.md5]
 , we calculate the hash of the downloaded jar and we compare with this value.

I am wondering if anybody has any other nicer idea to solve this.

> [build] Migration from FindBugs to SpotBugs
> ---
>
> Key: OOZIE-3395
> URL: https://issues.apache.org/jira/browse/OOZIE-3395
> Project: Oozie
>  Issue Type: Task
>  Components: build
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Minor
> Fix For: 5.2.0
>
> Attachments: OOZIE-3395-001.patch, OOZIE-3395-002.patch, 
> OOZIE-3395-003.patch, OOZIE-3395-amend-001.patch
>
>
> https://gleclaire.github.io/findbugs-maven-plugin/
> {quote}
> Status: Since Findbugs is no longer maintained, please use Spotbugs which has 
> a Maven plugin.
> {quote}
> The plugin author recommends to migrate to Spotbugs: 
> https://spotbugs.github.io/
> It might  worth to investigate this plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3395) [build] Migration from FindBugs to SpotBugs

2019-02-26 Thread Julia Kinga Marton (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OOZIE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julia Kinga Marton updated OOZIE-3395:
--
Attachment: OOZIE-3395-amend-001.patch

> [build] Migration from FindBugs to SpotBugs
> ---
>
> Key: OOZIE-3395
> URL: https://issues.apache.org/jira/browse/OOZIE-3395
> Project: Oozie
>  Issue Type: Task
>  Components: build
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Minor
> Fix For: 5.2.0
>
> Attachments: OOZIE-3395-001.patch, OOZIE-3395-002.patch, 
> OOZIE-3395-003.patch, OOZIE-3395-amend-001.patch
>
>
> https://gleclaire.github.io/findbugs-maven-plugin/
> {quote}
> Status: Since Findbugs is no longer maintained, please use Spotbugs which has 
> a Maven plugin.
> {quote}
> The plugin author recommends to migrate to Spotbugs: 
> https://spotbugs.github.io/
> It might  worth to investigate this plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3441) Spark Action：Jackson version is too old 2.4.2

2019-02-26 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777870#comment-16777870
 ] 

Hadoop QA commented on OOZIE-3441:
--

PreCommit-OOZIE-Build started


> Spark Action：Jackson version is too old 2.4.2
> -
>
> Key: OOZIE-3441
> URL: https://issues.apache.org/jira/browse/OOZIE-3441
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Affects Versions: 5.1.0
>Reporter: duan xiong
>Assignee: duan xiong
>Priority: Critical
> Attachments: oozie-3441-001.patch
>
>
> When I install oozie 5.1.0, I run Spark Action Demo.It failed.In Yarn log,It 
> shows:
> {color:#FF}Caused By : 
> com.fasterxml.jackson.databind.JsonMappingException: Jackson version is too 
> old 2.4.2 Failing Oozie Launcher,null{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3441) Spark Action：Jackson version is too old 2.4.2

2019-02-26 Thread duan xiong (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OOZIE-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

duan xiong updated OOZIE-3441:
--
Attachment: oozie-3441-001.patch

> Spark Action：Jackson version is too old 2.4.2
> -
>
> Key: OOZIE-3441
> URL: https://issues.apache.org/jira/browse/OOZIE-3441
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Affects Versions: 5.1.0
>Reporter: duan xiong
>Assignee: duan xiong
>Priority: Critical
> Attachments: oozie-3441-001.patch
>
>
> When I install oozie 5.1.0, I run Spark Action Demo.It failed.In Yarn log,It 
> shows:
> {color:#FF}Caused By : 
> com.fasterxml.jackson.databind.JsonMappingException: Jackson version is too 
> old 2.4.2 Failing Oozie Launcher,null{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3440) Oozie Spark action replaces path symlink # to %23

2019-02-26 Thread Andras Salamon (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777823#comment-16777823
 ] 

Andras Salamon commented on OOZIE-3440:
---

Thanks [~dionusos] for the new patch, I left a few comments on the review board.

> Oozie Spark action replaces path symlink # to %23
> -
>
> Key: OOZIE-3440
> URL: https://issues.apache.org/jira/browse/OOZIE-3440
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Affects Versions: 4.3.1, 5.1.0
> Environment: Hadoop 2.7.3
> Spark 2 - 2.3.0
>Reporter: Denes Bodo
>Assignee: Denes Bodo
>Priority: Major
> Attachments: OOZIE-3440-001.patch, OOZIE-3440-002.patch
>
>
> When we provide in a hive action:
>  * --files /etc/spark2/conf/hive-site.xml#hive-site.xml or
>  * /etc/spark2/conf/hive-site.xml#hive-site.xml or
> * hdfs:///tmp/spark2/conf/hive-site.xml#hive-site.xml or
>  * /etc/spark2/conf/hive-site.xml#hive-site.xml
> we get the following error:
> {code}
> Failing Oozie Launcher, Main class 
> [org.apache.oozie.action.hadoop.SparkMain], main() threw exception, File 
> file:/etc/spark2/conf/hive-site.xml%23hive-site.xml does not exist
> {code}
> The culprit seems to be 
> https://github.com/apache/oozie/blob/master/sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java#L480L489
>  .
> Please help me confirm if this is a bug or not. Meanwhile I am creating a 
> fix/workaround to this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 70042: Oozie Spark action replaces path symlink # to %23

2019-02-26 Thread Andras Salamon 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70042/#review213221
---




sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java
Line 490 (original), 490 (patched)


Could you please add @VisibleForTesting



sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java
Lines 22 (patched)


Do we really use this class?



sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java
Lines 402-403 (patched)


Could be private



sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java
Lines 415 (patched)


Unfortunately we use a mixture of Junit3, Junit4. To make it very clear 
that this is not a test method, just a helper method called by other test 
methods I would choose an other prefix instead of 'test'.

It could also be private



sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java
Lines 417-418 (patched)


Can you extract the Configuration variable. We need to break the long line 
anyway.



sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java
Lines 422-423 (patched)


Can you extract the Configuration variable. We need to break the long line 
anyway.



sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java
Lines 432 (patched)


Couldn't we remove the new URI[] part? Like

Arrays.asList(new Path(LOCAL_FILE).toUri(),
  new Path(HDFS_FILE).toUri())



sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java
Lines 454 (patched)


Couldn't we use equals instead of startsWith?



sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java
Lines 461 (patched)


If neither positive nor negative is present, then the assertTrue above 
should give us an error.

If I understand correctly we reach this fail if the collection has no 
--files / --archives item.


- Andras Salamon


On Feb. 25, 2019, 12:42 p.m., Denes Bodo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70042/
> ---
> 
> (Updated Feb. 25, 2019, 12:42 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-3440
> https://issues.apache.org/jira/browse/OOZIE-3440
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> Failing Oozie Launcher, Main class 
> [org.apache.oozie.action.hadoop.SparkMain], main() threw exception, File 
> file:/etc/spark2/conf/hive-site.xml%23hive-site.xml does not exist
> 
> 
> Diffs
> -
> 
>   
> sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java
>  28d9c5cc4 
>   
> sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java
>  7ccd26ad5 
> 
> 
> Diff: https://reviews.apache.org/r/70042/diff/2/
> 
> 
> Testing
> ---
> 
> Unit tests run
> 
> 
> Thanks,
> 
> Denes Bodo
> 
>

[jira] [Updated] (OOZIE-3335) Cleanup parseFilter methods

2019-02-26 Thread Andras Salamon (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OOZIE-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Salamon updated OOZIE-3335:
--
Description: 
The {{parseFilter}} method is implemented several times in oozie:
{noformat}
servlet/SLAServlet.java
util/JobsFilterUtils.java
DagEngine.java
CoordinatorEngine.java (parseJobFilter and parseJobsFilter methods)
BundleEngine.java (parseBulkFilter method){noformat}
The implementations are quite similar. Code duplication should be eliminated.

OOZIE-3229 will introduce a new utility class for filter parsing, all the other 
classes should use it as well.

  was:
The {{parseFilter}} method is implemented several times in oozie:
{noformat}
servlet/SLAServlet.java
util/JobsFilterUtils.java
DagEngine.java
CoordinatorEngine.java (parseJobFilter and parseJobsFilter methods){noformat}
The implementations are quite similar. Code duplication should be eliminated.

OOZIE-3229 will introduce a new utility class for filter parsing, all the other 
classes should use it as well.


> Cleanup parseFilter methods
> ---
>
> Key: OOZIE-3335
> URL: https://issues.apache.org/jira/browse/OOZIE-3335
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: trunk
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Minor
>
> The {{parseFilter}} method is implemented several times in oozie:
> {noformat}
> servlet/SLAServlet.java
> util/JobsFilterUtils.java
> DagEngine.java
> CoordinatorEngine.java (parseJobFilter and parseJobsFilter methods)
> BundleEngine.java (parseBulkFilter method){noformat}
> The implementations are quite similar. Code duplication should be eliminated.
> OOZIE-3229 will introduce a new utility class for filter parsing, all the 
> other classes should use it as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)