[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[
https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491324#comment-15491324
]
Hadoop QA commented on OOZIE-2530:
--
Testing JIRA OOZIE-2530
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1804
.Tests failed: 0
.Tests errors: 1
.The patch failed the following testcases:
.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3269/
> Remove jline from parent and sharelib pig pom
> -
>
> Key: OOZIE-2530
> URL: https://issues.apache.org/jira/browse/OOZIE-2530
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: trunk
>Reporter: Thomas Poepping
> Attachments: OOZIE-2530.01.patch, OOZIE-2530.02.patch,
> OOZIE-2530.03.patch, OOZIE-2530.patch
>
>
> This patch removes an unnecessary hardcoded dependency on jline in the oozie
> parent pom and pig sharelib pom.
> The jline dependencies were required before OOZIE-704, which removed the
> direct dependencies on jline in oozie code. Since that patch, the direct
> dependency on jline in oozie has been unnecessary. This will also fix
> OOZIE-2409.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491029#comment-15491029 ] Thomas Poepping commented on OOZIE-2530: You're right, oops. Uploading a new patch now. > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.02.patch, > OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438618#comment-15438618 ] Robert Kanter commented on OOZIE-2530: -- Don't we also need to have the jline version apply to the hive2 sharelib? > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.02.patch, > OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[
https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435573#comment-15435573
]
Hadoop QA commented on OOZIE-2530:
--
Testing JIRA OOZIE-2530
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1798
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3238/
> Remove jline from parent and sharelib pig pom
> -
>
> Key: OOZIE-2530
> URL: https://issues.apache.org/jira/browse/OOZIE-2530
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: trunk
>Reporter: Thomas Poepping
> Attachments: OOZIE-2530.01.patch, OOZIE-2530.02.patch,
> OOZIE-2530.patch
>
>
> This patch removes an unnecessary hardcoded dependency on jline in the oozie
> parent pom and pig sharelib pom.
> The jline dependencies were required before OOZIE-704, which removed the
> direct dependencies on jline in oozie code. Since that patch, the direct
> dependency on jline in oozie has been unnecessary. This will also fix
> OOZIE-2409.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435378#comment-15435378 ] Thomas Poepping commented on OOZIE-2530: new diff attached, appreciate comments. > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.02.patch, > OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419156#comment-15419156 ] Thomas Poepping commented on OOZIE-2530: Yes Robert, sounds good. I should be able to attach an updated patch later today. > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[
https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404530#comment-15404530
]
Robert Kanter commented on OOZIE-2530:
--
As I said before, we have multiple components, needing different versions of
jline. To allow for this, we need to figure out the correct versions for each
component and set those in the sharelibs. It seems like Pig isn't pulling in
jline as a transitive dependency, which is unfortunate, as it makes this more
of a burden on Oozie.
Looking at the current versions of jline after building Oozie, I see:
{noformat}
./sharelib/target/oozie-sharelib-4.3.0-SNAPSHOT/share/lib/hive/jline-0.9.94.jar
./sharelib/target/oozie-sharelib-4.3.0-SNAPSHOT/share/lib/hive2/jline-0.9.94.jar
./sharelib/target/oozie-sharelib-4.3.0-SNAPSHOT/share/lib/pig/jline-0.9.94.jar
./sharelib/target/oozie-sharelib-4.3.0-SNAPSHOT/share/lib/spark/jline-0.9.94.jar
./sharelib/target/oozie-sharelib-4.3.0-SNAPSHOT/share/lib/spark/jline-2.10.5.jar
./webapp/target/oozie-webapp-4.3.0-SNAPSHOT/WEB-INF/lib/jline-0.9.94.jar
{noformat}
As it stands, Everything (by default) is using jline 0.9.94, though Spark
somehow has two versions of it. Given that, I'd say that the correct thing
here would be to do something like OOZIE-2409, which specified a different
version for Hive. I think what we should do here is to leave jline to 0.9.94
as-is, add a new {{hive.jline.version}} property in the root pom, set to 0.9.94
by default for now (we can change it later if we update the minimum Hive
version), and have the Hive sharelibs use {{hive.jline.version}}. That's the
same way we handle a newer guava version for Spark (see
{{spark.guava.version}}).
Sounds good?
> Remove jline from parent and sharelib pig pom
> -
>
> Key: OOZIE-2530
> URL: https://issues.apache.org/jira/browse/OOZIE-2530
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: trunk
>Reporter: Thomas Poepping
> Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch
>
>
> This patch removes an unnecessary hardcoded dependency on jline in the oozie
> parent pom and pig sharelib pom.
> The jline dependencies were required before OOZIE-704, which removed the
> direct dependencies on jline in oozie code. Since that patch, the direct
> dependency on jline in oozie has been unnecessary. This will also fix
> OOZIE-2409.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402643#comment-15402643 ] Thomas Poepping commented on OOZIE-2530: Bump? > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398118#comment-15398118 ] Thomas Poepping commented on OOZIE-2530: Pig directly depends on jline as a compile dependency. In my testing, it looks like the pig sharelib should transitively load the required jline dependency from the dependency on org.apache.pig, removing the requirement for the explicit dependency. The reason for this patch is that other sharelibs (like Hive) also depend on jline, but on a later incompatible version. If there is an explicit dependency defined in the root pom, then the transitive jline dependency loaded from the hive jars for the hive sharelib will be managed to the incompatible version, causing Hive actions to fail. Does Oozie not have any integration tests that install oozie, install the sharelib, and run through the examples? That would answer our question. > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[
https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396835#comment-15396835
]
Hadoop QA commented on OOZIE-2530:
--
Testing JIRA OOZIE-2530
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:red}-1 COMPILE{color}
.{color:red}-1{color} HEAD does not compile
.{color:red}-1{color} patch does not compile
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3098/
> Remove jline from parent and sharelib pig pom
> -
>
> Key: OOZIE-2530
> URL: https://issues.apache.org/jira/browse/OOZIE-2530
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: trunk
>Reporter: Thomas Poepping
> Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch
>
>
> This patch removes an unnecessary hardcoded dependency on jline in the oozie
> parent pom and pig sharelib pom.
> The jline dependencies were required before OOZIE-704, which removed the
> direct dependencies on jline in oozie code. Since that patch, the direct
> dependency on jline in oozie has been unnecessary. This will also fix
> OOZIE-2409.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344728#comment-15344728 ] Rohini Palaniswamy commented on OOZIE-2530: --- bq. which leads me to believe it isn't needed by any components (pig included) Pig does need it in the sharelib, else pig scripts cannot run. It is not needed in the Oozie server. bq. You should build Oozie with no changes, and look for jline jar files to see which sharelibs should have it. That's right. > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340580#comment-15340580 ] Robert Kanter commented on OOZIE-2530: -- The problem is that while Oozie might not need jline, the components we run or the user code they run might need them (or maybe only when certain features are used). So we need to include it with components that _might_ need it, rather than components that need it during compilation. This is the case with most 3rd party dependencies we add in the sharelibs. Given that nobody has been filing JIRAs to add jline to any of the other components, I'd say that what we currently have is correct. You should build Oozie with no changes, and look for jline jar files to see which sharelibs should have it. It would then be a good idea to look at the poms from those components to make sure we have the correct version. > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340455#comment-15340455 ] Thomas Poepping commented on OOZIE-2530: Do you have a recommendation for how we can figure out which component needs jline? Compiling oozie with no direct jline dependencies succeeds, which leads me to believe it isn't needed by any components (pig included) > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340259#comment-15340259 ] Robert Kanter commented on OOZIE-2530: -- We should figure out which versions of jline are used by each component that needs it. Then we'll have to add a direct dependency to each of those sharelib poms so that we can override the version there to specify the correct version that it needs. If we're lucky, they all need a single version, or most of them need the same, in which case we can mostly use a version defined in the root pom and only override one of them, but it will depend. > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340212#comment-15340212 ] Thomas Poepping commented on OOZIE-2530: What would be your suggested course of action here? Add the jline dependency back in the pig sharelib pom? > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336112#comment-15336112 ] Rohini Palaniswamy commented on OOZIE-2530: --- Pig does need jline > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332531#comment-15332531 ] Robert Kanter commented on OOZIE-2530: -- I like this fix better than OOZIE-2409. It looks like Spark also brings in jline as a transitive dependency, so it's probably best that we leave it alone given that Oozie itself doesn't need jline. However, Pig isn't pulling jline in as a transitive dependency. Does Pig need jline? [~rohini]? > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323133#comment-15323133 ] Thomas Poepping commented on OOZIE-2530: Ping? > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284920#comment-15284920 ] Thomas Poepping commented on OOZIE-2530: This test doesn't appear to be related. Can I get something on this issue? > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[
https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283177#comment-15283177
]
Hadoop QA commented on OOZIE-2530:
--
Testing JIRA OOZIE-2530
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1777
.Tests failed: 1
.Tests errors: 0
.The patch failed the following testcases:
.
testMessage_withMixedStatus(org.apache.oozie.command.coord.TestAbandonedCoordChecker)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/2880/
> Remove jline from parent and sharelib pig pom
> -
>
> Key: OOZIE-2530
> URL: https://issues.apache.org/jira/browse/OOZIE-2530
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: trunk
>Reporter: Thomas Poepping
> Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch
>
>
> This patch removes an unnecessary hardcoded dependency on jline in the oozie
> parent pom and pig sharelib pom.
> The jline dependencies were required before OOZIE-704, which removed the
> direct dependencies on jline in oozie code. Since that patch, the direct
> dependency on jline in oozie has been unnecessary. This will also fix
> OOZIE-2409.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283047#comment-15283047 ] Thomas Poepping commented on OOZIE-2530: https://reviews.apache.org/r/47351/ > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[ https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283043#comment-15283043 ] Thomas Poepping commented on OOZIE-2530: Patch applies cleanly to master in my workspace -- resubmitting patch with slightly different diff format. > Remove jline from parent and sharelib pig pom > - > > Key: OOZIE-2530 > URL: https://issues.apache.org/jira/browse/OOZIE-2530 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Thomas Poepping > Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch > > > This patch removes an unnecessary hardcoded dependency on jline in the oozie > parent pom and pig sharelib pom. > The jline dependencies were required before OOZIE-704, which removed the > direct dependencies on jline in oozie code. Since that patch, the direct > dependency on jline in oozie has been unnecessary. This will also fix > OOZIE-2409. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2530) Remove jline from parent and sharelib pig pom
[
https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283028#comment-15283028
]
Hadoop QA commented on OOZIE-2530:
--
Testing JIRA OOZIE-2530
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> Remove jline from parent and sharelib pig pom
> -
>
> Key: OOZIE-2530
> URL: https://issues.apache.org/jira/browse/OOZIE-2530
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: trunk
>Reporter: Thomas Poepping
> Attachments: OOZIE-2530.patch
>
>
> This patch removes an unnecessary hardcoded dependency on jline in the oozie
> parent pom and pig sharelib pom.
> The jline dependencies were required before OOZIE-704, which removed the
> direct dependencies on jline in oozie code. Since that patch, the direct
> dependency on jline in oozie has been unnecessary. This will also fix
> OOZIE-2409.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
