[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2022-08-17 Thread Jira


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580627#comment-17580627
 ] 

Dénes Bodó commented on OOZIE-3136:
---

[~rohini] as there is no answer from the people who worked on them before I 
encourage you to upload your patch here. Let's see the magic. ;) If possible, 
please also put the change on review board too.

Thanks,

Denes

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvári
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2022-08-13 Thread Rohini Palaniswamy (Jira)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579253#comment-17579253
 ] 

Rohini Palaniswamy commented on OOZIE-3136:
---

Is anyone working on this? I did migrate Oozie completely to 2.x (just deployed 
internally and seems to be good) and can put up the patch for review. Local and 
mini oozie are yet to be done but I can get that done soon. The Oozie client 
and server will be on 2.x but launched jobs will still be on hadoop 1.x till 
Hadoop migrates. 

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvári
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-10-11 Thread Robert Kanter (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646713#comment-16646713
 ] 

Robert Kanter commented on OOZIE-3136:
--

You probably don't need to create two full LocalOozie/MiniOozie instances; just 
two (or more) of the XLogService and maybe some others - that'll help cut down 
on any interference we might get from running two Oozies on the same machine.  
There may be other options two; for instance, TestZKXLogStreamingService 
actually tests log streaming from another server by making a dummy servlet.

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-10-11 Thread Andras Piros (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646253#comment-16646253
 ] 

Andras Piros commented on OOZIE-3136:
-

[~pbacsko] a nice writeup, thanks! I guess to 6) we need more coverage on 
integration test side, like running two {{LocalOozie}} / {{MiniOozie}} 
instances that write logs at the same time, and then try to aggregate the maybe 
overflowing but unified logs. We could even make stress tests given a similar 
scenario.

Otherwise it really looks like a viable plan now.

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-10-10 Thread Peter Bacsko (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644531#comment-16644531
 ] 

Peter Bacsko commented on OOZIE-3136:
-

So looks like the plan is

# Add log4j-api12 dependency
# Remove log4j-specific calls from XLogService, add new log4j2 setup code
# Rewrite OozieRollingPolicy or rewrite streaming code
# Adapt the remaining classes to log4j2:
* TestXLogService.java
* TestXLogStreamingService.java
* XLogUtil.java
* LocalOozie.java
* TestSignalXCommand.java
* ... some other test classes
# Remove log4j dependency
# Test like crazy, especially streaming and backward compatibility

Anything I missed?

Can we give a possible ETA to the Bigtop guys? I assume it's at least 4-5 
weeks, perhaps more.


> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-10-09 Thread Robert Kanter (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643738#comment-16643738
 ] 

Robert Kanter commented on OOZIE-3136:
--

+1 on not going to log4j2 until Oozie 6. Cleaning up our logging story and 
using the bridge in the meantime is probably a good idea.

Our logging is somewhat brittle because of the log streaming. IIRC, we require 
log files to be rolled every hour because the log streaming makes some 
assumptions about that to improve performance. Similarly, logs can be 
automatically gzipped, but we also make assumptions about that and the 
filenames. That's part of what the {{OozieRollingPolicy}} was for (it used to 
be messier before I added it :)). So if we need to get rid of 
{{OozieRollingPolicy}}, then we'll need to either replace it with something 
equivalent, or refactor the log streaming code to be more flexible.

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-10-09 Thread Peter Cseh (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643244#comment-16643244
 ] 

Peter Cseh commented on OOZIE-3136:
---

Additionally we have our own Policy: 
https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java



> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-10-09 Thread Peter Bacsko (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643106#comment-16643106
 ] 

Peter Bacsko commented on OOZIE-3136:
-

Well, yeah, we do access log4j directly:

https://github.com/apache/oozie/blob/ba665da34c23b1fa86bf1570724147e6f8c85b1d/core/src/main/java/org/apache/oozie/service/XLogService.java#L149

https://github.com/apache/oozie/blob/ba665da34c23b1fa86bf1570724147e6f8c85b1d/core/src/main/java/org/apache/oozie/service/XLogService.java#L174-L178

We must go through the whole code to see if there's any direct calls to Log4j 
classes, then we have to rewrite them appropriately...

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-10-09 Thread Peter Bacsko (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643098#comment-16643098
 ] 

Peter Bacsko commented on OOZIE-3136:
-

Regarding the bridge, check this out: 
https://logging.apache.org/log4j/log4j-2.2/log4j-1.2-api/index.html

"To use the Log4j Legacy Bridge just remove all the Log4j 1.x jars from the 
application and replace them with the bridge jar. Once in place all logging 
that uses Log4j 1.x will be routed to Log4j 2. *However, applications that 
attempt to modify legacy Log4j by adding Appenders, Filters, etc may experience 
problems if they try to verify the success of these actions as these methods 
are largely no-ops*."

Do we do anything like that? I mean, messing around log4j classes directly. 
This must be checked.

If we directly use stuff like {{PropertyConfigurator}}, that's a no-op in the 
bridge. We must also make sure that initial {{Logger.getlogger()}} calls 
configure the Log4j2 based on the original log4j properties file. I just 
checked this and does not seem to be the case - there is a converter class, but 
looks like we have to call that manually. 

So there are quite a few things to consider/validate here.

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-10-09 Thread Peter Bacsko (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643051#comment-16643051
 ] 

Peter Bacsko commented on OOZIE-3136:
-

I do agree that we don't have to upgrade right now. That would be a much bigger 
undertaking, taking at least weeks to finish and then test properly. Backward 
compatibility must be preserved.

bq. if the user has a fat JAR consisting also of log4j12 classes that are 
versions incompatible w/ the Oozie server 

Fat jar has always been a problem and right now there's not much we can do 
about it (we could mitigate it to a certain degree with better classloader 
isolation, but again, that's not straightforward). We've seen conflicting 
Guavas as well. Also, the YARN side is a different story, we don't even use 
loggers there, just sysout. On a separate note, we shall focus on those sysouts 
too, it doesn't look good :)

bq.  I don't recall any issues with Oozie's logging performance

I do remember one instance and I'm sure that so do you: when we enabled full 
DEBUG loggin in the tests, that completely choked log4j and upstream tests 
timed out. Pretty nasty. Indeed, lot of output was generated, but still, such 
things should not happen with a well-performing logging library.

Just the fact that we depend on an ancient library that hasn't been actively 
maintained in the last 3-4 years is alone a good reason for an upgrade - 
probably in Oozie 6.0.

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-10-09 Thread Peter Cseh (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643018#comment-16643018
 ] 

Peter Cseh commented on OOZIE-3136:
---

I don't really see a compelling reason for upgrading to Log4j2 in the short 
term. It has better performance characteristics, but I don't recall any issues 
with Oozie's logging performance. I think moving to SLF4J is a good approach 
though as it will make the future Log4J2 migration easier. 
Really, with proper Slf4j usage, the log4j version shouldn't really matter.
We're using a very old logger though to support log streaming across 
active-active Oozie servers in case of HA. That will be probably the hardest 
part of the migration and I think we could address that in slf4j as well.

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-10-09 Thread Andras Piros (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643002#comment-16643002
 ] 

Andras Piros commented on OOZIE-3136:
-

[~pbacsko] [~asalamon74] [~kmarton] HADOOP-12596 seems really a good read, as 
is HBASE-10092. It seems that we indeed need to go for the {{slf4j-log4j12}} 
adapter based approach because:
# in Oozie 5.x, we need that old {{.properties}} based configuration remains 
working, else we would break compatibility guidelines for a minor version. In 
Oozie 6.0 we may consider moving to {{log4j2}} completely, thus breaking 
backwards compatibility guarantees
# as there are many Oozie users that have custom {{.properties}} settings we 
need those settings remain working in Oozie 5.x
# caveats of the same type you mentioned do exist on Oozie 5.0: if the user has 
a fat JAR consisting also of {{log4j12}} classes that are versions incompatible 
w/ the Oozie server / sharelib's version, we can see lots of 
{{ClassNotFoundException}} instances, and other types of class loading errors, 
as well as strange behavior like logging doesn't work silently at all. The 
general recommendation has been to either avoid packing those classes inside 
user JARs, or to use {{maven-shade-plugin}} to hide those

All in all, I'm for using adapter classes and maintain {{log4j12}} 
configuration throughout Oozie 5.x. [~gezapeti] [~asasvari] what do you think?

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-10-09 Thread Julia Kinga Marton (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642946#comment-16642946
 ] 

Julia Kinga Marton commented on OOZIE-3136:
---

I totally agree that at some point we will need to make a complete migration. 
This is cleaner and only using this approach will be able to use the new 
functionalities introduced by Log4j2. 

Since there is no way to keep compatibility, I would change the .property based 
configuration to the xml configuration.

I was also thinking about waiting LOG4J2-63 but I did not see any progress 
since last year.

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-10-08 Thread Andras Salamon (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642186#comment-16642186
 ] 

Andras Salamon commented on OOZIE-3136:
---

[~kmarton] I don't think that we should break compatibility in a minor release 
so in the short run (Oozie 5.2) we should use the bridge. We can upgrade later 
to log4j2 (Oozie 6.0). 

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-10-08 Thread Peter Bacsko (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641930#comment-16641930
 ] 

Peter Bacsko commented on OOZIE-3136:
-

HADOOP-12956 proposed a complete migration to Log4j2. I think we should do that 
as well. It is certainly more complex, but cleaner.

Having both the adapter layer and the original log4j on the classpath can cause 
strange issues. For example, an application wants to use the legacy log4j and 
the classloader finds the adapter classes first and it will redirect all 
logging calls to log4j2. Depending on the situation this might or might not be 
what we want, but in general, having the same API in two different artifacts is 
simply a pain and a perfect recipe for hard-to-debug problems.

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-10-08 Thread Julia Kinga Marton (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641844#comment-16641844
 ] 

Julia Kinga Marton commented on OOZIE-3136:
---

The upgrade can be done in two ways: 
 # Use the log4j1.x bridge: this is quite trivial solution: we need to replace 
the log4j dependency with log4j-1.2-api. However if there are places when we 
touched/used legacy Log4j1 classes such as Appenders, LoggerRepository or 
Category it may need a small refactoring. Using this bridge, all logging that 
uses Log4j 1 will be routed to Log4j 2. 
 # Convert manually to the Log4j2 api and update the configuration. This is a 
more complex solution. On the one hand, there are some calls what are changed 
in Log4j2, on the other hand, however Log4j2 supports configuration via a 
.properties file, the syntax is changed, so we need to reconfigure our 
framework. 

Having this configuration syntax changed, proceeding with manual conversion 
will brake compatibility. There is an issue when the Log4j guys will address 
this incompatibility, but this is still in progress: LOG4J2-63. I don't think 
that we should wait for this issue.

However I consider the second solution a more elegant solution, I think that we 
should keep somehow backwards compatibility, and proceed with the bridge. 

[~andras.piros], [~asalamon74], and others, what is your opinion? 

You can find more information related the migration here: 
[https://logging.apache.org/log4j/2.x/manual/migration.html]

 

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-08-31 Thread Andras Piros (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598440#comment-16598440
 ] 

Andras Piros commented on OOZIE-3136:
-

Hi [~bugg_tb],

we're targeting to resolve this issue in the next couple of weeks.

The one that wants to get this resolved sooner needs to address following other 
JIRAs:
* OOZIE-3135
* OOZIE-3137

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-08-30 Thread Tom Barber (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598045#comment-16598045
 ] 

Tom Barber commented on OOZIE-3136:
---

 Hi folks, I'm trying to get Oozie 5 into the next Bigtop release but this is a 
blocker. How "In Progress" is it and can I do anything to help get this one 
resolved?

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-06-25 Thread Julia Kinga Marton (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522095#comment-16522095
 ] 

Julia Kinga Marton commented on OOZIE-3136:
---

Hi [~nick_w], I have started to work on this issue. The work is still in 
progress :)

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-06-25 Thread nick (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522083#comment-16522083
 ] 

nick commented on OOZIE-3136:
-

hi, Julia Kinga Marton, how about the work going ? Any plan to finish it?

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-06-25 Thread nick (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522081#comment-16522081
 ] 

nick commented on OOZIE-3136:
-

hi, [~kmarton], how about the work going ? Any plan to finish it?

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3136) Upgrade from Log4j 1.x to 2.x

2018-06-15 Thread Julia Kinga Marton (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513526#comment-16513526
 ] 

Julia Kinga Marton commented on OOZIE-3136:
---

[~plinnell], I am planning to start to work on this issue next week.

> Upgrade from Log4j 1.x to 2.x
> -
>
> Key: OOZIE-3136
> URL: https://issues.apache.org/jira/browse/OOZIE-3136
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Major
>
> {{5 August 2015 --The Apache Logging Services™ Project Management Committee 
> (PMC) has announced that the Log4j™ 1.x logging framework has reached its end 
> of life (EOL) and is no longer officially supported.}} 
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> We should upgrade from Log4j 1.x to 2.x . Perhaps we could use slf4j .
> Related tickets: MAPREDUCE-6983, HADOOP-12956, OOZIE-3135



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)