Re: Review Request 67129: OOZIE-3240 Flaky test TestJMSAccessorService#testConnectionRetry

[András Piros via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67129/#review203112
---


Ship it!




Ship It!

- András Piros


On May 15, 2018, 1:17 p.m., Peter Bacsko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67129/
> ---
> 
> (Updated May 15, 2018, 1:17 p.m.)
> 
> 
> Review request for oozie, András Piros and Peter Cseh.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> Proposed fir for OOZIE-3240.
> 
> Note that most likely this patch will also solve OOZIE-3239 (or other tests 
> that fail in this class) and OOZIE-3241.
> 
> 
> Diffs
> -
> 
>   core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 
> 41241d2533bf6c3f32f0fca5d76ad5b960bff1a1 
> 
> 
> Diff: https://reviews.apache.org/r/67129/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Peter Bacsko
> 
>

Re: Review Request 67129: OOZIE-3240 Flaky test TestJMSAccessorService#testConnectionRetry

[Peter Bacsko via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67129/
---

(Updated máj. 15, 2018, 12:52 du)


Review request for oozie, András Piros and Peter Cseh.


Repository: oozie-git


Description (updated)
---

Proposed fir for OOZIE-3240.

Note that most likely this patch will also solve OOZIE-3239 (or other tests 
that fail in this class) and OOZIE-3241.


Diffs
-

  core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 
41241d2533bf6c3f32f0fca5d76ad5b960bff1a1 
  core/src/test/java/org/apache/oozie/test/XTestCase.java 
f471b889896e9a37a59c3b8ad1c47633eed3e0c0 


Diff: https://reviews.apache.org/r/67129/diff/1/


Testing
---


Thanks,

Peter Bacsko

Re: Review Request 67129: OOZIE-3240 Flaky test TestJMSAccessorService#testConnectionRetry

[András Piros via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67129/#review203110
---




core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
Lines 160 (patched)


Wouldn't use lambdas, an anonymous class is better IMO.



core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
Line 226 (original), 207 (patched)


Wouldn't use lambdas, an anonymous class is better IMO.



core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
Line 265 (original), 252 (patched)


Wouldn't use lambdas, an anonymous class is better IMO.



core/src/test/java/org/apache/oozie/test/XTestCase.java
Lines 806-813 (patched)


Nice :)


- András Piros


On May 15, 2018, 12:43 p.m., Peter Bacsko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67129/
> ---
> 
> (Updated May 15, 2018, 12:43 p.m.)
> 
> 
> Review request for oozie, András Piros and Peter Cseh.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> Proposed fir for OOZIE-3240.
> 
> Note that most likely this patch will also solve OOZIE-3239 (or other tests 
> that fail in this class).
> 
> 
> Diffs
> -
> 
>   core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 
> 41241d2533bf6c3f32f0fca5d76ad5b960bff1a1 
>   core/src/test/java/org/apache/oozie/test/XTestCase.java 
> f471b889896e9a37a59c3b8ad1c47633eed3e0c0 
> 
> 
> Diff: https://reviews.apache.org/r/67129/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Peter Bacsko
> 
>

Re: Review Request 67129: OOZIE-3240 Flaky test TestJMSAccessorService#testConnectionRetry

[Peter Bacsko via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67129/#review203109
---




core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
Line 86 (original)


I removed these catch blocks, they didn't serve any purpose whatsoever.



core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
Lines 142-146 (original), 127 (patched)


This was absolutely unnecessary here.



core/src/test/java/org/apache/oozie/test/XTestCase.java
Lines 806 (patched)


Small enhancement for JDK8.


- Peter Bacsko


On máj. 15, 2018, 12:43 du, Peter Bacsko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67129/
> ---
> 
> (Updated máj. 15, 2018, 12:43 du)
> 
> 
> Review request for oozie, András Piros and Peter Cseh.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> Proposed fir for OOZIE-3240.
> 
> Note that most likely this patch will also solve OOZIE-3239 (or other tests 
> that fail in this class).
> 
> 
> Diffs
> -
> 
>   core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 
> 41241d2533bf6c3f32f0fca5d76ad5b960bff1a1 
>   core/src/test/java/org/apache/oozie/test/XTestCase.java 
> f471b889896e9a37a59c3b8ad1c47633eed3e0c0 
> 
> 
> Diff: https://reviews.apache.org/r/67129/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Peter Bacsko
> 
>