[GitHub] [openoffice] Pilot-Pirx merged pull request #165: Update zlib to 1.2.13

[GitBox]

Pilot-Pirx merged PR #165:
URL: https://github.com/apache/openoffice/pull/165


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #165: Update zlib to 1.2.13

[GitBox]

Pilot-Pirx commented on PR #165:
URL: https://github.com/apache/openoffice/pull/165#issuecomment-1382711711

   Thanks for the review!
   The permission change was done by git, so I will revert it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx opened a new pull request, #165: Update zlib to 1.2.13

[GitBox]

Pilot-Pirx opened a new pull request, #165:
URL: https://github.com/apache/openoffice/pull/165

   Currently we use zlib 1.2.7 from 2012.
   This PR updates it to the most recent version 1.2.13 from 2022.
   
   I am no developer, but basically we only add a makefile and patch some 
headers.
   
   I could build successfully with this PR on Windows, testing on other OS is 
welcome!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] jimjag merged pull request #163: Remove Bitmaps from build

[GitBox]

jimjag merged PR #163:
URL: https://github.com/apache/openoffice/pull/163


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] jimjag commented on pull request #163: Remove Bitmaps from build

[GitBox]

jimjag commented on PR #163:
URL: https://github.com/apache/openoffice/pull/163#issuecomment-1377303029

   Looks good!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

[GitBox]

cbmarcum commented on PR #164:
URL: https://github.com/apache/openoffice/pull/164#issuecomment-1374548388

   > > Copy/Paste from Firefox to Calc trunk and this PR all 2 rows for both
   > 
   > There is no way all 2 pasted successfully over HTML on trunk. Either 
the transfer format wasn't HTML, or you tested something other than trunk.
   
   Hi Damjan,
   You are correct. I found out what was wrong with my test.
   I had copied from a Firefox outside of the VM and pasted to AOO inside the 
VM. This opened a Text Import dialog and did import all 2 rows in both 
trunk and the PR.
   
   I can confirm that copying from Firefox and pasting into AOO within the same 
VM results in:
   trunk getting to row 13106 and inserting a lot (or all) of the rest into 
column D of the next row.
   The PR build takes all 2 rows.
   Both without using the Text import dialog.
   Sorry for the confusion.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] DamjanJovanovic commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

[GitBox]

DamjanJovanovic commented on PR #164:
URL: https://github.com/apache/openoffice/pull/164#issuecomment-137456

   > Copy/Paste from Firefox to Calc trunk and this PR all 2 rows for both
   
   There is no way all 2 pasted successfully over HTML on trunk. Either the 
transfer format wasn't HTML, or you tested something other than trunk.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

[GitBox]

cbmarcum commented on PR #164:
URL: https://github.com/apache/openoffice/pull/164#issuecomment-1374528032

   My latest testing:
   File > Open 
   set file type filter to HTML Document (OpenOffice Calc) (*.html;*.htm)
   
   trunk got to row 13106
   with PR 164 got all 2 rows
   
   ---
   Copy/Paste from Firefox to Calc
   trunk and this PR 
   all 2 rows for both 
   ---
   Copy/Paste from Firefox to Writer
   trunk and this PR 
   all 2 rows as tab separated values per row.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] DamjanJovanovic commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

[GitBox]

DamjanJovanovic commented on PR #164:
URL: https://github.com/apache/openoffice/pull/164#issuecomment-1374407466

   I believe the Writer table limit of 64K cells is unrelated to this issue. 
   
   For example in main/sw/source/filter/html/htmltab.cxx:
   
   ```
   class HTMLTable
   {
   ...
   sal_uInt16 nRows;   // Anzahl Zeilen
   sal_uInt16 nCols;   // Anzahl Spalten
   ```
   
   That's not EditEngine related, that's a separate issue specific to Writer.
   
   Please test only copying from a web browser and pasting into Calc, and 
opening through the "File type" of "HTML document (**OpenOffice Calc**) (*html, 
*.htm)".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] DamjanJovanovic commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

[GitBox]

DamjanJovanovic commented on PR #164:
URL: https://github.com/apache/openoffice/pull/164#issuecomment-1374378198

   > When I open it with my build of this PR on CentOS 7 it still only opens 
into a Writer/HTML document to the row 12801 before starting to just produce 
text beyond that. Same as with trunk.
   > 
   > [1] https://home.apache.org/~cmarcum/test-files/2-row-html-table.html
   
   Nice catch. Yes, apparently there is still a problem somewhere in Writer. I 
only tested copying from a web browser and pasting to Calc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

[GitBox]

cbmarcum commented on PR #164:
URL: https://github.com/apache/openoffice/pull/164#issuecomment-1374199770

   H Damjan,
   Thanks for your work on this.
   I made a slight change to the html test file from i117635 by removing the 
first row so that cell A1 was in the first row.
   See link [1].
   the file is a simple html table with 2 rows and 5 columns.
   When I open it with my build of this PR on CentOS 7 it still only opens into 
a Writer/HTML document to the row 12801 before starting to just produce text 
beyond that. Same as with trunk.
   
   [1] https://home.apache.org/~cmarcum/test-files/2-row-html-table.html
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #163: Remove Bitmaps from build

[GitBox]

Pilot-Pirx commented on PR #163:
URL: https://github.com/apache/openoffice/pull/163#issuecomment-1372116100

   Hi Jim,
   can you try to build this on macOS?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #164: Update EditEngine code to use 32 bit paragraph storage

[GitBox]

Pilot-Pirx commented on PR #164:
URL: https://github.com/apache/openoffice/pull/164#issuecomment-1372114965

   Hi Damjan,
   this is a great amount of work, thank you!
   I will try to do a build on Windows and test some files...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] DamjanJovanovic opened a new pull request, #164: Update EditEngine code to use 32 bit paragraph storage

[GitBox]

DamjanJovanovic opened a new pull request, #164:
URL: https://github.com/apache/openoffice/pull/164

   Our EditEngine, in main/editeng, has a number of containers for paragraphs, 
paragraph portions, lines, etc. These are based on svl's "PTRARR" type classes, 
which is just an array of some caller-defined class that grows as needed, like 
::std::vector but hardcoded to 16 bit limits. Worse, a lot of code, even 
outside of main/editeng, is written under these assumptions, and passes 16 bit 
types and constants to EditEngine classes and retrieves 16 bit results.
   
   One particularly notorious bug emerging from this design, is that when you 
try to paste an HTML table of more than 65534 cells into Calc, the first 65534 
cells are pasted, but all further cells are silently lost, something reported 
in at least 3 bugs in the last 18 years 
([57176](https://bz.apache.org/ooo/show_bug.cgi?id=57176), 
[110486](https://bz.apache.org/ooo/show_bug.cgi?id=110486) and 
[117225](https://bz.apache.org/ooo/show_bug.cgi?id=117225)). This apparently 
happens because our HTML import is similar to XML DOM parsing, done in 2 
phases, first parsing the results into memory, then processing those in-memory 
results to populate data into the spreadsheet (ScHTMLImport::WriteToDocument() 
in main/sc/source/filter/html/htmlimp.cxx). When parsing, each HTML cell () 
becomes a new EditEngine paragraph, and after 65534 paragraphs, all further 
cells are ignored, so when it's time to populate the spreadsheet, the data 
isn't there to add.
   
   This enormous patchset changes the container for paragraphs to a new 
BaseList class, which wraps ::std::vector and uses 32 bit integers to access 
it. All EditEngine methods are changed to take 32 bit paragraph index 
parameters, all EditEngine classes store any paragraph indices as 32 bit 
fields, all 16 bit paragraph index constants like 0x are changed to 32 bit 
0x (and to a more readable constant like EE_PARA_NOT_FOUND), and all 
(known) calling code everywhere in OpenOffice is updated to take these changes 
into account.
   
   The bug is definitely fixed, all sample documents from Bugzilla paste fully 
and correctly. What is harder to prove is that nothing else broke. Much had to 
change, 136 files in 9 modules. OpenGrok helped tremendously in finding obscure 
places where EditEngine methods were getting called from. I've really tried to 
avoid introducing any new bugs, but it is hard to be sure with a change of this 
size. I am making a PR instead of directly pushing to allow you to test a lot 
;).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #163: Remove Bitmaps from build

[GitBox]

Pilot-Pirx commented on PR #163:
URL: https://github.com/apache/openoffice/pull/163#issuecomment-1366741343

   Windows build went fine!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx opened a new pull request, #163: Remove Bitmaps from build

[GitBox]

Pilot-Pirx opened a new pull request, #163:
URL: https://github.com/apache/openoffice/pull/163

   See attached files for history of the "symbol" directory.
   
   [rec OOo 1 1 
5](https://user-images.githubusercontent.com/6442166/209715840-e45631bd-81df-4498-a7bd-a3763032f0d0.gif)
   [Symbol 
ISSUE.pdf](https://github.com/apache/openoffice/files/10310420/1.Symbol.ISSUE.pdf)
   
   Thanks go to Czesław Wolański!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx closed pull request #141: Added one line extra space between the code.

[GitBox]

Pilot-Pirx closed pull request #141: Added one line extra space between the 
code.
URL: https://github.com/apache/openoffice/pull/141


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #141: Added one line extra space between the code.

[GitBox]

Pilot-Pirx commented on PR #141:
URL: https://github.com/apache/openoffice/pull/141#issuecomment-1366026312

   I can't see any use of this PR.
   Esp. the License header should not be changed at all!
   Closing this now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx merged pull request #162: Add patch for cygwin64

[GitBox]

Pilot-Pirx merged PR #162:
URL: https://github.com/apache/openoffice/pull/162


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #162: Add patch for cygwin64

[GitBox]

Pilot-Pirx commented on PR #162:
URL: https://github.com/apache/openoffice/pull/162#issuecomment-1329355978

   My test build was successful, so this can be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] DamjanJovanovic commented on pull request #162: Add patch for cygwin64

[GitBox]

DamjanJovanovic commented on PR #162:
URL: https://github.com/apache/openoffice/pull/162#issuecomment-1328306545

   Never mind, that's from 
https://github.com/apache/openoffice/commit/adb6f5d8a37c5b86304c6f182c17e5b29dcc384a


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] DamjanJovanovic commented on pull request #162: Add patch for cygwin64

[GitBox]

DamjanJovanovic commented on PR #162:
URL: https://github.com/apache/openoffice/pull/162#issuecomment-1328305859

   What's that oowintool change all about? It wasn't part of my 2 commits to 
trunk.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx merged pull request #161: Increase defaults for graphic cache

[GitBox]

Pilot-Pirx merged PR #161:
URL: https://github.com/apache/openoffice/pull/161


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #161: Increase defaults for graphic cache

[GitBox]

Pilot-Pirx commented on PR #161:
URL: https://github.com/apache/openoffice/pull/161#issuecomment-1323778808

   If there are no objections I will merge this PR at the end of the week to 
trunk and cherry-pick it for AOO42X. This way it will be in 4.2.0-Dev4 for 
testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #161: Increase defaults for graphic cache

[GitBox]

Pilot-Pirx commented on PR #161:
URL: https://github.com/apache/openoffice/pull/161#issuecomment-1322341701

   However, this will only have an effect on new installations, I think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] marcus-aoo commented on pull request #161: Increase defaults for graphic cache

[GitBox]

marcus-aoo commented on PR #161:
URL: https://github.com/apache/openoffice/pull/161#issuecomment-1321976782

   You habe found the location in the code, great. :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx opened a new pull request, #161: Increase defaults for graphic cache

[GitBox]

Pilot-Pirx opened a new pull request, #161:
URL: https://github.com/apache/openoffice/pull/161

   As discussed on dev@:
- maximum cache size for all graphical display objects: 100 MB
- maximum cache size for a single graphic display object: 10 MB


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] ardovm merged pull request #160: Remove SuSE packaging information

[GitBox]

ardovm merged PR #160:
URL: https://github.com/apache/openoffice/pull/160


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] ardovm commented on pull request #160: Remove SuSE packaging information

[GitBox]

ardovm commented on PR #160:
URL: https://github.com/apache/openoffice/pull/160#issuecomment-1312416674

   I will merge this PR in one week if no one objects


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] ardovm opened a new pull request, #160: Remove SuSE packaging information

[GitBox]

ardovm opened a new pull request, #160:
URL: https://github.com/apache/openoffice/pull/160

   The SuSE RPMs depend on certain files that were once present in SuSE 
distributions, and were deprecated.
   
   Freedesktop RPMs should work flawlessly on today's SUSE and openSUSE 
distributions.
   
   See https://bz.apache.org/ooo/show_bug.cgi?id=128424


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] jimjag merged pull request #151: Fix for Issue 114497

[GitBox]

jimjag merged PR #151:
URL: https://github.com/apache/openoffice/pull/151


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] jimjag merged pull request #154: Update srcrelease.xml to exclude certain files from Source build

[GitBox]

jimjag merged PR #154:
URL: https://github.com/apache/openoffice/pull/154


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #154: Update srcrelease.xml to exclude certain files from Source build

[GitBox]

Pilot-Pirx commented on PR #154:
URL: https://github.com/apache/openoffice/pull/154#issuecomment-1310340462

   If there are no additions needed I will merge this PR in the next days.
   Then it will be included in 4.2.0-Dev4 and 4.1.14.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx closed pull request #154: Update srcrelease.xml to exclude certain files from Source build

[GitBox]

Pilot-Pirx closed pull request #154: Update srcrelease.xml to exclude certain 
files from Source build
URL: https://github.com/apache/openoffice/pull/154


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #154: Update srcrelease.xml to exclude certain files from Source build

[GitBox]

Pilot-Pirx commented on PR #154:
URL: https://github.com/apache/openoffice/pull/154#issuecomment-1290243039

   I think this issue should be fixed before the next release.
   So any additions are welcome!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] oooforum opened a new pull request, #159: Update dabawiz01.xhp

[GitBox]

oooforum opened a new pull request, #159:
URL: https://github.com/apache/openoffice/pull/159

   Fix for F1 helpfile: https for HSQL website URL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] ardovm merged pull request #157: Update the list of safe extensions

[GitBox]

ardovm merged PR #157:
URL: https://github.com/apache/openoffice/pull/157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum merged pull request #158: Refs #128536 - fixes BasicSheetTest.insertSheetFromfile locks up and times out

[GitBox]

cbmarcum merged PR #158:
URL: https://github.com/apache/openoffice/pull/158


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] ardovm commented on pull request #157: Update the list of safe extensions

[GitBox]

ardovm commented on PR #157:
URL: https://github.com/apache/openoffice/pull/157#issuecomment-1264291580

   Thank you @cbmarcum for your review.
   More extension are coming... please see [this forum 
thread](https://forum.openoffice.org/en/forum/viewtopic.php?p=528972).
   
   I think we can wait for one week to make sure everyone interested send their 
proposal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] ardovm opened a new pull request, #157: Update the list of safe extensions

[GitBox]

ardovm opened a new pull request, #157:
URL: https://github.com/apache/openoffice/pull/157

   The purpose of the extensions branch, and of this PR, is to add any missing 
entries to the list of "safe" file extensions.
   
   Safe file extensions allow hyperlinks to be opened without asking for user 
confirmation.
   
   Before this PR, the following extensions are considered safe:
   1 123 602 aif aifc asf asx au avi bmp cgm csv dbf dib dif doc docm docx dot 
dotm dotx dxf emf eps fdf flac gif htm html jfif jif jpe jpeg jpg m1a m3u m4a 
met mid midi mml moov mov movie mp2 mp3 mpa mpe mpeg mpg odb odf odg odm odp 
ods odt ogg otg oth otp ots ott pbm pbm pcd pcd pct pcx pcx pdb pdf pgm pict 
png pot potm potx ppm pps ppt pptm pptx psd psw pxl qt ra ram ras rm rtf sda 
sdc sdd sdp sds sdw sgf sgl sgv shtml slk smf stc std sti stw svg svm sxc sxd 
sxg sxi sxm sxp sxw text tga tif tiff txt uof uop uos uot vor wav wb2 wk1 wks 
wmf wpl xbm xhp xhp xhtml xlc xlm xls xlsb xlsm xlsx xlt xltm xltx xlw xml xpm
   
   The first commit adds mp4 to the above list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] oooforum closed pull request #32: Fix for issue #127897

[GitBox]

oooforum closed pull request #32: Fix for issue #127897
URL: https://github.com/apache/openoffice/pull/32


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] oooforum commented on pull request #151: Fix for Issue 114497

[GitBox]

oooforum commented on PR #151:
URL: https://github.com/apache/openoffice/pull/151#issuecomment-1262233279

   Somebody can push it this fix? 
   It will be fine to have this in the next builds. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] leginee merged pull request #155: Proposed fix for Issue 60217

[GitBox]

leginee merged PR #155:
URL: https://github.com/apache/openoffice/pull/155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice-org] Pilot-Pirx closed pull request #65: Update index2.html

[GitBox]

Pilot-Pirx closed pull request #65: Update index2.html
URL: https://github.com/apache/openoffice-org/pull/65


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice-org] Pilot-Pirx commented on pull request #65: Update index2.html

[GitBox]

Pilot-Pirx commented on PR #65:
URL: https://github.com/apache/openoffice-org/pull/65#issuecomment-1259780368

   Are you member of The ASF? Then you should see the same as I do.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice-org] marcus-aoo commented on pull request #65: Update index2.html

[GitBox]

marcus-aoo commented on PR #65:
URL: https://github.com/apache/openoffice-org/pull/65#issuecomment-1259775476

   I've haven't seen any commit or merge funktion, button, ...
   So, had to do it manually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice-org] Pilot-Pirx commented on pull request #65: Update index2.html

[GitBox]

Pilot-Pirx commented on PR #65:
URL: https://github.com/apache/openoffice-org/pull/65#issuecomment-1259768835

   Hi Marcus,
   
   why don't you simply merge the PR instead of committing manually?
   
   Now we have another "dead" PR that must be closed...
   
   Regards,
   
      Matthias
   
   Am 27.09.22 um 18:28 schrieb marcus-aoo:
   >
   > Thanks for the changes. I'll build a new website.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > ,
   > or unsubscribe
   > 
.
   > You are receiving this because you are subscribed to this
   > thread.Message ID: ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice-org] marcus-aoo commented on pull request #65: Update index2.html

[GitBox]

marcus-aoo commented on PR #65:
URL: https://github.com/apache/openoffice-org/pull/65#issuecomment-1259758388

   Thanks for the changes. I'll build a new website.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice-org] jeanmicoste opened a new pull request, #65: Update index2.html

[GitBox]

jeanmicoste opened a new pull request, #65:
URL: https://github.com/apache/openoffice-org/pull/65

   changes suggested by Bidouille


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #155: Proposed fix for Issue 60217

[GitBox]

Pilot-Pirx commented on PR #155:
URL: https://github.com/apache/openoffice/pull/155#issuecomment-1259328223

   @leginee: Can you please "squash and merge"?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #155: Proposed fix for Issue 60217

[GitBox]

Pilot-Pirx commented on PR #155:
URL: https://github.com/apache/openoffice/pull/155#issuecomment-1259169010

   If nobody else wants to review, It think we can merge this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum merged pull request #156: Tab function test document and test

[GitBox]

cbmarcum merged PR #156:
URL: https://github.com/apache/openoffice/pull/156


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum opened a new pull request, #156: Tab function test document and test

[GitBox]

cbmarcum opened a new pull request, #156:
URL: https://github.com/apache/openoffice/pull/156

   A test document and added it to TestFormulaDocs.java
   
   Refs i19221
   https://bz.apache.org/ooo/show_bug.cgi?id=19221
   
   Patch-By: Czesław Wolański


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] leginee commented on pull request #155: Proposed fix for Issue 60217

[GitBox]

leginee commented on PR #155:
URL: https://github.com/apache/openoffice/pull/155#issuecomment-1255799157

   Compiles now on docker container. Sadly the dockerbuild crashes on my system 
for some (other) reason.
   SO I am not able to test now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] leginee opened a new pull request, #155: Proposed fix for Issue 60217

[GitBox]

leginee opened a new pull request, #155:
URL: https://github.com/apache/openoffice/pull/155

   I have added the if clause, with the expectation it fullfills the goal 
czeslav formulated in comment 9
   `1. Truncated string
   It was fixed in version 3.0.0
   (cf. the attached file "juxtaVER.jpeg")
   
   
   2. A spurious colon
   ralphie, [comment #4](https://bz.apache.org/ooo/show_bug.cgi?id=60217#c4)
   > Furthermore, if there is no database selected, there is
   > a spurious colon after this sentence, see:
   > 
   > http://www.pangea.at/%7eralph/datenbank-austauschen.png
   
   If no database is selected, there is a colon after the "sentence".
   And the program unnecessarily displays a dot character.
   (cf. the attached file "Period.jpg").
   
   
   the source file: changedb.cxx
   
http://openoffice-vm1-he-de.apache.org/xref/trunk/main/sw/source/ui/fldui/changedb.cxx?r=efeef26f#333
   
   333 void SwChangeDBDlg::ShowDBName(const SwDBData& rDBData)
   334  {
   335 String sTmp(rDBData.sDataSource);
   336 String sName;
   337 sTmp += '.';
   338 sTmp += (String)rDBData.sCommand;
   339
   340 for (sal_uInt16 i = 0; i < sTmp.Len(); i++)
   341 {
   342 sName += sTmp.GetChar(i);
   343 if (sTmp.GetChar(i) == '~')
   344 sName += '~';
   345 }
   346  
   347 aDocDBNameFT.SetText(sName);
   348  }
   
   
   Look at the lines 335 - 338
   I am not a software developer...
   but if the properties "sDataSource" and "sCommand" are empty
   then the programm should set the "sName" variable to empty
   otherwise proceed as usual.`
   
   Did not build the PR. Needs testing, but can be a base of discussion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #154: Update srcrelease.xml to exclude certain files from Source build

[GitBox]

Pilot-Pirx commented on PR #154:
URL: https://github.com/apache/openoffice/pull/154#issuecomment-1236418794

   I think Andrea had some...
   If he can add them we could close the Bugzilla issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #154: Update srcrelease.xml to exclude certain files from Source build

[GitBox]

Pilot-Pirx commented on PR #154:
URL: https://github.com/apache/openoffice/pull/154#issuecomment-1236405780

   Thanks! My understanding is that we don't want to bundle any log, so I will 
change it accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] ardovm commented on pull request #154: Update srcrelease.xml to exclude certain files from Source build

[GitBox]

ardovm commented on PR #154:
URL: https://github.com/apache/openoffice/pull/154#issuecomment-1236402907

   It is also not very clear to me, if the other spurious files from the bug 
report are still included.
   If so, shall we also add exclusions for them in this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #154: Update srcrelease.xml to exclude certain files from Source build

[GitBox]

Pilot-Pirx commented on PR #154:
URL: https://github.com/apache/openoffice/pull/154#issuecomment-1232200883

   See:
   https://bz.apache.org/ooo/show_bug.cgi?id=127544


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice-org] leginee merged pull request #64: Update referenzkunden.html

[GitBox]

leginee merged PR #64:
URL: https://github.com/apache/openoffice-org/pull/64


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice-org] marcus-aoo commented on pull request #64: Update referenzkunden.html

[GitBox]

marcus-aoo commented on PR #64:
URL: https://github.com/apache/openoffice-org/pull/64#issuecomment-1185782318

   @leginee  I looked at the changes and it is good for me. No objects for 
merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice-org] leginee opened a new pull request, #64: Update referenzkunden.html

[GitBox]

leginee opened a new pull request, #64:
URL: https://github.com/apache/openoffice-org/pull/64

   Added Reference according to mail request 
https://lists.apache.org/thread/sox98vldnjhnrvqq7bqn9p6wm2c9j5ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #30: Issue 128286 – Add locale file for Ligurian

[GitBox]

Pilot-Pirx commented on PR #30:
URL: https://github.com/apache/openoffice/pull/30#issuecomment-1155168547

   Sorry, I don't have time for this at the moment.
   Maybe some other volunteer wants to take over?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] leginee closed pull request #153: Fix for Issue 128375

[GitBox]

leginee closed pull request #153: Fix for Issue 128375
URL: https://github.com/apache/openoffice/pull/153


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] leginee commented on pull request #153: Fix for Issue 128375

[GitBox]

leginee commented on PR #153:
URL: https://github.com/apache/openoffice/pull/153#issuecomment-1154150850

   > Are you sure the tilde doesn't have some significance like in hotkeys? 
   Interesting point. Needs to be reviewe?. Then why is Tilde visible in the 
string as reported.
   > Also, which file has this change. I see removing stax and some some build 
files?
   oO. There went something wrong. I need to check. I withdraw my PR then.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum commented on pull request #153: Fix for Issue 128375

[GitBox]

cbmarcum commented on PR #153:
URL: https://github.com/apache/openoffice/pull/153#issuecomment-1153718179

   Are you sure the tilde doesn't have some significance like in hotkeys?
   Also, which file has this change.  I see removing stax and some some build 
files?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] leginee opened a new pull request, #153: Bz128375

[GitBox]

leginee opened a new pull request, #153:
URL: https://github.com/apache/openoffice/pull/153

   This is a pull request for[ Issue 
128375](https://bz.apache.org/ooo/show_bug.cgi#add_comment)
   
   I removed all ~ in Text Aerea.
   Example:
   ```
   String STR_EDIT_OBJ
   {
Text [ en-US ] = "~Edit" ;
   };
   ```
   or reported
   ```
   `String STR_PLAY
   {
Text [ en-US ] = "~Play" ;
   };`
   ```
   Not sure maybe there is an impact on other language files?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum merged pull request #152: Refs i126272 - add test and test document for testing Basic comment in single-line if statements

[GitBox]

cbmarcum merged PR #152:
URL: https://github.com/apache/openoffice/pull/152


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum opened a new pull request, #152: Refs i126272 - add test and test document for testing Basic comment in single-line if statements

[GitBox]

cbmarcum opened a new pull request, #152:
URL: https://github.com/apache/openoffice/pull/152

   This can be cherry-picked for AOO42X but a version of it is already covered 
in AOO41X.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] oooforum commented on pull request #151: Fix for Issue 114497

[GitBox]

oooforum commented on PR #151:
URL: https://github.com/apache/openoffice/pull/151#issuecomment-1151995625

   Simple, read the BZ report https://bz.apache.org/ooo/show_bug.cgi?id=114497 
and apply instructions from comment #37
   Before, we can not use smtp with SSL protocol (like GMail account).
   After, access works.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum commented on pull request #151: Fix for Issue 114497

[GitBox]

cbmarcum commented on PR #151:
URL: https://github.com/apache/openoffice/pull/151#issuecomment-1151602055

   Hi Cyril, could you provide some simple steps we can use to test this before 
and after the fix for those who have not used the mail merge feature before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum merged pull request #150: Refs #i112383#, #i117960#, and #i126272# - Basic lang backports

[GitBox]

cbmarcum merged PR #150:
URL: https://github.com/apache/openoffice/pull/150


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum commented on pull request #150: Refs #i112383#, #i117960#, and #i126272# - Basic lang backports

[GitBox]

cbmarcum commented on PR #150:
URL: https://github.com/apache/openoffice/pull/150#issuecomment-1151455289

   Based on this email thread [1] on dev@ I'm going to pull this in.
   
   [1] https://lists.apache.org/thread/21vgh6ovcp7mnf82j7nz6rngzx7yvztn


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] oooforum opened a new pull request, #151: Fix for Issue 114497

[GitBox]

oooforum opened a new pull request, #151:
URL: https://github.com/apache/openoffice/pull/151

   Thanks to hanya for this patch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum commented on pull request #150: Refs #i112383# and #i117960#. - backporting to AOO41X

[GitBox]

cbmarcum commented on PR #150:
URL: https://github.com/apache/openoffice/pull/150#issuecomment-1142722148

   I found these changes missing from AOO41X after updating the tests in trunk 
to be standalone and running them against AOO41X and debugging test failures 
and errors. To run the included test after building this branch. 
   From test dir:
   ```
   ant -Dopenoffice.home="" compile
   ./run -Dopenoffice.home="" -tc 
fvt.uno.sc.formula.TestFormulaDocs
   ```
   The test in trunk has been further improved as a JUnit parameterized test so 
each document is reported separately.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum opened a new pull request, #150: Refs #i112383# and #i117960#. - backporting to AOO41X

[GitBox]

cbmarcum opened a new pull request, #150:
URL: https://github.com/apache/openoffice/pull/150

   Can't cherry-pick due to file changes and both commits changed the same test 
file.
   
   Original commit messages and links follow:
   
   #i112383# CLng('') fails on 64-bits rather than returning -1
   Found-by: andrew
   Patch-by: Damjan Jovanovic
   
https://github.com/apache/openoffice/commit/323c350123d05cd9f450aebd421b7bfa74c331d2
   
   #i117960# Basic: Line Input doesn't work in single-line If
   i92642 added the ability to use certain keywords as variable names (eg. name 
= 1, line = 'hi'),
   but also caused a regression where "Line Input" is broken in single-line If 
statements.
   This patch fixes that by allowing Then and Else to also be the start-of-line 
tokens expected to
   immediately preceed the 'Line' token in order for that 'Line' token to be 
recognized a keyword instead
   of a variable name. Also added FVT spreadsheet tests for 'Line' as both a 
variable name and as 'Line Input'.
   Patch by: Damjan Jovanovic
   
https://github.com/apache/openoffice/commit/725d867363770a4c47c4b3c6dbe1f359c296604a


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum merged pull request #149: Fix TestFormulaDocs to run against AOO41X, make parameterized, and fix late screenshots

[GitBox]

cbmarcum merged PR #149:
URL: https://github.com/apache/openoffice/pull/149


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum opened a new pull request, #149: Fix test formula docs

[GitBox]

cbmarcum opened a new pull request, #149:
URL: https://github.com/apache/openoffice/pull/149

   updated TestFormulaDocs test to be a parameterized test to better see which 
document failed.
   Fixed late screenshots on failures.
   Added timeout for dialog hangs when running tests against AOO41X branch due 
to some BASIC bug fixes for i112383 [1] and it's commit [2] and i117960 [3] and 
it's commit [4] not being back-ported to AOO41X.
   
   [1] https://bz.apache.org/ooo/show_bug.cgi?id=112383
   [2] 
https://github.com/cbmarcum/openoffice/commit/323c350123d05cd9f450aebd421b7bfa74c331d2
   
   [3] https://bz.apache.org/ooo/show_bug.cgi?id=117960
   [4] 
https://github.com/apache/openoffice/commit/725d867363770a4c47c4b3c6dbe1f359c296604a


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Baciccin commented on pull request #30: Issue 128286 – Add locale file for Ligurian

[GitBox]

Baciccin commented on PR #30:
URL: https://github.com/apache/openoffice/pull/30#issuecomment-1140351524

   Hi @Pilot-Pirx @pescetti, any chance we could get this merged? Are any other 
changes required?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] ardovm merged pull request #146: Port our WebDAV content provider from serf/apr/apr-util, to curl.

[GitBox]

ardovm merged PR #146:
URL: https://github.com/apache/openoffice/pull/146


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum merged pull request #148: Fix sample test AOOTest for late failure screenshots and fix an assertion text incorrectly changed in a code cleanup.

[GitBox]

cbmarcum merged PR #148:
URL: https://github.com/apache/openoffice/pull/148


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum opened a new pull request, #148: Fix sample test AOOTest for late failure screenshots and fix an assertion text incorrectly changed in a code cleanup.

[GitBox]

cbmarcum opened a new pull request, #148:
URL: https://github.com/apache/openoffice/pull/148

   Updated AOOTest to use newer API and fix late screenshots on failures. Fixed 
BasicFunctionTest.testFind assertion because of a previous code cleanup that 
changed the assertion text causing the test to fail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] ardovm commented on pull request #146: Port our WebDAV content provider from serf/apr/apr-util, to curl.

[GitBox]

ardovm commented on PR #146:
URL: https://github.com/apache/openoffice/pull/146#issuecomment-1119963720

   I just opened https://github.com/DamjanJovanovic/openoffice/pull/1 with my 
proposal for using the bundled OpenSSL under Unix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] ardovm merged pull request #147: Fix including OpenSSL dynamic libraries on Unix

[GitBox]

ardovm merged PR #147:
URL: https://github.com/apache/openoffice/pull/147


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] ardovm opened a new pull request, #147: Fix including OpenSSL dynamic libraries on Unix

[GitBox]

ardovm opened a new pull request, #147:
URL: https://github.com/apache/openoffice/pull/147

   .so files were never copied.
   The logic needed two small changes IMHO. Here they are.
   
   These commits are meant to be squashed if we choose to merge them.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] DamjanJovanovic commented on a diff in pull request #146: Port our WebDAV content provider from serf/apr/apr-util, to curl.

[GitBox]

DamjanJovanovic commented on code in PR #146:
URL: https://github.com/apache/openoffice/pull/146#discussion_r861084069


##
main/ucb/source/ucp/webdav/CurlRequest.cxx:
##
@@ -0,0 +1,391 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+
+
+
+// MARKER(update_precomp.py): autogen include statement, do not remove
+#include "precompiled_webdav.hxx"
+

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] ardovm commented on a diff in pull request #146: Port our WebDAV content provider from serf/apr/apr-util, to curl.

[GitBox]

ardovm commented on code in PR #146:
URL: https://github.com/apache/openoffice/pull/146#discussion_r861055045


##
main/ucb/source/ucp/webdav/CurlRequest.cxx:
##
@@ -0,0 +1,391 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+
+
+
+// MARKER(update_precomp.py): autogen include statement, do not remove
+#include "precompiled_webdav.hxx"
+

Review Comment:
   Please include string.h
   Otherwise the compiler cannot find memcpy(3).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] DamjanJovanovic opened a new pull request, #146: Port our WebDAV content provider from serf/apr/apr-util, to curl.

[GitBox]

DamjanJovanovic opened a new pull request, #146:
URL: https://github.com/apache/openoffice/pull/146

   Remove serf/apr/apr-from the build.
   Curl must now use OpenSSL, and linking to zlib helps.
   See the email on 
https://lists.apache.org/thread/0k8vnbcr0z7r2boftz4zdq9r69w6n8cc for details.
   
   Patch by: me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum merged pull request #145: Make the automated test suite standalone from the office build

[GitBox]

cbmarcum merged PR #145:
URL: https://github.com/apache/openoffice/pull/145


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum opened a new pull request, #145: Make the automated test suite standalone from the office build

[GitBox]

cbmarcum opened a new pull request, #145:
URL: https://github.com/apache/openoffice/pull/145

   This change has been discussed on the qa@ list [1] and more recently on the 
dev@ list [2] and my Fosdem 2022 talk from February 2022. See the README.md for 
more information.
   
   [1] https://lists.apache.org/thread/v6bnty1qxho4o5hmt4pg0rw00yxzrhx8
   [2] https://lists.apache.org/thread/yf1l47j7fw7z0rl074x7y1zy7qljy6mo
   
   If there are no objections I plan on merging this into trunk only per the 
discussion in [2] on Feb. 14.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum merged pull request #144: Refs #i128450# - disabled smb host only test

[GitBox]

cbmarcum merged pull request #144:
URL: https://github.com/apache/openoffice/pull/144


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum opened a new pull request #144: Refs #i128450# - disabled smb host only test

[GitBox]

cbmarcum opened a new pull request #144:
URL: https://github.com/apache/openoffice/pull/144


   per this email thread: 
https://lists.apache.org/thread/k1m3wqz04bj8b5kdg814h24qf45sv811
   AOO keeps appending a final / thus changing the intent of the test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum merged pull request #143: Refs #i128505# - testTableBorderLineStyle flaky test

[GitBox]

cbmarcum merged pull request #143:
URL: https://github.com/apache/openoffice/pull/143


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] cbmarcum opened a new pull request #143: Refs #i128505# - testTableBorderLineStyle flaky test

[GitBox]

cbmarcum opened a new pull request #143:
URL: https://github.com/apache/openoffice/pull/143


   testTableBorderLineStyle() was entering 0.55" instead of 0.50" at line 199 
because the ctrl-a wasn't selecting all of the cell contents and leaving a 5 in 
the cell. then when typing in 0.5 it became 0.55 and failing the assertion at 
line 222. added sleep at 197 to make sure focus is completed before ctrl-a.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] ardovm commented on pull request #142: Add "empty" and "not empty" autofilters

[GitBox]

ardovm commented on pull request #142:
URL: https://github.com/apache/openoffice/pull/142#issuecomment-1070847229


   > No problem, it can be cherry-picked later. @ardovm: I wonder why this PR 
was against AOO42X?
   
   I got confused by the bug report requesting a patch to the AOO42X branch. 
Sorry!
   
   I will cherry-pick it into trunk.
   
   IMHO it does not belong to AOO41X... but we can discuss this on the mailing 
list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #142: Add "empty" and "not empty" autofilters

[GitBox]

Pilot-Pirx commented on pull request #142:
URL: https://github.com/apache/openoffice/pull/142#issuecomment-1070808593






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] pedlino commented on pull request #142: Add "empty" and "not empty" autofilters

[GitBox]

pedlino commented on pull request #142:
URL: https://github.com/apache/openoffice/pull/142#issuecomment-1070831280


   I merged with branch 42X only (or at least that was my intention)
   If I messed up, I apologize. I assume it can be undone?
   
   
   > On 03/17/2022 11:21 AM Matthias Seidel ***@***.***> wrote:
   > 
   > 
   > 
   > 
   > 
   > Is this already in trunk?
   > 
   > —
   > Reply to this email directly, view it on GitHub 
https://github.com/apache/openoffice/pull/142#issuecomment-1070808593, or 
unsubscribe 
https://github.com/notifications/unsubscribe-auth/AIGNCYNDQYJX5ME357HA2IDVAMIS5ANCNFSM5Q5BMIRQ.
   > Triage notifications on the go with GitHub Mobile for iOS 
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email=8=524675
 or Android 
https://play.google.com/store/apps/details?id=com.github.android=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
   > You are receiving this because you modified the open/close state.Message 
ID: ***@***.***>
   > 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #142: Add "empty" and "not empty" autofilters

[GitBox]

Pilot-Pirx commented on pull request #142:
URL: https://github.com/apache/openoffice/pull/142#issuecomment-1070849460


   I did a Windows build now, seems to work.
   Yes, please cherry-pick it for trunk.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] ardovm commented on pull request #142: Add "empty" and "not empty" autofilters

[GitBox]

ardovm commented on pull request #142:
URL: https://github.com/apache/openoffice/pull/142#issuecomment-1070847229


   > No problem, it can be cherry-picked later. @ardovm: I wonder why this PR 
was against AOO42X?
   
   I got confused by the bug report requesting a patch to the AOO42X branch. 
Sorry!
   
   I will cherry-pick it into trunk.
   
   IMHO it does not belong to AOO41X... but we can discuss this on the mailing 
list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #142: Add "empty" and "not empty" autofilters

[GitBox]

Pilot-Pirx commented on pull request #142:
URL: https://github.com/apache/openoffice/pull/142#issuecomment-1070839577


   No problem, it can be cherry-picked later.
   @ardovm: I wonder why this PR was against AOO42X?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org