Re: WaE: LineJoint_MAKE_FIXED_SIZE
Hi Pavel, On 17.05.2013 07:37, Pavel Janík wrote: On Apr 19, 2013, at 11:02 AM, Pavel Janík wrote: On Apr 19, 2013, at 10:51 AM, Armin Le Grand wrote: I am confused; where does com::sun::star::drawing::LineJoint_MAKE_FIXED_SIZE come from? When you look at he UNO API file (trunk\main\offapi\com\sun\star\drawing\LineJoint.idl) there is no such definition. Since the headers are generated from the UNO API files I would wonder if we have such a token at all. I do not know, the compiler should know better ;-) solver/400/unxmacxi.pro/inc/offuh/com/sun/star/drawing/LineJoint.hdl: LineJoint_MAKE_FIXED_SIZE = SAL_MAX_ENUM I added missing cases to the code today. Okay, thanks. Still - where does it come from and who uses this? The *.hdl is crerated form the *.idl normally AFAIK. I'll have a look now... Greetings Armin -- ALG - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: WaE: LineJoint_MAKE_FIXED_SIZE
Hi Pavel,
On 17.05.2013 10:24, Armin Le Grand wrote:
Hi Pavel,
On 17.05.2013 07:37, Pavel Janík wrote:
On Apr 19, 2013, at 11:02 AM, Pavel Janík wrote:
On Apr 19, 2013, at 10:51 AM, Armin Le Grand wrote:
I am confused; where does
com::sun::star::drawing::LineJoint_MAKE_FIXED_SIZE come from? When
you look at he UNO API file
(trunk\main\offapi\com\sun\star\drawing\LineJoint.idl) there is no
such definition. Since the headers are generated from the UNO API
files I would wonder if we have such a token at all.
I do not know, the compiler should know better ;-)
solver/400/unxmacxi.pro/inc/offuh/com/sun/star/drawing/LineJoint.hdl: LineJoint_MAKE_FIXED_SIZE
= SAL_MAX_ENUM
I added missing cases to the code today.
Okay, thanks. Still - where does it come from and who uses this? The
*.hdl is crerated form the *.idl normally AFAIK. I'll have a look now...
Looks as if for all *.hdl files which define enums the idl compiler
generates a last entry in the form of
enum tag
{
...
tag_MAKE_FIXED_SIZE = SAL_MAX_ENUM
};
Thus, all is fine, no unused/new/unexpected entry. From the C++
perspective it's questionable when this leads to extra-code in
switch/case statements for an entry which seems to be there for UNO
technical reasons to be warning-free. Those entries have no
informational content as it seems.
Greetings
Armin
--
ALG
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: WaE: LineJoint_MAKE_FIXED_SIZE
On 17.05.2013 11:08, Pavel Janík wrote: Thus, all is fine, no unused/new/unexpected entry. From the C++ perspective it's questionable when this leads to extra-code in switch/case statements for an entry which seems to be there for UNO technical reasons to be warning-free. Those entries have no informational content as it seems. Right. Should I change them to default: break; instead? Maybe better, makes things clearar from my POV - +1 - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: WaE: LineJoint_MAKE_FIXED_SIZE
On Apr 19, 2013, at 11:02 AM, Pavel Janík wrote: On Apr 19, 2013, at 10:51 AM, Armin Le Grand wrote: I am confused; where does com::sun::star::drawing::LineJoint_MAKE_FIXED_SIZE come from? When you look at he UNO API file (trunk\main\offapi\com\sun\star\drawing\LineJoint.idl) there is no such definition. Since the headers are generated from the UNO API files I would wonder if we have such a token at all. I do not know, the compiler should know better ;-) solver/400/unxmacxi.pro/inc/offuh/com/sun/star/drawing/LineJoint.hdl: LineJoint_MAKE_FIXED_SIZE = SAL_MAX_ENUM I added missing cases to the code today. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: WaE: LineJoint_MAKE_FIXED_SIZE
Who is the author of this code? Is it right to not handle the value in these switches? On Apr 10, 2013, at 10:19 PM, Pavel Janík wrote: Hi, please have a look at this change: http://tmp.janik.cz/AO/WaE-cui+svx-LineJoint_MAKE_FIXED_SIZE.diff LineJoint_MAKE_FIXED_SIZE is not handled in two switch commands. It is OK? Please add proper handling or default case or whatever suits you. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: WaE: LineJoint_MAKE_FIXED_SIZE
Hi Pavel, I am confused; where does com::sun::star::drawing::LineJoint_MAKE_FIXED_SIZE come from? When you look at he UNO API file (trunk\main\offapi\com\sun\star\drawing\LineJoint.idl) there is no such definition. Since the headers are generated from the UNO API files I would wonder if we have such a token at all. On 19.04.2013 10:04, Pavel Janík wrote: Who is the author of this code? Is it right to not handle the value in these switches? On Apr 10, 2013, at 10:19 PM, Pavel Janík wrote: Hi, please have a look at this change: http://tmp.janik.cz/AO/WaE-cui+svx-LineJoint_MAKE_FIXED_SIZE.diff LineJoint_MAKE_FIXED_SIZE is not handled in two switch commands. It is OK? Please add proper handling or default case or whatever suits you. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: WaE: LineJoint_MAKE_FIXED_SIZE
On Apr 19, 2013, at 10:51 AM, Armin Le Grand wrote: I am confused; where does com::sun::star::drawing::LineJoint_MAKE_FIXED_SIZE come from? When you look at he UNO API file (trunk\main\offapi\com\sun\star\drawing\LineJoint.idl) there is no such definition. Since the headers are generated from the UNO API files I would wonder if we have such a token at all. I do not know, the compiler should know better ;-) solver/400/unxmacxi.pro/inc/offuh/com/sun/star/drawing/LineJoint.hdl: LineJoint_MAKE_FIXED_SIZE = SAL_MAX_ENUM -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
WaE: LineJoint_MAKE_FIXED_SIZE
Hi, please have a look at this change: http://tmp.janik.cz/AO/WaE-cui+svx-LineJoint_MAKE_FIXED_SIZE.diff LineJoint_MAKE_FIXED_SIZE is not handled in two switch commands. It is OK? Please add proper handling or default case or whatever suits you. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
