Re: [dev] Building CWS odff06 with debug
Daniel Rentz wrote: Hi Regina, Regina Henschel schrieb: Hi Eiki, Eike, please :-)) Eike Rathke schrieb: Yes, these are nasty, that's http://qa.openoffice.org/issues/show_bug.cgi?id=100534 MSVC somehow includes a few definitions in multiple objects, IIRC related to DLL_PUBLIC/DLL_PRIVATE declarations. Unfortunately, so far there is no resolution that would satisfy all compilers. Daniel apparently had some workaround, see issue, which didn't work on other platforms. He'll be back tomorrow so we can ask him for a temporary patch to make that work. I would like to get this patch. There is no patch available yet. The problem is that an object (pvlaydlg.obj AFAIK) is linked into two libraries. I still have to figure out where this object is linked wrongly. Workaround is to replace all inline functions which appear in the error message by regular functions (remove the inline and function body in the *.hxx and add the full function in the respective *.cxx). Inlines are evil. :-) They shouldn't appear in exported headers except for very trivial ones (one liners like return m_pPointer or so). Everything else can always lead to problems if parts of the code are built with debug=t. Regards, Mathias -- Mathias Bauer (mba) - Project Lead OpenOffice.org Writer OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't reply to nospamfor...@gmx.de. I use it for the OOo lists and only rarely read other mails sent to it. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] Product name in window title bar
Carsten Driesner wrote: Cor Nouws wrote: Hi, Someone asked me if it is possible to hide/remove the product name - thus OpenOffice.org - in window title bar. I would expect that this only can be done by building your own office. Is that right? Hi Cor, You can remove the product name from the whole Office only. Just set the product name property in Setup.xcu to an empty string. Unfortunately this property is used by other features, too (e.g. help, about box, ...). I don't consider this unfortunate. This is how it should work. Regards, Mathias -- Mathias Bauer (mba) - Project Lead OpenOffice.org Writer OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't reply to nospamfor...@gmx.de. I use it for the OOo lists and only rarely read other mails sent to it. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] Mercurial Pilot Feedback, Results
Jens-Heiner Rechtien wrote: Scalability: - overall perceived good performance, some were even quite enthusiastic about it (SVN users are easy to please ...). - there were three mentions of sub-par performance which all have been investigated shortly: - unexpected slow clone times on a very old machine with slow disks and little memory: this machine was probably simply underpowered for use with Mercurial, which is somewhat memory intensive due to the implementation in python. Also there was a misunderstanding about when hg uses hard links as an optimization. If that was true, please tell me why it also was that slow on my MacBook 2Ghz, 1GB RAM with (quite) fast disk, not an old like my Mac mini G4 with 512M RAM? But I told you that at that time, too - unexpected slow update of the working tree: caused by using the pure python replacements instead of the hg native shared libs. This should be avoided by any project of the size of OOo. You didn't read what I wrote. How please is http://packages.debian.org/lenny/mercurial not using native libs? (See the libc6 dependency and the .sos). Conclusion: === The purpose of the pilot was to find out if there are any important aspects which render Mercurial unusable as SCM for OOo. We found that there are none. This doesn't mean that Mercurial couldn't use some Not difficult if you ignore problems ;-( Regards, Rene - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] Mercurial Pilot Feedback, Results
[ forgot something ] Jens-Heiner Rechtien wrote: intensive due to the implementation in python. Also there was a misunderstanding about when hg uses hard links as an optimization. There wasn't actually, I just followed your pilot documentation 1:1. If that sucked you can't blame it on the person using that documentation. Regards, Rene - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] Mercurial Pilot Feedback, Results
Hi Rene, Rene Engelhard schrieb: Jens-Heiner Rechtien wrote: Conclusion: === The purpose of the pilot was to find out if there are any important aspects which render Mercurial unusable as SCM for OOo. We found that there are none. This doesn't mean that Mercurial couldn't use some Not difficult if you ignore problems ;-( I don't think, that Heiner ignore problem reports. He was very open for comments for this pilot and did a lot to evaluate problems. As you can read he has listed positive and also negative feedback. Also your feedback is listed with the result he had taken from the discussion. When I take a look at your type of communication at that time, I can understand when somebody isn't willing to communicate with you at all and isn't willing to read all your comments. But I don't think that Heiner did this. So please be constructive with your feedback and be friendly. Thanks, Thorsten - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] Consult on OOXML filter code contribution
Hello, He Feng Su schrieb: This is He Feng Su from IBM Lotus Symphony.We are working at the OOXML support enablement and enhancement (such as the shape in Word, Excel and PPT) and planning to make code contribution. Here are some questions: 1. In OO3.2, what other OOXML filter new support work will be included? Where can I find the worklist for OOXML filter support? A lot of additions (especially in the spreadsheet area) have been integrated in the meantime: - Import of PivotTables from XLSX and BIFF12 - Import of charts has been improved (new features in OOo's chart) - Import of OLE objects - Import of embedded ActiveX form controls from XLSX and PPTX The latter two points include extensive additions in the area of VML support. There is a wiki page (with a somewhat outdated list of supported features): http://wiki.services.openoffice.org/wiki/SpreadsheetML I will update it now... 2. If we do the code contribution now, when will the code be integrated into MWS? Can be in 3.2? Please make sure your contributions are compatible with the new milestones, at least DEV300m53 which contains the mentioned changes in the VML filter. Currently, it is still possible to add code for the 3.2 release. 3. What's the code contribution process? Who should I contact with? Usually, you create a new issue in IssueZilla of type PATCH and attach the patch file to that issue. Then, this patch will be reviewed and a discussion about problems/mistakes etc may take place, in the issue or on a mailing list. PS: I notice that, after OO open the excel file with the activeX control and save again, the control becomes the forms control and some properties and macro event binding are lost. I have started to implement export of ActiveX form controls a few years ago, but have noticed that Excel does not accept the controls (it simply does not show them). My assumption is that there is still some data missing, e.g. a metafile or so. But at that time I couldn't figure that out (limited time or whatever) so we stuck with the export of old-style drawing controls known from earlier versions of Excel. The drawback is, that these controls have a limited feature set, so some formatting attributes get lost on export. Some history: Excel 3.0 has introduced support of drawing objects at all and exactly one form control: the push button. Excel 5.0 has added a few more controls, such as checkboxes, option buttons, list boxes etc. All these controls work without OLE/ActiveX, I call them drawing controls here. In Excel 97, a new class of form controls has been added: the ActiveX controls. But for backward compatibility, the old controls are still supported. Excel does even offer them in the UI until now: In Excel 2003, you can find the toolbar Forms for the old-style drawing controls, and the toolbar Control Toolbox for the ActiveX controls. In Excel 2007, if the Developer tab is activated in the ribbon, you can find both sets of controls in a dropdown button. Does anybody know if there are people who are working or prepare to work on the activeX control keeping? Thanks! In sc/source/filter/inc/xcl97esc.hxx, you can find the lines // 0 = Export TBX form controls, 1 = Export OCX form controls. #define EXC_EXP_OCX_CTRL 0 If you set this define to 1, the export of form controls in ActiceX format is activated (instead of the old drawing format). But as said, even if this still compiles (code was inactive for a few years), Excel will currently not accept the results. Daniel - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] Consult on OOXML filter code contribution
Hello, Le vendredi 31 juillet 2009 à 09:55 +0200, Daniel Rentz a écrit : He Feng Su schrieb: This is He Feng Su from IBM Lotus Symphony.We are working at the OOXML support enablement and enhancement (such as the shape in Word, Excel and PPT) and planning to make code contribution. Here are some questions: 1. In OO3.2, what other OOXML filter new support work will be included? Where can I find the worklist for OOXML filter support? I have been improving the docx import filter for a few months. You can find the code in the writerfilter32bugfixes01 CWS. Even thought I haven't upstreamed all my code yet, you can find the complete patche on go-oo git repo: http://cgit.freedesktop.org/ooo-build/ooo-build/tree/patches/dev300/docx-import-fixes.diff. My plan is to integrate the CWS in OOo 3.2, the differences between the patch and the CWS may be upstreamed later. I have blogged on some of the improvements here: http://cedric.bosdonnat.free.fr/wordpress/?tag=ooxml And you can have a look at my bug list (Closed and opened bugs) on novell bugzilla: http://tinyurl.com/cbosdo-novell-ooxml-bugs I hope this can help you. Regards, -- Cédric Bosdonnat Go-OO Novell hacker OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] Product name in window title bar
Hi, Regina Henschel wrote (30-7-2009 16:03) There is the node ooName in Openoffice.org3\share\registry\modules\org\openoffice\Setup\Setup-brand.xcu But this entry is not only used in the title bar, but also in ToolsOptions and in the Help and likely in other places too. I use it to distinguish different developer builds. Thanks for your answers, Regina, Carsten, Matthias. I see that for an 2.x version ( ;-) ) I can use share/registry/data/org/openoffice/Setup.xcu For me it is no problem that this also affects the name in other places. Regards, Cor -- Cor Nouws - nl.OpenOffice.org marketing contact Ontwikkelaar? Join! http://council.openoffice.org/developers.html Gevoel niet vrij te zijn? Zie www.nieuwsteversie.nl - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] Product name in window title bar
Mathias Bauer wrote: Carsten Driesner wrote: Cor Nouws wrote: Hi, Someone asked me if it is possible to hide/remove the product name - thus OpenOffice.org - in window title bar. I would expect that this only can be done by building your own office. Is that right? Hi Cor, You can remove the product name from the whole Office only. Just set the product name property in Setup.xcu to an empty string. Unfortunately this property is used by other features, too (e.g. help, about box, ...). I don't consider this unfortunate. This is how it should work. Hi Mathias, Unfortunately was meant to be related to the person who ask the question (unfortunately for him/her ...). The feature itself works as specified and how it should work. So my comment was not a validation for the current implementation or complaining that the feature is broken. Regards, Carsten - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] Mercurial Pilot Feedback, Results
Hi Rene, please see my comments inline, Rene Engelhard wrote: Jens-Heiner Rechtien wrote: Scalability: - overall perceived good performance, some were even quite enthusiastic about it (SVN users are easy to please ...). - there were three mentions of sub-par performance which all have been investigated shortly: - unexpected slow clone times on a very old machine with slow disks and little memory: this machine was probably simply underpowered for use with Mercurial, which is somewhat memory intensive due to the implementation in python. Also there was a misunderstanding about when hg uses hard links as an optimization. If that was true, please tell me why it also was that slow on my MacBook 2Ghz, 1GB RAM with (quite) fast disk, not an old like my Mac mini G4 with 512M RAM? But I told you that at that time, too - unexpected slow update of the working tree: caused by using the pure python replacements instead of the hg native shared libs. This should be avoided by any project of the size of OOo. You didn't read what I wrote. How please is http://packages.debian.org/lenny/mercurial not using native libs? (See the libc6 dependency and the .sos). You shouldn't think that only you have problems here and there :-) This bullet point was about an observation by Mikhail, and we think we have tracked it down to this problem. Conclusion: === The purpose of the pilot was to find out if there are any important aspects which render Mercurial unusable as SCM for OOo. We found that there are none. This doesn't mean that Mercurial couldn't use some Not difficult if you ignore problems ;-( I certainly do not ignore problems. I may come to different conclusions at that time, but I do not ignore them. I even blogged about it at that time. Heiner -- Jens-Heiner Rechtien recht...@sun.com - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] Building CWS odff06 with debug
Hi Regina, On Tuesday, 2009-07-28 18:05:46 +0200, Regina Henschel wrote: Workaround (hopefully, didn't try) for now: remove all object files mentioned in the error messages and rebuild the module without debug. Then remove the resulting DLLs and relink them with debug to include debug code of other object files again: cd sc del wntmsci12/slo/{the,object,files,mentioned}.obj build Here it breaks again :( and the .obj files are there again. Same errors already defined in ... with same object files although you built them without debug this time? Are you sure you removed all object files that were mentioned in the error messages? del wntmsci12/bin/*.dll cd util dmake debug=t Or was the error during this step? Eike -- OOo/SO Calc core developer. Number formatter stricken i18n transpositionizer. SunSign 0x87F8D412 : 2F58 5236 DB02 F335 8304 7D6C 65C9 F9B5 87F8 D412 OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't send personal mail to the e...@sun.com account, which I use for mailing lists only and don't read from outside Sun. Use er...@sun.com Thanks. pgp5hr0uOsEI9.pgp Description: PGP signature
[dev] Important Process for Mercurial Users
Hi there! Everyone using a mercurial based CWS MUST enter the new milestone in EIS manually after rebasing the CWS to a new milestone using mercurial commandline or gui tools. For SVN and CVS Childworkspaces the cws rebase Kommand stored the information about a new milestone in EIS. Mercurial based CWSs are updated to a newer milestone using mercurial tools only. These do not know about EIS at all. Thus in order to not break processes which depend on the correct milestone version information in EIS like buildbots or automated tests do for example a developer MUST update milestone information in EIS manually after using mercurial tools to update the source code to the new milestone. The Milestone and the MasterWorkspace are two separate Fields on the CWS EditPage in EIS. The Milestone field MUST only contain the milestone (eg. m53) and MUST NOT contain masterworkspacename+milestone (eg. not DEV300m53). Kind regards, Bernd Eilers - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] Important Process for Mercurial Users
Cool, this simplifies hg CWS handling a lot. However may I suggest putting in the current milestone into the edit field on the page where you edit the CWS properties ? Kind regards, pl Bernd Eilers wrote: know about EIS at all. Thus in order to not break processes which depend on the correct milestone version information in EIS like buildbots or automated tests do for example a developer MUST update milestone information in EIS manually after using mercurial tools to update the source code to the new milestone. -- Sanity is just a bad excuse for a lack of imagination. -- Author unknown Registered Office: Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten Commercial register of the Local Court of Munich: HRB 161028 Managing Directors: Thomas Schröder, Wolfgang Engels, Wolf Frenkel Chairman of the Supervisory Board: Martin Häring - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] Building CWS odff06 with debug
Hi Eike, Eike Rathke schrieb: Hi Regina, On Tuesday, 2009-07-28 18:05:46 +0200, Regina Henschel wrote: Workaround (hopefully, didn't try) for now: remove all object files mentioned in the error messages and rebuild the module without debug. Then remove the resulting DLLs and relink them with debug to include debug code of other object files again: cd sc del wntmsci12/slo/{the,object,files,mentioned}.obj build Here it breaks again :( and the .obj files are there again. Same errors already defined in ... with same object files although you built them without debug this time? Yes. Are you sure you removed all object files that were mentioned in the error messages? I removed scui_dftl_version.obj and pvfundlg.obj with rm (del does not work) and controlled in the explorer that the files are really deleted. I also tried it with only removing pvfundlg.obj. Same result, build breaks. Would it help, to sent you the complete build log? del wntmsci12/bin/*.dll cd util dmake debug=t Or was the error during this step? No, I had not made that step because it breaks already before. kind regards Regina - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] Important Process for Mercurial Users
Hi there! Philipp Lohmann wrote: Cool, this simplifies hg CWS handling a lot. However may I suggest putting in the current milestone into the edit field on the page where you edit the CWS properties ? Well yes this was a bug which has been fixed now! Kind regards, pl Regards, Bernd Eilers Bernd Eilers wrote: know about EIS at all. Thus in order to not break processes which depend on the correct milestone version information in EIS like buildbots or automated tests do for example a developer MUST update milestone information in EIS manually after using mercurial tools to update the source code to the new milestone. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org