Re: [dev] Warning-Free Code

2005-09-04 Thread Ken Foskey
On Fri, 2005-09-02 at 09:58 +0200, Nikolai Pretzell wrote:
 Hi all,
 
   Ken Foskey wrote:
  So I would actually recommend against an all out warnings push unless
  everyone is VERY clear the objective is to highlight bugs not to remove
  warnings.  The difference in objectives is very important.
 
 Yes, but given the mass of code we have, the only way I see to really 
 highlight bugs, is to remove as much as all warnings.

I consider myself a very experienced developer and to boot I have worked
through a huge amount of warnings removal in several programs.  I have
been caught before between the subtle difference between warning removal
and removing warnings for the purpose of highlighting bugs.

Experience is not the issue,  mundane means that even experienced
programmers will hide the bug by correcting the warning.

The goal of the task is to highlight bugs by removing obvious warnings
then taking your time to eliminate the rest.  Do this too fast and your
fingers and quick solutions will take over.  I speak from experience.

Thanks
Ken Foskey
OpenOffice.org Programmer


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dev] Warning-Free Code

2005-08-30 Thread Ken Foskey
On Mon, 2005-08-29 at 17:59 +0200, Stephan Bergmann wrote:

 If someone think it's reasonable to suppress a warning, this must be 
 discussed with the team members. It should also be discussed in public, 
 using the mailing list [EMAIL PROTECTED] Please start the subject with 
 “compiler warnings:”.

* Initially I would suggest -Wno-reorder (I think)

There are a HUGE number of errors caused simply by the order of the
variables in the class declaration and I have only found one instance
where it indicated a real error (parent initialisation depended on child
data).  The needle for this one is small and the haystack particularly
large.  Because of the pervasiveness of this change merges afterwards a
PAINFUL!  I speak from experience.  I would think about doing this
module by module as a separate exercise.

* Second possibly -Wno-unknown-pragmas.

There are a few pragmas for VC that are in the code and don't really
affect things.  I have bracketted them but effort for return is fairly
low.


* Before you start you might want to merge cws waratahbasctl.  This is a
warnings cws that has lingered for want of a QA person.  Have a look at
the assignment bug contained within.

* I also have a large number of patches that I can apply to save you
time.  I will also volunteer to assist :-)

* In the interim I would recommend adding immediately BY DEFAULT
-Wparentheses to the gcc compile.  This really does highlight a number
of problems with the code, good return error for extra warning ratio.

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dev] Warning-Free Code

2005-08-30 Thread Ken Foskey
On Tue, 2005-08-30 at 18:50 +0200, Mathias Bauer wrote:
 Ken Foskey wrote:
  On Mon, 2005-08-29 at 17:59 +0200, Stephan Bergmann wrote:
  
  If someone think it's reasonable to suppress a warning, this must be 
  discussed with the team members. It should also be discussed in public, 
  using the mailing list [EMAIL PROTECTED] Please start the subject with 
  “compiler warnings:”.
  
  * Initially I would suggest -Wno-reorder (I think)
  
  There are a HUGE number of errors caused simply by the order of the
  variables in the class declaration and I have only found one instance
  where it indicated a real error (parent initialisation depended on child
  data).  The needle for this one is small and the haystack particularly
  large.  Because of the pervasiveness of this change merges afterwards a
  PAINFUL!  I speak from experience.  I would think about doing this
  module by module as a separate exercise.
 
 Just to make sure that I understood correctly: you suggest to ignore
 these warnings but work on it in a subsequent CWS?
 
 This is a real useful warning that can find some really nasty errors, so
  we should definitely work on keeping it activated, but of course if
 there are so much places that trigger the warning it could be a good
 idea to postpone it to a later CWS.

Yes,  In my experience this warning leads to a lot of changes.  Doing
this initialy will make the whole process really tedious, (as opposed to
simply tedious).

It will also break a lot of merges of patches.

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dev] re: using ant to create source from .idl file

2005-06-23 Thread Ken Foskey
On Wed, 2005-06-22 at 15:11 -0400, James Black wrote:
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1
 
 I am hoping that someone could send me a sample of creating source from
 the .idl file, as it appears that there are a few steps to do this task.

There is however you might want to describe why you want to do this and
for what language binding so that you can get accurate help.

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dev] Urgent

2005-06-10 Thread Ken Foskey
On Fri, 2005-06-10 at 08:01 -0700, Doaa Shawky wrote:
 Dear Sir,
  I downloaded the source of openoffice and I need to separate the code 
 of the Writer and the Calc components from other components for 
 research reasons. Is there any documentation that can help me to determine 
 the 
 code related to each component individually?

There is a huge amount of common code this is why it is not worth
separating the applications.

sw is the source dir for writer,  sc for the calc part.  This is only a
very small portion of the whole.  Now what were you actually wanting to
study?



-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dev] MSWord File Structure

2005-06-10 Thread Ken Foskey
On Thu, 2005-06-09 at 12:53 -0400, Hesham Ahmed wrote:
 Hi, i'm looking for information about the roadmap (file structure or 
 definition) of DOC file of microsoft word. My purpose is to understand it to 
 build an application to extract information out of word .doc file. Thanks 
 for supporting me.

why, how many, how often, what for?

scripting OOo could help you.

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[dev] missing scslots.hxx

2005-06-01 Thread Ken Foskey
/data/office/binfilter/bf_sc/source/ui/app/sc_scmod.cxx:183:23:
scslots.hxx: No such file or directory

Plus lots of other errors, probably related...

froddo: /data/office
$ find . -name scslots.hxx

Anyone seen this file :-)

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dev] missing scslots.hxx

2005-06-01 Thread Ken Foskey
On Wed, 2005-06-01 at 22:04 +1000, Ken Foskey wrote:
 /data/office/binfilter/bf_sc/source/ui/app/sc_scmod.cxx:183:23:
 scslots.hxx: No such file or directory
 
 Plus lots of other errors, probably related...
 
 froddo: /data/office
 $ find . -name scslots.hxx
 
 Anyone seen this file :-)

rscdep failed to build...

Sorry for the noise.

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dev] circular dependency in tools/

2005-05-29 Thread Ken Foskey
On Sun, 2005-05-29 at 20:16 +0200, Pavel Janík wrote:
From: Ken Foskey [EMAIL PROTECTED]
Date: Sun, 29 May 2005 00:39:34 +1000
 
 Ken,
 
 In head has anyone figured out how to get rid of the circular
 dependency.  In order to link some libraries inside tools you have to
 have already linked tools.
 
 what is the error message? What lib in tools needs what library?

libtl, the tools library itself.   Hence the recursive nature of the
problem.

THanks
Ken


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[dev] circular dependency in tools/

2005-05-28 Thread Ken Foskey
In head has anyone figured out how to get rid of the circular
dependency.  In order to link some libraries inside tools you have to
have already linked tools.

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dev] ./configure before compiling problem with cups

2005-05-17 Thread Ken Foskey
On Tue, 2005-05-17 at 07:44 -0700, Vizion wrote:

 please read original email carefully:
 You will see that I do have cups.h

But it is not in your standard compiler search path:

AC_CHECK_HEADER(cups/cups.h, [],
 [AC_MSG_ERROR([cups/cups.h could not be found. 
 libcupsys2-dev or cups???-devel missing?])], [])
 

This piece of configure requires the compiler to pick it up without
changes try something to serch an additional search path, from memory
-I /path/to/my/cups/includes/

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dev] idlc on Windows

2005-05-11 Thread Ken Foskey
On Wed, 2005-05-11 at 11:10 +0200, Jürgen Schmidt wrote:
 Hi Jorge,
 
 this is a bug and it is interesting that nobody until now have detected 
 this bug. Please submit an issue to me.
 A workaround would be to install the SDK in a path without spaces.

Paths with spaces issue is documented in the build guides.  We probably
should check and error these in configure.

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dev] Writing Code for OOo - Introduction

2005-04-28 Thread Ken Foskey
On Wed, 2005-04-27 at 16:48 -0400, Merrell, Douglas Stuart wrote:
 Hi,
 
 I want to get involved (anti-M$) but I don't know where to start.  I
 am currently reading the Developer's Guide to get acquainted with the
 architecture.  I mainly want to write Java code but I also use to
 write C++.  I know XML completely and work with XML at a functional
 level professionally.  My B.S. is in Computer Science and I'm a Sun
 Certified Programmer... studying for the Developer Exam in my free
 time.
 
 I was wondering if I could start out providing
 patches/fixes/enhancements to existing code first and build up a base
 level of knowledge about how the different modules interact?

I have a problem with beanshell that I need help with:

http://www.openoffice.org/issues/show_bug.cgi?id=48187

Regarding the rest, mainly what things interest you most apart from
languages.  There are a lot of tings that need to be done it is better
to direct you to a project that interests you.  Possibly you offer help
in the http://xml.openoffice.org project.

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[dev] error on head

2005-04-28 Thread Ken Foskey

Has anyone seen this error and have anything to fix it?

... languages ENUS ... 

**
ERROR: ERROR: Missing files
in function: remove_Files_Without_Sourcedirectory
**

**
ERROR: Saved
logfile: 
/data/office/instsetoo_native/unxlngi6.pro/OpenOffice/logging/ENUS/log_SRC680__ENUS.log
**
... analyzing files ...
ERROR: The following files could not be found: 
ERROR: File not found: shared_ENUS.zip
ERROR: File not found: sdatabase_ENUS.zip
ERROR: File not found: sbasic_ENUS.zip
ERROR: File not found: schart_ENUS.zip
ERROR: File not found: autotextshare_ENUS.zip
ERROR: File not found: palettes_ENUS.zip
ERROR: File not found: tpllayoutimpr_ENUS.zip
ERROR: File not found: tplpresntimpr_ENUS.zip
ERROR: File not found: tplwizdesktop_ENUS.zip
ERROR: File not found: tplwizfax_ENUS.zip
ERROR: File not found: tplwizagenda_ENUS.zip
ERROR: File not found: tplwizmemo_ENUS.zip
ERROR: File not found: tplwizreport_ENUS.zip
ERROR: File not found: tplwizstyles_ENUS.zip
ERROR: File not found: wordbook_ENUS.zip
ERROR: File not found: swriter_ENUS.zip
ERROR: File not found: scalc_ENUS.zip
ERROR: File not found: sdraw_ENUS.zip
ERROR: File not found: simpress_ENUS.zip
ERROR: File not found: smath_ENUS.zip
... cleaning the output tree ...
Fri Apr 29 09:18:55 2005 (00:03 min.)
dmake:  Error code 255, while making 'openoffice_ENUS'
'---* tg_merge.mk *---'

ERROR: next directories could not be built:
/data/office/instsetoo_native/util

ERROR: please check these directories and build the corresponding
module(s) anew!!


-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dev] Thoughts on CVS?

2005-04-26 Thread Ken Foskey
On Mon, 2005-04-25 at 15:31 -0400, Daniel Carrera wrote:
 Hi all,
 
 This is just one of those Daniel is curious questions :-)
 
 What are your thoughts on CVS? Most OOo developers are Sun developers. 
 What SCM do you use at Sun?
 
 CVS is sort of the de-facto standard in the FOSS world, but I also know 
 that it's a bit old and doesn't do the things that modern SCM's do 
 (renaming a file!). So I'd like to hear some thoughts.

CVS is fine for small centralised projects.  It is really awful for
larger open source projects.

From my point of view the problem is lack of distributed control so that
things like diffs etc take a long time to do.

 On a related topic, if I wanted to play around with a SCM, which would 
 you recommend? (open source svp). Some times I wish I had one. Right 
 now, when I work on a program, I keep doing a 'cp -r'.
 
 I'm looking at Darcs right now. It looks neat.

From my point of view I would do nothing until the current SCM wars
settle down.  Linus has thrown the gauntlet down and a lot of SCM
projects are doing great things but this also makes them a little
unstable.

subversion is an enhanced CVS and improves things.  Does not make
fundamental improvements.

aegis is a forced testing framework that has a source repository as
well.

archs latest release is badly broken.

I went to the http://bazaar-ng.org presentation at LCA it looks like the
future of source control but it really is raw.

Ubuntu Linux is throwing a lot of weight to baz, an archs derivative
with easier command structures and faster performance.  If I was jumping
today I would definitely look at this.  They are actively canvasing
support from other teams.  Seems like a great idea.


I want to write a proposal on implementing a replacement for CVS so I
have been spending some time learning about this stuff.

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dev] Issue 4925

2005-04-26 Thread Ken Foskey
On Mon, 2005-04-25 at 10:05 -0400, [EMAIL PROTECTED]
wrote:
 Hello,
 
 For the past three years this issue has gone unresolved.  In an 
 attempt to bring more attention to this BUG, I am reaching out to my 
 community.  I am pleading for someone to resolve this issue.   Every 
 developer that uses Ooo for manipulating data and saving it as a CSV file 
 has to find another application (MS Excel) to get there work done.  Please 
 help us.
 
 http://www.openoffice.org/issues/show_bug.cgi?id=4925
 

Try this in excel:

Format a column short so that you get  for field overflow.
Write to a CSV file.
Look at it, the field is ### in the export file.

There are flaws with the MS model.

There probably should be an option however I have heard that the major
problem is the lack of certain functions (from spreadsheet people).
Basically what is your major problem is not others.  There are other
methods of solving your problem so you could work around it or just work
with your own external formatting rules therefore it is not a major show
stopper even for you.  It is more of an annoyance.

CSV is a really bad format, I have seen csv files from excel loaded into
excel that are totally different.  I have seen interoperability problems
with csv files between applications.  I STRONGLY recommend you abandon
csv files as a method of transporting data between applications.

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dev] Thoughts on CVS?

2005-04-26 Thread Ken Foskey
On Tue, 2005-04-26 at 23:09 +0200, David Fraser wrote:
 Martin Hollmichel wrote:
  Daniel Carrera wrote:

  I kind of like the idea of just grabbing my own branch and playing 
  with it, and doing my own commits, without having to touch the 
  central server. And then if it turns out I produce something 
  worthwhile I can try to get it approved.
 
  It seems that you got the idea of having childworkspaces :)
 
 Correct me if I'm wrong, but childworkspaces still touch the central 
 server, they just operate on a private branch...

Yes, you are correct.  The concept of the new SCM tools are a
fundamental shift in the way you work.  The ability to branch and merge
externally on your own tree appeals to me.  For example when a new CWS
is created internally for review there is a period of time until the
merge, during that time I want to be able to merge that branch into my
tree then when head merges with that branch I want the merge to actually
work.  The new SCM tools do that.

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [dev] Help with Free Software Magazine

2005-04-24 Thread Ken Foskey
On Sun, 2005-04-24 at 00:51 +0800, Tony Mobily IMAP wrote:

 I created an OpenOffice document (see attach) which basically follows 
 the specs, assigning a different style to XML equivalent. I manupulated 
 it with Word a little bit, because that's what's going to happen to it 
 when it goes through copy editing.

At the OOo miniconf at linux.conf.au there was a process to merge in
documentation into a template.  It avoided XML (There are traps to
this...) it simply replaced keywords in the document with text simplest
approach is:

unzip
cat document.xml | sed 's/{$MYVAR}/some value I want to see/g'  new
zip

This was so simple and fast.  This process could help you a lot.  I was
going to write a sample perl module and put it somewhere in the tree
when I get time.

Traps are if you get actual XML inside the text you replace you could
end up in trouble.

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[dev] HEAD: simple patch for desktop

2005-03-03 Thread Ken Foskey
stderr not defined...

===
RCS file: /cvs/framework/desktop/source/migration/services/jvmfwk.cxx,v
retrieving revision 1.4
diff -u -r1.4 jvmfwk.cxx
--- jvmfwk.cxx  27 Jan 2005 14:27:09 -  1.4
+++ jvmfwk.cxx  3 Mar 2005 11:10:49 -
@@ -58,6 +58,7 @@
  *
  *

/
+#include stdio.h

 #include cppuhelper/implbase4.hxx
 #include cppuhelper/implementationentry.hxx


-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[dev] building 3.4 and failing...

2005-03-01 Thread Ken Foskey

I am getting errors like this on gcc 3.4 when I can build successfully
on gcc 3.3.

ccache gcc-3.4 -z combreloc -Wl,-z,defs -Wl,-rpath,'$ORIGIN' -shared
-L../unxlngi6.pro/lib -L../lib -L/data2/office/solenv/unxlngi6/lib
-L/data2/office/solver/680/unxlngi6.pro/lib
-L/data2/office/solenv/unxlngi6/lib -LNO_JAVA_HOME/lib
-LNO_JAVA_HOME/jre/lib/i386 -LNO_JAVA_HOME/jre/lib/i386/client
-LNO_JAVA_HOME/jre/lib/i386/native_threads
-L/usr/X11R6/lib ../unxlngi6.pro/slo/vos3gcc3_version.o 
../unxlngi6.pro/slo/vos3gcc3_description.o -o 
../unxlngi6.pro/lib/libvos3gcc3.so ../unxlngi6.pro/slo/bytarray.o 
../unxlngi6.pro/slo/bytestrm.o ../unxlngi6.pro/slo/conditn.o 
../unxlngi6.pro/slo/mutex.o ../unxlngi6.pro/slo/object.o 
../unxlngi6.pro/slo/refernce.o ../unxlngi6.pro/slo/socket.o 
../unxlngi6.pro/slo/thread.o ../unxlngi6.pro/slo/stream.o 
../unxlngi6.pro/slo/module.o ../unxlngi6.pro/slo/timer.o 
../unxlngi6.pro/slo/process.o ../unxlngi6.pro/slo/security.o 
../unxlngi6.pro/slo/signal.o ../unxlngi6.pro/slo/pipe.o 
../unxlngi6.pro/slo/xception.o -luno_sal -ldl -lpthread -lm -Wl,-Bdynamic 
-lstlport_gcc
../unxlngi6.pro/slo/bytarray.o(.gnu.linkonce.d._ZTIN3vos10OByteArrayE
+0x0): undefined reference to `vtable for
__cxxabiv1::__si_class_type_info'


Note that I cannot be sure however configure updated. and the CVER
define is now -DC341 which changes the nature of the code.  I think that
the -DC341 is based on version not whether the gcc has visibility
patches in it or not.

This is probably issue 
http://qa.openoffice.org/issues/show_bug.cgi?id=34676

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[dev] development wiki

2005-01-28 Thread Ken Foskey

I have been using a wiki for http://www.communitycode.org/ and this is a
really great idea.  Is there one for the development documentation of
OOo?

-- 
Ken Foskey
OpenOffice.org developer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]