Re: [OSM-dev] GSoC 17 : JOSM- New main menu

[Michael Zangl]

Hi,

That ticket is just a rough starting point. Simply implementing the
changes there won't be enough for a full GSoC - you would be done in a
week ;-). Some minor, easy changes may already be applied - don't worry
about them. Your task would be to work on the big picture. So part of
your task is defining the task you will be working on ;-). You can work
on other parts of the UI (context menus, ...) if you feel the need for it.
This is not like a university project where you get a todo list and
simply work on it.

If you have further questions on details, feel free to mail me privately
without CCing the mailing list. In cases like this one that need
clarification about a JOSM ticket, it is best to write your answer below
that ticket. Don't worry, I'll get a mail as soon as you write a comment
there.

Michael

Am 09.03.2017 um 18:51 schrieb Nathiesha Maddage:
> Hi Micheal,
> 
> I studied the MainMenu class and the associated Activity classes, and
> got a basic idea on how the code is structured. I will get more
> familiarized with it as you have suggested, to come up with a clean up
> plan for the source code. 
> I think the required changes of visual menu is all listed here [1]. I
> went through that and got an idea about the proposed changes. However I
> could not find a few of the listed problems, in the JOSM version I compiled.
> 
> eg: 
> 
>   * Remove functionality - *Copy coordinates actions*
>   * Move menu items - *Jump to position -> Two items up and name it Zoom
> to coordinates...*
>   * Restructure the Tools menu - *Areas: Mirror , join, multipolygon*
> 
> Are those issues already fixed? Or I might have missed them? And are
> there any other new requirement other than those, that need to be done?
> 
> I still could not try out installing new plugins and observe how they
> fit in. I will do so.
> 
> [1]. https://josm.openstreetmap.de/ticket/13456#no1
> 
> On Wed, Mar 8, 2017 at 12:17 AM, Michael Zangl
>  > wrote:
> 
> Hi Nathiesha,
> 
> For this particular project, I'd recommend that you familiarize yourself
> with the editing options that JOSM provides. Fell free to install many
> plugins and see how they integrate into JOSM.
> 
> You should also get familiar with the menu code, starting at the
> MainMenu class. It currently has a lot of public fields and other ugly
> code. You should develop a cleanup plan for both the source code and the
> the visual menu. Feel free to use object-oriented approaches. The new
> menu should be compatible to the old API as good as possible, since all
> JOSM plugins depend on it and we don't want to break them all. You can
> use the adapter pattern for this, so don't worry too much about it.
> 
> Michael
> 
> Am 07.03.2017 um 19:17 schrieb Nathiesha Maddage:
> > Hi Michael,
> >
> > Thanks for the quick reply.
> >
> > I am Nathiesha Maddage, a final year undergraduate at University of
> > Moratuwa, Sri Lanka. I participated in GSoC 2016 as well and completed
> > the project successfully, by developing an Eclipse plugin.
> >
> > I was interested in OSM, since I was doing my final year University
> > project on visualizing the land use with OSM data and Google satellite
> > images. I went through the project list and I am interested in the JOSM
> > project , new main menu. I am familiar with Java and I am getting
> > familiarized with JOSM.
> >
> > I compiled the source code using Eclipse. I will go through it to get a
> > basic understanding about the code and the project structure. And I will
> > use the JOSM mailing list and bug tracker, as you have suggested, if I
> > find any question regarding the code.
> >
> > Is there any other resources that I should follow in the meantime, that
> > would be useful for this project?
> >
> > Github -https://github.com/nathiesha
> > LinkedIn - https://www.linkedin.com/in/nathiesha-maddage-48710096/
> 
> >  >
> >
> >
> > On Tue, Mar 7, 2017 at 11:24 PM, Michael Zangl
> >  
> >  >> wrote:
> >
> > Hi,
> >
> > I am the one who proposed that project.
> >
> > Getting your own compiled version of JOSM is a good starting
> point.
> >
> > You can experiment with the github repository. It has not been
> updated
> > since January, but this should be no problem since there were
> only minor
> > changes since then. It is just a read-only mirror of the SVN
> 

Re: [OSM-dev] GSoC 17 : JOSM- New main menu

[Nathiesha Maddage]

Hi Micheal,

I studied the MainMenu class and the associated Activity classes, and got a
basic idea on how the code is structured. I will get more familiarized with
it as you have suggested, to come up with a clean up plan for the source
code.
I think the required changes of visual menu is all listed here [1]. I went
through that and got an idea about the proposed changes. However I could
not find a few of the listed problems, in the JOSM version I compiled.

eg:

   - Remove functionality - *Copy coordinates actions*
   - Move menu items - *Jump to position -> Two items up and name it Zoom
   to coordinates...*
   - Restructure the Tools menu - *Areas: Mirror , join, multipolygon*

Are those issues already fixed? Or I might have missed them? And are there
any other new requirement other than those, that need to be done?

I still could not try out installing new plugins and observe how they fit
in. I will do so.

[1]. https://josm.openstreetmap.de/ticket/13456#no1

On Wed, Mar 8, 2017 at 12:17 AM, Michael Zangl <
openstreet...@michael.fam-zangl.net> wrote:

> Hi Nathiesha,
>
> For this particular project, I'd recommend that you familiarize yourself
> with the editing options that JOSM provides. Fell free to install many
> plugins and see how they integrate into JOSM.
>
> You should also get familiar with the menu code, starting at the
> MainMenu class. It currently has a lot of public fields and other ugly
> code. You should develop a cleanup plan for both the source code and the
> the visual menu. Feel free to use object-oriented approaches. The new
> menu should be compatible to the old API as good as possible, since all
> JOSM plugins depend on it and we don't want to break them all. You can
> use the adapter pattern for this, so don't worry too much about it.
>
> Michael
>
> Am 07.03.2017 um 19:17 schrieb Nathiesha Maddage:
> > Hi Michael,
> >
> > Thanks for the quick reply.
> >
> > I am Nathiesha Maddage, a final year undergraduate at University of
> > Moratuwa, Sri Lanka. I participated in GSoC 2016 as well and completed
> > the project successfully, by developing an Eclipse plugin.
> >
> > I was interested in OSM, since I was doing my final year University
> > project on visualizing the land use with OSM data and Google satellite
> > images. I went through the project list and I am interested in the JOSM
> > project , new main menu. I am familiar with Java and I am getting
> > familiarized with JOSM.
> >
> > I compiled the source code using Eclipse. I will go through it to get a
> > basic understanding about the code and the project structure. And I will
> > use the JOSM mailing list and bug tracker, as you have suggested, if I
> > find any question regarding the code.
> >
> > Is there any other resources that I should follow in the meantime, that
> > would be useful for this project?
> >
> > Github -https://github.com/nathiesha
> > LinkedIn - https://www.linkedin.com/in/nathiesha-maddage-48710096/
> > 
> >
> >
> > On Tue, Mar 7, 2017 at 11:24 PM, Michael Zangl
> >  > > wrote:
> >
> > Hi,
> >
> > I am the one who proposed that project.
> >
> > Getting your own compiled version of JOSM is a good starting point.
> >
> > You can experiment with the github repository. It has not been
> updated
> > since January, but this should be no problem since there were only
> minor
> > changes since then. It is just a read-only mirror of the SVN
> repository.
> >
> > For detailed questions about the code, JOSM has a own mailing list:
> > https://lists.openstreetmap.org/listinfo/josm-dev
> > 
> > But we tend to use the bug tracker more, so you can simply comment on
> > that ticket.
> >
> > If you have any further questions about the project, I'm always open
> to
> > a chat session ;-).
> >
> > Michael
> >
> > Am 07.03.2017 um 18:14 schrieb Nathiesha Maddage:
> > > Hi all,
> > >
> > > I downloaded the JOSM source code from the git hub repository [1]
> > > because I am more familiar with git than svn. Is that OK, or
> should I
> > > download the source code from the SVN repository, as git
> repository is
> > > listed as unofficial in the website [2]?
> > >
> > > [1]. https://github.com/openstreetmap/josm
> > 
> > > [2]. https://josm.openstreetmap.de/wiki/Source%20code
> > 
> > >
> > > --
> > > Best Regards,
> > > *Nathiesha Maddage*
> > > Undergraduate,*
> > > *
> > > Department of Computer Science & Engineering,
> > > Faculty of Engineering,
> > > University of Moraduwa,
> > > Sri Lanka.
> > >
> > >
> > >
> > > ___
> > > dev mailing list

Re: [OSM-dev] GSoC 17 : JOSM- New main menu

[Michael Zangl]

Hi Nathiesha,

For this particular project, I'd recommend that you familiarize yourself
with the editing options that JOSM provides. Fell free to install many
plugins and see how they integrate into JOSM.

You should also get familiar with the menu code, starting at the
MainMenu class. It currently has a lot of public fields and other ugly
code. You should develop a cleanup plan for both the source code and the
the visual menu. Feel free to use object-oriented approaches. The new
menu should be compatible to the old API as good as possible, since all
JOSM plugins depend on it and we don't want to break them all. You can
use the adapter pattern for this, so don't worry too much about it.

Michael

Am 07.03.2017 um 19:17 schrieb Nathiesha Maddage:
> Hi Michael,
> 
> Thanks for the quick reply. 
> 
> I am Nathiesha Maddage, a final year undergraduate at University of
> Moratuwa, Sri Lanka. I participated in GSoC 2016 as well and completed
> the project successfully, by developing an Eclipse plugin.
> 
> I was interested in OSM, since I was doing my final year University
> project on visualizing the land use with OSM data and Google satellite
> images. I went through the project list and I am interested in the JOSM
> project , new main menu. I am familiar with Java and I am getting
> familiarized with JOSM.
> 
> I compiled the source code using Eclipse. I will go through it to get a
> basic understanding about the code and the project structure. And I will
> use the JOSM mailing list and bug tracker, as you have suggested, if I
> find any question regarding the code. 
> 
> Is there any other resources that I should follow in the meantime, that
> would be useful for this project?
> 
> Github -https://github.com/nathiesha
> LinkedIn - https://www.linkedin.com/in/nathiesha-maddage-48710096/
> 
> 
> 
> On Tue, Mar 7, 2017 at 11:24 PM, Michael Zangl
>  > wrote:
> 
> Hi,
> 
> I am the one who proposed that project.
> 
> Getting your own compiled version of JOSM is a good starting point.
> 
> You can experiment with the github repository. It has not been updated
> since January, but this should be no problem since there were only minor
> changes since then. It is just a read-only mirror of the SVN repository.
> 
> For detailed questions about the code, JOSM has a own mailing list:
> https://lists.openstreetmap.org/listinfo/josm-dev
> 
> But we tend to use the bug tracker more, so you can simply comment on
> that ticket.
> 
> If you have any further questions about the project, I'm always open to
> a chat session ;-).
> 
> Michael
> 
> Am 07.03.2017 um 18:14 schrieb Nathiesha Maddage:
> > Hi all,
> >
> > I downloaded the JOSM source code from the git hub repository [1]
> > because I am more familiar with git than svn. Is that OK, or should I
> > download the source code from the SVN repository, as git repository is
> > listed as unofficial in the website [2]?
> >
> > [1]. https://github.com/openstreetmap/josm
> 
> > [2]. https://josm.openstreetmap.de/wiki/Source%20code
> 
> >
> > --
> > Best Regards,
> > *Nathiesha Maddage*
> > Undergraduate,*
> > *
> > Department of Computer Science & Engineering,
> > Faculty of Engineering,
> > University of Moraduwa,
> > Sri Lanka.
> >
> >
> >
> > ___
> > dev mailing list
> > dev@openstreetmap.org 
> > https://lists.openstreetmap.org/listinfo/dev
> 
> >
> 
> 
> ___
> dev mailing list
> dev@openstreetmap.org 
> https://lists.openstreetmap.org/listinfo/dev
> 
> 
> 
> 
> 
> -- 
> Best Regards,
> *Nathiesha Maddage*
> Undergraduate,*
> *
> Department of Computer Science & Engineering,
> Faculty of Engineering,
> University of Moraduwa,
> Sri Lanka.
> 


___
dev mailing list
dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/dev

Re: [OSM-dev] GSoC 17 : JOSM- New main menu

[Nathiesha Maddage]

Hi Michael,

Thanks for the quick reply.

I am Nathiesha Maddage, a final year undergraduate at University of
Moratuwa, Sri Lanka. I participated in GSoC 2016 as well and completed the
project successfully, by developing an Eclipse plugin.

I was interested in OSM, since I was doing my final year University project
on visualizing the land use with OSM data and Google satellite images. I
went through the project list and I am interested in the JOSM project , new
main menu. I am familiar with Java and I am getting familiarized with JOSM.

I compiled the source code using Eclipse. I will go through it to get a
basic understanding about the code and the project structure. And I will
use the JOSM mailing list and bug tracker, as you have suggested, if I find
any question regarding the code.

Is there any other resources that I should follow in the meantime, that
would be useful for this project?

Github -https://github.com/nathiesha
LinkedIn - https://www.linkedin.com/in/nathiesha-maddage-48710096/


On Tue, Mar 7, 2017 at 11:24 PM, Michael Zangl <
openstreet...@michael.fam-zangl.net> wrote:

> Hi,
>
> I am the one who proposed that project.
>
> Getting your own compiled version of JOSM is a good starting point.
>
> You can experiment with the github repository. It has not been updated
> since January, but this should be no problem since there were only minor
> changes since then. It is just a read-only mirror of the SVN repository.
>
> For detailed questions about the code, JOSM has a own mailing list:
> https://lists.openstreetmap.org/listinfo/josm-dev
> But we tend to use the bug tracker more, so you can simply comment on
> that ticket.
>
> If you have any further questions about the project, I'm always open to
> a chat session ;-).
>
> Michael
>
> Am 07.03.2017 um 18:14 schrieb Nathiesha Maddage:
> > Hi all,
> >
> > I downloaded the JOSM source code from the git hub repository [1]
> > because I am more familiar with git than svn. Is that OK, or should I
> > download the source code from the SVN repository, as git repository is
> > listed as unofficial in the website [2]?
> >
> > [1]. https://github.com/openstreetmap/josm
> > [2]. https://josm.openstreetmap.de/wiki/Source%20code
> >
> > --
> > Best Regards,
> > *Nathiesha Maddage*
> > Undergraduate,*
> > *
> > Department of Computer Science & Engineering,
> > Faculty of Engineering,
> > University of Moraduwa,
> > Sri Lanka.
> >
> >
> >
> > ___
> > dev mailing list
> > dev@openstreetmap.org
> > https://lists.openstreetmap.org/listinfo/dev
> >
>
>
> ___
> dev mailing list
> dev@openstreetmap.org
> https://lists.openstreetmap.org/listinfo/dev
>



-- 
Best Regards,
*Nathiesha Maddage*
Undergraduate,
Department of Computer Science & Engineering,
Faculty of Engineering,
University of Moraduwa,
Sri Lanka.
___
dev mailing list
dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/dev

Re: [OSM-dev] GSoC 17 : JOSM- New main menu

[Michael Zangl]

Hi,

I am the one who proposed that project.

Getting your own compiled version of JOSM is a good starting point.

You can experiment with the github repository. It has not been updated
since January, but this should be no problem since there were only minor
changes since then. It is just a read-only mirror of the SVN repository.

For detailed questions about the code, JOSM has a own mailing list:
https://lists.openstreetmap.org/listinfo/josm-dev
But we tend to use the bug tracker more, so you can simply comment on
that ticket.

If you have any further questions about the project, I'm always open to
a chat session ;-).

Michael

Am 07.03.2017 um 18:14 schrieb Nathiesha Maddage:
> Hi all,
> 
> I downloaded the JOSM source code from the git hub repository [1]
> because I am more familiar with git than svn. Is that OK, or should I
> download the source code from the SVN repository, as git repository is
> listed as unofficial in the website [2]?
> 
> [1]. https://github.com/openstreetmap/josm
> [2]. https://josm.openstreetmap.de/wiki/Source%20code
> 
> -- 
> Best Regards,
> *Nathiesha Maddage*
> Undergraduate,*
> *
> Department of Computer Science & Engineering,
> Faculty of Engineering,
> University of Moraduwa,
> Sri Lanka.
> 
> 
> 
> ___
> dev mailing list
> dev@openstreetmap.org
> https://lists.openstreetmap.org/listinfo/dev
> 


___
dev mailing list
dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/dev

[OSM-dev] GSoC 17 : JOSM- New main menu

[Nathiesha Maddage]

Hi all,

I downloaded the JOSM source code from the git hub repository [1] because I
am more familiar with git than svn. Is that OK, or should I download the
source code from the SVN repository, as git repository is listed as
unofficial in the website [2]?

[1]. https://github.com/openstreetmap/josm
[2]. https://josm.openstreetmap.de/wiki/Source%20code

-- 
Best Regards,
*Nathiesha Maddage*
Undergraduate,
Department of Computer Science & Engineering,
Faculty of Engineering,
University of Moraduwa,
Sri Lanka.
___
dev mailing list
dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/dev

[OSM-dev] GSoC 17 : JOSM: New main menu

[Nathiesha Maddage]

Hi all,

I am Nathiesha Maddage, a final year undergraduate at University of
Moratuwa, Sri Lanka. I participated in GSoC 2016 as well and completed the
project successfully, by developing an Eclipse plugin.

I was interested in OSM, since I was doing my final year University project
on visualizing the land use with OSM data and Google satellite images. I
went through the project list and I am interested in the JOSM project , new
main menu. I am familiar with Java and I am getting familiarized with JOSM.

Since I am new to the community and I would appreciate if any guidance is
given to me regarding the resources I should follow.

Github -https://github.com/nathiesha
LinkedIn - https://www.linkedin.com/in/nathiesha-maddage-48710096/

Best Regards
Nathiesha Maddage
___
dev mailing list
dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/dev