Re: [Potlatch-dev] How about another build?
On Tue, Dec 28, 2010 at 1:30 PM, Steve Bennett stevag...@gmail.com wrote: Just checking before I implement this* and then find out there was another reason that I missed. Ah, I've just done this a different way, and then read your email. Ho-hum! Also, what is the thinking around the text part of the icon element? It seems a bit under-developed. Perhaps a more explicit description element which explains what the entity represents (eg, text from the wiki), and a title or something which uses string substitution to summarise the entity? There's already a description element for the feature, see e.g. stream. I'm currently working on exposing this in the UI but I don't think it's actually used anywhere at the moment. Cheers, Andy ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] How about another build?
On Tue, Feb 15, 2011 at 10:36 PM, Andy Allan gravityst...@gmail.com wrote: Ah, I've just done this a different way, and then read your email. Ho-hum! Interesting - I'd totally forgotten about my above suggestion. I actually implemented something extremely similar to your implementation (http://trac.openstreetmap.org/changeset/25309) but didn't get around to checking it in. Cool. :) Steve ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] How about another build?
Ok, done. Btw, I notice a lot of pairs of features like this: feature name=Slipway line/ ... /feature feature name=Slipway point / ... /feature I guess the goal here is to have different icons for nodes vs areas? If so, would it be a better idea to allow something like: feature name=Slipway icon point=yes image=features/pois/boat-launch-24.png/ icon line=yes image=features/waterway__slipway.png / point / line / ... /feature Just checking before I implement this* and then find out there was another reason that I missed. Also, what is the thinking around the text part of the icon element? It seems a bit under-developed. Perhaps a more explicit description element which explains what the entity represents (eg, text from the wiki), and a title or something which uses string substitution to summarise the entity? Steve * Not a promise. On Sun, Dec 26, 2010 at 11:19 AM, Steve Bennett stevag...@gmail.com wrote: On Fri, Dec 24, 2010 at 9:15 PM, Richard Fairhurst rich...@systemed.net wrote: Have you had any thoughts about supplying icons for the new amenities? I don't think we can make something live with rows upon rows of ? ? ? ? ? ? ? ? ? ?. (Brian's SJJB set is usually the best place to look.) As you can see from my terrible power=* icons, graphic design is not really my strength :) Perhaps we could consider getting a more attractive default icon? Will have a look at SJJB though. Steve ___ Potlatch-dev mailing list potlatch-...@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] How about another build?
Steve Bennett wrote: Cool, I see we are out of the anything goes alpha phase then? :) Definitely... thousands of people are using this to edit the map; we have to be careful what we commit! Have you had any thoughts about supplying icons for the new amenities? I don't think we can make something live with rows upon rows of ? ? ? ? ? ? ? ? ? ?. (Brian's SJJB set is usually the best place to look.) cheers Richard ___ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
Re: [Potlatch-dev] How about another build?
On Wed, Dec 22, 2010 at 11:05 AM, Richard Fairhurst rich...@systemed.net wrote: Steve Bennett wrote: Could we please have the live PL2 rebuilt? I fixed a pretty annoying bug which prevented some imagery tiles ever being displayed. I think I'd like to review recent commits before the next deployment, if that's ok. With it being Christmas time is a bit short but I'll take a look when I can. It's great to see so many bugfixes coming in. But Steve, can you avoid hiding bug fixes in amongst other things, please? You're even referring to the issue in your commit messages, c.f. In amongst all that there are two lines of code that fix the bug: Fixed a bug [...] also, a bunch of random doco It's really hard to figure out what changes are being made - and to review them, too - when they keep getting buried like this. Just do more of what you're doing, but split into multiple commits so the bugfixes are nice and easy to see! Cheers, Andy P.S. For people used to git, I can totally recommend git-svn for working with potlatch2, much easier to stage files for committing, git add -i etc. ___ Potlatch-dev mailing list potlatch-...@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev
