[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442180#comment-16442180
]
ASF GitHub Bot commented on PARQUET-1179:
-
xhochy commented on issue #433: PARQUET-1179: Upgrade to Thrift 0.11, use
std::shared_ptr instead of boost::shared_ptr
URL: https://github.com/apache/parquet-cpp/pull/433#issuecomment-382324782
@thamht4190 You need to do `export PATH=/usr/local/opt/bison/bin:$PATH` and
then a fresh build to get rid of the error. Alternatively install Thrift via
homebrew or conda and use that instead of the one that is built by parquet-cpp.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
>Assignee: Wes McKinney
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(tmem_transport);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
> std::__1::shared_ptr &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to
> 'std::__1::shared_ptr &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
>^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr getProtocol(stdcxx::shared_ptr
> trans) {
>^
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
>
[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442042#comment-16442042
]
ASF GitHub Bot commented on PARQUET-1179:
-
thamht4190 commented on issue #433: PARQUET-1179: Upgrade to Thrift 0.11, use
std::shared_ptr instead of boost::shared_ptr
URL: https://github.com/apache/parquet-cpp/pull/433#issuecomment-382291072
I tried check `bison --version`, oh, it show bison 2.3. Then I found [this
article on
stackoverflow](https://stackoverflow.com/questions/10778905/why-not-gnu-bison-upgrade-to-2-5-on-macosx-10-7-3/30844621#30844621).
It generates another errors but it passed bison issue ;)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
>Assignee: Wes McKinney
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(tmem_transport);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
> std::__1::shared_ptr &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to
> 'std::__1::shared_ptr &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
>^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr getProtocol(stdcxx::shared_ptr
> trans) {
>^
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442043#comment-16442043
]
ASF GitHub Bot commented on PARQUET-1179:
-
thamht4190 commented on issue #433: PARQUET-1179: Upgrade to Thrift 0.11, use
std::shared_ptr instead of boost::shared_ptr
URL: https://github.com/apache/parquet-cpp/pull/433#issuecomment-382291072
I tried check `bison --version`, oh, it showed bison version 2.3. Then I
found [this article on
stackoverflow](https://stackoverflow.com/questions/10778905/why-not-gnu-bison-upgrade-to-2-5-on-macosx-10-7-3/30844621#30844621).
It generates another errors but it passed bison issue ;)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
>Assignee: Wes McKinney
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(tmem_transport);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
> std::__1::shared_ptr &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to
> 'std::__1::shared_ptr &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
>^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr getProtocol(stdcxx::shared_ptr
> trans) {
>^
> In file included from
>
[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441991#comment-16441991
]
ASF GitHub Bot commented on PARQUET-1179:
-
thamht4190 commented on issue #433: PARQUET-1179: Upgrade to Thrift 0.11, use
std::shared_ptr instead of boost::shared_ptr
URL: https://github.com/apache/parquet-cpp/pull/433#issuecomment-382281162
I still get an issue on MacOS while the latest bison is installed:
```
/Users/dev/tham/cortex-v2/src/ThirdParty/parquet-cpp/build/thrift_ep-prefix/src/thrift_ep/compiler/cpp/src/thrift/thrifty.yy:1.1-5:
invalid directive: `%code'
/Users/dev/tham/cortex-v2/src/ThirdParty/parquet-cpp/build/thrift_ep-prefix/src/thrift_ep/compiler/cpp/src/thrift/thrifty.yy:1.7-14:
syntax error, unexpected identifier
```
Here are the version of bison:
```
Mac-CoreTeam:ThirdParty dev$ brew upgrade bison
Error: bison 3.0.4_1 already installed
```
Do you have any idea? Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
>Assignee: Wes McKinney
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(tmem_transport);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
> std::__1::shared_ptr &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to
> 'std::__1::shared_ptr &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
>^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
>
[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441990#comment-16441990
]
ASF GitHub Bot commented on PARQUET-1179:
-
thamht4190 commented on issue #433: PARQUET-1179: Upgrade to Thrift 0.11, use
std::shared_ptr instead of boost::shared_ptr
URL: https://github.com/apache/parquet-cpp/pull/433#issuecomment-382281162
I still get an issue on MacOS while the latest bison is installed
`
/Users/dev/tham/cortex-v2/src/ThirdParty/parquet-cpp/build/thrift_ep-prefix/src/thrift_ep/compiler/cpp/src/thrift/thrifty.yy:1.1-5:
invalid directive: `%code'
/Users/dev/tham/cortex-v2/src/ThirdParty/parquet-cpp/build/thrift_ep-prefix/src/thrift_ep/compiler/cpp/src/thrift/thrifty.yy:1.7-14:
syntax error, unexpected identifier
`
Here are the version of bison:
`
Mac-CoreTeam:ThirdParty dev$ brew upgrade bison
Error: bison 3.0.4_1 already installed
`
Do you have any idea? Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
>Assignee: Wes McKinney
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(tmem_transport);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
> std::__1::shared_ptr &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to
> 'std::__1::shared_ptr &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
>^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
>
[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441989#comment-16441989
]
ASF GitHub Bot commented on PARQUET-1179:
-
thamht4190 commented on issue #433: PARQUET-1179: Upgrade to Thrift 0.11, use
std::shared_ptr instead of boost::shared_ptr
URL: https://github.com/apache/parquet-cpp/pull/433#issuecomment-382281162
I still get an issue on MacOS while the latest bison is installed
`
/Users/dev/tham/cortex-v2/src/ThirdParty/parquet-cpp/build/thrift_ep-prefix/src/thrift_ep/compiler/cpp/src/thrift/thrifty.yy:1.1-5:
invalid directive: `%code'
/Users/dev/tham/cortex-v2/src/ThirdParty/parquet-cpp/build/thrift_ep-prefix/src/thrift_ep/compiler/cpp/src/thrift/thrifty.yy:1.7-14:
syntax error, unexpected identifier
`
`
Mac-CoreTeam:ThirdParty dev$ brew upgrade bison
Error: bison 3.0.4_1 already installed
`
Do you have any idea? Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
>Assignee: Wes McKinney
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(tmem_transport);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
> std::__1::shared_ptr &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to
> 'std::__1::shared_ptr &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
>^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note:
[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441988#comment-16441988
]
ASF GitHub Bot commented on PARQUET-1179:
-
thamht4190 commented on issue #433: PARQUET-1179: Upgrade to Thrift 0.11, use
std::shared_ptr instead of boost::shared_ptr
URL: https://github.com/apache/parquet-cpp/pull/433#issuecomment-382281162
I still get an issue after install the latest bison
`
/Users/dev/tham/cortex-v2/src/ThirdParty/parquet-cpp/build/thrift_ep-prefix/src/thrift_ep/compiler/cpp/src/thrift/thrifty.yy:1.1-5:
invalid directive: `%code'
/Users/dev/tham/cortex-v2/src/ThirdParty/parquet-cpp/build/thrift_ep-prefix/src/thrift_ep/compiler/cpp/src/thrift/thrifty.yy:1.7-14:
syntax error, unexpected identifier
`
`
Mac-CoreTeam:ThirdParty dev$ brew upgrade bison
Error: bison 3.0.4_1 already installed
`
Do you have any idea? Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
>Assignee: Wes McKinney
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(tmem_transport);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
> std::__1::shared_ptr &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to
> 'std::__1::shared_ptr &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
>^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument
[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342586#comment-16342586
]
ASF GitHub Bot commented on PARQUET-1179:
-
xhochy closed pull request #433: PARQUET-1179: Upgrade to Thrift 0.11, use
std::shared_ptr instead of boost::shared_ptr
URL: https://github.com/apache/parquet-cpp/pull/433
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ci/before_script_travis.sh b/ci/before_script_travis.sh
index 4251ee5f..95a2fd82 100755
--- a/ci/before_script_travis.sh
+++ b/ci/before_script_travis.sh
@@ -16,8 +16,10 @@ if [ $TRAVIS_OS_NAME == "osx" ]; then
brew update > /dev/null
brew install boost
brew install openssl
+ brew install bison
export OPENSSL_ROOT_DIR=/usr/local/opt/openssl
export LD_LIBRARY_PATH=/usr/local/opt/openssl/lib:$LD_LIBRARY_PATH
+ export PATH="/usr/local/opt/bison/bin:$PATH"
else
# Use a C++11 compiler on Linux
export CC="gcc-4.9"
diff --git a/ci/msvc-build.bat b/ci/msvc-build.bat
index 29d8b839..46d4aeac 100644
--- a/ci/msvc-build.bat
+++ b/ci/msvc-build.bat
@@ -28,7 +28,7 @@ if NOT "%CONFIGURATION%" == "Debug" (
)
if "%CONFIGURATION%" == "Toolchain" (
- conda install -y boost-cpp=1.63 thrift-cpp=0.10.0 ^
+ conda install -y boost-cpp=1.63 thrift-cpp=0.11.0 ^
brotli=0.6.0 zlib=1.2.11 snappy=1.1.6 lz4-c=1.7.5 zstd=1.2.0 ^
-c conda-forge
diff --git a/cmake_modules/ThirdpartyToolchain.cmake
b/cmake_modules/ThirdpartyToolchain.cmake
index 52ab7a8d..2ea76860 100644
--- a/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cmake_modules/ThirdpartyToolchain.cmake
@@ -17,7 +17,7 @@
set(GTEST_VERSION "1.8.0")
set(GBENCHMARK_VERSION "1.1.0")
-set(THRIFT_VERSION "0.10.0")
+set(THRIFT_VERSION "0.11.0")
string(TOUPPER ${CMAKE_BUILD_TYPE} UPPERCASE_BUILD_TYPE)
diff --git a/src/parquet/thrift.h b/src/parquet/thrift.h
index 7a23e417..d2915a94 100644
--- a/src/parquet/thrift.h
+++ b/src/parquet/thrift.h
@@ -19,9 +19,7 @@
#define PARQUET_THRIFT_UTIL_H
#include
-
-// Needed for thrift
-#include
+#include
// TCompactProtocol requires some #defines to work right.
#define SIGNED_RIGHT_SHIFT_IS 1
@@ -96,12 +94,12 @@ static inline format::CompressionCodec::type
ToThrift(Compression::type type) {
template
inline void DeserializeThriftMsg(const uint8_t* buf, uint32_t* len, T*
deserialized_msg) {
// Deserialize msg bytes into c++ thrift msg using memory transport.
- boost::shared_ptr tmem_transport(
+ std::shared_ptr tmem_transport(
new apache::thrift::transport::TMemoryBuffer(const_cast(buf),
*len));
apache::thrift::protocol::TCompactProtocolFactoryT<
apache::thrift::transport::TMemoryBuffer>
tproto_factory;
- boost::shared_ptr tproto =
+ std::shared_ptr tproto =
tproto_factory.getProtocol(tmem_transport);
try {
deserialized_msg->read(tproto.get());
@@ -119,12 +117,12 @@ inline void DeserializeThriftMsg(const uint8_t* buf,
uint32_t* len, T* deseriali
// the expected size of the serialized object
template
inline int64_t SerializeThriftMsg(T* obj, uint32_t len, OutputStream* out) {
- boost::shared_ptr mem_buffer(
+ std::shared_ptr mem_buffer(
new apache::thrift::transport::TMemoryBuffer(len));
apache::thrift::protocol::TCompactProtocolFactoryT<
apache::thrift::transport::TMemoryBuffer>
tproto_factory;
- boost::shared_ptr tproto =
+ std::shared_ptr tproto =
tproto_factory.getProtocol(mem_buffer);
try {
mem_buffer->resetBuffer();
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
>Assignee: Wes McKinney
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
>
[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341086#comment-16341086
]
ASF GitHub Bot commented on PARQUET-1179:
-
xhochy commented on issue #433: PARQUET-1179: Upgrade to Thrift 0.11, use
std::shared_ptr instead of boost::shared_ptr
URL: https://github.com/apache/parquet-cpp/pull/433#issuecomment-360792171
Build still fails
https://ci.appveyor.com/project/wesm/parquet-cpp/build/job/6ct7coqbty6pxd6u as
thrift-cpp did not yet drop in conda-forge for Windows.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
>Assignee: Wes McKinney
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(tmem_transport);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
> std::__1::shared_ptr &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to
> 'std::__1::shared_ptr &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
>^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr getProtocol(stdcxx::shared_ptr
> trans) {
>^
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:128:34: error:
> no viable conversion from
>
[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338558#comment-16338558
]
ASF GitHub Bot commented on PARQUET-1179:
-
wesm commented on issue #433: PARQUET-1179: Upgrade to Thrift 0.11, use
std::shared_ptr instead of boost::shared_ptr
URL: https://github.com/apache/parquet-cpp/pull/433#issuecomment-360331620
We can merge on conda-forge first. We may need to pin thrift-cpp in Arrow
until this gets in
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
>Assignee: Wes McKinney
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(tmem_transport);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
> std::__1::shared_ptr &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to
> 'std::__1::shared_ptr &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
>^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr getProtocol(stdcxx::shared_ptr
> trans) {
>^
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:128:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
>
[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338225#comment-16338225
]
ASF GitHub Bot commented on PARQUET-1179:
-
xhochy commented on issue #433: PARQUET-1179: Upgrade to Thrift 0.11, use
std::shared_ptr instead of boost::shared_ptr
URL: https://github.com/apache/parquet-cpp/pull/433#issuecomment-360274528
The bison issue should be fixable by installing a bison version using `brew`
and adding `/user/local/opt/bison/bin` to the PATH. Other people seem to have
the same issue: https://github.com/argvk/jsonxx/issues/1#issuecomment-37492928
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
>Assignee: Wes McKinney
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(tmem_transport);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
> std::__1::shared_ptr &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to
> 'std::__1::shared_ptr &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
>^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr getProtocol(stdcxx::shared_ptr
> trans) {
>^
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
>
[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338221#comment-16338221
]
ASF GitHub Bot commented on PARQUET-1179:
-
xhochy commented on issue #433: PARQUET-1179: Upgrade to Thrift 0.11, use
std::shared_ptr instead of boost::shared_ptr
URL: https://github.com/apache/parquet-cpp/pull/433#issuecomment-360273893
@wesm Do we want to first merge on `conda-forge` or here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
>Assignee: Wes McKinney
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(tmem_transport);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
> std::__1::shared_ptr &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to
> 'std::__1::shared_ptr &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
>^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr getProtocol(stdcxx::shared_ptr
> trans) {
>^
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:128:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(mem_buffer);
>
[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337838#comment-16337838
]
ASF GitHub Bot commented on PARQUET-1179:
-
wesm commented on issue #433: PARQUET-1179: Upgrade to Thrift 0.11, use
std::shared_ptr instead of boost::shared_ptr
URL: https://github.com/apache/parquet-cpp/pull/433#issuecomment-360186802
The macOS build is failing due to a Bison issue, and the toolchain builds
fail because conda-forge hasn't upgraded to 0.11 yet
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
>Assignee: Wes McKinney
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(tmem_transport);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
> std::__1::shared_ptr &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to
> 'std::__1::shared_ptr &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
>^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr getProtocol(stdcxx::shared_ptr
> trans) {
>^
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:128:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
>
[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335202#comment-16335202
]
Wes McKinney commented on PARQUET-1179:
---
PR: [https://github.com/apache/parquet-cpp/pull/433]
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
>Assignee: Wes McKinney
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(tmem_transport);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
> std::__1::shared_ptr &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to
> 'std::__1::shared_ptr &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
>^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr getProtocol(stdcxx::shared_ptr
> trans) {
>^
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:128:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(mem_buffer);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known
[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308182#comment-16308182
]
Wes McKinney commented on PARQUET-1179:
---
Can you show the entire build log when running CMake? Thanks!
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(tmem_transport);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
> std::__1::shared_ptr &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to
> 'std::__1::shared_ptr &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
>^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr getProtocol(stdcxx::shared_ptr
> trans) {
>^
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:128:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(mem_buffer);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
>
[jira] [Commented] (PARQUET-1179) [C++] Support Apache Thrift 0.11
[
https://issues.apache.org/jira/browse/PARQUET-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308163#comment-16308163
]
Stephen Carman commented on PARQUET-1179:
-
[~wesmckinn] I'm not trying to do anything, this is just a straight checkout
and build. I don't have thrift libs installed already on my machine.
> [C++] Support Apache Thrift 0.11
>
>
> Key: PARQUET-1179
> URL: https://issues.apache.org/jira/browse/PARQUET-1179
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Environment: OSX 10.13.2
> Apple Clang
> {code:java}
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
> Target: x86_64-apple-darwin17.3.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
> {code}
>Reporter: Stephen Carman
> Fix For: cpp-1.4.0
>
>
> I am not sure if this is an OSX specific issue or something with a new
> version of Boost, but parquet does not seem to build with the current setup.
> {code:java}
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:105:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(tmem_transport);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'const
> std::__1::shared_ptr &' for 1st
> argument
> shared_ptr(const shared_ptr& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3922:5:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to
> 'std::__1::shared_ptr &&' for 1st
> argument
> shared_ptr(shared_ptr&& __r) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3917:9:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> shared_ptr(const shared_ptr<_Yp>& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3923:52:
> note: candidate template ignored: could not match 'std::__1::shared_ptr'
> against 'boost::shared_ptr'
> template _LIBCPP_INLINE_VISIBILITY
> shared_ptr(shared_ptr<_Yp>&& __r,
>^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3931:9:
> note: candidate template ignored: could not match 'auto_ptr' against
> 'shared_ptr'
> shared_ptr(auto_ptr<_Yp>&& __r,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3940:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3949:9:
> note: candidate template ignored: could not match 'unique_ptr' against
> 'shared_ptr'
> shared_ptr(unique_ptr<_Yp, _Dp>&&,
> ^
> /usr/local/include/thrift/protocol/TCompactProtocol.h:242:76: note: passing
> argument to parameter 'trans' here
> stdcxx::shared_ptr getProtocol(stdcxx::shared_ptr
> trans) {
>^
> In file included from
> /Users/steve_carman/software/parquet-cpp/src/parquet/schema.cc:28:
> /Users/steve_carman/software/parquet-cpp/src/parquet/thrift.h:128:34: error:
> no viable conversion from
> 'boost::shared_ptr' to
> 'stdcxx::shared_ptr'
> tproto_factory.getProtocol(mem_buffer);
> ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3900:23:
> note: candidate constructor not viable: no known conversion from
> 'boost::shared_ptr' to 'nullptr_t'
> for 1st argument
> _LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
> ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3914:5:
> note: candidate
