[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[
https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371793#comment-16371793
]
ASF GitHub Bot commented on PARQUET-1233:
-
wesm closed pull request #443: PARQUET-1233: Enable option to switch between
stl classes and boost c…
URL: https://github.com/apache/parquet-cpp/pull/443
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/CMakeLists.txt b/CMakeLists.txt
index bca8478c..304f3fb3 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -151,6 +151,11 @@ if ("${CMAKE_SOURCE_DIR}" STREQUAL
"${CMAKE_CURRENT_SOURCE_DIR}")
option(PARQUET_MINIMAL_DEPENDENCY
"Depend only on Thirdparty headers to build libparquet. Always OFF if
building binaries"
OFF)
+
+ option(PARQUET_THRIFT_USE_BOOST
+"Enable if Thirdparty Thrift uses boost::shared_ptr (Apache Thrift < 0.11)"
+OFF)
+
if (MSVC)
set(ARROW_MSVC_STATIC_LIB_SUFFIX "_static" CACHE STRING
"Arrow static lib suffix used on Windows with MSVC (default _static)")
diff --git a/ci/travis_script_static.sh b/ci/travis_script_static.sh
index 6da7a334..b76ced8f 100755
--- a/ci/travis_script_static.sh
+++ b/ci/travis_script_static.sh
@@ -40,7 +40,7 @@ conda config --set remote_connect_timeout_secs 12
conda info -a
conda create -y -q -p $CPP_TOOLCHAIN \
- boost-cpp thrift-cpp cmake git \
+ boost-cpp thrift-cpp=0.10.0 cmake git \
-c conda-forge
source activate $CPP_TOOLCHAIN
@@ -70,6 +70,7 @@ cmake -DPARQUET_CXXFLAGS="$PARQUET_CXXFLAGS" \
-DPARQUET_ARROW_LINKAGE="static" \
-DPARQUET_BUILD_SHARED=OFF \
-DPARQUET_BOOST_USE_SHARED=OFF \
+ -DPARQUET_THRIFT_USE_BOOST=ON \
-DPARQUET_BUILD_BENCHMARKS=ON \
-DPARQUET_BUILD_EXAMPLES=ON \
-DPARQUET_GENERATE_COVERAGE=1 \
diff --git a/ci/travis_script_toolchain.sh b/ci/travis_script_toolchain.sh
index 7db96581..036ab3c2 100755
--- a/ci/travis_script_toolchain.sh
+++ b/ci/travis_script_toolchain.sh
@@ -40,7 +40,7 @@ conda config --set remote_connect_timeout_secs 12
conda info -a
conda create -y -q -p $CPP_TOOLCHAIN \
- boost-cpp thrift-cpp cmake git \
+ boost-cpp thrift-cpp=0.11.0 cmake git \
-c conda-forge
# --
diff --git a/cmake_modules/ThirdpartyToolchain.cmake
b/cmake_modules/ThirdpartyToolchain.cmake
index 3c197dd6..690fd0b6 100644
--- a/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cmake_modules/ThirdpartyToolchain.cmake
@@ -17,7 +17,7 @@
set(GTEST_VERSION "1.8.0")
set(GBENCHMARK_VERSION "1.1.0")
-set(THRIFT_VERSION "0.11.0")
+set(THRIFT_VENDOR_VERSION "0.11.0")
string(TOUPPER ${CMAKE_BUILD_TYPE} UPPERCASE_BUILD_TYPE)
@@ -244,7 +244,7 @@ if (NOT THRIFT_FOUND)
endif()
ExternalProject_Add(thrift_ep
-URL
"http://archive.apache.org/dist/thrift/${THRIFT_VERSION}/thrift-${THRIFT_VERSION}.tar.gz;
+URL
"http://archive.apache.org/dist/thrift/${THRIFT_VENDOR_VERSION}/thrift-${THRIFT_VENDOR_VERSION}.tar.gz;
BUILD_BYPRODUCTS "${THRIFT_STATIC_LIB}" "${THRIFT_COMPILER}"
CMAKE_ARGS ${THRIFT_CMAKE_ARGS}
DEPENDS ${THRIFT_DEPENDENCIES}
@@ -259,6 +259,7 @@ include_directories(SYSTEM ${THRIFT_INCLUDE_DIR}
${THRIFT_INCLUDE_DIR}/thrift)
message(STATUS "Thrift include dir: ${THRIFT_INCLUDE_DIR}")
message(STATUS "Thrift static library: ${THRIFT_STATIC_LIB}")
message(STATUS "Thrift compiler: ${THRIFT_COMPILER}")
+message(STATUS "Thrift version: ${THRIFT_VERSION}")
add_library(thriftstatic STATIC IMPORTED)
set_target_properties(thriftstatic PROPERTIES IMPORTED_LOCATION
${THRIFT_STATIC_LIB})
@@ -266,6 +267,11 @@ if (THRIFT_VENDORED)
add_dependencies(thriftstatic thrift_ep)
endif()
+if (PARQUET_THRIFT_USE_BOOST)
+ add_definitions(-DPARQUET_THRIFT_USE_BOOST)
+ message(STATUS "Using Boost in Thrift header")
+endif()
+
## GTest
if(PARQUET_BUILD_TESTS AND NOT IGNORE_OPTIONAL_PACKAGES)
add_custom_target(unittest ctest -L unittest)
diff --git a/src/parquet/thrift.h b/src/parquet/thrift.h
index d2915a94..ec7ac906 100644
--- a/src/parquet/thrift.h
+++ b/src/parquet/thrift.h
@@ -19,7 +19,13 @@
#define PARQUET_THRIFT_UTIL_H
#include
+// Check if thrift version < 0.11.0
+// or if FORCE_BOOST_SMART_PTR is defined. Ref:
https://thrift.apache.org/lib/cpp
+#if defined(PARQUET_THRIFT_USE_BOOST) || defined(FORCE_BOOST_SMART_PTR)
+#include
+#else
#include
+#endif
// TCompactProtocol requires some #defines to work right.
#define SIGNED_RIGHT_SHIFT_IS 1
@@ -39,6 +45,14 @@
namespace parquet {
+// Check if thrift version < 0.11.0
+// or if FORCE_BOOST_SMART_PTR is defined. Ref:
https://thrift.apache.org/lib/cpp
+#if defined(PARQUET_THRIFT_USE_BOOST) ||
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[ https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371776#comment-16371776 ] ASF GitHub Bot commented on PARQUET-1233: - majetideepak commented on issue #443: PARQUET-1233: Enable option to switch between stl classes and boost c… URL: https://github.com/apache/parquet-cpp/pull/443#issuecomment-367417922 +1 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [CPP ]Enable option to switch between stl classes and boost classes for > thrift header > - > > Key: PARQUET-1233 > URL: https://issues.apache.org/jira/browse/PARQUET-1233 > Project: Parquet > Issue Type: Bug >Reporter: Deepak Majeti >Assignee: Deepak Majeti >Priority: Major > Fix For: cpp-1.4.0 > > > Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This > causes an issue with older thrift versions. The scope of this Jira is to > enable an option to choose between stl and boost in parquet thrift header. > https://thrift.apache.org/lib/cpp -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[ https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371762#comment-16371762 ] ASF GitHub Bot commented on PARQUET-1233: - wesm commented on issue #443: PARQUET-1233: Enable option to switch between stl classes and boost c… URL: https://github.com/apache/parquet-cpp/pull/443#issuecomment-367414331 @xhochy @majetideepak is this good to go? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [CPP ]Enable option to switch between stl classes and boost classes for > thrift header > - > > Key: PARQUET-1233 > URL: https://issues.apache.org/jira/browse/PARQUET-1233 > Project: Parquet > Issue Type: Bug >Reporter: Deepak Majeti >Assignee: Deepak Majeti >Priority: Major > Fix For: cpp-1.4.0 > > > Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This > causes an issue with older thrift versions. The scope of this Jira is to > enable an option to choose between stl and boost in parquet thrift header. > https://thrift.apache.org/lib/cpp -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[
https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371369#comment-16371369
]
ASF GitHub Bot commented on PARQUET-1233:
-
wesm commented on a change in pull request #443: PARQUET-1233: Enable option to
switch between stl classes and boost c…
URL: https://github.com/apache/parquet-cpp/pull/443#discussion_r169627833
##
File path: cmake_modules/ThirdpartyToolchain.cmake
##
@@ -259,13 +259,19 @@ include_directories(SYSTEM ${THRIFT_INCLUDE_DIR}
${THRIFT_INCLUDE_DIR}/thrift)
message(STATUS "Thrift include dir: ${THRIFT_INCLUDE_DIR}")
message(STATUS "Thrift static library: ${THRIFT_STATIC_LIB}")
message(STATUS "Thrift compiler: ${THRIFT_COMPILER}")
+message(STATUS "Thrift version: ${THRIFT_VERSION}")
Review comment:
No, this variable is set by `FindThrift.cmake`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [CPP ]Enable option to switch between stl classes and boost classes for
> thrift header
> -
>
> Key: PARQUET-1233
> URL: https://issues.apache.org/jira/browse/PARQUET-1233
> Project: Parquet
> Issue Type: Bug
>Reporter: Deepak Majeti
>Assignee: Deepak Majeti
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This
> causes an issue with older thrift versions. The scope of this Jira is to
> enable an option to choose between stl and boost in parquet thrift header.
> https://thrift.apache.org/lib/cpp
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[
https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371312#comment-16371312
]
ASF GitHub Bot commented on PARQUET-1233:
-
majetideepak commented on a change in pull request #443: PARQUET-1233: Enable
option to switch between stl classes and boost c…
URL: https://github.com/apache/parquet-cpp/pull/443#discussion_r169620628
##
File path: cmake_modules/ThirdpartyToolchain.cmake
##
@@ -259,13 +259,19 @@ include_directories(SYSTEM ${THRIFT_INCLUDE_DIR}
${THRIFT_INCLUDE_DIR}/thrift)
message(STATUS "Thrift include dir: ${THRIFT_INCLUDE_DIR}")
message(STATUS "Thrift static library: ${THRIFT_STATIC_LIB}")
message(STATUS "Thrift compiler: ${THRIFT_COMPILER}")
+message(STATUS "Thrift version: ${THRIFT_VERSION}")
Review comment:
Should this be `THRIFT_VENDOR_VERSION`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [CPP ]Enable option to switch between stl classes and boost classes for
> thrift header
> -
>
> Key: PARQUET-1233
> URL: https://issues.apache.org/jira/browse/PARQUET-1233
> Project: Parquet
> Issue Type: Bug
>Reporter: Deepak Majeti
>Assignee: Deepak Majeti
>Priority: Major
> Fix For: cpp-1.4.0
>
>
> Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This
> causes an issue with older thrift versions. The scope of this Jira is to
> enable an option to choose between stl and boost in parquet thrift header.
> https://thrift.apache.org/lib/cpp
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[ https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370854#comment-16370854 ] ASF GitHub Bot commented on PARQUET-1233: - wesm commented on issue #443: PARQUET-1233: Enable option to switch between stl classes and boost c… URL: https://github.com/apache/parquet-cpp/pull/443#issuecomment-367191067 This should be working now. I think having an explicit option to indicate that you're using the old Thrift API is the cleanest solution -- we could also regex out the version number from the output of `thrift --version` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [CPP ]Enable option to switch between stl classes and boost classes for > thrift header > - > > Key: PARQUET-1233 > URL: https://issues.apache.org/jira/browse/PARQUET-1233 > Project: Parquet > Issue Type: Bug >Reporter: Deepak Majeti >Assignee: Deepak Majeti >Priority: Major > Fix For: cpp-1.4.0 > > > Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This > causes an issue with older thrift versions. The scope of this Jira is to > enable an option to choose between stl and boost in parquet thrift header. > https://thrift.apache.org/lib/cpp -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[ https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370847#comment-16370847 ] ASF GitHub Bot commented on PARQUET-1233: - wesm commented on issue #443: PARQUET-1233: Enable option to switch between stl classes and boost c… URL: https://github.com/apache/parquet-cpp/pull/443#issuecomment-367188777 This is failing for me with thrift 0.11 in toolchain, I'm going to push a fix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [CPP ]Enable option to switch between stl classes and boost classes for > thrift header > - > > Key: PARQUET-1233 > URL: https://issues.apache.org/jira/browse/PARQUET-1233 > Project: Parquet > Issue Type: Bug >Reporter: Deepak Majeti >Assignee: Deepak Majeti >Priority: Major > Fix For: cpp-1.4.0 > > > Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This > causes an issue with older thrift versions. The scope of this Jira is to > enable an option to choose between stl and boost in parquet thrift header. > https://thrift.apache.org/lib/cpp -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[ https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370839#comment-16370839 ] ASF GitHub Bot commented on PARQUET-1233: - wesm commented on issue #443: PARQUET-1233: Enable option to switch between stl classes and boost c… URL: https://github.com/apache/parquet-cpp/pull/443#issuecomment-367186649 Let's make sure that this works with no extra build flags with Thrift 0.11 in the toolchain, since that's the current stable release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [CPP ]Enable option to switch between stl classes and boost classes for > thrift header > - > > Key: PARQUET-1233 > URL: https://issues.apache.org/jira/browse/PARQUET-1233 > Project: Parquet > Issue Type: Bug >Reporter: Deepak Majeti >Assignee: Deepak Majeti >Priority: Major > Fix For: cpp-1.4.0 > > > Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This > causes an issue with older thrift versions. The scope of this Jira is to > enable an option to choose between stl and boost in parquet thrift header. > https://thrift.apache.org/lib/cpp -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[ https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370414#comment-16370414 ] ASF GitHub Bot commented on PARQUET-1233: - majetideepak commented on a change in pull request #443: PARQUET-1233: Enable option to switch between stl classes and boost c… URL: https://github.com/apache/parquet-cpp/pull/443#discussion_r169414077 ## File path: CMakeLists.txt ## @@ -399,6 +399,11 @@ else() endif() include(ThirdpartyToolchain) +if (THRIFT_VERSION VERSION_LESS "0.11.0") Review comment: Ref: https://thrift.apache.org/lib/cpp This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [CPP ]Enable option to switch between stl classes and boost classes for > thrift header > - > > Key: PARQUET-1233 > URL: https://issues.apache.org/jira/browse/PARQUET-1233 > Project: Parquet > Issue Type: Bug >Reporter: Deepak Majeti >Assignee: Deepak Majeti >Priority: Major > Fix For: cpp-1.4.0 > > > Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This > causes an issue with older thrift versions. The scope of this Jira is to > enable an option to choose between stl and boost in parquet thrift header. > https://thrift.apache.org/lib/cpp -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[ https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370413#comment-16370413 ] ASF GitHub Bot commented on PARQUET-1233: - majetideepak commented on a change in pull request #443: PARQUET-1233: Enable option to switch between stl classes and boost c… URL: https://github.com/apache/parquet-cpp/pull/443#discussion_r169413993 ## File path: CMakeLists.txt ## @@ -399,6 +399,11 @@ else() endif() include(ThirdpartyToolchain) +if (THRIFT_VERSION VERSION_LESS "0.11.0") + add_definitions(-DPARQUET_THRIFT_USE_BOOST) + message(STATUS "Using Boost in Thrift header") +endif() Review comment: Ref: https://thrift.apache.org/lib/cpp This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [CPP ]Enable option to switch between stl classes and boost classes for > thrift header > - > > Key: PARQUET-1233 > URL: https://issues.apache.org/jira/browse/PARQUET-1233 > Project: Parquet > Issue Type: Bug >Reporter: Deepak Majeti >Assignee: Deepak Majeti >Priority: Major > Fix For: cpp-1.4.0 > > > Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This > causes an issue with older thrift versions. The scope of this Jira is to > enable an option to choose between stl and boost in parquet thrift header. > https://thrift.apache.org/lib/cpp -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[ https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370412#comment-16370412 ] ASF GitHub Bot commented on PARQUET-1233: - majetideepak commented on a change in pull request #443: PARQUET-1233: Enable option to switch between stl classes and boost c… URL: https://github.com/apache/parquet-cpp/pull/443#discussion_r169413993 ## File path: CMakeLists.txt ## @@ -399,6 +399,11 @@ else() endif() include(ThirdpartyToolchain) +if (THRIFT_VERSION VERSION_LESS "0.11.0") + add_definitions(-DPARQUET_THRIFT_USE_BOOST) + message(STATUS "Using Boost in Thrift header") +endif() Review comment: Ref: https://thrift.apache.org/lib/cpp This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [CPP ]Enable option to switch between stl classes and boost classes for > thrift header > - > > Key: PARQUET-1233 > URL: https://issues.apache.org/jira/browse/PARQUET-1233 > Project: Parquet > Issue Type: Bug >Reporter: Deepak Majeti >Assignee: Deepak Majeti >Priority: Major > Fix For: cpp-1.4.0 > > > Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This > causes an issue with older thrift versions. The scope of this Jira is to > enable an option to choose between stl and boost in parquet thrift header. > https://thrift.apache.org/lib/cpp -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[ https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370411#comment-16370411 ] ASF GitHub Bot commented on PARQUET-1233: - majetideepak commented on a change in pull request #443: PARQUET-1233: Enable option to switch between stl classes and boost c… URL: https://github.com/apache/parquet-cpp/pull/443#discussion_r169413745 ## File path: CMakeLists.txt ## @@ -399,6 +399,11 @@ else() endif() include(ThirdpartyToolchain) +if (THRIFT_VERSION VERSION_LESS "0.11.0") + add_definitions(-DPARQUET_THRIFT_USE_BOOST) + message(STATUS "Using Boost in Thrift header") +endif() Review comment: Makes sense to add this configuration. Will include that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [CPP ]Enable option to switch between stl classes and boost classes for > thrift header > - > > Key: PARQUET-1233 > URL: https://issues.apache.org/jira/browse/PARQUET-1233 > Project: Parquet > Issue Type: Bug >Reporter: Deepak Majeti >Assignee: Deepak Majeti >Priority: Major > Fix For: cpp-1.4.0 > > > Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This > causes an issue with older thrift versions. The scope of this Jira is to > enable an option to choose between stl and boost in parquet thrift header. > https://thrift.apache.org/lib/cpp -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[ https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370409#comment-16370409 ] ASF GitHub Bot commented on PARQUET-1233: - majetideepak commented on a change in pull request #443: PARQUET-1233: Enable option to switch between stl classes and boost c… URL: https://github.com/apache/parquet-cpp/pull/443#discussion_r169413745 ## File path: CMakeLists.txt ## @@ -399,6 +399,11 @@ else() endif() include(ThirdpartyToolchain) +if (THRIFT_VERSION VERSION_LESS "0.11.0") + add_definitions(-DPARQUET_THRIFT_USE_BOOST) + message(STATUS "Using Boost in Thrift header") +endif() Review comment: Makes sense to add this option. Will include that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [CPP ]Enable option to switch between stl classes and boost classes for > thrift header > - > > Key: PARQUET-1233 > URL: https://issues.apache.org/jira/browse/PARQUET-1233 > Project: Parquet > Issue Type: Bug >Reporter: Deepak Majeti >Assignee: Deepak Majeti >Priority: Major > Fix For: cpp-1.4.0 > > > Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This > causes an issue with older thrift versions. The scope of this Jira is to > enable an option to choose between stl and boost in parquet thrift header. > https://thrift.apache.org/lib/cpp -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[ https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370408#comment-16370408 ] ASF GitHub Bot commented on PARQUET-1233: - majetideepak commented on a change in pull request #443: PARQUET-1233: Enable option to switch between stl classes and boost c… URL: https://github.com/apache/parquet-cpp/pull/443#discussion_r169413543 ## File path: CMakeLists.txt ## @@ -399,6 +399,11 @@ else() endif() include(ThirdpartyToolchain) +if (THRIFT_VERSION VERSION_LESS "0.11.0") Review comment: `FORCE_BOOST_SMART_PTR` is the option to enforce boost in Thrift 0.11.0. Can users pass that via existing `PARQUET_CXXFLAGS`? The check `if defined(PARQUET_THRIFT_USE_BOOST) || defined(FORCE_BOOST_SMART_PTR)` in `thrift.h` examines that macro. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [CPP ]Enable option to switch between stl classes and boost classes for > thrift header > - > > Key: PARQUET-1233 > URL: https://issues.apache.org/jira/browse/PARQUET-1233 > Project: Parquet > Issue Type: Bug >Reporter: Deepak Majeti >Assignee: Deepak Majeti >Priority: Major > Fix For: cpp-1.4.0 > > > Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This > causes an issue with older thrift versions. The scope of this Jira is to > enable an option to choose between stl and boost in parquet thrift header. > https://thrift.apache.org/lib/cpp -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[ https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370333#comment-16370333 ] ASF GitHub Bot commented on PARQUET-1233: - wesm commented on a change in pull request #443: PARQUET-1233: Enable option to switch between stl classes and boost c… URL: https://github.com/apache/parquet-cpp/pull/443#discussion_r169399652 ## File path: CMakeLists.txt ## @@ -399,6 +399,11 @@ else() endif() include(ThirdpartyToolchain) +if (THRIFT_VERSION VERSION_LESS "0.11.0") Review comment: This might need to be a build option to toggle rather than using the version number. I think in Thrift 0.11.0 there might be a way to build with `boost:shared_ptr` support This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [CPP ]Enable option to switch between stl classes and boost classes for > thrift header > - > > Key: PARQUET-1233 > URL: https://issues.apache.org/jira/browse/PARQUET-1233 > Project: Parquet > Issue Type: Bug >Reporter: Deepak Majeti >Assignee: Deepak Majeti >Priority: Major > Fix For: cpp-1.4.0 > > > Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This > causes an issue with older thrift versions. The scope of this Jira is to > enable an option to choose between stl and boost in parquet thrift header. > https://thrift.apache.org/lib/cpp -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[ https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370332#comment-16370332 ] ASF GitHub Bot commented on PARQUET-1233: - wesm commented on a change in pull request #443: PARQUET-1233: Enable option to switch between stl classes and boost c… URL: https://github.com/apache/parquet-cpp/pull/443#discussion_r169399293 ## File path: CMakeLists.txt ## @@ -399,6 +399,11 @@ else() endif() include(ThirdpartyToolchain) +if (THRIFT_VERSION VERSION_LESS "0.11.0") + add_definitions(-DPARQUET_THRIFT_USE_BOOST) + message(STATUS "Using Boost in Thrift header") +endif() Review comment: Our toolchain build seems to be broken. If we wanted to be rigorous, we could pin Thrift 0.10.0 in the toolchain part of the build matrix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [CPP ]Enable option to switch between stl classes and boost classes for > thrift header > - > > Key: PARQUET-1233 > URL: https://issues.apache.org/jira/browse/PARQUET-1233 > Project: Parquet > Issue Type: Bug >Reporter: Deepak Majeti >Assignee: Deepak Majeti >Priority: Major > Fix For: cpp-1.4.0 > > > Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This > causes an issue with older thrift versions. The scope of this Jira is to > enable an option to choose between stl and boost in parquet thrift header. > https://thrift.apache.org/lib/cpp -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PARQUET-1233) [CPP ]Enable option to switch between stl classes and boost classes for thrift header
[ https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370165#comment-16370165 ] ASF GitHub Bot commented on PARQUET-1233: - majetideepak opened a new pull request #443: PARQUET-1233: Enable option to switch between stl classes and boost c… URL: https://github.com/apache/parquet-cpp/pull/443 …lasses for thrift header This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [CPP ]Enable option to switch between stl classes and boost classes for > thrift header > - > > Key: PARQUET-1233 > URL: https://issues.apache.org/jira/browse/PARQUET-1233 > Project: Parquet > Issue Type: Bug >Reporter: Deepak Majeti >Assignee: Deepak Majeti >Priority: Major > Fix For: cpp-1.4.0 > > > Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This > causes an issue with older thrift versions. The scope of this Jira is to > enable an option to choose between stl and boost in parquet thrift header. > https://thrift.apache.org/lib/cpp -- This message was sent by Atlassian JIRA (v7.6.3#76005)
