Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC3

2019-09-28 Thread Damyan Ivanov
-=| Vincent Veyron, 26.09.2019 21:40:29 +0200 |=-
> On Thu, 26 Sep 2019 21:52:29 +0300
> Damyan Ivanov  wrote:
> > 
> > builds OK and tests pass on Debian/unstable amd64 and i386 with apache 
> > 2.4.41, apr 1.6.5, Perl 5.28.1, CGI 4.44
> 
> Would you mind explaining what steps you took to build on Debian? I'm on 
> Stretch (old stable), and can't build. 

I am building the Debian package, not the "naked" source.

> # make
> cd "src/modules/perl" && make
> …
> /usr/bin/ld : ne peut trouver -lperl
> collect2: error: ld returned 1 exit status

Seems you miss the Perl development files. Try installing libperl-dev.

You may prefer to stick with the pre-compiled package 
(libapache2-mod-perl2).


-- Damyan

-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org



Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC3

2019-09-26 Thread Damyan Ivanov
-=| Steve Hay, 26.09.2019 18:17:33 +0100 |=-
> Please download, test, and report back on this mod_perl 2.0.11 release
> candidate.
> 
> https://dist.apache.org/repos/dist/dev/perl/mod_perl-2.0.11-rc3.tar.gz

builds OK and tests pass on Debian/unstable amd64 and i386 with apache 
2.4.41, apr 1.6.5, Perl 5.28.1, CGI 4.44

-- Damyan

-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org



Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2

2019-09-26 Thread Damyan Ivanov
-=| Steve Hay, 26.09.2019 09:02:19 +0100 |=-
> Before I actually roll out an RC3, please can you confirm that
> switching to FINFO_SIZE as per this patch works for you (it does for
> me):
> …

This works for me:

# testing : $r->finfo
# expected: 7278
# received: 7278
ok 44

(the rest of the tests still pass).

-- Damyan


-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org



Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2

2019-09-25 Thread Damyan Ivanov
-=| Damyan Ivanov, 25.09.2019 23:06:56 +0300 |=-
> -=| Steve Hay, 25.09.2019 08:34:07 +0100 |=-
> > What happens if you revert the change in that file? I.e. Change
> > FINFO_NAME back to FINFO_NORM on line 168, and on line 18 (the
> > APR::Const -compile line)? Does that fix it for you?
> 
> With these two lines reverted, all tests pass for me.

Out of interest I also tried using "FINFO_NAME | FINFO_NORM" on line 
168 and the test failed with the same error. It appears that 
FINFO_NAME triggers it.

Tracing this in APR, the error seems to come from 
file_io/unix/filestat.c¹ where the valid flags on line 73 don't 
include APR_FINFO_NAME. This kind of makes sense, because the stat(2) 
struct lacks information about the file name.

 ¹ https://sources.debian.org/src/apr/1.6.5-1/file_io/unix/filestat.c/

-- Damyan

-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org



Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2

2019-09-25 Thread Damyan Ivanov
-=| Steve Hay, 25.09.2019 08:34:07 +0100 |=-
> What happens if you revert the change in that file? I.e. Change
> FINFO_NAME back to FINFO_NORM on line 168, and on line 18 (the
> APR::Const -compile line)? Does that fix it for you?

With these two lines reverted, all tests pass for me (and the Debian 
package finished building. Yay!).


-- Damyan

-
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org



Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2

2019-09-24 Thread Damyan Ivanov
(Cc-ing Debian Perl group in case I missed something obvious)

-=| Steve Hay, 24.09.2019 17:53:14 +0100 |=-
> Please download, test, and report back on this mod_perl 2.0.11 release
> candidate.
> 
> https://dist.apache.org/repos/dist/dev/perl/mod_perl-2.0.11-rc2.tar.gz

One test fails on Debian unstable/amd64.

-8<-- Start Bug Report 8<--
1. Problem Description:

…
# testing : mtime
# expected: 1569347574
# received: '1569347574'
ok 43


500 Internal Server Error

Internal Server Error
The server encountered an internal error or
misconfiguration and was unable to complete
your request.
Please contact the server administrator at 
 dam@localhost to inform them of the time this error occurred,
 and the actions you performed just before this error.
More information about this error may be available
in the server error log.

Apache/2.4.41 (Debian) world domination series/2.0 
mod_apreq2-20090110/2.8.0 mod_perl/2.0.11-rc2 Perl/v5.28.1 Server at localhost 
Port 8529

Failed 12/55 subtests 

Test Summary Report
---
t/api/request_rec.t (Wstat: 0 Tests: 43 Failed: 0)
  Parse errors: Bad plan.  You planned 55 tests but ran 43.
Files=1, Tests=43,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.46 cusr  0.13 
csys =  0.61 CPU)
Result: FAIL

error_log:
(full log for request_rec.t attached)

[Tue Sep 24 21:55:53.589476 2019] [perl:error] [pid 1184:tid 140271230908160] 
[client 127.0.0.1:40218] APR::Finfo::stat: (70008) Partial results are valid 
but processing is incomplete at 
/home/dam/w/pkg-perl/packages/libapache2-mod-perl2/t/response/TestAPI/request_rec.pm
 line 168

Note that in Debian apache, apreq and mod_perl have plenty of patches 
applied. That wasn't a problem by itself before, but I'd rather 
mention it here to avoid surprises.

This report is about the RC2 tarball with all the patches at 
https://salsa.debian.org/perl-team/modules/packages/libapache2-mod-perl2/tree/master/debian/patches
 
minus
 260_fix_pipelined_response_deadlock.patch,
 370_http_syntax.patch,
 380_inject_header_line_terminators.patch, and
 CVE-2011-2767.patch
that were included in this RC2 release (thanks!)

2. Used Components and their Configuration:

*** mod_perl version 2.11

*** using 
/home/dam/w/pkg-perl/packages/libapache2-mod-perl2/lib/Apache2/BuildConfig.pm

*** Makefile.PL options:
  MP_APR_CONFIG  => /usr/bin/apr-config
  MP_APR_LIB => aprext
  MP_APXS=> /usr/bin/apxs
  MP_CCOPTS  => -g -O2 
-fdebug-prefix-map=/home/dam/w/pkg-perl/packages/libapache2-mod-perl2=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wall -fgnu89-inline
  MP_COMPAT_1X   => 1
  MP_GENERATE_XS => 1
  MP_LIBNAME => mod_perl
  MP_TRACE   => 0
  MP_USE_DSO => 1
  MP_USE_STATIC  => 0


*** /usr/sbin/apache2 -V
Server version: Apache/2.4.41 (Debian)
Server built:   2019-08-14T04:42:29
Server's Module Magic Number: 20120211:88
Server loaded:  APR 1.6.5, APR-UTIL 1.6.1
Compiled using: APR 1.6.5, APR-UTIL 1.6.1
Architecture:   64-bit
Server MPM: 
Server compiled with
 -D APR_HAS_SENDFILE
 -D APR_HAS_MMAP
 -D APR_HAVE_IPV6 (IPv4-mapped addresses enabled)
 -D APR_USE_SYSVSEM_SERIALIZE
 -D APR_USE_PTHREAD_SERIALIZE
 -D SINGLE_LISTEN_UNSERIALIZED_ACCEPT
 -D APR_HAS_OTHER_CHILD
 -D AP_HAVE_RELIABLE_PIPED_LOGS
 -D DYNAMIC_MODULE_LIMIT=256
 -D HTTPD_ROOT="/etc/apache2"
 -D SUEXEC_BIN="/usr/lib/apache2/suexec"
 -D DEFAULT_PIDLOG="/var/run/apache2.pid"
 -D DEFAULT_SCOREBOARD="logs/apache_runtime_status"
 -D DEFAULT_ERRORLOG="logs/error_log"
 -D AP_TYPES_CONFIG_FILE="mime.types"
 -D SERVER_CONFIG_FILE="apache2.conf"

*** /usr/bin/ldd /usr/sbin/apache2
linux-vdso.so.1 (0x7ffc791c9000)
libpcre.so.3 => /lib/x86_64-linux-gnu/libpcre.so.3 (0x7f145fe89000)
libaprutil-1.so.0 => /usr/lib/x86_64-linux-gnu/libaprutil-1.so.0 
(0x7f145fe5b000)
libapr-1.so.0 => /usr/lib/x86_64-linux-gnu/libapr-1.so.0 
(0x7f145fe22000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 
(0x7f145fe01000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x7f145fc41000)
libuuid.so.1 => /lib/x86_64-linux-gnu/libuuid.so.1 (0x7f145fc38000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x7f145fc2b000)
libcrypt.so.1 => /lib/x86_64-linux-gnu/libcrypt.so.1 
(0x7f145fbf2000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x7f145fbed000)
libexpat.so.1 => /lib/x86_64-linux-gnu/libexpat.so.1 
(0x7f145fbc)
/lib64/ld-linux-x86-64.so.2 (0x7f145ffcc000)


*** (apr|apu)-config linking info

 -L/usr/lib/x86_64-linux-gnu -laprutil-1
 -L/usr/lib/x86_64-linux-gnu -lapr-1  



*** /usr/bin/perl -V
Summary of my perl5 (revision 5 version 28 subversion 1) configuration:
   
  Platform:
osname=linux
osvers=4.9.0
archname=x86_64-linux-gnu-thread-multi
uname='linux localhost 4.9.0 #1 smp debian 4.9.0 x86_64 gnulinux '
config_args='-Dusethreads