[jira] [Commented] (PHOENIX-2048) change to_char() function to use HALF_UP rounding mode
[
https://issues.apache.org/jira/browse/PHOENIX-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238564#comment-16238564
]
Hadoop QA commented on PHOENIX-2048:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12883121/PHOENIX-2048_v2.patch
against master branch at commit a09cea6bfb94edd95ce06aa2cb7f229227db5666.
ATTACHMENT ID: 12883121
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1618//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1618//console
This message is automatically generated.
> change to_char() function to use HALF_UP rounding mode
> --
>
> Key: PHOENIX-2048
> URL: https://issues.apache.org/jira/browse/PHOENIX-2048
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: verify
>Reporter: Jonathan Leech
>Assignee: Csaba Skrabak
>Priority: Minor
> Fix For: 4.14.0
>
> Attachments: PHOENIX-2048.patch, PHOENIX-2048_v2.patch
>
>
> to_char() function uses the default rounding mode in java DecimalFormat,
> which is a strange one called HALF_EVEN, which rounds a '5' in the last
> position either up or down depending on the preceding digit.
> Change it to HALF_UP so it rounds the same way as the round() function does,
> or provide a way to override the behavior; e.g. globally or as a client
> config, or an argument to the to_char() function.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-2048) change to_char() function to use HALF_UP rounding mode
[ https://issues.apache.org/jira/browse/PHOENIX-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136845#comment-16136845 ] Csaba Skrabak commented on PHOENIX-2048: Help, @hadoopqa lies: * phoenix-core/src/it/java/org/apache/phoenix/end2end/ToCharFunctionIT.java _is_ a test and modification of it is included. * There is no Javadoc warning about the modified files in the linked txt. * Yes, I can break the long lines. > change to_char() function to use HALF_UP rounding mode > -- > > Key: PHOENIX-2048 > URL: https://issues.apache.org/jira/browse/PHOENIX-2048 > Project: Phoenix > Issue Type: Improvement >Affects Versions: verify >Reporter: Jonathan Leech >Assignee: Csaba Skrabak >Priority: Minor > Fix For: 4.12.0 > > Attachments: PHOENIX-2048.patch > > > to_char() function uses the default rounding mode in java DecimalFormat, > which is a strange one called HALF_EVEN, which rounds a '5' in the last > position either up or down depending on the preceding digit. > Change it to HALF_UP so it rounds the same way as the round() function does, > or provide a way to override the behavior; e.g. globally or as a client > config, or an argument to the to_char() function. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-2048) change to_char() function to use HALF_UP rounding mode
[
https://issues.apache.org/jira/browse/PHOENIX-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131013#comment-16131013
]
Hadoop QA commented on PHOENIX-2048:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12850265/phoenix-2048.patch
against master branch at commit b13413614fef3cdb87233fd1543081e7198d685f.
ATTACHMENT ID: 12850265
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
56 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+String query = "select to_char(col_decimal, '" + pattern + "')
from " + TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
+String query = "select to_char(col_date, '" + pattern + "') from " +
TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
+String query = "select to_char(col_time, '" + pattern + "') from " +
TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
+String query = "select to_char(col_timestamp, '" + pattern + "') from
" + TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
+String query = "select to_char(col_integer, '" + pattern + "') from "
+ TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
+String query = "select to_char(col_decimal, '" + pattern + "') from "
+ TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1269//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1269//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1269//console
This message is automatically generated.
> change to_char() function to use HALF_UP rounding mode
> --
>
> Key: PHOENIX-2048
> URL: https://issues.apache.org/jira/browse/PHOENIX-2048
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: verify
>Reporter: Jonathan Leech
>Assignee: Csaba Skrabak
>Priority: Minor
> Fix For: 4.12.0
>
> Attachments: PHOENIX-2048.patch
>
>
> to_char() function uses the default rounding mode in java DecimalFormat,
> which is a strange one called HALF_EVEN, which rounds a '5' in the last
> position either up or down depending on the preceding digit.
> Change it to HALF_UP so it rounds the same way as the round() function does,
> or provide a way to override the behavior; e.g. globally or as a client
> config, or an argument to the to_char() function.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-2048) change to_char() function to use HALF_UP rounding mode
[
https://issues.apache.org/jira/browse/PHOENIX-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131005#comment-16131005
]
Hadoop QA commented on PHOENIX-2048:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12882386/PHOENIX-2048.patch
against master branch at commit b13413614fef3cdb87233fd1543081e7198d685f.
ATTACHMENT ID: 12882386
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
56 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+String query = "select to_char(col_decimal, '" + pattern + "')
from " + TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
+String query = "select to_char(col_date, '" + pattern + "') from " +
TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
+String query = "select to_char(col_time, '" + pattern + "') from " +
TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
+String query = "select to_char(col_timestamp, '" + pattern + "') from
" + TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
+String query = "select to_char(col_integer, '" + pattern + "') from "
+ TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
+String query = "select to_char(col_decimal, '" + pattern + "') from "
+ TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1270//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1270//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1270//console
This message is automatically generated.
> change to_char() function to use HALF_UP rounding mode
> --
>
> Key: PHOENIX-2048
> URL: https://issues.apache.org/jira/browse/PHOENIX-2048
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: verify
>Reporter: Jonathan Leech
>Assignee: Csaba Skrabak
>Priority: Minor
> Fix For: 4.12.0
>
> Attachments: PHOENIX-2048.patch
>
>
> to_char() function uses the default rounding mode in java DecimalFormat,
> which is a strange one called HALF_EVEN, which rounds a '5' in the last
> position either up or down depending on the preceding digit.
> Change it to HALF_UP so it rounds the same way as the round() function does,
> or provide a way to override the behavior; e.g. globally or as a client
> config, or an argument to the to_char() function.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-2048) change to_char() function to use HALF_UP rounding mode
[ https://issues.apache.org/jira/browse/PHOENIX-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090297#comment-16090297 ] Julian Hyde commented on PHOENIX-2048: -- By the way, if you don't have an Oracle instance, this is an easy way to get one using Docker: https://github.com/wnameless/docker-oracle-xe-11g > change to_char() function to use HALF_UP rounding mode > -- > > Key: PHOENIX-2048 > URL: https://issues.apache.org/jira/browse/PHOENIX-2048 > Project: Phoenix > Issue Type: Improvement >Affects Versions: verify >Reporter: Jonathan Leech >Priority: Minor > Fix For: 4.12.0 > > Attachments: phoenix-2048.patch > > > to_char() function uses the default rounding mode in java DecimalFormat, > which is a strange one called HALF_EVEN, which rounds a '5' in the last > position either up or down depending on the preceding digit. > Change it to HALF_UP so it rounds the same way as the round() function does, > or provide a way to override the behavior; e.g. globally or as a client > config, or an argument to the to_char() function. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-2048) change to_char() function to use HALF_UP rounding mode
[ https://issues.apache.org/jira/browse/PHOENIX-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090022#comment-16090022 ] Julian Hyde commented on PHOENIX-2048: -- I don't think you need it to be configurable. If you ask 10 people what is the least surprising behavior, they'd all say either "I don't care" or "do the same as oracle". It's probably not documented in oracle, but do some experiments. > change to_char() function to use HALF_UP rounding mode > -- > > Key: PHOENIX-2048 > URL: https://issues.apache.org/jira/browse/PHOENIX-2048 > Project: Phoenix > Issue Type: Improvement >Affects Versions: verify >Reporter: Jonathan Leech >Priority: Minor > Fix For: 4.12.0 > > Attachments: phoenix-2048.patch > > > to_char() function uses the default rounding mode in java DecimalFormat, > which is a strange one called HALF_EVEN, which rounds a '5' in the last > position either up or down depending on the preceding digit. > Change it to HALF_UP so it rounds the same way as the round() function does, > or provide a way to override the behavior; e.g. globally or as a client > config, or an argument to the to_char() function. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-2048) change to_char() function to use HALF_UP rounding mode
[ https://issues.apache.org/jira/browse/PHOENIX-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089808#comment-16089808 ] Csaba Skrabak commented on PHOENIX-2048: Found nothing about rounding in the Oracle online documentation. We tried in Live SQL, it rounded with HALF_UP. Still not sure if there is a config value in Oracle that changes rounding mode. So the question is the same. Do you think we need to do this in a configurable way? > change to_char() function to use HALF_UP rounding mode > -- > > Key: PHOENIX-2048 > URL: https://issues.apache.org/jira/browse/PHOENIX-2048 > Project: Phoenix > Issue Type: Improvement >Affects Versions: verify >Reporter: Jonathan Leech >Priority: Minor > Fix For: 4.12.0 > > Attachments: phoenix-2048.patch > > > to_char() function uses the default rounding mode in java DecimalFormat, > which is a strange one called HALF_EVEN, which rounds a '5' in the last > position either up or down depending on the preceding digit. > Change it to HALF_UP so it rounds the same way as the round() function does, > or provide a way to override the behavior; e.g. globally or as a client > config, or an argument to the to_char() function. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-2048) change to_char() function to use HALF_UP rounding mode
[ https://issues.apache.org/jira/browse/PHOENIX-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087667#comment-16087667 ] Julian Hyde commented on PHOENIX-2048: -- Make it behave the same as Oracle. > change to_char() function to use HALF_UP rounding mode > -- > > Key: PHOENIX-2048 > URL: https://issues.apache.org/jira/browse/PHOENIX-2048 > Project: Phoenix > Issue Type: Improvement >Affects Versions: verify >Reporter: Jonathan Leech >Priority: Minor > Fix For: 4.12.0 > > Attachments: phoenix-2048.patch > > > to_char() function uses the default rounding mode in java DecimalFormat, > which is a strange one called HALF_EVEN, which rounds a '5' in the last > position either up or down depending on the preceding digit. > Change it to HALF_UP so it rounds the same way as the round() function does, > or provide a way to override the behavior; e.g. globally or as a client > config, or an argument to the to_char() function. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-2048) change to_char() function to use HALF_UP rounding mode
[ https://issues.apache.org/jira/browse/PHOENIX-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087322#comment-16087322 ] Csaba Skrabak commented on PHOENIX-2048: [~elserj] [~asinghal] [~enis], do you think we need to do this in a configurable way? > change to_char() function to use HALF_UP rounding mode > -- > > Key: PHOENIX-2048 > URL: https://issues.apache.org/jira/browse/PHOENIX-2048 > Project: Phoenix > Issue Type: Improvement >Affects Versions: verify >Reporter: Jonathan Leech >Priority: Minor > Fix For: 4.12.0 > > Attachments: phoenix-2048.patch > > > to_char() function uses the default rounding mode in java DecimalFormat, > which is a strange one called HALF_EVEN, which rounds a '5' in the last > position either up or down depending on the preceding digit. > Change it to HALF_UP so it rounds the same way as the round() function does, > or provide a way to override the behavior; e.g. globally or as a client > config, or an argument to the to_char() function. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-2048) change to_char() function to use HALF_UP rounding mode
[ https://issues.apache.org/jira/browse/PHOENIX-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848596#comment-15848596 ] Jonathan Leech commented on PHOENIX-2048: - Looking through the other functions, I don't see any that look at configuration. Should be possible to grab a value from hbase-site.xml in a function, not sure if it's necessary. > change to_char() function to use HALF_UP rounding mode > -- > > Key: PHOENIX-2048 > URL: https://issues.apache.org/jira/browse/PHOENIX-2048 > Project: Phoenix > Issue Type: Improvement >Affects Versions: verify >Reporter: Jonathan Leech >Priority: Minor > Fix For: 4.10.0 > > Attachments: phoenix-2048.patch > > > to_char() function uses the default rounding mode in java DecimalFormat, > which is a strange one called HALF_EVEN, which rounds a '5' in the last > position either up or down depending on the preceding digit. > Change it to HALF_UP so it rounds the same way as the round() function does, > or provide a way to override the behavior; e.g. globally or as a client > config, or an argument to the to_char() function. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (PHOENIX-2048) change to_char() function to use HALF_UP rounding mode
[ https://issues.apache.org/jira/browse/PHOENIX-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848114#comment-15848114 ] Csaba Skrabak commented on PHOENIX-2048: [^phoenix-2048.patch] is the solution that always uses HALF_UP. It is an _incompatible_ change. I don't know about the configurable ideas. Is there any example in Phoenix for a function that behaves different ways depending on configuration? > change to_char() function to use HALF_UP rounding mode > -- > > Key: PHOENIX-2048 > URL: https://issues.apache.org/jira/browse/PHOENIX-2048 > Project: Phoenix > Issue Type: Improvement >Affects Versions: verify >Reporter: Jonathan Leech >Priority: Minor > Fix For: 4.10.0 > > Attachments: phoenix-2048.patch > > > to_char() function uses the default rounding mode in java DecimalFormat, > which is a strange one called HALF_EVEN, which rounds a '5' in the last > position either up or down depending on the preceding digit. > Change it to HALF_UP so it rounds the same way as the round() function does, > or provide a way to override the behavior; e.g. globally or as a client > config, or an argument to the to_char() function. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
