[jira] [Updated] (PHOENIX-3242) Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
[ https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated PHOENIX-3242: - Attachment: PHOENIX-3242_v7.patch [~maryannxue] Here is the patch made UDF it test pass. Fixed PHOENIX-3351 also as part of this. > Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration > - > > Key: PHOENIX-3242 > URL: https://issues.apache.org/jira/browse/PHOENIX-3242 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla > Labels: calcite > Attachments: PHOENIX-3242-WIP-2.patch, PHOENIX-3242-wip.patch, > PHOENIX-3242_select-wip.patch, PHOENIX-3242_v1.patch, PHOENIX-3242_v2.patch, > PHOENIX-3242_v3.patch, PHOENIX-3242_v4.patch, PHOENIX-3242_v5.patch, > PHOENIX-3242_v6.patch, PHOENIX-3242_v7.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PHOENIX-3242) Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
[ https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maryann Xue updated PHOENIX-3242: - Attachment: PHOENIX-3242-WIP-2.patch [~rajeshbabu], this is the new patch. The UDF works now. But there seems to be an issue with UPSERT so I had to tweak the test case a little bit by using the new calcite-phoenix connection for function creation and UDF queries and using old Phoenix connection for UPSERT only. It can now pass the UDF queries but fails at the point of checking function DROP, which is another issue in schema object caching, I'll open a different JIRA for this. Yet I didn't get to review your entire patch yet. But I found at least one issue while I was trying to work out the test case. During function creation, the single quotes surrounding the class name and the jar path should be trimmed when you create the function node, otherwise you'd run into trouble at a later stage. And I believe that's why you were trying to do a fix in PhoenixSchema. I moved this trimming logic into CREATE_FUNCTION but I'm not sure if there are better ways to do this with Calcite facilities. And I guess there might be some other checks in CREATE_FUNCTION that need to be done. So could you please go through this new patch again and see if there's anything that needs to be refined? > Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration > - > > Key: PHOENIX-3242 > URL: https://issues.apache.org/jira/browse/PHOENIX-3242 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla > Labels: calcite > Attachments: PHOENIX-3242-WIP-2.patch, PHOENIX-3242-wip.patch, > PHOENIX-3242_select-wip.patch, PHOENIX-3242_v1.patch, PHOENIX-3242_v2.patch, > PHOENIX-3242_v3.patch, PHOENIX-3242_v4.patch, PHOENIX-3242_v5.patch, > PHOENIX-3242_v6.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PHOENIX-3242) Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
[ https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated PHOENIX-3242: - Attachment: PHOENIX-3242_select-wip.patch [~maryannxue] Here is wip patch using UDF function in select query. You can run UserDefinedFunctionsIT#testUDFsWithMultipleConnections to check testing where select query using UDF function is failing. Here are couple of changes I have done other than DDL: - In PhoenixScheam#getFunctions tried to load the class and create SchalarFunctionImpl - which is not correct but just tried to reach PhoenixAbstractProject to translate which fail with exception. > Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration > - > > Key: PHOENIX-3242 > URL: https://issues.apache.org/jira/browse/PHOENIX-3242 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla > Labels: calcite > Attachments: PHOENIX-3242-wip.patch, PHOENIX-3242_select-wip.patch, > PHOENIX-3242_v1.patch, PHOENIX-3242_v2.patch, PHOENIX-3242_v3.patch, > PHOENIX-3242_v4.patch, PHOENIX-3242_v5.patch, PHOENIX-3242_v6.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PHOENIX-3242) Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
[ https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated PHOENIX-3242: - Attachment: PHOENIX-3242_v6.patch Here is the rebased patch on latest calcite branch. > Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration > - > > Key: PHOENIX-3242 > URL: https://issues.apache.org/jira/browse/PHOENIX-3242 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla > Labels: calcite > Attachments: PHOENIX-3242-wip.patch, PHOENIX-3242_v1.patch, > PHOENIX-3242_v2.patch, PHOENIX-3242_v3.patch, PHOENIX-3242_v4.patch, > PHOENIX-3242_v5.patch, PHOENIX-3242_v6.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PHOENIX-3242) Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
[ https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated PHOENIX-3242: - Attachment: PHOENIX-3242_v5.patch > Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration > - > > Key: PHOENIX-3242 > URL: https://issues.apache.org/jira/browse/PHOENIX-3242 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla > Labels: calcite > Attachments: PHOENIX-3242-wip.patch, PHOENIX-3242_v1.patch, > PHOENIX-3242_v2.patch, PHOENIX-3242_v3.patch, PHOENIX-3242_v4.patch, > PHOENIX-3242_v5.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PHOENIX-3242) Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
[ https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated PHOENIX-3242: - Attachment: (was: PHOENIX-3163_v4.patch) > Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration > - > > Key: PHOENIX-3242 > URL: https://issues.apache.org/jira/browse/PHOENIX-3242 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla > Labels: calcite > Attachments: PHOENIX-3242-wip.patch, PHOENIX-3242_v1.patch, > PHOENIX-3242_v2.patch, PHOENIX-3242_v3.patch, PHOENIX-3242_v4.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PHOENIX-3242) Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
[ https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated PHOENIX-3242: - Attachment: PHOENIX-3242_v4.patch > Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration > - > > Key: PHOENIX-3242 > URL: https://issues.apache.org/jira/browse/PHOENIX-3242 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla > Labels: calcite > Attachments: PHOENIX-3242-wip.patch, PHOENIX-3242_v1.patch, > PHOENIX-3242_v2.patch, PHOENIX-3242_v3.patch, PHOENIX-3242_v4.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PHOENIX-3242) Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
[ https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated PHOENIX-3242: - Attachment: PHOENIX-3163_v4.patch > Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration > - > > Key: PHOENIX-3242 > URL: https://issues.apache.org/jira/browse/PHOENIX-3242 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla > Labels: calcite > Attachments: PHOENIX-3163_v4.patch, PHOENIX-3242-wip.patch, > PHOENIX-3242_v1.patch, PHOENIX-3242_v2.patch, PHOENIX-3242_v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PHOENIX-3242) Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
[ https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maryann Xue updated PHOENIX-3242: - Labels: calcite (was: ) > Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration > - > > Key: PHOENIX-3242 > URL: https://issues.apache.org/jira/browse/PHOENIX-3242 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla > Labels: calcite > Attachments: PHOENIX-3242-wip.patch, PHOENIX-3242_v1.patch, > PHOENIX-3242_v2.patch, PHOENIX-3242_v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PHOENIX-3242) Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
[ https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated PHOENIX-3242: - Attachment: PHOENIX-3242_v3.patch Here is the patch to support create and drop function, add and delete jar queries. "add jars" query changed as "copy jars" because of add keyword the query is not getting parsed properly but the functionality is same. As Julian suggested at CALCITE-1370 copied SqlParserTest to phoenix and added tests to check the ddl queries properly parsing as ddl statements or not. ping [~maryannxue]? > Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration > - > > Key: PHOENIX-3242 > URL: https://issues.apache.org/jira/browse/PHOENIX-3242 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla > Attachments: PHOENIX-3242-wip.patch, PHOENIX-3242_v1.patch, > PHOENIX-3242_v2.patch, PHOENIX-3242_v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PHOENIX-3242) Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
[ https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated PHOENIX-3242: - Attachment: PHOENIX-3242_v2.patch In v2 patch added drop function support as well. > Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration > - > > Key: PHOENIX-3242 > URL: https://issues.apache.org/jira/browse/PHOENIX-3242 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla > Attachments: PHOENIX-3242-wip.patch, PHOENIX-3242_v1.patch, > PHOENIX-3242_v2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PHOENIX-3242) Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
[ https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated PHOENIX-3242: - Attachment: PHOENIX-3242_v1.patch [~maryannxue] Here is the updated patch working fine after CALCITE-1370. If it's ok will commit it. > Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration > - > > Key: PHOENIX-3242 > URL: https://issues.apache.org/jira/browse/PHOENIX-3242 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla > Attachments: PHOENIX-3242-wip.patch, PHOENIX-3242_v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PHOENIX-3242) Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
[ https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated PHOENIX-3242: - Attachment: PHOENIX-3242-wip.patch [~maryannxue] Here is the patch to support create or replace function ddl operation. Working on unparse logic in SqlCreateFunction. > Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration > - > > Key: PHOENIX-3242 > URL: https://issues.apache.org/jira/browse/PHOENIX-3242 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla > Attachments: PHOENIX-3242-wip.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PHOENIX-3242) Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
[ https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated PHOENIX-3242: - Summary: Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration (was: Support CREATE Function in Phoenix-Calcite Integration) > Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration > - > > Key: PHOENIX-3242 > URL: https://issues.apache.org/jira/browse/PHOENIX-3242 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
