[GitHub] poi pull request #112: Support for LineStyle in XSSFComment

2018-06-09 Thread mayuranchalia
Github user mayuranchalia closed the pull request at:

https://github.com/apache/poi/pull/112


---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[GitHub] poi pull request #112: Support for LineStyle in XSSFComment

2018-06-09 Thread mayuranchalia
GitHub user mayuranchalia opened a pull request:

https://github.com/apache/poi/pull/112

 Support for LineStyle in XSSFComment

XSSFComment doesn't have support for Linestyle similar to HSSFComment

In HSSFComment we have functions like setLineStyle and setLineStyleColor, 
similar feature is required for XSSFComment .

Bugzilla bug 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62247


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/poi trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/poi/pull/112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #112


commit fb321255e8aab6f51ef579c554ff1b5028e3a2d3
Author: Javen O'Neal 
Date:   2017-11-07T00:29:09Z

bug 61730: add iterator interface to CellRangeAddressBase for iterating 
over CellAddresses

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814448 
13f79535-47bb-0310-9956-ffa450edef68

commit 841cc75ee498921c97fd9386e8f564e75010f173
Author: Javen O'Neal 
Date:   2017-11-07T01:54:25Z

bug 61730: add javadoc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814451 
13f79535-47bb-0310-9956-ffa450edef68

commit 163673a7aa8b42324f4aa922971a9475ddcdee62
Author: Javen O'Neal 
Date:   2017-11-07T07:21:24Z

bug 61730: remove CellRangeAddressBase which is eager. The lazy iterator is 
safer, less likely to cause an OOM/DoS.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814461 
13f79535-47bb-0310-9956-ffa450edef68

commit 8b0145c6e0cb27ac72610271073ebac140e5ca5a
Author: Javen O'Neal 
Date:   2017-11-07T07:26:48Z

bug 61730: remove asSet function from unit test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814462 
13f79535-47bb-0310-9956-ffa450edef68

commit 2d5b6457c6d5dd5a8f910d726bb493233b01724b
Author: Dominik Stadler 
Date:   2017-11-08T14:59:08Z

Some JavaDoc adjustments, typos, IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814587 
13f79535-47bb-0310-9956-ffa450edef68

commit 70fdcdf8481cdcf3c6465a189956e30822a3e96f
Author: Mark Murphy 
Date:   2017-11-11T14:18:24Z

Surface XSSF Header/Footer Attributes (60887)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814950 
13f79535-47bb-0310-9956-ffa450edef68

commit c1e6c2eef7949e74e99d6dda799d2be1b9c6b6ff
Author: Javen O'Neal 
Date:   2017-11-12T01:30:42Z

deprecate XWPFTable#addNewRowBetween(int,int), which has not been 
implemented since 2008 when this class was first authored. (Unrelated: This 
closes #82 on github).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814997 
13f79535-47bb-0310-9956-ffa450edef68

commit fd29e874025e5d2ab6f6595ccc9687639124dc2f
Author: Javen O'Neal 
Date:   2017-11-12T01:32:43Z

make tableRows final; initialize where defined rather than in constructor.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814998 
13f79535-47bb-0310-9956-ffa450edef68

commit 1bc1bdb58b2b3517c98ebc5899810f8ce1234411
Author: Javen O'Neal 
Date:   2017-11-12T01:34:52Z

XWPFTable#getRows() should return an unmodifiable list unless the method 
can correctly update xmlbeans in response to modifying the list

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814999 
13f79535-47bb-0310-9956-ffa450edef68

commit fbccf3066cda10b8f1408d11785a1d07a24a8f18
Author: Javen O'Neal 
Date:   2017-11-12T06:14:43Z

github #81: sheet names are case insensitive

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815001 
13f79535-47bb-0310-9956-ffa450edef68

commit bac484ba379cc226ace386fdd851ffd8bdc76b12
Author: Javen O'Neal 
Date:   2017-11-12T06:52:38Z

+svn:eol-style native *.java

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815002 
13f79535-47bb-0310-9956-ffa450edef68

commit a1b8f3ff1446f1e52d9ced9de8370e10cf5e5faa
Author: Javen O'Neal 
Date:   2017-11-12T21:48:41Z

bug 61745: add support for charts in XWPF/docx. Thanks to Sandeep Tiwari 
for the patch

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815047 
13f79535-47bb-0310-9956-ffa450edef68

commit f062e7f1c2c278b19f5fb7ac86bb7df9d3a48882
Author: Javen O'Neal 
Date:   2017-11-13T00:51:41Z

bug 61745: remove String#toString() usage found by forbidden apis check

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815048 
13f79535-47bb-0310-9956-ffa450edef68

commit 1b9d599882ba628b8d7499b807e404186ffa1ac0
Author: Dominik Stadler 
Date:   2017-11-13T11:44:50Z

Fix tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815085 
13f79535-47bb-0310-9956-ffa450edef68

commit 3e70d22cbc45f1460583127e9c430a461b7852c9
Author: Dominik Stadler 
Date:   2017-11-13T11:46:04Z