Re: [VOTE] Release Apache POI 5.2.4 (RC1)
Thanks Dominik. My svn client did not show those .svnpatch.rej files. They are not checked in. They are part of my local install. I have removed them locally now. While it isn't ideal to have them in the source distribution, I don't think they will cause much harm. In the announcement emails, I'll make sure to highlight the fact that we don't have binary zip/tar.gz any more. I have updated https://poi.apache.org/download.html (Binary Artifacts section) to provide a URL for traversing Maven jars. On Saturday 23 September 2023 at 11:45:49 IST, Dominik Stadler wrote: Hi, I found one additional minor issue,the following 2 files are part of the source-package and break the "rat" step if you execute full "jenkins" build target. But I would not re-run the release just because of this unless something else pops up. ./poi/src/main/java/org/apache/poi/hssf/record/SSTDeserializer.java (working copy).svnpatch.rej ./poi/src/test/java/org/apache/poi/hssf/record/TestSSTDeserializer.java (working copy).svnpatch.rej Dominik. On Sat, Sep 23, 2023 at 12:31 PM Dominik Stadler wrote: > Hi, > > +1 from me, thanks P.J.! > > Large-scale regression testing looks good, only very very few regressions > for more than 3mio documents ( ~0.02% ), most are caused by slightly > stricter handling (more than 1000 compressed files, more than 300 nested > children), a few remaining cases which we can take a look after release. > Results are at > http://people.apache.org/~centic/poi_regression/reports/index523RC1to524RC1.html > and > http://people.apache.org/~centic/poi_regression/reportsAll/index523RC1to524RC1.html > > Difference between source-packages from 5.2.3 and 5.2.4 looks good. > > Building from sources works locally. > > Upgrading projects to 5.2.4RC1 from the staging Maven repository did work > fine, all tests passing. > > > I added a note in the changelog about the removed binary packages, but if > possible we should also add a bit more description about this in the > announcement email. I think it may disrupt how some people integrate poi > and thus may be worth to note in the release notes/announcement as well. > I.e. "either build it yourself or download the binaries from Maven Central" > > Regards... Dominik. > > On Fri, Sep 22, 2023 at 9:26 PM Tim Allison wrote: > >> +1 >> >> Reports are here: There's surprisingly little difference: >> https://corpora.tika.apache.org/base/reports/poi-reports.tgz >> >> I only had time to glance briefly. >> >> Thank you PJ and team! >> >> On Fri, Sep 22, 2023 at 4:09 AM PJ Fanning >> wrote: >> >> > Thanks Alex. The pdfbox issue is tracked at >> > https://bz.apache.org/bugzilla/show_bug.cgi?id=67023 and includes a >> link >> > to what is blocking our upgrade. >> > >> > In terms of the version names of the jars - the ASF has a rule that you >> > must release what has been voted on. That means I can't create 5.2.4-RC1 >> > jars - get those voted on and then go off and rebuild 5.2.4 jars without >> > having those voted on. The jars are not in Maven Central yet, they are >> in a >> > staging area. Anyone who tests the staging jars will need to consider >> > cleaning out their local jar caches (e.g. their Maven local cache) after >> > they test the staging jars. Only a small number of POI reviewers will >> use >> > the staging jars. >> > >> > >> > >> > >> > >> > >> > On Friday 22 September 2023 at 04:05:48 IST, Axel Howind > > >> > wrote: >> > >> > >> > >> > >> > >> > +1 for the release. >> > >> > I just built and tested one of my own projects with the RC and >> everything >> > seems to work just fine. >> > >> > Two notes: >> > - I think release candidates should be published with an "rc“ in the >> > version string, something like "5.3.4-rc1“ because otherwise when a >> second >> > release candidate/the final release becomes available, Maven might stick >> > with the old rc build in the local .m2. >> > - pdfboc has been updated to 2.0.29. in the meantime, pdfbox released >> the >> > next major release (3.0.0), but I think switching to pdfbox 3 should be >> > more thoroughly tested and would rather be something for POI 5.3 >> > >> > > Am 21.09.2023 um 23:58 schrieb PJ Fanning : >> > > >> > > https://dist.apache.org/repos/dist/dev/poi/RELEASE-NOTES-5.2.4.txt >> > >> > - >> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org >> > For additional commands, e-mail: dev-h...@poi.apache.org >> > >> > >> > - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
Re: [VOTE] Release Apache POI 5.2.4 (RC1)
Hi, I found one additional minor issue,the following 2 files are part of the source-package and break the "rat" step if you execute full "jenkins" build target. But I would not re-run the release just because of this unless something else pops up. ./poi/src/main/java/org/apache/poi/hssf/record/SSTDeserializer.java (working copy).svnpatch.rej ./poi/src/test/java/org/apache/poi/hssf/record/TestSSTDeserializer.java (working copy).svnpatch.rej Dominik. On Sat, Sep 23, 2023 at 12:31 PM Dominik Stadler wrote: > Hi, > > +1 from me, thanks P.J.! > > Large-scale regression testing looks good, only very very few regressions > for more than 3mio documents ( ~0.02% ), most are caused by slightly > stricter handling (more than 1000 compressed files, more than 300 nested > children), a few remaining cases which we can take a look after release. > Results are at > http://people.apache.org/~centic/poi_regression/reports/index523RC1to524RC1.html > and > http://people.apache.org/~centic/poi_regression/reportsAll/index523RC1to524RC1.html > > Difference between source-packages from 5.2.3 and 5.2.4 looks good. > > Building from sources works locally. > > Upgrading projects to 5.2.4RC1 from the staging Maven repository did work > fine, all tests passing. > > > I added a note in the changelog about the removed binary packages, but if > possible we should also add a bit more description about this in the > announcement email. I think it may disrupt how some people integrate poi > and thus may be worth to note in the release notes/announcement as well. > I.e. "either build it yourself or download the binaries from Maven Central" > > Regards... Dominik. > > On Fri, Sep 22, 2023 at 9:26 PM Tim Allison wrote: > >> +1 >> >> Reports are here: There's surprisingly little difference: >> https://corpora.tika.apache.org/base/reports/poi-reports.tgz >> >> I only had time to glance briefly. >> >> Thank you PJ and team! >> >> On Fri, Sep 22, 2023 at 4:09 AM PJ Fanning >> wrote: >> >> > Thanks Alex. The pdfbox issue is tracked at >> > https://bz.apache.org/bugzilla/show_bug.cgi?id=67023 and includes a >> link >> > to what is blocking our upgrade. >> > >> > In terms of the version names of the jars - the ASF has a rule that you >> > must release what has been voted on. That means I can't create 5.2.4-RC1 >> > jars - get those voted on and then go off and rebuild 5.2.4 jars without >> > having those voted on. The jars are not in Maven Central yet, they are >> in a >> > staging area. Anyone who tests the staging jars will need to consider >> > cleaning out their local jar caches (e.g. their Maven local cache) after >> > they test the staging jars. Only a small number of POI reviewers will >> use >> > the staging jars. >> > >> > >> > >> > >> > >> > >> > On Friday 22 September 2023 at 04:05:48 IST, Axel Howind > > >> > wrote: >> > >> > >> > >> > >> > >> > +1 for the release. >> > >> > I just built and tested one of my own projects with the RC and >> everything >> > seems to work just fine. >> > >> > Two notes: >> > - I think release candidates should be published with an "rc“ in the >> > version string, something like "5.3.4-rc1“ because otherwise when a >> second >> > release candidate/the final release becomes available, Maven might stick >> > with the old rc build in the local .m2. >> > - pdfboc has been updated to 2.0.29. in the meantime, pdfbox released >> the >> > next major release (3.0.0), but I think switching to pdfbox 3 should be >> > more thoroughly tested and would rather be something for POI 5.3 >> > >> > > Am 21.09.2023 um 23:58 schrieb PJ Fanning : >> > > >> > > https://dist.apache.org/repos/dist/dev/poi/RELEASE-NOTES-5.2.4.txt >> > >> > - >> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org >> > For additional commands, e-mail: dev-h...@poi.apache.org >> > >> > >> >
Re: [VOTE] Release Apache POI 5.2.4 (RC1)
Hi, +1 from me, thanks P.J.! Large-scale regression testing looks good, only very very few regressions for more than 3mio documents ( ~0.02% ), most are caused by slightly stricter handling (more than 1000 compressed files, more than 300 nested children), a few remaining cases which we can take a look after release. Results are at http://people.apache.org/~centic/poi_regression/reports/index523RC1to524RC1.html and http://people.apache.org/~centic/poi_regression/reportsAll/index523RC1to524RC1.html Difference between source-packages from 5.2.3 and 5.2.4 looks good. Building from sources works locally. Upgrading projects to 5.2.4RC1 from the staging Maven repository did work fine, all tests passing. I added a note in the changelog about the removed binary packages, but if possible we should also add a bit more description about this in the announcement email. I think it may disrupt how some people integrate poi and thus may be worth to note in the release notes/announcement as well. I.e. "either build it yourself or download the binaries from Maven Central" Regards... Dominik. On Fri, Sep 22, 2023 at 9:26 PM Tim Allison wrote: > +1 > > Reports are here: There's surprisingly little difference: > https://corpora.tika.apache.org/base/reports/poi-reports.tgz > > I only had time to glance briefly. > > Thank you PJ and team! > > On Fri, Sep 22, 2023 at 4:09 AM PJ Fanning > wrote: > > > Thanks Alex. The pdfbox issue is tracked at > > https://bz.apache.org/bugzilla/show_bug.cgi?id=67023 and includes a link > > to what is blocking our upgrade. > > > > In terms of the version names of the jars - the ASF has a rule that you > > must release what has been voted on. That means I can't create 5.2.4-RC1 > > jars - get those voted on and then go off and rebuild 5.2.4 jars without > > having those voted on. The jars are not in Maven Central yet, they are > in a > > staging area. Anyone who tests the staging jars will need to consider > > cleaning out their local jar caches (e.g. their Maven local cache) after > > they test the staging jars. Only a small number of POI reviewers will use > > the staging jars. > > > > > > > > > > > > > > On Friday 22 September 2023 at 04:05:48 IST, Axel Howind > > wrote: > > > > > > > > > > > > +1 for the release. > > > > I just built and tested one of my own projects with the RC and everything > > seems to work just fine. > > > > Two notes: > > - I think release candidates should be published with an "rc“ in the > > version string, something like "5.3.4-rc1“ because otherwise when a > second > > release candidate/the final release becomes available, Maven might stick > > with the old rc build in the local .m2. > > - pdfboc has been updated to 2.0.29. in the meantime, pdfbox released the > > next major release (3.0.0), but I think switching to pdfbox 3 should be > > more thoroughly tested and would rather be something for POI 5.3 > > > > > Am 21.09.2023 um 23:58 schrieb PJ Fanning : > > > > > > https://dist.apache.org/repos/dist/dev/poi/RELEASE-NOTES-5.2.4.txt > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > > For additional commands, e-mail: dev-h...@poi.apache.org > > > > >
Re: [VOTE] Release Apache POI 5.2.4 (RC1)
+1 Reports are here: There's surprisingly little difference: https://corpora.tika.apache.org/base/reports/poi-reports.tgz I only had time to glance briefly. Thank you PJ and team! On Fri, Sep 22, 2023 at 4:09 AM PJ Fanning wrote: > Thanks Alex. The pdfbox issue is tracked at > https://bz.apache.org/bugzilla/show_bug.cgi?id=67023 and includes a link > to what is blocking our upgrade. > > In terms of the version names of the jars - the ASF has a rule that you > must release what has been voted on. That means I can't create 5.2.4-RC1 > jars - get those voted on and then go off and rebuild 5.2.4 jars without > having those voted on. The jars are not in Maven Central yet, they are in a > staging area. Anyone who tests the staging jars will need to consider > cleaning out their local jar caches (e.g. their Maven local cache) after > they test the staging jars. Only a small number of POI reviewers will use > the staging jars. > > > > > > > On Friday 22 September 2023 at 04:05:48 IST, Axel Howind > wrote: > > > > > > +1 for the release. > > I just built and tested one of my own projects with the RC and everything > seems to work just fine. > > Two notes: > - I think release candidates should be published with an "rc“ in the > version string, something like "5.3.4-rc1“ because otherwise when a second > release candidate/the final release becomes available, Maven might stick > with the old rc build in the local .m2. > - pdfboc has been updated to 2.0.29. in the meantime, pdfbox released the > next major release (3.0.0), but I think switching to pdfbox 3 should be > more thoroughly tested and would rather be something for POI 5.3 > > > Am 21.09.2023 um 23:58 schrieb PJ Fanning : > > > > https://dist.apache.org/repos/dist/dev/poi/RELEASE-NOTES-5.2.4.txt > > - > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > For additional commands, e-mail: dev-h...@poi.apache.org > >
Re: [VOTE] Release Apache POI 5.2.4 (RC1)
Thanks Alex. The pdfbox issue is tracked at https://bz.apache.org/bugzilla/show_bug.cgi?id=67023 and includes a link to what is blocking our upgrade. In terms of the version names of the jars - the ASF has a rule that you must release what has been voted on. That means I can't create 5.2.4-RC1 jars - get those voted on and then go off and rebuild 5.2.4 jars without having those voted on. The jars are not in Maven Central yet, they are in a staging area. Anyone who tests the staging jars will need to consider cleaning out their local jar caches (e.g. their Maven local cache) after they test the staging jars. Only a small number of POI reviewers will use the staging jars. On Friday 22 September 2023 at 04:05:48 IST, Axel Howind wrote: +1 for the release. I just built and tested one of my own projects with the RC and everything seems to work just fine. Two notes: - I think release candidates should be published with an "rc“ in the version string, something like "5.3.4-rc1“ because otherwise when a second release candidate/the final release becomes available, Maven might stick with the old rc build in the local .m2. - pdfboc has been updated to 2.0.29. in the meantime, pdfbox released the next major release (3.0.0), but I think switching to pdfbox 3 should be more thoroughly tested and would rather be something for POI 5.3 > Am 21.09.2023 um 23:58 schrieb PJ Fanning : > > https://dist.apache.org/repos/dist/dev/poi/RELEASE-NOTES-5.2.4.txt - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
Re: [VOTE] Release Apache POI 5.2.4 (RC1)
+1 for the release. I just built and tested one of my own projects with the RC and everything seems to work just fine. Two notes: - I think release candidates should be published with an "rc“ in the version string, something like "5.3.4-rc1“ because otherwise when a second release candidate/the final release becomes available, Maven might stick with the old rc build in the local .m2. - pdfboc has been updated to 2.0.29. in the meantime, pdfbox released the next major release (3.0.0), but I think switching to pdfbox 3 should be more thoroughly tested and would rather be something for POI 5.3 > Am 21.09.2023 um 23:58 schrieb PJ Fanning : > > https://dist.apache.org/repos/dist/dev/poi/RELEASE-NOTES-5.2.4.txt
