[jira] [Created] (DISPATCH-109) Support parsing of the Subject field from the message properties

2015-02-02 Thread Ken Giusti (JIRA)
Ken Giusti created DISPATCH-109:
---

 Summary: Support parsing of the Subject field from the message 
properties
 Key: DISPATCH-109
 URL: https://issues.apache.org/jira/browse/DISPATCH-109
 Project: Qpid Dispatch
  Issue Type: New Feature
  Components: Routing Engine
Affects Versions: 0.3
Reporter: Ken Giusti
Assignee: Ken Giusti
 Fix For: 0.4


Update the message header parsing logic to allow the extraction of the subject 
field from the message properties.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-109) Support parsing of the Subject field from the message properties

2015-02-02 Thread Ken Giusti (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301893#comment-14301893
 ] 

Ken Giusti commented on DISPATCH-109:
-

Proposed patch:

https://github.com/apache/dispatch/pull/3


 Support parsing of the Subject field from the message properties
 

 Key: DISPATCH-109
 URL: https://issues.apache.org/jira/browse/DISPATCH-109
 Project: Qpid Dispatch
  Issue Type: New Feature
  Components: Routing Engine
Affects Versions: 0.3
Reporter: Ken Giusti
Assignee: Ken Giusti
 Fix For: 0.4


 Update the message header parsing logic to allow the extraction of the 
 subject field from the message properties.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6341) [Java Broker] Enhancements to config object meta data model

2015-02-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301898#comment-14301898
 ] 

ASF subversion and git services commented on QPID-6341:
---

Commit 1656566 from [~godfrer] in branch 'qpid/trunk'
[ https://svn.apache.org/r1656566 ]

QPID-6341 : Add test and allow a default alt text for oversized values

 [Java Broker] Enhancements to config object meta data model
 ---

 Key: QPID-6341
 URL: https://issues.apache.org/jira/browse/QPID-6341
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Rob Godfrey
Assignee: Rob Godfrey
 Fix For: 0.31


 The config model meta data should allow for the following additional features:
 ManagedObjects should be able to define a description as well as a name - 
 this description may be used in UI drop downs, etc
 ManagedObjects should be able to be marked as deprecated in order to exclude 
 them from the UI if desired
 Attributes should be able to be marked as oversized that is they may 
 contain a potentially very large value, and the RestServlet may choose to 
 truncate the value (based on a parameter in the servlet request).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Review Request 30526: DISPATCH-109: add parsing of subject field

2015-02-02 Thread Kenneth Giusti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30526/
---

Review request for qpid, Alan Conway and Ted Ross.


Bugs: DISPATCH-109
https://issues.apache.org/jira/browse/DISPATCH-109


Repository: qpid-dispatch


Description
---

Refactor the field parse logic.  Avoid re-parsing fields previous to the target 
field.  My understanding of the existing field parsing code may be a littled 
flawed - please let me know if you see anything that doesn't make sense or 
seems sub-optimal.


Diffs
-

  trunk/include/qpid/dispatch/message.h 1656496 
  trunk/src/message.c 1656496 
  trunk/src/message_private.h 1656496 
  trunk/tests/message_test.c 1656496 

Diff: https://reviews.apache.org/r/30526/diff/


Testing
---

Added a new unit test.


Thanks,

Kenneth Giusti



[jira] [Updated] (QPID-6341) [Java Broker] Enhancements to config object meta data model

2015-02-02 Thread Rob Godfrey (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-6341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey updated QPID-6341:
--
Status: Reviewable  (was: In Progress)

 [Java Broker] Enhancements to config object meta data model
 ---

 Key: QPID-6341
 URL: https://issues.apache.org/jira/browse/QPID-6341
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Rob Godfrey
Assignee: Rob Godfrey
 Fix For: 0.31


 The config model meta data should allow for the following additional features:
 ManagedObjects should be able to define a description as well as a name - 
 this description may be used in UI drop downs, etc
 ManagedObjects should be able to be marked as deprecated in order to exclude 
 them from the UI if desired
 Attributes should be able to be marked as oversized that is they may 
 contain a potentially very large value, and the RestServlet may choose to 
 truncate the value (based on a parameter in the servlet request).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-6) Implement link-routing

2015-02-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301265#comment-14301265
 ] 

ASF subversion and git services commented on DISPATCH-6:


Commit 1656457 from [~tedross] in branch 'dispatch/trunk'
[ https://svn.apache.org/r1656457 ]

DISPATCH-6 - Completed link-detach propagation.

 Implement link-routing
 --

 Key: DISPATCH-6
 URL: https://issues.apache.org/jira/browse/DISPATCH-6
 Project: Qpid Dispatch
  Issue Type: New Feature
Reporter: Ted Ross
Assignee: Ted Ross
 Fix For: 0.4


 All routing is done at the message-delivery level in Dispatch.
 Implement link routing (at the link-attach level) as an alternative mechanism.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-5538) [amqp1.0] Generate keep-alive frames for peers using idle timeout

2015-02-02 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301277#comment-14301277
 ] 

Justin Ross commented on QPID-5538:
---

https://reviews.apache.org/r/30206/

 [amqp1.0] Generate keep-alive frames for peers using idle timeout
 -

 Key: QPID-5538
 URL: https://issues.apache.org/jira/browse/QPID-5538
 Project: Qpid
  Issue Type: Improvement
  Components: C++ Broker
Affects Versions: 0.26
Reporter: Ken Giusti
Assignee: Ken Giusti
 Fix For: 0.31


 When establishing an AMQP 1.0 connection, an endpoint may elect to use an 
 idle link timeout.  This timeout is advertised to the peer in the Open frame.
 The recipient of the advertised timeout should either:
 1) Close the connection if the idle timeout cannot be honored, or
 2) guarantee it will generate traffic frequently enough to prevent the peer 
 from timing out simply because there is no data to transfer.
 Currently, qpidd does neither - it simply ignores the timeout.  This will 
 cause the peer to incorrectly drop the link should no data become available 
 on the broker within the advertised idle time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Re: Review Request 30206: QPID-5538: heartbeats on AMQP 1.0

2015-02-02 Thread Gordon Sim

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30206/#review70569
---

Ship it!


Ship It!

- Gordon Sim


On Jan. 27, 2015, 1:28 a.m., Kenneth Giusti wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30206/
 ---
 
 (Updated Jan. 27, 2015, 1:28 a.m.)
 
 
 Review request for qpid and Gordon Sim.
 
 
 Bugs: QPID-5538
 https://issues.apache.org/jira/browse/QPID-5538
 
 
 Repository: qpid
 
 
 Description
 ---
 
 Minor tweak to Gordon's original patch
 
 
 Diffs
 -
 
   trunk/qpid/cpp/src/qpid/broker/amqp/Connection.h 1653631 
   trunk/qpid/cpp/src/qpid/broker/amqp/Connection.cpp 1653631 
   trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.h 1653631 
   trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.cpp 1653631 
   trunk/qpid/cpp/src/qpid/messaging/amqp/DriverImpl.h 1653631 
   trunk/qpid/cpp/src/qpid/messaging/amqp/DriverImpl.cpp 1653631 
   trunk/qpid/cpp/src/qpid/messaging/amqp/Transport.h 1653631 
   trunk/qpid/cpp/src/tests/CMakeLists.txt 1653631 
   trunk/qpid/cpp/src/tests/idle_timeout_tests.py PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/30206/diff/
 
 
 Testing
 ---
 
 Unit tests pass.  Manually SIGSTOP the broker and the client to trigger the 
 timeout.
 
 
 Thanks,
 
 Kenneth Giusti
 




[jira] [Updated] (QPID-6346) [Java Broker] Add UI for uploading of pem/der keys and certificates for non-java keystores/truststores into web management console

2015-02-02 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-6346:
-
Status: Reviewable  (was: In Progress)

 [Java Broker] Add UI for uploading of pem/der keys and certificates for 
 non-java keystores/truststores into web management console
 --

 Key: QPID-6346
 URL: https://issues.apache.org/jira/browse/QPID-6346
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Alex Rudyy
Assignee: Alex Rudyy
 Fix For: 0.31


  Add UI for uploading of pem/der keys and certificates for non-java 
 keystores/truststores into web management console



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6346) [Java Broker] Add UI for uploading of pem/der keys and certificates for non-java keystores/truststores into web management console

2015-02-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301337#comment-14301337
 ] 

ASF subversion and git services commented on QPID-6346:
---

Commit 1656477 from oru...@apache.org in branch 'qpid/trunk'
[ https://svn.apache.org/r1656477 ]

QPID-6346: Improve field labels and prompt messages in UI for non java 
keystores/truststores, display timezone for certificate start/end time

 [Java Broker] Add UI for uploading of pem/der keys and certificates for 
 non-java keystores/truststores into web management console
 --

 Key: QPID-6346
 URL: https://issues.apache.org/jira/browse/QPID-6346
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Alex Rudyy
Assignee: Alex Rudyy
 Fix For: 0.31


  Add UI for uploading of pem/der keys and certificates for non-java 
 keystores/truststores into web management console



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (QPID-6346) [Java Broker] Add UI for uploading of pem/der keys and certificates for non-java keystores/truststores into web management console

2015-02-02 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reassigned QPID-6346:


Assignee: Keith Wall  (was: Alex Rudyy)

 [Java Broker] Add UI for uploading of pem/der keys and certificates for 
 non-java keystores/truststores into web management console
 --

 Key: QPID-6346
 URL: https://issues.apache.org/jira/browse/QPID-6346
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Alex Rudyy
Assignee: Keith Wall
 Fix For: 0.31


  Add UI for uploading of pem/der keys and certificates for non-java 
 keystores/truststores into web management console



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6346) [Java Broker] Add UI for uploading of pem/der keys and certificates for non-java keystores/truststores into web management console

2015-02-02 Thread Alex Rudyy (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301340#comment-14301340
 ] 

Alex Rudyy commented on QPID-6346:
--

Keith,
I addressed your comments in the commit under revision 
[r1656477|https://svn.apache.org/r1656477]. Please, review

 [Java Broker] Add UI for uploading of pem/der keys and certificates for 
 non-java keystores/truststores into web management console
 --

 Key: QPID-6346
 URL: https://issues.apache.org/jira/browse/QPID-6346
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Alex Rudyy
Assignee: Alex Rudyy
 Fix For: 0.31


  Add UI for uploading of pem/der keys and certificates for non-java 
 keystores/truststores into web management console



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-5538) [amqp1.0] Generate keep-alive frames for peers using idle timeout

2015-02-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301402#comment-14301402
 ] 

ASF subversion and git services commented on QPID-5538:
---

Commit 1656505 from [~kgiusti] in branch 'qpid/trunk'
[ https://svn.apache.org/r1656505 ]

QPID-5538: Implement AMQP 1.0 connection idle-timeout.

Original patch by Gordon Sim.

 [amqp1.0] Generate keep-alive frames for peers using idle timeout
 -

 Key: QPID-5538
 URL: https://issues.apache.org/jira/browse/QPID-5538
 Project: Qpid
  Issue Type: Improvement
  Components: C++ Broker
Affects Versions: 0.26
Reporter: Ken Giusti
Assignee: Ken Giusti
 Fix For: 0.31


 When establishing an AMQP 1.0 connection, an endpoint may elect to use an 
 idle link timeout.  This timeout is advertised to the peer in the Open frame.
 The recipient of the advertised timeout should either:
 1) Close the connection if the idle timeout cannot be honored, or
 2) guarantee it will generate traffic frequently enough to prevent the peer 
 from timing out simply because there is no data to transfer.
 Currently, qpidd does neither - it simply ignores the timeout.  This will 
 cause the peer to incorrectly drop the link should no data become available 
 on the broker within the advertised idle time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-108) Identify settable, updatable and read-only attributes in management schema.

2015-02-02 Thread Alan Conway (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway resolved DISPATCH-108.
--
Resolution: Fixed

 Identify settable,  updatable and read-only attributes in management schema.
 

 Key: DISPATCH-108
 URL: https://issues.apache.org/jira/browse/DISPATCH-108
 Project: Qpid Dispatch
  Issue Type: Improvement
  Components: Management Agent
Affects Versions: 0.3
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.4


 The schema should identify which attributes can be set at entity creation, 
 which can be updated with an UPDATE operation and which are read-only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (DISPATCH-103) Websocket Listeners

2015-02-02 Thread Alan Conway (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway reassigned DISPATCH-103:


Assignee: Alan Conway

 Websocket Listeners
 ---

 Key: DISPATCH-103
 URL: https://issues.apache.org/jira/browse/DISPATCH-103
 Project: Qpid Dispatch
  Issue Type: New Feature
  Components: Container
Reporter: Ted Ross
Assignee: Alan Conway
 Fix For: 0.5


 Add an option in configured listeners to use websockets encapsulation.  This 
 will allow AMQP clients inside web browsers to directly connect to the 
 message bus.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-103) Websocket Listeners

2015-02-02 Thread Alan Conway (JIRA)

[ 
https://issues.apache.org/jira/browse/DISPATCH-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301408#comment-14301408
 ] 

Alan Conway commented on DISPATCH-103:
--

This commit should say DISPATCH-102

 Websocket Listeners
 ---

 Key: DISPATCH-103
 URL: https://issues.apache.org/jira/browse/DISPATCH-103
 Project: Qpid Dispatch
  Issue Type: New Feature
  Components: Container
Reporter: Ted Ross
Assignee: Alan Conway
 Fix For: 0.5


 Add an option in configured listeners to use websockets encapsulation.  This 
 will allow AMQP clients inside web browsers to directly connect to the 
 message bus.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-5538) [amqp1.0] Generate keep-alive frames for peers using idle timeout

2015-02-02 Thread Ken Giusti (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ken Giusti resolved QPID-5538.
--
Resolution: Fixed

 [amqp1.0] Generate keep-alive frames for peers using idle timeout
 -

 Key: QPID-5538
 URL: https://issues.apache.org/jira/browse/QPID-5538
 Project: Qpid
  Issue Type: Improvement
  Components: C++ Broker
Affects Versions: 0.26
Reporter: Ken Giusti
Assignee: Ken Giusti
 Fix For: 0.31


 When establishing an AMQP 1.0 connection, an endpoint may elect to use an 
 idle link timeout.  This timeout is advertised to the peer in the Open frame.
 The recipient of the advertised timeout should either:
 1) Close the connection if the idle timeout cannot be honored, or
 2) guarantee it will generate traffic frequently enough to prevent the peer 
 from timing out simply because there is no data to transfer.
 Currently, qpidd does neither - it simply ignores the timeout.  This will 
 cause the peer to incorrectly drop the link should no data become available 
 on the broker within the advertised idle time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Re: Review Request 30379: Skeleton code for a possible approach for codec improvements in proton-j.

2015-02-02 Thread rajith attapattu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30379/
---

(Updated Feb. 2, 2015, 6:38 p.m.)


Review request for qpid and Rafael Schloming.


Repository: qpid-proton-git


Description
---

Skeleton code for a possible approach for codec improvements in proton-j.


Diffs (updated)
-

  proton-j/src/main/java/org/apache/qpid/proton/amqp/transport2/Flow.java 
388cbef 
  proton-j/src/main/java/org/apache/qpid/proton/codec2/DecodeException.java 
PRE-CREATION 
  proton-j/src/main/java/org/apache/qpid/proton/codec2/Decoder.java d61fdef 
  proton-j/src/main/java/org/apache/qpid/proton/codec2/Encodable.java 
PRE-CREATION 
  proton-j/src/main/java/org/apache/qpid/proton/codec2/POJOBuilder.java c95844b 
  proton-j/src/main/java/org/apache/qpid/proton/codec2/PerformativeFactory.java 
PRE-CREATION 
  
proton-j/src/main/java/org/apache/qpid/proton/codec2/TransportTypesDecoder.java 
a262760 
  
proton-j/src/main/java/org/apache/qpid/proton/codec2/TransportTypesEncoder.java 
c7c888c 
  proton-j/src/main/java/org/apache/qpid/proton/codec2/TypeRegistry.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/30379/diff/


Testing
---


Thanks,

rajith attapattu



Re: Review Request 30379: Skeleton code for a possible approach for codec improvements in proton-j.

2015-02-02 Thread Rafael Schloming

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30379/#review70627
---



proton-j/src/main/java/org/apache/qpid/proton/amqp/transport2/Flow.java
https://reviews.apache.org/r/30379/#comment115893

I'm not sure we should do this kind of validation here. This is really a 
semantic check, I would stick to just syntactic checks in the decode, e.g. if 
you get a String where you expect an int or something like that.

I would put the sort of semantic check you have here in a separate method 
since it would be useful to be able to a) omit it at runtime for performance 
reasons, and b) it would also be useful to perform the same validation prior to 
encoding.



proton-j/src/main/java/org/apache/qpid/proton/codec2/POJOBuilder.java
https://reviews.apache.org/r/30379/#comment115889

This should probably be moved out into a top level class, I think I just 
had it nested for conciseness.



proton-j/src/main/java/org/apache/qpid/proton/codec2/PerformativeFactory.java
https://reviews.apache.org/r/30379/#comment115887

PerformativeFactory is a bit over specific for the name of this. It can 
really work on any described type and we will need to use it for things nested 
inside of performatives also (like error conditions, etc). Maybe 
DescribedFactory?



proton-j/src/main/java/org/apache/qpid/proton/codec2/TypeRegistry.java
https://reviews.apache.org/r/30379/#comment115886

DescriptorRegistry might be a bit more precise as a name for this


- Rafael Schloming


On Feb. 2, 2015, 6:38 p.m., rajith attapattu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30379/
 ---
 
 (Updated Feb. 2, 2015, 6:38 p.m.)
 
 
 Review request for qpid and Rafael Schloming.
 
 
 Repository: qpid-proton-git
 
 
 Description
 ---
 
 Skeleton code for a possible approach for codec improvements in proton-j.
 
 
 Diffs
 -
 
   proton-j/src/main/java/org/apache/qpid/proton/amqp/transport2/Flow.java 
 388cbef 
   proton-j/src/main/java/org/apache/qpid/proton/codec2/DecodeException.java 
 PRE-CREATION 
   proton-j/src/main/java/org/apache/qpid/proton/codec2/Decoder.java d61fdef 
   proton-j/src/main/java/org/apache/qpid/proton/codec2/Encodable.java 
 PRE-CREATION 
   proton-j/src/main/java/org/apache/qpid/proton/codec2/POJOBuilder.java 
 c95844b 
   
 proton-j/src/main/java/org/apache/qpid/proton/codec2/PerformativeFactory.java 
 PRE-CREATION 
   
 proton-j/src/main/java/org/apache/qpid/proton/codec2/TransportTypesDecoder.java
  a262760 
   
 proton-j/src/main/java/org/apache/qpid/proton/codec2/TransportTypesEncoder.java
  c7c888c 
   proton-j/src/main/java/org/apache/qpid/proton/codec2/TypeRegistry.java 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/30379/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 rajith attapattu
 




Re: Review Request 30379: Skeleton code for a possible approach for codec improvements in proton-j.

2015-02-02 Thread rajith attapattu


 On Feb. 2, 2015, 9:41 p.m., Rafael Schloming wrote:
  proton-j/src/main/java/org/apache/qpid/proton/amqp/transport2/Flow.java, 
  line 217
  https://reviews.apache.org/r/30379/diff/2/?file=843887#file843887line217
 
  I'm not sure we should do this kind of validation here. This is really 
  a semantic check, I would stick to just syntactic checks in the decode, 
  e.g. if you get a String where you expect an int or something like that.
  
  I would put the sort of semantic check you have here in a separate 
  method since it would be useful to be able to a) omit it at runtime for 
  performance reasons, and b) it would also be useful to perform the same 
  validation prior to encoding.

I see your logic in having the semantic checks on it's own and being able to 
use on both encoding and decoding.

But when do you envision this to be called during decoding? I want to 
understand what you meant by omit it at runtime for performance reasons.


- rajith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30379/#review70627
---


On Feb. 2, 2015, 6:38 p.m., rajith attapattu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30379/
 ---
 
 (Updated Feb. 2, 2015, 6:38 p.m.)
 
 
 Review request for qpid and Rafael Schloming.
 
 
 Repository: qpid-proton-git
 
 
 Description
 ---
 
 Skeleton code for a possible approach for codec improvements in proton-j.
 
 
 Diffs
 -
 
   proton-j/src/main/java/org/apache/qpid/proton/amqp/transport2/Flow.java 
 388cbef 
   proton-j/src/main/java/org/apache/qpid/proton/codec2/DecodeException.java 
 PRE-CREATION 
   proton-j/src/main/java/org/apache/qpid/proton/codec2/Decoder.java d61fdef 
   proton-j/src/main/java/org/apache/qpid/proton/codec2/Encodable.java 
 PRE-CREATION 
   proton-j/src/main/java/org/apache/qpid/proton/codec2/POJOBuilder.java 
 c95844b 
   
 proton-j/src/main/java/org/apache/qpid/proton/codec2/PerformativeFactory.java 
 PRE-CREATION 
   
 proton-j/src/main/java/org/apache/qpid/proton/codec2/TransportTypesDecoder.java
  a262760 
   
 proton-j/src/main/java/org/apache/qpid/proton/codec2/TransportTypesEncoder.java
  c7c888c 
   proton-j/src/main/java/org/apache/qpid/proton/codec2/TypeRegistry.java 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/30379/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 rajith attapattu
 




[jira] [Commented] (QPID-6351) [Java Broker] Remove provider name from edit UI, remove button Add Preferences Provider from Authentication provider tab and fix disabled preferences provider fields

2015-02-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301503#comment-14301503
 ] 

ASF subversion and git services commented on QPID-6351:
---

Commit 1656522 from oru...@apache.org in branch 'qpid/trunk'
[ https://svn.apache.org/r1656522 ]

QPID-6351: Fix preferences provider widget to update UI every time on setting 
or loading data

 [Java Broker] Remove provider name from edit UI, remove button Add 
 Preferences Provider from Authentication provider tab and fix disabled  
 preferences provider fields in Add Authentication provider dialog
 --

 Key: QPID-6351
 URL: https://issues.apache.org/jira/browse/QPID-6351
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Affects Versions: 0.30
Reporter: Alex Rudyy
Assignee: Alex Rudyy
 Fix For: 0.31

 Attachments: lostprefproviderpath.png


 Remediate the following issues found in AP UI:
 * Preferences provider fields are disabled in Add Authentication provider 
 dialog
 * Remove preferences provider name from add/edit UI
 *Remove button Add Preferences Provider from Authentication provider tab



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org