[jira] [Commented] (PROTON-1762) [ruby] gem does not contain examples or tests

2018-02-14 Thread Alan Conway (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364770#comment-16364770
 ] 

Alan Conway commented on PROTON-1762:
-

Also should allow building the gem *without* the C library. Building the C 
library creates false dependencies in RPMs that contain only the Gem.

> [ruby] gem does not contain examples or tests
> -
>
> Key: PROTON-1762
> URL: https://issues.apache.org/jira/browse/PROTON-1762
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: ruby-binding
>Affects Versions: proton-c-0.20.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.21.0
>
>
> The ruby gem created by cmake does not include example files or tests. 
> The example sources should be included as part of the documentation and 
> linked from the README.
>  
> The tests should be included as per: 
> http://guides.rubygems.org/make-your-own-gem/#writing-tests



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Closed] (PROTON-1761) [ruby-binding] proton-c/bindings/ruby/cprotonRUBY_wrap.c:2166:26: warning: implicit declaration of function ‘rb_thread_call_without_gvl’ [-Wimplicit-function-declaration]

2018-02-14 Thread Alan Conway (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PROTON-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway closed PROTON-1761.
---
Resolution: Duplicate

Fixed by commit 9a8f9f59 PROTON-1738: [ruby] Fix compile warnings in SWIG source

> [ruby-binding] proton-c/bindings/ruby/cprotonRUBY_wrap.c:2166:26: warning: 
> implicit declaration of function ‘rb_thread_call_without_gvl’ 
> [-Wimplicit-function-declaration]
> --
>
> Key: PROTON-1761
> URL: https://issues.apache.org/jira/browse/PROTON-1761
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
> Environment: ruby 2.0.0p648 (2015-12-16) [x86_64-linux]
>Reporter: Jiri Daněk
>Assignee: Alan Conway
>Priority: Minor
> Fix For: proton-c-0.21.0
>
>
> https://issues.apache.org/jira/issues/?jql=text%20~%20%22rb_thread_call_without_gvl%22
> {noformat}
> $ ninja -j4 install
> [214/269] Building C object 
> proton-c/bindings/ruby/CMakeFiles/cproton-ruby.dir/cprotonRUBY_wrap.c.o
> proton-c/bindings/ruby/cprotonRUBY_wrap.c: In function 
> ‘wrap_pn_messenger_send’:
> proton-c/bindings/ruby/cprotonRUBY_wrap.c:2166:26: warning: implicit 
> declaration of function ‘rb_thread_call_without_gvl’ 
> [-Wimplicit-function-declaration]
>  #define RB_BLOCKING_CALL rb_thread_call_without_gvl
>   ^
> proton-c/bindings/ruby/cprotonRUBY_wrap.c:2227:12: note: in expansion of 
> macro ‘RB_BLOCKING_CALL’
>rc = RB_BLOCKING_CALL(pn_messenger_send_no_gvl,
> ^~~~
> [216/269] Generating qpid_proton-0.21.0.gem
>   Successfully built RubyGem
>   Name: qpid_proton
>   Version: 0.21.0
>   File: qpid_proton-0.21.0.gem
> {noformat}
> {noformat}
> $ git log
> commit ae3eaaa2e2351b29c23825d141ac9b5ba17cbdf6 (upstream/master)
> Author: Kim van der Riet 
> Date:   Fri Feb 2 16:53:33 2018 -0500
> PROTON-1758: Change message application properties that are binary to 
> unicode string; raise error for other key types.
> {noformat}
> {noformat}
> $ ruby --version
> ruby 2.0.0p648 (2015-12-16) [x86_64-linux]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8083) [REST] Refactor REST system test suite

2018-02-14 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364436#comment-16364436
 ] 

ASF subversion and git services commented on QPID-8083:
---

Commit 7851928d030754066034bd225084addcbf332d66 in qpid-broker-j's branch 
refs/heads/master from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=7851928 ]

QPID-8083 [System Tests] [REST/HTTP] Remove keystores/trusts stores left behind 
by the test


> [REST] Refactor REST system test suite
> --
>
> Key: QPID-8083
> URL: https://issues.apache.org/jira/browse/QPID-8083
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Keith Wall
>Priority: Major
>
> REST is an orthogonal concern within the Broker.  It should be possible for 
> developers of the Broker to easily exclude REST tests from test runs whilst 
> developing other parts of the Broker.  To allow for this, the REST test suite 
> should be separate.
> Also many of the current tests are very repetitious in nature.  Currently 
> each model object is subjected to its own REST test merely testing that model 
> attributes are available over REST, pointlessly retesting the same piece of 
> common mechanism code over and over again.  Such tests should be eliminated.
> Tests that remain should focus on REST concerns such as:
>  * CRUD model access
>  * Model operations
>  * SASL and Preemptive Authentication
>  * Compression/Decompression
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8038) [Broker-J][System Tests] Add protocol system test suites for AMQP 0-x

2018-02-14 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364438#comment-16364438
 ] 

ASF subversion and git services commented on QPID-8038:
---

Commit a827841b24b22cd21f0ca6523da00093f2a26669 in qpid-broker-j's branch 
refs/heads/master from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=a827841 ]

QPID-8038: [Broker-J] [AMQP 0-10] Add a protocol test supporting explicit 
message acquision


> [Broker-J][System Tests] Add protocol system test suites for AMQP 0-x
> -
>
> Key: QPID-8038
> URL: https://issues.apache.org/jira/browse/QPID-8038
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J, Java Tests
>Reporter: Alex Rudyy
>Priority: Major
>
> We need a test frameworks which would allow creation of tests which would be 
> sending the AMQP 0-x performatives over TCP and receiving and asserting 
> broker responses.
> The framework should satisfy the following requirements:
> * It should allow running tests against other AMQP brokers
> * The framework should encapsulate starting/stopping of broker and queue 
> creation/deletion under special interface(s) which can be implemented by the 
> Broker developers in order to run tests against different Broker 
> implementations
> * Tests should be able to start and stop broker if required or configured
> * Tests should be able to generate AMQP performatives and assert received 
> peer's AMQP performatives
> * The framework should allow using other transport than TCP if required
> * The framework should be based on AMQP 0-x  implementations of Broker-J



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-8098) [Broker-J] [AMQP 0-10] Queue browsers erroneously increment the delivery count

2018-02-14 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364437#comment-16364437
 ] 

ASF subversion and git services commented on QPID-8098:
---

Commit a6408e156a717e8e91aa95e3220ed300c71c52bd in qpid-broker-j's branch 
refs/heads/master from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=a6408e1 ]

QPID-8098: [Broker-J] [AMQP 0-10] No longer unconditionally increment 
deliveryCount when MessageAcquireMode.NOT_ACQUIRED


> [Broker-J] [AMQP 0-10] Queue browsers erroneously increment the delivery count
> --
>
> Key: QPID-8098
> URL: https://issues.apache.org/jira/browse/QPID-8098
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: 0.30, 0.32, qpid-java-6.0, qpid-java-6.1, 
> qpid-java-broker-7.0.0
>Reporter: Keith Wall
>Priority: Major
>
> On the AMQP 0-10 protocol path within the Broker, deliveries to queue 
> browsers erroneously increase the {{MessageInstance#deliveryCount}}.  This 
> should not happen.  The purpose of the delivery count is to count deliveries 
> to (destructive) consumers - not browsers.  The problem is restricted to AMQP 
> 0-10 implementation.  Neither AMQP 0-x nor AMQP 1.0 are affected by this 
> defect.
> The defect could mean that messages are spuriously routed to a DLQ (if 
> configured).  For this to happen, there would need to be additional 
> destructive consumers on the queue that cause the message to be 'released'.  
> Releasing occurs during transaction rollback and client disconnection (when 
> messages are prefetched).   The message would be prematurely routed to the 
> DLQ in this case.
> The defect is longstanding.  I tested as far back as 0.30.
> https://mail-archives.apache.org/mod_mbox/qpid-users/201802.mbox/%3c1518546115789-0.p...@n2.nabble.com%3e



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (PROTON-1738) [ruby-binding] incompatible with ruby 2.0.0

2018-02-14 Thread Alan Conway (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PROTON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway resolved PROTON-1738.
-
Resolution: Fixed

Fixed and tested on 1.9.3, 2.0.0, 2.4.3. If we need compatibility further back 
than 1.9.3 then it probably can be done without too much pain, but I won't push 
it further unless there's a definite requirement. 1.9.3 seems a good place to 
stop, it is the oldest maintained  branch according to 
https://www.ruby-lang.org/en/downloads/branches/

> [ruby-binding] incompatible with ruby 2.0.0
> ---
>
> Key: PROTON-1738
> URL: https://issues.apache.org/jira/browse/PROTON-1738
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
>Affects Versions: proton-c-0.19.0
> Environment: 4dfe296920c9345dfbe8c9c535cbeb27055c01c2 
> (upstream/master)
> Author: Alan Conway 
> Date:   Thu Jan 4 12:47:25 2018 -0500
> PROTON-1706: fix compiler warnings in windows c examples
>Reporter: Jiri Daněk
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.21.0
>
> Attachments: 0001-WIP-Fix-for-issues-on-ruby-2.0.0.patch
>
>
> {noformat}
> $ ctest -VV -R ruby-example-test
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Test project /home/jdanek/Work/repos/qpid-proton/build
> Constructing a list of tests
> Done constructing a list of tests
> Updating test list for fixtures
> Added 0 tests to meet fixture requirements
> Checking test dependency graph...
> Checking test dependency graph end
> test 13
> Start 13: ruby-example-test
> 13: Test command: 
> /nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin/python 
> "/home/jdanek/Work/repos/qpid-proton/proton-c/env.py" "--" 
> "PATH=/nix/store/pgwzcwz3v13dm193iys78xajrxf7m9yq-include-what-you-use-0.8/bin:/nix/store/x9p1z5z22z59x88h7ap09s0f79w50nj0-krb5-1.15.2-dev/bin:/nix/store/0gpszn41jk1fdw98q1jdm7n4z271m303-krb5-1.15.2/bin:/nix/store/xmbal41hbh2z82jz7pgjgxkba9malcvf-gss-1.0.3/bin:/nix/store/qs68njxs4awvjaqf2yw89x8bnb2jwl2a-pkg-config-0.29.2/bin:/nix/store/bd1qnp2y4mni2jsr7yqfy45q5wj9q4wz-util-linux-2.31-bin/bin:/nix/store/s03sh263lrxnz8dp9d81is9xwrs67ay9-openssl-1.0.2n-bin/bin:/nix/store/0frzwaf62yrbs0ni6043sllk8ac7db1l-cmake-3.9.6/bin:/nix/store/q03ccdnb7i7za2q66gx8b3mii293i6cg-ninja-1.8.2/bin:/nix/store/2sb5s8wj4s6awvfd4rn82297g2fhr18d-gcc-wrapper-7.2.0/bin:/nix/store/gkasrgaqw2riqc8ck8hh3a9k06cqaqrd-gcc-7.2.0/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/m5s6hd02nlfywi9n3yrgrx3fa8kgp9jd-binutils-wrapper-2.28.1/bin:/nix/store/kcdiibhpjrbpash3r1bvj2ncv4rwr3sm-binutils-2.28.1/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/h5m0g1agfcyc2d5lql0n8z6fls261rnn-go-1.9.2/bin:/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin:/nix/store/10lvqls7vl68blvvv42g36bh5rjbwkmk-gdb-8.0.1/bin:/nix/store/11wq1ncfb8za0mnnficcizd53p1md2y7-swig-3.0.12/bin:/nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin:/nix/store/waf0wx7drw74pkig43ickd8bn540wbz6-cyrus-sasl-2.1.26-bin/bin:/nix/store/n7l459d0f28lmdirr1wlzkdi7151jhqk-patchelf-0.9/bin:/nix/store/q7p8jaiymb1k4n44l31xdm753j79h7l5-paxctl-0.9/bin:/nix/store/4cqv0dm94h2sm0xpcqi6h8z6bnxqqlna-gcc-wrapper-6.4.0/bin:/nix/store/d88s1v28v11j2jxshqdvqms6h0pvp8aw-gcc-6.4.0/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/n2p15qg4lxgq0xkfrgqqfgpwkmd3295d-findutils-4.6.0/bin:/nix/store/ajiwrzg6nz9xpifr91wp14cy8al7s4df-diffutils-3.6/bin:/nix/store/n5rsq2cxj7lp4gynkvqrp0xkf78f1ni6-gnused-4.4/bin:/nix/store/nwpv4sxayci7jkjq7fid8hwz6ig5xjzi-gnugrep-3.1/bin:/nix/store/w1cddj0qc3ximvpwrn28rig7wq99ajd7-gawk-4.2.0/bin:/nix/store/7iw6c6nx7spzsp92pqq5qnd7d8jvbdl8-gnutar-1.30/bin:/nix/store/qk11lqm8fz9hpk1682gyf3x51wwasj3z-gzip-1.8/bin:/nix/store/mi9vmy5nwc4ma33jz6ihrdhh1r6izzv6-bzip2-1.0.6.0.1-bin/bin:/nix/store/92cdms75qnqh3hf39wbxra60bxdah9mq-gnumake-4.2.1/bin:/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin:/nix/store/irwrb341fpqd2lj22j13ffsxcjhayv1m-patch-2.7.5/bin:/nix/store/8fy4c90a0cj1mw2xibvv5k6b0rxx6b09-xz-5.2.3-bin/bin:/home/jdanek/bin:/run/wrappers/bin:/etc/per-user-pkgs/jdanek/bin:/home/jdanek/.nix-profile/bin:/nix/var/nix/profiles/default/bin:/ru

[jira] [Commented] (PROTON-1738) [ruby-binding] incompatible with ruby 2.0.0

2018-02-14 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364407#comment-16364407
 ] 

ASF subversion and git services commented on PROTON-1738:
-

Commit 9a8f9f59a59d93d5bbe9755f3f893b47bf24aa76 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=9a8f9f5 ]

PROTON-1738: [ruby] Fix compile warnings in SWIG source

Correct feature checks to cover >= 2.0.0, fix compile warnings for 
RB_BLOCKING_CALL.


> [ruby-binding] incompatible with ruby 2.0.0
> ---
>
> Key: PROTON-1738
> URL: https://issues.apache.org/jira/browse/PROTON-1738
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
>Affects Versions: proton-c-0.19.0
> Environment: 4dfe296920c9345dfbe8c9c535cbeb27055c01c2 
> (upstream/master)
> Author: Alan Conway 
> Date:   Thu Jan 4 12:47:25 2018 -0500
> PROTON-1706: fix compiler warnings in windows c examples
>Reporter: Jiri Daněk
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.21.0
>
> Attachments: 0001-WIP-Fix-for-issues-on-ruby-2.0.0.patch
>
>
> {noformat}
> $ ctest -VV -R ruby-example-test
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Test project /home/jdanek/Work/repos/qpid-proton/build
> Constructing a list of tests
> Done constructing a list of tests
> Updating test list for fixtures
> Added 0 tests to meet fixture requirements
> Checking test dependency graph...
> Checking test dependency graph end
> test 13
> Start 13: ruby-example-test
> 13: Test command: 
> /nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin/python 
> "/home/jdanek/Work/repos/qpid-proton/proton-c/env.py" "--" 
> "PATH=/nix/store/pgwzcwz3v13dm193iys78xajrxf7m9yq-include-what-you-use-0.8/bin:/nix/store/x9p1z5z22z59x88h7ap09s0f79w50nj0-krb5-1.15.2-dev/bin:/nix/store/0gpszn41jk1fdw98q1jdm7n4z271m303-krb5-1.15.2/bin:/nix/store/xmbal41hbh2z82jz7pgjgxkba9malcvf-gss-1.0.3/bin:/nix/store/qs68njxs4awvjaqf2yw89x8bnb2jwl2a-pkg-config-0.29.2/bin:/nix/store/bd1qnp2y4mni2jsr7yqfy45q5wj9q4wz-util-linux-2.31-bin/bin:/nix/store/s03sh263lrxnz8dp9d81is9xwrs67ay9-openssl-1.0.2n-bin/bin:/nix/store/0frzwaf62yrbs0ni6043sllk8ac7db1l-cmake-3.9.6/bin:/nix/store/q03ccdnb7i7za2q66gx8b3mii293i6cg-ninja-1.8.2/bin:/nix/store/2sb5s8wj4s6awvfd4rn82297g2fhr18d-gcc-wrapper-7.2.0/bin:/nix/store/gkasrgaqw2riqc8ck8hh3a9k06cqaqrd-gcc-7.2.0/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/m5s6hd02nlfywi9n3yrgrx3fa8kgp9jd-binutils-wrapper-2.28.1/bin:/nix/store/kcdiibhpjrbpash3r1bvj2ncv4rwr3sm-binutils-2.28.1/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/h5m0g1agfcyc2d5lql0n8z6fls261rnn-go-1.9.2/bin:/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin:/nix/store/10lvqls7vl68blvvv42g36bh5rjbwkmk-gdb-8.0.1/bin:/nix/store/11wq1ncfb8za0mnnficcizd53p1md2y7-swig-3.0.12/bin:/nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin:/nix/store/waf0wx7drw74pkig43ickd8bn540wbz6-cyrus-sasl-2.1.26-bin/bin:/nix/store/n7l459d0f28lmdirr1wlzkdi7151jhqk-patchelf-0.9/bin:/nix/store/q7p8jaiymb1k4n44l31xdm753j79h7l5-paxctl-0.9/bin:/nix/store/4cqv0dm94h2sm0xpcqi6h8z6bnxqqlna-gcc-wrapper-6.4.0/bin:/nix/store/d88s1v28v11j2jxshqdvqms6h0pvp8aw-gcc-6.4.0/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/n2p15qg4lxgq0xkfrgqqfgpwkmd3295d-findutils-4.6.0/bin:/nix/store/ajiwrzg6nz9xpifr91wp14cy8al7s4df-diffutils-3.6/bin:/nix/store/n5rsq2cxj7lp4gynkvqrp0xkf78f1ni6-gnused-4.4/bin:/nix/store/nwpv4sxayci7jkjq7fid8hwz6ig5xjzi-gnugrep-3.1/bin:/nix/store/w1cddj0qc3ximvpwrn28rig7wq99ajd7-gawk-4.2.0/bin:/nix/store/7iw6c6nx7spzsp92pqq5qnd7d8jvbdl8-gnutar-1.30/bin:/nix/store/qk11lqm8fz9hpk1682gyf3x51wwasj3z-gzip-1.8/bin:/nix/store/mi9vmy5nwc4ma33jz6ihrdhh1r6izzv6-bzip2-1.0.6.0.1-bin/bin:/nix/store/92cdms75qnqh3hf39wbxra60bxdah9mq-gnumake-4.2.1/bin:/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin:/nix/store/irwrb341fpqd2lj22j13ffsxcjhayv1m-patch-2.7.5/bin:/nix/store/8fy4c90a0cj1mw2xibvv5k6b0rxx6b09-xz-5.2.3-bin/bin:/home/jdanek/bin:/run/wrappers/bin:/etc/per-user-pkgs/jdanek/bin:/home/jdanek/.n

[jira] [Commented] (PROTON-1738) [ruby-binding] incompatible with ruby 2.0.0

2018-02-14 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364406#comment-16364406
 ] 

ASF subversion and git services commented on PROTON-1738:
-

Commit 5c7db4df7c74bd2d5e3c89226e4f749cada2f089 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=5c7db4d ]

PROTON-1738: [ruby] add required_ruby_version >= 1.9.3 to gemspec

Tested and working with ruby 1.9.3, 2.0.0 and 2.4.3.

1.9.3 is the oldest version listed on 
https://www.ruby-lang.org/en/downloads/branches/

Does not work with 1.9.2. Open a new issue if there is a requirement for older 
versions.


> [ruby-binding] incompatible with ruby 2.0.0
> ---
>
> Key: PROTON-1738
> URL: https://issues.apache.org/jira/browse/PROTON-1738
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
>Affects Versions: proton-c-0.19.0
> Environment: 4dfe296920c9345dfbe8c9c535cbeb27055c01c2 
> (upstream/master)
> Author: Alan Conway 
> Date:   Thu Jan 4 12:47:25 2018 -0500
> PROTON-1706: fix compiler warnings in windows c examples
>Reporter: Jiri Daněk
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.21.0
>
> Attachments: 0001-WIP-Fix-for-issues-on-ruby-2.0.0.patch
>
>
> {noformat}
> $ ctest -VV -R ruby-example-test
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Test project /home/jdanek/Work/repos/qpid-proton/build
> Constructing a list of tests
> Done constructing a list of tests
> Updating test list for fixtures
> Added 0 tests to meet fixture requirements
> Checking test dependency graph...
> Checking test dependency graph end
> test 13
> Start 13: ruby-example-test
> 13: Test command: 
> /nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin/python 
> "/home/jdanek/Work/repos/qpid-proton/proton-c/env.py" "--" 
> "PATH=/nix/store/pgwzcwz3v13dm193iys78xajrxf7m9yq-include-what-you-use-0.8/bin:/nix/store/x9p1z5z22z59x88h7ap09s0f79w50nj0-krb5-1.15.2-dev/bin:/nix/store/0gpszn41jk1fdw98q1jdm7n4z271m303-krb5-1.15.2/bin:/nix/store/xmbal41hbh2z82jz7pgjgxkba9malcvf-gss-1.0.3/bin:/nix/store/qs68njxs4awvjaqf2yw89x8bnb2jwl2a-pkg-config-0.29.2/bin:/nix/store/bd1qnp2y4mni2jsr7yqfy45q5wj9q4wz-util-linux-2.31-bin/bin:/nix/store/s03sh263lrxnz8dp9d81is9xwrs67ay9-openssl-1.0.2n-bin/bin:/nix/store/0frzwaf62yrbs0ni6043sllk8ac7db1l-cmake-3.9.6/bin:/nix/store/q03ccdnb7i7za2q66gx8b3mii293i6cg-ninja-1.8.2/bin:/nix/store/2sb5s8wj4s6awvfd4rn82297g2fhr18d-gcc-wrapper-7.2.0/bin:/nix/store/gkasrgaqw2riqc8ck8hh3a9k06cqaqrd-gcc-7.2.0/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/m5s6hd02nlfywi9n3yrgrx3fa8kgp9jd-binutils-wrapper-2.28.1/bin:/nix/store/kcdiibhpjrbpash3r1bvj2ncv4rwr3sm-binutils-2.28.1/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/h5m0g1agfcyc2d5lql0n8z6fls261rnn-go-1.9.2/bin:/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin:/nix/store/10lvqls7vl68blvvv42g36bh5rjbwkmk-gdb-8.0.1/bin:/nix/store/11wq1ncfb8za0mnnficcizd53p1md2y7-swig-3.0.12/bin:/nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin:/nix/store/waf0wx7drw74pkig43ickd8bn540wbz6-cyrus-sasl-2.1.26-bin/bin:/nix/store/n7l459d0f28lmdirr1wlzkdi7151jhqk-patchelf-0.9/bin:/nix/store/q7p8jaiymb1k4n44l31xdm753j79h7l5-paxctl-0.9/bin:/nix/store/4cqv0dm94h2sm0xpcqi6h8z6bnxqqlna-gcc-wrapper-6.4.0/bin:/nix/store/d88s1v28v11j2jxshqdvqms6h0pvp8aw-gcc-6.4.0/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/n2p15qg4lxgq0xkfrgqqfgpwkmd3295d-findutils-4.6.0/bin:/nix/store/ajiwrzg6nz9xpifr91wp14cy8al7s4df-diffutils-3.6/bin:/nix/store/n5rsq2cxj7lp4gynkvqrp0xkf78f1ni6-gnused-4.4/bin:/nix/store/nwpv4sxayci7jkjq7fid8hwz6ig5xjzi-gnugrep-3.1/bin:/nix/store/w1cddj0qc3ximvpwrn28rig7wq99ajd7-gawk-4.2.0/bin:/nix/store/7iw6c6nx7spzsp92pqq5qnd7d8jvbdl8-gnutar-1.30/bin:/nix/store/qk11lqm8fz9hpk1682gyf3x51wwasj3z-gzip-1.8/bin:/nix/store/mi9vmy5nwc4ma33jz6ihrdhh1r6izzv6-bzip2-1.0.6.0.1-bin/bin:/nix/store/92cdms75qnqh3hf39wbxra60bxdah9mq-gnumake-4.2.1/bin:/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin:/nix/store/irwrb341fpqd2lj22j13ffsxcjhayv1m-

[jira] [Commented] (PROTON-1738) [ruby-binding] incompatible with ruby 2.0.0

2018-02-14 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364405#comment-16364405
 ] 

ASF subversion and git services commented on PROTON-1738:
-

Commit 71e8c7b2ede3a8510a8a3152c861d6a197d163ce in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=71e8c7b ]

PROTON-1738: [ruby] Make tests compatible with ruby 2.0.0

Rewrite tests in older style for minitest/spec and minitest/unit
Add missing require 'rbconfig' for older versions.


> [ruby-binding] incompatible with ruby 2.0.0
> ---
>
> Key: PROTON-1738
> URL: https://issues.apache.org/jira/browse/PROTON-1738
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
>Affects Versions: proton-c-0.19.0
> Environment: 4dfe296920c9345dfbe8c9c535cbeb27055c01c2 
> (upstream/master)
> Author: Alan Conway 
> Date:   Thu Jan 4 12:47:25 2018 -0500
> PROTON-1706: fix compiler warnings in windows c examples
>Reporter: Jiri Daněk
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.21.0
>
> Attachments: 0001-WIP-Fix-for-issues-on-ruby-2.0.0.patch
>
>
> {noformat}
> $ ctest -VV -R ruby-example-test
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> UpdateCTestConfiguration  from 
> :/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Parse Config 
> file:/home/jdanek/Work/repos/qpid-proton/build/DartConfiguration.tcl
> Test project /home/jdanek/Work/repos/qpid-proton/build
> Constructing a list of tests
> Done constructing a list of tests
> Updating test list for fixtures
> Added 0 tests to meet fixture requirements
> Checking test dependency graph...
> Checking test dependency graph end
> test 13
> Start 13: ruby-example-test
> 13: Test command: 
> /nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin/python 
> "/home/jdanek/Work/repos/qpid-proton/proton-c/env.py" "--" 
> "PATH=/nix/store/pgwzcwz3v13dm193iys78xajrxf7m9yq-include-what-you-use-0.8/bin:/nix/store/x9p1z5z22z59x88h7ap09s0f79w50nj0-krb5-1.15.2-dev/bin:/nix/store/0gpszn41jk1fdw98q1jdm7n4z271m303-krb5-1.15.2/bin:/nix/store/xmbal41hbh2z82jz7pgjgxkba9malcvf-gss-1.0.3/bin:/nix/store/qs68njxs4awvjaqf2yw89x8bnb2jwl2a-pkg-config-0.29.2/bin:/nix/store/bd1qnp2y4mni2jsr7yqfy45q5wj9q4wz-util-linux-2.31-bin/bin:/nix/store/s03sh263lrxnz8dp9d81is9xwrs67ay9-openssl-1.0.2n-bin/bin:/nix/store/0frzwaf62yrbs0ni6043sllk8ac7db1l-cmake-3.9.6/bin:/nix/store/q03ccdnb7i7za2q66gx8b3mii293i6cg-ninja-1.8.2/bin:/nix/store/2sb5s8wj4s6awvfd4rn82297g2fhr18d-gcc-wrapper-7.2.0/bin:/nix/store/gkasrgaqw2riqc8ck8hh3a9k06cqaqrd-gcc-7.2.0/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/m5s6hd02nlfywi9n3yrgrx3fa8kgp9jd-binutils-wrapper-2.28.1/bin:/nix/store/kcdiibhpjrbpash3r1bvj2ncv4rwr3sm-binutils-2.28.1/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/h5m0g1agfcyc2d5lql0n8z6fls261rnn-go-1.9.2/bin:/nix/store/ksl9j54260jc99qphf9gr6gg5vdn8dp0-ruby-2.0.0-p648/bin:/nix/store/10lvqls7vl68blvvv42g36bh5rjbwkmk-gdb-8.0.1/bin:/nix/store/11wq1ncfb8za0mnnficcizd53p1md2y7-swig-3.0.12/bin:/nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin:/nix/store/waf0wx7drw74pkig43ickd8bn540wbz6-cyrus-sasl-2.1.26-bin/bin:/nix/store/n7l459d0f28lmdirr1wlzkdi7151jhqk-patchelf-0.9/bin:/nix/store/q7p8jaiymb1k4n44l31xdm753j79h7l5-paxctl-0.9/bin:/nix/store/4cqv0dm94h2sm0xpcqi6h8z6bnxqqlna-gcc-wrapper-6.4.0/bin:/nix/store/d88s1v28v11j2jxshqdvqms6h0pvp8aw-gcc-6.4.0/bin:/nix/store/b25rk6qm6p3af1r1g25lzr16r31336r1-glibc-2.26-75-bin/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/hw5a3mifkrzd8y0pxs7nzzr4yscg08mw-coreutils-8.28/bin:/nix/store/n2p15qg4lxgq0xkfrgqqfgpwkmd3295d-findutils-4.6.0/bin:/nix/store/ajiwrzg6nz9xpifr91wp14cy8al7s4df-diffutils-3.6/bin:/nix/store/n5rsq2cxj7lp4gynkvqrp0xkf78f1ni6-gnused-4.4/bin:/nix/store/nwpv4sxayci7jkjq7fid8hwz6ig5xjzi-gnugrep-3.1/bin:/nix/store/w1cddj0qc3ximvpwrn28rig7wq99ajd7-gawk-4.2.0/bin:/nix/store/7iw6c6nx7spzsp92pqq5qnd7d8jvbdl8-gnutar-1.30/bin:/nix/store/qk11lqm8fz9hpk1682gyf3x51wwasj3z-gzip-1.8/bin:/nix/store/mi9vmy5nwc4ma33jz6ihrdhh1r6izzv6-bzip2-1.0.6.0.1-bin/bin:/nix/store/92cdms75qnqh3hf39wbxra60bxdah9mq-gnumake-4.2.1/bin:/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin:/nix/store/irwrb341fpqd2lj22j13ffsxcjhayv1m-patch-2.7.5/bin:/nix/store/8fy4c90a0cj1mw2xibvv5k6b0rxx6b09-xz-5.2.3-bin/bin:/home/jdanek/bin:/run/wrappers/bin:/etc/per-user

[jira] [Commented] (PROTON-1762) [ruby] gem does not contain examples or tests

2018-02-14 Thread Alan Conway (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364384#comment-16364384
 ] 

Alan Conway commented on PROTON-1762:
-

We also should have a cmake auto-test that installs the gem and runs a smoke 
test against the installed Gem,

ruby-examples-test should be enough to smoke test the Gem, no need to run the 
entire suite again, that would be too slow.

 

> [ruby] gem does not contain examples or tests
> -
>
> Key: PROTON-1762
> URL: https://issues.apache.org/jira/browse/PROTON-1762
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: ruby-binding
>Affects Versions: proton-c-0.20.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.21.0
>
>
> The ruby gem created by cmake does not include example files or tests. 
> The example sources should be included as part of the documentation and 
> linked from the README.
>  
> The tests should be included as per: 
> http://guides.rubygems.org/make-your-own-gem/#writing-tests



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

2018-02-14 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364354#comment-16364354
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit f256f675e63f17f3ade949033c14b93d4d6a146c in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=f256f67 ]

DISPATCH-209 : test dispositions over changing topology


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>Priority: Major
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-926) offered-capabilities is not compliant with OASIS AMQP 1.0 in case of QD_CAPABILITY_ANONYMOUS_RELAY

2018-02-14 Thread Ganesh Murthy (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364261#comment-16364261
 ] 

Ganesh Murthy commented on DISPATCH-926:


[~s1061123] are you already subscribed to the qpid users list? If not, please 
do. You can ask questions like this on that list and there will be lot more 
participation. Thanks.

> offered-capabilities is not compliant with OASIS AMQP 1.0 in case of 
> QD_CAPABILITY_ANONYMOUS_RELAY
> --
>
> Key: DISPATCH-926
> URL: https://issues.apache.org/jira/browse/DISPATCH-926
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: Tomofumi Hayashi
>Priority: Major
>
> In OASIS AMQP 1.0 document, offered-capabilities should be type symbol[], 
> symbol array as following: 
> [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-open]
> But in case of "saslMechanisms: ANONYMOUS" (listener section of 
> qdrouterd.conf), qdrouterd sends it as 'symbol' (!= symbol[]).
> I am just a beginner of AMQP, so it might be my misunderstood Could you 
> please double check?
> Candidate fix code:
> {noformat}
> diff --git a/src/server.c b/src/server.c
> index 4dff133e..5cc7cf01 100644
> --- a/src/server.c
> +++ b/src/server.c
> @@ -429,6 +429,8 @@ static void decorate_connection(qd_server_t *qd_server, 
> pn_connection_t *conn, c
>  //
>  // Offer ANONYMOUS_RELAY capability
>  //
> +pn_data_put_array(pn_connection_offered_capabilities(conn), false, 
> PN_SYMBOL);
> +pn_data_enter(pn_connection_offered_capabilities(conn));
>  pn_data_put_symbol(pn_connection_offered_capabilities(conn), 
> pn_bytes(clen, (char*) QD_CAPABILITY_ANONYMOUS_RELAY));
>  
>  //
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Apache EU Roadshow CFP Closing Soon (23 February)

2018-02-14 Thread Sharan F 

Hello Everyone

This is an initial reminder to let you all know that we are holding an 
Apache EU Roadshow co-located with FOSS Backstage in Berlin on 13^th and 
14^th June 2018. https://s.apache.org/tCHx


The Call for Proposals (CFP) for the Apache EU Roadshow is currently 
open and will close at the end of next week, so if you have been 
delaying making a submission because the closing date seemed a long way 
off, then it's time to start getting your proposals submitted.


So what are we looking for?
We will have 2 Apache Devrooms available during the 2 day Roadshow so 
are looking for projects including incubating ones, to submit 
presentations, panel discussions, BoFs, or workshop proposals. The main 
focus of the Roadshow will be IoT, Cloud, Httpd and Tomcat so if your 
project is involved in or around any of these technologies at Apache 
then we are very interested in hearing from you.


Community and collaboration is important at Apache so if your project is 
interested in organising a project sprint, meetup or hackathon during 
the Roadshow, then please submit it inthe CFP as we do have some space 
available to allocate for these.


If you are wanting to submit a talk on open source community related 
topics such as the Apache Way, governance or legal aspects then please 
submit these to the CFP for FOSS Backstage.


Tickets for the Apache EU Roadshow are included as part of the 
registration for FOSS Backstage, so to attend the Roadshow you will need 
to register for FOSS Backstage. Early Bird tickets are still available 
until the 21^st February 2018.


Please see below for important URLs to remember:

-  To submit a CFP for the Apache EU Roadshow 
:http://apachecon.com/euroadshow18/ 


-  To submit a CFP for FOSS Backstage : 
https://foss-backstage.de/call-papers


-  To register to attend the Apache EU Roadshow and/or FOSS Backstage : 
https://foss-backstage.de/tickets


For further updates and information about the Apache EU Roadshowplease 
check http://apachecon.com/euroadshow18/


Thanks
Sharan Foga, VP Apache Community Development

[jira] [Commented] (DISPATCH-911) Add link and address level counters at the global router level

2018-02-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364151#comment-16364151
 ] 

ASF GitHub Bot commented on DISPATCH-911:
-

Github user ganeshmurthy commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/254#discussion_r168192351
  
--- Diff: src/router_node.c ---
@@ -33,7 +33,6 @@
 const char *QD_ROUTER_NODE_TYPE = "router.node";
 const char *QD_ROUTER_ADDRESS_TYPE = "router.address";
 const char *QD_ROUTER_LINK_TYPE = "router.link";
-const char *CORE_AGENT_ADDRESS = "$management";
--- End diff --

You are correct. This is not related to the PR. I saw that this was not 
being used anywhere, so I removed it. 


> Add link and address level counters at the global router level
> --
>
> Key: DISPATCH-911
> URL: https://issues.apache.org/jira/browse/DISPATCH-911
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Management Agent
>Affects Versions: 1.0.0
>Reporter: Ernest Allen
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.1.0
>
>
> Link already has the following counters - 
>  presettledCount
>  droppedPresettledCount
>  acceptedCount
>  rejectedCount
>  releasedCount
>  modifiedCount
> Address already has the following counters
>  deliveriesIngress
>  deliveriesEgress
>  deliveriesTransit
> 1. Add the above link and address counters to the global router level as well.
>  2. Add routeContainerDeliveriesEgress and routeContainerDeliveriesIngress as 
> address and global counters
>  3. Add router memory footprint as a global statistic



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #254: DISPATCH-911 - Added global delivery counts

2018-02-14 Thread ganeshmurthy 
Github user ganeshmurthy commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/254#discussion_r168192351
  
--- Diff: src/router_node.c ---
@@ -33,7 +33,6 @@
 const char *QD_ROUTER_NODE_TYPE = "router.node";
 const char *QD_ROUTER_ADDRESS_TYPE = "router.address";
 const char *QD_ROUTER_LINK_TYPE = "router.link";
-const char *CORE_AGENT_ADDRESS = "$management";
--- End diff --

You are correct. This is not related to the PR. I saw that this was not 
being used anywhere, so I removed it. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #256: DISPATCH-926: Fix offered capability encoding

2018-02-14 Thread rgodfrey 
Github user rgodfrey commented on the issue:

https://github.com/apache/qpid-dispatch/pull/256
  
@s1061123 as an author of the AMQP spec it is probably my fault that it is 
confusing :)


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-926) offered-capabilities is not compliant with OASIS AMQP 1.0 in case of QD_CAPABILITY_ANONYMOUS_RELAY

2018-02-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363755#comment-16363755
 ] 

ASF GitHub Bot commented on DISPATCH-926:
-

Github user rgodfrey commented on the issue:

https://github.com/apache/qpid-dispatch/pull/256
  
@s1061123 as an author of the AMQP spec it is probably my fault that it is 
confusing :)


> offered-capabilities is not compliant with OASIS AMQP 1.0 in case of 
> QD_CAPABILITY_ANONYMOUS_RELAY
> --
>
> Key: DISPATCH-926
> URL: https://issues.apache.org/jira/browse/DISPATCH-926
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: Tomofumi Hayashi
>Priority: Major
>
> In OASIS AMQP 1.0 document, offered-capabilities should be type symbol[], 
> symbol array as following: 
> [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-open]
> But in case of "saslMechanisms: ANONYMOUS" (listener section of 
> qdrouterd.conf), qdrouterd sends it as 'symbol' (!= symbol[]).
> I am just a beginner of AMQP, so it might be my misunderstood Could you 
> please double check?
> Candidate fix code:
> {noformat}
> diff --git a/src/server.c b/src/server.c
> index 4dff133e..5cc7cf01 100644
> --- a/src/server.c
> +++ b/src/server.c
> @@ -429,6 +429,8 @@ static void decorate_connection(qd_server_t *qd_server, 
> pn_connection_t *conn, c
>  //
>  // Offer ANONYMOUS_RELAY capability
>  //
> +pn_data_put_array(pn_connection_offered_capabilities(conn), false, 
> PN_SYMBOL);
> +pn_data_enter(pn_connection_offered_capabilities(conn));
>  pn_data_put_symbol(pn_connection_offered_capabilities(conn), 
> pn_bytes(clen, (char*) QD_CAPABILITY_ANONYMOUS_RELAY));
>  
>  //
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-926) offered-capabilities is not compliant with OASIS AMQP 1.0 in case of QD_CAPABILITY_ANONYMOUS_RELAY

2018-02-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363747#comment-16363747
 ] 

ASF GitHub Bot commented on DISPATCH-926:
-

Github user s1061123 commented on the issue:

https://github.com/apache/qpid-dispatch/pull/256
  
@rgodfrey thank you for your comment! I understood it.


> offered-capabilities is not compliant with OASIS AMQP 1.0 in case of 
> QD_CAPABILITY_ANONYMOUS_RELAY
> --
>
> Key: DISPATCH-926
> URL: https://issues.apache.org/jira/browse/DISPATCH-926
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: Tomofumi Hayashi
>Priority: Major
>
> In OASIS AMQP 1.0 document, offered-capabilities should be type symbol[], 
> symbol array as following: 
> [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-open]
> But in case of "saslMechanisms: ANONYMOUS" (listener section of 
> qdrouterd.conf), qdrouterd sends it as 'symbol' (!= symbol[]).
> I am just a beginner of AMQP, so it might be my misunderstood Could you 
> please double check?
> Candidate fix code:
> {noformat}
> diff --git a/src/server.c b/src/server.c
> index 4dff133e..5cc7cf01 100644
> --- a/src/server.c
> +++ b/src/server.c
> @@ -429,6 +429,8 @@ static void decorate_connection(qd_server_t *qd_server, 
> pn_connection_t *conn, c
>  //
>  // Offer ANONYMOUS_RELAY capability
>  //
> +pn_data_put_array(pn_connection_offered_capabilities(conn), false, 
> PN_SYMBOL);
> +pn_data_enter(pn_connection_offered_capabilities(conn));
>  pn_data_put_symbol(pn_connection_offered_capabilities(conn), 
> pn_bytes(clen, (char*) QD_CAPABILITY_ANONYMOUS_RELAY));
>  
>  //
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-926) offered-capabilities is not compliant with OASIS AMQP 1.0 in case of QD_CAPABILITY_ANONYMOUS_RELAY

2018-02-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363748#comment-16363748
 ] 

ASF GitHub Bot commented on DISPATCH-926:
-

Github user s1061123 closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/256


> offered-capabilities is not compliant with OASIS AMQP 1.0 in case of 
> QD_CAPABILITY_ANONYMOUS_RELAY
> --
>
> Key: DISPATCH-926
> URL: https://issues.apache.org/jira/browse/DISPATCH-926
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: Tomofumi Hayashi
>Priority: Major
>
> In OASIS AMQP 1.0 document, offered-capabilities should be type symbol[], 
> symbol array as following: 
> [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-open]
> But in case of "saslMechanisms: ANONYMOUS" (listener section of 
> qdrouterd.conf), qdrouterd sends it as 'symbol' (!= symbol[]).
> I am just a beginner of AMQP, so it might be my misunderstood Could you 
> please double check?
> Candidate fix code:
> {noformat}
> diff --git a/src/server.c b/src/server.c
> index 4dff133e..5cc7cf01 100644
> --- a/src/server.c
> +++ b/src/server.c
> @@ -429,6 +429,8 @@ static void decorate_connection(qd_server_t *qd_server, 
> pn_connection_t *conn, c
>  //
>  // Offer ANONYMOUS_RELAY capability
>  //
> +pn_data_put_array(pn_connection_offered_capabilities(conn), false, 
> PN_SYMBOL);
> +pn_data_enter(pn_connection_offered_capabilities(conn));
>  pn_data_put_symbol(pn_connection_offered_capabilities(conn), 
> pn_bytes(clen, (char*) QD_CAPABILITY_ANONYMOUS_RELAY));
>  
>  //
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #256: DISPATCH-926: Fix offered capability encodi...

2018-02-14 Thread s1061123 
Github user s1061123 closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/256


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #256: DISPATCH-926: Fix offered capability encoding

2018-02-14 Thread s1061123 
Github user s1061123 commented on the issue:

https://github.com/apache/qpid-dispatch/pull/256
  
@rgodfrey thank you for your comment! I understood it.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-8098) [Broker-J] [AMQP 0-10] Queue browsers erroneously increment the delivery count

2018-02-14 Thread Keith Wall (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-8098:
-
Description: 
On the AMQP 0-10 protocol path within the Broker, deliveries to queue browsers 
erroneously increase the {{MessageInstance#deliveryCount}}.  This should not 
happen.  The purpose of the delivery count is to count deliveries to 
(destructive) consumers - not browsers.  The problem is restricted to AMQP 0-10 
implementation.  Neither AMQP 0-x nor AMQP 1.0 are affected by this defect.

The defect could mean that messages are spuriously routed to a DLQ (if 
configured).  For this to happen, there would need to be additional destructive 
consumers on the queue that cause the message to be 'released'.  Releasing 
occurs during transaction rollback and client disconnection (when messages are 
prefetched).   The message would be prematurely routed to the DLQ in this case.

The defect is longstanding.  I tested as far back as 0.30.

https://mail-archives.apache.org/mod_mbox/qpid-users/201802.mbox/%3c1518546115789-0.p...@n2.nabble.com%3e

  was:
On the AMQP 0-10 protocol path within the Broker, deliveries to queue browsers 
erroneously increase the {{MessageInstance#deliveryCount}}.  This should not 
happen.  The purpose of the delivery count is to count deliveries to 
(destructive) consumers - not browsers.  The problem is restricted to AMQP 0-10 
implementation.  Neither AMQP 0-x nor AMQP 1.0 are affected by this defect.

The defect could mean that messages are spuriously routed to a DLQ (if 
configured).  For this to happen, there would need to be additional destructive 
consumers on the queue that cause the message to be 'released'.  Releasing 
occurs during transaction rollback and client disconnection (when messages are 
prefetched).   The message would be prematurely routed to the DLQ in this case.

https://mail-archives.apache.org/mod_mbox/qpid-users/201802.mbox/%3c1518546115789-0.p...@n2.nabble.com%3e


> [Broker-J] [AMQP 0-10] Queue browsers erroneously increment the delivery count
> --
>
> Key: QPID-8098
> URL: https://issues.apache.org/jira/browse/QPID-8098
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: 0.30, 0.32, qpid-java-6.0, qpid-java-6.1, 
> qpid-java-broker-7.0.0
>Reporter: Keith Wall
>Priority: Major
>
> On the AMQP 0-10 protocol path within the Broker, deliveries to queue 
> browsers erroneously increase the {{MessageInstance#deliveryCount}}.  This 
> should not happen.  The purpose of the delivery count is to count deliveries 
> to (destructive) consumers - not browsers.  The problem is restricted to AMQP 
> 0-10 implementation.  Neither AMQP 0-x nor AMQP 1.0 are affected by this 
> defect.
> The defect could mean that messages are spuriously routed to a DLQ (if 
> configured).  For this to happen, there would need to be additional 
> destructive consumers on the queue that cause the message to be 'released'.  
> Releasing occurs during transaction rollback and client disconnection (when 
> messages are prefetched).   The message would be prematurely routed to the 
> DLQ in this case.
> The defect is longstanding.  I tested as far back as 0.30.
> https://mail-archives.apache.org/mod_mbox/qpid-users/201802.mbox/%3c1518546115789-0.p...@n2.nabble.com%3e



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-8098) [Broker-J] [AMQP 0-10] Queue browsers erroneously increment the delivery count

2018-02-14 Thread Keith Wall (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-8098:
-
Summary: [Broker-J] [AMQP 0-10] Queue browsers erroneously increment the 
delivery count  (was: [AMQP 0-10] Queue browsers increment the delivery count)

> [Broker-J] [AMQP 0-10] Queue browsers erroneously increment the delivery count
> --
>
> Key: QPID-8098
> URL: https://issues.apache.org/jira/browse/QPID-8098
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: 0.30, 0.32, qpid-java-6.0, qpid-java-6.1, 
> qpid-java-broker-7.0.0
>Reporter: Keith Wall
>Priority: Major
>
> On the AMQP 0-10 protocol path within the Broker, deliveries to queue 
> browsers erroneously increase the {{MessageInstance#deliveryCount}}.  This 
> should not happen.  The purpose of the delivery count is to count deliveries 
> to (destructive) consumers - not browsers.  The problem is restricted to AMQP 
> 0-10 implementation.  Neither AMQP 0-x nor AMQP 1.0 are affected by this 
> defect.
> The defect could mean that messages are spuriously routed to a DLQ (if 
> configured).  For this to happen, there would need to be additional 
> destructive consumers on the queue that cause the message to be 'released'.  
> Releasing occurs during transaction rollback and client disconnection (when 
> messages are prefetched).   The message would be prematurely routed to the 
> DLQ in this case.
> https://mail-archives.apache.org/mod_mbox/qpid-users/201802.mbox/%3c1518546115789-0.p...@n2.nabble.com%3e



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-8098) [AMQP 0-10] Queue browsers increment the delivery count

2018-02-14 Thread Keith Wall (JIRA) 
Keith Wall created QPID-8098:


 Summary: [AMQP 0-10] Queue browsers increment the delivery count
 Key: QPID-8098
 URL: https://issues.apache.org/jira/browse/QPID-8098
 Project: Qpid
  Issue Type: Bug
  Components: Broker-J
Affects Versions: qpid-java-broker-7.0.0, qpid-java-6.1, qpid-java-6.0, 
0.32, 0.30
Reporter: Keith Wall


On the AMQP 0-10 protocol path within the Broker, deliveries to queue browsers 
erroneously increase the {{MessageInstance#deliveryCount}}.  This should not 
happen.  The purpose of the delivery count is to count deliveries to 
(destructive) consumers - not browsers.  The problem is restricted to AMQP 0-10 
implementation.  Neither AMQP 0-x nor AMQP 1.0 are affected by this defect.

The defect could mean that messages are spuriously routed to a DLQ (if 
configured).  For this to happen, there would need to be additional destructive 
consumers on the queue that cause the message to be 'released'.  Releasing 
occurs during transaction rollback and client disconnection (when messages are 
prefetched).   The message would be prematurely routed to the DLQ in this case.

https://mail-archives.apache.org/mod_mbox/qpid-users/201802.mbox/%3c1518546115789-0.p...@n2.nabble.com%3e



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (DISPATCH-926) offered-capabilities is not compliant with OASIS AMQP 1.0 in case of QD_CAPABILITY_ANONYMOUS_RELAY

2018-02-14 Thread Rob Godfrey (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DISPATCH-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey resolved DISPATCH-926.
--
Resolution: Not A Problem

The current encoding is valid (though the spec is a little misleading)

> offered-capabilities is not compliant with OASIS AMQP 1.0 in case of 
> QD_CAPABILITY_ANONYMOUS_RELAY
> --
>
> Key: DISPATCH-926
> URL: https://issues.apache.org/jira/browse/DISPATCH-926
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: Tomofumi Hayashi
>Priority: Major
>
> In OASIS AMQP 1.0 document, offered-capabilities should be type symbol[], 
> symbol array as following: 
> [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-open]
> But in case of "saslMechanisms: ANONYMOUS" (listener section of 
> qdrouterd.conf), qdrouterd sends it as 'symbol' (!= symbol[]).
> I am just a beginner of AMQP, so it might be my misunderstood Could you 
> please double check?
> Candidate fix code:
> {noformat}
> diff --git a/src/server.c b/src/server.c
> index 4dff133e..5cc7cf01 100644
> --- a/src/server.c
> +++ b/src/server.c
> @@ -429,6 +429,8 @@ static void decorate_connection(qd_server_t *qd_server, 
> pn_connection_t *conn, c
>  //
>  // Offer ANONYMOUS_RELAY capability
>  //
> +pn_data_put_array(pn_connection_offered_capabilities(conn), false, 
> PN_SYMBOL);
> +pn_data_enter(pn_connection_offered_capabilities(conn));
>  pn_data_put_symbol(pn_connection_offered_capabilities(conn), 
> pn_bytes(clen, (char*) QD_CAPABILITY_ANONYMOUS_RELAY));
>  
>  //
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-926) offered-capabilities is not compliant with OASIS AMQP 1.0 in case of QD_CAPABILITY_ANONYMOUS_RELAY

2018-02-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363674#comment-16363674
 ] 

ASF GitHub Bot commented on DISPATCH-926:
-

Github user rgodfrey commented on the issue:

https://github.com/apache/qpid-dispatch/pull/256
  
The encoding of a single offered capability as a symbol (rather than as an 
array of symbols) is valid.  As per 
http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-types-v1.0-os.html#section-composite-type-representation

> The multiple attribute of a field description controls whether multiple 
element values are permitted in the representation. A single element of the 
type specified in the field description is always permitted. Multiple values 
are represented by the use of an array where the type of the elements in the 
array is the type defined in the field definition. Note that a null value and a 
zero-length array (with a correct type for its elements) both describe an 
absence of a value and MUST be treated as semantically identical.

So I don't think this change is necessary


> offered-capabilities is not compliant with OASIS AMQP 1.0 in case of 
> QD_CAPABILITY_ANONYMOUS_RELAY
> --
>
> Key: DISPATCH-926
> URL: https://issues.apache.org/jira/browse/DISPATCH-926
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: Tomofumi Hayashi
>Priority: Major
>
> In OASIS AMQP 1.0 document, offered-capabilities should be type symbol[], 
> symbol array as following: 
> [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-open]
> But in case of "saslMechanisms: ANONYMOUS" (listener section of 
> qdrouterd.conf), qdrouterd sends it as 'symbol' (!= symbol[]).
> I am just a beginner of AMQP, so it might be my misunderstood Could you 
> please double check?
> Candidate fix code:
> {noformat}
> diff --git a/src/server.c b/src/server.c
> index 4dff133e..5cc7cf01 100644
> --- a/src/server.c
> +++ b/src/server.c
> @@ -429,6 +429,8 @@ static void decorate_connection(qd_server_t *qd_server, 
> pn_connection_t *conn, c
>  //
>  // Offer ANONYMOUS_RELAY capability
>  //
> +pn_data_put_array(pn_connection_offered_capabilities(conn), false, 
> PN_SYMBOL);
> +pn_data_enter(pn_connection_offered_capabilities(conn));
>  pn_data_put_symbol(pn_connection_offered_capabilities(conn), 
> pn_bytes(clen, (char*) QD_CAPABILITY_ANONYMOUS_RELAY));
>  
>  //
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #256: DISPATCH-926: Fix offered capability encoding

2018-02-14 Thread rgodfrey 
Github user rgodfrey commented on the issue:

https://github.com/apache/qpid-dispatch/pull/256
  
The encoding of a single offered capability as a symbol (rather than as an 
array of symbols) is valid.  As per 
http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-types-v1.0-os.html#section-composite-type-representation

> The multiple attribute of a field description controls whether multiple 
element values are permitted in the representation. A single element of the 
type specified in the field description is always permitted. Multiple values 
are represented by the use of an array where the type of the elements in the 
array is the type defined in the field definition. Note that a null value and a 
zero-length array (with a correct type for its elements) both describe an 
absence of a value and MUST be treated as semantically identical.

So I don't think this change is necessary


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org