[jira] [Created] (PROTON-1867) Debug libs missing in Windows build
Justin Ross created PROTON-1867: --- Summary: Debug libs missing in Windows build Key: PROTON-1867 URL: https://issues.apache.org/jira/browse/PROTON-1867 Project: Qpid Proton Issue Type: Bug Components: cpp-binding Reporter: Justin Ross Assignee: Justin Ross Fix For: proton-c-0.24.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-1865) Improve split between general SASL code and the specific implementations
[ https://issues.apache.org/jira/browse/PROTON-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519765#comment-16519765 ] Andrew Stitcher edited comment on PROTON-1865 at 6/21/18 8:55 PM: -- Commit 885d68aeaf522021a35b7b5cecb7c7c53663929b: [https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=885d68ae] was (Author: astitcher): Commit 885d68aeaf522021a35b7b5cecb7c7c53663929b: > Improve split between general SASL code and the specific implementations > > > Key: PROTON-1865 > URL: https://issues.apache.org/jira/browse/PROTON-1865 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.24.0 > > > There are a number of places where the SASL code needs to be tidied up since > it was split into general and plugin implementations. > Specifically checking for inclusion in the allowed mechanisms list only needs > to happen in the common code and the specific implementations only need to > receive a prefiltered list. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-1354) Disable problematic SASL mechanisms if they are not explicitly enabled
[ https://issues.apache.org/jira/browse/PROTON-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519767#comment-16519767 ] Andrew Stitcher edited comment on PROTON-1354 at 6/21/18 8:55 PM: -- Commited in 170be2e68f0824376b4641dfc2b65193bdaac317 [https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=170be2e6] was (Author: astitcher): Commited in 170be2e68f0824376b4641dfc2b65193bdaac317 [https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=67d4d74] > Disable problematic SASL mechanisms if they are not explicitly enabled > -- > > Key: PROTON-1354 > URL: https://issues.apache.org/jira/browse/PROTON-1354 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Justin Ross >Assignee: Andrew Stitcher >Priority: Major > Labels: release-notes, sasl, usability > Fix For: proton-c-0.24.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-1354) Disable problematic SASL mechanisms if they are not explicitly enabled
[ https://issues.apache.org/jira/browse/PROTON-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519767#comment-16519767 ] Andrew Stitcher edited comment on PROTON-1354 at 6/21/18 8:54 PM: -- Commited in 170be2e68f0824376b4641dfc2b65193bdaac317 [https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=67d4d74] was (Author: astitcher): Commited in 170be2e68f0824376b4641dfc2b65193bdaac317 [[https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=170be2]|https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=67d4d74] > Disable problematic SASL mechanisms if they are not explicitly enabled > -- > > Key: PROTON-1354 > URL: https://issues.apache.org/jira/browse/PROTON-1354 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Justin Ross >Assignee: Andrew Stitcher >Priority: Major > Labels: release-notes, sasl, usability > Fix For: proton-c-0.24.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (PROTON-1354) Disable problematic SASL mechanisms if they are not explicitly enabled
[ https://issues.apache.org/jira/browse/PROTON-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519767#comment-16519767 ] Andrew Stitcher edited comment on PROTON-1354 at 6/21/18 8:53 PM: -- Commited in 170be2e68f0824376b4641dfc2b65193bdaac317 [[https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=170be2]|https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=67d4d74] was (Author: astitcher): Commited in 170be2e68f0824376b4641dfc2b65193bdaac317 > Disable problematic SASL mechanisms if they are not explicitly enabled > -- > > Key: PROTON-1354 > URL: https://issues.apache.org/jira/browse/PROTON-1354 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Justin Ross >Assignee: Andrew Stitcher >Priority: Major > Labels: release-notes, sasl, usability > Fix For: proton-c-0.24.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1354) Disable problematic SASL mechanisms if they are not explicitly enabled
[ https://issues.apache.org/jira/browse/PROTON-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519767#comment-16519767 ] Andrew Stitcher commented on PROTON-1354: - Commited in 170be2e68f0824376b4641dfc2b65193bdaac317 > Disable problematic SASL mechanisms if they are not explicitly enabled > -- > > Key: PROTON-1354 > URL: https://issues.apache.org/jira/browse/PROTON-1354 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Justin Ross >Assignee: Andrew Stitcher >Priority: Major > Labels: release-notes, sasl, usability > Fix For: proton-c-0.24.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1865) Improve split between general SASL code and the specific implementations
[ https://issues.apache.org/jira/browse/PROTON-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519765#comment-16519765 ] Andrew Stitcher commented on PROTON-1865: - Commit 885d68aeaf522021a35b7b5cecb7c7c53663929b: > Improve split between general SASL code and the specific implementations > > > Key: PROTON-1865 > URL: https://issues.apache.org/jira/browse/PROTON-1865 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.24.0 > > > There are a number of places where the SASL code needs to be tidied up since > it was split into general and plugin implementations. > Specifically checking for inclusion in the allowed mechanisms list only needs > to happen in the common code and the specific implementations only need to > receive a prefiltered list. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-1865) Improve split between general SASL code and the specific implementations
[ https://issues.apache.org/jira/browse/PROTON-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-1865. - Resolution: Fixed Fix Version/s: proton-c-0.24.0 > Improve split between general SASL code and the specific implementations > > > Key: PROTON-1865 > URL: https://issues.apache.org/jira/browse/PROTON-1865 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.24.0 > > > There are a number of places where the SASL code needs to be tidied up since > it was split into general and plugin implementations. > Specifically checking for inclusion in the allowed mechanisms list only needs > to happen in the common code and the specific implementations only need to > receive a prefiltered list. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-1354) Disable problematic SASL mechanisms if they are not explicitly enabled
[ https://issues.apache.org/jira/browse/PROTON-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-1354. - Resolution: Fixed Fix Version/s: proton-c-0.24.0 > Disable problematic SASL mechanisms if they are not explicitly enabled > -- > > Key: PROTON-1354 > URL: https://issues.apache.org/jira/browse/PROTON-1354 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Justin Ross >Assignee: Andrew Stitcher >Priority: Major > Labels: sasl, usability > Fix For: proton-c-0.24.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1354) Disable problematic SASL mechanisms if they are not explicitly enabled
[ https://issues.apache.org/jira/browse/PROTON-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519761#comment-16519761 ] ASF GitHub Bot commented on PROTON-1354: Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/148 > Disable problematic SASL mechanisms if they are not explicitly enabled > -- > > Key: PROTON-1354 > URL: https://issues.apache.org/jira/browse/PROTON-1354 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Justin Ross >Assignee: Andrew Stitcher >Priority: Major > Labels: sasl, usability > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton pull request #148: PROTON-1354: Don't allow SASL mechanisms GSSA...
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/148 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Review Request 66839: translation of remote address in link route
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66839/#review205183 --- Ship it! Ship It! - Ganesh Murthy On June 21, 2018, 3:19 p.m., Gordon Sim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66839/ > --- > > (Updated June 21, 2018, 3:19 p.m.) > > > Review request for qpid and Ted Ross. > > > Bugs: DISPATCH-980 > https://issues.apache.org/jira/browse/DISPATCH-980 > > > Repository: qpid-dispatch > > > Description > --- > > This adds two fields to the link route config, addExternalPrefix and > delExternalPrefix, that behave similar to the externalAddr in auto links. > I.e. they will cause a prefix to be inserted and/or deleted in the final hop > for a link routed link attach. That prefix will also be stripped off or > inserted back into the reply, making the renaming completely transparent to > clients. > > > Diffs > - > > include/qpid/dispatch/router_core.h 8f144b0 > python/qpid_dispatch/management/qdrouter.json 42f501f > src/router_config.c 94758df > src/router_core/agent_config_link_route.h 57f6f0d > src/router_core/agent_config_link_route.c 981d142 > src/router_core/connections.c 5fdc3bf > src/router_core/forwarder.c fca19c3 > src/router_core/route_control.h 3c715bc > src/router_core/route_control.c 61f426d > src/router_core/router_core.c 9d7f7a5 > src/router_core/router_core_private.h cd2ffa4 > src/router_core/terminus.c 4c0e0a3 > tests/CMakeLists.txt 159521d > tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION > tools/qdstat 1e3a3a3 > > > Diff: https://reviews.apache.org/r/66839/diff/6/ > > > Testing > --- > > Added system tests plus some ad hoc testing. > > > Thanks, > > Gordon Sim > >
Re: Review Request 66839: translation of remote address in link route
> On June 20, 2018, 2:22 p.m., Ganesh Murthy wrote: > > 1. Should displayLinkRoutes() function in qpid-dispatch/tools/qdstat be > > modified to show "addExternalPrefix" and "delExternalPrefix" attributes? > > 2. I think we should have an additional test added to > > system_tests_link_routes_add_external_prefix which will run qdmanage query > > on link routes and make sure that "addExternalPrefix" and > > "delExternalPrefix" are showing correctly > > Gordon Sim wrote: > Done. (The extra columns do add a little noise to the qdstat output > considering they will often not be set) > > Ganesh Murthy wrote: > The qdstat test looks good. Can you also please add a qdmanage test > (qdmanage query --type=linkroute) to make sure that the "addExternalPrefix" > and "delExternalPrefix" columns are present. Done! - Gordon --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66839/#review205080 --- On June 21, 2018, 3:19 p.m., Gordon Sim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66839/ > --- > > (Updated June 21, 2018, 3:19 p.m.) > > > Review request for qpid and Ted Ross. > > > Bugs: DISPATCH-980 > https://issues.apache.org/jira/browse/DISPATCH-980 > > > Repository: qpid-dispatch > > > Description > --- > > This adds two fields to the link route config, addExternalPrefix and > delExternalPrefix, that behave similar to the externalAddr in auto links. > I.e. they will cause a prefix to be inserted and/or deleted in the final hop > for a link routed link attach. That prefix will also be stripped off or > inserted back into the reply, making the renaming completely transparent to > clients. > > > Diffs > - > > include/qpid/dispatch/router_core.h 8f144b0 > python/qpid_dispatch/management/qdrouter.json 42f501f > src/router_config.c 94758df > src/router_core/agent_config_link_route.h 57f6f0d > src/router_core/agent_config_link_route.c 981d142 > src/router_core/connections.c 5fdc3bf > src/router_core/forwarder.c fca19c3 > src/router_core/route_control.h 3c715bc > src/router_core/route_control.c 61f426d > src/router_core/router_core.c 9d7f7a5 > src/router_core/router_core_private.h cd2ffa4 > src/router_core/terminus.c 4c0e0a3 > tests/CMakeLists.txt 159521d > tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION > tools/qdstat 1e3a3a3 > > > Diff: https://reviews.apache.org/r/66839/diff/6/ > > > Testing > --- > > Added system tests plus some ad hoc testing. > > > Thanks, > > Gordon Sim > >
Re: Review Request 66839: translation of remote address in link route
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66839/ --- (Updated June 21, 2018, 3:19 p.m.) Review request for qpid and Ted Ross. Changes --- Added test for qdmanage Ensure qdstat can still run against older routers Bugs: DISPATCH-980 https://issues.apache.org/jira/browse/DISPATCH-980 Repository: qpid-dispatch Description --- This adds two fields to the link route config, addExternalPrefix and delExternalPrefix, that behave similar to the externalAddr in auto links. I.e. they will cause a prefix to be inserted and/or deleted in the final hop for a link routed link attach. That prefix will also be stripped off or inserted back into the reply, making the renaming completely transparent to clients. Diffs (updated) - include/qpid/dispatch/router_core.h 8f144b0 python/qpid_dispatch/management/qdrouter.json 42f501f src/router_config.c 94758df src/router_core/agent_config_link_route.h 57f6f0d src/router_core/agent_config_link_route.c 981d142 src/router_core/connections.c 5fdc3bf src/router_core/forwarder.c fca19c3 src/router_core/route_control.h 3c715bc src/router_core/route_control.c 61f426d src/router_core/router_core.c 9d7f7a5 src/router_core/router_core_private.h cd2ffa4 src/router_core/terminus.c 4c0e0a3 tests/CMakeLists.txt 159521d tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION tools/qdstat 1e3a3a3 Diff: https://reviews.apache.org/r/66839/diff/6/ Changes: https://reviews.apache.org/r/66839/diff/5-6/ Testing --- Added system tests plus some ad hoc testing. Thanks, Gordon Sim
[GitHub] qpid-dispatch issue #326: Logging
Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/326 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/326?src=pr=h1) Report > Merging [#326](https://codecov.io/gh/apache/qpid-dispatch/pull/326?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/6d5d7cd29207637550f019f1bdc744a541b696c3?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/326?src=pr=tree) ```diff @@Coverage Diff @@ ## master #326 +/- ## == + Coverage 86.56% 86.59% +0.02% == Files 69 69 Lines 1546715471 +4 == + Hits1338913397 +8 + Misses 2078 2074 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/326?src=pr=tree) | Coverage Π| | |---|---|---| | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/326/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.59% <100%> (ø)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/326/diff?src=pr=tree#diff-c3JjL3NlcnZlci5j) | `87.78% <87.5%> (+0.04%)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/326/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `86.6% <0%> (-0.2%)` | :arrow_down: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/326/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `99.25% <0%> (+0.37%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/326/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.79% <0%> (+0.57%)` | :arrow_up: | | [src/log.c](https://codecov.io/gh/apache/qpid-dispatch/pull/326/diff?src=pr=tree#diff-c3JjL2xvZy5j) | `91.22% <0%> (+1.05%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/326?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/326?src=pr=footer). Last update [6d5d7cd...d92719a](https://codecov.io/gh/apache/qpid-dispatch/pull/326?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #326: Logging
GitHub user alanconway opened a pull request: https://github.com/apache/qpid-dispatch/pull/326 Logging Some minor changes to dispatch logging based on experience debugging the HTTP Envoy bridge. See the commit comments for explanation. One additional question: I was confused by the new messageLoggingComponents config, when I set MESSAGE enable trace+ I saw nothing at all, which was surprising. Perhaps the default should be "all" so that enabling MESSAGE trace does what folks expect and they can turn the logging down per connector/listener if they wish. Since trace logging will be off in production (I hope!) this won't have any effect except on users that are deliberately debugging AND have turned on trace logging for at least the MESSAGE module, so are expecting a lot of log data. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alanconway/dispatch logging Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/326.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #326 commit c2be6c7ec46567675a036c7c77ec840d3c2a4982 Author: Alan Conway Date: 2018-06-20T17:27:23Z NO-JIRA: Adjust log levels. - upgrade connection failure INFO messages to WARNING - downgrade incref/decref messages to TRACE Personally I think the incref/decref messages should not be in user-facing logs at all, but if they must be they should be TRACE as they occur at a per-delivery (i.e. per-message) volume. commit d02442ec6422bbdb2cb505345eaa4afa2691068e Author: Alan Conway Date: 2018-06-20T17:52:09Z NO-JIRA: Removed redundant "accepted" log message, added missing connection_id commit d92719aad8f3be6ace7fb10dbadb9dcd4f1776b7 Author: Alan Conway Date: 2018-06-21T13:19:23Z NO-JIRA: symmetric logging for incoming/outgoing establish/close connection Incoming connection establishment was being logged at info. Added info logs for outgoing connection establishment and any connection close. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Review Request 66839: translation of remote address in link route
> On June 20, 2018, 2:22 p.m., Ganesh Murthy wrote: > > 1. Should displayLinkRoutes() function in qpid-dispatch/tools/qdstat be > > modified to show "addExternalPrefix" and "delExternalPrefix" attributes? > > 2. I think we should have an additional test added to > > system_tests_link_routes_add_external_prefix which will run qdmanage query > > on link routes and make sure that "addExternalPrefix" and > > "delExternalPrefix" are showing correctly > > Gordon Sim wrote: > Done. (The extra columns do add a little noise to the qdstat output > considering they will often not be set) The qdstat test looks good. Can you also please add a qdmanage test (qdmanage query --type=linkroute) to make sure that the "addExternalPrefix" and "delExternalPrefix" columns are present. - Ganesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66839/#review205080 --- On June 20, 2018, 4:25 p.m., Gordon Sim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66839/ > --- > > (Updated June 20, 2018, 4:25 p.m.) > > > Review request for qpid and Ted Ross. > > > Bugs: DISPATCH-980 > https://issues.apache.org/jira/browse/DISPATCH-980 > > > Repository: qpid-dispatch > > > Description > --- > > This adds two fields to the link route config, addExternalPrefix and > delExternalPrefix, that behave similar to the externalAddr in auto links. > I.e. they will cause a prefix to be inserted and/or deleted in the final hop > for a link routed link attach. That prefix will also be stripped off or > inserted back into the reply, making the renaming completely transparent to > clients. > > > Diffs > - > > include/qpid/dispatch/router_core.h 8f144b0 > python/qpid_dispatch/management/qdrouter.json 42f501f > src/router_config.c 94758df > src/router_core/agent_config_link_route.h 57f6f0d > src/router_core/agent_config_link_route.c 981d142 > src/router_core/connections.c 5fdc3bf > src/router_core/forwarder.c fca19c3 > src/router_core/route_control.h 3c715bc > src/router_core/route_control.c 61f426d > src/router_core/router_core.c 9d7f7a5 > src/router_core/router_core_private.h cd2ffa4 > src/router_core/terminus.c 4c0e0a3 > tests/CMakeLists.txt 159521d > tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION > tools/qdstat 1e3a3a3 > > > Diff: https://reviews.apache.org/r/66839/diff/5/ > > > Testing > --- > > Added system tests plus some ad hoc testing. > > > Thanks, > > Gordon Sim > >
Re: Review Request 67661: propagate link-detach as expiry policy for link route if none was explicitly selected by client
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67661/#review205164 --- Ship it! Ship It! - Kenneth Giusti On June 20, 2018, 5 p.m., Gordon Sim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67661/ > --- > > (Updated June 20, 2018, 5 p.m.) > > > Review request for qpid, Alan Conway and Ted Ross. > > > Bugs: DISPATCH-1020 > https://issues.apache.org/jira/browse/DISPATCH-1020 > > > Repository: qpid-dispatch > > > Description > --- > > The default expiry policy for a terminus is session-end. Now that link routed > links share a session by default, this is likely not what is wanted (terminus > state on a broker would have to be kept until the session ended, which is > when the connection between broker and router ends). This change propagates > an explicit link-detach policy where none is explicitly requested by the > client. If the client does request an explicit policy, that is propagated > without alteration. > > Note this requires a change to proton PROTON-1866, > https://reviews.apache.org/r/67659/ > > > Diffs > - > > include/qpid/dispatch/router_core.h 8f144b0 > src/router_core/connections.c 5fdc3bf > src/router_core/terminus.c 4c0e0a3 > tests/system_tests_link_routes.py 57e6d41 > > > Diff: https://reviews.apache.org/r/67661/diff/2/ > > > Testing > --- > > Automated tests added, all existing tests pass. > > > Thanks, > > Gordon Sim > >
Re: Review Request 67678: when indicating a routed link has been detached due to loss of connection, set close flag based on ability of terminus to survive disconnection
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67678/#review205155 --- Looks good to me. - Keith Wall On June 20, 2018, 9:29 p.m., Gordon Sim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67678/ > --- > > (Updated June 20, 2018, 9:29 p.m.) > > > Review request for qpid and Ted Ross. > > > Bugs: DISPATCH-1020 > https://issues.apache.org/jira/browse/DISPATCH-1020 > > > Repository: qpid-dispatch > > > Description > --- > > This ensures that the broker (or other route container) will clean-up the > terminus state when the client is disconnected, unless that state is supposed > to survive disconnection. > > This is an alternative approach to solving DISPATCH-1020 to > https://reviews.apache.org/r/67661/ > > > Diffs > - > > src/router_core/connections.c 5fdc3bf > src/router_core/router_core_private.h cd2ffa4 > > > Diff: https://reviews.apache.org/r/67678/diff/1/ > > > Testing > --- > > > Thanks, > > Gordon Sim > >
