[GitHub] [qpid-dispatch] ldebello commented on issue #459: [WIP] DISPATCH-1282 - Support for building on macOS
ldebello commented on issue #459: [WIP] DISPATCH-1282 - Support for building on macOS URL: https://github.com/apache/qpid-dispatch/pull/459#issuecomment-497895348 Hi guys, I am trying to execute the router in osx, did you have luck? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1346) Create documentation for priority delivery
[ https://issues.apache.org/jira/browse/DISPATCH-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853394#comment-16853394 ] ASF GitHub Bot commented on DISPATCH-1346: -- mgoulish commented on issue #513: DISPATCH-1346: Create doc for prioritized message delivery URL: https://github.com/apache/qpid-dispatch/pull/513#issuecomment-497846132 * priority range shall be between 0 and 9. Neither less than 0 nor greater than 9 shall it be, but 0-9 shall be the range of the priority. * there are two ways that a user can make a message get a priority. One is by assigning the message a priority directly. The other is by sending the message to an address that has a priority assigned to it.In the Dispatch Router config file, when you are defining an address, you can stick a priority descriptor in there. And if a message with a priority gets sent to an address with a priority, then the address priority wins. * priority only affects how messages are processed on inter-router links between interior routers. * Higher numbers are higher priority. It's not like golf. * The reason the default priority is 4 is so that you can set some message to be *lower* than default if you want to. * If you set a message's priority to 0 we just don't bother sending it at all. Who cares? Instead we break it down into its constituent 1s and 0s which are then used as lubricant in the code. * That last point ^^^ is completely false. Sorry. Low blood sugar. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create documentation for priority delivery > -- > > Key: DISPATCH-1346 > URL: https://issues.apache.org/jira/browse/DISPATCH-1346 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Reporter: Ben Hardesty >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] mgoulish edited a comment on issue #513: DISPATCH-1346: Create doc for prioritized message delivery
mgoulish edited a comment on issue #513: DISPATCH-1346: Create doc for prioritized message delivery URL: https://github.com/apache/qpid-dispatch/pull/513#issuecomment-497846132 * priority range shall be between 0 and 9. Neither less than 0 nor greater than 9 shall it be, but 0-9 shall be the range of the priority. * there are two ways that a user can make a message get a priority. One is by assigning the message a priority directly. The other is by sending the message to an address that has a priority assigned to it.In the Dispatch Router config file, when you are defining an address, you can stick a priority descriptor in there. And if a message with a priority gets sent to an address with a priority, then the address priority wins. * priority only affects how messages are processed on inter-router links between interior routers. * Higher numbers are higher priority. It's not like golf. * The reason the default priority is 4 is so that you can set some message to be *lower* than default if you want to. * If you set a message's priority to 0 we just don't bother sending it at all. Who cares? Instead we break it down into its constituent 1s and 0s which are then used as lubricant in the code. * That last point ^^^ is completely false. Sorry. Low blood sugar. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1346) Create documentation for priority delivery
[ https://issues.apache.org/jira/browse/DISPATCH-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853392#comment-16853392 ] ASF GitHub Bot commented on DISPATCH-1346: -- mgoulish commented on issue #513: DISPATCH-1346: Create doc for prioritized message delivery URL: https://github.com/apache/qpid-dispatch/pull/513#issuecomment-497846132 * priority range shall be between 0 and 9. Neither less than 0 nor greater than 9 shall it be, but 0-9 shall be the range of the priority. * there are two ways that a user can make a message get a priority. One is by assigning the message a priority directly. The other is by sending the message to an address that has a priority assigned to it.In the Dispatch Router config file, when you are defining an address, you can stick a priority descriptor in there. And if a message with a priority gets sent to an address with a priority, then the address priority wins. * priority only affects how messages are processed on inter-router links between interior routers. * Higher number are higher priority. It's not like golf. * The reason the default priority is 4 is so that you can set some message to be *lower* than default if you want to. * If you set a message's priority to 0 we just don't bother sending it at all. Who cares? Instead we break it down into its constituent 1s and 0s which are then used as lubricant in the code. * That last point ^^^ is completely false. Sorry. Low blood sugar. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create documentation for priority delivery > -- > > Key: DISPATCH-1346 > URL: https://issues.apache.org/jira/browse/DISPATCH-1346 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Reporter: Ben Hardesty >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] mgoulish commented on issue #513: DISPATCH-1346: Create doc for prioritized message delivery
mgoulish commented on issue #513: DISPATCH-1346: Create doc for prioritized message delivery URL: https://github.com/apache/qpid-dispatch/pull/513#issuecomment-497846132 * priority range shall be between 0 and 9. Neither less than 0 nor greater than 9 shall it be, but 0-9 shall be the range of the priority. * there are two ways that a user can make a message get a priority. One is by assigning the message a priority directly. The other is by sending the message to an address that has a priority assigned to it.In the Dispatch Router config file, when you are defining an address, you can stick a priority descriptor in there. And if a message with a priority gets sent to an address with a priority, then the address priority wins. * priority only affects how messages are processed on inter-router links between interior routers. * Higher number are higher priority. It's not like golf. * The reason the default priority is 4 is so that you can set some message to be *lower* than default if you want to. * If you set a message's priority to 0 we just don't bother sending it at all. Who cares? Instead we break it down into its constituent 1s and 0s which are then used as lubricant in the code. * That last point ^^^ is completely false. Sorry. Low blood sugar. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-cpp] ChugR commented on issue #21: QPID-8319: clear persistent connection context on autodeleted msgs
ChugR commented on issue #21: QPID-8319: clear persistent connection context on autodeleted msgs URL: https://github.com/apache/qpid-cpp/pull/21#issuecomment-497845984 This patch breaks a self test. 10: qpid_tests.broker_0_10.new_api.GeneralTests.test_nolocal_rerouted ... start 10: assertEqual failure: ['a', 'b', 'c'] != ['a', 'c'] 10: qpid_tests.broker_0_10.new_api.GeneralTests.test_nolocal_rerouted ... fail 10: Error during test: Traceback (most recent call last): 10: File "/home/chug/.local/bin/qpid-python-test", line 340, in run 10: phase() 10: File "/home/chug/.local/lib/python2.7/site-packages/qpid_tests/broker_0_10/new_api.py", line 179, in test_nolocal_rerouted 10: self.assertEqual(received, ["a", "c"]) 10: File "/home/chug/.local/lib/python2.7/site-packages/qpid_tests/broker_0_10/new_api.py", line 39, in assertEqual 10: assert None 10: AssertionError This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8319) QMF requests rerouted to QMF exchange may crash with invalid connection
[ https://issues.apache.org/jira/browse/QPID-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853391#comment-16853391 ] ASF GitHub Bot commented on QPID-8319: -- ChugR commented on pull request #21: QPID-8319: clear persistent connection context on autodeleted msgs URL: https://github.com/apache/qpid-cpp/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > QMF requests rerouted to QMF exchange may crash with invalid connection > --- > > Key: QPID-8319 > URL: https://issues.apache.org/jira/browse/QPID-8319 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker >Affects Versions: qpid-cpp-1.39.0 >Reporter: Chuck Rolke >Priority: Major > > Reported by Pavel in [https://bugzilla.redhat.com/show_bug.cgi?id=1713560] > Description of problem: > User story: when running concurrently 2 times a program that: > 1) Creates a queue on the broker "HelloQueue" > 2) Creates a second queue called "HelloQueue.AutoDelete" with auto-delete > set and alternate exchange set to "qmf.default.direct" and hold open the > Receiver that is subscribed to it. > 3) Puts a QMF message into the "HelloQueue.AutoDelete" queue that will > delete the "HelloQueue" queue when it is processed. > 4) Waits 10 seconds. > 5) Closes the receiver, triggering the auto-delete of > "HelloQueue.AutoDelete". > Then the QMF message will be sent to "qmf.default.direct" because of the > alternate exchange, resulting in the deletion of "HelloQueue" regardless of > whether or not there are other subscribers connected to it. And with some > high probability, the 2nd QMF request from just dropped connection will > attempt to be processed, but causes segfault. > Version-Release number of selected component (if applicable): > qpid-cpp 1.36.0-15 (or -21 or -21+hf2), I expect any > How reproducible: > 75% in my case > Steps to Reproduce: > 1. Compile attached program. > 2. qpidd & > 3. ./QmfBrokerCrashRepro localhost:5672 & ./QmfBrokerCrashRepro > localhost:5672 & > Actual results: > client program aborts every time (unhandled exception, no deal), but very > often qpidd segfaults as well, with backtrace: > {code:java} > (gdb) bt > #0 0x in ?? () > #1 0x7f9b5cdca752 in qpid::management::(anonymous > namespace)::ScopedManagementContext::getUserId (this=) > at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementAgent.cpp:105 > #2 0x7f9b5cde8055 in > qpid::management::ManagementAgent::dispatchAgentCommand (this=0x1680930, > msg=..., viaLocal=true) > at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementAgent.cpp:2347 > #3 0x7f9b5cde8958 in qpid::management::ManagementAgent::dispatchCommand > (this=0x1680930, deliverable=, routingKey="broker", > topic=false, qmfVersion=2) > at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementAgent.cpp:1255 > #4 0x7f9b5cdfb219 in qpid::broker::ManagementDirectExchange::route > (this=0x168b6f0, msg=...) at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementDirectExchange.cpp:48 > #5 0x7f9b5cccfa2a in qpid::broker::Exchange::routeWithAlternate > (this=0x168b768, msg=...) at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Exchange.cpp:410 > #6 0x7f9b5ccfddb5 in qpid::broker::Queue::reroute (e= out>, m=) at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:1761 > #7 0x7f9b5ccfe006 in qpid::broker::Queue::abandoned (this=0x16ba740, > message=) at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:1156 > #8 0x7f9b5ccf16cd in operator() (this=0x16ba740, maxCount=0, p=..., > f=..., type=, triggerAutoDelete=false, maxTests=0) > at /usr/include/boost/function/function_template.hpp:1013 > #9 qpid::broker::Queue::remove (this=0x16ba740, maxCount=0, p=..., f=..., > type=, triggerAutoDelete=false, maxTests=0) > at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:795 > #10 0x7f9b5ccf49d5 in qpid::broker::Queue::destroyed (this=0x16ba740) at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:1167 > #11 0x7f9b5cd73b09 in qpid::broker::QueueRegistry::destroyIfUntouched > (this=0x167f2f8, targetQ=, version= out>, connectionId="", userId="") > at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/QueueRegistry.cpp:156 > #12 0x7f9b5ccee336 in qpid::broker::Queue::tryAutoDelete (this=0x16ba740, > expectedVersion=1) at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:1358 > #13 0x7f9b5ccee834 in
[jira] [Commented] (QPID-8319) QMF requests rerouted to QMF exchange may crash with invalid connection
[ https://issues.apache.org/jira/browse/QPID-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853390#comment-16853390 ] ASF GitHub Bot commented on QPID-8319: -- ChugR commented on issue #21: QPID-8319: clear persistent connection context on autodeleted msgs URL: https://github.com/apache/qpid-cpp/pull/21#issuecomment-497845984 This patch breaks a self test. 10: qpid_tests.broker_0_10.new_api.GeneralTests.test_nolocal_rerouted ... start 10: assertEqual failure: ['a', 'b', 'c'] != ['a', 'c'] 10: qpid_tests.broker_0_10.new_api.GeneralTests.test_nolocal_rerouted ... fail 10: Error during test: Traceback (most recent call last): 10: File "/home/chug/.local/bin/qpid-python-test", line 340, in run 10: phase() 10: File "/home/chug/.local/lib/python2.7/site-packages/qpid_tests/broker_0_10/new_api.py", line 179, in test_nolocal_rerouted 10: self.assertEqual(received, ["a", "c"]) 10: File "/home/chug/.local/lib/python2.7/site-packages/qpid_tests/broker_0_10/new_api.py", line 39, in assertEqual 10: assert None 10: AssertionError This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > QMF requests rerouted to QMF exchange may crash with invalid connection > --- > > Key: QPID-8319 > URL: https://issues.apache.org/jira/browse/QPID-8319 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker >Affects Versions: qpid-cpp-1.39.0 >Reporter: Chuck Rolke >Priority: Major > > Reported by Pavel in [https://bugzilla.redhat.com/show_bug.cgi?id=1713560] > Description of problem: > User story: when running concurrently 2 times a program that: > 1) Creates a queue on the broker "HelloQueue" > 2) Creates a second queue called "HelloQueue.AutoDelete" with auto-delete > set and alternate exchange set to "qmf.default.direct" and hold open the > Receiver that is subscribed to it. > 3) Puts a QMF message into the "HelloQueue.AutoDelete" queue that will > delete the "HelloQueue" queue when it is processed. > 4) Waits 10 seconds. > 5) Closes the receiver, triggering the auto-delete of > "HelloQueue.AutoDelete". > Then the QMF message will be sent to "qmf.default.direct" because of the > alternate exchange, resulting in the deletion of "HelloQueue" regardless of > whether or not there are other subscribers connected to it. And with some > high probability, the 2nd QMF request from just dropped connection will > attempt to be processed, but causes segfault. > Version-Release number of selected component (if applicable): > qpid-cpp 1.36.0-15 (or -21 or -21+hf2), I expect any > How reproducible: > 75% in my case > Steps to Reproduce: > 1. Compile attached program. > 2. qpidd & > 3. ./QmfBrokerCrashRepro localhost:5672 & ./QmfBrokerCrashRepro > localhost:5672 & > Actual results: > client program aborts every time (unhandled exception, no deal), but very > often qpidd segfaults as well, with backtrace: > {code:java} > (gdb) bt > #0 0x in ?? () > #1 0x7f9b5cdca752 in qpid::management::(anonymous > namespace)::ScopedManagementContext::getUserId (this=) > at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementAgent.cpp:105 > #2 0x7f9b5cde8055 in > qpid::management::ManagementAgent::dispatchAgentCommand (this=0x1680930, > msg=..., viaLocal=true) > at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementAgent.cpp:2347 > #3 0x7f9b5cde8958 in qpid::management::ManagementAgent::dispatchCommand > (this=0x1680930, deliverable=, routingKey="broker", > topic=false, qmfVersion=2) > at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementAgent.cpp:1255 > #4 0x7f9b5cdfb219 in qpid::broker::ManagementDirectExchange::route > (this=0x168b6f0, msg=...) at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementDirectExchange.cpp:48 > #5 0x7f9b5cccfa2a in qpid::broker::Exchange::routeWithAlternate > (this=0x168b768, msg=...) at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Exchange.cpp:410 > #6 0x7f9b5ccfddb5 in qpid::broker::Queue::reroute (e= out>, m=) at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:1761 > #7 0x7f9b5ccfe006 in qpid::broker::Queue::abandoned (this=0x16ba740, > message=) at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:1156 > #8 0x7f9b5ccf16cd in operator() (this=0x16ba740, maxCount=0, p=..., > f=..., type=, triggerAutoDelete=false, maxTests=0) > at
[GitHub] [qpid-cpp] ChugR closed pull request #21: QPID-8319: clear persistent connection context on autodeleted msgs
ChugR closed pull request #21: QPID-8319: clear persistent connection context on autodeleted msgs URL: https://github.com/apache/qpid-cpp/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1350) Update logging/monitoring documentation
[ https://issues.apache.org/jira/browse/DISPATCH-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853366#comment-16853366 ] ASF GitHub Bot commented on DISPATCH-1350: -- bhardesty commented on pull request #517: DISPATCH-1350 - Update logging and management doc URL: https://github.com/apache/qpid-dispatch/pull/517 Replaced the example in the ROUTER log doc with a new example that demonstrates how to use the log to trace a connection and its link. Added a new procedure for closing a connection. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update logging/monitoring documentation > --- > > Key: DISPATCH-1350 > URL: https://issues.apache.org/jira/browse/DISPATCH-1350 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Reporter: Ben Hardesty >Priority: Major > > In the Dispatch Router user guide, the logging documentation should be > enhanced to demonstrate the improvements made in DISPATCH-1289. > In addition, management control for closing a connection should be documented. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] bhardesty opened a new pull request #517: DISPATCH-1350 - Update logging and management doc
bhardesty opened a new pull request #517: DISPATCH-1350 - Update logging and management doc URL: https://github.com/apache/qpid-dispatch/pull/517 Replaced the example in the ROUTER log doc with a new example that demonstrates how to use the log to trace a connection and its link. Added a new procedure for closing a connection. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8319) QMF requests rerouted to QMF exchange may crash with invalid connection
[ https://issues.apache.org/jira/browse/QPID-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853331#comment-16853331 ] ASF GitHub Bot commented on QPID-8319: -- ChugR commented on pull request #21: QPID-8319: clear persistent connection context on autodeleted msgs URL: https://github.com/apache/qpid-cpp/pull/21 In the event that 1) the message is a QMF request 2) it is in an autoDelete queue 3) the queue has an alternate exchange 'qmf.default.direct' 4) the original connection is lost then the router may segfault or otherwise misbehave since the message's connection context is now invalid. This patch clears the connection context for *all* autodeleted messages and as such may be too aggressive clearing the context. Review Needed This patch does not include a self test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > QMF requests rerouted to QMF exchange may crash with invalid connection > --- > > Key: QPID-8319 > URL: https://issues.apache.org/jira/browse/QPID-8319 > Project: Qpid > Issue Type: Improvement > Components: C++ Broker >Affects Versions: qpid-cpp-1.39.0 >Reporter: Chuck Rolke >Priority: Major > > Reported by Pavel in [https://bugzilla.redhat.com/show_bug.cgi?id=1713560] > Description of problem: > User story: when running concurrently 2 times a program that: > 1) Creates a queue on the broker "HelloQueue" > 2) Creates a second queue called "HelloQueue.AutoDelete" with auto-delete > set and alternate exchange set to "qmf.default.direct" and hold open the > Receiver that is subscribed to it. > 3) Puts a QMF message into the "HelloQueue.AutoDelete" queue that will > delete the "HelloQueue" queue when it is processed. > 4) Waits 10 seconds. > 5) Closes the receiver, triggering the auto-delete of > "HelloQueue.AutoDelete". > Then the QMF message will be sent to "qmf.default.direct" because of the > alternate exchange, resulting in the deletion of "HelloQueue" regardless of > whether or not there are other subscribers connected to it. And with some > high probability, the 2nd QMF request from just dropped connection will > attempt to be processed, but causes segfault. > Version-Release number of selected component (if applicable): > qpid-cpp 1.36.0-15 (or -21 or -21+hf2), I expect any > How reproducible: > 75% in my case > Steps to Reproduce: > 1. Compile attached program. > 2. qpidd & > 3. ./QmfBrokerCrashRepro localhost:5672 & ./QmfBrokerCrashRepro > localhost:5672 & > Actual results: > client program aborts every time (unhandled exception, no deal), but very > often qpidd segfaults as well, with backtrace: > {code:java} > (gdb) bt > #0 0x in ?? () > #1 0x7f9b5cdca752 in qpid::management::(anonymous > namespace)::ScopedManagementContext::getUserId (this=) > at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementAgent.cpp:105 > #2 0x7f9b5cde8055 in > qpid::management::ManagementAgent::dispatchAgentCommand (this=0x1680930, > msg=..., viaLocal=true) > at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementAgent.cpp:2347 > #3 0x7f9b5cde8958 in qpid::management::ManagementAgent::dispatchCommand > (this=0x1680930, deliverable=, routingKey="broker", > topic=false, qmfVersion=2) > at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementAgent.cpp:1255 > #4 0x7f9b5cdfb219 in qpid::broker::ManagementDirectExchange::route > (this=0x168b6f0, msg=...) at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementDirectExchange.cpp:48 > #5 0x7f9b5cccfa2a in qpid::broker::Exchange::routeWithAlternate > (this=0x168b768, msg=...) at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Exchange.cpp:410 > #6 0x7f9b5ccfddb5 in qpid::broker::Queue::reroute (e= out>, m=) at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:1761 > #7 0x7f9b5ccfe006 in qpid::broker::Queue::abandoned (this=0x16ba740, > message=) at > /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:1156 > #8 0x7f9b5ccf16cd in operator() (this=0x16ba740, maxCount=0, p=..., > f=..., type=, triggerAutoDelete=false, maxTests=0) > at /usr/include/boost/function/function_template.hpp:1013 > #9 qpid::broker::Queue::remove (this=0x16ba740, maxCount=0, p=..., f=..., > type=, triggerAutoDelete=false, maxTests=0) > at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:795 > #10 0x7f9b5ccf49d5 in qpid::broker::Queue::destroyed (this=0x16ba740)
[GitHub] [qpid-cpp] ChugR opened a new pull request #21: QPID-8319: clear persistent connection context on autodeleted msgs
ChugR opened a new pull request #21: QPID-8319: clear persistent connection context on autodeleted msgs URL: https://github.com/apache/qpid-cpp/pull/21 In the event that 1) the message is a QMF request 2) it is in an autoDelete queue 3) the queue has an alternate exchange 'qmf.default.direct' 4) the original connection is lost then the router may segfault or otherwise misbehave since the message's connection context is now invalid. This patch clears the connection context for *all* autodeleted messages and as such may be too aggressive clearing the context. Review Needed This patch does not include a self test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity
ganeshmurthy commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity URL: https://github.com/apache/qpid-dispatch/pull/514#issuecomment-497819534 > Given that it would make the code more complex I can close this: considering the context of utilization it won't bring any improvement +1 Say a message has 4 router hops on its way from sender to receiver, will there ever be more than one buffer worth of each annotation (to_override or trace or ingress) given each of them get a buffer size of 512 bytes. @franz1981 is trying to compact these buffers but it comes into play *only* if there is more than one buffer. In 99% percent of the cases one buffer is more than enough space to hold one of these annotations, I just realized that I am restating what @ChugR said earlier. Although this PR is a good one, I agree that the context of utilization it won't bring any improvement. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1349) qd_buffer_list_clone is wasting dst buffers available capacity
[ https://issues.apache.org/jira/browse/DISPATCH-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853322#comment-16853322 ] ASF GitHub Bot commented on DISPATCH-1349: -- ganeshmurthy commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity URL: https://github.com/apache/qpid-dispatch/pull/514#issuecomment-497819534 > Given that it would make the code more complex I can close this: considering the context of utilization it won't bring any improvement +1 Say a message has 4 router hops on its way from sender to receiver, will there ever be more than one buffer worth of each annotation (to_override or trace or ingress) given each of them get a buffer size of 512 bytes. @franz1981 is trying to compact these buffers but it comes into play *only* if there is more than one buffer. In 99% percent of the cases one buffer is more than enough space to hold one of these annotations, I just realized that I am restating what @ChugR said earlier. Although this PR is a good one, I agree that the context of utilization it won't bring any improvement. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > qd_buffer_list_clone is wasting dst buffers available capacity > -- > > Key: DISPATCH-1349 > URL: https://issues.apache.org/jira/browse/DISPATCH-1349 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Routing Engine >Affects Versions: 1.7.0 >Reporter: Francesco Nigro >Priority: Minor > > qd_buffer_list_clone is not filling completely destination buffers available > space (if any) after the first memcpy, allocating unnecessary qd_buffer(s) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2056) [proton-python] on_settled callback not called when disposition arrives in 2 frames
[ https://issues.apache.org/jira/browse/PROTON-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853302#comment-16853302 ] Robbie Gemmell commented on PROTON-2056: {quote}it is expected that the sender should respond to the release only disposition with a settle {quote} I'm not sure it is expected. The example in the spec of this is for exactly-once (though thats only noted later) which isnt being done here. I'm not sure the spec specifically covers what happens in the unusual case of a terminal outcome being sent as not settled by a peer that is meant to settle first, but settling at the sender first regardless seems to go against the general intent in my mind. Another interesting thing would be transactional state (which can be updated settled or not, and imposes behavioural differences) and how the delivery would be impacted in the face of sender settling first. I think the patch you proposed is the correct thing to do, its whats being done in other cases. The main thing here is perhaps just that Dispatch is actually being a bit odd in not settling the message at the point of release, which I believe its only doing at all due to PROTON-1914. {quote}in the case where the sender settles a delivery that reported a terminal state you should get an {{on_settled}} callback - this is because the delivery has been settled at both receiver and sender. {quote} It hasn't necessarily been settled at the receiver, thats why we can get into the situation. It also seems that it would need to distinguish between an auto-settlement and a regular-local-settlement, since it would seem a bit odd to me that you would get a callback about a delivery settlement when you explicitly call settle, which means you've forgot about it already and so couldnt action anything provided by a callback. Again I think the appropriate thing is to do what your patch does. You will get an on_settled when they settle, if you have not already [explicitly] settled, in which case you shouldnt get a callback (what do you do with a callback about something you already indicated you have forgotten?). > [proton-python] on_settled callback not called when disposition arrives in 2 > frames > > > Key: PROTON-2056 > URL: https://issues.apache.org/jira/browse/PROTON-2056 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c, python-binding >Affects Versions: proton-c-0.28.0 >Reporter: Ganesh Murthy >Priority: Major > Attachments: proton-2056.patch > > > When very large anonymous messages are sent to the router and these messages > have no receiver, they are immediately released. The router waits for the > entire large message to arrive in the router before settling it. Due to this, > in some cases, two disposition frames are sent for the same delivery, the > first has state=released and the second has settled=true as seen below > > {noformat} > 0x56330c891430]:0 <- @disposition(21) [role=true, first=315, > state=@released(38) []] > [0x56330c891430]:0 <- @disposition(21) [role=true, first=315, settled=true, > state=@released(38) []]{noformat} > > When this case happens, the on_settled is not called for the python binding. > The on_released is called. The on_settled must be called when a settlement > arrives for every delivery. I observed this behavior in a python system test > in Dispatch Router. The test called > test_51_anon_sender_mobile_address_large_msg_edge_to_edge_two_interior can be > found in tests/system_tests_edge_router.py > The test does not fail all the time but when it does it is due to the > on_settled not being called for deliveries that have this two part > disposition. > > I tried in vain to write a standalone python reproducer. I could not do it. > > To run the specific system test run the following from the > qpid-dispatch/build folder > > {noformat} > /usr/bin/python "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" > "-m" "unittest" "-v" > "system_tests_edge_router.RouterTest.test_51_anon_sender_mobile_address_large_msg_edge_to_edge_two_interior"{noformat} > > The following is the test failure > {noformat} > test_51_anon_sender_mobile_address_large_msg_edge_to_edge_two_interior > (system_tests_edge_router.RouterTest) ... FAIL > == > FAIL: test_51_anon_sender_mobile_address_large_msg_edge_to_edge_two_interior > (system_tests_edge_router.RouterTest) > -- > Traceback (most recent call last): > File > "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_edge_router.py", > line 964, in > test_51_anon_sender_mobile_address_large_msg_edge_to_edge_two_interior >
[jira] [Created] (QPID-8319) QMF requests rerouted to QMF exchange may crash with invalid connection
Chuck Rolke created QPID-8319: - Summary: QMF requests rerouted to QMF exchange may crash with invalid connection Key: QPID-8319 URL: https://issues.apache.org/jira/browse/QPID-8319 Project: Qpid Issue Type: Improvement Components: C++ Broker Affects Versions: qpid-cpp-1.39.0 Reporter: Chuck Rolke Reported by Pavel in [https://bugzilla.redhat.com/show_bug.cgi?id=1713560] Description of problem: User story: when running concurrently 2 times a program that: 1) Creates a queue on the broker "HelloQueue" 2) Creates a second queue called "HelloQueue.AutoDelete" with auto-delete set and alternate exchange set to "qmf.default.direct" and hold open the Receiver that is subscribed to it. 3) Puts a QMF message into the "HelloQueue.AutoDelete" queue that will delete the "HelloQueue" queue when it is processed. 4) Waits 10 seconds. 5) Closes the receiver, triggering the auto-delete of "HelloQueue.AutoDelete". Then the QMF message will be sent to "qmf.default.direct" because of the alternate exchange, resulting in the deletion of "HelloQueue" regardless of whether or not there are other subscribers connected to it. And with some high probability, the 2nd QMF request from just dropped connection will attempt to be processed, but causes segfault. Version-Release number of selected component (if applicable): qpid-cpp 1.36.0-15 (or -21 or -21+hf2), I expect any How reproducible: 75% in my case Steps to Reproduce: 1. Compile attached program. 2. qpidd & 3. ./QmfBrokerCrashRepro localhost:5672 & ./QmfBrokerCrashRepro localhost:5672 & Actual results: client program aborts every time (unhandled exception, no deal), but very often qpidd segfaults as well, with backtrace: {code:java} (gdb) bt #0 0x in ?? () #1 0x7f9b5cdca752 in qpid::management::(anonymous namespace)::ScopedManagementContext::getUserId (this=) at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementAgent.cpp:105 #2 0x7f9b5cde8055 in qpid::management::ManagementAgent::dispatchAgentCommand (this=0x1680930, msg=..., viaLocal=true) at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementAgent.cpp:2347 #3 0x7f9b5cde8958 in qpid::management::ManagementAgent::dispatchCommand (this=0x1680930, deliverable=, routingKey="broker", topic=false, qmfVersion=2) at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementAgent.cpp:1255 #4 0x7f9b5cdfb219 in qpid::broker::ManagementDirectExchange::route (this=0x168b6f0, msg=...) at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/management/ManagementDirectExchange.cpp:48 #5 0x7f9b5cccfa2a in qpid::broker::Exchange::routeWithAlternate (this=0x168b768, msg=...) at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Exchange.cpp:410 #6 0x7f9b5ccfddb5 in qpid::broker::Queue::reroute (e=, m=) at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:1761 #7 0x7f9b5ccfe006 in qpid::broker::Queue::abandoned (this=0x16ba740, message=) at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:1156 #8 0x7f9b5ccf16cd in operator() (this=0x16ba740, maxCount=0, p=..., f=..., type=, triggerAutoDelete=false, maxTests=0) at /usr/include/boost/function/function_template.hpp:1013 #9 qpid::broker::Queue::remove (this=0x16ba740, maxCount=0, p=..., f=..., type=, triggerAutoDelete=false, maxTests=0) at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:795 #10 0x7f9b5ccf49d5 in qpid::broker::Queue::destroyed (this=0x16ba740) at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:1167 #11 0x7f9b5cd73b09 in qpid::broker::QueueRegistry::destroyIfUntouched (this=0x167f2f8, targetQ=, version=, connectionId="", userId="") at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/QueueRegistry.cpp:156 #12 0x7f9b5ccee336 in qpid::broker::Queue::tryAutoDelete (this=0x16ba740, expectedVersion=1) at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:1358 #13 0x7f9b5ccee834 in qpid::broker::Queue::scheduleAutoDelete (this=0x16ba740, immediate=false) at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:1342 #14 0x7f9b5ccef626 in qpid::broker::Queue::cancel (this=0x16ba740, c=..., connectionId="qpid.[::1]:5672-[::1]:54658", userId="anonymous@QPID") at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/Queue.cpp:638 #15 0x7f9b5cd90eca in qpid::broker::SemanticState::cancel (this=0x7f9b4c00a078, c=...) at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/SemanticState.cpp:475 #16 0x7f9b5cd98775 in qpid::broker::SemanticState::closed (this=0x7f9b4c00a078) at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/SemanticState.cpp:111 #17 0x7f9b5cdb0301 in qpid::broker::SessionState::~SessionState (this=0x7f9b4c009eb0, __in_chrg=) at /usr/src/debug/qpid-cpp-1.36.0/src/qpid/broker/SessionState.cpp:107 #18 0x7f9b5cdb08a9 in
[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity
ganeshmurthy commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity URL: https://github.com/apache/qpid-dispatch/pull/514#issuecomment-497808371 This PR looks good and can be committed once @ted-ross has had a chance to look at it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1349) qd_buffer_list_clone is wasting dst buffers available capacity
[ https://issues.apache.org/jira/browse/DISPATCH-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853282#comment-16853282 ] ASF GitHub Bot commented on DISPATCH-1349: -- ganeshmurthy commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity URL: https://github.com/apache/qpid-dispatch/pull/514#issuecomment-497808371 This PR looks good and can be committed once @ted-ross has had a chance to look at it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > qd_buffer_list_clone is wasting dst buffers available capacity > -- > > Key: DISPATCH-1349 > URL: https://issues.apache.org/jira/browse/DISPATCH-1349 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Routing Engine >Affects Versions: 1.7.0 >Reporter: Francesco Nigro >Priority: Minor > > qd_buffer_list_clone is not filling completely destination buffers available > space (if any) after the first memcpy, allocating unnecessary qd_buffer(s) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity
ganeshmurthy commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity URL: https://github.com/apache/qpid-dispatch/pull/514#issuecomment-497795391 My next observation is that the msg->ma_to_override, msg->ma_trace and msg->ma_ingress always has at least one buffer associated with them even in the one router single sender, single receiver case. If we have only one router and the sender is not sending in any annotations and there is only one receiver on the same standalone router, why are these buffer populated in the first place and since they are populated, we are performing the extra overhead of copying them. If a message visits only one router in its lifetime, this seems like a waste of time This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1349) qd_buffer_list_clone is wasting dst buffers available capacity
[ https://issues.apache.org/jira/browse/DISPATCH-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853235#comment-16853235 ] ASF GitHub Bot commented on DISPATCH-1349: -- ganeshmurthy commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity URL: https://github.com/apache/qpid-dispatch/pull/514#issuecomment-497790642 My first question which is not related to the contents of this PR is why is this function returning an unsigned int ? The returned value is not used anywhere inside the actual router source code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > qd_buffer_list_clone is wasting dst buffers available capacity > -- > > Key: DISPATCH-1349 > URL: https://issues.apache.org/jira/browse/DISPATCH-1349 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Routing Engine >Affects Versions: 1.7.0 >Reporter: Francesco Nigro >Priority: Minor > > qd_buffer_list_clone is not filling completely destination buffers available > space (if any) after the first memcpy, allocating unnecessary qd_buffer(s) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity
ganeshmurthy commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity URL: https://github.com/apache/qpid-dispatch/pull/514#issuecomment-497790642 My first question which is not related to the contents of this PR is why is this function returning an unsigned int ? The returned value is not used anywhere inside the actual router source code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1347) Update documentation for Dispatch Router console
[ https://issues.apache.org/jira/browse/DISPATCH-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853104#comment-16853104 ] ASF GitHub Bot commented on DISPATCH-1347: -- bhardesty commented on pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289432566 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110 +17,100 @@ specific language governing permissions and limitations under the License +[id='using-router-console'] = Using {ConsoleName} -[[console-overview]] -== Console Overview +{ConsoleName} is a web console for monitoring the status and performance of {RouterName} router networks. -The console is an HTML based web site that displays information about a qpid dispatch router network. +== Setting up access to the web console -The console requires an HTML web server that can serve static html, javascript, style sheets, and images. +Before you can access the web console, you must configure a `listener` to accept HTTP connections for the web console and serve the console files. -The console only provides limited information about the clients that are attached to the router network and is therfore more appropriate for administrators needing to know the layout and health of the router network. +.Procedure -[[console-installation]] -== Console Installation +. On the router from which you want to access the web console, open the {RouterConfigFile} configuration file. Review comment: Yes, the attribute is unresolved because it was introduced in another PR that hasn't been merged yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update documentation for Dispatch Router console > > > Key: DISPATCH-1347 > URL: https://issues.apache.org/jira/browse/DISPATCH-1347 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Reporter: Ben Hardesty >Priority: Major > > The documentation for the web console is out-of-date. It should be updated to > describe how to install and access the console. > > [https://qpid.apache.org/releases/qpid-dispatch-1.7.0/user-guide/index.html#using_apache_qpid_dispatch_router_console] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] bhardesty commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console
bhardesty commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289432566 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110 +17,100 @@ specific language governing permissions and limitations under the License +[id='using-router-console'] = Using {ConsoleName} -[[console-overview]] -== Console Overview +{ConsoleName} is a web console for monitoring the status and performance of {RouterName} router networks. -The console is an HTML based web site that displays information about a qpid dispatch router network. +== Setting up access to the web console -The console requires an HTML web server that can serve static html, javascript, style sheets, and images. +Before you can access the web console, you must configure a `listener` to accept HTTP connections for the web console and serve the console files. -The console only provides limited information about the clients that are attached to the router network and is therfore more appropriate for administrators needing to know the layout and health of the router network. +.Procedure -[[console-installation]] -== Console Installation +. On the router from which you want to access the web console, open the {RouterConfigFile} configuration file. Review comment: Yes, the attribute is unresolved because it was introduced in another PR that hasn't been merged yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1347) Update documentation for Dispatch Router console
[ https://issues.apache.org/jira/browse/DISPATCH-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852847#comment-16852847 ] ASF GitHub Bot commented on DISPATCH-1347: -- jbyrne-redhat commented on pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289306715 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110 +17,100 @@ specific language governing permissions and limitations under the License +[id='using-router-console'] = Using {ConsoleName} -[[console-overview]] -== Console Overview +{ConsoleName} is a web console for monitoring the status and performance of {RouterName} router networks. -The console is an HTML based web site that displays information about a qpid dispatch router network. +== Setting up access to the web console -The console requires an HTML web server that can serve static html, javascript, style sheets, and images. +Before you can access the web console, you must configure a `listener` to accept HTTP connections for the web console and serve the console files. -The console only provides limited information about the clients that are attached to the router network and is therfore more appropriate for administrators needing to know the layout and health of the router network. +.Procedure -[[console-installation]] -== Console Installation +. On the router from which you want to access the web console, open the {RouterConfigFile} configuration file. -[discrete] -=== Prerequisites - -The following need to be installed before running a console: - -* One or more dispatch routers. See the documentation for the dispatch -router for help in starting a router network. -* A websockets to tcp proxy. -* A web server. This can be any server capable of serving static -html/js/css/image files. - -[discrete] -=== Procedure - -To install a websockets to tcp proxy: +. Add a `listener` to serve the console. ++ +-- +This example creates a `listener` that clients can use to access the web console: +[options="nowrap",subs="+quotes"] -sudo dnf install python-websockify -websockify localhost:5673 localhost:5672 +listener { +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +} +`http`:: Set this attribute to `true` to specify that this `listener` should accept HTTP connections instead of plain AMQP connections. -This will start the proxy listening to ws traffic on port 5673 and -translating it to tcp on port 5672. One of the routers in the network -needs to have a listener configured on port 5672. That listener's role -should be 'normal'. For example: +`httpRootDir`:: Specify the absolute path to the directory that contains the web console HTML files. The default directory is `/usr/share/qpid-dispatch/console`. +-- +. If you want to secure access to the console, secure the `listener`. ++ +-- +For more information, see xref:securing-incoming-client-connections-{context}[]. This example adds basic user name and password authentication using SASL PLAIN. + +[options="nowrap",subs="+quotes"] listener { - host: 0.0.0.0 - role: normal - port: amqp - saslMechanisms: ANONYMOUS +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +authenticatePeer: yes +saslMechanisms: PLAIN } +-- -[[the-console-files]] -=== The Console Files - -The files for the console are located under the console/stand-alone -directory in the source tree -* 'index.html' -* 'plugin/' - -Copy these files to a directory under the the html or webapps directory -of your web server. For example, for apache tomcat the files should be -under webapps/dispatch. Then the console is available as 'http://localhost:8080/dispatch' - -[[console-operation]] -== Console Operation - -[[logging-in-to-a-router-network]] -=== Logging into a Router Network - -image:console_login.png[image] +. If you want to set up access to the web console from any other router in the router network, repeat this procedure for each router. -Enter the address of the websockets to tcp proxy that is connected to a router in the network. +== Accessing the web console -The Autostart checkbox, when checked, will automatically log in with the previous host:port the next time you start the console. +You can access the web console from a web browser. -[[overview-page]] -=== Overview Page +.Procedure -image:console_overview.png[image] +. In a web browser, navigate to the web console URL. ++ +-- +The web console URL is the : from the `listener` that you created to serve the web console. For example: `localhost:8672`. -On the overview page, aggregate information about routers, addresses, and connections is displayed. +The {ConsoleName} opens. If you
[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console
jbyrne-redhat commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289306715 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110 +17,100 @@ specific language governing permissions and limitations under the License +[id='using-router-console'] = Using {ConsoleName} -[[console-overview]] -== Console Overview +{ConsoleName} is a web console for monitoring the status and performance of {RouterName} router networks. -The console is an HTML based web site that displays information about a qpid dispatch router network. +== Setting up access to the web console -The console requires an HTML web server that can serve static html, javascript, style sheets, and images. +Before you can access the web console, you must configure a `listener` to accept HTTP connections for the web console and serve the console files. -The console only provides limited information about the clients that are attached to the router network and is therfore more appropriate for administrators needing to know the layout and health of the router network. +.Procedure -[[console-installation]] -== Console Installation +. On the router from which you want to access the web console, open the {RouterConfigFile} configuration file. -[discrete] -=== Prerequisites - -The following need to be installed before running a console: - -* One or more dispatch routers. See the documentation for the dispatch -router for help in starting a router network. -* A websockets to tcp proxy. -* A web server. This can be any server capable of serving static -html/js/css/image files. - -[discrete] -=== Procedure - -To install a websockets to tcp proxy: +. Add a `listener` to serve the console. ++ +-- +This example creates a `listener` that clients can use to access the web console: +[options="nowrap",subs="+quotes"] -sudo dnf install python-websockify -websockify localhost:5673 localhost:5672 +listener { +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +} +`http`:: Set this attribute to `true` to specify that this `listener` should accept HTTP connections instead of plain AMQP connections. -This will start the proxy listening to ws traffic on port 5673 and -translating it to tcp on port 5672. One of the routers in the network -needs to have a listener configured on port 5672. That listener's role -should be 'normal'. For example: +`httpRootDir`:: Specify the absolute path to the directory that contains the web console HTML files. The default directory is `/usr/share/qpid-dispatch/console`. +-- +. If you want to secure access to the console, secure the `listener`. ++ +-- +For more information, see xref:securing-incoming-client-connections-{context}[]. This example adds basic user name and password authentication using SASL PLAIN. + +[options="nowrap",subs="+quotes"] listener { - host: 0.0.0.0 - role: normal - port: amqp - saslMechanisms: ANONYMOUS +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +authenticatePeer: yes +saslMechanisms: PLAIN } +-- -[[the-console-files]] -=== The Console Files - -The files for the console are located under the console/stand-alone -directory in the source tree -* 'index.html' -* 'plugin/' - -Copy these files to a directory under the the html or webapps directory -of your web server. For example, for apache tomcat the files should be -under webapps/dispatch. Then the console is available as 'http://localhost:8080/dispatch' - -[[console-operation]] -== Console Operation - -[[logging-in-to-a-router-network]] -=== Logging into a Router Network - -image:console_login.png[image] +. If you want to set up access to the web console from any other router in the router network, repeat this procedure for each router. -Enter the address of the websockets to tcp proxy that is connected to a router in the network. +== Accessing the web console -The Autostart checkbox, when checked, will automatically log in with the previous host:port the next time you start the console. +You can access the web console from a web browser. -[[overview-page]] -=== Overview Page +.Procedure -image:console_overview.png[image] +. In a web browser, navigate to the web console URL. ++ +-- +The web console URL is the : from the `listener` that you created to serve the web console. For example: `localhost:8672`. -On the overview page, aggregate information about routers, addresses, and connections is displayed. +The {ConsoleName} opens. If you set up user name and password authentication, the *Connect* tab is displayed. +-- -[[topology-page]] -=== Topology Page +. If necessary, log in to the web console. ++ +-- +If you set up user name and password authentication, enter
[jira] [Commented] (DISPATCH-1347) Update documentation for Dispatch Router console
[ https://issues.apache.org/jira/browse/DISPATCH-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852832#comment-16852832 ] ASF GitHub Bot commented on DISPATCH-1347: -- jbyrne-redhat commented on pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289310152 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110 +17,100 @@ specific language governing permissions and limitations under the License +[id='using-router-console'] = Using {ConsoleName} -[[console-overview]] -== Console Overview +{ConsoleName} is a web console for monitoring the status and performance of {RouterName} router networks. -The console is an HTML based web site that displays information about a qpid dispatch router network. +== Setting up access to the web console -The console requires an HTML web server that can serve static html, javascript, style sheets, and images. +Before you can access the web console, you must configure a `listener` to accept HTTP connections for the web console and serve the console files. -The console only provides limited information about the clients that are attached to the router network and is therfore more appropriate for administrators needing to know the layout and health of the router network. +.Procedure -[[console-installation]] -== Console Installation +. On the router from which you want to access the web console, open the {RouterConfigFile} configuration file. -[discrete] -=== Prerequisites - -The following need to be installed before running a console: - -* One or more dispatch routers. See the documentation for the dispatch -router for help in starting a router network. -* A websockets to tcp proxy. -* A web server. This can be any server capable of serving static -html/js/css/image files. - -[discrete] -=== Procedure - -To install a websockets to tcp proxy: +. Add a `listener` to serve the console. ++ +-- +This example creates a `listener` that clients can use to access the web console: +[options="nowrap",subs="+quotes"] -sudo dnf install python-websockify -websockify localhost:5673 localhost:5672 +listener { +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +} +`http`:: Set this attribute to `true` to specify that this `listener` should accept HTTP connections instead of plain AMQP connections. -This will start the proxy listening to ws traffic on port 5673 and -translating it to tcp on port 5672. One of the routers in the network -needs to have a listener configured on port 5672. That listener's role -should be 'normal'. For example: +`httpRootDir`:: Specify the absolute path to the directory that contains the web console HTML files. The default directory is `/usr/share/qpid-dispatch/console`. +-- +. If you want to secure access to the console, secure the `listener`. ++ +-- +For more information, see xref:securing-incoming-client-connections-{context}[]. This example adds basic user name and password authentication using SASL PLAIN. Review comment: This is extremely nit-picky, but you introduce other examples with a : This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update documentation for Dispatch Router console > > > Key: DISPATCH-1347 > URL: https://issues.apache.org/jira/browse/DISPATCH-1347 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Reporter: Ben Hardesty >Priority: Major > > The documentation for the web console is out-of-date. It should be updated to > describe how to install and access the console. > > [https://qpid.apache.org/releases/qpid-dispatch-1.7.0/user-guide/index.html#using_apache_qpid_dispatch_router_console] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console
jbyrne-redhat commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289310152 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110 +17,100 @@ specific language governing permissions and limitations under the License +[id='using-router-console'] = Using {ConsoleName} -[[console-overview]] -== Console Overview +{ConsoleName} is a web console for monitoring the status and performance of {RouterName} router networks. -The console is an HTML based web site that displays information about a qpid dispatch router network. +== Setting up access to the web console -The console requires an HTML web server that can serve static html, javascript, style sheets, and images. +Before you can access the web console, you must configure a `listener` to accept HTTP connections for the web console and serve the console files. -The console only provides limited information about the clients that are attached to the router network and is therfore more appropriate for administrators needing to know the layout and health of the router network. +.Procedure -[[console-installation]] -== Console Installation +. On the router from which you want to access the web console, open the {RouterConfigFile} configuration file. -[discrete] -=== Prerequisites - -The following need to be installed before running a console: - -* One or more dispatch routers. See the documentation for the dispatch -router for help in starting a router network. -* A websockets to tcp proxy. -* A web server. This can be any server capable of serving static -html/js/css/image files. - -[discrete] -=== Procedure - -To install a websockets to tcp proxy: +. Add a `listener` to serve the console. ++ +-- +This example creates a `listener` that clients can use to access the web console: +[options="nowrap",subs="+quotes"] -sudo dnf install python-websockify -websockify localhost:5673 localhost:5672 +listener { +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +} +`http`:: Set this attribute to `true` to specify that this `listener` should accept HTTP connections instead of plain AMQP connections. -This will start the proxy listening to ws traffic on port 5673 and -translating it to tcp on port 5672. One of the routers in the network -needs to have a listener configured on port 5672. That listener's role -should be 'normal'. For example: +`httpRootDir`:: Specify the absolute path to the directory that contains the web console HTML files. The default directory is `/usr/share/qpid-dispatch/console`. +-- +. If you want to secure access to the console, secure the `listener`. ++ +-- +For more information, see xref:securing-incoming-client-connections-{context}[]. This example adds basic user name and password authentication using SASL PLAIN. Review comment: This is extremely nit-picky, but you introduce other examples with a : This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console
jbyrne-redhat commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289308421 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110 +17,100 @@ specific language governing permissions and limitations under the License +[id='using-router-console'] = Using {ConsoleName} -[[console-overview]] -== Console Overview +{ConsoleName} is a web console for monitoring the status and performance of {RouterName} router networks. -The console is an HTML based web site that displays information about a qpid dispatch router network. +== Setting up access to the web console -The console requires an HTML web server that can serve static html, javascript, style sheets, and images. +Before you can access the web console, you must configure a `listener` to accept HTTP connections for the web console and serve the console files. -The console only provides limited information about the clients that are attached to the router network and is therfore more appropriate for administrators needing to know the layout and health of the router network. +.Procedure -[[console-installation]] -== Console Installation +. On the router from which you want to access the web console, open the {RouterConfigFile} configuration file. -[discrete] -=== Prerequisites - -The following need to be installed before running a console: - -* One or more dispatch routers. See the documentation for the dispatch -router for help in starting a router network. -* A websockets to tcp proxy. -* A web server. This can be any server capable of serving static -html/js/css/image files. - -[discrete] -=== Procedure - -To install a websockets to tcp proxy: +. Add a `listener` to serve the console. ++ +-- +This example creates a `listener` that clients can use to access the web console: +[options="nowrap",subs="+quotes"] -sudo dnf install python-websockify -websockify localhost:5673 localhost:5672 +listener { +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +} +`http`:: Set this attribute to `true` to specify that this `listener` should accept HTTP connections instead of plain AMQP connections. Review comment: Is there anything to be said about the other attributes -- _host, port_, and _role_ -- or are these well understood by users? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1347) Update documentation for Dispatch Router console
[ https://issues.apache.org/jira/browse/DISPATCH-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852827#comment-16852827 ] ASF GitHub Bot commented on DISPATCH-1347: -- jbyrne-redhat commented on pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289308421 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110 +17,100 @@ specific language governing permissions and limitations under the License +[id='using-router-console'] = Using {ConsoleName} -[[console-overview]] -== Console Overview +{ConsoleName} is a web console for monitoring the status and performance of {RouterName} router networks. -The console is an HTML based web site that displays information about a qpid dispatch router network. +== Setting up access to the web console -The console requires an HTML web server that can serve static html, javascript, style sheets, and images. +Before you can access the web console, you must configure a `listener` to accept HTTP connections for the web console and serve the console files. -The console only provides limited information about the clients that are attached to the router network and is therfore more appropriate for administrators needing to know the layout and health of the router network. +.Procedure -[[console-installation]] -== Console Installation +. On the router from which you want to access the web console, open the {RouterConfigFile} configuration file. -[discrete] -=== Prerequisites - -The following need to be installed before running a console: - -* One or more dispatch routers. See the documentation for the dispatch -router for help in starting a router network. -* A websockets to tcp proxy. -* A web server. This can be any server capable of serving static -html/js/css/image files. - -[discrete] -=== Procedure - -To install a websockets to tcp proxy: +. Add a `listener` to serve the console. ++ +-- +This example creates a `listener` that clients can use to access the web console: +[options="nowrap",subs="+quotes"] -sudo dnf install python-websockify -websockify localhost:5673 localhost:5672 +listener { +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +} +`http`:: Set this attribute to `true` to specify that this `listener` should accept HTTP connections instead of plain AMQP connections. Review comment: Is there anything to be said about the other attributes -- _host, port_, and _role_ -- or are these well understood by users? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update documentation for Dispatch Router console > > > Key: DISPATCH-1347 > URL: https://issues.apache.org/jira/browse/DISPATCH-1347 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Reporter: Ben Hardesty >Priority: Major > > The documentation for the web console is out-of-date. It should be updated to > describe how to install and access the console. > > [https://qpid.apache.org/releases/qpid-dispatch-1.7.0/user-guide/index.html#using_apache_qpid_dispatch_router_console] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1347) Update documentation for Dispatch Router console
[ https://issues.apache.org/jira/browse/DISPATCH-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852819#comment-16852819 ] ASF GitHub Bot commented on DISPATCH-1347: -- jbyrne-redhat commented on pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289306715 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110 +17,100 @@ specific language governing permissions and limitations under the License +[id='using-router-console'] = Using {ConsoleName} -[[console-overview]] -== Console Overview +{ConsoleName} is a web console for monitoring the status and performance of {RouterName} router networks. -The console is an HTML based web site that displays information about a qpid dispatch router network. +== Setting up access to the web console -The console requires an HTML web server that can serve static html, javascript, style sheets, and images. +Before you can access the web console, you must configure a `listener` to accept HTTP connections for the web console and serve the console files. -The console only provides limited information about the clients that are attached to the router network and is therfore more appropriate for administrators needing to know the layout and health of the router network. +.Procedure -[[console-installation]] -== Console Installation +. On the router from which you want to access the web console, open the {RouterConfigFile} configuration file. -[discrete] -=== Prerequisites - -The following need to be installed before running a console: - -* One or more dispatch routers. See the documentation for the dispatch -router for help in starting a router network. -* A websockets to tcp proxy. -* A web server. This can be any server capable of serving static -html/js/css/image files. - -[discrete] -=== Procedure - -To install a websockets to tcp proxy: +. Add a `listener` to serve the console. ++ +-- +This example creates a `listener` that clients can use to access the web console: +[options="nowrap",subs="+quotes"] -sudo dnf install python-websockify -websockify localhost:5673 localhost:5672 +listener { +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +} +`http`:: Set this attribute to `true` to specify that this `listener` should accept HTTP connections instead of plain AMQP connections. -This will start the proxy listening to ws traffic on port 5673 and -translating it to tcp on port 5672. One of the routers in the network -needs to have a listener configured on port 5672. That listener's role -should be 'normal'. For example: +`httpRootDir`:: Specify the absolute path to the directory that contains the web console HTML files. The default directory is `/usr/share/qpid-dispatch/console`. +-- +. If you want to secure access to the console, secure the `listener`. ++ +-- +For more information, see xref:securing-incoming-client-connections-{context}[]. This example adds basic user name and password authentication using SASL PLAIN. + +[options="nowrap",subs="+quotes"] listener { - host: 0.0.0.0 - role: normal - port: amqp - saslMechanisms: ANONYMOUS +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +authenticatePeer: yes +saslMechanisms: PLAIN } +-- -[[the-console-files]] -=== The Console Files - -The files for the console are located under the console/stand-alone -directory in the source tree -* 'index.html' -* 'plugin/' - -Copy these files to a directory under the the html or webapps directory -of your web server. For example, for apache tomcat the files should be -under webapps/dispatch. Then the console is available as 'http://localhost:8080/dispatch' - -[[console-operation]] -== Console Operation - -[[logging-in-to-a-router-network]] -=== Logging into a Router Network - -image:console_login.png[image] +. If you want to set up access to the web console from any other router in the router network, repeat this procedure for each router. -Enter the address of the websockets to tcp proxy that is connected to a router in the network. +== Accessing the web console -The Autostart checkbox, when checked, will automatically log in with the previous host:port the next time you start the console. +You can access the web console from a web browser. -[[overview-page]] -=== Overview Page +.Procedure -image:console_overview.png[image] +. In a web browser, navigate to the web console URL. ++ +-- +The web console URL is the : from the `listener` that you created to serve the web console. For example: `localhost:8672`. -On the overview page, aggregate information about routers, addresses, and connections is displayed. +The {ConsoleName} opens. If you
[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console
jbyrne-redhat commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289306715 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110 +17,100 @@ specific language governing permissions and limitations under the License +[id='using-router-console'] = Using {ConsoleName} -[[console-overview]] -== Console Overview +{ConsoleName} is a web console for monitoring the status and performance of {RouterName} router networks. -The console is an HTML based web site that displays information about a qpid dispatch router network. +== Setting up access to the web console -The console requires an HTML web server that can serve static html, javascript, style sheets, and images. +Before you can access the web console, you must configure a `listener` to accept HTTP connections for the web console and serve the console files. -The console only provides limited information about the clients that are attached to the router network and is therfore more appropriate for administrators needing to know the layout and health of the router network. +.Procedure -[[console-installation]] -== Console Installation +. On the router from which you want to access the web console, open the {RouterConfigFile} configuration file. -[discrete] -=== Prerequisites - -The following need to be installed before running a console: - -* One or more dispatch routers. See the documentation for the dispatch -router for help in starting a router network. -* A websockets to tcp proxy. -* A web server. This can be any server capable of serving static -html/js/css/image files. - -[discrete] -=== Procedure - -To install a websockets to tcp proxy: +. Add a `listener` to serve the console. ++ +-- +This example creates a `listener` that clients can use to access the web console: +[options="nowrap",subs="+quotes"] -sudo dnf install python-websockify -websockify localhost:5673 localhost:5672 +listener { +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +} +`http`:: Set this attribute to `true` to specify that this `listener` should accept HTTP connections instead of plain AMQP connections. -This will start the proxy listening to ws traffic on port 5673 and -translating it to tcp on port 5672. One of the routers in the network -needs to have a listener configured on port 5672. That listener's role -should be 'normal'. For example: +`httpRootDir`:: Specify the absolute path to the directory that contains the web console HTML files. The default directory is `/usr/share/qpid-dispatch/console`. +-- +. If you want to secure access to the console, secure the `listener`. ++ +-- +For more information, see xref:securing-incoming-client-connections-{context}[]. This example adds basic user name and password authentication using SASL PLAIN. + +[options="nowrap",subs="+quotes"] listener { - host: 0.0.0.0 - role: normal - port: amqp - saslMechanisms: ANONYMOUS +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +authenticatePeer: yes +saslMechanisms: PLAIN } +-- -[[the-console-files]] -=== The Console Files - -The files for the console are located under the console/stand-alone -directory in the source tree -* 'index.html' -* 'plugin/' - -Copy these files to a directory under the the html or webapps directory -of your web server. For example, for apache tomcat the files should be -under webapps/dispatch. Then the console is available as 'http://localhost:8080/dispatch' - -[[console-operation]] -== Console Operation - -[[logging-in-to-a-router-network]] -=== Logging into a Router Network - -image:console_login.png[image] +. If you want to set up access to the web console from any other router in the router network, repeat this procedure for each router. -Enter the address of the websockets to tcp proxy that is connected to a router in the network. +== Accessing the web console -The Autostart checkbox, when checked, will automatically log in with the previous host:port the next time you start the console. +You can access the web console from a web browser. -[[overview-page]] -=== Overview Page +.Procedure -image:console_overview.png[image] +. In a web browser, navigate to the web console URL. ++ +-- +The web console URL is the : from the `listener` that you created to serve the web console. For example: `localhost:8672`. -On the overview page, aggregate information about routers, addresses, and connections is displayed. +The {ConsoleName} opens. If you set up user name and password authentication, the *Connect* tab is displayed. +-- -[[topology-page]] -=== Topology Page +. If necessary, log in to the web console. ++ +-- +If you set up user name and password authentication, enter
[jira] [Commented] (DISPATCH-1347) Update documentation for Dispatch Router console
[ https://issues.apache.org/jira/browse/DISPATCH-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852815#comment-16852815 ] ASF GitHub Bot commented on DISPATCH-1347: -- jbyrne-redhat commented on pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289304599 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110 +17,100 @@ specific language governing permissions and limitations under the License +[id='using-router-console'] = Using {ConsoleName} -[[console-overview]] -== Console Overview +{ConsoleName} is a web console for monitoring the status and performance of {RouterName} router networks. -The console is an HTML based web site that displays information about a qpid dispatch router network. +== Setting up access to the web console -The console requires an HTML web server that can serve static html, javascript, style sheets, and images. +Before you can access the web console, you must configure a `listener` to accept HTTP connections for the web console and serve the console files. -The console only provides limited information about the clients that are attached to the router network and is therfore more appropriate for administrators needing to know the layout and health of the router network. +.Procedure -[[console-installation]] -== Console Installation +. On the router from which you want to access the web console, open the {RouterConfigFile} configuration file. -[discrete] -=== Prerequisites - -The following need to be installed before running a console: - -* One or more dispatch routers. See the documentation for the dispatch -router for help in starting a router network. -* A websockets to tcp proxy. -* A web server. This can be any server capable of serving static -html/js/css/image files. - -[discrete] -=== Procedure - -To install a websockets to tcp proxy: +. Add a `listener` to serve the console. ++ +-- +This example creates a `listener` that clients can use to access the web console: +[options="nowrap",subs="+quotes"] -sudo dnf install python-websockify -websockify localhost:5673 localhost:5672 +listener { +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +} +`http`:: Set this attribute to `true` to specify that this `listener` should accept HTTP connections instead of plain AMQP connections. -This will start the proxy listening to ws traffic on port 5673 and -translating it to tcp on port 5672. One of the routers in the network -needs to have a listener configured on port 5672. That listener's role -should be 'normal'. For example: +`httpRootDir`:: Specify the absolute path to the directory that contains the web console HTML files. The default directory is `/usr/share/qpid-dispatch/console`. +-- +. If you want to secure access to the console, secure the `listener`. ++ +-- +For more information, see xref:securing-incoming-client-connections-{context}[]. This example adds basic user name and password authentication using SASL PLAIN. + +[options="nowrap",subs="+quotes"] listener { - host: 0.0.0.0 - role: normal - port: amqp - saslMechanisms: ANONYMOUS +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +authenticatePeer: yes +saslMechanisms: PLAIN } +-- -[[the-console-files]] -=== The Console Files - -The files for the console are located under the console/stand-alone -directory in the source tree -* 'index.html' -* 'plugin/' - -Copy these files to a directory under the the html or webapps directory -of your web server. For example, for apache tomcat the files should be -under webapps/dispatch. Then the console is available as 'http://localhost:8080/dispatch' - -[[console-operation]] -== Console Operation - -[[logging-in-to-a-router-network]] -=== Logging into a Router Network - -image:console_login.png[image] +. If you want to set up access to the web console from any other router in the router network, repeat this procedure for each router. -Enter the address of the websockets to tcp proxy that is connected to a router in the network. +== Accessing the web console -The Autostart checkbox, when checked, will automatically log in with the previous host:port the next time you start the console. +You can access the web console from a web browser. -[[overview-page]] -=== Overview Page +.Procedure -image:console_overview.png[image] +. In a web browser, navigate to the web console URL. ++ +-- +The web console URL is the : from the `listener` that you created to serve the web console. For example: `localhost:8672`. Review comment: For example, This is an automated message from
[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console
jbyrne-redhat commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289304599 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110 +17,100 @@ specific language governing permissions and limitations under the License +[id='using-router-console'] = Using {ConsoleName} -[[console-overview]] -== Console Overview +{ConsoleName} is a web console for monitoring the status and performance of {RouterName} router networks. -The console is an HTML based web site that displays information about a qpid dispatch router network. +== Setting up access to the web console -The console requires an HTML web server that can serve static html, javascript, style sheets, and images. +Before you can access the web console, you must configure a `listener` to accept HTTP connections for the web console and serve the console files. -The console only provides limited information about the clients that are attached to the router network and is therfore more appropriate for administrators needing to know the layout and health of the router network. +.Procedure -[[console-installation]] -== Console Installation +. On the router from which you want to access the web console, open the {RouterConfigFile} configuration file. -[discrete] -=== Prerequisites - -The following need to be installed before running a console: - -* One or more dispatch routers. See the documentation for the dispatch -router for help in starting a router network. -* A websockets to tcp proxy. -* A web server. This can be any server capable of serving static -html/js/css/image files. - -[discrete] -=== Procedure - -To install a websockets to tcp proxy: +. Add a `listener` to serve the console. ++ +-- +This example creates a `listener` that clients can use to access the web console: +[options="nowrap",subs="+quotes"] -sudo dnf install python-websockify -websockify localhost:5673 localhost:5672 +listener { +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +} +`http`:: Set this attribute to `true` to specify that this `listener` should accept HTTP connections instead of plain AMQP connections. -This will start the proxy listening to ws traffic on port 5673 and -translating it to tcp on port 5672. One of the routers in the network -needs to have a listener configured on port 5672. That listener's role -should be 'normal'. For example: +`httpRootDir`:: Specify the absolute path to the directory that contains the web console HTML files. The default directory is `/usr/share/qpid-dispatch/console`. +-- +. If you want to secure access to the console, secure the `listener`. ++ +-- +For more information, see xref:securing-incoming-client-connections-{context}[]. This example adds basic user name and password authentication using SASL PLAIN. + +[options="nowrap",subs="+quotes"] listener { - host: 0.0.0.0 - role: normal - port: amqp - saslMechanisms: ANONYMOUS +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +authenticatePeer: yes +saslMechanisms: PLAIN } +-- -[[the-console-files]] -=== The Console Files - -The files for the console are located under the console/stand-alone -directory in the source tree -* 'index.html' -* 'plugin/' - -Copy these files to a directory under the the html or webapps directory -of your web server. For example, for apache tomcat the files should be -under webapps/dispatch. Then the console is available as 'http://localhost:8080/dispatch' - -[[console-operation]] -== Console Operation - -[[logging-in-to-a-router-network]] -=== Logging into a Router Network - -image:console_login.png[image] +. If you want to set up access to the web console from any other router in the router network, repeat this procedure for each router. -Enter the address of the websockets to tcp proxy that is connected to a router in the network. +== Accessing the web console -The Autostart checkbox, when checked, will automatically log in with the previous host:port the next time you start the console. +You can access the web console from a web browser. -[[overview-page]] -=== Overview Page +.Procedure -image:console_overview.png[image] +. In a web browser, navigate to the web console URL. ++ +-- +The web console URL is the : from the `listener` that you created to serve the web console. For example: `localhost:8672`. Review comment: For example, This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards,
[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console
jbyrne-redhat commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289304599 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110 +17,100 @@ specific language governing permissions and limitations under the License +[id='using-router-console'] = Using {ConsoleName} -[[console-overview]] -== Console Overview +{ConsoleName} is a web console for monitoring the status and performance of {RouterName} router networks. -The console is an HTML based web site that displays information about a qpid dispatch router network. +== Setting up access to the web console -The console requires an HTML web server that can serve static html, javascript, style sheets, and images. +Before you can access the web console, you must configure a `listener` to accept HTTP connections for the web console and serve the console files. -The console only provides limited information about the clients that are attached to the router network and is therfore more appropriate for administrators needing to know the layout and health of the router network. +.Procedure -[[console-installation]] -== Console Installation +. On the router from which you want to access the web console, open the {RouterConfigFile} configuration file. -[discrete] -=== Prerequisites - -The following need to be installed before running a console: - -* One or more dispatch routers. See the documentation for the dispatch -router for help in starting a router network. -* A websockets to tcp proxy. -* A web server. This can be any server capable of serving static -html/js/css/image files. - -[discrete] -=== Procedure - -To install a websockets to tcp proxy: +. Add a `listener` to serve the console. ++ +-- +This example creates a `listener` that clients can use to access the web console: +[options="nowrap",subs="+quotes"] -sudo dnf install python-websockify -websockify localhost:5673 localhost:5672 +listener { +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +} +`http`:: Set this attribute to `true` to specify that this `listener` should accept HTTP connections instead of plain AMQP connections. -This will start the proxy listening to ws traffic on port 5673 and -translating it to tcp on port 5672. One of the routers in the network -needs to have a listener configured on port 5672. That listener's role -should be 'normal'. For example: +`httpRootDir`:: Specify the absolute path to the directory that contains the web console HTML files. The default directory is `/usr/share/qpid-dispatch/console`. +-- +. If you want to secure access to the console, secure the `listener`. ++ +-- +For more information, see xref:securing-incoming-client-connections-{context}[]. This example adds basic user name and password authentication using SASL PLAIN. + +[options="nowrap",subs="+quotes"] listener { - host: 0.0.0.0 - role: normal - port: amqp - saslMechanisms: ANONYMOUS +host: 0.0.0.0 +port: 8672 +role: normal +http: true +httpRootDir: /usr/share/qpid-dispatch/console +authenticatePeer: yes +saslMechanisms: PLAIN } +-- -[[the-console-files]] -=== The Console Files - -The files for the console are located under the console/stand-alone -directory in the source tree -* 'index.html' -* 'plugin/' - -Copy these files to a directory under the the html or webapps directory -of your web server. For example, for apache tomcat the files should be -under webapps/dispatch. Then the console is available as 'http://localhost:8080/dispatch' - -[[console-operation]] -== Console Operation - -[[logging-in-to-a-router-network]] -=== Logging into a Router Network - -image:console_login.png[image] +. If you want to set up access to the web console from any other router in the router network, repeat this procedure for each router. -Enter the address of the websockets to tcp proxy that is connected to a router in the network. +== Accessing the web console -The Autostart checkbox, when checked, will automatically log in with the previous host:port the next time you start the console. +You can access the web console from a web browser. -[[overview-page]] -=== Overview Page +.Procedure -image:console_overview.png[image] +. In a web browser, navigate to the web console URL. ++ +-- +The web console URL is the : from the `listener` that you created to serve the web console. For example: `localhost:8672`. Review comment: For example, This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards,
[jira] [Commented] (DISPATCH-1347) Update documentation for Dispatch Router console
[ https://issues.apache.org/jira/browse/DISPATCH-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852805#comment-16852805 ] ASF GitHub Bot commented on DISPATCH-1347: -- jbyrne-redhat commented on pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289303385 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110 +17,100 @@ specific language governing permissions and limitations under the License +[id='using-router-console'] = Using {ConsoleName} -[[console-overview]] -== Console Overview +{ConsoleName} is a web console for monitoring the status and performance of {RouterName} router networks. -The console is an HTML based web site that displays information about a qpid dispatch router network. +== Setting up access to the web console -The console requires an HTML web server that can serve static html, javascript, style sheets, and images. +Before you can access the web console, you must configure a `listener` to accept HTTP connections for the web console and serve the console files. -The console only provides limited information about the clients that are attached to the router network and is therfore more appropriate for administrators needing to know the layout and health of the router network. +.Procedure -[[console-installation]] -== Console Installation +. On the router from which you want to access the web console, open the {RouterConfigFile} configuration file. Review comment: {RouterConfigFile} is unresolved in the HTML. Is this a new alias? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update documentation for Dispatch Router console > > > Key: DISPATCH-1347 > URL: https://issues.apache.org/jira/browse/DISPATCH-1347 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Reporter: Ben Hardesty >Priority: Major > > The documentation for the web console is out-of-date. It should be updated to > describe how to install and access the console. > > [https://qpid.apache.org/releases/qpid-dispatch-1.7.0/user-guide/index.html#using_apache_qpid_dispatch_router_console] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jbyrne-redhat commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console
jbyrne-redhat commented on a change in pull request #516: DISPATCH-1347: Update doc for setting up and accessing web console URL: https://github.com/apache/qpid-dispatch/pull/516#discussion_r289303385 ## File path: docs/books/user-guide/using-console.adoc ## @@ -17,110 +17,100 @@ specific language governing permissions and limitations under the License +[id='using-router-console'] = Using {ConsoleName} -[[console-overview]] -== Console Overview +{ConsoleName} is a web console for monitoring the status and performance of {RouterName} router networks. -The console is an HTML based web site that displays information about a qpid dispatch router network. +== Setting up access to the web console -The console requires an HTML web server that can serve static html, javascript, style sheets, and images. +Before you can access the web console, you must configure a `listener` to accept HTTP connections for the web console and serve the console files. -The console only provides limited information about the clients that are attached to the router network and is therfore more appropriate for administrators needing to know the layout and health of the router network. +.Procedure -[[console-installation]] -== Console Installation +. On the router from which you want to access the web console, open the {RouterConfigFile} configuration file. Review comment: {RouterConfigFile} is unresolved in the HTML. Is this a new alias? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org