[GitHub] [qpid-dispatch] jdanekrh commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests
jdanekrh commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests URL: https://github.com/apache/qpid-dispatch/pull/590#discussion_r336318656 ## File path: CMakeLists.txt ## @@ -191,9 +191,13 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang") add_compile_options(-Wno-gnu-statement-expression) endif() -if (NOT (APPLE OR USE_SANITIZERS OR USE_TSAN)) +if (APPLE) Review comment: I'll consider comment https://github.com/jdanekrh/qpid-dispatch/commit/4c07a4d9f5e0bf6c12a3d5661f86adc6390b432a#r35553494 as sufficient review and merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954258#comment-16954258
]
ASF GitHub Bot commented on DISPATCH-1384:
--
jdanekrh commented on pull request #590: DISPATCH-1384 - Fix unit_tests
URL: https://github.com/apache/qpid-dispatch/pull/590#discussion_r336318656
##
File path: CMakeLists.txt
##
@@ -191,9 +191,13 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wno-gnu-statement-expression)
endif()
-if (NOT (APPLE OR USE_SANITIZERS OR USE_TSAN))
+if (APPLE)
Review comment:
I'll consider comment
https://github.com/jdanekrh/qpid-dispatch/commit/4c07a4d9f5e0bf6c12a3d5661f86adc6390b432a#r35553494
as sufficient review and merge this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954255#comment-16954255
]
ASF subversion and git services commented on DISPATCH-1384:
---
Commit f81b834769d9426679183b498a7b3e0162bc8fed in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=f81b834 ]
DISPATCH-1384 - Disable inlining of functions that are mocked in unit_tests
The timer_test.c relies on being able to provide its own dummy versions
of `qd_timer_now` and `qd_server_timeout`. That is not possible if these
functions are inlined in the .dynlib. Clang on macOS inlines them,
GCC on Linux doesn't (that's why the tests pass on Linux)
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954256#comment-16954256
]
ASF subversion and git services commented on DISPATCH-1384:
---
Commit 1c7203b2518e343bb4c5d774a2a7179555ef2793 in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=1c7203b ]
DISPATCH-1384 - Enable flat namespace on macOS
-flat_namespace overrides macOS default of -two_levelnamespace,
to make the behavior more like Linux; also should compensate for lack
of -Wl,-z,defs on macOS.
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954254#comment-16954254
]
ASF GitHub Bot commented on DISPATCH-1384:
--
jdanekrh commented on pull request #590: DISPATCH-1384 - Fix unit_tests
URL: https://github.com/apache/qpid-dispatch/pull/590
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh merged pull request #590: DISPATCH-1384 - Fix unit_tests
jdanekrh merged pull request #590: DISPATCH-1384 - Fix unit_tests URL: https://github.com/apache/qpid-dispatch/pull/590 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1363) Remove apache rat check from main travis build and move to a sub build
[ https://issues.apache.org/jira/browse/DISPATCH-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954114#comment-16954114 ] ASF GitHub Bot commented on DISPATCH-1363: -- codecov-io commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543364515 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=h1) Report > Merging [#592](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/a96e6ae693cc998b0385aa018ede1e88d05922e1?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #592 +/- ## == - Coverage 86.39% 86.36% -0.04% == Files 90 90 Lines 2048420475 -9 == - Hits1769717683 -14 - Misses 2787 2792 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/agent\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2FkZHJlc3MuYw==) | `88.18% <0%> (-1.58%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.26% <0%> (-1%)` | :arrow_down: | | [src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `91.41% <0%> (-0.53%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.64% <0%> (-0.23%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.97% <0%> (-0.12%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.02% <0%> (+0.12%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `67.33% <0%> (+0.5%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `94.6% <0%> (+0.7%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=footer). Last update [a96e6ae...a9adf88](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove apache rat check from main travis build and move to a sub build > --- > > Key: DISPATCH-1363 > URL: https://issues.apache.org/jira/browse/DISPATCH-1363 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.7.0 >Reporter: Ganesh Murthy >Assignee: Jiri Daněk >Priority: Minor > Labels: CI/CD > > Currently, when a Travis build fails, we are unable to tell if the the > failure was due to the rat check failure or due to a system test failure. You > have to scroll all the way to the bottom of the build output page to find out > if the rat check failed. > An improvement would be to move the rat check to a sub build so that it is > easy to visually identify if the build failure is due to the
[GitHub] [qpid-dispatch] codecov-io commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build
codecov-io commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543364515 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=h1) Report > Merging [#592](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/a96e6ae693cc998b0385aa018ede1e88d05922e1?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #592 +/- ## == - Coverage 86.39% 86.36% -0.04% == Files 90 90 Lines 2048420475 -9 == - Hits1769717683 -14 - Misses 2787 2792 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/agent\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2FkZHJlc3MuYw==) | `88.18% <0%> (-1.58%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.26% <0%> (-1%)` | :arrow_down: | | [src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `91.41% <0%> (-0.53%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.64% <0%> (-0.23%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.97% <0%> (-0.12%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.02% <0%> (+0.12%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `67.33% <0%> (+0.5%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `94.6% <0%> (+0.7%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=footer). Last update [a96e6ae...a9adf88](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1363) Remove apache rat check from main travis build and move to a sub build
[ https://issues.apache.org/jira/browse/DISPATCH-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954061#comment-16954061 ] ASF GitHub Bot commented on DISPATCH-1363: -- ganeshmurthy commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543335722 @jdanekrh ok thanks, I will wait for the builds to complete and check back in an hour or so to see how things have worked out. Will keep you posted. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove apache rat check from main travis build and move to a sub build > --- > > Key: DISPATCH-1363 > URL: https://issues.apache.org/jira/browse/DISPATCH-1363 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.7.0 >Reporter: Ganesh Murthy >Assignee: Jiri Daněk >Priority: Minor > Labels: CI/CD > > Currently, when a Travis build fails, we are unable to tell if the the > failure was due to the rat check failure or due to a system test failure. You > have to scroll all the way to the bottom of the build output page to find out > if the rat check failed. > An improvement would be to move the rat check to a sub build so that it is > easy to visually identify if the build failure is due to the rat check or > system test failure. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build
ganeshmurthy commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543335722 @jdanekrh ok thanks, I will wait for the builds to complete and check back in an hour or so to see how things have worked out. Will keep you posted. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1363) Remove apache rat check from main travis build and move to a sub build
[ https://issues.apache.org/jira/browse/DISPATCH-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954056#comment-16954056 ] ASF GitHub Bot commented on DISPATCH-1363: -- jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543334656 Ahd the PR here https://github.com/apache/qpid-dispatch/pull/593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove apache rat check from main travis build and move to a sub build > --- > > Key: DISPATCH-1363 > URL: https://issues.apache.org/jira/browse/DISPATCH-1363 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.7.0 >Reporter: Ganesh Murthy >Assignee: Jiri Daněk >Priority: Minor > Labels: CI/CD > > Currently, when a Travis build fails, we are unable to tell if the the > failure was due to the rat check failure or due to a system test failure. You > have to scroll all the way to the bottom of the build output page to find out > if the rat check failed. > An improvement would be to move the rat check to a sub build so that it is > easy to visually identify if the build failure is due to the rat check or > system test failure. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1363) Remove apache rat check from main travis build and move to a sub build
[ https://issues.apache.org/jira/browse/DISPATCH-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954057#comment-16954057 ] ASF GitHub Bot commented on DISPATCH-1363: -- jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543334656 And the PR here https://github.com/apache/qpid-dispatch/pull/593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove apache rat check from main travis build and move to a sub build > --- > > Key: DISPATCH-1363 > URL: https://issues.apache.org/jira/browse/DISPATCH-1363 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.7.0 >Reporter: Ganesh Murthy >Assignee: Jiri Daněk >Priority: Minor > Labels: CI/CD > > Currently, when a Travis build fails, we are unable to tell if the the > failure was due to the rat check failure or due to a system test failure. You > have to scroll all the way to the bottom of the build output page to find out > if the rat check failed. > An improvement would be to move the rat check to a sub build so that it is > easy to visually identify if the build failure is due to the rat check or > system test failure. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh edited a comment on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build
jdanekrh edited a comment on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543334656 And the PR here https://github.com/apache/qpid-dispatch/pull/593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build
jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543334656 Ahd the PR here https://github.com/apache/qpid-dispatch/pull/593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh opened a new pull request #593: I am an unlicenced file
jdanekrh opened a new pull request #593: I am an unlicenced file URL: https://github.com/apache/qpid-dispatch/pull/593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1363) Remove apache rat check from main travis build and move to a sub build
[ https://issues.apache.org/jira/browse/DISPATCH-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954054#comment-16954054 ] ASF GitHub Bot commented on DISPATCH-1363: -- jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-54990 Here, https://travis-ci.org/jdanekrh/qpid-dispatch/builds/599323593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove apache rat check from main travis build and move to a sub build > --- > > Key: DISPATCH-1363 > URL: https://issues.apache.org/jira/browse/DISPATCH-1363 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.7.0 >Reporter: Ganesh Murthy >Assignee: Jiri Daněk >Priority: Minor > Labels: CI/CD > > Currently, when a Travis build fails, we are unable to tell if the the > failure was due to the rat check failure or due to a system test failure. You > have to scroll all the way to the bottom of the build output page to find out > if the rat check failed. > An improvement would be to move the rat check to a sub build so that it is > easy to visually identify if the build failure is due to the rat check or > system test failure. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build
jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-54990 Here, https://travis-ci.org/jdanekrh/qpid-dispatch/builds/599323593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1363) Remove apache rat check from main travis build and move to a sub build
[ https://issues.apache.org/jira/browse/DISPATCH-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954042#comment-16954042 ] ASF GitHub Bot commented on DISPATCH-1363: -- ganeshmurthy commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543328646 @jdanekrh can you please rebase this PR with master and simply add a file with no license so that the RAT check fails? This is what I would like to see. If the RAT check fails, there should be a red X mark next to the checkin. When I click on the X mark I should be taken to a page which shows all builds passing but only the RAT failing (this is already happening). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove apache rat check from main travis build and move to a sub build > --- > > Key: DISPATCH-1363 > URL: https://issues.apache.org/jira/browse/DISPATCH-1363 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.7.0 >Reporter: Ganesh Murthy >Assignee: Jiri Daněk >Priority: Minor > Labels: CI/CD > > Currently, when a Travis build fails, we are unable to tell if the the > failure was due to the rat check failure or due to a system test failure. You > have to scroll all the way to the bottom of the build output page to find out > if the rat check failed. > An improvement would be to move the rat check to a sub build so that it is > easy to visually identify if the build failure is due to the rat check or > system test failure. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build
ganeshmurthy commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543328646 @jdanekrh can you please rebase this PR with master and simply add a file with no license so that the RAT check fails? This is what I would like to see. If the RAT check fails, there should be a red X mark next to the checkin. When I click on the X mark I should be taken to a page which shows all builds passing but only the RAT failing (this is already happening). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1454) system_tests_one_router failing due to changes in qpid-proton
[ https://issues.apache.org/jira/browse/DISPATCH-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1454. - Resolution: Fixed > system_tests_one_router failing due to changes in qpid-proton > - > > Key: DISPATCH-1454 > URL: https://issues.apache.org/jira/browse/DISPATCH-1454 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Tests >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > 20: == > 20: FAIL: test_12_test_strip_message_annotations_no_add_trace > (system_tests_one_router.OneRouterTest) > 20: -- > 20: Traceback (most recent call last): > 20: File > "/home/travis/build/apache/qpid-dispatch/tests/system_tests_one_router.py", > line 213, in test_12_test_strip_message_annotations_no_add_trace > 20: self.assertEqual ( None, test.error ) > 20: AssertionError: None != u'annotations are not a dictionary' > 20: > 20: == > 20: FAIL: test_39_connection_properties_binary > (system_tests_one_router.OneRouterTest) > 20: -- > 20: Traceback (most recent call last): > 20: File > "/home/travis/build/apache/qpid-dispatch/tests/system_tests_one_router.py", > line 431, in test_39_connection_properties_binary > 20: self.assertFalse(results_found) > 20: AssertionError: True is not false > 20: > 20: -- > 20: Ran 45 tests in 23.076s -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1454) system_tests_one_router failing due to changes in qpid-proton
[ https://issues.apache.org/jira/browse/DISPATCH-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954039#comment-16954039 ] ASF subversion and git services commented on DISPATCH-1454: --- Commit a96e6ae693cc998b0385aa018ede1e88d05922e1 in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=a96e6ae ] DISPATCH-1454 - Fixed test_12 to use instanceof instead of __class__ and skipped test_39 until proton bug gets fixed > system_tests_one_router failing due to changes in qpid-proton > - > > Key: DISPATCH-1454 > URL: https://issues.apache.org/jira/browse/DISPATCH-1454 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Tests >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > 20: == > 20: FAIL: test_12_test_strip_message_annotations_no_add_trace > (system_tests_one_router.OneRouterTest) > 20: -- > 20: Traceback (most recent call last): > 20: File > "/home/travis/build/apache/qpid-dispatch/tests/system_tests_one_router.py", > line 213, in test_12_test_strip_message_annotations_no_add_trace > 20: self.assertEqual ( None, test.error ) > 20: AssertionError: None != u'annotations are not a dictionary' > 20: > 20: == > 20: FAIL: test_39_connection_properties_binary > (system_tests_one_router.OneRouterTest) > 20: -- > 20: Traceback (most recent call last): > 20: File > "/home/travis/build/apache/qpid-dispatch/tests/system_tests_one_router.py", > line 431, in test_39_connection_properties_binary > 20: self.assertFalse(results_found) > 20: AssertionError: True is not false > 20: > 20: -- > 20: Ran 45 tests in 23.076s -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1454) system_tests_one_router failing due to changes in qpid-proton
[
https://issues.apache.org/jira/browse/DISPATCH-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy updated DISPATCH-1454:
Description:
20: ==
20: FAIL: test_12_test_strip_message_annotations_no_add_trace
(system_tests_one_router.OneRouterTest)
20: --
20: Traceback (most recent call last):
20: File
"/home/travis/build/apache/qpid-dispatch/tests/system_tests_one_router.py",
line 213, in test_12_test_strip_message_annotations_no_add_trace
20: self.assertEqual ( None, test.error )
20: AssertionError: None != u'annotations are not a dictionary'
20:
20: ==
20: FAIL: test_39_connection_properties_binary
(system_tests_one_router.OneRouterTest)
20: --
20: Traceback (most recent call last):
20: File
"/home/travis/build/apache/qpid-dispatch/tests/system_tests_one_router.py",
line 431, in test_39_connection_properties_binary
20: self.assertFalse(results_found)
20: AssertionError: True is not false
20:
20: --
20: Ran 45 tests in 23.076s
was:
{noformat}
20: ==20:
FAIL: test_12_test_strip_message_annotations_no_add_trace
(system_tests_one_router.OneRouterTest)20:
--20:
Traceback (most recent call last):20: File
"/home/travis/build/apache/qpid-dispatch/tests/system_tests_one_router.py",
line 213, in test_12_test_strip_message_annotations_no_add_trace20:
self.assertEqual ( None, test.error )20: AssertionError: None != u'annotations
are not a dictionary'20: 20:
==20: FAIL:
test_39_connection_properties_binary (system_tests_one_router.OneRouterTest)20:
--20:
Traceback (most recent call last):20: File
"/home/travis/build/apache/qpid-dispatch/tests/system_tests_one_router.py",
line 431, in test_39_connection_properties_binary20:
self.assertFalse(results_found)20: AssertionError: True is not false20: 20:
--20: Ran
45 tests in 23.076s {noformat}
> system_tests_one_router failing due to changes in qpid-proton
> -
>
> Key: DISPATCH-1454
> URL: https://issues.apache.org/jira/browse/DISPATCH-1454
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
>Affects Versions: 1.9.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.10.0
>
>
> 20: ==
> 20: FAIL: test_12_test_strip_message_annotations_no_add_trace
> (system_tests_one_router.OneRouterTest)
> 20: --
> 20: Traceback (most recent call last):
> 20: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_one_router.py",
> line 213, in test_12_test_strip_message_annotations_no_add_trace
> 20: self.assertEqual ( None, test.error )
> 20: AssertionError: None != u'annotations are not a dictionary'
> 20:
> 20: ==
> 20: FAIL: test_39_connection_properties_binary
> (system_tests_one_router.OneRouterTest)
> 20: --
> 20: Traceback (most recent call last):
> 20: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_one_router.py",
> line 431, in test_39_connection_properties_binary
> 20: self.assertFalse(results_found)
> 20: AssertionError: True is not false
> 20:
> 20: --
> 20: Ran 45 tests in 23.076s
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1454) system_tests_one_router failing due to changes in qpid-proton
Ganesh Murthy created DISPATCH-1454:
---
Summary: system_tests_one_router failing due to changes in
qpid-proton
Key: DISPATCH-1454
URL: https://issues.apache.org/jira/browse/DISPATCH-1454
Project: Qpid Dispatch
Issue Type: Improvement
Components: Tests
Affects Versions: 1.9.0
Reporter: Ganesh Murthy
Assignee: Ganesh Murthy
Fix For: 1.10.0
{noformat}
20: ==20:
FAIL: test_12_test_strip_message_annotations_no_add_trace
(system_tests_one_router.OneRouterTest)20:
--20:
Traceback (most recent call last):20: File
"/home/travis/build/apache/qpid-dispatch/tests/system_tests_one_router.py",
line 213, in test_12_test_strip_message_annotations_no_add_trace20:
self.assertEqual ( None, test.error )20: AssertionError: None != u'annotations
are not a dictionary'20: 20:
==20: FAIL:
test_39_connection_properties_binary (system_tests_one_router.OneRouterTest)20:
--20:
Traceback (most recent call last):20: File
"/home/travis/build/apache/qpid-dispatch/tests/system_tests_one_router.py",
line 431, in test_39_connection_properties_binary20:
self.assertFalse(results_found)20: AssertionError: True is not false20: 20:
--20: Ran
45 tests in 23.076s {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954004#comment-16954004
]
ASF subversion and git services commented on DISPATCH-1384:
---
Commit ccf49e52c36aafc47452f8b1cd65ef89b92581bb in qpid-dispatch's branch
refs/heads/master from Jiri Danek
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=ccf49e5 ]
DISPATCH-1384 - Fix assert in system_tests_bad_configuration
The expected Linux error is
2019-10-17 10:14:09.319632 +0200 SERVER (info) [C1] Connection to
unresolvable.host.name:amqp failed: proton:io Name or service not known -
connect to unresolvable.host.name:5672 (../src/server.c:974)
The expected macOS error is
2019-06-21 21:00:34.125714 -0700 SERVER (info) [C4] Connection to
unresolvable.host.name:amqp failed: proton:io unknown node or service - on
connect resolving unresolvable.host.name:5672
(/Users/cloud-user/projects/qpid-dispatch/src/server.c:965)
The macOS error did not match the Linux specific regex used before.
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954003#comment-16954003
]
ASF GitHub Bot commented on DISPATCH-1384:
--
jdanekrh commented on pull request #591: DISPATCH-1384 - Fix assert in
system_tests_bad_configuration
URL: https://github.com/apache/qpid-dispatch/pull/591
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh merged pull request #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration
jdanekrh merged pull request #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration URL: https://github.com/apache/qpid-dispatch/pull/591 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953995#comment-16953995
]
ASF GitHub Bot commented on DISPATCH-1384:
--
jdanekrh commented on issue #591: DISPATCH-1384 - Fix assert in
system_tests_bad_configuration
URL: https://github.com/apache/qpid-dispatch/pull/591#issuecomment-543301645
There should not be anything "controversial" about this, and I've checked
that the test is capable of failing (always concern when touching existing
tests), so I'll just merge this. Thanks for review.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh commented on issue #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration
jdanekrh commented on issue #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration URL: https://github.com/apache/qpid-dispatch/pull/591#issuecomment-543301645 There should not be anything "controversial" about this, and I've checked that the test is capable of failing (always concern when touching existing tests), so I'll just merge this. Thanks for review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1363) Remove apache rat check from main travis build and move to a sub build
[ https://issues.apache.org/jira/browse/DISPATCH-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953993#comment-16953993 ] ASF GitHub Bot commented on DISPATCH-1363: -- jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543300086 @ganeshmurthy Is this what you've had in mind? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove apache rat check from main travis build and move to a sub build > --- > > Key: DISPATCH-1363 > URL: https://issues.apache.org/jira/browse/DISPATCH-1363 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.7.0 >Reporter: Ganesh Murthy >Assignee: Jiri Daněk >Priority: Minor > Labels: CI/CD > > Currently, when a Travis build fails, we are unable to tell if the the > failure was due to the rat check failure or due to a system test failure. You > have to scroll all the way to the bottom of the build output page to find out > if the rat check failed. > An improvement would be to move the rat check to a sub build so that it is > easy to visually identify if the build failure is due to the rat check or > system test failure. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build
jdanekrh commented on issue #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543300086 @ganeshmurthy Is this what you've had in mind? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1445) Update saslPassword attribute in connector entity to use openssl style prefixes
[ https://issues.apache.org/jira/browse/DISPATCH-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1445. - Resolution: Fixed > Update saslPassword attribute in connector entity to use openssl style > prefixes > --- > > Key: DISPATCH-1445 > URL: https://issues.apache.org/jira/browse/DISPATCH-1445 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > Modify the saslPassword attribute of the connector entity to use env: file: > and pass: prefixes. Model this around the sslProfile's password field. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1445) Update saslPassword attribute in connector entity to use openssl style prefixes
[ https://issues.apache.org/jira/browse/DISPATCH-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953970#comment-16953970 ] ASF GitHub Bot commented on DISPATCH-1445: -- ganeshmurthy commented on pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with … URL: https://github.com/apache/qpid-dispatch/pull/587 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update saslPassword attribute in connector entity to use openssl style > prefixes > --- > > Key: DISPATCH-1445 > URL: https://issues.apache.org/jira/browse/DISPATCH-1445 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > Modify the saslPassword attribute of the connector entity to use env: file: > and pass: prefixes. Model this around the sslProfile's password field. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with …
ganeshmurthy closed pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with … URL: https://github.com/apache/qpid-dispatch/pull/587 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1445) Update saslPassword attribute in connector entity to use openssl style prefixes
[ https://issues.apache.org/jira/browse/DISPATCH-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953968#comment-16953968 ] ASF subversion and git services commented on DISPATCH-1445: --- Commit c6cbac8fb748096259e0c28864b262a724f7b089 in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c6cbac8 ] DISPATCH-1445 - Modeled saslPassword to be more or less in line with sslProfile's password field > Update saslPassword attribute in connector entity to use openssl style > prefixes > --- > > Key: DISPATCH-1445 > URL: https://issues.apache.org/jira/browse/DISPATCH-1445 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > Modify the saslPassword attribute of the connector entity to use env: file: > and pass: prefixes. Model this around the sslProfile's password field. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1450) Add build option to enable thread sanitizer build
[ https://issues.apache.org/jira/browse/DISPATCH-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-1450: - Fix Version/s: 1.10.0 > Add build option to enable thread sanitizer build > - > > Key: DISPATCH-1450 > URL: https://issues.apache.org/jira/browse/DISPATCH-1450 > Project: Qpid Dispatch > Issue Type: Test > Components: Tests >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: tsan > Fix For: Backlog, 1.10.0 > > > Update cmake to support building qdrouterd with thread sanitizing turned on > (tsan). > This should be configurable via a cmake option (default to off). > See the proton cmake files for a guide. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1450) Add build option to enable thread sanitizer build
[ https://issues.apache.org/jira/browse/DISPATCH-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti updated DISPATCH-1450: - Labels: tsan (was: ) > Add build option to enable thread sanitizer build > - > > Key: DISPATCH-1450 > URL: https://issues.apache.org/jira/browse/DISPATCH-1450 > Project: Qpid Dispatch > Issue Type: Test > Components: Tests >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: tsan > Fix For: Backlog > > > Update cmake to support building qdrouterd with thread sanitizing turned on > (tsan). > This should be configurable via a cmake option (default to off). > See the proton cmake files for a guide. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953932#comment-16953932 ] ASF subversion and git services commented on DISPATCH-1300: --- Commit e06fd587c88e134e9898bba57e85bf6d1adbbda5 in qpid-dispatch's branch refs/heads/master from Jiří Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=e06fd58 ] DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path (#550) * DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path I am intentionally not mentioning the CMAKE_INSTALL_PREFIX here. I hope people who know of it can guess that it plays a role in determining the console installation directory. * fixup Update python/qpid_dispatch/management/qdrouter.json Co-Authored-By: Ben Hardesty > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953931#comment-16953931 ] ASF subversion and git services commented on DISPATCH-1300: --- Commit e06fd587c88e134e9898bba57e85bf6d1adbbda5 in qpid-dispatch's branch refs/heads/master from Jiří Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=e06fd58 ] DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path (#550) * DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path I am intentionally not mentioning the CMAKE_INSTALL_PREFIX here. I hope people who know of it can guess that it plays a role in determining the console installation directory. * fixup Update python/qpid_dispatch/management/qdrouter.json Co-Authored-By: Ben Hardesty > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953930#comment-16953930 ] ASF GitHub Bot commented on DISPATCH-1300: -- jdanekrh commented on pull request #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path URL: https://github.com/apache/qpid-dispatch/pull/550 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh merged pull request #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path
jdanekrh merged pull request #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path URL: https://github.com/apache/qpid-dispatch/pull/550 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953912#comment-16953912 ] ASF GitHub Bot commented on DISPATCH-1300: -- ganeshmurthy commented on issue #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path URL: https://github.com/apache/qpid-dispatch/pull/550#issuecomment-543261498 @jdanekrh please squash the commits into one commit and merge that commit to master. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path
ganeshmurthy commented on issue #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path URL: https://github.com/apache/qpid-dispatch/pull/550#issuecomment-543261498 @jdanekrh please squash the commits into one commit and merge that commit to master. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2116) Memory leak in python client
[ https://issues.apache.org/jira/browse/PROTON-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953901#comment-16953901 ] Lukas commented on PROTON-2116: --- https://issues.apache.org/jira/browse/PROTON-2121 is a possible duplicate of this issue - please verify the test case described in PROTON-2121 and if it's not possible to reproduce the issue with the version 0.30.0 please close PROTON-2121 as duplicate. I tried to quickly backport the changes in 8c2e66c to 0.28.0 but I'm still experiencing the file descriptor leak. > Memory leak in python client > > > Key: PROTON-2116 > URL: https://issues.apache.org/jira/browse/PROTON-2116 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.29.0 >Reporter: Clifford Jansen >Assignee: Clifford Jansen >Priority: Major > Fix For: proton-c-0.30.0 > > Attachments: leak.py > > > The Python client leaks transports and selectables. When using the > BlockingConnection classes, Containers, Collectors and other runtime class > objects can also leak as additional referents. > To reproduce, run the test case leak.py against the example broker. Kill and > restart the broker repeatedly. The value of gc.get_objects() keeps increasing. > Breaking the circular references between transports and selectables prevents > these leaks. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1453) Adding "defaultDistribution: unavailable" overrides the regular handling of transaction coordinator link refusal
Robbie Gemmell created DISPATCH-1453:
Summary: Adding "defaultDistribution: unavailable" overrides the
regular handling of transaction coordinator link refusal
Key: DISPATCH-1453
URL: https://issues.apache.org/jira/browse/DISPATCH-1453
Project: Qpid Dispatch
Issue Type: Bug
Affects Versions: 1.9.0
Reporter: Robbie Gemmell
DISPATCH-802 added handling to refuse links to the transaction coordinator
(which has no address, but is a specific target) if a link route to e.g a
broker isnt configured (using DISPATCH-195), and help clarify the reasons for
the refusal.
DISPATCH-803 was added to provide a way for links to adressses that are
otherwise unknown to be refused rather than message routed, by setting
"defaultDistribution: unavailable". This functionality overrides the behaviour
from DISPATCH-802, making it less clear again why a transaction usage attempt
has failed.
>From a JMS client trying to create a transacted session, the failure with
>"defaultDistribution: unavailable" config present looks like:
{noformat}
javax.jms.JMSException: No route to the destination node [condition =
qd:no-route-to-dest]
at
org.apache.qpid.jms.provider.ProviderException.toJMSException(ProviderException.java:34)
at
org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:80)
at
org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:112)
at org.apache.qpid.jms.JmsConnection.createResource(JmsConnection.java:698)
at
org.apache.qpid.jms.JmsLocalTransactionContext.begin(JmsLocalTransactionContext.java:140)
at org.apache.qpid.jms.JmsSession.(JmsSession.java:172)
at org.apache.qpid.jms.JmsConnection.createSession(JmsConnection.java:316)
at org.apache.qpid.jms.example.HelloWorld.main(HelloWorld.java:52)
{noformat}
While without it,the router sends a more specific error condition, and so the
failure normally looks like:
{noformat}
javax.jms.JMSException: The router can't coordinate transactions by itself, a
linkRoute to a coordinator must be configured to use transactions. [condition =
amqp:precondition-failed]
at
org.apache.qpid.jms.provider.ProviderException.toJMSException(ProviderException.java:34)
at
org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:80)
at
org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:112)
at org.apache.qpid.jms.JmsConnection.createResource(JmsConnection.java:698)
at
org.apache.qpid.jms.JmsLocalTransactionContext.begin(JmsLocalTransactionContext.java:140)
at org.apache.qpid.jms.JmsSession.(JmsSession.java:172)
at org.apache.qpid.jms.JmsConnection.createSession(JmsConnection.java:316)
at org.apache.qpid.jms.example.HelloWorld.main(HelloWorld.java:52)
{noformat}
It would be nicer if the regular coordinator refusal error condition was sent
in both cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953854#comment-16953854
]
ASF GitHub Bot commented on DISPATCH-1384:
--
kgiusti commented on pull request #590: DISPATCH-1384 - Fix unit_tests
URL: https://github.com/apache/qpid-dispatch/pull/590#discussion_r336079605
##
File path: CMakeLists.txt
##
@@ -191,9 +191,13 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wno-gnu-statement-expression)
endif()
-if (NOT (APPLE OR USE_SANITIZERS OR USE_TSAN))
+if (APPLE)
Review comment:
yep, np. I'll hold off until this patch lands.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests
kgiusti commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests URL: https://github.com/apache/qpid-dispatch/pull/590#discussion_r336079605 ## File path: CMakeLists.txt ## @@ -191,9 +191,13 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang") add_compile_options(-Wno-gnu-statement-expression) endif() -if (NOT (APPLE OR USE_SANITIZERS OR USE_TSAN)) +if (APPLE) Review comment: yep, np. I'll hold off until this patch lands. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953848#comment-16953848 ] ASF GitHub Bot commented on DISPATCH-1300: -- jdanekrh commented on issue #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path URL: https://github.com/apache/qpid-dispatch/pull/550#issuecomment-543229008 @ErnieAllen [~eallen] Afaik updating the doc is last step for DISPATCH-1300 and it can be closed when this is merged, if I recall correctly. I'll close it in a day or so if nobody objects. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh commented on issue #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path
jdanekrh commented on issue #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path URL: https://github.com/apache/qpid-dispatch/pull/550#issuecomment-543229008 @ErnieAllen [~eallen] Afaik updating the doc is last step for DISPATCH-1300 and it can be closed when this is merged, if I recall correctly. I'll close it in a day or so if nobody objects. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2121) python-qpid-proton 0.28 BlockingConnection leaks connections (does not close file descriptors)
Lukas created PROTON-2121:
-
Summary: python-qpid-proton 0.28 BlockingConnection leaks
connections (does not close file descriptors)
Key: PROTON-2121
URL: https://issues.apache.org/jira/browse/PROTON-2121
Project: Qpid Proton
Issue Type: Bug
Affects Versions: proton-c-0.28.0
Reporter: Lukas
Starting in proton 0.28.0 and verified in 0.29.0b1 (pre-release) I can confirm
following issue:
{code:java}
from proton.utils import BlockingConnection
c = BlockingConnection(YOUR_ADDRESS)
c.close()
# ^^ FINE, all file descriptors closed properly
from proton.utils import BlockingConnection
c = BlockingConnection(YOUR_ADDRESS)
s = c.create_sender(YOUR_EXCHANGE)
s.close()
c.close()
# ^^ leaks the socket file descriptor - connection not closed properly (ls
/proc/YOUR_PID/fd to verify){code}
Version 0.27.0 is *not* affected by this issue.
Having a quick look at the proton bindings, this very well might be bug in the
qpid proton library itself, not the python bindings!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1300) Remove 'stand-alone' from console install path
[
https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953839#comment-16953839
]
ASF GitHub Bot commented on DISPATCH-1300:
--
bhardesty commented on pull request #550: DISPATCH-1300 - doc default
httpRootDir as being stand-alone console install path
URL: https://github.com/apache/qpid-dispatch/pull/550#discussion_r336069549
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -869,7 +869,7 @@
},
"httpRootDir": {
"type": "path",
-"description": "Absolute path to a directory from which to
serve static HTML files. For example, /usr/share/qpid-dispatch/console.",
+"description": "Absolute path to a directory from which to
serve static HTML files. Defaults to the stand-alone console installation
directory, e.g. /usr/share/qpid-dispatch/console.",
Review comment:
```suggestion
"description": "Absolute path to a directory from which
to serve static HTML files. Defaults to the stand-alone console installation
directory (typically /usr/share/qpid-dispatch/console).",
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove 'stand-alone' from console install path
> --
>
> Key: DISPATCH-1300
> URL: https://issues.apache.org/jira/browse/DISPATCH-1300
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Console
>Affects Versions: 1.5.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
>
> Remove 'stand-alone' from the console install directory. This allows upstream
> and downstream console locations to match. It also allows the console to be
> used without requiring httpRoot to be setup.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] bhardesty commented on a change in pull request #550: DISPATCH-1300 - doc default httpRootDir as being stand-alone console install path
bhardesty commented on a change in pull request #550: DISPATCH-1300 - doc
default httpRootDir as being stand-alone console install path
URL: https://github.com/apache/qpid-dispatch/pull/550#discussion_r336069549
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -869,7 +869,7 @@
},
"httpRootDir": {
"type": "path",
-"description": "Absolute path to a directory from which to
serve static HTML files. For example, /usr/share/qpid-dispatch/console.",
+"description": "Absolute path to a directory from which to
serve static HTML files. Defaults to the stand-alone console installation
directory, e.g. /usr/share/qpid-dispatch/console.",
Review comment:
```suggestion
"description": "Absolute path to a directory from which
to serve static HTML files. Defaults to the stand-alone console installation
directory (typically /usr/share/qpid-dispatch/console).",
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953833#comment-16953833
]
ASF GitHub Bot commented on DISPATCH-1384:
--
jdanekrh commented on pull request #590: DISPATCH-1384 - Fix unit_tests
URL: https://github.com/apache/qpid-dispatch/pull/590#discussion_r336064713
##
File path: CMakeLists.txt
##
@@ -191,9 +191,13 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wno-gnu-statement-expression)
endif()
-if (NOT (APPLE OR USE_SANITIZERS OR USE_TSAN))
+if (APPLE)
Review comment:
Thanks for the head's up. Would you be OK if this gets merged before you get
done? For APPLE, the important thing is never to set `"-Wl,-z,defs"`, because
then the compile fails. No other considerations I know about, so far.
Btw, there is apparently special automagical setting to enable sanitizers
with XCODE
```
cmake_minimum_required(VERSION 3.13)
set(CMAKE_XCODE_GENERATE_SCHEME ON)
set(CMAKE_XCODE_SCHEME_ADDRESS_SANITIZER ON)
set(CMAKE_XCODE_SCHEME_ADDRESS_SANITIZER_USE_AFTER_RETURN ON)
```
https://stackoverflow.com/questions/44320465/whats-the-proper-way-to-enable-addresssanitizer-in-cmake-that-works-in-xcode
Probably something that can be safely ignored for now.
I was wondering if "modern" CMake has special support for Valgrind, and so
on, but I found nothing. It has e.g. support for cppcheck, though,
https://cmake.org/cmake/help/v3.10/prop_tgt/LANG_CPPCHECK.html
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests
jdanekrh commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests URL: https://github.com/apache/qpid-dispatch/pull/590#discussion_r336064713 ## File path: CMakeLists.txt ## @@ -191,9 +191,13 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang") add_compile_options(-Wno-gnu-statement-expression) endif() -if (NOT (APPLE OR USE_SANITIZERS OR USE_TSAN)) +if (APPLE) Review comment: Thanks for the head's up. Would you be OK if this gets merged before you get done? For APPLE, the important thing is never to set `"-Wl,-z,defs"`, because then the compile fails. No other considerations I know about, so far. Btw, there is apparently special automagical setting to enable sanitizers with XCODE ``` cmake_minimum_required(VERSION 3.13) set(CMAKE_XCODE_GENERATE_SCHEME ON) set(CMAKE_XCODE_SCHEME_ADDRESS_SANITIZER ON) set(CMAKE_XCODE_SCHEME_ADDRESS_SANITIZER_USE_AFTER_RETURN ON) ``` https://stackoverflow.com/questions/44320465/whats-the-proper-way-to-enable-addresssanitizer-in-cmake-that-works-in-xcode Probably something that can be safely ignored for now. I was wondering if "modern" CMake has special support for Valgrind, and so on, but I found nothing. It has e.g. support for cppcheck, though, https://cmake.org/cmake/help/v3.10/prop_tgt/LANG_CPPCHECK.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1448) Investigate all Valgrind leaks and update suppression files appropriately
[ https://issues.apache.org/jira/browse/DISPATCH-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned DISPATCH-1448: Assignee: Ken Giusti > Investigate all Valgrind leaks and update suppression files appropriately > - > > Key: DISPATCH-1448 > URL: https://issues.apache.org/jira/browse/DISPATCH-1448 > Project: Qpid Dispatch > Issue Type: Task > Components: Tests >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: memory-bug > Fix For: Backlog > > > Running Valgrind is fairly useless as there are always some sort of memory > leak that occurs in a majority of tests. > These leaks need to be analyzed and either fixed or suppressed in order to > use Valgrind effectively. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1450) Add build option to enable thread sanitizer build
[ https://issues.apache.org/jira/browse/DISPATCH-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned DISPATCH-1450: Assignee: Ken Giusti > Add build option to enable thread sanitizer build > - > > Key: DISPATCH-1450 > URL: https://issues.apache.org/jira/browse/DISPATCH-1450 > Project: Qpid Dispatch > Issue Type: Test > Components: Tests >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: Backlog > > > Update cmake to support building qdrouterd with thread sanitizing turned on > (tsan). > This should be configurable via a cmake option (default to off). > See the proton cmake files for a guide. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953813#comment-16953813
]
ASF GitHub Bot commented on DISPATCH-1384:
--
kgiusti commented on pull request #590: DISPATCH-1384 - Fix unit_tests
URL: https://github.com/apache/qpid-dispatch/pull/590#discussion_r336044898
##
File path: CMakeLists.txt
##
@@ -191,9 +191,13 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wno-gnu-statement-expression)
endif()
-if (NOT (APPLE OR USE_SANITIZERS OR USE_TSAN))
+if (APPLE)
Review comment:
Just a head's up - I'm refactoring the way we enable TSAN in cmake to follow
the model used by proton.
See [DISPATCH-1450](https://issues.apache.org/jira/browse/DISPATCH-1450)
I'll be creating a pull request for DISPATCH-1450 in the next day or so.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests
kgiusti commented on a change in pull request #590: DISPATCH-1384 - Fix unit_tests URL: https://github.com/apache/qpid-dispatch/pull/590#discussion_r336044898 ## File path: CMakeLists.txt ## @@ -191,9 +191,13 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang") add_compile_options(-Wno-gnu-statement-expression) endif() -if (NOT (APPLE OR USE_SANITIZERS OR USE_TSAN)) +if (APPLE) Review comment: Just a head's up - I'm refactoring the way we enable TSAN in cmake to follow the model used by proton. See [DISPATCH-1450](https://issues.apache.org/jira/browse/DISPATCH-1450) I'll be creating a pull request for DISPATCH-1450 in the next day or so. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2120) [Proton-c] Threaderciser test does not link
[
https://issues.apache.org/jira/browse/PROTON-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kim van der Riet resolved PROTON-2120.
--
Resolution: Fixed
In the c/test/CMakeLists.txt file:
Using the add_c_test() macro to add the threadersicer test is causing the link
issue. This test defines its own main() function, whereas other tests are part
of a test framework in which the framework provides the main() function.
By explicitly adding the test without the test framework library bits rather
than using the macro solves the issue and the test runs and passes.
> [Proton-c] Threaderciser test does not link
> ---
>
> Key: PROTON-2120
> URL: https://issues.apache.org/jira/browse/PROTON-2120
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Reporter: Kim van der Riet
>Priority: Major
>
> Proton C has a "threaderciser" test which is by default is not enabled.
> However, if it is enabled before compile through the following cmake option:
> {{-DTHREADERCISER="ON"}}
> then the compile fails with a link error:
> {{multiple definitions of 'main'}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2120) [Proton-c] Threaderciser test does not link
[
https://issues.apache.org/jira/browse/PROTON-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953763#comment-16953763
]
ASF subversion and git services commented on PROTON-2120:
-
Commit f78aabcd500eb53c434defd3249a53a3b8229ae8 in qpid-proton's branch
refs/heads/master from Kim van der Riet
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=f78aabc ]
PROTON-2120: Changed in c/tests/CMakeLists.txt the way threaderciser test is
added to resolve link problem
> [Proton-c] Threaderciser test does not link
> ---
>
> Key: PROTON-2120
> URL: https://issues.apache.org/jira/browse/PROTON-2120
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Reporter: Kim van der Riet
>Priority: Major
>
> Proton C has a "threaderciser" test which is by default is not enabled.
> However, if it is enabled before compile through the following cmake option:
> {{-DTHREADERCISER="ON"}}
> then the compile fails with a link error:
> {{multiple definitions of 'main'}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2120) [Proton-c] Threaderciser test does not link
[
https://issues.apache.org/jira/browse/PROTON-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kim van der Riet updated PROTON-2120:
-
Summary: [Proton-c] Threaderciser test does not link (was:
[Proton-c]Threaderciser test does not link)
> [Proton-c] Threaderciser test does not link
> ---
>
> Key: PROTON-2120
> URL: https://issues.apache.org/jira/browse/PROTON-2120
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Reporter: Kim van der Riet
>Priority: Major
>
> Proton C has a "threaderciser" test which is by default is not enabled.
> However, if it is enabled before compile through the following cmake option:
> {{-DTHREADERCISER="ON"}}
> then the compile fails with a link error:
> {{multiple definitions of 'main'}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2120) [Proton-c]Threaderciser test does not link
Kim van der Riet created PROTON-2120:
Summary: [Proton-c]Threaderciser test does not link
Key: PROTON-2120
URL: https://issues.apache.org/jira/browse/PROTON-2120
Project: Qpid Proton
Issue Type: Bug
Components: proton-c
Reporter: Kim van der Riet
Proton C has a "threaderciser" test which is by default is not enabled.
However, if it is enabled before compile through the following cmake option:
{{-DTHREADERCISER="ON"}}
then the compile fails with a link error:
{{multiple definitions of 'main'}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1363) Remove apache rat check from main travis build and move to a sub build
[ https://issues.apache.org/jira/browse/DISPATCH-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk reassigned DISPATCH-1363: Assignee: Jiri Daněk > Remove apache rat check from main travis build and move to a sub build > --- > > Key: DISPATCH-1363 > URL: https://issues.apache.org/jira/browse/DISPATCH-1363 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.7.0 >Reporter: Ganesh Murthy >Assignee: Jiri Daněk >Priority: Minor > Labels: CI/CD > > Currently, when a Travis build fails, we are unable to tell if the the > failure was due to the rat check failure or due to a system test failure. You > have to scroll all the way to the bottom of the build output page to find out > if the rat check failed. > An improvement would be to move the rat check to a sub build so that it is > easy to visually identify if the build failure is due to the rat check or > system test failure. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh opened a new pull request #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build
jdanekrh opened a new pull request #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592 Now easier to do when the `matrix` key is in place in `.travis.yml`. Doing this also fixes the duplicated top level `cache` key in `.travis.yml` we had. It appears that `matrix` is outdated syntax, and `jobs` should be preferred, https://github.com/travis-ci/docs-travis-ci-com/issues/1500. The doc page https://docs.travis-ci.com/user/customizing-the-build/#Build-Matrix uses `matrix.include` in the text and `jobs.include` in the yaml samples. Task for another time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1363) Remove apache rat check from main travis build and move to a sub build
[ https://issues.apache.org/jira/browse/DISPATCH-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953699#comment-16953699 ] ASF GitHub Bot commented on DISPATCH-1363: -- jdanekrh commented on pull request #592: DISPATCH-1363 - Move RAT licence check from travis builds into a sub build URL: https://github.com/apache/qpid-dispatch/pull/592 Now easier to do when the `matrix` key is in place in `.travis.yml`. Doing this also fixes the duplicated top level `cache` key in `.travis.yml` we had. It appears that `matrix` is outdated syntax, and `jobs` should be preferred, https://github.com/travis-ci/docs-travis-ci-com/issues/1500. The doc page https://docs.travis-ci.com/user/customizing-the-build/#Build-Matrix uses `matrix.include` in the text and `jobs.include` in the yaml samples. Task for another time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove apache rat check from main travis build and move to a sub build > --- > > Key: DISPATCH-1363 > URL: https://issues.apache.org/jira/browse/DISPATCH-1363 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.7.0 >Reporter: Ganesh Murthy >Priority: Minor > Labels: CI/CD > > Currently, when a Travis build fails, we are unable to tell if the the > failure was due to the rat check failure or due to a system test failure. You > have to scroll all the way to the bottom of the build output page to find out > if the rat check failed. > An improvement would be to move the rat check to a sub build so that it is > easy to visually identify if the build failure is due to the rat check or > system test failure. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPIDJMS-476) Improve send performance of anonymous fallback producer
[ https://issues.apache.org/jira/browse/QPIDJMS-476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPIDJMS-476. Resolution: Fixed > Improve send performance of anonymous fallback producer > --- > > Key: QPIDJMS-476 > URL: https://issues.apache.org/jira/browse/QPIDJMS-476 > Project: Qpid JMS > Issue Type: Improvement > Components: qpid-jms-client >Affects Versions: 0.46.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: 0.47.0 > > > For servers that do not report support for the 'anonymous relay', allowing a > single sending link to be created for 'anonymous' producers (either > JMSProducer instances, or a MessageProducer created with null as the > destination) we implemented a fallback mechanism that created a sender link > that is opened on send and closed on completion of the send (remote sends > disposition). This mechanism essentially makes every send using the > anonymous fallback mechanism synchronous, with the overhead of Attach -> > Transfer -> Detach for each call to send, inhibiting performance. We can > improve this mechanism and also allow for asynchronous sends both from the > JMS 1.1 send methods and from the JMS 2 CompletionListener send methods, as > is currently done when the anonymous relay is supported by the server. By > allowing for caching of sender links we can also reduce the number of attach > and detach cycles for sends that encompass a fixed set of addresses as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953519#comment-16953519
]
ASF GitHub Bot commented on DISPATCH-1384:
--
jdanekrh commented on issue #591: DISPATCH-1384 - Fix assert in
system_tests_bad_configuration
URL: https://github.com/apache/qpid-dispatch/pull/591#issuecomment-543076154
"**79% tests passed**, 13 tests failed out of 61"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh commented on issue #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration
jdanekrh commented on issue #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration URL: https://github.com/apache/qpid-dispatch/pull/591#issuecomment-543076154 "**79% tests passed**, 13 tests failed out of 61" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953518#comment-16953518
]
ASF GitHub Bot commented on DISPATCH-1384:
--
jdanekrh commented on issue #590: DISPATCH-1384 - Fix unit_tests
URL: https://github.com/apache/qpid-dispatch/pull/590#issuecomment-543075142
"**79% tests passed**, 13 tests failed out of 61"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh commented on issue #590: DISPATCH-1384 - Fix unit_tests
jdanekrh commented on issue #590: DISPATCH-1384 - Fix unit_tests URL: https://github.com/apache/qpid-dispatch/pull/590#issuecomment-543075142 "**79% tests passed**, 13 tests failed out of 61" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953494#comment-16953494
]
ASF GitHub Bot commented on DISPATCH-1384:
--
jdanekrh commented on pull request #591: DISPATCH-1384 - Fix assert in
system_tests_bad_configuration
URL: https://github.com/apache/qpid-dispatch/pull/591
The expected Linux error is
2019-10-17 10:14:09.319632 +0200 SERVER (info) [C1] Connection to
unresolvable.host.name:amqp failed: proton:io Name or service not known -
connect to unresolvable.host.name:5672 (../src/server.c:974)
The expected macOS error is
2019-06-21 21:00:34.125714 -0700 SERVER (info) [C4] Connection to
unresolvable.host.name:amqp failed: proton:io unknown node or service - on
connect resolving unresolvable.host.name:5672
(/Users/cloud-user/projects/qpid-dispatch/src/server.c:965)
The macOS error did not match the Linux specific regex used before.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh opened a new pull request #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration
jdanekrh opened a new pull request #591: DISPATCH-1384 - Fix assert in system_tests_bad_configuration URL: https://github.com/apache/qpid-dispatch/pull/591 The expected Linux error is 2019-10-17 10:14:09.319632 +0200 SERVER (info) [C1] Connection to unresolvable.host.name:amqp failed: proton:io Name or service not known - connect to unresolvable.host.name:5672 (../src/server.c:974) The expected macOS error is 2019-06-21 21:00:34.125714 -0700 SERVER (info) [C4] Connection to unresolvable.host.name:amqp failed: proton:io unknown node or service - on connect resolving unresolvable.host.name:5672 (/Users/cloud-user/projects/qpid-dispatch/src/server.c:965) The macOS error did not match the Linux specific regex used before. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1282) Support for building on macOS
[ https://issues.apache.org/jira/browse/DISPATCH-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk reassigned DISPATCH-1282: Assignee: Jiri Daněk > Support for building on macOS > - > > Key: DISPATCH-1282 > URL: https://issues.apache.org/jira/browse/DISPATCH-1282 > Project: Qpid Dispatch > Issue Type: New Feature >Affects Versions: 1.5.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Labels: macOS > > Currently, Dispatch compilation fails on "rt" library being unavailable. > All Dispatch dependencies (Qpid Proton, libwebsockets, ...) can be built on > macOS. > I am attaching a patch which allows to compile dispatch on OSX and run it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated DISPATCH-1384:
-
Labels: macOS (was: )
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953472#comment-16953472
]
ASF GitHub Bot commented on DISPATCH-1384:
--
jdanekrh commented on issue #590: DISPATCH-1384 - fix unit_tests test
URL: https://github.com/apache/qpid-dispatch/pull/590#issuecomment-543049810
The `-Wl,-flat_namespace` is not in conflict with sanitizers, e.g. the
following is running the sanitizer just fine.
$ cmake .. -DCMAKE_INSTALL_PREFIX=../../install -DUSE_TSAN=ON
$ make
$ ctest -R unit_tests -V
```
9: 2019-10-17 09:39:52.994660 +0200 DEFAULT (notice) configured pattern
'.#.*.policy' optimized and re-written to '.*.#.policy'
9: ==
9: WARNING: ThreadSanitizer: data race (pid=3930)
9: Read of size 1 at 0x7b6400014a20 by thread T1 (mutexes: write M309):
9: * #0 router_core_thread router_core_thread.c:148
(libqpid-dispatch.dylib:x86_64+0x5fe6d)
9:
9: Previous write of size 1 at 0x7b6400014a20 by main thread:
9: * #0 qdr_core_free router_core.c:103
(libqpid-dispatch.dylib:x86_64+0x5b015)
9: #1 qd_router_free router_node.c:1788
(libqpid-dispatch.dylib:x86_64+0x73865)
9: #2 qd_dispatch_free dispatch.c:360
(libqpid-dispatch.dylib:x86_64+0x15a8e)
9: #3 main run_unit_tests.c:67 (unit_tests:x86_64+0x13772)
9:
9: Issue is caused by frames marked with "*".
9:
9: Location is heap block of size 1152 at 0x7b6400014a00 allocated by main
thread:
9: #0 malloc :1064000
(libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x48f1a)
9: #1 qdr_core router_core.c:45 (libqpid-dispatch.dylib:x86_64+0x5ac60)
9: #2 qd_router_setup_late router_node.c:1762
(libqpid-dispatch.dylib:x86_64+0x72c58)
9: #3 ffi_call_unix64 :1064000 (libffi.6.dylib:x86_64+0x4913)
9: #4 main run_unit_tests.c:52 (unit_tests:x86_64+0x136d0)
9:
9: Mutex M309 (0x7b107c00) created at:
9: #0 pthread_mutex_init :1063856
(libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2b5f3)
9: #1 sys_mutex threading.c:42 (libqpid-dispatch.dylib:x86_64+0x31be1)
9: #2 qdr_core router_core.c:65 (libqpid-dispatch.dylib:x86_64+0x5ad30)
9: #3 qd_router_setup_late router_node.c:1762
(libqpid-dispatch.dylib:x86_64+0x72c58)
9: #4 ffi_call_unix64 :1063856 (libffi.6.dylib:x86_64+0x4913)
9: #5 main run_unit_tests.c:52 (unit_tests:x86_64+0x136d0)
9:
9: Thread T1 (tid=20228, running) created by main thread at:
9: #0 pthread_create :1064048
(libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a72d)
9: #1 sys_thread threading.c:158 (libqpid-dispatch.dylib:x86_64+0x32035)
9: #2 qdr_core router_core.c:82 (libqpid-dispatch.dylib:x86_64+0x5adf6)
9: #3 qd_router_setup_late router_node.c:1762
(libqpid-dispatch.dylib:x86_64+0x72c58)
9: #4 ffi_call_unix64 :1064048 (libffi.6.dylib:x86_64+0x4913)
9: #5 main run_unit_tests.c:52 (unit_tests:x86_64+0x136d0)
9:
9: SUMMARY: ThreadSanitizer: data race router_core_thread.c:148 in
router_core_thread
9: ==
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh commented on issue #590: DISPATCH-1384 - fix unit_tests test
jdanekrh commented on issue #590: DISPATCH-1384 - fix unit_tests test URL: https://github.com/apache/qpid-dispatch/pull/590#issuecomment-543049810 The `-Wl,-flat_namespace` is not in conflict with sanitizers, e.g. the following is running the sanitizer just fine. $ cmake .. -DCMAKE_INSTALL_PREFIX=../../install -DUSE_TSAN=ON $ make $ ctest -R unit_tests -V ``` 9: 2019-10-17 09:39:52.994660 +0200 DEFAULT (notice) configured pattern '.#.*.policy' optimized and re-written to '.*.#.policy' 9: == 9: WARNING: ThreadSanitizer: data race (pid=3930) 9: Read of size 1 at 0x7b6400014a20 by thread T1 (mutexes: write M309): 9: * #0 router_core_thread router_core_thread.c:148 (libqpid-dispatch.dylib:x86_64+0x5fe6d) 9: 9: Previous write of size 1 at 0x7b6400014a20 by main thread: 9: * #0 qdr_core_free router_core.c:103 (libqpid-dispatch.dylib:x86_64+0x5b015) 9: #1 qd_router_free router_node.c:1788 (libqpid-dispatch.dylib:x86_64+0x73865) 9: #2 qd_dispatch_free dispatch.c:360 (libqpid-dispatch.dylib:x86_64+0x15a8e) 9: #3 main run_unit_tests.c:67 (unit_tests:x86_64+0x13772) 9: 9: Issue is caused by frames marked with "*". 9: 9: Location is heap block of size 1152 at 0x7b6400014a00 allocated by main thread: 9: #0 malloc :1064000 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x48f1a) 9: #1 qdr_core router_core.c:45 (libqpid-dispatch.dylib:x86_64+0x5ac60) 9: #2 qd_router_setup_late router_node.c:1762 (libqpid-dispatch.dylib:x86_64+0x72c58) 9: #3 ffi_call_unix64 :1064000 (libffi.6.dylib:x86_64+0x4913) 9: #4 main run_unit_tests.c:52 (unit_tests:x86_64+0x136d0) 9: 9: Mutex M309 (0x7b107c00) created at: 9: #0 pthread_mutex_init :1063856 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2b5f3) 9: #1 sys_mutex threading.c:42 (libqpid-dispatch.dylib:x86_64+0x31be1) 9: #2 qdr_core router_core.c:65 (libqpid-dispatch.dylib:x86_64+0x5ad30) 9: #3 qd_router_setup_late router_node.c:1762 (libqpid-dispatch.dylib:x86_64+0x72c58) 9: #4 ffi_call_unix64 :1063856 (libffi.6.dylib:x86_64+0x4913) 9: #5 main run_unit_tests.c:52 (unit_tests:x86_64+0x136d0) 9: 9: Thread T1 (tid=20228, running) created by main thread at: 9: #0 pthread_create :1064048 (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a72d) 9: #1 sys_thread threading.c:158 (libqpid-dispatch.dylib:x86_64+0x32035) 9: #2 qdr_core router_core.c:82 (libqpid-dispatch.dylib:x86_64+0x5adf6) 9: #3 qd_router_setup_late router_node.c:1762 (libqpid-dispatch.dylib:x86_64+0x72c58) 9: #4 ffi_call_unix64 :1064048 (libffi.6.dylib:x86_64+0x4913) 9: #5 main run_unit_tests.c:52 (unit_tests:x86_64+0x136d0) 9: 9: SUMMARY: ThreadSanitizer: data race router_core_thread.c:148 in router_core_thread 9: == ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953471#comment-16953471
]
ASF GitHub Bot commented on DISPATCH-1384:
--
jdanekrh commented on pull request #590: DISPATCH-1384 - fix unit_tests test
URL: https://github.com/apache/qpid-dispatch/pull/590
The inlining is not happening on Linux anyways, so disabling it should
affect only macOS. I could not think of other way to make tests pass with the
inlining, except doing some really crazy things that would have to affect what
happens during normal execution too.
I have a StackOverflow question about it, btw ;)
https://stackoverflow.com/questions/56711149/how-do-i-replace-a-function-by-a-mock-implementation-when-unit-testing-a-shared
`-Wl,-export-dynamic` is Clangs equivalent of `-rdynamic` in GCC. I thought
it should be used, but it does not appear to be necessary, so I am not adding
that.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jdanekrh opened a new pull request #590: DISPATCH-1384 - fix unit_tests test
jdanekrh opened a new pull request #590: DISPATCH-1384 - fix unit_tests test URL: https://github.com/apache/qpid-dispatch/pull/590 The inlining is not happening on Linux anyways, so disabling it should affect only macOS. I could not think of other way to make tests pass with the inlining, except doing some really crazy things that would have to affect what happens during normal execution too. I have a StackOverflow question about it, btw ;) https://stackoverflow.com/questions/56711149/how-do-i-replace-a-function-by-a-mock-implementation-when-unit-testing-a-shared `-Wl,-export-dynamic` is Clangs equivalent of `-rdynamic` in GCC. I thought it should be used, but it does not appear to be necessary, so I am not adding that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953454#comment-16953454
]
Jiri Daněk edited comment on DISPATCH-1384 at 10/17/19 7:01 AM:
Hi [~rkieley]!
On Travis, I see "*75% tests passed*, 15 tests failed out of 61" on master,
https://travis-ci.org/apache/qpid-dispatch/jobs/598898629. Probably because
there I have `saslpasswd2` from macports.
I have branch
https://github.com/jdanekrh/qpid-dispatch/commits/jd_2019-10_macos_unit_tests_segfault
https://travis-ci.org/jdanekrh/qpid-dispatch/jobs/599002957 which fixes the
unit_tests SEGFAULT in IMO a good way. I just have to figure where to put the
linker options in CMakeLists.txt (they are in .travis.yml now) and it should be
ready to go.
I'll do a separate branch for {{system_tests_bad_configuration}} as well.
Further, I tried the tactic of throwing random stuff at the CI, to see if
anything sticks.
So I have
https://github.com/jdanekrh/qpid-dispatch/commits/jd_2019-10_macos_tests_py3,
https://travis-ci.org/jdanekrh/qpid-dispatch/jobs/598992799, which is "*80%
tests passed*, 12 tests failed out of 61"
Then I have a Python 2 branch, which is a throwback to the previous state of
the original PR done the "python -m easy_install unittest2" way,
https://github.com/jdanekrh/qpid-dispatch/commits/jd_2019-10_macos_tests_py2,
https://travis-ci.org/jdanekrh/qpid-dispatch/builds/59973, and that gets
"*84% tests passed*, 10 tests failed out of 61" on Travis. I'd like to stick
with Python 3 here though, if at all practical.
edit: jd_macos_tests is ancient branch at this point (see the total number of
tests, or commit dates). I should probably delete it.
was (Author: jdanek):
Hi [~rkieley]!
On Travis, I see "*75% tests passed*, 15 tests failed out of 61" on master,
https://travis-ci.org/apache/qpid-dispatch/jobs/598898629. Probably because
there I have `saslpasswd2` from macports.
I have branch
https://github.com/jdanekrh/qpid-dispatch/commits/jd_2019-10_macos_unit_tests_segfault
https://travis-ci.org/jdanekrh/qpid-dispatch/jobs/599002957 which fixes the
unit_tests SEGFAULT in IMO a good way. I just have to figure where to put the
linker options in CMakeLists.txt (they are in .travis.yml now) and it should be
ready to go.
I'll do a separate branch for {{system_tests_bad_configuration}} as well.
Further, I tried the tactic of throwing random stuff at the CI, to see if
anything sticks.
So I have
https://github.com/jdanekrh/qpid-dispatch/commits/jd_2019-10_macos_tests_py3,
https://travis-ci.org/jdanekrh/qpid-dispatch/jobs/598992799, which is "*80%
tests passed*, 12 tests failed out of 61"
Then I have a Python 2 branch, which is a throwback to the previous state of
the original PR done the "python -m easy_install unittest2" way,
https://github.com/jdanekrh/qpid-dispatch/commits/jd_2019-10_macos_tests_py2,
https://travis-ci.org/jdanekrh/qpid-dispatch/builds/59973, and that gets
"*84% tests passed*, 10 tests failed out of 61" on Travis. I'd like to stick
with Python 3 here though, if at all practical.
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1384) Fix tests in Travis CI on macOS
[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953454#comment-16953454
]
Jiri Daněk commented on DISPATCH-1384:
--
Hi [~rkieley]!
On Travis, I see "*75% tests passed*, 15 tests failed out of 61" on master,
https://travis-ci.org/apache/qpid-dispatch/jobs/598898629. Probably because
there I have `saslpasswd2` from macports.
I have branch
https://github.com/jdanekrh/qpid-dispatch/commits/jd_2019-10_macos_unit_tests_segfault
https://travis-ci.org/jdanekrh/qpid-dispatch/jobs/599002957 which fixes the
unit_tests SEGFAULT in IMO a good way. I just have to figure where to put the
linker options in CMakeLists.txt (they are in .travis.yml now) and it should be
ready to go.
I'll do a separate branch for {{system_tests_bad_configuration}} as well.
Further, I tried the tactic of throwing random stuff at the CI, to see if
anything sticks.
So I have
https://github.com/jdanekrh/qpid-dispatch/commits/jd_2019-10_macos_tests_py3,
https://travis-ci.org/jdanekrh/qpid-dispatch/jobs/598992799, which is "*80%
tests passed*, 12 tests failed out of 61"
Then I have a Python 2 branch, which is a throwback to the previous state of
the original PR done the "python -m easy_install unittest2" way,
https://github.com/jdanekrh/qpid-dispatch/commits/jd_2019-10_macos_tests_py2,
https://travis-ci.org/jdanekrh/qpid-dispatch/builds/59973, and that gets
"*84% tests passed*, 10 tests failed out of 61" on Travis. I'd like to stick
with Python 3 here though, if at all practical.
> Fix tests in Travis CI on macOS
> ---
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
>23 - system_tests_policy (Timeout)
>28 - system_tests_sasl_plain (Failed)
>38 - system_tests_auth_service_plugin (Failed)
>39 - system_tests_authz_service_plugin (Failed)
>48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
