[jira] [Commented] (QPIDJMS-441) Using QPID JMS behind a proxy
[ https://issues.apache.org/jira/browse/QPIDJMS-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964346#comment-16964346 ] Clement Pellerin commented on QPIDJMS-441: -- I understand the proxy is configured as an extension to avoid a dependency in the JmsConnectionFactory, unfortunately this makes it impossible to configure through JNDI. Can we define a JmsProxiedConnectionFactory that would take the proxy configuration as regular options to make it compatible with JNDI? The second factory could be in its own jar. Users of that factory would not mind the extra proxy dependencies since that's the whole point of using that factory. > Using QPID JMS behind a proxy > - > > Key: QPIDJMS-441 > URL: https://issues.apache.org/jira/browse/QPIDJMS-441 > Project: Qpid JMS > Issue Type: New Feature > Components: qpid-jms-client >Affects Versions: 0.40.0 >Reporter: morten >Priority: Minor > Fix For: 0.47.0 > > > I actually did not find a possibility to use the jms qpid client behind a > proxy. I guess there will be a lot of people who needs to run the library > behind a proxy. It would be nice to have the possibility to set a proxy > somehow. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2127) Proton doesn't build on FreeBSD currently
[ https://issues.apache.org/jira/browse/PROTON-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964344#comment-16964344 ] ASF subversion and git services commented on PROTON-2127: - Commit 3167d532812ecedf91b84342c59f6ac4c0fe8bb6 in qpid-proton's branch refs/heads/master from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=3167d53 ] PROTON-2127: Fix FreeBSD build breakage > Proton doesn't build on FreeBSD currently > - > > Key: PROTON-2127 > URL: https://issues.apache.org/jira/browse/PROTON-2127 > Project: Qpid Proton > Issue Type: Bug > Components: build >Affects Versions: proton-c-0.29.0 >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.30.0 > > > Having not been build on FreeBSD in a little while proton has bitrotted > slightly and doesn't build. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2127) Proton doesn't build on FreeBSD currently
Andrew Stitcher created PROTON-2127: --- Summary: Proton doesn't build on FreeBSD currently Key: PROTON-2127 URL: https://issues.apache.org/jira/browse/PROTON-2127 Project: Qpid Proton Issue Type: Bug Components: build Affects Versions: proton-c-0.29.0 Reporter: Andrew Stitcher Assignee: Andrew Stitcher Fix For: proton-c-0.30.0 Having not been build on FreeBSD in a little while proton has bitrotted slightly and doesn't build. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2096) Drop Python < 3.5
[ https://issues.apache.org/jira/browse/PROTON-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2096. - Fix Version/s: (was: proton-c-future) proton-c-0.30.0 Resolution: Fixed > Drop Python < 3.5 > - > > Key: PROTON-2096 > URL: https://issues.apache.org/jira/browse/PROTON-2096 > Project: Qpid Proton > Issue Type: Improvement > Components: python-binding >Affects Versions: proton-c-0.29.0 >Reporter: Omer Katz >Priority: Major > Labels: easyfix > Fix For: proton-c-0.30.0 > > > Python 3.3 and 3.4 have reached EOL a while ago. > Python 2.7 is about to reach EOL in 1st, January, 2020. > We should drop support for those versions. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on issue #605: DISPATCH-1409 - Exposed available-credit and time-of-zero-credit as l…
codecov-io commented on issue #605: DISPATCH-1409 - Exposed available-credit and time-of-zero-credit as l… URL: https://github.com/apache/qpid-dispatch/pull/605#issuecomment-548513815 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=h1) Report > Merging [#605](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/37aef86a9ac20f5925de955846dd001de117ed5a?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `97.43%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=tree) ```diff @@Coverage Diff @@ ## master #605 +/- ## == + Coverage 86.42% 86.45% +0.02% == Files 91 91 Lines 2058220620 +38 == + Hits1778917828 +39 + Misses 2793 2792 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.54% <0%> (-0.17%)` | :arrow_down: | | [...odules/stuck\_delivery\_detection/delivery\_tracker.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvc3R1Y2tfZGVsaXZlcnlfZGV0ZWN0aW9uL2RlbGl2ZXJ5X3RyYWNrZXIuYw==) | `96.87% <100%> (+0.26%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.92% <100%> (+0.02%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.02% <100%> (+0.76%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.97% <100%> (-0.12%)` | :arrow_down: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `68.11% <100%> (+0.95%)` | :arrow_up: | | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `90.8% <100%> (+0.21%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.09% <100%> (+0.04%)` | :arrow_up: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `90.98% <0%> (-0.01%)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=footer). Last update [37aef86...8498ffc](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964313#comment-16964313 ] ASF GitHub Bot commented on DISPATCH-1409: -- codecov-io commented on issue #605: DISPATCH-1409 - Exposed available-credit and time-of-zero-credit as l… URL: https://github.com/apache/qpid-dispatch/pull/605#issuecomment-548513815 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=h1) Report > Merging [#605](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/37aef86a9ac20f5925de955846dd001de117ed5a?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `97.43%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=tree) ```diff @@Coverage Diff @@ ## master #605 +/- ## == + Coverage 86.42% 86.45% +0.02% == Files 91 91 Lines 2058220620 +38 == + Hits1778917828 +39 + Misses 2793 2792 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.54% <0%> (-0.17%)` | :arrow_down: | | [...odules/stuck\_delivery\_detection/delivery\_tracker.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvc3R1Y2tfZGVsaXZlcnlfZGV0ZWN0aW9uL2RlbGl2ZXJ5X3RyYWNrZXIuYw==) | `96.87% <100%> (+0.26%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.92% <100%> (+0.02%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.02% <100%> (+0.76%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.97% <100%> (-0.12%)` | :arrow_down: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `68.11% <100%> (+0.95%)` | :arrow_up: | | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `90.8% <100%> (+0.21%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.09% <100%> (+0.04%)` | :arrow_up: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `90.98% <0%> (-0.01%)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=footer). Last update [37aef86...8498ffc](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > Fix For: 1.10.0 > > > The (cap) field in the output of qdstat -l shows the
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964299#comment-16964299 ] ASF GitHub Bot commented on DISPATCH-1409: -- ted-ross commented on pull request #605: DISPATCH-1409 - Exposed available-credit and time-of-zero-credit as l… URL: https://github.com/apache/qpid-dispatch/pull/605 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved DISPATCH-1409. Fix Version/s: 1.10.0 Resolution: Fixed > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > Fix For: 1.10.0 > > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964294#comment-16964294 ] ASF subversion and git services commented on DISPATCH-1409: --- Commit 1837ece08add3cfd1af377be4dfeb3203dc32339 in qpid-dispatch's branch refs/heads/master from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=1837ece ] DISPATCH-1409 - Added test case, fixed accounting bug found by the test case. > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964295#comment-16964295 ] ASF subversion and git services commented on DISPATCH-1409: --- Commit 7dc31d20eb917678c8fedbd5cd487c5c4f5f6c50 in qpid-dispatch's branch refs/heads/master from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=7dc31d2 ] DISPATCH-1409 - Added a test for sender-link credit. > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ted-ross closed pull request #605: DISPATCH-1409 - Exposed available-credit and time-of-zero-credit as l…
ted-ross closed pull request #605: DISPATCH-1409 - Exposed available-credit and time-of-zero-credit as l… URL: https://github.com/apache/qpid-dispatch/pull/605 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964293#comment-16964293 ] ASF subversion and git services commented on DISPATCH-1409: --- Commit 8fe83b73005c5c1b6322a6b0dad7356672b17f5f in qpid-dispatch's branch refs/heads/master from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=8fe83b7 ] DISPATCH-1409 - Added global metric/gauge for links-blocked. Updated qdstat man page. > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964292#comment-16964292 ] ASF subversion and git services commented on DISPATCH-1409: --- Commit abda6a8de0d4838cb022e686c35af8471a194f3b in qpid-dispatch's branch refs/heads/master from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=abda6a8 ] DISPATCH-1409 - Reduce the batch size for batched management queries to account for the increased number of attributes in the link entity type. > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964291#comment-16964291 ] ASF subversion and git services commented on DISPATCH-1409: --- Commit beb89a3d4a355af277f37248dac6bf3ae9733e96 in qpid-dispatch's branch refs/heads/master from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=beb89a3 ] DISPATCH-1409 - Exposed available-credit and time-of-zero-credit as link attributes. Added logging for links that have been stuck with no credit for more than ten seconds. > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-441) Using QPID JMS behind a proxy
[ https://issues.apache.org/jira/browse/QPIDJMS-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964288#comment-16964288 ] Clement Pellerin commented on QPIDJMS-441: -- Can you update the docs in qpid-jms-docs/Configuration.md? > Using QPID JMS behind a proxy > - > > Key: QPIDJMS-441 > URL: https://issues.apache.org/jira/browse/QPIDJMS-441 > Project: Qpid JMS > Issue Type: New Feature > Components: qpid-jms-client >Affects Versions: 0.40.0 >Reporter: morten >Priority: Minor > Fix For: 0.47.0 > > > I actually did not find a possibility to use the jms qpid client behind a > proxy. I guess there will be a lot of people who needs to run the library > behind a proxy. It would be nice to have the possibility to set a proxy > somehow. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] nicob87 closed pull request #604: I am just a test. Jenkinsfile.
nicob87 closed pull request #604: I am just a test. Jenkinsfile. URL: https://github.com/apache/qpid-dispatch/pull/604 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1428) route connection not indexed by 'connection' field of connector
[
https://issues.apache.org/jira/browse/DISPATCH-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964233#comment-16964233
]
ASF subversion and git services commented on DISPATCH-1428:
---
Commit 6d8eeb65069ff8c5579286d69a2b90d43d9d7f5c in qpid-dispatch's branch
refs/heads/master from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=6d8eeb6 ]
DISPATCH-1428 - Replace xrange with range since it is gone is Python 3.x
> route connection not indexed by 'connection' field of connector
> ---
>
> Key: DISPATCH-1428
> URL: https://issues.apache.org/jira/browse/DISPATCH-1428
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Assignee: Gordon Sim
>Priority: Major
>
> The connection established by a route-container connector will not be indexed
> by the 'connection' field of that connector if there is already an existing
> route-connection with the same container id but established by a different
> connector.
> E.g. start router on 5672 and a broker (or a separate router emulating a
> broker) on 5673, then:
> {noformat}
> for n in foo bar; do
> qdmanage CREATE --type connector --name $n role=route-container
> host=localhost port=5673;
> qdmanage CREATE --type linkRoute --name $n pattern=$n direction=in
> connection=$n;
> done;
> qdstat --linkroute
> {noformat}
> Only one of these link routes is active though both connections are
> established.
> The issues is that when the first connection is established, it indexes the
> qdr_conn_identifier_t by container-id and the connection label from the
> connector. When the second connection is established, it looks up first by
> container id, so adds itself to the qdr_conn_identifier_t created by the
> first connection. There is then no entry in the index for the connection
> label of the second connector, so the second link route can never be
> activated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-441) Using QPID JMS behind a proxy
[ https://issues.apache.org/jira/browse/QPIDJMS-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964193#comment-16964193 ] ASF subversion and git services commented on QPIDJMS-441: - Commit 545ff4ef4cdcf4c5f1548f7b4ab6cf03e909cbed in qpid-jms's branch refs/heads/master from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-jms.git;h=545ff4e ] QPIDJMS-441: mark proxy bits optional in bundle manifest > Using QPID JMS behind a proxy > - > > Key: QPIDJMS-441 > URL: https://issues.apache.org/jira/browse/QPIDJMS-441 > Project: Qpid JMS > Issue Type: New Feature > Components: qpid-jms-client >Affects Versions: 0.40.0 >Reporter: morten >Priority: Minor > Fix For: 0.47.0 > > > I actually did not find a possibility to use the jms qpid client behind a > proxy. I guess there will be a lot of people who needs to run the library > behind a proxy. It would be nice to have the possibility to set a proxy > somehow. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2030) Use CLOCK_MONOTONIC in proactors for pn_transport_tick
[
https://issues.apache.org/jira/browse/PROTON-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964140#comment-16964140
]
ASF GitHub Bot commented on PROTON-2030:
astitcher commented on pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in
proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341207935
##
File path: c/src/proactor/win_iocp.c
##
@@ -1968,9 +1955,9 @@ class reaper {
// Call with lock
if (timer_ || !running)
return;
-pn_timestamp_t now = pn_i_now2();
+int64_t now = pn_proactor_now_64();
pni_zombie_check(iocp_, now);
-pn_timestamp_t zd = pni_zombie_deadline(iocp_);
+int64_t zd = pni_zombie_deadline(iocp_);
if (zd) {
DWORD tm = (zd > now) ? zd - now : 1;
Review comment:
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use CLOCK_MONOTONIC in proactors for pn_transport_tick
> --
>
> Key: PROTON-2030
> URL: https://issues.apache.org/jira/browse/PROTON-2030
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
>Affects Versions: proton-c-0.27.0
>Reporter: Jiri Daněk
>Priority: Major
>
> IOCP and epoll proactors are feeding wall clock time to pn_transport_tick. I
> tested (with epoll) that changing system clock breaks heartbeating.
> The libuv proactor does use monotonic already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on a change in pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in proactors for pn_transport_tick
astitcher commented on a change in pull request #180: PROTON-2030 Use
CLOCK_MONOTONIC in proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341207935
##
File path: c/src/proactor/win_iocp.c
##
@@ -1968,9 +1955,9 @@ class reaper {
// Call with lock
if (timer_ || !running)
return;
-pn_timestamp_t now = pn_i_now2();
+int64_t now = pn_proactor_now_64();
pni_zombie_check(iocp_, now);
-pn_timestamp_t zd = pni_zombie_deadline(iocp_);
+int64_t zd = pni_zombie_deadline(iocp_);
if (zd) {
DWORD tm = (zd > now) ? zd - now : 1;
Review comment:
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2030) Use CLOCK_MONOTONIC in proactors for pn_transport_tick
[
https://issues.apache.org/jira/browse/PROTON-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964136#comment-16964136
]
ASF GitHub Bot commented on PROTON-2030:
astitcher commented on pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in
proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341206698
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
@jdanekrh I'm happy with the change now - I suggest you squash the changes
when you rebase the change to merge it though.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use CLOCK_MONOTONIC in proactors for pn_transport_tick
> --
>
> Key: PROTON-2030
> URL: https://issues.apache.org/jira/browse/PROTON-2030
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
>Affects Versions: proton-c-0.27.0
>Reporter: Jiri Daněk
>Priority: Major
>
> IOCP and epoll proactors are feeding wall clock time to pn_transport_tick. I
> tested (with epoll) that changing system clock breaks heartbeating.
> The libuv proactor does use monotonic already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on a change in pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in proactors for pn_transport_tick
astitcher commented on a change in pull request #180: PROTON-2030 Use
CLOCK_MONOTONIC in proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341206698
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
@jdanekrh I'm happy with the change now - I suggest you squash the changes
when you rebase the change to merge it though.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2030) Use CLOCK_MONOTONIC in proactors for pn_transport_tick
[
https://issues.apache.org/jira/browse/PROTON-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964134#comment-16964134
]
ASF GitHub Bot commented on PROTON-2030:
astitcher commented on pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in
proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341206019
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
> The more I think about this, the more confused I feel.
I feel your pain.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use CLOCK_MONOTONIC in proactors for pn_transport_tick
> --
>
> Key: PROTON-2030
> URL: https://issues.apache.org/jira/browse/PROTON-2030
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
>Affects Versions: proton-c-0.27.0
>Reporter: Jiri Daněk
>Priority: Major
>
> IOCP and epoll proactors are feeding wall clock time to pn_transport_tick. I
> tested (with epoll) that changing system clock breaks heartbeating.
> The libuv proactor does use monotonic already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on a change in pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in proactors for pn_transport_tick
astitcher commented on a change in pull request #180: PROTON-2030 Use
CLOCK_MONOTONIC in proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341206019
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
> The more I think about this, the more confused I feel.
I feel your pain.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] alanconway commented on a change in pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in proactors for pn_transport_tick
alanconway commented on a change in pull request #180: PROTON-2030 Use
CLOCK_MONOTONIC in proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341202605
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
@astitcher and I are in violent agreement, just like old times. Signed in
the API, and the @astitcher unsigned magic in the impl is correct. Speculation
about horseshoe crabs out-evolving humans in the distant future is irrelevant
(they probably already have)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2030) Use CLOCK_MONOTONIC in proactors for pn_transport_tick
[
https://issues.apache.org/jira/browse/PROTON-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964126#comment-16964126
]
ASF GitHub Bot commented on PROTON-2030:
alanconway commented on pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in
proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341202605
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
@astitcher and I are in violent agreement, just like old times. Signed in
the API, and the @astitcher unsigned magic in the impl is correct. Speculation
about horseshoe crabs out-evolving humans in the distant future is irrelevant
(they probably already have)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use CLOCK_MONOTONIC in proactors for pn_transport_tick
> --
>
> Key: PROTON-2030
> URL: https://issues.apache.org/jira/browse/PROTON-2030
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
>Affects Versions: proton-c-0.27.0
>Reporter: Jiri Daněk
>Priority: Major
>
> IOCP and epoll proactors are feeding wall clock time to pn_transport_tick. I
> tested (with epoll) that changing system clock breaks heartbeating.
> The libuv proactor does use monotonic already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #603: DISPATCH-1428 - Minor modification to test to make sure link routes a…
asfgit closed pull request #603: DISPATCH-1428 - Minor modification to test to make sure link routes a… URL: https://github.com/apache/qpid-dispatch/pull/603 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1428) route connection not indexed by 'connection' field of connector
[
https://issues.apache.org/jira/browse/DISPATCH-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964105#comment-16964105
]
ASF GitHub Bot commented on DISPATCH-1428:
--
asfgit commented on pull request #603: DISPATCH-1428 - Minor modification to
test to make sure link routes a…
URL: https://github.com/apache/qpid-dispatch/pull/603
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> route connection not indexed by 'connection' field of connector
> ---
>
> Key: DISPATCH-1428
> URL: https://issues.apache.org/jira/browse/DISPATCH-1428
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Assignee: Gordon Sim
>Priority: Major
>
> The connection established by a route-container connector will not be indexed
> by the 'connection' field of that connector if there is already an existing
> route-connection with the same container id but established by a different
> connector.
> E.g. start router on 5672 and a broker (or a separate router emulating a
> broker) on 5673, then:
> {noformat}
> for n in foo bar; do
> qdmanage CREATE --type connector --name $n role=route-container
> host=localhost port=5673;
> qdmanage CREATE --type linkRoute --name $n pattern=$n direction=in
> connection=$n;
> done;
> qdstat --linkroute
> {noformat}
> Only one of these link routes is active though both connections are
> established.
> The issues is that when the first connection is established, it indexes the
> qdr_conn_identifier_t by container-id and the connection label from the
> connector. When the second connection is established, it looks up first by
> container id, so adds itself to the qdr_conn_identifier_t created by the
> first connection. There is then no entry in the index for the connection
> label of the second connector, so the second link route can never be
> activated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1428) route connection not indexed by 'connection' field of connector
[
https://issues.apache.org/jira/browse/DISPATCH-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964104#comment-16964104
]
ASF subversion and git services commented on DISPATCH-1428:
---
Commit 711361778332a4c434a899ce76806b7b4b749f97 in qpid-dispatch's branch
refs/heads/master from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=7113617 ]
DISPATCH-1428 - Minor modification to test to make sure link routes are all
activated before the test begins. This closes #603.
> route connection not indexed by 'connection' field of connector
> ---
>
> Key: DISPATCH-1428
> URL: https://issues.apache.org/jira/browse/DISPATCH-1428
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Assignee: Gordon Sim
>Priority: Major
>
> The connection established by a route-container connector will not be indexed
> by the 'connection' field of that connector if there is already an existing
> route-connection with the same container id but established by a different
> connector.
> E.g. start router on 5672 and a broker (or a separate router emulating a
> broker) on 5673, then:
> {noformat}
> for n in foo bar; do
> qdmanage CREATE --type connector --name $n role=route-container
> host=localhost port=5673;
> qdmanage CREATE --type linkRoute --name $n pattern=$n direction=in
> connection=$n;
> done;
> qdstat --linkroute
> {noformat}
> Only one of these link routes is active though both connections are
> established.
> The issues is that when the first connection is established, it indexes the
> qdr_conn_identifier_t by container-id and the connection label from the
> connector. When the second connection is established, it looks up first by
> container id, so adds itself to the qdr_conn_identifier_t created by the
> first connection. There is then no entry in the index for the connection
> label of the second connector, so the second link route can never be
> activated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2030) Use CLOCK_MONOTONIC in proactors for pn_transport_tick
[
https://issues.apache.org/jira/browse/PROTON-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964086#comment-16964086
]
ASF GitHub Bot commented on PROTON-2030:
jdanekrh commented on pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in
proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341169869
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
The more I think about this, the more confused I feel.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use CLOCK_MONOTONIC in proactors for pn_transport_tick
> --
>
> Key: PROTON-2030
> URL: https://issues.apache.org/jira/browse/PROTON-2030
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
>Affects Versions: proton-c-0.27.0
>Reporter: Jiri Daněk
>Priority: Major
>
> IOCP and epoll proactors are feeding wall clock time to pn_transport_tick. I
> tested (with epoll) that changing system clock breaks heartbeating.
> The libuv proactor does use monotonic already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2030) Use CLOCK_MONOTONIC in proactors for pn_transport_tick
[
https://issues.apache.org/jira/browse/PROTON-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964085#comment-16964085
]
ASF GitHub Bot commented on PROTON-2030:
jdanekrh commented on pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in
proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341169458
##
File path: c/src/proactor/win_iocp.c
##
@@ -1968,9 +1955,9 @@ class reaper {
// Call with lock
if (timer_ || !running)
return;
-pn_timestamp_t now = pn_i_now2();
+int64_t now = pn_proactor_now_64();
pni_zombie_check(iocp_, now);
-pn_timestamp_t zd = pni_zombie_deadline(iocp_);
+int64_t zd = pni_zombie_deadline(iocp_);
if (zd) {
DWORD tm = (zd > now) ? zd - now : 1;
Review comment:
Here the subtraction will not wraparound, so I am not touching it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use CLOCK_MONOTONIC in proactors for pn_transport_tick
> --
>
> Key: PROTON-2030
> URL: https://issues.apache.org/jira/browse/PROTON-2030
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
>Affects Versions: proton-c-0.27.0
>Reporter: Jiri Daněk
>Priority: Major
>
> IOCP and epoll proactors are feeding wall clock time to pn_transport_tick. I
> tested (with epoll) that changing system clock breaks heartbeating.
> The libuv proactor does use monotonic already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jdanekrh commented on a change in pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in proactors for pn_transport_tick
jdanekrh commented on a change in pull request #180: PROTON-2030 Use
CLOCK_MONOTONIC in proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341169869
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
The more I think about this, the more confused I feel.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jdanekrh commented on a change in pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in proactors for pn_transport_tick
jdanekrh commented on a change in pull request #180: PROTON-2030 Use
CLOCK_MONOTONIC in proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341169458
##
File path: c/src/proactor/win_iocp.c
##
@@ -1968,9 +1955,9 @@ class reaper {
// Call with lock
if (timer_ || !running)
return;
-pn_timestamp_t now = pn_i_now2();
+int64_t now = pn_proactor_now_64();
pni_zombie_check(iocp_, now);
-pn_timestamp_t zd = pni_zombie_deadline(iocp_);
+int64_t zd = pni_zombie_deadline(iocp_);
if (zd) {
DWORD tm = (zd > now) ? zd - now : 1;
Review comment:
Here the subtraction will not wraparound, so I am not touching it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2030) Use CLOCK_MONOTONIC in proactors for pn_transport_tick
[
https://issues.apache.org/jira/browse/PROTON-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964072#comment-16964072
]
ASF GitHub Bot commented on PROTON-2030:
jdanekrh commented on pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in
proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341160594
##
File path: c/src/proactor/win_iocp.c
##
@@ -3427,11 +3414,9 @@ const pn_netaddr_t *pn_listener_addr(pn_listener_t *l) {
}
pn_millis_t pn_proactor_now(void) {
- FILETIME now;
- GetSystemTimeAsFileTime();
- ULARGE_INTEGER t;
- t.u.HighPart = now.dwHighDateTime;
- t.u.LowPart = now.dwLowDateTime;
- // Convert to milliseconds and adjust base epoch
- return t.QuadPart / 1 - 1164447360;
+return (pn_millis_t) pn_proactor_now_64();
+}
+
+int64_t pn_proactor_now_64(void) {
Review comment:
Thanks for the explanation. I am going to make the change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use CLOCK_MONOTONIC in proactors for pn_transport_tick
> --
>
> Key: PROTON-2030
> URL: https://issues.apache.org/jira/browse/PROTON-2030
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
>Affects Versions: proton-c-0.27.0
>Reporter: Jiri Daněk
>Priority: Major
>
> IOCP and epoll proactors are feeding wall clock time to pn_transport_tick. I
> tested (with epoll) that changing system clock breaks heartbeating.
> The libuv proactor does use monotonic already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jdanekrh commented on a change in pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in proactors for pn_transport_tick
jdanekrh commented on a change in pull request #180: PROTON-2030 Use
CLOCK_MONOTONIC in proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341160594
##
File path: c/src/proactor/win_iocp.c
##
@@ -3427,11 +3414,9 @@ const pn_netaddr_t *pn_listener_addr(pn_listener_t *l) {
}
pn_millis_t pn_proactor_now(void) {
- FILETIME now;
- GetSystemTimeAsFileTime();
- ULARGE_INTEGER t;
- t.u.HighPart = now.dwHighDateTime;
- t.u.LowPart = now.dwLowDateTime;
- // Convert to milliseconds and adjust base epoch
- return t.QuadPart / 1 - 1164447360;
+return (pn_millis_t) pn_proactor_now_64();
+}
+
+int64_t pn_proactor_now_64(void) {
Review comment:
Thanks for the explanation. I am going to make the change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1464) [test] Python triggers proton assert in system_tests_delivery_abort test
[
https://issues.apache.org/jira/browse/DISPATCH-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964042#comment-16964042
]
Charles E. Rolke commented on DISPATCH-1464:
attach a python backtrace.
> [test] Python triggers proton assert in system_tests_delivery_abort test
>
>
> Key: DISPATCH-1464
> URL: https://issues.apache.org/jira/browse/DISPATCH-1464
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.9.0
> Environment: Fedora 29
> Proton 0.29
> Dispatch master now, and a week ago at commit 015c1c
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Attachments: DISPATCH-1464-py-bt.txt, DISPATCH-1464-stacktrace.txt
>
>
> Running the test in a loop quickly (<20 passes) fails with:
> {{
> 41: test_05_message_route_abort_one_router
> (system_tests_delivery_abort.RouterTest)
> ... python: /home/chug/git/qpid-proton/c/src/core/engine.c:691:
> pni_add_work: Assertion `!delivery->local.settled' failed.
> 1/1 Test #41: system_tests_delivery_abort ..Child aborted***Exception:
> 4.47 sec
> }}
> python backtrace attached
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2030) Use CLOCK_MONOTONIC in proactors for pn_transport_tick
[
https://issues.apache.org/jira/browse/PROTON-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964040#comment-16964040
]
ASF GitHub Bot commented on PROTON-2030:
astitcher commented on pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in
proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341148531
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
To be clear I agree that the external API should maintain signed values - it
really has to in any case for back compatibility. but the very specific case of
this subtraction needs to be done in correct wraparound mode so unsigned is
required here (even if you just cast it back immediately to signed)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use CLOCK_MONOTONIC in proactors for pn_transport_tick
> --
>
> Key: PROTON-2030
> URL: https://issues.apache.org/jira/browse/PROTON-2030
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
>Affects Versions: proton-c-0.27.0
>Reporter: Jiri Daněk
>Priority: Major
>
> IOCP and epoll proactors are feeding wall clock time to pn_transport_tick. I
> tested (with epoll) that changing system clock breaks heartbeating.
> The libuv proactor does use monotonic already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on a change in pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in proactors for pn_transport_tick
astitcher commented on a change in pull request #180: PROTON-2030 Use
CLOCK_MONOTONIC in proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341148531
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
To be clear I agree that the external API should maintain signed values - it
really has to in any case for back compatibility. but the very specific case of
this subtraction needs to be done in correct wraparound mode so unsigned is
required here (even if you just cast it back immediately to signed)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1464) [test] Python triggers proton assert in system_tests_delivery_abort test
[
https://issues.apache.org/jira/browse/DISPATCH-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles E. Rolke updated DISPATCH-1464:
---
Attachment: DISPATCH-1464-py-bt.txt
> [test] Python triggers proton assert in system_tests_delivery_abort test
>
>
> Key: DISPATCH-1464
> URL: https://issues.apache.org/jira/browse/DISPATCH-1464
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.9.0
> Environment: Fedora 29
> Proton 0.29
> Dispatch master now, and a week ago at commit 015c1c
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Attachments: DISPATCH-1464-py-bt.txt, DISPATCH-1464-stacktrace.txt
>
>
> Running the test in a loop quickly (<20 passes) fails with:
> {{
> 41: test_05_message_route_abort_one_router
> (system_tests_delivery_abort.RouterTest)
> ... python: /home/chug/git/qpid-proton/c/src/core/engine.c:691:
> pni_add_work: Assertion `!delivery->local.settled' failed.
> 1/1 Test #41: system_tests_delivery_abort ..Child aborted***Exception:
> 4.47 sec
> }}
> python backtrace attached
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2030) Use CLOCK_MONOTONIC in proactors for pn_transport_tick
[
https://issues.apache.org/jira/browse/PROTON-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964039#comment-16964039
]
ASF GitHub Bot commented on PROTON-2030:
astitcher commented on pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in
proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341147231
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
@jdanekrh If it helps the unsigned arithmetic is still correct when the cast
signed values are negative. And given that the C language only defines unsigned
arithmetic to be correctly wrapping the subtraction must use uints.
@alanconway you are assuming that the now value is based at 0 which is not a
given - and in fact it is common to test timer wraparound by starting the 'now'
monotonic timer at MAXINT-a few minutes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use CLOCK_MONOTONIC in proactors for pn_transport_tick
> --
>
> Key: PROTON-2030
> URL: https://issues.apache.org/jira/browse/PROTON-2030
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
>Affects Versions: proton-c-0.27.0
>Reporter: Jiri Daněk
>Priority: Major
>
> IOCP and epoll proactors are feeding wall clock time to pn_transport_tick. I
> tested (with epoll) that changing system clock breaks heartbeating.
> The libuv proactor does use monotonic already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on a change in pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in proactors for pn_transport_tick
astitcher commented on a change in pull request #180: PROTON-2030 Use
CLOCK_MONOTONIC in proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341147231
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
@jdanekrh If it helps the unsigned arithmetic is still correct when the cast
signed values are negative. And given that the C language only defines unsigned
arithmetic to be correctly wrapping the subtraction must use uints.
@alanconway you are assuming that the now value is based at 0 which is not a
given - and in fact it is common to test timer wraparound by starting the 'now'
monotonic timer at MAXINT-a few minutes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1464) [test] Python triggers proton assert in system_tests_delivery_abort test
[
https://issues.apache.org/jira/browse/DISPATCH-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles E. Rolke reassigned DISPATCH-1464:
--
Assignee: Charles E. Rolke
> [test] Python triggers proton assert in system_tests_delivery_abort test
>
>
> Key: DISPATCH-1464
> URL: https://issues.apache.org/jira/browse/DISPATCH-1464
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.9.0
> Environment: Fedora 29
> Proton 0.29
> Dispatch master now, and a week ago at commit 015c1c
>Reporter: Charles E. Rolke
>Assignee: Charles E. Rolke
>Priority: Major
> Attachments: DISPATCH-1464-stacktrace.txt
>
>
> Running the test in a loop quickly (<20 passes) fails with:
> {{
> 41: test_05_message_route_abort_one_router
> (system_tests_delivery_abort.RouterTest)
> ... python: /home/chug/git/qpid-proton/c/src/core/engine.c:691:
> pni_add_work: Assertion `!delivery->local.settled' failed.
> 1/1 Test #41: system_tests_delivery_abort ..Child aborted***Exception:
> 4.47 sec
> }}
> python backtrace attached
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2030) Use CLOCK_MONOTONIC in proactors for pn_transport_tick
[
https://issues.apache.org/jira/browse/PROTON-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963930#comment-16963930
]
ASF GitHub Bot commented on PROTON-2030:
alanconway commented on pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in
proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341102642
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
Signed arithmetic is a lot easier in general, since you can have negative
intermediate results in an expression, and express offsets in both directions
in a straightforward way. I'd prefer signed in the public API unless there's a
massively good reason to go unsigned. Overflow in 34,000,000,000 years instead
of 17,000,000,000 years doesn't strike me as a massively good reason, although
obviously programmers in the year 17,000,001,969 will curse my
short-sightedness. Trust Andrew to be considerate of the hyper-intelligent
horseshoe-crabs that will be masters of the planet then.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use CLOCK_MONOTONIC in proactors for pn_transport_tick
> --
>
> Key: PROTON-2030
> URL: https://issues.apache.org/jira/browse/PROTON-2030
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
>Affects Versions: proton-c-0.27.0
>Reporter: Jiri Daněk
>Priority: Major
>
> IOCP and epoll proactors are feeding wall clock time to pn_transport_tick. I
> tested (with epoll) that changing system clock breaks heartbeating.
> The libuv proactor does use monotonic already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] alanconway commented on a change in pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in proactors for pn_transport_tick
alanconway commented on a change in pull request #180: PROTON-2030 Use
CLOCK_MONOTONIC in proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341102642
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
Signed arithmetic is a lot easier in general, since you can have negative
intermediate results in an expression, and express offsets in both directions
in a straightforward way. I'd prefer signed in the public API unless there's a
massively good reason to go unsigned. Overflow in 34,000,000,000 years instead
of 17,000,000,000 years doesn't strike me as a massively good reason, although
obviously programmers in the year 17,000,001,969 will curse my
short-sightedness. Trust Andrew to be considerate of the hyper-intelligent
horseshoe-crabs that will be masters of the planet then.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2030) Use CLOCK_MONOTONIC in proactors for pn_transport_tick
[
https://issues.apache.org/jira/browse/PROTON-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963864#comment-16963864
]
ASF GitHub Bot commented on PROTON-2030:
jdanekrh commented on pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in
proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341068567
##
File path: c/src/proactor/win_iocp.c
##
@@ -3427,11 +3414,9 @@ const pn_netaddr_t *pn_listener_addr(pn_listener_t *l) {
}
pn_millis_t pn_proactor_now(void) {
- FILETIME now;
- GetSystemTimeAsFileTime();
- ULARGE_INTEGER t;
- t.u.HighPart = now.dwHighDateTime;
- t.u.LowPart = now.dwLowDateTime;
- // Convert to milliseconds and adjust base epoch
- return t.QuadPart / 1 - 1164447360;
+return (pn_millis_t) pn_proactor_now_64();
+}
+
+int64_t pn_proactor_now_64(void) {
Review comment:
@astitcher So you you think that pn_proactor_now whould return signed or
unsigned value? Because one response given your comments could be to just go
unsigned everywhere.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use CLOCK_MONOTONIC in proactors for pn_transport_tick
> --
>
> Key: PROTON-2030
> URL: https://issues.apache.org/jira/browse/PROTON-2030
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
>Affects Versions: proton-c-0.27.0
>Reporter: Jiri Daněk
>Priority: Major
>
> IOCP and epoll proactors are feeding wall clock time to pn_transport_tick. I
> tested (with epoll) that changing system clock breaks heartbeating.
> The libuv proactor does use monotonic already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jdanekrh commented on a change in pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in proactors for pn_transport_tick
jdanekrh commented on a change in pull request #180: PROTON-2030 Use
CLOCK_MONOTONIC in proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341068567
##
File path: c/src/proactor/win_iocp.c
##
@@ -3427,11 +3414,9 @@ const pn_netaddr_t *pn_listener_addr(pn_listener_t *l) {
}
pn_millis_t pn_proactor_now(void) {
- FILETIME now;
- GetSystemTimeAsFileTime();
- ULARGE_INTEGER t;
- t.u.HighPart = now.dwHighDateTime;
- t.u.LowPart = now.dwLowDateTime;
- // Convert to milliseconds and adjust base epoch
- return t.QuadPart / 1 - 1164447360;
+return (pn_millis_t) pn_proactor_now_64();
+}
+
+int64_t pn_proactor_now_64(void) {
Review comment:
@astitcher So you you think that pn_proactor_now whould return signed or
unsigned value? Because one response given your comments could be to just go
unsigned everywhere.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jdanekrh commented on a change in pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in proactors for pn_transport_tick
jdanekrh commented on a change in pull request #180: PROTON-2030 Use
CLOCK_MONOTONIC in proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341046138
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
Yes, ok. But first I'll spend some time trying to remember why I was so
eager on signed arithmetic back then.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2030) Use CLOCK_MONOTONIC in proactors for pn_transport_tick
[
https://issues.apache.org/jira/browse/PROTON-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963829#comment-16963829
]
ASF GitHub Bot commented on PROTON-2030:
jdanekrh commented on pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in
proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341046138
##
File path: c/src/proactor/epoll.c
##
@@ -1426,10 +1419,10 @@ static void pconnection_tick(pconnection_t *pc) {
pn_transport_t *t = pc->driver.transport;
if (pn_transport_get_idle_timeout(t) ||
pn_transport_get_remote_idle_timeout(t)) {
ptimer_set(>timer, 0);
-uint64_t now = pn_i_now2();
-uint64_t next = pn_transport_tick(t, now);
+int64_t now = pn_proactor_now_64();
+int64_t next = pn_transport_tick(t, now);
if (next) {
- ptimer_set(>timer, next - now);
+ ptimer_set(>timer, (uint64_t) next - now);
}
Review comment:
Yes, ok. But first I'll spend some time trying to remember why I was so
eager on signed arithmetic back then.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use CLOCK_MONOTONIC in proactors for pn_transport_tick
> --
>
> Key: PROTON-2030
> URL: https://issues.apache.org/jira/browse/PROTON-2030
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
>Affects Versions: proton-c-0.27.0
>Reporter: Jiri Daněk
>Priority: Major
>
> IOCP and epoll proactors are feeding wall clock time to pn_transport_tick. I
> tested (with epoll) that changing system clock breaks heartbeating.
> The libuv proactor does use monotonic already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
