[GitHub] [qpid-broker-j] YYTVicky opened a new pull request #47: change Random to SecureRandom -fixp46

[GitBox]

YYTVicky opened a new pull request #47:
URL: https://github.com/apache/qpid-broker-j/pull/47


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-1636) Extract the version advertized in the Open performative by the peer router

[Ken Giusti (Jira)]

Ken Giusti created DISPATCH-1636:


 Summary: Extract the version advertized in the Open performative 
by the peer router 
 Key: DISPATCH-1636
 URL: https://issues.apache.org/jira/browse/DISPATCH-1636
 Project: Qpid Dispatch
  Issue Type: Improvement
  Components: Router Node
Affects Versions: 1.12.0
Reporter: Ken Giusti
Assignee: Ken Giusti
 Fix For: 1.13.0


Cache the version in the qdr_connection_info to use for backward compatibility 
checking.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (DISPATCH-1631) system_tests_bad_configuration fails if the router is not already installed

[Charles E. Rolke (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles E. Rolke resolved DISPATCH-1631.

Fix Version/s: 1.13.0
   Resolution: Fixed

Commit 4527ad

 

> system_tests_bad_configuration fails if the router is not already installed
> ---
>
> Key: DISPATCH-1631
> URL: https://issues.apache.org/jira/browse/DISPATCH-1631
> Project: Qpid Dispatch
>  Issue Type: Test
>  Components: Tests
>Affects Versions: 1.12.0
>Reporter: Robbie Gemmell
>Assignee: Charles E. Rolke
>Priority: Major
> Fix For: 1.13.0
>
> Attachments: DISPATCH-1631.txt
>
>
> _test_verify_reject_id_with_ctrl_char_ and 
> _test_verify_reject_id_with_whitespace_ from _system_tests_bad_configuration_ 
> fail unless the router is already installed, which is annoying given it is 
> typical to test before installing.
> If the tests do need an install for some reason they could perhaps verify one 
> exists which works with good config, rather than fail because one doesnt 
> exist.
> I have noted similar issues with tests in the past, which seems to point to a 
> change needed in the CI to actually catch such things as they happen.
> {noformat}
>  Start 51: system_tests_bad_configuration
> 51: Test command: /usr/bin/python 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/tests/run.py"
>  "-m" "unittest" "-v" "system_tests_bad_configuration"
> 51: Test timeout computed to be: 600
> 51: test_qdmanage_query 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: test_unresolvable_host_caught 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: 
> 51: Router QDR.A debug dump file:
> 51: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 1
> 51: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 1
> 51: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar) ... FAIL
> 51: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace) ... FAIL
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 203, in test_verify_reject_id_with_ctrl_char
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 243, in test_verify_reject_id_with_whitespace
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: --
> 51: Ran 4 tests in 1.293s
> 51: 
> 51: FAILED (failures=2)
> 51: output: 2020-04-28 09:57:22.734890 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 51: output: 2020-04-28 09:57:22.838318 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 1/1 Test #51: system_tests_bad_configuration ...***Failed 1.35 sec
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1631) system_tests_bad_configuration fails if the router is not already installed

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095859#comment-17095859
 ] 

ASF subversion and git services commented on DISPATCH-1631:
---

Commit 4527ad7bf8d8c44090e8220b2103258bcc122995 in qpid-dispatch's branch 
refs/heads/master from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=4527ad7 ]

DISPATCH-1631: bad_configuration tests failed to start qdrouterd

Command line was missing -I switch to locate python libs.


> system_tests_bad_configuration fails if the router is not already installed
> ---
>
> Key: DISPATCH-1631
> URL: https://issues.apache.org/jira/browse/DISPATCH-1631
> Project: Qpid Dispatch
>  Issue Type: Test
>  Components: Tests
>Affects Versions: 1.12.0
>Reporter: Robbie Gemmell
>Assignee: Charles E. Rolke
>Priority: Major
> Attachments: DISPATCH-1631.txt
>
>
> _test_verify_reject_id_with_ctrl_char_ and 
> _test_verify_reject_id_with_whitespace_ from _system_tests_bad_configuration_ 
> fail unless the router is already installed, which is annoying given it is 
> typical to test before installing.
> If the tests do need an install for some reason they could perhaps verify one 
> exists which works with good config, rather than fail because one doesnt 
> exist.
> I have noted similar issues with tests in the past, which seems to point to a 
> change needed in the CI to actually catch such things as they happen.
> {noformat}
>  Start 51: system_tests_bad_configuration
> 51: Test command: /usr/bin/python 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/tests/run.py"
>  "-m" "unittest" "-v" "system_tests_bad_configuration"
> 51: Test timeout computed to be: 600
> 51: test_qdmanage_query 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: test_unresolvable_host_caught 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: 
> 51: Router QDR.A debug dump file:
> 51: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 1
> 51: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 1
> 51: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar) ... FAIL
> 51: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace) ... FAIL
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 203, in test_verify_reject_id_with_ctrl_char
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 243, in test_verify_reject_id_with_whitespace
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: --
> 51: Ran 4 tests in 1.293s
> 51: 
> 51: FAILED (failures=2)
> 51: output: 2020-04-28 09:57:22.734890 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 51: output: 2020-04-28 09:57:22.838318 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 1/1 Test #51: system_tests_bad_configuration ...***Failed 1.35 sec
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: 

[jira] [Commented] (DISPATCH-1631) system_tests_bad_configuration fails if the router is not already installed

[Charles E. Rolke (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095740#comment-17095740
 ] 

Charles E. Rolke commented on DISPATCH-1631:


After sanitizing more of the cmake install root I was able to reproduce this 
issue.

> system_tests_bad_configuration fails if the router is not already installed
> ---
>
> Key: DISPATCH-1631
> URL: https://issues.apache.org/jira/browse/DISPATCH-1631
> Project: Qpid Dispatch
>  Issue Type: Test
>  Components: Tests
>Affects Versions: 1.12.0
>Reporter: Robbie Gemmell
>Assignee: Charles E. Rolke
>Priority: Major
> Attachments: DISPATCH-1631.txt
>
>
> _test_verify_reject_id_with_ctrl_char_ and 
> _test_verify_reject_id_with_whitespace_ from _system_tests_bad_configuration_ 
> fail unless the router is already installed, which is annoying given it is 
> typical to test before installing.
> If the tests do need an install for some reason they could perhaps verify one 
> exists which works with good config, rather than fail because one doesnt 
> exist.
> I have noted similar issues with tests in the past, which seems to point to a 
> change needed in the CI to actually catch such things as they happen.
> {noformat}
>  Start 51: system_tests_bad_configuration
> 51: Test command: /usr/bin/python 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/tests/run.py"
>  "-m" "unittest" "-v" "system_tests_bad_configuration"
> 51: Test timeout computed to be: 600
> 51: test_qdmanage_query 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: test_unresolvable_host_caught 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: 
> 51: Router QDR.A debug dump file:
> 51: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 1
> 51: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 1
> 51: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar) ... FAIL
> 51: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace) ... FAIL
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 203, in test_verify_reject_id_with_ctrl_char
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 243, in test_verify_reject_id_with_whitespace
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: --
> 51: Ran 4 tests in 1.293s
> 51: 
> 51: FAILED (failures=2)
> 51: output: 2020-04-28 09:57:22.734890 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 51: output: 2020-04-28 09:57:22.838318 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 1/1 Test #51: system_tests_bad_configuration ...***Failed 1.35 sec
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1631) system_tests_bad_configuration fails if the router is not already installed

[Charles E. Rolke (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095726#comment-17095726
 ] 

Charles E. Rolke commented on DISPATCH-1631:


Indeed that is a mystery. I downloaded the 1.12 rc kit and built it with

{noformat}
mkdir build
cd build
cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=/opt/local ..
make -j 8
{noformat}

After the build completes source config.sh and see where it looks for qdrouterd

{noformat}
. config.sh
which qdrouterd
~/Downloads/qpid-dispatch-1.12.0/build/router/qdrouterd
{noformat}

It is not finding the executable in the install area (/opt/local) but in the 
expected place in the build tree.

These tests do not use the standard methods to launch qdrouterd. The standard 
methods don't respond well to routers that are supposed to fail. I suspect that 
the tests are in error in the subprocess launcher calculations. That will be 
the next path of study.

> system_tests_bad_configuration fails if the router is not already installed
> ---
>
> Key: DISPATCH-1631
> URL: https://issues.apache.org/jira/browse/DISPATCH-1631
> Project: Qpid Dispatch
>  Issue Type: Test
>  Components: Tests
>Affects Versions: 1.12.0
>Reporter: Robbie Gemmell
>Assignee: Charles E. Rolke
>Priority: Major
> Attachments: DISPATCH-1631.txt
>
>
> _test_verify_reject_id_with_ctrl_char_ and 
> _test_verify_reject_id_with_whitespace_ from _system_tests_bad_configuration_ 
> fail unless the router is already installed, which is annoying given it is 
> typical to test before installing.
> If the tests do need an install for some reason they could perhaps verify one 
> exists which works with good config, rather than fail because one doesnt 
> exist.
> I have noted similar issues with tests in the past, which seems to point to a 
> change needed in the CI to actually catch such things as they happen.
> {noformat}
>  Start 51: system_tests_bad_configuration
> 51: Test command: /usr/bin/python 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/tests/run.py"
>  "-m" "unittest" "-v" "system_tests_bad_configuration"
> 51: Test timeout computed to be: 600
> 51: test_qdmanage_query 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: test_unresolvable_host_caught 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: 
> 51: Router QDR.A debug dump file:
> 51: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 1
> 51: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 1
> 51: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar) ... FAIL
> 51: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace) ... FAIL
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 203, in test_verify_reject_id_with_ctrl_char
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 243, in test_verify_reject_id_with_whitespace
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: --
> 51: Ran 4 tests in 1.293s
> 51: 
> 51: FAILED (failures=2)
> 51: output: 2020-04-28 09:57:22.734890 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 51: output: 2020-04-28 09:57:22.838318 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 

[jira] [Resolved] (DISPATCH-1624) Doc max message size

[Ben Hardesty (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ben Hardesty resolved DISPATCH-1624.

Fix Version/s: 1.13.0
   Resolution: Fixed

> Doc max message size
> 
>
> Key: DISPATCH-1624
> URL: https://issues.apache.org/jira/browse/DISPATCH-1624
> Project: Qpid Dispatch
>  Issue Type: Task
>  Components: Documentation
>Reporter: Ben Hardesty
>Assignee: Ben Hardesty
>Priority: Major
> Fix For: 1.13.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1624) Doc max message size

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095571#comment-17095571
 ] 

ASF subversion and git services commented on DISPATCH-1624:
---

Commit 96d1c1b8d315aa72738b026808cf928e2e3e1579 in qpid-dispatch's branch 
refs/heads/master from Ben Hardesty
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=96d1c1b ]

DISPATCH-1624: doc max message size. This closes #729.


> Doc max message size
> 
>
> Key: DISPATCH-1624
> URL: https://issues.apache.org/jira/browse/DISPATCH-1624
> Project: Qpid Dispatch
>  Issue Type: Task
>  Components: Documentation
>Reporter: Ben Hardesty
>Assignee: Ben Hardesty
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1631) system_tests_bad_configuration fails if the router is not already installed

[Robbie Gemmell (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095549#comment-17095549
 ] 

Robbie Gemmell commented on DISPATCH-1631:
--

I have attached a start to finish copy showing a download, build, test failure, 
install, test pass sequence. I ran it on a second system rather than the one I 
used originally when hitting the issue.

> system_tests_bad_configuration fails if the router is not already installed
> ---
>
> Key: DISPATCH-1631
> URL: https://issues.apache.org/jira/browse/DISPATCH-1631
> Project: Qpid Dispatch
>  Issue Type: Test
>  Components: Tests
>Affects Versions: 1.12.0
>Reporter: Robbie Gemmell
>Assignee: Charles E. Rolke
>Priority: Major
> Attachments: DISPATCH-1631.txt
>
>
> _test_verify_reject_id_with_ctrl_char_ and 
> _test_verify_reject_id_with_whitespace_ from _system_tests_bad_configuration_ 
> fail unless the router is already installed, which is annoying given it is 
> typical to test before installing.
> If the tests do need an install for some reason they could perhaps verify one 
> exists which works with good config, rather than fail because one doesnt 
> exist.
> I have noted similar issues with tests in the past, which seems to point to a 
> change needed in the CI to actually catch such things as they happen.
> {noformat}
>  Start 51: system_tests_bad_configuration
> 51: Test command: /usr/bin/python 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/tests/run.py"
>  "-m" "unittest" "-v" "system_tests_bad_configuration"
> 51: Test timeout computed to be: 600
> 51: test_qdmanage_query 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: test_unresolvable_host_caught 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: 
> 51: Router QDR.A debug dump file:
> 51: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 1
> 51: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 1
> 51: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar) ... FAIL
> 51: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace) ... FAIL
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 203, in test_verify_reject_id_with_ctrl_char
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 243, in test_verify_reject_id_with_whitespace
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: --
> 51: Ran 4 tests in 1.293s
> 51: 
> 51: FAILED (failures=2)
> 51: output: 2020-04-28 09:57:22.734890 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 51: output: 2020-04-28 09:57:22.838318 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 1/1 Test #51: system_tests_bad_configuration ...***Failed 1.35 sec
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-1631) system_tests_bad_configuration fails if the router is not already installed

[Robbie Gemmell (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated DISPATCH-1631:
-
Attachment: DISPATCH-1631.txt

> system_tests_bad_configuration fails if the router is not already installed
> ---
>
> Key: DISPATCH-1631
> URL: https://issues.apache.org/jira/browse/DISPATCH-1631
> Project: Qpid Dispatch
>  Issue Type: Test
>  Components: Tests
>Affects Versions: 1.12.0
>Reporter: Robbie Gemmell
>Assignee: Charles E. Rolke
>Priority: Major
> Attachments: DISPATCH-1631.txt
>
>
> _test_verify_reject_id_with_ctrl_char_ and 
> _test_verify_reject_id_with_whitespace_ from _system_tests_bad_configuration_ 
> fail unless the router is already installed, which is annoying given it is 
> typical to test before installing.
> If the tests do need an install for some reason they could perhaps verify one 
> exists which works with good config, rather than fail because one doesnt 
> exist.
> I have noted similar issues with tests in the past, which seems to point to a 
> change needed in the CI to actually catch such things as they happen.
> {noformat}
>  Start 51: system_tests_bad_configuration
> 51: Test command: /usr/bin/python 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/tests/run.py"
>  "-m" "unittest" "-v" "system_tests_bad_configuration"
> 51: Test timeout computed to be: 600
> 51: test_qdmanage_query 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: test_unresolvable_host_caught 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: 
> 51: Router QDR.A debug dump file:
> 51: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 1
> 51: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 1
> 51: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar) ... FAIL
> 51: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace) ... FAIL
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 203, in test_verify_reject_id_with_ctrl_char
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 243, in test_verify_reject_id_with_whitespace
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: --
> 51: Ran 4 tests in 1.293s
> 51: 
> 51: FAILED (failures=2)
> 51: output: 2020-04-28 09:57:22.734890 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 51: output: 2020-04-28 09:57:22.838318 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 1/1 Test #51: system_tests_bad_configuration ...***Failed 1.35 sec
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1631) system_tests_bad_configuration fails if the router is not already installed

[Robbie Gemmell (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095541#comment-17095541
 ] 

Robbie Gemmell commented on DISPATCH-1631:
--

To confirm, seems I did source config.sh:
{noformat}
build]$ . config.sh 
{noformat}

> system_tests_bad_configuration fails if the router is not already installed
> ---
>
> Key: DISPATCH-1631
> URL: https://issues.apache.org/jira/browse/DISPATCH-1631
> Project: Qpid Dispatch
>  Issue Type: Test
>  Components: Tests
>Affects Versions: 1.12.0
>Reporter: Robbie Gemmell
>Assignee: Charles E. Rolke
>Priority: Major
>
> _test_verify_reject_id_with_ctrl_char_ and 
> _test_verify_reject_id_with_whitespace_ from _system_tests_bad_configuration_ 
> fail unless the router is already installed, which is annoying given it is 
> typical to test before installing.
> If the tests do need an install for some reason they could perhaps verify one 
> exists which works with good config, rather than fail because one doesnt 
> exist.
> I have noted similar issues with tests in the past, which seems to point to a 
> change needed in the CI to actually catch such things as they happen.
> {noformat}
>  Start 51: system_tests_bad_configuration
> 51: Test command: /usr/bin/python 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/tests/run.py"
>  "-m" "unittest" "-v" "system_tests_bad_configuration"
> 51: Test timeout computed to be: 600
> 51: test_qdmanage_query 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: test_unresolvable_host_caught 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: 
> 51: Router QDR.A debug dump file:
> 51: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 1
> 51: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 1
> 51: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar) ... FAIL
> 51: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace) ... FAIL
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 203, in test_verify_reject_id_with_ctrl_char
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 243, in test_verify_reject_id_with_whitespace
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: --
> 51: Ran 4 tests in 1.293s
> 51: 
> 51: FAILED (failures=2)
> 51: output: 2020-04-28 09:57:22.734890 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 51: output: 2020-04-28 09:57:22.838318 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 1/1 Test #51: system_tests_bad_configuration ...***Failed 1.35 sec
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1631) system_tests_bad_configuration fails if the router is not already installed

[Robbie Gemmell (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095531#comment-17095531
 ] 

Robbie Gemmell commented on DISPATCH-1631:
--

Ill admit I cant remember whether I sourced config.sh or not - but even if i 
didn't it still seems odd only those 2 tests would fail, and either way they 
did so by looking for files in the install dir and then passed as soon as it 
was installed.

My testing would have been as follows:
{noformat}
mkdir build
cd build
cmake .. -DCMAKE_INSTALL_PREFIX=`pwd`/install

make -j4
ctest -V -R
{noformat}

> system_tests_bad_configuration fails if the router is not already installed
> ---
>
> Key: DISPATCH-1631
> URL: https://issues.apache.org/jira/browse/DISPATCH-1631
> Project: Qpid Dispatch
>  Issue Type: Test
>  Components: Tests
>Affects Versions: 1.12.0
>Reporter: Robbie Gemmell
>Assignee: Charles E. Rolke
>Priority: Major
>
> _test_verify_reject_id_with_ctrl_char_ and 
> _test_verify_reject_id_with_whitespace_ from _system_tests_bad_configuration_ 
> fail unless the router is already installed, which is annoying given it is 
> typical to test before installing.
> If the tests do need an install for some reason they could perhaps verify one 
> exists which works with good config, rather than fail because one doesnt 
> exist.
> I have noted similar issues with tests in the past, which seems to point to a 
> change needed in the CI to actually catch such things as they happen.
> {noformat}
>  Start 51: system_tests_bad_configuration
> 51: Test command: /usr/bin/python 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/tests/run.py"
>  "-m" "unittest" "-v" "system_tests_bad_configuration"
> 51: Test timeout computed to be: 600
> 51: test_qdmanage_query 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: test_unresolvable_host_caught 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: 
> 51: Router QDR.A debug dump file:
> 51: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 1
> 51: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 1
> 51: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar) ... FAIL
> 51: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace) ... FAIL
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 203, in test_verify_reject_id_with_ctrl_char
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 243, in test_verify_reject_id_with_whitespace
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: --
> 51: Ran 4 tests in 1.293s
> 51: 
> 51: FAILED (failures=2)
> 51: output: 2020-04-28 09:57:22.734890 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 51: output: 2020-04-28 09:57:22.838318 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 1/1 Test #51: system_tests_bad_configuration ...***Failed 1.35 sec
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: 

[jira] [Resolved] (DISPATCH-1633) system_tests_sasl_plain intermittent test failure

[Ganesh Murthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy resolved DISPATCH-1633.
-
Resolution: Fixed

> system_tests_sasl_plain intermittent test failure
> -
>
> Key: DISPATCH-1633
> URL: https://issues.apache.org/jira/browse/DISPATCH-1633
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.11.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.13.0
>
>
> {noformat}
>  FAIL: test_inter_router_sasl_fail 
> (system_tests_sasl_plain.RouterTestPlainSaslFailure)
> 31: --
> 31: Traceback (most recent call last):
> 31: File \"/opt/qpid-dispatch-src/tests/system_test.py\", line 788, in wrap
> 31: return f(*args, **kwargs)
> 31: File \"/opt/qpid-dispatch-src/tests/system_tests_sasl_plain.py\", line 
> 151, in test_inter_router_sasl_fail
> 31: self.assertTrue(sasl_failed)
> 31: AssertionError: False is not true{noformat}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1631) system_tests_bad_configuration fails if the router is not already installed

[Charles E. Rolke (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095463#comment-17095463
 ] 

Charles E. Rolke commented on DISPATCH-1631:


It is fundamental that the tests run with no qdrouterd installed. On my fedora 
system I have no qdrouterd installed and the test executes just fine.

{{chug@unused build> which qdrouterd}}
{{/usr/bin/which: no qdrouterd in (/my/user/path)}}

{{chug@unused build> ctest -R bad_config}}
{{Test project /home/chug/git/qpid-dispatch/build}}
{{ Start 51: system_tests_bad_configuration}}
{{  1/1 Test #51: system_tests_bad_configuration ... }}

{{Passed 1.38 sec}}
{{100% tests passed, 0 tests failed out of 1 }}{{Total }}

{{Test time (real) = 1.39 sec}}

Part of the _ctest_ scheme is to prepare the execution environment for the 
tests. This includes PYTHONPATH, PATH, and the rest of the environment defined 
in config.sh. The config.sh file is generated by the cmake build and is bound 
to the source location and the build location where cmake was run.

How is the failing system executing the test? From what directory?



> system_tests_bad_configuration fails if the router is not already installed
> ---
>
> Key: DISPATCH-1631
> URL: https://issues.apache.org/jira/browse/DISPATCH-1631
> Project: Qpid Dispatch
>  Issue Type: Test
>  Components: Tests
>Affects Versions: 1.12.0
>Reporter: Robbie Gemmell
>Assignee: Charles E. Rolke
>Priority: Major
>
> _test_verify_reject_id_with_ctrl_char_ and 
> _test_verify_reject_id_with_whitespace_ from _system_tests_bad_configuration_ 
> fail unless the router is already installed, which is annoying given it is 
> typical to test before installing.
> If the tests do need an install for some reason they could perhaps verify one 
> exists which works with good config, rather than fail because one doesnt 
> exist.
> I have noted similar issues with tests in the past, which seems to point to a 
> change needed in the CI to actually catch such things as they happen.
> {noformat}
>  Start 51: system_tests_bad_configuration
> 51: Test command: /usr/bin/python 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/tests/run.py"
>  "-m" "unittest" "-v" "system_tests_bad_configuration"
> 51: Test timeout computed to be: 600
> 51: test_qdmanage_query 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: test_unresolvable_host_caught 
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: 
> 51: Router QDR.A debug dump file:
> 51: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 1
> 51: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 1
> 51: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar) ... FAIL
> 51: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace) ... FAIL
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_ctrl_char 
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 203, in test_verify_reject_id_with_ctrl_char
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: ==
> 51: FAIL: test_verify_reject_id_with_whitespace 
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace)
> 51: --
> 51: Traceback (most recent call last):
> 51: File 
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
>  line 243, in test_verify_reject_id_with_whitespace
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51: 
> 51: --
> 51: Ran 4 tests in 1.293s
> 51: 
> 51: FAILED (failures=2)
> 51: output: 2020-04-28 09:57:22.734890 +0100 ERROR (error) Cannot find Python 
> library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: qdrouterd: Cannot find Python library path 
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
>  Unknown error 2
> 51: 
> 51: output: 2020-04-28 09:57:22.838318 +0100 ERROR (error) Cannot find Python 
> library path 
> 

Re: [VOTE] Release Qpid Dispatch Router 1.12.0 (RC1)

[Ken Giusti]

+1

This release successfully passed my stress tests w/o incident and no
apparent memory leaks:
- oslo-messaging stress test

- 2 router x 1 broker


On Tue, Apr 28, 2020 at 3:23 PM Ganesh Murthy  wrote:

> +1
>
> - Verified the signature and checksum
> - Checked for LICENCE + NOTICE files
> - Ran mvn apache-rat:check, no files with missing license headers found
> - Built against Proton 0.30.0 and ran the tests on Fedora 30. All tests
> passed
>
> On Mon, Apr 27, 2020 at 3:29 PM Ganesh Murthy  wrote:
>
> > Hello All,
> >
> >  Please cast your vote on this thread to release RC1 as the
> > official Qpid Dispatch Router version  1.12.0.
> >
> > RC1 of Qpid Dispatch Router version 1.12.0 can be found here:
> >
> > https://dist.apache.org/repos/dist/dev/qpid/dispatch/1.12.0-rc1/
> >
> > The following improvements, and bug fixes are introduced in 1.12.0:
> >
> >
> > Improvements -
> > DISPATCH-1479 - multicast/routing behaviour doc improvements
> > DISPATCH-1608 - Display workerThreads in the output of qdstat -g
> > and qdmanage query --type=router
> > DISPATCH-1611 - In debug mode, provide time and backtrace of
> > leaked pool allocations
> > DISPATCH-1615 - Backtrace of leaked allocations does not show object
> > address
> > DISPATCH-1616 - Scraper could export facts for creating sequence
> > diagrams
> > DISPATCH-1617 - Prevent router startup if edge or standalone
> > routers have 'edge' role listeners
> >
> > Bug fixes -
> > DISPATCH-1581 - Policy counters are int and should be uint64
> > DISPATCH-1593 - Fix legend in console's topology view
> > DISPATCH-1606 - Qpid dispatch console keeps trying to open
> > connections when using empty username and password against a listener
> > configured with SASL plain
> > DISPATCH-1607 - [test] one_router
> > test_48_connection_uptime_last_dlv ConnectionUptimeLastDlvTest
> > intermittent fail
> > DISPATCH-1609 - Policy denial logs omit the 'C' in the connection ID
> > DISPATCH-1610 - qd_pn_free_link_session_t objects leaking when
> > connections are socket closed
> > DISPATCH-1612 - Automatically fill in the address and port that
> > was used to serve the console into the console's connect form
> > DISPATCH-1613 - Remove error log that is issued when >
> > QDR_N_PRIORITY router links attach
> > DISPATCH-1614 - Edge router crash when interior closes edge uplink
> > connection
> > DISPATCH-1618 - Server shutdown leaks policy setting objects
> > DISPATCH-1622 - Router crash when trying to create connector via
> > qdmanage
> > DISPATCH-1626 - On released callback invoked twice for same delivery
> > tag
> > DISPATCH-1627 - Occasional leak of qd_iterator_buffer during
> > system_tests_link_route_credit test
> > DISPATCH-1628 - Crash after enforcing oversize message connection
> close
> > DISPATCH-1630 - Coverity issues on master branch
> >
> > Thanks.
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
> > For additional commands, e-mail: dev-h...@qpid.apache.org
> >
> >
>


-- 
-K

[jira] [Commented] (DISPATCH-1635) Allow listener to specify an optional request for TLS client auth

[Keith Wall (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095331#comment-17095331
 ] 

Keith Wall commented on DISPATCH-1635:
--

I *think* delivering this might invoke a Proton API change 
(pn_ssl_domain_set_peer_authentication) as it currently has responsibilities 
for setting the client CA and putting OpenSSL into SSL_VERIFY_PEER | 
SSL_VERIFY_FAIL_IF_NO_PEER_CERT mode.

> Allow listener to specify an optional request for TLS client auth
> -
>
> Key: DISPATCH-1635
> URL: https://issues.apache.org/jira/browse/DISPATCH-1635
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Keith Wall
>Priority: Minor
>
> Dispatch Router currently allows the user to configure a *mandatory 
> requirement* that TLS client authentication must be used for connections to a 
> TLS port.
> For some use-cases it is desirable for some clients to use TLS client-auth 
> and some clients to authenticate via other means. In Java parlance this mode 
> of operation is describing as 
> [Wanting|https://docs.oracle.com/en/java/javase/11/docs/api/java.base/javax/net/ssl/SSLServerSocket.html#setWantClientAuth(boolean)]
>  TLS client auth rather than 
> [Needing|https://docs.oracle.com/en/java/javase/11/docs/api/java.base/javax/net/ssl/SSLServerSocket.html#setNeedClientAuth(boolean)].
> It would be convenient if the configuration of TLS client auth in Dispatch 
> Router permitted the Want semantics.
> Currently with Dispatch Router to achieve this you need to configure two TLS 
> listeners, one with authenticatePeer: yes set true and the other not.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-1635) Allow listener to specify an optional request for TLS client auth

[Keith Wall (Jira)]

Keith Wall created DISPATCH-1635:


 Summary: Allow listener to specify an optional request for TLS 
client auth
 Key: DISPATCH-1635
 URL: https://issues.apache.org/jira/browse/DISPATCH-1635
 Project: Qpid Dispatch
  Issue Type: Improvement
Reporter: Keith Wall


Dispatch Router currently allows the user to configure a *mandatory 
requirement* that TLS client authentication must be used for connections to a 
TLS port.

For some use-cases it is desirable for some clients to use TLS client-auth and 
some clients to authenticate via other means. In Java parlance this mode of 
operation is describing as 
[Wanting|https://docs.oracle.com/en/java/javase/11/docs/api/java.base/javax/net/ssl/SSLServerSocket.html#setWantClientAuth(boolean)]
 TLS client auth rather than 
[Needing|https://docs.oracle.com/en/java/javase/11/docs/api/java.base/javax/net/ssl/SSLServerSocket.html#setNeedClientAuth(boolean)].

It would be convenient if the configuration of TLS client auth in Dispatch 
Router permitted the Want semantics.

Currently with Dispatch Router to achieve this you need to configure two TLS 
listeners, one with authenticatePeer: yes set true and the other not.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Comment Edited] (DISPATCH-1634) Expose client X509 certificate identity (TLS client auth) to the auth service delegate

[Keith Wall (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095275#comment-17095275
 ] 

Keith Wall edited comment on DISPATCH-1634 at 4/29/20, 9:20 AM:


In the case where the SASL EXTERNAL mechanism is selected by the client, the 
router's authplugin SASL relay should be able to prepare to rewrite the 
authorization identity within response of the SASL-INIT (or SASL-RESPONSE) and 
insert the identity from the client cert..

The SASL EXTERNAL specification[1] allows the for the authorization identity to 
be empty (the client is requesting to act as the identity the server has 
associated with the client's credentials) or non empty (the client is 
requesting to act as the identity represented by the string).  In the latter 
case, if the identity provided by the authorization string doesn't match the  
identity from the client cert, as the Dispatch Router has no means to verify 
that user is entitled to impersonate that user, it should preemptively end the 
SASL negotiation negatively.

[1] https://tools.ietf.org/html/rfc4422#page-29





was (Author: k-wall):
In the case where the SASL EXTERNAL mechanism is selected by the client, the 
router's authplugin SASL relay should be able to prepare to rewrite the 
authorization identity within response of the SASL-INIT (or SASL-RESPONSE) and 
insert the identity from the client cert..

The SASL EXTERNAL specification[1] allows the for the authorization identity to 
be empty (the client is requesting to act as the identity the server has 
associated with the client's credentials) or non empty (the client is 
requesting to act as the identity represented by the string).  In the latter 
case, if the identity provided by the authorization string doesn't match the  
identity from the client cert, as the router has no means to verify that user 
is entitled to impersonate that user, it should end the SASL negotiation 
negatively.

[1] https://tools.ietf.org/html/rfc4422#page-29




> Expose client X509 certificate identity (TLS client auth) to the auth service 
> delegate
> --
>
> Key: DISPATCH-1634
> URL: https://issues.apache.org/jira/browse/DISPATCH-1634
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Keith Wall
>Priority: Major
>
> For the use-case where Dispatch Router is configured to require the client 
> use TLS client auth (authenticatePeer: yes) and the authServicePlugin is in 
> use, there needs to be a mechanism to expose the X509 certificate identity of 
> the client to the auth service so it can be used to control the`address-authz 
> response. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Comment Edited] (DISPATCH-1634) Expose client X509 certificate identity (TLS client auth) to the auth service delegate

[Keith Wall (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095275#comment-17095275
 ] 

Keith Wall edited comment on DISPATCH-1634 at 4/29/20, 9:18 AM:


In the case where the SASL EXTERNAL mechanism is selected by the client, the 
router's authplugin SASL relay should be able to prepare to rewrite the 
authorization identity within response of the SASL-INIT (or SASL-RESPONSE) and 
insert the identity from the client cert..

The SASL EXTERNAL specification[1] allows the for the authorization identity to 
be empty (the client is requesting to act as the identity the server has 
associated with the client's credentials) or non empty (the client is 
requesting to act as the identity represented by the string).  In the latter 
case, if the identity provided by the authorization string doesn't match the  
identity from the client cert, as the router has no means to verify that user 
is entitled to impersonate that user, it should end the SASL negotiation 
negatively.

[1] https://tools.ietf.org/html/rfc4422#page-29





was (Author: k-wall):
In the case where the SASL EXTERNAL mechanism is selected by the client, the 
router's authplugin SASL relay should be able to prepare to rewrite the 
authorization identity within response of the SASL-INIT (or SASL-RESPONSE) and 
insert the identity from the client cert..

The SASL EXTERNAL specification[1] allows the for the authorization identity to 
be empty (the client is requesting to act as the identity the server has 
associated with the client's credentials) or non empty (the client is 
requesting to act as the identity represented by the string).  In the latter 
case, if the identity provided by the authorization string doesn't match the  
identity from the client cert, as the router has no means to verify that user 
is entitled to impersonate that user, it should end the SASL negotiation 
negatively.

[1] https://tools.ietf.org/html/rfc4422#page-29






If the authenticated identity that the client supplies is identical to the one 
we would form from the client cert, then there is no need to reject... but 
otherwise (absent any other form of verification/validation) it's a way of 
trying to impersonate and potentially a security hole

> Expose client X509 certificate identity (TLS client auth) to the auth service 
> delegate
> --
>
> Key: DISPATCH-1634
> URL: https://issues.apache.org/jira/browse/DISPATCH-1634
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Keith Wall
>Priority: Major
>
> For the use-case where Dispatch Router is configured to require the client 
> use TLS client auth (authenticatePeer: yes) and the authServicePlugin is in 
> use, there needs to be a mechanism to expose the X509 certificate identity of 
> the client to the auth service so it can be used to control the`address-authz 
> response. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-1634) Expose client X509 certificate identity (TLS client auth) to the auth service delegate

[Keith Wall (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095275#comment-17095275
 ] 

Keith Wall commented on DISPATCH-1634:
--

In the case where the SASL EXTERNAL mechanism is selected by the client, the 
router's authplugin SASL relay should be able to prepare to rewrite the 
authorization identity within response of the SASL-INIT (or SASL-RESPONSE) and 
insert the identity from the client cert..

The SASL EXTERNAL specification[1] allows the for the authorization identity to 
be empty (the client is requesting to act as the identity the server has 
associated with the client's credentials) or non empty (the client is 
requesting to act as the identity represented by the string).  In the latter 
case, if the identity provided by the authorization string doesn't match the  
identity from the client cert, as the router has no means to verify that user 
is entitled to impersonate that user, it should end the SASL negotiation 
negatively.

[1] https://tools.ietf.org/html/rfc4422#page-29






If the authenticated identity that the client supplies is identical to the one 
we would form from the client cert, then there is no need to reject... but 
otherwise (absent any other form of verification/validation) it's a way of 
trying to impersonate and potentially a security hole

> Expose client X509 certificate identity (TLS client auth) to the auth service 
> delegate
> --
>
> Key: DISPATCH-1634
> URL: https://issues.apache.org/jira/browse/DISPATCH-1634
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Keith Wall
>Priority: Major
>
> For the use-case where Dispatch Router is configured to require the client 
> use TLS client auth (authenticatePeer: yes) and the authServicePlugin is in 
> use, there needs to be a mechanism to expose the X509 certificate identity of 
> the client to the auth service so it can be used to control the`address-authz 
> response. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-1634) Expose client X509 certificate identity (TLS client auth) to the auth service delegate

[Keith Wall (Jira)]

Keith Wall created DISPATCH-1634:


 Summary: Expose client X509 certificate identity (TLS client auth) 
to the auth service delegate
 Key: DISPATCH-1634
 URL: https://issues.apache.org/jira/browse/DISPATCH-1634
 Project: Qpid Dispatch
  Issue Type: Improvement
Reporter: Keith Wall


For the use-case where Dispatch Router is configured to require the client use 
TLS client auth (authenticatePeer: yes) and the authServicePlugin is in use, 
there needs to be a mechanism to expose the X509 certificate identity of the 
client to the auth service so it can be used to control the`address-authz 
response. 






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org