[jira] [Resolved] (PROTON-2413) Python binding example runner can't run python examples
[
https://issues.apache.org/jira/browse/PROTON-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher resolved PROTON-2413.
-
Fix Version/s: proton-c-0.36.0
Resolution: Fixed
> Python binding example runner can't run python examples
> ---
>
> Key: PROTON-2413
> URL: https://issues.apache.org/jira/browse/PROTON-2413
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Affects Versions: proton-c-0.35.0
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
> Fix For: proton-c-0.36.0
>
>
> The python examples test runner {{test_examples.py}} relies on the
> environment path to find and run the python examples that are in the same
> directory as it is.
> It would be much better if it just added the current directory to the path to
> run them itself. This avoids sensitivity on the build/test environment.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2413) Python binding example runner can't run python examples
[
https://issues.apache.org/jira/browse/PROTON-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394323#comment-17394323
]
ASF subversion and git services commented on PROTON-2413:
-
Commit 052cf288e00f0220542e365dcaedd890420deb3d in qpid-proton's branch
refs/heads/main from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=052cf28 ]
PROTON-2413: [Python] set PATH in example test runner
Previously the test runner assumed it could find the examples on the
path. This meant that the environment running the examples would have to
set up the path correctly. This is unnecessary as they are all in the
same directory as the test runner itself.
> Python binding example runner can't run python examples
> ---
>
> Key: PROTON-2413
> URL: https://issues.apache.org/jira/browse/PROTON-2413
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Affects Versions: proton-c-0.35.0
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
>
> The python examples test runner {{test_examples.py}} relies on the
> environment path to find and run the python examples that are in the same
> directory as it is.
> It would be much better if it just added the current directory to the path to
> run them itself. This avoids sensitivity on the build/test environment.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2413) Python binding example runner can't run python examples
Andrew Stitcher created PROTON-2413:
---
Summary: Python binding example runner can't run python examples
Key: PROTON-2413
URL: https://issues.apache.org/jira/browse/PROTON-2413
Project: Qpid Proton
Issue Type: Bug
Components: python-binding
Affects Versions: proton-c-0.35.0
Reporter: Andrew Stitcher
Assignee: Andrew Stitcher
The python examples test runner {{test_examples.py}} relies on the environment
path to find and run the python examples that are in the same directory as it
is.
It would be much better if it just added the current directory to the path to
run them itself. This avoids sensitivity on the build/test environment.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2407) [proton-python] add type annotations
[ https://issues.apache.org/jira/browse/PROTON-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394269#comment-17394269 ] ASF GitHub Bot commented on PROTON-2407: jiridanek merged pull request #326: URL: https://github.com/apache/qpid-proton/pull/326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [proton-python] add type annotations > > > Key: PROTON-2407 > URL: https://issues.apache.org/jira/browse/PROTON-2407 > Project: Qpid Proton > Issue Type: New Feature > Components: python-binding >Affects Versions: proton-c-0.35.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2407) [proton-python] add type annotations
[ https://issues.apache.org/jira/browse/PROTON-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394268#comment-17394268 ] ASF subversion and git services commented on PROTON-2407: - Commit 38e176816c18de1b7490ec449fb71893e1287304 in qpid-proton's branch refs/heads/main from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=38e1768 ] PROTON-2407 Introduce more optional typing annotations to Python binding (#326) > [proton-python] add type annotations > > > Key: PROTON-2407 > URL: https://issues.apache.org/jira/browse/PROTON-2407 > Project: Qpid Proton > Issue Type: New Feature > Components: python-binding >Affects Versions: proton-c-0.35.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jiridanek merged pull request #326: PROTON-2407 Introduce more optional typing annotations to Python binding
jiridanek merged pull request #326: URL: https://github.com/apache/qpid-proton/pull/326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPIDJMS-546) update Mockito to 3.11.2
[ https://issues.apache.org/jira/browse/QPIDJMS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPIDJMS-546: --- Priority: Minor (was: Major) > update Mockito to 3.11.2 > > > Key: QPIDJMS-546 > URL: https://issues.apache.org/jira/browse/QPIDJMS-546 > Project: Qpid JMS > Issue Type: Test >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 1.2.0 > > > update Mockito to 3.11.2 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPIDJMS-546) update Mockito to 3.11.2
[ https://issues.apache.org/jira/browse/QPIDJMS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPIDJMS-546. Resolution: Fixed > update Mockito to 3.11.2 > > > Key: QPIDJMS-546 > URL: https://issues.apache.org/jira/browse/QPIDJMS-546 > Project: Qpid JMS > Issue Type: Test >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 1.2.0 > > > update Mockito to 3.11.2 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-546) update Mockito to 3.11.2
[ https://issues.apache.org/jira/browse/QPIDJMS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394125#comment-17394125 ] ASF subversion and git services commented on QPIDJMS-546: - Commit a4b9d3c28962825822ea89819c34b5239c0aaaf3 in qpid-jms's branch refs/heads/main from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-jms.git;h=a4b9d3c ] QPIDJMS-546: update Mockito to 3.11.2 > update Mockito to 3.11.2 > > > Key: QPIDJMS-546 > URL: https://issues.apache.org/jira/browse/QPIDJMS-546 > Project: Qpid JMS > Issue Type: Test >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 1.2.0 > > > update Mockito to 3.11.2 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8557) [Broker-J] Batching mode for CoalescingCommitter
[
https://issues.apache.org/jira/browse/QPID-8557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394084#comment-17394084
]
ASF GitHub Bot commented on QPID-8557:
--
dakirily opened a new pull request #105:
URL: https://github.com/apache/qpid-broker-j/pull/105
The purpose of this PR is addition of batching mode to the
CoalescingCommitter allowing BDB log flush in configurable chunks and
increasing performance (see
[QPID-8557](https://issues.apache.org/jira/browse/QPID-8557)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Broker-J] Batching mode for CoalescingCommitter
>
>
> Key: QPID-8557
> URL: https://issues.apache.org/jira/browse/QPID-8557
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Affects Versions: qpid-java-broker-8.0.5
>Reporter: Daniil Kirilyuk
>Priority: Minor
>
> Although QPID-8547 introduced configurable parameters for
> CoalescingCommitter, BDB log is flushed to disc on every message. That is
> caused by calling future.get() inside of
> org.apache.qpid.server.txn.AsyncCommand.complete(). Such call forces broker
> to wait until CoalescingCommiter calls #CommitThread#processJobs() making the
> operation effectively sync instead of async (every message triggers
> processJobs() and data flush).
> To improve overall performance we suggest to add batching mode for
> CoalescingCommitter, which would consider BDBVirtualHost parameters and flush
> data in chunks of size ${qpid.broker.bdbCommiterNotifyThreshold} or every
> ${qpid.broker.bdbCommiterWaitTimeout} ms (whatever comes first).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] dakirily opened a new pull request #105: QPID-8557 - [Broker-J] Batching mode for CoalescingCommitter
dakirily opened a new pull request #105: URL: https://github.com/apache/qpid-broker-j/pull/105 The purpose of this PR is addition of batching mode to the CoalescingCommitter allowing BDB log flush in configurable chunks and increasing performance (see [QPID-8557](https://issues.apache.org/jira/browse/QPID-8557)). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPIDJMS-546) update Mockito to 3.11.2
Robbie Gemmell created QPIDJMS-546: -- Summary: update Mockito to 3.11.2 Key: QPIDJMS-546 URL: https://issues.apache.org/jira/browse/QPIDJMS-546 Project: Qpid JMS Issue Type: Test Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: 1.2.0 update Mockito to 3.11.2 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8557) [Broker-J] Batching mode for CoalescingCommitter
Daniil Kirilyuk created QPID-8557:
-
Summary: [Broker-J] Batching mode for CoalescingCommitter
Key: QPID-8557
URL: https://issues.apache.org/jira/browse/QPID-8557
Project: Qpid
Issue Type: Improvement
Components: Broker-J
Affects Versions: qpid-java-broker-8.0.5
Reporter: Daniil Kirilyuk
Although QPID-8547 introduced configurable parameters for CoalescingCommitter,
BDB log is flushed to disc on every message. That is caused by calling
future.get() inside of org.apache.qpid.server.txn.AsyncCommand.complete(). Such
call forces broker to wait until CoalescingCommiter calls
#CommitThread#processJobs() making the operation effectively sync instead of
async (every message triggers processJobs() and data flush).
To improve overall performance we suggest to add batching mode for
CoalescingCommitter, which would consider BDBVirtualHost parameters and flush
data in chunks of size ${qpid.broker.bdbCommiterNotifyThreshold} or every
${qpid.broker.bdbCommiterWaitTimeout} ms (whatever comes first).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2411) Simultaneous idle timeout sequencing errors
[ https://issues.apache.org/jira/browse/PROTON-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393892#comment-17393892 ] ASF GitHub Bot commented on PROTON-2411: gemmellr commented on pull request #327: URL: https://github.com/apache/qpid-proton/pull/327#issuecomment-892682441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Simultaneous idle timeout sequencing errors > --- > > Key: PROTON-2411 > URL: https://issues.apache.org/jira/browse/PROTON-2411 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.34.0 >Reporter: Jaap Wiggelinkhuizen >Priority: Critical > Attachments: p2411_0.diff > > > In our mission critical software we use Qpid proton 0.34.0 in our C++-client > software together with the Qpid dispatch router 1.16.0. We updated to these > versions not so long ago, before we used proton 0.25.0 and dispatch 1.3.0. > Our application runs on several VM’s with a router on each VM. All clients > connect to the local router only and the routers connect to eachother in a > hub spoke pattern. In both the client configuration as the router > configuration we have configured an idle timeout of 30 seconds. > On July 4th we were confronted with an incident in production where a lot of > our client processes reported problems regarding the idle timeouts. These > client processes were already running stable for more than 3 weeks. The > problem appeared in two flavors: > # Transport error “error: amqp:resource-limit-exceeded: local-idle-timeout > expired” > # epoll proactor failure in epoll_timer.c:263: “idle timeout sequencing > error” > On each VM at least 3 processes showed one of these problems in a total time > window of less than a minute. We haven’t found any cause in the underlying > hardware, hypervisor, network or operating system until now. > Although we don’t know the root cause of the problems, we can solve the first > situation by using the proper reconnect settings (by mistake we handled > on_transport_error() as a fatal situation and will correct that so that only > on_transport_close() will be handled as fatal). However the second situation > is more odd because it results in an abort within proton itself. The comments > in epoll_timer.c explain that this error occurs when a connection timer is > moved backwards a second time. We don’t understand how this can happen > suddenly. > > Last sunday the problem occurred again on two more production sites where our > software was operational just over 3 weeks now. And again it has happened on > all VM's within a short timeframe. It's interesting that it only occurs on > sunday mornings until now. Maybe it has something to do with how long the > software is running and the fact that on sunday mornings there is less > messaging traffic, i.e. more heartbeats?... > > Unfortunately we haven't been able to reproduce the issue at our test > facilities and hence can not provide a reproducer. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8553) [Broker-J] HP Fortify: Weak SecurityManager Check: Overridable Method
[ https://issues.apache.org/jira/browse/QPID-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393890#comment-17393890 ] ASF GitHub Bot commented on QPID-8553: -- asfgit closed pull request #104: URL: https://github.com/apache/qpid-broker-j/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Broker-J] HP Fortify: Weak SecurityManager Check: Overridable Method > - > > Key: QPID-8553 > URL: https://issues.apache.org/jira/browse/QPID-8553 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-8.0.5 >Reporter: Daniil Kirilyuk >Priority: Minor > Fix For: qpid-java-broker-9.0.0 > > > HP Fortify complains that classes defining security may be overridden by > sub-classes and thereby by-passing the security features: > broker-plugins/access-control/src/main/org/apache/qpid/server/security/access/config/RuleBasedAccessControl.java > Line 58 newToken() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Line 75 authorise() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > broker-core/src/main/java/org/apache/qpid/server/model/BrokerImpl.java > Line 1022 getConnectionMetaData() - Non-final methods that perform security > checks may be overridden in ways that bypass security checks. > Line 1046 getGroups() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > broker-plugins/management-http/src/main/org/apache/qpid/server/management/plugin/servlet/rest/SaslServlet.java > Line 79 doGet() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > broker-plugins/amqp-0-8-protocol/org/apache/qpid/server/protocol/v0_8/AMQPConnection_0_8Impl.java > Line 699 readerIdle() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Executes privileged action. > broker-plugins/logging-logback/src/main/org/apache/qpid/server/logging/logback/ConnectionAndUserPredicate.java > Line 43 evaluate() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > broker-plugins/amqp-1-0-protocol/src/main/org/apache/qpid/server/protocol/v1_0/AMQPConnection_1_0Impl.java > Line 444 receive() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Line 1269 readerIdle() - Non-final methods that perform security checks may > be overridden in ways that bypass security checks. > Line 1340 receivedComplete() - Non-final methods that perform security checks > may be overridden in ways that bypass security checks. > broker-plugins/amqp-0-8-protocol/src/main/org/apache/qpid/server/protocol/v0_8/BrokerDecoder.java > Line 78 processAMQPFrames() - Non-final methods that perform security checks > may be overridden in ways that bypass security checks. > Executes privileged action. > broker-core/src/main/java/org/apache/qpid/server/security/CompoundAccessControl.java > Line 68 newToken() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/ServerAssembler.java > Line 72 received() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Executes privileged action. > broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/AMQPConnection_0_10Impl.java > Line 165 readerIdle() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Line 182 closed() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Executes privileged action. > broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ProxyMessageSource.java > Line 152 addConsumer() - Non-final methods that perform security checks may > be overridden in ways that bypass security checks. > broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementAddressSpace.java > Line 172 getProxyNode() - Non-final methods that perform security checks may > be overridden in ways that bypass security checks. >
[GitHub] [qpid-proton] gemmellr commented on pull request #327: PROTON-2411: Fix integer overflow in pn_proactor_now_64 while compiling 32-bits
gemmellr commented on pull request #327: URL: https://github.com/apache/qpid-proton/pull/327#issuecomment-892682441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] asfgit closed pull request #104: QPID-8553 - [Broker-J] HP Fortify: Weak SecurityManager Check: Overridable Method
asfgit closed pull request #104: URL: https://github.com/apache/qpid-broker-j/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2411) Simultaneous idle timeout sequencing errors
[ https://issues.apache.org/jira/browse/PROTON-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393879#comment-17393879 ] ASF GitHub Bot commented on PROTON-2411: astitcher merged pull request #327: URL: https://github.com/apache/qpid-proton/pull/327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Simultaneous idle timeout sequencing errors > --- > > Key: PROTON-2411 > URL: https://issues.apache.org/jira/browse/PROTON-2411 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.34.0 >Reporter: Jaap Wiggelinkhuizen >Priority: Critical > Attachments: p2411_0.diff > > > In our mission critical software we use Qpid proton 0.34.0 in our C++-client > software together with the Qpid dispatch router 1.16.0. We updated to these > versions not so long ago, before we used proton 0.25.0 and dispatch 1.3.0. > Our application runs on several VM’s with a router on each VM. All clients > connect to the local router only and the routers connect to eachother in a > hub spoke pattern. In both the client configuration as the router > configuration we have configured an idle timeout of 30 seconds. > On July 4th we were confronted with an incident in production where a lot of > our client processes reported problems regarding the idle timeouts. These > client processes were already running stable for more than 3 weeks. The > problem appeared in two flavors: > # Transport error “error: amqp:resource-limit-exceeded: local-idle-timeout > expired” > # epoll proactor failure in epoll_timer.c:263: “idle timeout sequencing > error” > On each VM at least 3 processes showed one of these problems in a total time > window of less than a minute. We haven’t found any cause in the underlying > hardware, hypervisor, network or operating system until now. > Although we don’t know the root cause of the problems, we can solve the first > situation by using the proper reconnect settings (by mistake we handled > on_transport_error() as a fatal situation and will correct that so that only > on_transport_close() will be handled as fatal). However the second situation > is more odd because it results in an abort within proton itself. The comments > in epoll_timer.c explain that this error occurs when a connection timer is > moved backwards a second time. We don’t understand how this can happen > suddenly. > > Last sunday the problem occurred again on two more production sites where our > software was operational just over 3 weeks now. And again it has happened on > all VM's within a short timeframe. It's interesting that it only occurs on > sunday mornings until now. Maybe it has something to do with how long the > software is running and the fact that on sunday mornings there is less > messaging traffic, i.e. more heartbeats?... > > Unfortunately we haven't been able to reproduce the issue at our test > facilities and hence can not provide a reproducer. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher merged pull request #327: PROTON-2411: Fix integer overflow in pn_proactor_now_64 while compiling 32-bits
astitcher merged pull request #327: URL: https://github.com/apache/qpid-proton/pull/327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2121) Investigate whether there might be benefits from LTO-ing Proton into Dispatch
[ https://issues.apache.org/jira/browse/DISPATCH-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393871#comment-17393871 ] ASF GitHub Bot commented on DISPATCH-2121: -- codecov-commenter commented on pull request #1331: URL: https://github.com/apache/qpid-dispatch/pull/1331#issuecomment-892986340 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1331?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1331](https://codecov.io/gh/apache/qpid-dispatch/pull/1331?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a6a5c72) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/25360c6cf6655e85cfb521e0c475b8a6a12bc592?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (25360c6) will **decrease** coverage by `0.06%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1331?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1331 +/- ## == - Coverage 84.65% 84.59% -0.07% == Files 113 113 Lines 2838328385 +2 == - Hits2402924013 -16 - Misses 4354 4372 +18 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1331?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0.00%> (-4.15%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `84.15% <0.00%> (-1.00%)` | :arrow_down: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.12% <0.00%> (-0.96%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.33% <0.00%> (-0.56%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.18% <0.00%> (-0.44%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.15% <0.00%> (-0.22%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.49% <0.00%> (-0.07%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.16% <0.00%> (ø)` | | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.55% <0.00%> (+0.11%)` | :arrow_up: | |
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1331: DISPATCH-2121 Allow the -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=ON build option without warning
codecov-commenter commented on pull request #1331: URL: https://github.com/apache/qpid-dispatch/pull/1331#issuecomment-892986340 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1331?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1331](https://codecov.io/gh/apache/qpid-dispatch/pull/1331?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a6a5c72) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/25360c6cf6655e85cfb521e0c475b8a6a12bc592?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (25360c6) will **decrease** coverage by `0.06%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1331?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1331 +/- ## == - Coverage 84.65% 84.59% -0.07% == Files 113 113 Lines 2838328385 +2 == - Hits2402924013 -16 - Misses 4354 4372 +18 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1331?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0.00%> (-4.15%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `84.15% <0.00%> (-1.00%)` | :arrow_down: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.12% <0.00%> (-0.96%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.33% <0.00%> (-0.56%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.18% <0.00%> (-0.44%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.15% <0.00%> (-0.22%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.49% <0.00%> (-0.07%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.16% <0.00%> (ø)` | | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.55% <0.00%> (+0.11%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1331/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `88.18% <0.00%> (+0.21%)` | :arrow_up: | | ... and [1
[jira] [Commented] (DISPATCH-2164) test_26_multicast_mobile_address_edge_to_interior failing in system_tests_edge_router
[ https://issues.apache.org/jira/browse/DISPATCH-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393854#comment-17393854 ] ASF GitHub Bot commented on DISPATCH-2164: -- codecov-commenter commented on pull request #1332: URL: https://github.com/apache/qpid-dispatch/pull/1332#issuecomment-893037484 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1332?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1332](https://codecov.io/gh/apache/qpid-dispatch/pull/1332?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (fdee67e) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/182138cfe21b1f0b921590bb9344b18588e1c368?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (182138c) will **increase** coverage by `0.04%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1332?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1332 +/- ## == + Coverage 84.59% 84.64% +0.04% == Files 113 113 Lines 2838528385 == + Hits2401224026 +14 + Misses 4373 4359 -14 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1332?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1332/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==) | `92.03% <0.00%> (-1.28%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1332/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.65% <0.00%> (+0.19%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1332/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `88.18% <0.00%> (+0.21%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1332/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.61% <0.00%> (+0.86%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1332/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.06% <0.00%> (+0.88%)` | :arrow_up: | | [...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1332/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j) | `91.39% <0.00%> (+1.07%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1332?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1332?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [182138c...fdee67e](https://codecov.io/gh/apache/qpid-dispatch/pull/1332?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1332: DISPATCH-2164: Removed timers and subsciber count checks in favor of …
codecov-commenter commented on pull request #1332: URL: https://github.com/apache/qpid-dispatch/pull/1332#issuecomment-893037484 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1332?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1332](https://codecov.io/gh/apache/qpid-dispatch/pull/1332?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (fdee67e) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/182138cfe21b1f0b921590bb9344b18588e1c368?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (182138c) will **increase** coverage by `0.04%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1332?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1332 +/- ## == + Coverage 84.59% 84.64% +0.04% == Files 113 113 Lines 2838528385 == + Hits2401224026 +14 + Misses 4373 4359 -14 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1332?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1332/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==) | `92.03% <0.00%> (-1.28%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1332/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.65% <0.00%> (+0.19%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1332/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `88.18% <0.00%> (+0.21%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1332/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.61% <0.00%> (+0.86%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1332/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.06% <0.00%> (+0.88%)` | :arrow_up: | | [...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1332/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j) | `91.39% <0.00%> (+1.07%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1332?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1332?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [182138c...fdee67e](https://codecov.io/gh/apache/qpid-dispatch/pull/1332?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To
[jira] [Commented] (PROTON-2411) Simultaneous idle timeout sequencing errors
[ https://issues.apache.org/jira/browse/PROTON-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393850#comment-17393850 ] ASF GitHub Bot commented on PROTON-2411: astitcher commented on pull request #327: URL: https://github.com/apache/qpid-proton/pull/327#issuecomment-892687001 Oops, My bad, I saw the PR title and didn't look carefully enough at the commit comment. I didn't know about the squash UI option - It must be newish. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Simultaneous idle timeout sequencing errors > --- > > Key: PROTON-2411 > URL: https://issues.apache.org/jira/browse/PROTON-2411 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.34.0 >Reporter: Jaap Wiggelinkhuizen >Priority: Critical > Attachments: p2411_0.diff > > > In our mission critical software we use Qpid proton 0.34.0 in our C++-client > software together with the Qpid dispatch router 1.16.0. We updated to these > versions not so long ago, before we used proton 0.25.0 and dispatch 1.3.0. > Our application runs on several VM’s with a router on each VM. All clients > connect to the local router only and the routers connect to eachother in a > hub spoke pattern. In both the client configuration as the router > configuration we have configured an idle timeout of 30 seconds. > On July 4th we were confronted with an incident in production where a lot of > our client processes reported problems regarding the idle timeouts. These > client processes were already running stable for more than 3 weeks. The > problem appeared in two flavors: > # Transport error “error: amqp:resource-limit-exceeded: local-idle-timeout > expired” > # epoll proactor failure in epoll_timer.c:263: “idle timeout sequencing > error” > On each VM at least 3 processes showed one of these problems in a total time > window of less than a minute. We haven’t found any cause in the underlying > hardware, hypervisor, network or operating system until now. > Although we don’t know the root cause of the problems, we can solve the first > situation by using the proper reconnect settings (by mistake we handled > on_transport_error() as a fatal situation and will correct that so that only > on_transport_close() will be handled as fatal). However the second situation > is more odd because it results in an abort within proton itself. The comments > in epoll_timer.c explain that this error occurs when a connection timer is > moved backwards a second time. We don’t understand how this can happen > suddenly. > > Last sunday the problem occurred again on two more production sites where our > software was operational just over 3 weeks now. And again it has happened on > all VM's within a short timeframe. It's interesting that it only occurs on > sunday mornings until now. Maybe it has something to do with how long the > software is running and the fact that on sunday mornings there is less > messaging traffic, i.e. more heartbeats?... > > Unfortunately we haven't been able to reproduce the issue at our test > facilities and hence can not provide a reproducer. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on pull request #327: PROTON-2411: Fix integer overflow in pn_proactor_now_64 while compiling 32-bits
astitcher commented on pull request #327: URL: https://github.com/apache/qpid-proton/pull/327#issuecomment-892687001 Oops, My bad, I saw the PR title and didn't look carefully enough at the commit comment. I didn't know about the squash UI option - It must be newish. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2411) Simultaneous idle timeout sequencing errors
[ https://issues.apache.org/jira/browse/PROTON-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393848#comment-17393848 ] ASF GitHub Bot commented on PROTON-2411: jiridanek edited a comment on pull request #327: URL: https://github.com/apache/qpid-proton/pull/327#issuecomment-892695058 (I love it, which is why I did `) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Simultaneous idle timeout sequencing errors > --- > > Key: PROTON-2411 > URL: https://issues.apache.org/jira/browse/PROTON-2411 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.34.0 >Reporter: Jaap Wiggelinkhuizen >Priority: Critical > Attachments: p2411_0.diff > > > In our mission critical software we use Qpid proton 0.34.0 in our C++-client > software together with the Qpid dispatch router 1.16.0. We updated to these > versions not so long ago, before we used proton 0.25.0 and dispatch 1.3.0. > Our application runs on several VM’s with a router on each VM. All clients > connect to the local router only and the routers connect to eachother in a > hub spoke pattern. In both the client configuration as the router > configuration we have configured an idle timeout of 30 seconds. > On July 4th we were confronted with an incident in production where a lot of > our client processes reported problems regarding the idle timeouts. These > client processes were already running stable for more than 3 weeks. The > problem appeared in two flavors: > # Transport error “error: amqp:resource-limit-exceeded: local-idle-timeout > expired” > # epoll proactor failure in epoll_timer.c:263: “idle timeout sequencing > error” > On each VM at least 3 processes showed one of these problems in a total time > window of less than a minute. We haven’t found any cause in the underlying > hardware, hypervisor, network or operating system until now. > Although we don’t know the root cause of the problems, we can solve the first > situation by using the proper reconnect settings (by mistake we handled > on_transport_error() as a fatal situation and will correct that so that only > on_transport_close() will be handled as fatal). However the second situation > is more odd because it results in an abort within proton itself. The comments > in epoll_timer.c explain that this error occurs when a connection timer is > moved backwards a second time. We don’t understand how this can happen > suddenly. > > Last sunday the problem occurred again on two more production sites where our > software was operational just over 3 weeks now. And again it has happened on > all VM's within a short timeframe. It's interesting that it only occurs on > sunday mornings until now. Maybe it has something to do with how long the > software is running and the fact that on sunday mornings there is less > messaging traffic, i.e. more heartbeats?... > > Unfortunately we haven't been able to reproduce the issue at our test > facilities and hence can not provide a reproducer. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jiridanek edited a comment on pull request #327: PROTON-2411: Fix integer overflow in pn_proactor_now_64 while compiling 32-bits
jiridanek edited a comment on pull request #327: URL: https://github.com/apache/qpid-proton/pull/327#issuecomment-892695058 (I love it, which is why I did `) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8550) [Broker-J] HP Fortify: Unreleased streams
[
https://issues.apache.org/jira/browse/QPID-8550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393845#comment-17393845
]
ASF GitHub Bot commented on QPID-8550:
--
alex-rufous commented on a change in pull request #103:
URL: https://github.com/apache/qpid-broker-j/pull/103#discussion_r683282742
##
File path:
broker-core/src/main/java/org/apache/qpid/server/store/JsonFileConfigStore.java
##
@@ -156,49 +156,52 @@ protected boolean load(final ConfiguredObjectRecord...
initialRecords)
boolean updated = false;
Collection records =
Collections.emptyList();
-ConfiguredObjectRecordConverter configuredObjectRecordConverter =
+final ConfiguredObjectRecordConverter
configuredObjectRecordConverter =
new ConfiguredObjectRecordConverter(_parent.getModel());
-records = configuredObjectRecordConverter.readFromJson(_rootClass,
_parent, new FileReader(configFile));
-
-if(_rootClass == null)
+try (FileReader configFileReader = new FileReader(configFile))
Review comment:
This change is unnecessary. The `configFileReader` is closed in
`ObjectMapper`. If you really need to make sure that `configFileReader` is
closed in the code where it is created, you can simply add `try-with-resource`
block around the code reading from json
```
try (FileReader configFileReader = new FileReader(configFile))
{
records = configuredObjectRecordConverter.readFromJson(_rootClass,
_parent, configFileReader);
}
```
##
File path:
broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/RestServlet.java
##
@@ -437,7 +437,10 @@ public String getRequestURL()
{
if ("data".equals(part.getName()) &&
"application/json".equals(part.getContentType()))
{
-items = mapper.readValue(part.getInputStream(),
LinkedHashMap.class);
+try (InputStream inputStream = part.getInputStream())
Review comment:
The change is unnecessary as methods `ObjectMapper#readValue ` close the
input stream/reader..
##
File path:
perftests/src/main/java/org/apache/qpid/disttest/controller/config/ConfigReader.java
##
@@ -37,10 +37,10 @@
public Config getConfigFromFile(String fileName) throws IOException
{
-Reader reader = getConfigReader(fileName);
-
-Config config = readConfig(reader);
-return config;
+try (Reader reader = getConfigReader(fileName))
Review comment:
The reader is closed in `ObjectMapper#read...`. Thus, the change is
unnecessary...
##
File path: broker-core/src/main/java/org/apache/qpid/server/util/FileUtils.java
##
@@ -205,8 +205,10 @@ public static void copy(File src, File dst)
*/
public static void copyCheckedEx(File src, File dst) throws IOException
{
-InputStream in = new FileInputStream(src);
-copy(in, dst);
+try (InputStream in = new FileInputStream(src))
Review comment:
The `InputStream` is closed in `copy`. Arguably the method `copy` should
indicate that it closes the input stream. It make more sense to rename it into
`copyInputStreamIntoFileAndClose`. Though, I suppose for a better code
relaibility the 'try-with-resource` would be good here.
##
File path:
broker-core/src/main/java/org/apache/qpid/server/virtualhostnode/AbstractVirtualHostNode.java
##
@@ -430,40 +430,42 @@ public PreferenceStore createPreferenceStore()
protected final ConfiguredObjectRecord[] getInitialRecords() throws
IOException
{
-ConfiguredObjectRecordConverter converter = new
ConfiguredObjectRecordConverter(getModel());
+final ConfiguredObjectRecordConverter converter = new
ConfiguredObjectRecordConverter(getModel());
-Collection records =
-new
ArrayList<>(converter.readFromJson(VirtualHost.class,this,getInitialConfigReader()));
-
-if(!records.isEmpty())
+try (final Reader initialConfigReader = getInitialConfigReader())
Review comment:
Try-with-resource block is unnecessary here as reading code is closing
the reader. If you really have to change to `try-with-resource`, it would be
preferable to keep the `try` block small and only use it for reading the
records. IMHO, that makes code more readable
```
final Collection records;
try (final Reader initialConfigReader = getInitialConfigReader())
{
records = new ArrayList<>(converter.readFromJson(VirtualHost.class,
this, initialConfigReader));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[jira] [Commented] (PROTON-2411) Simultaneous idle timeout sequencing errors
[ https://issues.apache.org/jira/browse/PROTON-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393843#comment-17393843 ] ASF GitHub Bot commented on PROTON-2411: jiridanek commented on pull request #327: URL: https://github.com/apache/qpid-proton/pull/327#issuecomment-892683614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Simultaneous idle timeout sequencing errors > --- > > Key: PROTON-2411 > URL: https://issues.apache.org/jira/browse/PROTON-2411 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.34.0 >Reporter: Jaap Wiggelinkhuizen >Priority: Critical > Attachments: p2411_0.diff > > > In our mission critical software we use Qpid proton 0.34.0 in our C++-client > software together with the Qpid dispatch router 1.16.0. We updated to these > versions not so long ago, before we used proton 0.25.0 and dispatch 1.3.0. > Our application runs on several VM’s with a router on each VM. All clients > connect to the local router only and the routers connect to eachother in a > hub spoke pattern. In both the client configuration as the router > configuration we have configured an idle timeout of 30 seconds. > On July 4th we were confronted with an incident in production where a lot of > our client processes reported problems regarding the idle timeouts. These > client processes were already running stable for more than 3 weeks. The > problem appeared in two flavors: > # Transport error “error: amqp:resource-limit-exceeded: local-idle-timeout > expired” > # epoll proactor failure in epoll_timer.c:263: “idle timeout sequencing > error” > On each VM at least 3 processes showed one of these problems in a total time > window of less than a minute. We haven’t found any cause in the underlying > hardware, hypervisor, network or operating system until now. > Although we don’t know the root cause of the problems, we can solve the first > situation by using the proper reconnect settings (by mistake we handled > on_transport_error() as a fatal situation and will correct that so that only > on_transport_close() will be handled as fatal). However the second situation > is more odd because it results in an abort within proton itself. The comments > in epoll_timer.c explain that this error occurs when a connection timer is > moved backwards a second time. We don’t understand how this can happen > suddenly. > > Last sunday the problem occurred again on two more production sites where our > software was operational just over 3 weeks now. And again it has happened on > all VM's within a short timeframe. It's interesting that it only occurs on > sunday mornings until now. Maybe it has something to do with how long the > software is running and the fact that on sunday mornings there is less > messaging traffic, i.e. more heartbeats?... > > Unfortunately we haven't been able to reproduce the issue at our test > facilities and hence can not provide a reproducer. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] alex-rufous commented on a change in pull request #103: QPID-8550 - [Broker-J] HP Fortify: Unreleased streams
alex-rufous commented on a change in pull request #103:
URL: https://github.com/apache/qpid-broker-j/pull/103#discussion_r683282742
##
File path:
broker-core/src/main/java/org/apache/qpid/server/store/JsonFileConfigStore.java
##
@@ -156,49 +156,52 @@ protected boolean load(final ConfiguredObjectRecord...
initialRecords)
boolean updated = false;
Collection records =
Collections.emptyList();
-ConfiguredObjectRecordConverter configuredObjectRecordConverter =
+final ConfiguredObjectRecordConverter
configuredObjectRecordConverter =
new ConfiguredObjectRecordConverter(_parent.getModel());
-records = configuredObjectRecordConverter.readFromJson(_rootClass,
_parent, new FileReader(configFile));
-
-if(_rootClass == null)
+try (FileReader configFileReader = new FileReader(configFile))
Review comment:
This change is unnecessary. The `configFileReader` is closed in
`ObjectMapper`. If you really need to make sure that `configFileReader` is
closed in the code where it is created, you can simply add `try-with-resource`
block around the code reading from json
```
try (FileReader configFileReader = new FileReader(configFile))
{
records = configuredObjectRecordConverter.readFromJson(_rootClass,
_parent, configFileReader);
}
```
##
File path:
broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/RestServlet.java
##
@@ -437,7 +437,10 @@ public String getRequestURL()
{
if ("data".equals(part.getName()) &&
"application/json".equals(part.getContentType()))
{
-items = mapper.readValue(part.getInputStream(),
LinkedHashMap.class);
+try (InputStream inputStream = part.getInputStream())
Review comment:
The change is unnecessary as methods `ObjectMapper#readValue ` close the
input stream/reader..
##
File path:
perftests/src/main/java/org/apache/qpid/disttest/controller/config/ConfigReader.java
##
@@ -37,10 +37,10 @@
public Config getConfigFromFile(String fileName) throws IOException
{
-Reader reader = getConfigReader(fileName);
-
-Config config = readConfig(reader);
-return config;
+try (Reader reader = getConfigReader(fileName))
Review comment:
The reader is closed in `ObjectMapper#read...`. Thus, the change is
unnecessary...
##
File path: broker-core/src/main/java/org/apache/qpid/server/util/FileUtils.java
##
@@ -205,8 +205,10 @@ public static void copy(File src, File dst)
*/
public static void copyCheckedEx(File src, File dst) throws IOException
{
-InputStream in = new FileInputStream(src);
-copy(in, dst);
+try (InputStream in = new FileInputStream(src))
Review comment:
The `InputStream` is closed in `copy`. Arguably the method `copy` should
indicate that it closes the input stream. It make more sense to rename it into
`copyInputStreamIntoFileAndClose`. Though, I suppose for a better code
relaibility the 'try-with-resource` would be good here.
##
File path:
broker-core/src/main/java/org/apache/qpid/server/virtualhostnode/AbstractVirtualHostNode.java
##
@@ -430,40 +430,42 @@ public PreferenceStore createPreferenceStore()
protected final ConfiguredObjectRecord[] getInitialRecords() throws
IOException
{
-ConfiguredObjectRecordConverter converter = new
ConfiguredObjectRecordConverter(getModel());
+final ConfiguredObjectRecordConverter converter = new
ConfiguredObjectRecordConverter(getModel());
-Collection records =
-new
ArrayList<>(converter.readFromJson(VirtualHost.class,this,getInitialConfigReader()));
-
-if(!records.isEmpty())
+try (final Reader initialConfigReader = getInitialConfigReader())
Review comment:
Try-with-resource block is unnecessary here as reading code is closing
the reader. If you really have to change to `try-with-resource`, it would be
preferable to keep the `try` block small and only use it for reading the
records. IMHO, that makes code more readable
```
final Collection records;
try (final Reader initialConfigReader = getInitialConfigReader())
{
records = new ArrayList<>(converter.readFromJson(VirtualHost.class,
this, initialConfigReader));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For
[GitHub] [qpid-proton] jiridanek commented on pull request #327: PROTON-2411: Fix integer overflow in pn_proactor_now_64 while compiling 32-bits
jiridanek commented on pull request #327: URL: https://github.com/apache/qpid-proton/pull/327#issuecomment-892683614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2164) test_26_multicast_mobile_address_edge_to_interior failing in system_tests_edge_router
[
https://issues.apache.org/jira/browse/DISPATCH-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393837#comment-17393837
]
ASF GitHub Bot commented on DISPATCH-2164:
--
ganeshmurthy opened a new pull request #1332:
URL: https://github.com/apache/qpid-dispatch/pull/1332
…sending test messages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> test_26_multicast_mobile_address_edge_to_interior failing in
> system_tests_edge_router
> -
>
> Key: DISPATCH-2164
> URL: https://issues.apache.org/jira/browse/DISPATCH-2164
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Affects Versions: 1.16.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Attachments: DISPATCH-2164-multicast.25-analysis.txt
>
>
> {noformat}
> 55:
> 55:
> 55: ==
> 55: FAIL: test_26_multicast_mobile_address_edge_to_interior
> (system_tests_edge_router.RouterTest)
> 55: --
> 55: Traceback (most recent call last):
> 55: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_edge_router.py",
> line 663, in test_26_multicast_mobile_address_edge_to_interior
> 55: self.assertIsNone(test.error)
> 55: AssertionError: 'Timeout Expired - n_sent=100 n_rcvd1=100, n_rcvd2=99,
> n_rcvd3=99, n_released=0, addr=multicast.26' is not None
> 55:
> 55: --
> 55: Ran 89 tests in 545.208s
> 55:
> 55: FAILED (failures=1)
> 55/72 Test #55: system_tests_edge_router ..***Failed
> 545.35 sec {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2222) Avoid cpu-intensive message string-ify of every received AMQP message
[ https://issues.apache.org/jira/browse/DISPATCH-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393825#comment-17393825 ] ASF GitHub Bot commented on DISPATCH-: -- asfgit closed pull request #1330: URL: https://github.com/apache/qpid-dispatch/pull/1330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Avoid cpu-intensive message string-ify of every received AMQP message > - > > Key: DISPATCH- > URL: https://issues.apache.org/jira/browse/DISPATCH- > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.17.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.18.0 > > > A call to log_link_message() is made for every received AMQP message. This > function logs a string-ified version of the message at level QD_LOG_TRACE. > > log_link_message() parses out each message and summarizes it into a string > buffer before logging. This stringify operation is cpu-intensive. According > to flamegraphs it occupies 5% of the compute budget. > > The string-ify operation should be avoided if the message log level doe not > have TRACE enabled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #1330: DISPATCH-2222: avoid per-message logging overhead when not tracing
asfgit closed pull request #1330: URL: https://github.com/apache/qpid-dispatch/pull/1330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2223) Incorporate pythoncapi_compat.h to keep up with CPython development
[ https://issues.apache.org/jira/browse/DISPATCH-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393822#comment-17393822 ] ASF GitHub Bot commented on DISPATCH-2223: -- codecov-commenter commented on pull request #1333: URL: https://github.com/apache/qpid-dispatch/pull/1333#issuecomment-893043451 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1333](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (af64b43) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/25360c6cf6655e85cfb521e0c475b8a6a12bc592?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (25360c6) will **increase** coverage by `0.00%`. > The diff coverage is `90.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main#1333 +/- ## === Coverage 84.65% 84.66% === Files 113 114+1 Lines 2838328394 +11 === + Hits2402924041 +12 + Misses 4354 4353-1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/pythoncapi\_compat.h](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbmNhcGlfY29tcGF0Lmg=) | `86.66% <86.66%> (ø)` | | | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `68.43% <100.00%> (-0.26%)` | :arrow_down: | | [src/router\_pynode.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9weW5vZGUuYw==) | `87.85% <100.00%> (-0.12%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.18% <0.00%> (-0.44%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.49% <0.00%> (-0.07%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.55% <0.00%> (+0.11%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.46% <0.00%> (+0.29%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.04% <0.00%> (+0.39%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1333: DISPATCH-2223 Incorporate pythoncapi_compat.h to keep up with CPython development
codecov-commenter commented on pull request #1333: URL: https://github.com/apache/qpid-dispatch/pull/1333#issuecomment-893043451 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1333](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (af64b43) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/25360c6cf6655e85cfb521e0c475b8a6a12bc592?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (25360c6) will **increase** coverage by `0.00%`. > The diff coverage is `90.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main#1333 +/- ## === Coverage 84.65% 84.66% === Files 113 114+1 Lines 2838328394 +11 === + Hits2402924041 +12 + Misses 4354 4353-1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/pythoncapi\_compat.h](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbmNhcGlfY29tcGF0Lmg=) | `86.66% <86.66%> (ø)` | | | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `68.43% <100.00%> (-0.26%)` | :arrow_down: | | [src/router\_pynode.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9weW5vZGUuYw==) | `87.85% <100.00%> (-0.12%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.18% <0.00%> (-0.44%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.49% <0.00%> (-0.07%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.55% <0.00%> (+0.11%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `90.46% <0.00%> (+0.29%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1333/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.04% <0.00%> (+0.39%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1333?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update
[jira] [Commented] (DISPATCH-2121) Investigate whether there might be benefits from LTO-ing Proton into Dispatch
[ https://issues.apache.org/jira/browse/DISPATCH-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393809#comment-17393809 ] ASF GitHub Bot commented on DISPATCH-2121: -- jiridanek opened a new pull request #1331: URL: https://github.com/apache/qpid-dispatch/pull/1331 ``` CMake Warning (dev) at router/CMakeLists.txt:35 (add_executable): Policy CMP0069 is not set: INTERPROCEDURAL_OPTIMIZATION is enforced when enabled. Run "cmake --help-policy CMP0069" for policy details. Use the cmake_policy command to set the policy and suppress this warning. INTERPROCEDURAL_OPTIMIZATION property will be ignored for target 'qdrouterd'. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Investigate whether there might be benefits from LTO-ing Proton into Dispatch > - > > Key: DISPATCH-2121 > URL: https://issues.apache.org/jira/browse/DISPATCH-2121 > Project: Qpid Dispatch > Issue Type: Task >Affects Versions: 1.16.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: 1.17.0 > > > https://stackoverflow.com/questions/25878407/how-can-i-use-lto-with-static-libraries -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8553) [Broker-J] HP Fortify: Weak SecurityManager Check: Overridable Method
[ https://issues.apache.org/jira/browse/QPID-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393802#comment-17393802 ] ASF GitHub Bot commented on QPID-8553: -- asfgit closed pull request #104: URL: https://github.com/apache/qpid-broker-j/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Broker-J] HP Fortify: Weak SecurityManager Check: Overridable Method > - > > Key: QPID-8553 > URL: https://issues.apache.org/jira/browse/QPID-8553 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-8.0.5 >Reporter: Daniil Kirilyuk >Priority: Minor > Fix For: qpid-java-broker-9.0.0 > > > HP Fortify complains that classes defining security may be overridden by > sub-classes and thereby by-passing the security features: > broker-plugins/access-control/src/main/org/apache/qpid/server/security/access/config/RuleBasedAccessControl.java > Line 58 newToken() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Line 75 authorise() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > broker-core/src/main/java/org/apache/qpid/server/model/BrokerImpl.java > Line 1022 getConnectionMetaData() - Non-final methods that perform security > checks may be overridden in ways that bypass security checks. > Line 1046 getGroups() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > broker-plugins/management-http/src/main/org/apache/qpid/server/management/plugin/servlet/rest/SaslServlet.java > Line 79 doGet() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > broker-plugins/amqp-0-8-protocol/org/apache/qpid/server/protocol/v0_8/AMQPConnection_0_8Impl.java > Line 699 readerIdle() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Executes privileged action. > broker-plugins/logging-logback/src/main/org/apache/qpid/server/logging/logback/ConnectionAndUserPredicate.java > Line 43 evaluate() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > broker-plugins/amqp-1-0-protocol/src/main/org/apache/qpid/server/protocol/v1_0/AMQPConnection_1_0Impl.java > Line 444 receive() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Line 1269 readerIdle() - Non-final methods that perform security checks may > be overridden in ways that bypass security checks. > Line 1340 receivedComplete() - Non-final methods that perform security checks > may be overridden in ways that bypass security checks. > broker-plugins/amqp-0-8-protocol/src/main/org/apache/qpid/server/protocol/v0_8/BrokerDecoder.java > Line 78 processAMQPFrames() - Non-final methods that perform security checks > may be overridden in ways that bypass security checks. > Executes privileged action. > broker-core/src/main/java/org/apache/qpid/server/security/CompoundAccessControl.java > Line 68 newToken() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/ServerAssembler.java > Line 72 received() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Executes privileged action. > broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/AMQPConnection_0_10Impl.java > Line 165 readerIdle() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Line 182 closed() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Executes privileged action. > broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ProxyMessageSource.java > Line 152 addConsumer() - Non-final methods that perform security checks may > be overridden in ways that bypass security checks. > broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementAddressSpace.java > Line 172 getProxyNode() - Non-final methods that perform security checks may > be overridden in ways that bypass security checks. >
[jira] [Commented] (QPID-8553) [Broker-J] HP Fortify: Weak SecurityManager Check: Overridable Method
[ https://issues.apache.org/jira/browse/QPID-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393801#comment-17393801 ] ASF subversion and git services commented on QPID-8553: --- Commit 62564fbb9231b5db5d5831540bafaafbc40f in qpid-broker-j's branch refs/heads/main from dakirily [ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=625 ] QPID-8553 - [Broker-J] Improve code with final keywords This closes #104 > [Broker-J] HP Fortify: Weak SecurityManager Check: Overridable Method > - > > Key: QPID-8553 > URL: https://issues.apache.org/jira/browse/QPID-8553 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-broker-8.0.5 >Reporter: Daniil Kirilyuk >Priority: Minor > Fix For: qpid-java-broker-9.0.0 > > > HP Fortify complains that classes defining security may be overridden by > sub-classes and thereby by-passing the security features: > broker-plugins/access-control/src/main/org/apache/qpid/server/security/access/config/RuleBasedAccessControl.java > Line 58 newToken() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Line 75 authorise() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > broker-core/src/main/java/org/apache/qpid/server/model/BrokerImpl.java > Line 1022 getConnectionMetaData() - Non-final methods that perform security > checks may be overridden in ways that bypass security checks. > Line 1046 getGroups() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > broker-plugins/management-http/src/main/org/apache/qpid/server/management/plugin/servlet/rest/SaslServlet.java > Line 79 doGet() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > broker-plugins/amqp-0-8-protocol/org/apache/qpid/server/protocol/v0_8/AMQPConnection_0_8Impl.java > Line 699 readerIdle() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Executes privileged action. > broker-plugins/logging-logback/src/main/org/apache/qpid/server/logging/logback/ConnectionAndUserPredicate.java > Line 43 evaluate() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > broker-plugins/amqp-1-0-protocol/src/main/org/apache/qpid/server/protocol/v1_0/AMQPConnection_1_0Impl.java > Line 444 receive() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Line 1269 readerIdle() - Non-final methods that perform security checks may > be overridden in ways that bypass security checks. > Line 1340 receivedComplete() - Non-final methods that perform security checks > may be overridden in ways that bypass security checks. > broker-plugins/amqp-0-8-protocol/src/main/org/apache/qpid/server/protocol/v0_8/BrokerDecoder.java > Line 78 processAMQPFrames() - Non-final methods that perform security checks > may be overridden in ways that bypass security checks. > Executes privileged action. > broker-core/src/main/java/org/apache/qpid/server/security/CompoundAccessControl.java > Line 68 newToken() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/ServerAssembler.java > Line 72 received() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Executes privileged action. > broker-plugins/amqp-0-10-protocol/src/main/java/org/apache/qpid/server/protocol/v0_10/AMQPConnection_0_10Impl.java > Line 165 readerIdle() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Line 182 closed() - Non-final methods that perform security checks may be > overridden in ways that bypass security checks. > Executes privileged action. > broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ProxyMessageSource.java > Line 152 addConsumer() - Non-final methods that perform security checks may > be overridden in ways that bypass security checks. > broker-plugins/management-amqp/src/main/java/org/apache/qpid/server/management/amqp/ManagementAddressSpace.java > Line 172 getProxyNode() - Non-final methods that perform security checks may > be overridden in ways that bypass security checks. > broker-plugins/logging-logback/src/main/java/org/apache/qpid/server/logging/logback/PrincipalLogEventFilter.java > Line 43 decide() - Non-final methods that perform security checks may be > overridden in ways that
[GitHub] [qpid-broker-j] asfgit closed pull request #104: QPID-8553 - [Broker-J] HP Fortify: Weak SecurityManager Check: Overridable Method
asfgit closed pull request #104: URL: https://github.com/apache/qpid-broker-j/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8500) [Broker-J] Introduce a switch to disable coalescing committer in BDB HA message store
[
https://issues.apache.org/jira/browse/QPID-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393776#comment-17393776
]
hanxq commented on QPID-8500:
-
Hi Alex:
My durability policy is WRITE_NO_SYN,NO_SYN,SIMPLE_MAJORITY. QPID version is
6.1.1， je is 7.4.5, qpid.bdb.ha.disable_coalescing_committer = true . but
other exception occurred.(Failed to dequeue message 1672 in transaction
)。
---
Error message：2021-08-05 15:19:07,041 ERROR [IO-/128.196.18.19:21588
(o.a.q.s.s.b.BDBConfigurationStore) Failed to dequeue message 1672 in
transaction 2021-08-05 15:19:07,041 ERROR
[IO-/128.196.18.19:21588 (o.a.q.s.s.b.BDBConfigurationStore) Failed to dequeue
message 1672 in transaction
com.sleepycat.je.rep.Replicawriteexcepton: (JE 7.4.5) Problem closing
transaction 8405. The current state is:UNKNOWN. The node transitioned to this
state at:Thu Aug 05 15:19:06 CST 2021 at
com.sleepycat.je.rep.txn.ReadonlyTxn.disallowReplicaWrite(ReadonlyTxn.java:114)-[je-7.4.5.jar:7.4.51
at com.sleepycat.je.rep.txn.Readonlylxn.preLogwithoutLock
(ReadonlyTxn.java:102) ~[je-7.4.5.jar:7.4.5】 at
com.sleepycat.je.dbi.cursorImpl.locklN (CursorImp1.java:3561)
~je-1.4.5.jar:7.4.5] at
com.sleepycat.je.dbi.CursorImpl.deletecurrentRecord(CursorImp1.java:900)~[je-7-4.5-jar:7.4.5
at
com.sleepycat.je.Cursor.deleteNoNotify(Cursor.java:2412)~[je-7.4.5.jar:7.4.5]
at com.sleepycat.je.cursor.deleteInternal(Cursor.java:2353)[je-7.4.5.jar:7.4.5]
at com.sleepycat.je.Database.deleteInternal(Database.java:1169)
-[je-7.4.5.jar:7.4.5] at
com.sleepyeat.je.Database.delete(Database.java:1128) -tje-7.4.5.jar:7.4.5] at
com.sleepycat.je.Database.delete(Database.java:1230)-[je-7.4.5.jar:7.4.5] at
org.apache.gpid.server.store.berkeleydb.AbstractBDBMessageStore.dequeueMessage(AbstractBDBMessageStore.java:671)[qpid-babstore-6.1.1.jar:6.1.1]
at
org.apache.apid.server.store.berkeleydb.AbstractBDBMessageStore.accessS1000(AbstractBDBMe3sageStore.java:74)
[cpid-bdbstore-6.1.1.jar:6.1.1 at
ora.apache.apid.server.store.berkeleydb.AbstractBDBMessageStoreSBDBTransaction.dequeueMessage(AbstractBDBM
ssageStore.java:1326)[gpid-bdbstore-6.1.1.jar:6.11] at
org.apache.qpid.server.txn.AsyncAutoCommitTransaction.dequeue
(AsyncAutoCommitTransaction.java:103)[apid-broker-core-6.1.1.iar:6.1.11 at
org.apache.pid.server.protocol.v0 10.serverSession.acknowledge
(ServerSession.java:567)[opid-broker-plugins-amap-0-10-protoco1-6.1.1.iar:6.1.11
> [Broker-J] Introduce a switch to disable coalescing committer in BDB HA
> message store
> -
>
> Key: QPID-8500
> URL: https://issues.apache.org/jira/browse/QPID-8500
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-8.0.4, qpid-java-broker-7.1.12
>
>
> A BDB JE replication Feeder fails sporadically with errors like the one below
> {noformat}
> Halted log file reading at file 0x7472c8 offset 0x199d07
> offset(decimal)=1678599 prev=0x199cd5:
> entry=DEL_LN_TXtype=31,version=14)
> prev=0x199cd5
> size=44
> Next entry should be at 0x199d49
> com.sleepycat.je.EnvironmentFailureException: (JE 7.4.5) want to read
> 52,431,066,320 but reader at 52,431,066,327 UNEXPECTED_STATE: Unexpected
> internal state, may have side effects.
> at
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:428)
> at
> com.sleepycat.je.rep.stream.FeederReader.checkForPassingTarget(FeederReader.java:297)
> at
> com.sleepycat.je.rep.stream.FeederReader.isTargetEntry(FeederReader.java:317)
> at
> com.sleepycat.je.log.FileReader.readNextEntryAllowExceptions(FileReader.java:332)
> at com.sleepycat.je.log.FileReader.readNextEntry(FileReader.java:245)
> at
> com.sleepycat.je.rep.stream.FeederReader.scanForwards(FeederReader.java:280)
> at
> com.sleepycat.je.rep.stream.MasterFeederSource.getWireRecord(MasterFeederSource.java:70)
> at
> com.sleepycat.je.rep.impl.node.Feeder$OutputThread.writeAvailableEntries(Feeder.java:1266)
> at
> com.sleepycat.je.rep.impl.node.Feeder$OutputThread.run(Feeder.java:1144)
> {noformat}
> Based on discussion at
> [https://community.oracle.com/tech/developers/discussion/4300421/master-fails-unexpectedly-due-to-feeder-output-halted-log-file-reading-at-file-0x334f63-offset-0x8ce]
> we need a way to configure broker without a coalescing committer. The local
> sync policy would be set as per user virtual host settings.
> A context variable can be added into BDB HA to disable coalescing committer
> thread.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (QPID-8550) [Broker-J] HP Fortify: Unreleased streams
[
https://issues.apache.org/jira/browse/QPID-8550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393757#comment-17393757
]
ASF GitHub Bot commented on QPID-8550:
--
alex-rufous commented on a change in pull request #103:
URL: https://github.com/apache/qpid-broker-j/pull/103#discussion_r683282742
##
File path:
broker-core/src/main/java/org/apache/qpid/server/store/JsonFileConfigStore.java
##
@@ -156,49 +156,52 @@ protected boolean load(final ConfiguredObjectRecord...
initialRecords)
boolean updated = false;
Collection records =
Collections.emptyList();
-ConfiguredObjectRecordConverter configuredObjectRecordConverter =
+final ConfiguredObjectRecordConverter
configuredObjectRecordConverter =
new ConfiguredObjectRecordConverter(_parent.getModel());
-records = configuredObjectRecordConverter.readFromJson(_rootClass,
_parent, new FileReader(configFile));
-
-if(_rootClass == null)
+try (FileReader configFileReader = new FileReader(configFile))
Review comment:
This change is unnecessary. The `configFileReader` is closed in
`ObjectMapper`. If you really need to make sure that `configFileReader` is
closed in the code where it is created, you can simply add `try-with-resource`
block around the code reading from json
```
try (FileReader configFileReader = new FileReader(configFile))
{
records = configuredObjectRecordConverter.readFromJson(_rootClass,
_parent, configFileReader);
}
```
##
File path:
broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/RestServlet.java
##
@@ -437,7 +437,10 @@ public String getRequestURL()
{
if ("data".equals(part.getName()) &&
"application/json".equals(part.getContentType()))
{
-items = mapper.readValue(part.getInputStream(),
LinkedHashMap.class);
+try (InputStream inputStream = part.getInputStream())
Review comment:
The change is unnecessary as methods `ObjectMapper#readValue ` close the
input stream/reader..
##
File path:
perftests/src/main/java/org/apache/qpid/disttest/controller/config/ConfigReader.java
##
@@ -37,10 +37,10 @@
public Config getConfigFromFile(String fileName) throws IOException
{
-Reader reader = getConfigReader(fileName);
-
-Config config = readConfig(reader);
-return config;
+try (Reader reader = getConfigReader(fileName))
Review comment:
The reader is closed in `ObjectMapper#read...`. Thus, the change is
unnecessary...
##
File path: broker-core/src/main/java/org/apache/qpid/server/util/FileUtils.java
##
@@ -205,8 +205,10 @@ public static void copy(File src, File dst)
*/
public static void copyCheckedEx(File src, File dst) throws IOException
{
-InputStream in = new FileInputStream(src);
-copy(in, dst);
+try (InputStream in = new FileInputStream(src))
Review comment:
The `InputStream` is closed in `copy`. Arguably the method `copy` should
indicate that it closes the input stream. It make more sense to rename it into
`copyInputStreamIntoFileAndClose`. Though, I suppose for a better code
relaibility the 'try-with-resource` would be good here.
##
File path:
broker-core/src/main/java/org/apache/qpid/server/virtualhostnode/AbstractVirtualHostNode.java
##
@@ -430,40 +430,42 @@ public PreferenceStore createPreferenceStore()
protected final ConfiguredObjectRecord[] getInitialRecords() throws
IOException
{
-ConfiguredObjectRecordConverter converter = new
ConfiguredObjectRecordConverter(getModel());
+final ConfiguredObjectRecordConverter converter = new
ConfiguredObjectRecordConverter(getModel());
-Collection records =
-new
ArrayList<>(converter.readFromJson(VirtualHost.class,this,getInitialConfigReader()));
-
-if(!records.isEmpty())
+try (final Reader initialConfigReader = getInitialConfigReader())
Review comment:
Try-with-resource block is unnecessary here as reading code is closing
the reader. If you really have to change to `try-with-resource`, it would be
preferable to keep the `try` block small and only use it for reading the
records. IMHO, that makes code more readable
```
final Collection records;
try (final Reader initialConfigReader = getInitialConfigReader())
{
records = new ArrayList<>(converter.readFromJson(VirtualHost.class,
this, initialConfigReader));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[GitHub] [qpid-broker-j] alex-rufous commented on a change in pull request #103: QPID-8550 - [Broker-J] HP Fortify: Unreleased streams
alex-rufous commented on a change in pull request #103:
URL: https://github.com/apache/qpid-broker-j/pull/103#discussion_r683282742
##
File path:
broker-core/src/main/java/org/apache/qpid/server/store/JsonFileConfigStore.java
##
@@ -156,49 +156,52 @@ protected boolean load(final ConfiguredObjectRecord...
initialRecords)
boolean updated = false;
Collection records =
Collections.emptyList();
-ConfiguredObjectRecordConverter configuredObjectRecordConverter =
+final ConfiguredObjectRecordConverter
configuredObjectRecordConverter =
new ConfiguredObjectRecordConverter(_parent.getModel());
-records = configuredObjectRecordConverter.readFromJson(_rootClass,
_parent, new FileReader(configFile));
-
-if(_rootClass == null)
+try (FileReader configFileReader = new FileReader(configFile))
Review comment:
This change is unnecessary. The `configFileReader` is closed in
`ObjectMapper`. If you really need to make sure that `configFileReader` is
closed in the code where it is created, you can simply add `try-with-resource`
block around the code reading from json
```
try (FileReader configFileReader = new FileReader(configFile))
{
records = configuredObjectRecordConverter.readFromJson(_rootClass,
_parent, configFileReader);
}
```
##
File path:
broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/RestServlet.java
##
@@ -437,7 +437,10 @@ public String getRequestURL()
{
if ("data".equals(part.getName()) &&
"application/json".equals(part.getContentType()))
{
-items = mapper.readValue(part.getInputStream(),
LinkedHashMap.class);
+try (InputStream inputStream = part.getInputStream())
Review comment:
The change is unnecessary as methods `ObjectMapper#readValue ` close the
input stream/reader..
##
File path:
perftests/src/main/java/org/apache/qpid/disttest/controller/config/ConfigReader.java
##
@@ -37,10 +37,10 @@
public Config getConfigFromFile(String fileName) throws IOException
{
-Reader reader = getConfigReader(fileName);
-
-Config config = readConfig(reader);
-return config;
+try (Reader reader = getConfigReader(fileName))
Review comment:
The reader is closed in `ObjectMapper#read...`. Thus, the change is
unnecessary...
##
File path: broker-core/src/main/java/org/apache/qpid/server/util/FileUtils.java
##
@@ -205,8 +205,10 @@ public static void copy(File src, File dst)
*/
public static void copyCheckedEx(File src, File dst) throws IOException
{
-InputStream in = new FileInputStream(src);
-copy(in, dst);
+try (InputStream in = new FileInputStream(src))
Review comment:
The `InputStream` is closed in `copy`. Arguably the method `copy` should
indicate that it closes the input stream. It make more sense to rename it into
`copyInputStreamIntoFileAndClose`. Though, I suppose for a better code
relaibility the 'try-with-resource` would be good here.
##
File path:
broker-core/src/main/java/org/apache/qpid/server/virtualhostnode/AbstractVirtualHostNode.java
##
@@ -430,40 +430,42 @@ public PreferenceStore createPreferenceStore()
protected final ConfiguredObjectRecord[] getInitialRecords() throws
IOException
{
-ConfiguredObjectRecordConverter converter = new
ConfiguredObjectRecordConverter(getModel());
+final ConfiguredObjectRecordConverter converter = new
ConfiguredObjectRecordConverter(getModel());
-Collection records =
-new
ArrayList<>(converter.readFromJson(VirtualHost.class,this,getInitialConfigReader()));
-
-if(!records.isEmpty())
+try (final Reader initialConfigReader = getInitialConfigReader())
Review comment:
Try-with-resource block is unnecessary here as reading code is closing
the reader. If you really have to change to `try-with-resource`, it would be
preferable to keep the `try` block small and only use it for reading the
records. IMHO, that makes code more readable
```
final Collection records;
try (final Reader initialConfigReader = getInitialConfigReader())
{
records = new ArrayList<>(converter.readFromJson(VirtualHost.class,
this, initialConfigReader));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For
[jira] [Commented] (QPID-8500) [Broker-J] Introduce a switch to disable coalescing committer in BDB HA message store
[
https://issues.apache.org/jira/browse/QPID-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393724#comment-17393724
]
Alex Rudyy commented on QPID-8500:
--
Hi [~1025524...@qq.com],
I was hoping that running BDB JE HA without coalescing committer and durability
SYN,SYN,MAJORITY would help to workaround the reported issue with BDB JE
replication.
Thus, a special context variable was introduced to disabled the coalescing
committer.
Could you please confirm that you managed to reproduce the problem when
{{qpid.bdb.ha.disable_coalescing_committer}} was set to {{true}}?
> [Broker-J] Introduce a switch to disable coalescing committer in BDB HA
> message store
> -
>
> Key: QPID-8500
> URL: https://issues.apache.org/jira/browse/QPID-8500
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Reporter: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-8.0.4, qpid-java-broker-7.1.12
>
>
> A BDB JE replication Feeder fails sporadically with errors like the one below
> {noformat}
> Halted log file reading at file 0x7472c8 offset 0x199d07
> offset(decimal)=1678599 prev=0x199cd5:
> entry=DEL_LN_TXtype=31,version=14)
> prev=0x199cd5
> size=44
> Next entry should be at 0x199d49
> com.sleepycat.je.EnvironmentFailureException: (JE 7.4.5) want to read
> 52,431,066,320 but reader at 52,431,066,327 UNEXPECTED_STATE: Unexpected
> internal state, may have side effects.
> at
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:428)
> at
> com.sleepycat.je.rep.stream.FeederReader.checkForPassingTarget(FeederReader.java:297)
> at
> com.sleepycat.je.rep.stream.FeederReader.isTargetEntry(FeederReader.java:317)
> at
> com.sleepycat.je.log.FileReader.readNextEntryAllowExceptions(FileReader.java:332)
> at com.sleepycat.je.log.FileReader.readNextEntry(FileReader.java:245)
> at
> com.sleepycat.je.rep.stream.FeederReader.scanForwards(FeederReader.java:280)
> at
> com.sleepycat.je.rep.stream.MasterFeederSource.getWireRecord(MasterFeederSource.java:70)
> at
> com.sleepycat.je.rep.impl.node.Feeder$OutputThread.writeAvailableEntries(Feeder.java:1266)
> at
> com.sleepycat.je.rep.impl.node.Feeder$OutputThread.run(Feeder.java:1144)
> {noformat}
> Based on discussion at
> [https://community.oracle.com/tech/developers/discussion/4300421/master-fails-unexpectedly-due-to-feeder-output-halted-log-file-reading-at-file-0x334f63-offset-0x8ce]
> we need a way to configure broker without a coalescing committer. The local
> sync policy would be set as per user virtual host settings.
> A context variable can be added into BDB HA to disable coalescing committer
> thread.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2224) system_tests_policy_oversize_compound: router_node.c:452: AMQP_rx_handler: Assertion `pn_link' failed
Jiri Daněk created DISPATCH-2224:
Summary: system_tests_policy_oversize_compound: router_node.c:452:
AMQP_rx_handler: Assertion `pn_link' failed
Key: DISPATCH-2224
URL: https://issues.apache.org/jira/browse/DISPATCH-2224
Project: Qpid Dispatch
Issue Type: Bug
Affects Versions: 1.18.0
Reporter: Jiri Daněk
https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/529131824#L4093
{noformat}
27: Test command: /opt/python/3.6.8/bin/python3.6
"/home/travis/build/apache/qpid-dispatch/build/tests/run.py" "-m" "unittest"
"-v" "system_tests_policy_oversize_compound"
27: Test timeout computed to be: 1200
27: test_60_block_oversize_EB1_INTB_at_INTB
(system_tests_policy_oversize_compound.MaxMessageSizeBlockOversize) ... ok
27: test_61_block_oversize_EB1_EA1_at_INTB
(system_tests_policy_oversize_compound.MaxMessageSizeBlockOversize) ... ok
27: test_70_block_oversize_EB1_INTB_at_both
(system_tests_policy_oversize_compound.MaxMessageSizeBlockOversize) ... ok
27: test_80_block_multicast_EB1_INTB_at_INTB
(system_tests_policy_oversize_compound.MaxMessageSizeBlockOversize) ... ok
27: test_81_block_multicast_EA1
(system_tests_policy_oversize_compound.MaxMessageSizeBlockOversize) ... ok
27: test_82_block_multicast_INTA
(system_tests_policy_oversize_compound.MaxMessageSizeBlockOversize) ... ok
27:
27: Router EB1 output file:
27:
27: -
27: Suppressions used:
27: count bytes template
27: 1 56 ^IoAdapter_init$
27: 1 32 ^qd_policy_c_counts_alloc$
27: 565 861321 /libpython3.*.so
27: -
27:
27:
27:
27:
27: Router EA1 output file:
27:
27: -
27: Suppressions used:
27: count bytes template
27: 1 56 ^IoAdapter_init$
27: 1 32 ^qd_policy_c_counts_alloc$
27: 565 861321 /libpython3.*.so
27: -
27:
27:
27:
27:
27: Router INT.B output file:
27:
27: -
27: Suppressions used:
27: count bytes template
27: 4224 ^IoAdapter_init$
27: 1 32 ^qd_policy_c_counts_alloc$
27: 649 918473 /libpython3.*.so
27: -
27:
27:
27:
27:
27: Router INT.A output file:
27:
27: -
27: Suppressions used:
27: count bytes template
27: 4224 ^IoAdapter_init$
27: 1 32 ^qd_policy_c_counts_alloc$
27: 644 915425 /libpython3.*.so
27: -
27:
27:
27:
27: test_90_block_link_route_EB1_INTB
(system_tests_policy_oversize_compound.MaxMessageSizeLinkRouteOversize) ... ok
27:
27: Router EB1 output file:
27:
27: -
27: Suppressions used:
27: count bytes template
27: 1 56 ^IoAdapter_init$
27: 1 32 ^qd_policy_c_counts_alloc$
27: 568 862505 /libpython3.*.so
27: -
27:
27:
27:
27:
27: Router EA1 output file:
27:
27: -
27: Suppressions used:
27: count bytes template
27: 1 56 ^IoAdapter_init$
27: 1 32 ^qd_policy_c_counts_alloc$
27: 568 862505 /libpython3.*.so
27: -
27:
27:
27:
27:
27: Router INT.B output file:
27:
27: qdrouterd: /home/travis/build/apache/qpid-dispatch/src/router_node.c:452:
AMQP_rx_handler: Assertion `pn_link' failed.
27:
27:
27:
27: Router INT.B output file:
27:
27: qdrouterd: /home/travis/build/apache/qpid-dispatch/src/router_node.c:452:
AMQP_rx_handler: Assertion `pn_link' failed.
27:
27:
27:
27: Router INT.B command file:
27:
27: qdrouterd -c INT.B.conf -I /home/travis/build/apache/qpid-dispatch/python
27: pid=13169
27:
27:
{noformat}
{noformat}
27: Router INT.B log file tail:
27:
27: 2021-08-04 23:04:25.293124 + ROUTER_CORE (debug) [C3][L39][D77]
Delivery decref_CT: rc:3 qdr_delivery_continue_CT - remove from action 2
(/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:641)
27: 2021-08-04 23:04:25.293427 + ROUTER_CORE (debug) [C3][L39][D77]
Delivery incref:rc:4 qdr_delivery_continue - add to action list
(/home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:116)
27: 2021-08-04 23:04:25.293655 + PROTOCOL (trace) [C3]:FRAME: 2 <-
@transfer(20) [handle=0, delivery-id=0, delivery-tag=b"1", message-format=0,
more=true] (16353)
