[GitHub] qpid-proton pull request #135: PROTON-1732: [OSX] Enable swig for the Travis...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/135


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #135: PROTON-1732: [OSX] Enable swig for the Travis...

[astitcher]

Github user astitcher commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/135#discussion_r160062571
  
--- Diff: .travis.yml ---
@@ -23,29 +23,37 @@ compiler:
 - gcc
 - clang
 
+env:
+- PIP='pip'
+
 matrix:
   include:
   - os: linux
 env:
 - QPID_PROTON_CMAKE_ARGS='-DCMAKE_BUILD_TYPE=Coverage'
+- PIP='pip'
--- End diff --

I think we may be talking about the opposite case:
- I'm suggesting that this line which part of a specific matrix build is 
not necessary because there is a line in the non matrix case.
- I think you are saying that not having the non matrix line doesn't work. 
I agree with this.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #135: PROTON-1732: [OSX] Enable swig for the Travis...

[RoddieKieley]

Github user RoddieKieley commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/135#discussion_r160039052
  
--- Diff: .travis.yml ---
@@ -23,29 +23,37 @@ compiler:
 - gcc
 - clang
 
+env:
+- PIP='pip'
+
 matrix:
   include:
   - os: linux
 env:
 - QPID_PROTON_CMAKE_ARGS='-DCMAKE_BUILD_TYPE=Coverage'
+- PIP='pip'
--- End diff --

I didn't have it first and the non matrix'd builds didn't succeed; see 
[buildlog](https://travis-ci.org/RoddieKieley/qpid-proton/jobs/325304860). Was 
there something I missed maybe?


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #135: PROTON-1732: [OSX] Enable swig for the Travis...

[astitcher]

Github user astitcher commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/135#discussion_r159936304
  
--- Diff: .travis.yml ---
@@ -23,29 +23,37 @@ compiler:
 - gcc
 - clang
 
+env:
+- PIP='pip'
+
 matrix:
   include:
   - os: linux
 env:
 - QPID_PROTON_CMAKE_ARGS='-DCMAKE_BUILD_TYPE=Coverage'
+- PIP='pip'
--- End diff --

You don't need this as it is the same as the default above.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #135: PROTON-1732: [OSX] Enable swig for the Travis...

[RoddieKieley]

GitHub user RoddieKieley opened a pull request:

https://github.com/apache/qpid-proton/pull/135

PROTON-1732: [OSX] Enable swig for the Travis CI build

Minor update to enable swig for the OSX Travis CI. BUILD_PERL=OFF for the 
moment as it attempts to build i386 and fails on OSX.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RoddieKieley/qpid-proton PROTON-1732

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #135


commit d88d23d0f8c4efcc4722ac5a87baef8e87227903
Author: Roddie Kieley 
Date:   2018-01-04T02:06:26Z

PROTON-1732: [OSX] Enable swig for the Travis CI build




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org