[jira] [Commented] (DISPATCH-1540) multiframe presettled messages not included in presettled count on downstream router
[ https://issues.apache.org/jira/browse/DISPATCH-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021512#comment-17021512 ] ASF subversion and git services commented on DISPATCH-1540: --- Commit a84c729aff44d78a959133e2731f8f7c1626d194 in qpid-dispatch's branch refs/heads/master from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=a84c729 ] DISPATCH-1540: fix access to presettled flag in qdr_action_t Clean up the qdr_action_t anonymous union layout by moving all delivery related action data out of the connection sub-structure and into the delivery sub-structure. > multiframe presettled messages not included in presettled count on downstream > router > - > > Key: DISPATCH-1540 > URL: https://issues.apache.org/jira/browse/DISPATCH-1540 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.10.0 >Reporter: Gordon Sim >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.11.0 > > > Set up two routers connected to each other. Attach receiver to one, sender to > the other and send a large message (such that it is sent as multiple transfer > frames). > > Then look at the inter-router link stats for each router. The downstream > router (i.e. that to which receiver is attached), does not record the > delivery as presettled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1540) multiframe presettled messages not included in presettled count on downstream router
[ https://issues.apache.org/jira/browse/DISPATCH-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021511#comment-17021511 ] ASF GitHub Bot commented on DISPATCH-1540: -- kgiusti commented on pull request #670: DISPATCH-1540: fix access to presettled flag in qdr_action_t URL: https://github.com/apache/qpid-dispatch/pull/670 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > multiframe presettled messages not included in presettled count on downstream > router > - > > Key: DISPATCH-1540 > URL: https://issues.apache.org/jira/browse/DISPATCH-1540 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.10.0 >Reporter: Gordon Sim >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.11.0 > > > Set up two routers connected to each other. Attach receiver to one, sender to > the other and send a large message (such that it is sent as multiple transfer > frames). > > Then look at the inter-router link stats for each router. The downstream > router (i.e. that to which receiver is attached), does not record the > delivery as presettled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1540) multiframe presettled messages not included in presettled count on downstream router
[ https://issues.apache.org/jira/browse/DISPATCH-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021159#comment-17021159 ] ASF GitHub Bot commented on DISPATCH-1540: -- kgiusti commented on pull request #670: DISPATCH-1540: fix access to presettled flag in qdr_action_t URL: https://github.com/apache/qpid-dispatch/pull/670 Clean up the qdr_action_t anonymous union layout by moving all delivery related action data out of the connection sub-structure and into the delivery sub-structure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > multiframe presettled messages not included in presettled count on downstream > router > - > > Key: DISPATCH-1540 > URL: https://issues.apache.org/jira/browse/DISPATCH-1540 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.10.0 >Reporter: Gordon Sim >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.11.0 > > > Set up two routers connected to each other. Attach receiver to one, sender to > the other and send a large message (such that it is sent as multiple transfer > frames). > > Then look at the inter-router link stats for each router. The downstream > router (i.e. that to which receiver is attached), does not record the > delivery as presettled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1540) multiframe presettled messages not included in presettled count on downstream router
[ https://issues.apache.org/jira/browse/DISPATCH-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016041#comment-17016041 ] ASF GitHub Bot commented on DISPATCH-1540: -- asfgit commented on pull request #658: DISPATCH-1540 - Set the pre-settled flag appropriately on a delivery … URL: https://github.com/apache/qpid-dispatch/pull/658 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > multiframe presettled messages not included in presettled count on downstream > router > - > > Key: DISPATCH-1540 > URL: https://issues.apache.org/jira/browse/DISPATCH-1540 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.10.0 >Reporter: Gordon Sim >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.11.0 > > > Set up two routers connected to each other. Attach receiver to one, sender to > the other and send a large message (such that it is sent as multiple transfer > frames). > > Then look at the inter-router link stats for each router. The downstream > router (i.e. that to which receiver is attached), does not record the > delivery as presettled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1540) multiframe presettled messages not included in presettled count on downstream router
[ https://issues.apache.org/jira/browse/DISPATCH-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016040#comment-17016040 ] ASF subversion and git services commented on DISPATCH-1540: --- Commit 9d3bf33f840b6fcce53db6db50365a3ee0bbb3de in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=9d3bf33 ] DISPATCH-1540 - Set the pre-settled flag appropriately on a delivery and its peers on large streaming messages. This will allow the presettled counters to be updated correctly. This closes #658. > multiframe presettled messages not included in presettled count on downstream > router > - > > Key: DISPATCH-1540 > URL: https://issues.apache.org/jira/browse/DISPATCH-1540 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.10.0 >Reporter: Gordon Sim >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.11.0 > > > Set up two routers connected to each other. Attach receiver to one, sender to > the other and send a large message (such that it is sent as multiple transfer > frames). > > Then look at the inter-router link stats for each router. The downstream > router (i.e. that to which receiver is attached), does not record the > delivery as presettled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1540) multiframe presettled messages not included in presettled count on downstream router
[ https://issues.apache.org/jira/browse/DISPATCH-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014707#comment-17014707 ] ASF GitHub Bot commented on DISPATCH-1540: -- codecov-io commented on issue #658: DISPATCH-1540 - Set the pre-settled flag appropriately on a delivery … URL: https://github.com/apache/qpid-dispatch/pull/658#issuecomment-573907457 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=h1) Report > Merging [#658](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/655145d8e5c9d3a947e407e8bbf08deb13830db3?src=pr=desc) will **increase** coverage by `0.03%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=tree) ```diff @@Coverage Diff @@ ## master #658 +/- ## == + Coverage 86.53% 86.57% +0.03% == Files 91 91 Lines 2065220658 +6 == + Hits1787217884 +12 + Misses 2780 2774 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.23% <100%> (ø)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `89.59% <100%> (+0.12%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.95% <0%> (-0.47%)` | :arrow_down: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3NlcnZlci5j) | `86.56% <0%> (+0.12%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `87.97% <0%> (+0.22%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.14% <0%> (+0.24%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.32% <0%> (+0.33%)` | :arrow_up: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `76.17% <0%> (+0.49%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=footer). Last update [655145d...1e5d89d](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > multiframe presettled messages not included in presettled count on downstream > router > - > > Key: DISPATCH-1540 > URL: https://issues.apache.org/jira/browse/DISPATCH-1540 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.10.0 >Reporter: Gordon Sim >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.11.0 > > > Set up two routers connected to each other. Attach receiver to one, sender to > the other and send a large message (such that it is sent as multiple transfer > frames). > > Then look at the inter-router link stats for each router. The downstream > router (i.e. that to which receiver is attached), does not record the > delivery as presettled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To
[jira] [Commented] (DISPATCH-1540) multiframe presettled messages not included in presettled count on downstream router
[
https://issues.apache.org/jira/browse/DISPATCH-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014395#comment-17014395
]
ASF GitHub Bot commented on DISPATCH-1540:
--
kgiusti commented on pull request #658: DISPATCH-1540 - Set the pre-settled
flag appropriately on a delivery …
URL: https://github.com/apache/qpid-dispatch/pull/658#discussion_r365850091
##
File path: src/router_core/delivery.c
##
@@ -201,8 +201,16 @@ void qdr_delivery_remote_state_updated(qdr_core_t *core,
qdr_delivery_t *deliver
}
-qdr_delivery_t *qdr_deliver_continue(qdr_core_t *core,qdr_delivery_t *in_dlv)
+qdr_delivery_t *qdr_deliver_continue(qdr_core_t *core,qdr_delivery_t *in_dlv,
bool settled)
{
+//
+// If the delivery is already pre-settled, don't do anything with the
pre-settled flag.
+//
+// If the in_delivery was not pre-settled, you can go to pre-settled.
+if (! in_dlv->presettled && settled) {
+in_dlv->presettled = settled;
Review comment:
This is (technically) a possible race condition. This method runs under the
I/O thread which should not be modifying qdr_delivery_t state directly.
It would be better to pass along the presettled flag in the action. I
suggest considering changing the existing code to use the action->args.delivery
action structure (adding a pre-settled flag there) instead of the
args.connection structure.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> multiframe presettled messages not included in presettled count on downstream
> router
> -
>
> Key: DISPATCH-1540
> URL: https://issues.apache.org/jira/browse/DISPATCH-1540
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.10.0
>Reporter: Gordon Sim
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.11.0
>
>
> Set up two routers connected to each other. Attach receiver to one, sender to
> the other and send a large message (such that it is sent as multiple transfer
> frames).
>
> Then look at the inter-router link stats for each router. The downstream
> router (i.e. that to which receiver is attached), does not record the
> delivery as presettled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1540) multiframe presettled messages not included in presettled count on downstream router
[ https://issues.apache.org/jira/browse/DISPATCH-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013027#comment-17013027 ] ASF GitHub Bot commented on DISPATCH-1540: -- ganeshmurthy commented on pull request #658: DISPATCH-1540 - Set the pre-settled flag appropriately on a delivery … URL: https://github.com/apache/qpid-dispatch/pull/658 …and its peers on large streaming messages. This will allow the presettled counters to be updated correctly This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > multiframe presettled messages not included in presettled count on downstream > router > - > > Key: DISPATCH-1540 > URL: https://issues.apache.org/jira/browse/DISPATCH-1540 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: Ganesh Murthy >Priority: Major > > Set up two routers connected to each other. Attach receiver to one, sender to > the other and send a large message (such that it is sent as multiple transfer > frames). > > Then look at the inter-router link stats for each router. The downstream > router (i.e. that to which receiver is attached), does not record the > delivery as presettled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
