[jira] [Commented] (DISPATCH-1656) Allow user-configured connection properties in the Open performative
[
https://issues.apache.org/jira/browse/DISPATCH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120653#comment-17120653
]
ASF subversion and git services commented on DISPATCH-1656:
---
Commit d8e09c4390fe452cec197fe860305ae4e8858925 in qpid-dispatch's branch
refs/heads/master from Ken Giusti
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=d8e09c4 ]
DISPATCH-1656: fix condition check error found by coverity
> Allow user-configured connection properties in the Open performative
>
>
> Key: DISPATCH-1656
> URL: https://issues.apache.org/jira/browse/DISPATCH-1656
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.13.0
>
>
> This feature would add a new "openProperties" map attribute to the
> org.apache.qpid.dispatch.connector and org.apache.qpid.dispatch.listener
> management entities. This new attribute is optional.
> The contents of the map are expected to be specified in JSON. The keys must
> be restricted to ASCII characters only in order to be encoded as AMQP 1.0
> Symbol types on the wire.
> Key values that start with the prefixes *qd.* or *x-opt-qd.* are reserved and
> must not be used.
> In addition, the following keys are reserved and must not be used:
> product
> version
> failover-server-list
> network-host
> port
> scheme
> hostname
> The openProperties keys and values will be merged into the connection
> properties field of the outgoing Open performative when establishing or
> accepting connections.
> The openProperties attribute is NOT allowed on connector or listener entities
> with roles of either "inter-router" or "edge".
> The openProperties attribute is NOT allowed on listener entities than enable
> http, i.e. http: true.
> Example:
> {{connector {}}
> {{ name: broker}}
> {{ role: route-container}}
> {{ host: 127.0.0.1}}
> {{ port: 22180}}
> {{ saslMechanisms: ANONYMOUS}}
> {{ *openProperties: {*}}
> {{ *"foo": "bar",*}}
> {{ *"integer": 7,*}}
> {{*"list": ["a", 1, "b", -9, true],*}}
> {{*"map": \{"key1": null, "key2": [1, 2, 3]\},*}}
> {{*}*}}
> {{ cost: 10}}
> {{}}}
> The resulting connection properties in the outgoing Open performative would
> include the following map entries:
> {{Symbol(foo): String(bar),}}
> {{Symbol(integer): Int(7),}}
> {{Symbol(list): List(String(a), Int(1), String(b), Int(-9), Boolean),}}
> {{Symbol(map): Map(String(key1): Null, String(key2): List(Int(1), Int(2),
> Int(3)))}}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1656) Allow user-configured connection properties in the Open performative
[
https://issues.apache.org/jira/browse/DISPATCH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119060#comment-17119060
]
ASF subversion and git services commented on DISPATCH-1656:
---
Commit 0d2e54ee7c7f6baf440de8a123253916dfb34ed5 in qpid-dispatch's branch
refs/heads/master from Ken Giusti
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=0d2e54e ]
DISPATCH-1656: do not allow openProperties on connections to router
> Allow user-configured connection properties in the Open performative
>
>
> Key: DISPATCH-1656
> URL: https://issues.apache.org/jira/browse/DISPATCH-1656
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.13.0
>
>
> This feature would add a new "openProperties" map attribute to the
> org.apache.qpid.dispatch.connector and org.apache.qpid.dispatch.listener
> management entities. This new attribute is optional.
> The contents of the map are expected to be specified in JSON. The keys must
> be restricted to ASCII characters only in order to be encoded as AMQP 1.0
> Symbol types on the wire.
> Key values that start with the prefixes *qd.* or *x-opt-qd.* are reserved and
> must not be used.
> In addition, the following keys are reserved and must not be used:
> product
> version
> failover-server-list
> network-host
> port
> scheme
> hostname
> The openProperties keys and values will be merged into the connection
> properties field of the outgoing Open performative when establishing or
> accepting connections.
> The openProperties attribute is NOT allowed on connector or listener entities
> with roles of either "inter-router" or "edge".
> The openProperties attribute is NOT allowed on listener entities than enable
> http, i.e. http: true.
> Example:
> {{connector {}}
> {{ name: broker}}
> {{ role: route-container}}
> {{ host: 127.0.0.1}}
> {{ port: 22180}}
> {{ saslMechanisms: ANONYMOUS}}
> {{ *openProperties: {*}}
> {{ *"foo": "bar",*}}
> {{ *"integer": 7,*}}
> {{*"list": ["a", 1, "b", -9, true],*}}
> {{*"map": \{"key1": null, "key2": [1, 2, 3]\},*}}
> {{*}*}}
> {{ cost: 10}}
> {{}}}
> The resulting connection properties in the outgoing Open performative would
> include the following map entries:
> {{Symbol(foo): String(bar),}}
> {{Symbol(integer): Int(7),}}
> {{Symbol(list): List(String(a), Int(1), String(b), Int(-9), Boolean),}}
> {{Symbol(map): Map(String(key1): Null, String(key2): List(Int(1), Int(2),
> Int(3)))}}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1656) Allow user-configured connection properties in the Open performative
[
https://issues.apache.org/jira/browse/DISPATCH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118990#comment-17118990
]
Ulf Lilleengen commented on DISPATCH-1656:
--
I think it looks great [~kgiusti] !
> Allow user-configured connection properties in the Open performative
>
>
> Key: DISPATCH-1656
> URL: https://issues.apache.org/jira/browse/DISPATCH-1656
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.13.0
>
>
> This feature would add a new "openProperties" map attribute to the
> org.apache.qpid.dispatch.connector and org.apache.qpid.dispatch.listener
> management entities. This new attribute is optional.
> The contents of the map are expected to be specified in JSON. The keys must
> be restricted to ASCII characters only in order to be encoded as AMQP 1.0
> Symbol types on the wire.
> Key values that start with the prefixes *qd.* or *x-opt-qd.* are reserved and
> must not be used.
> In addition, the following keys are reserved and must not be used:
> product
> version
> failover-server-list
> network-host
> port
> scheme
> hostname
> The openProperties keys and values will be merged into the connection
> properties field of the outgoing Open performative when establishing or
> accepting connections.
> The openProperties attribute is NOT allowed on connector or listener entities
> with roles of either "inter-router" or "edge".
> The openProperties attribute is NOT allowed on listener entities than enable
> http, i.e. http: true.
> Example:
> {{connector {}}
> {{ name: broker}}
> {{ role: route-container}}
> {{ host: 127.0.0.1}}
> {{ port: 22180}}
> {{ saslMechanisms: ANONYMOUS}}
> {{ *openProperties: {*}}
> {{ *"foo": "bar",*}}
> {{ *"integer": 7,*}}
> {{*"list": ["a", 1, "b", -9, true],*}}
> {{*"map": \{"key1": null, "key2": [1, 2, 3]\},*}}
> {{*}*}}
> {{ cost: 10}}
> {{}}}
> The resulting connection properties in the outgoing Open performative would
> include the following map entries:
> {{Symbol(foo): String(bar),}}
> {{Symbol(integer): Int(7),}}
> {{Symbol(list): List(String(a), Int(1), String(b), Int(-9), Boolean),}}
> {{Symbol(map): Map(String(key1): Null, String(key2): List(Int(1), Int(2),
> Int(3)))}}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1656) Allow user-configured connection properties in the Open performative
[
https://issues.apache.org/jira/browse/DISPATCH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118986#comment-17118986
]
ASF subversion and git services commented on DISPATCH-1656:
---
Commit a350f7ba869885d51fecf31878676b7c633a7200 in qpid-dispatch's branch
refs/heads/master from Ken Giusti
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=a350f7b ]
DISPATCH-1656: fix test to support older json version
> Allow user-configured connection properties in the Open performative
>
>
> Key: DISPATCH-1656
> URL: https://issues.apache.org/jira/browse/DISPATCH-1656
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.13.0
>
>
> This feature would add a new "openProperties" map attribute to the
> org.apache.qpid.dispatch.connector and org.apache.qpid.dispatch.listener
> management entities. This new attribute is optional.
> The contents of the map are expected to be specified in JSON. The keys must
> be restricted to ASCII characters only in order to be encoded as AMQP 1.0
> Symbol types on the wire.
> Key values that start with the prefixes *qd.* or *x-opt-qd.* are reserved and
> must not be used.
> In addition, the following keys are reserved and must not be used:
> product
> version
> failover-server-list
> network-host
> port
> scheme
> hostname
> The openProperties keys and values will be merged into the connection
> properties field of the outgoing Open performative when establishing or
> accepting connections.
> The openProperties attribute is NOT allowed on connector or listener entities
> with roles of either "inter-router" or "edge".
> The openProperties attribute is NOT allowed on listener entities than enable
> http, i.e. http: true.
> Example:
> {{connector {}}
> {{ name: broker}}
> {{ role: route-container}}
> {{ host: 127.0.0.1}}
> {{ port: 22180}}
> {{ saslMechanisms: ANONYMOUS}}
> {{ *openProperties: {*}}
> {{ *"foo": "bar",*}}
> {{ *"integer": 7,*}}
> {{*"list": ["a", 1, "b", -9, true],*}}
> {{*"map": \{"key1": null, "key2": [1, 2, 3]\},*}}
> {{*}*}}
> {{ cost: 10}}
> {{}}}
> The resulting connection properties in the outgoing Open performative would
> include the following map entries:
> {{Symbol(foo): String(bar),}}
> {{Symbol(integer): Int(7),}}
> {{Symbol(list): List(String(a), Int(1), String(b), Int(-9), Boolean),}}
> {{Symbol(map): Map(String(key1): Null, String(key2): List(Int(1), Int(2),
> Int(3)))}}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1656) Allow user-configured connection properties in the Open performative
[
https://issues.apache.org/jira/browse/DISPATCH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118747#comment-17118747
]
ASF GitHub Bot commented on DISPATCH-1656:
--
asfgit closed pull request #746:
URL: https://github.com/apache/qpid-dispatch/pull/746
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow user-configured connection properties in the Open performative
>
>
> Key: DISPATCH-1656
> URL: https://issues.apache.org/jira/browse/DISPATCH-1656
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.13.0
>
>
> This feature would add a new "openProperties" map attribute to the
> org.apache.qpid.dispatch.connector and org.apache.qpid.dispatch.listener
> management entities. This new attribute is optional.
> The contents of the map are expected to be specified in JSON. The keys must
> be restricted to ASCII characters only in order to be encoded as AMQP 1.0
> Symbol types on the wire.
> Key values that start with the prefixes *qd.* or *x-opt-qd.* are reserved and
> must not be used.
> In addition, the following keys are reserved and must not be used:
> product
> version
> failover-server-list
> network-host
> port
> scheme
> hostname
> The openProperties keys and values will be merged into the connection
> properties field of the outgoing Open performative when establishing or
> accepting connections.
> The openProperties attribute is NOT allowed on connector or listener entities
> with roles of either "inter-router" or "edge".
> The openProperties attribute is NOT allowed on listener entities than enable
> http, i.e. http: true.
> Example:
> {{connector {}}
> {{ name: broker}}
> {{ role: route-container}}
> {{ host: 127.0.0.1}}
> {{ port: 22180}}
> {{ saslMechanisms: ANONYMOUS}}
> {{ *openProperties: {*}}
> {{ *"foo": "bar",*}}
> {{ *"integer": 7,*}}
> {{*"list": ["a", 1, "b", -9, true],*}}
> {{*"map": \{"key1": null, "key2": [1, 2, 3]\},*}}
> {{*}*}}
> {{ cost: 10}}
> {{}}}
> The resulting connection properties in the outgoing Open performative would
> include the following map entries:
> {{Symbol(foo): String(bar),}}
> {{Symbol(integer): Int(7),}}
> {{Symbol(list): List(String(a), Int(1), String(b), Int(-9), Boolean),}}
> {{Symbol(map): Map(String(key1): Null, String(key2): List(Int(1), Int(2),
> Int(3)))}}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1656) Allow user-configured connection properties in the Open performative
[
https://issues.apache.org/jira/browse/DISPATCH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118744#comment-17118744
]
ASF subversion and git services commented on DISPATCH-1656:
---
Commit a1e59d27e00d4902935421e6788a2d65d55f3ce8 in qpid-dispatch's branch
refs/heads/master from Ken Giusti
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=a1e59d2 ]
DISPATCH-1656: Add openProperties attribute to listener and connector
This closes #746
> Allow user-configured connection properties in the Open performative
>
>
> Key: DISPATCH-1656
> URL: https://issues.apache.org/jira/browse/DISPATCH-1656
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.13.0
>
>
> This feature would add a new "openProperties" map attribute to the
> org.apache.qpid.dispatch.connector and org.apache.qpid.dispatch.listener
> management entities. This new attribute is optional.
> The contents of the map are expected to be specified in JSON. The keys must
> be restricted to ASCII characters only in order to be encoded as AMQP 1.0
> Symbol types on the wire.
> Key values that start with the prefixes *qd.* or *x-opt-qd.* are reserved and
> must not be used.
> In addition, the following keys are reserved and must not be used:
> product
> version
> failover-server-list
> network-host
> port
> scheme
> hostname
> The openProperties keys and values will be merged into the connection
> properties field of the outgoing Open performative when establishing or
> accepting connections.
> The openProperties attribute is NOT allowed on connector or listener entities
> with roles of either "inter-router" or "edge".
> The openProperties attribute is NOT allowed on listener entities than enable
> http, i.e. http: true.
> Example:
> {{connector {}}
> {{ name: broker}}
> {{ role: route-container}}
> {{ host: 127.0.0.1}}
> {{ port: 22180}}
> {{ saslMechanisms: ANONYMOUS}}
> {{ *openProperties: {*}}
> {{ *"foo": "bar",*}}
> {{ *"integer": 7,*}}
> {{*"list": ["a", 1, "b", -9, true],*}}
> {{*"map": \{"key1": null, "key2": [1, 2, 3]\},*}}
> {{*}*}}
> {{ cost: 10}}
> {{}}}
> The resulting connection properties in the outgoing Open performative would
> include the following map entries:
> {{Symbol(foo): String(bar),}}
> {{Symbol(integer): Int(7),}}
> {{Symbol(list): List(String(a), Int(1), String(b), Int(-9), Boolean),}}
> {{Symbol(map): Map(String(key1): Null, String(key2): List(Int(1), Int(2),
> Int(3)))}}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1656) Allow user-configured connection properties in the Open performative
[
https://issues.apache.org/jira/browse/DISPATCH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117804#comment-17117804
]
Ken Giusti commented on DISPATCH-1656:
--
[~lulf] , [~kwall]
I've updated the feature description and have a pull request on github that is
functionally complete.
In terms of config file syntax - the key and values that appear between the
braces of openProperties maps are specified in JSON syntax. Specifically:
* map keys are quoted ASCII strings
* map values can be any JSON type - quoted string, integer, null, true, false
- and allow list and map nesting.
Let me know what you think.
> Allow user-configured connection properties in the Open performative
>
>
> Key: DISPATCH-1656
> URL: https://issues.apache.org/jira/browse/DISPATCH-1656
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.13.0
>
>
> This feature would add a new "openProperties" map attribute to the
> org.apache.qpid.dispatch.connector and org.apache.qpid.dispatch.listener
> management entities. This new attribute is optional.
> The contents of the map are expected to be specified in JSON. The keys must
> be restricted to ASCII characters only in order to be encoded as AMQP 1.0
> Symbol types on the wire.
> Key values that start with the prefixes *qd.* or *x-opt-qd.* are reserved and
> must not be used.
> In addition, the following keys are reserved and must not be used:
> product
> version
> failover-server-list
> network-host
> port
> scheme
> hostname
> The openProperties keys and values will be merged into the connection
> properties field of the outgoing Open performative when establishing or
> accepting connections.
> The openProperties attribute is NOT allowed on connector or listener entities
> with roles of either "inter-router" or "edge".
> The openProperties attribute is NOT allowed on listener entities than enable
> http, i.e. http: true.
> Example:
> {{connector {}}
> {{ name: broker}}
> {{ role: route-container}}
> {{ host: 127.0.0.1}}
> {{ port: 22180}}
> {{ saslMechanisms: ANONYMOUS}}
> {{ *openProperties: {*}}
> {{ *"foo": "bar",*}}
> {{ *"integer": 7,*}}
> {{*"list": ["a", 1, "b", -9, true],*}}
> {{*"map": \{"key1": null, "key2": [1, 2, 3]\},*}}
> {{*}*}}
> {{ cost: 10}}
> {{}}}
> The resulting connection properties in the outgoing Open performative would
> include the following map entries:
> {{Symbol(foo): String(bar),}}
> {{Symbol(integer): Int(7),}}
> {{Symbol(list): List(String(a), Int(1), String(b), Int(-9), Boolean),}}
> {{Symbol(map): Map(String(key1): Null, String(key2): List(Int(1), Int(2),
> Int(3)))}}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1656) Allow user-configured connection properties in the Open performative
[ https://issues.apache.org/jira/browse/DISPATCH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117362#comment-17117362 ] ASF GitHub Bot commented on DISPATCH-1656: -- codecov-commenter commented on pull request #746: URL: https://github.com/apache/qpid-dispatch/pull/746#issuecomment-634197090 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/746?src=pr=h1) Report > Merging [#746](https://codecov.io/gh/apache/qpid-dispatch/pull/746?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/be42638a2da2d9fec0fac98f3b1c1be1606002c0=desc) will **decrease** coverage by `0.32%`. > The diff coverage is `50.24%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/746?src=pr=tree) ```diff @@Coverage Diff @@ ## master #746 +/- ## == - Coverage 86.95% 86.63% -0.33% == Files 96 96 Lines 2172821930 +202 == + Hits1889418999 +105 - Misses 2834 2931 +97 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/746?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/compose.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr=tree#diff-c3JjL2NvbXBvc2UuYw==) | `88.02% <0.00%> (-1.58%)` | :arrow_down: | | [src/proton\_utils.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr=tree#diff-c3JjL3Byb3Rvbl91dGlscy5j) | `48.96% <38.29%> (-19.67%)` | :arrow_down: | | [src/entity.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr=tree#diff-c3JjL2VudGl0eS5j) | `56.75% <57.14%> (+0.06%)` | :arrow_up: | | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr=tree#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `75.22% <57.35%> (-2.44%)` | :arrow_down: | | [src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `91.26% <100.00%> (+0.01%)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr=tree#diff-c3JjL3NlcnZlci5j) | `86.36% <100.00%> (+0.20%)` | :arrow_up: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `82.31% <0.00%> (-0.17%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `91.68% <0.00%> (-0.11%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.47% <0.00%> (+0.10%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/746?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/746?src=pr=footer). Last update [be42638...0bff301](https://codecov.io/gh/apache/qpid-dispatch/pull/746?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow user-configured connection properties in the Open performative > > > Key: DISPATCH-1656 > URL: https://issues.apache.org/jira/browse/DISPATCH-1656 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Router Node >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.13.0 > > > This feature would add a new "openProperties" attribute to the > org.apache.qpid.dispatch.connector and org.apache.qpid.dispatch.listener > management entities. This new attribute is type string and is optional. > If supplied it will consist of a series of one or more field entries > separated by commas. A field entry is text in the form "key: value", where > "key" that can
[jira] [Commented] (DISPATCH-1656) Allow user-configured connection properties in the Open performative
[
https://issues.apache.org/jira/browse/DISPATCH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117327#comment-17117327
]
ASF GitHub Bot commented on DISPATCH-1656:
--
kgiusti opened a new pull request #746:
URL: https://github.com/apache/qpid-dispatch/pull/746
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow user-configured connection properties in the Open performative
>
>
> Key: DISPATCH-1656
> URL: https://issues.apache.org/jira/browse/DISPATCH-1656
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.13.0
>
>
> This feature would add a new "openProperties" attribute to the
> org.apache.qpid.dispatch.connector and org.apache.qpid.dispatch.listener
> management entities. This new attribute is type string and is optional.
> If supplied it will consist of a series of one or more field entries
> separated by commas. A field entry is text in the form "key: value", where
> "key" that can be encoded as a valid AMQP 1.0 Symbol type. Value will be
> encoded as an AMQP 1.0 String type.
> The key or value text may contain spaces, colons or commas but must be
> enclosed in single quotes (see example below) if it does.
> Duplicate keys are NOT allowed.
> Key values that start with *qd.* or *x-opt-qd.* are reserved and must not be
> used.
> In addition, the following keys are reserved and must not be used:
> product
> version
> failover-server-list
> network-host
> port
> scheme
> hostname
> The openProperties keys and values will be merged into the connection
> properties field of the outgoing Open performative when establishing or
> accepting connections.
> The openProperties attribute is NOT allowed on connector or listener entities
> with roles of either "inter-router" or "edge".
> The openProperties attribute is NOT allowed on listener entities than enable
> http, i.e. http: true.
> Example:
> {{connector {}}
> {{ name: broker}}
> {{ role: route-container}}
> {{ host: 127.0.0.1}}
> {{ port: 22180}}
> {{ saslMechanisms: ANONYMOUS}}
> {{ *openProperties: "foo: bar,baz:foo, bar: 'Hello: you big, wonderful
> world!'"*}}
> {{}}}
>
> The resulting connection properties in the outgoing Open performative would
> include the following map entries:
> {{Symbol(foo): String(bar),}}
> {{Symbol(baz): String(foo),}}
> {{Symbol(bar): String(Hello: you big, wonderful world!)}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1656) Allow user-configured connection properties in the Open performative
[
https://issues.apache.org/jira/browse/DISPATCH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107951#comment-17107951
]
Ulf Lilleengen commented on DISPATCH-1656:
--
(Tangent response :D)
[~jross] you can already use JSON for the whole router config file. The format
is a bit ... special, but it works. Example:
{code:java}
[
["listener", { "host": "0.0.0.0", "port": 56721, "authenticatePeer": false,
"saslMechanisms": "ANONYMOUS", "multiTenant": true }],
["policy", {"enableVhostPolicy": true, "defaultVhost": "$default" }],
]
{code}
[~kgiusti] In this case though, will the config element be a JSON string
within this struct, or a JSON "native" object?
> Allow user-configured connection properties in the Open performative
>
>
> Key: DISPATCH-1656
> URL: https://issues.apache.org/jira/browse/DISPATCH-1656
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.13.0
>
>
> This feature would add a new "openProperties" attribute to the
> org.apache.qpid.dispatch.connector and org.apache.qpid.dispatch.listener
> management entities. This new attribute is type string and is optional.
> If supplied it will consist of a series of one or more field entries
> separated by commas. A field entry is text in the form "key: value", where
> "key" that can be encoded as a valid AMQP 1.0 Symbol type. Value will be
> encoded as an AMQP 1.0 String type.
> The key or value text may contain spaces, colons or commas but must be
> enclosed in single quotes (see example below) if it does.
> Duplicate keys are NOT allowed.
> Key values that start with *qd.* or *x-opt-qd.* are reserved and must not be
> used.
> In addition, the following keys are reserved and must not be used:
> product
> version
> failover-server-list
> network-host
> port
> scheme
> hostname
> The openProperties keys and values will be merged into the connection
> properties field of the outgoing Open performative when establishing or
> accepting connections.
> The openProperties attribute is NOT allowed on connector or listener entities
> with roles of either "inter-router" or "edge".
> The openProperties attribute is NOT allowed on listener entities than enable
> http, i.e. http: true.
> Example:
> {{connector {}}
> {{ name: broker}}
> {{ role: route-container}}
> {{ host: 127.0.0.1}}
> {{ port: 22180}}
> {{ saslMechanisms: ANONYMOUS}}
> {{ *openProperties: "foo: bar,baz:foo, bar: 'Hello: you big, wonderful
> world!'"*}}
> {{}}}
>
> The resulting connection properties in the outgoing Open performative would
> include the following map entries:
> {{Symbol(foo): String(bar),}}
> {{Symbol(baz): String(foo),}}
> {{Symbol(bar): String(Hello: you big, wonderful world!)}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1656) Allow user-configured connection properties in the Open performative
[
https://issues.apache.org/jira/browse/DISPATCH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107798#comment-17107798
]
Justin Ross commented on DISPATCH-1656:
---
JSON makes good sense for this bit, and embedding it here is a good choice for
expediency.
(Tangent alert.)
But! Why not just make the whole config file JSON? Then you can have nested
data of this sort - in a standard format that every language can already
generate and parse. Then you don't end up introducing *special mini-syntaxes*
for element values.
(IMO, this whole make-up-your-own-syntax-for-config-files thing is nonsense.)
> Allow user-configured connection properties in the Open performative
>
>
> Key: DISPATCH-1656
> URL: https://issues.apache.org/jira/browse/DISPATCH-1656
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.13.0
>
>
> This feature would add a new "openProperties" attribute to the
> org.apache.qpid.dispatch.connector and org.apache.qpid.dispatch.listener
> management entities. This new attribute is type string and is optional.
> If supplied it will consist of a series of one or more field entries
> separated by commas. A field entry is text in the form "key: value", where
> "key" that can be encoded as a valid AMQP 1.0 Symbol type. Value will be
> encoded as an AMQP 1.0 String type.
> The key or value text may contain spaces, colons or commas but must be
> enclosed in single quotes (see example below) if it does.
> Duplicate keys are NOT allowed.
> Key values that start with *qd.* or *x-opt-qd.* are reserved and must not be
> used.
> In addition, the following keys are reserved and must not be used:
> product
> version
> failover-server-list
> network-host
> port
> scheme
> hostname
> The openProperties keys and values will be merged into the connection
> properties field of the outgoing Open performative when establishing or
> accepting connections.
> The openProperties attribute is NOT allowed on connector or listener entities
> with roles of either "inter-router" or "edge".
> The openProperties attribute is NOT allowed on listener entities than enable
> http, i.e. http: true.
> Example:
> {{connector {}}
> {{ name: broker}}
> {{ role: route-container}}
> {{ host: 127.0.0.1}}
> {{ port: 22180}}
> {{ saslMechanisms: ANONYMOUS}}
> {{ *openProperties: "foo: bar,baz:foo, bar: 'Hello: you big, wonderful
> world!'"*}}
> {{}}}
>
> The resulting connection properties in the outgoing Open performative would
> include the following map entries:
> {{Symbol(foo): String(bar),}}
> {{Symbol(baz): String(foo),}}
> {{Symbol(bar): String(Hello: you big, wonderful world!)}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1656) Allow user-configured connection properties in the Open performative
[
https://issues.apache.org/jira/browse/DISPATCH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107551#comment-17107551
]
Ken Giusti commented on DISPATCH-1656:
--
JSON it is!
> Allow user-configured connection properties in the Open performative
>
>
> Key: DISPATCH-1656
> URL: https://issues.apache.org/jira/browse/DISPATCH-1656
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.13.0
>
>
> This feature would add a new "openProperties" attribute to the
> org.apache.qpid.dispatch.connector and org.apache.qpid.dispatch.listener
> management entities. This new attribute is type string and is optional.
> If supplied it will consist of a series of one or more field entries
> separated by commas. A field entry is text in the form "key: value", where
> "key" that can be encoded as a valid AMQP 1.0 Symbol type. Value will be
> encoded as an AMQP 1.0 String type.
> The key or value text may contain spaces, colons or commas but must be
> enclosed in single quotes (see example below) if it does.
> Duplicate keys are NOT allowed.
> Key values that start with *qd.* or *x-opt-qd.* are reserved and must not be
> used.
> In addition, the following keys are reserved and must not be used:
> product
> version
> failover-server-list
> network-host
> port
> scheme
> hostname
> The openProperties keys and values will be merged into the connection
> properties field of the outgoing Open performative when establishing or
> accepting connections.
> The openProperties attribute is NOT allowed on connector or listener entities
> with roles of either "inter-router" or "edge".
> The openProperties attribute is NOT allowed on listener entities than enable
> http, i.e. http: true.
> Example:
> {{connector {}}
> {{ name: broker}}
> {{ role: route-container}}
> {{ host: 127.0.0.1}}
> {{ port: 22180}}
> {{ saslMechanisms: ANONYMOUS}}
> {{ *openProperties: "foo: bar,baz:foo, bar: 'Hello: you big, wonderful
> world!'"*}}
> {{}}}
>
> The resulting connection properties in the outgoing Open performative would
> include the following map entries:
> {{Symbol(foo): String(bar),}}
> {{Symbol(baz): String(foo),}}
> {{Symbol(bar): String(Hello: you big, wonderful world!)}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1656) Allow user-configured connection properties in the Open performative
[
https://issues.apache.org/jira/browse/DISPATCH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107538#comment-17107538
]
Ulf Lilleengen commented on DISPATCH-1656:
--
+1 to use JSON, it makes it a lot easier to generate the router config than
writing a generator specifically for this format.
> Allow user-configured connection properties in the Open performative
>
>
> Key: DISPATCH-1656
> URL: https://issues.apache.org/jira/browse/DISPATCH-1656
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.13.0
>
>
> This feature would add a new "openProperties" attribute to the
> org.apache.qpid.dispatch.connector and org.apache.qpid.dispatch.listener
> management entities. This new attribute is type string and is optional.
> If supplied it will consist of a series of one or more field entries
> separated by commas. A field entry is text in the form "key: value", where
> "key" that can be encoded as a valid AMQP 1.0 Symbol type. Value will be
> encoded as an AMQP 1.0 String type.
> The key or value text may contain spaces, colons or commas but must be
> enclosed in single quotes (see example below) if it does.
> Duplicate keys are NOT allowed.
> Key values that start with *qd.* or *x-opt-qd.* are reserved and must not be
> used.
> In addition, the following keys are reserved and must not be used:
> product
> version
> failover-server-list
> network-host
> port
> scheme
> hostname
> The openProperties keys and values will be merged into the connection
> properties field of the outgoing Open performative when establishing or
> accepting connections.
> The openProperties attribute is NOT allowed on connector or listener entities
> with roles of either "inter-router" or "edge".
> The openProperties attribute is NOT allowed on listener entities than enable
> http, i.e. http: true.
> Example:
> {{connector {}}
> {{ name: broker}}
> {{ role: route-container}}
> {{ host: 127.0.0.1}}
> {{ port: 22180}}
> {{ saslMechanisms: ANONYMOUS}}
> {{ *openProperties: "foo: bar,baz:foo, bar: 'Hello: you big, wonderful
> world!'"*}}
> {{}}}
>
> The resulting connection properties in the outgoing Open performative would
> include the following map entries:
> {{Symbol(foo): String(bar),}}
> {{Symbol(baz): String(foo),}}
> {{Symbol(bar): String(Hello: you big, wonderful world!)}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1656) Allow user-configured connection properties in the Open performative
[
https://issues.apache.org/jira/browse/DISPATCH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107415#comment-17107415
]
Keith Wall commented on DISPATCH-1656:
--
As the AMQP open field properties is of type fields[1] it feels odd that the
router configuration property restrict it to only string pairings. Would it
be possible if the openProperties string was stringified JSON that must be a
map? That way the user would be free to make use of other types. It would
mean you could lean on the well defined JSON parsing rule, escape syntax
(rather than having Dispatch having special parsing rules for this
configuration item).
That said, I am anticipating the EnMasse use-case will be name/string value
pairs.
[~lulf] any thoughts?
[1]
http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-open
> Allow user-configured connection properties in the Open performative
>
>
> Key: DISPATCH-1656
> URL: https://issues.apache.org/jira/browse/DISPATCH-1656
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.13.0
>
>
> This feature would add a new "openProperties" attribute to the
> org.apache.qpid.dispatch.connector and org.apache.qpid.dispatch.listener
> management entities. This new attribute is type string and is optional.
> If supplied it will consist of a series of one or more field entries
> separated by commas. A field entry is text in the form "key: value", where
> "key" that can be encoded as a valid AMQP 1.0 Symbol type. Value will be
> encoded as an AMQP 1.0 String type.
> The key or value text may contain spaces, colons or commas but must be
> enclosed in single quotes (see example below) if it does.
> Duplicate keys are NOT allowed.
> Key values that start with *qd.* or *x-opt-qd.* are reserved and must not be
> used.
> In addition, the following keys are reserved and must not be used:
> product
> version
> failover-server-list
> network-host
> port
> scheme
> hostname
> The openProperties keys and values will be merged into the connection
> properties field of the outgoing Open performative when establishing or
> accepting connections.
> The openProperties attribute is NOT allowed on connector or listener entities
> with roles of either "inter-router" or "edge".
> The openProperties attribute is NOT allowed on listener entities than enable
> http, i.e. http: true.
> Example:
> {{connector {}}
> {{ name: broker}}
> {{ role: route-container}}
> {{ host: 127.0.0.1}}
> {{ port: 22180}}
> {{ saslMechanisms: ANONYMOUS}}
> {{ *openProperties: "foo: bar,baz:foo, bar: 'Hello: you big, wonderful
> world!'"*}}
> {{}}}
>
> The resulting connection properties in the outgoing Open performative would
> include the following map entries:
> {{Symbol(foo): String(bar),}}
> {{Symbol(baz): String(foo),}}
> {{Symbol(bar): String(Hello: you big, wonderful world!)}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
