[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382456#comment-16382456
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit 5691122fc23588e9a8d02db561f154fc4f4ed155 in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=5691122 ]

DISPATCH-209 : ensure no dispositions lost


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>Priority: Major
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380665#comment-16380665
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit 2a5633c431c1769ba45eb7d42a714e24c8f70ece in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=2a5633c ]

DISPATCH-209 : additive topology tests


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>Priority: Major
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364354#comment-16364354
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit f256f675e63f17f3ade949033c14b93d4d6a146c in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=f256f67 ]

DISPATCH-209 : test dispositions over changing topology


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>Priority: Major
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271177#comment-16271177
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit 58ecc97bcc3d9f89f62d308d3c9b01027151f5e3 in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=58ecc97 ]

DISPATCH-209 : first topology test


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211486#comment-16211486
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit c895d1c440e9ad24d1ae4415f27e5f26ee26357e in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=c895d1c ]

DISPATCH-209 : parallel waypoint test


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199273#comment-16199273
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit d9e328e505e14fd3105a6c68ee01d1d107e93747 in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=d9e328e ]

DISPATCH-209 : single and serial waypoint tests


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171625#comment-16171625
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit 233f23f158e334ed14345892307773205b6395fb in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=233f23f ]

DISPATCH-209 : linkroute 3-mesh failover test


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170030#comment-16170030
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit 584a24cc74745e7f407fd5913ba3a0eec2b6b98c in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=584a24c ]

DISPATCH-209 : new 3-router pure linkroute tests


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166336#comment-16166336
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish commented on the issue:

https://github.com/apache/qpid-dispatch/pull/193
  
I need to improve error message in one place. brb.


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166335#comment-16166335
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/193


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164712#comment-16164712
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/193

DISPATCH-209 : fix fratricide problem in linkroute tests 15-18.

* linkroute tests had a fratricide problem, earlier ones interfering with 
later ones.  Now fixed by waiting at the end of each test until the network has 
forgotten my linkroute address.

* fixed problem that Ganesh found, in which I was using incorrect address 
for C route container listener.

* put in "STEP" comments in RoutingTest to make it easy to follow what 
happens.

* extended use of 'slop' in balanced tests to avoid 5-in-1000 failures -- 
and put in comment to remind me to figure that out, sometime.  maybe.  (low 
priority)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch linkroute_test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/193.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #193


commit eb30ce35e7e966d731f228ab6edf0958a4be04a9
Author: mick goulish 
Date:   2017-09-13T14:06:50Z

DISPATCH-209 : fix fratricide problem in linkroute tests 15-18.




> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164680#comment-16164680
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/192


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164681#comment-16164681
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish commented on the issue:

https://github.com/apache/qpid-dispatch/pull/192
  
closing to make way for new rebased PR.


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157452#comment-16157452
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish commented on the issue:

https://github.com/apache/qpid-dispatch/pull/192
  
Don't take this yet!   Ganesh just found my mistake in the router C and D 
route-container addrs.



> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157061#comment-16157061
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/192

DISPATCH-209 : linkroute tests with event_injector

modified the linkroute tests after talking to Ted -- including rework to 
use cool reactor::event_injector  technology.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch linkroute_test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/192.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #192


commit 3aecc303ec362b772036ae723cdd32d9825d7c1d
Author: mick goulish 
Date:   2017-09-07T15:09:47Z

DISPATCH-209 : linkroute tests with event_injector




> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155966#comment-16155966
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish commented on the issue:

https://github.com/apache/qpid-dispatch/pull/191
  
I will file a new PR with a single commit -- re-written to use 
reactor::event_injector  technology.



> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155964#comment-16155964
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/191


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150701#comment-16150701
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/191

DISPATCH-209 : initial commit for linkroute tests.

These tests do not send payload messages. They only attach senders,
and then look at where those link-attaches get routed to, in a three-
router linear network. (I will add mesh once we get this code checked in.)

Two tests are disabled because of some functionality improvement 
opportunities
that they uncovered.

I would like a review of these test because they are a little unusual.
Specifically, the 'scripting' feature that gets different behavior out of 
the base
test code.
Thanks!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch linkroute_test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #191


commit f2501047aba446e1609d7d3be97a1fbed3059a84
Author: mick goulish 
Date:   2017-09-01T15:08:08Z

DISPATCH-209 : initial commit for linkroute tests.




> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133596#comment-16133596
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit 8896446756dc158673c9222e8bdb13bf41bfbc97 in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=8896446 ]

DISPATCH-209 : add multicast {linear,mesh} tests


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132121#comment-16132121
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit b38e63edff3f2ba820a9ed7574a40df10a0b8cc9 in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=b38e63e ]

DISPATCH-209 : add closest_mesh test


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130283#comment-16130283
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit 835f14d0f775063c45912e907f0d2a2d51c9feca in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=835f14d ]

DISPATCH-209 : uniq addresses used by tests


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127583#comment-16127583
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit e0cdeaaf531fd0f03b187fb47df3f59c2d2fdb94 in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=e0cdeaa ]

DISPATCH-209 : add omit-middle-receiver test


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126264#comment-16126264
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit 9739f93e0d94e3297def7a06b6e5ca2d67c9e6a3 in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=9739f93 ]

DISPATCH-209 : change name and add new all-test topology


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080775#comment-16080775
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit 1f1089b1052080645160fd3701004d386e4432b1 in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=1f1089b ]

DISPATCH-209 -- linkroute test based on multi tenancy

(cherry picked from commit 63b2b52c739d3fb9e090861a68b568b6d09262fb)


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080686#comment-16080686
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/174


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078492#comment-16078492
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/174

DISPATCH-209 -- new linkroute test based on multi-tenant test

As you review, please look at not only correctness but  --- I am trying to 
make this linkroute test something that would be good for educating a user who 
is new to linkroute concepts (like I was) -- please also review for how well 
the test accomplishes that goal & make suggestions ...

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #174


commit fee3160c2f31657c94d5aa9eed5c6f31d92292eb
Author: mick goulish 
Date:   2017-07-07T18:20:27Z

DISPATCH-209 -- new linkroute test based on multi-tenant test




> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078448#comment-16078448
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish commented on the issue:

https://github.com/apache/qpid-dispatch/pull/170
  
new one coming shortly...


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078447#comment-16078447
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/170


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068248#comment-16068248
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/170#discussion_r124781204
  
--- Diff: tests/system_tests_three_routers.py ---
@@ -373,5 +433,189 @@ def run(self):
 
 
 
+
+class Entity(object):
+def __init__(self, status_code, status_description, attrs):
+self.status_code= status_code
+self.status_description = status_description
+self.attrs  = attrs
+
+def __getattr__(self, key):
+return self.attrs[key]
+
+
+
+
+class RouterProxy(object):
+def __init__(self, reply_addr):
+self.reply_addr = reply_addr
+
+def response(self, msg):
+ap = msg.properties
+return Entity(ap['statusCode'], ap['statusDescription'], msg.body)
+
+def read_address(self, name):
+ap = {'operation': 'READ', 'type': 
'org.apache.qpid.dispatch.router.address', 'name': name}
+return Message(properties=ap, reply_to=self.reply_addr)
+
+def query_addresses(self):
+ap = {'operation': 'QUERY', 'type': 
'org.apache.qpid.dispatch.router.address'}
+return Message(properties=ap, reply_to=self.reply_addr)
+
+
+
+
+class PollTimeout(object):
+def __init__(self, parent):
+self.parent = parent
+
+def on_timer_task(self, event):
+self.parent.poll_timeout()
+
+
+
+class Timeout(object):
+def __init__(self, parent):
+self.parent = parent
+
+def on_timer_task(self, event):
+self.parent.timeout()
+
+
+class LinkRoute ( MessagingHandler ):
+
+"""
+Set up and use a link-route, to send a message this way:
+receiver <--- A <--- B <--- C <--- sender
--- End diff --

More information is needed here.   Which endpoint is the initiator of the 
link?  Which endpoint is connected as the route_container?


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068246#comment-16068246
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/170#discussion_r124780487
  
--- Diff: tests/system_tests_three_routers.py ---
@@ -373,5 +433,189 @@ def run(self):
 
 
 
+
+class Entity(object):
+def __init__(self, status_code, status_description, attrs):
+self.status_code= status_code
+self.status_description = status_description
+self.attrs  = attrs
+
+def __getattr__(self, key):
+return self.attrs[key]
+
+
+
+
+class RouterProxy(object):
+def __init__(self, reply_addr):
+self.reply_addr = reply_addr
+
+def response(self, msg):
+ap = msg.properties
+return Entity(ap['statusCode'], ap['statusDescription'], msg.body)
+
+def read_address(self, name):
+ap = {'operation': 'READ', 'type': 
'org.apache.qpid.dispatch.router.address', 'name': name}
+return Message(properties=ap, reply_to=self.reply_addr)
+
+def query_addresses(self):
+ap = {'operation': 'QUERY', 'type': 
'org.apache.qpid.dispatch.router.address'}
+return Message(properties=ap, reply_to=self.reply_addr)
+
+
+
+
+class PollTimeout(object):
+def __init__(self, parent):
+self.parent = parent
+
+def on_timer_task(self, event):
+self.parent.poll_timeout()
+
+
+
+class Timeout(object):
+def __init__(self, parent):
+self.parent = parent
+
+def on_timer_task(self, event):
+self.parent.timeout()
+
+
+class LinkRoute ( MessagingHandler ):
+
+"""
+Set up and use a link-route, to send a message this way:
+receiver <--- A <--- B <--- C <--- sender
+
+Check for appearance of the link-route at router A with a
+technique that is appropriate to the 'proactor' style,
+i.e. do not take control away from the proactor for an extended
+period of time.
+"""
+
+def __init__ ( self, route_container, linkroute_prefix, 
route_check_address, send_address ):
+super(LinkRoute, self).__init__(prefetch=0)
+self.route_container= route_container
+self.send_address   = send_address
+self.linkroute_prefix   = linkroute_prefix
+self.route_check_address= route_check_address
+self.true_statement = "This IS the message you are looking 
for."
+self.error  = None
+self.send_connection= None
+self.recv_connection= None
+self.route_check_connection = None
+self.route_check_sender = None
+self.sender = None
+self.route_check_timer  = None
+self.route_check_receiver   = None
+self.count  = 1
+self.sent   = 0
+self.route_checks_sent  = 0
+
+
+def bail ( self, error_text ) :
+self.error = error_text
+self.recv_connection.close()
+self.route_check_connection.close()
+self.send_connection.close()
+self.timer.cancel()
+if self.route_check_timer :
+self.route_check_timer.cancel()
+self.route_check_timer = None
+
+
+def timeout(self):
+self.bail ( "Timeout Expired" )
+
+
+def poll_timeout ( self ) :
+self.poll()
+
+
+def on_start(self, event):
+# Iff this timer expires, the test fails.
+self.timer = event.reactor.schedule ( TIMEOUT, Timeout(self) )
+
+# At startup, create only the receivers and the sender that checks 
for
+# the route being ready.  Creation of the payload message sender
+# has to wait until we know the address is available, to avoid a
+# 'no route to destination' error.
+self.recv_connection = event.container.connect ( 
self.route_container )
+
+self.route_check_connection  = event.container.connect ( 
self.route_check_address )
+self.route_check_receiver = event.container.create_receiver ( 
self.route_check_connection,
+
dynamic=True
+  )
+self.route_check_sender = event.container.create_sender ( 

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068247#comment-16068247
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/170#discussion_r124780999
  
--- Diff: tests/system_tests_three_routers.py ---
@@ -373,5 +433,189 @@ def run(self):
 
 
 
+
+class Entity(object):
+def __init__(self, status_code, status_description, attrs):
+self.status_code= status_code
+self.status_description = status_description
+self.attrs  = attrs
+
+def __getattr__(self, key):
+return self.attrs[key]
+
+
+
+
+class RouterProxy(object):
+def __init__(self, reply_addr):
+self.reply_addr = reply_addr
+
+def response(self, msg):
+ap = msg.properties
+return Entity(ap['statusCode'], ap['statusDescription'], msg.body)
+
+def read_address(self, name):
+ap = {'operation': 'READ', 'type': 
'org.apache.qpid.dispatch.router.address', 'name': name}
+return Message(properties=ap, reply_to=self.reply_addr)
+
+def query_addresses(self):
+ap = {'operation': 'QUERY', 'type': 
'org.apache.qpid.dispatch.router.address'}
+return Message(properties=ap, reply_to=self.reply_addr)
+
+
+
+
+class PollTimeout(object):
+def __init__(self, parent):
+self.parent = parent
+
+def on_timer_task(self, event):
+self.parent.poll_timeout()
+
+
+
+class Timeout(object):
+def __init__(self, parent):
+self.parent = parent
+
+def on_timer_task(self, event):
+self.parent.timeout()
+
+
+class LinkRoute ( MessagingHandler ):
+
+"""
+Set up and use a link-route, to send a message this way:
+receiver <--- A <--- B <--- C <--- sender
+
+Check for appearance of the link-route at router A with a
+technique that is appropriate to the 'proactor' style,
+i.e. do not take control away from the proactor for an extended
+period of time.
+"""
+
+def __init__ ( self, route_container, linkroute_prefix, 
route_check_address, send_address ):
+super(LinkRoute, self).__init__(prefetch=0)
+self.route_container= route_container
+self.send_address   = send_address
+self.linkroute_prefix   = linkroute_prefix
+self.route_check_address= route_check_address
+self.true_statement = "This IS the message you are looking 
for."
+self.error  = None
+self.send_connection= None
+self.recv_connection= None
+self.route_check_connection = None
+self.route_check_sender = None
+self.sender = None
+self.route_check_timer  = None
+self.route_check_receiver   = None
+self.count  = 1
+self.sent   = 0
+self.route_checks_sent  = 0
+
+
+def bail ( self, error_text ) :
+self.error = error_text
+self.recv_connection.close()
+self.route_check_connection.close()
+self.send_connection.close()
+self.timer.cancel()
+if self.route_check_timer :
+self.route_check_timer.cancel()
+self.route_check_timer = None
+
+
+def timeout(self):
+self.bail ( "Timeout Expired" )
+
+
+def poll_timeout ( self ) :
+self.poll()
+
+
+def on_start(self, event):
+# Iff this timer expires, the test fails.
+self.timer = event.reactor.schedule ( TIMEOUT, Timeout(self) )
+
+# At startup, create only the receivers and the sender that checks 
for
+# the route being ready.  Creation of the payload message sender
+# has to wait until we know the address is available, to avoid a
+# 'no route to destination' error.
+self.recv_connection = event.container.connect ( 
self.route_container )
+
+self.route_check_connection  = event.container.connect ( 
self.route_check_address )
+self.route_check_receiver = event.container.create_receiver ( 
self.route_check_connection,
+
dynamic=True
+  )
+self.route_check_sender = event.container.create_sender ( 

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067839#comment-16067839
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/170

DISPATCH-209 : linkroute test better for proactor

I stole code from LinkRoute test in multi tenancy system test -- to make my 
linkroute test better for proactor -- don't hog control so long while checking 
for linkroute address to appear at the far router.

All 4 tests survived a 100-iteration test on my machine.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/170.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #170


commit f7437644d1a938ab3220aa38dccbdc2627ffaefc
Author: mick goulish 
Date:   2017-06-29T06:26:17Z

DISPATCH-209 : linkroute test better for proactor




> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067835#comment-16067835
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/134


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066980#comment-16066980
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/165


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048251#comment-16048251
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/165#discussion_r121764581
  
--- Diff: tests/system_tests_three_routers.py ---
@@ -335,36 +417,124 @@ def on_start ( self, event ):
 self.client_receiver   = 
event.container.create_receiver(self.client_connection, None, dynamic=True)
 
 
+def on_sendable ( self, event ):
+if event.sender == self.sender :
+while event.sender.credit > 0 and self.n_sent < 
self.n_expected:
+# We send to server, and tell it how to reply to the 
client.
+reply_to_addr = self.client_receiver.remote_source.address
 
-def on_sendable(self, event):
-while event.sender.credit > 0 and self.n_sent < self.n_expected:
-# We send to server, and tell it how to reply to the client.
-reply_to_addr = self.client_receiver.remote_source.address
-
-request = Message ( body=self.n_sent,
-address=self.dest,
-reply_to = reply_to_addr )
-event.sender.send ( request )
-self.n_sent += 1
+request = Message ( body=self.n_sent,
+address=self.dest,
+reply_to = reply_to_addr )
+event.sender.send ( request )
+self.n_sent += 1
 
 
-def on_message(self, event):
+def on_message ( self, event ):
 # Server gets a request and responds to
 # the address that is embedded in the message.
 if event.receiver == self.server_receiver :
-self.server_sender.send ( 
Message(address=event.message.reply_to,
-  body="Reply hazy, try again later.") 
)
+# pdb.set_trace()
 self.received_by_server += 1
+msg = Message(address=event.message.reply_to, body="Reply 
hazy, try again later.")
+self.server_sender.send ( msg )
 
 # Client gets a response and counts it.
 elif event.receiver == self.client_receiver :
 self.received_by_client += 1
 if self.received_by_client == self.n_expected:
-self.timer.cancel()
-self.server_receiver.close()
-self.client_receiver.close()
-self.client_connection.close()
-self.server_connection.close()
+self.shutdown ( )
+
+
+def run(self):
+Container(self).run()
+
+
+
+
+
+class LinkRoute ( MessagingHandler ):
+
+"""
+Set up and use a link-route, to send a message this way:
+receiver <--- A <--- B <--- C <--- sender
+"""
+
+def __init__ ( self, addr_listening_for_route_container, 
linkroute_prefix, qdstat_address, send_address ):
+super(LinkRoute, self).__init__(prefetch=0)
+self.addr_listening_for_route_container = 
addr_listening_for_route_container
+self.send_address = send_address
+self.linkroute_prefix = linkroute_prefix
+self.qdstat_address = qdstat_address
+self.error  = None
+self.send_connection = None
+self.recv_connection = None
+self.false_statement = "This is not the message you are looking 
for."
+
+
+def timeout(self):
+self.error = "Timeout Expired"
+self.shutdown ( )
+
+
+def shutdown ( self ) :
+self.recv_connection.close()
+self.send_connection.close()
+self.timer.cancel()
+self.timer = None
+
+
+def on_start(self, event):
+# Iff this timer expires, the test fails.
+self.timer = event.reactor.schedule ( 5, Timeout(self) )
+
+# Create the receiver only at start time.
+# Sender-creation has to wait until we know that the address is 
available.
+self.recv_connection = event.container.connect ( 
self.addr_listening_for_route_container )
+self.receiver = event.container.create_receiver ( 
self.recv_connection, None, dynamic=True )
+
+
+def on_link_opening ( self, event ):
+if event.receiver:
+event.receiver.flow(1)
+
+
+def on_connection_remote_open ( self, event ):
--- End diff --

Doing this blocking, synchronous operation in a reactive 

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048253#comment-16048253
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/165#discussion_r121765790
  
--- Diff: tests/system_tests_three_routers.py ---
@@ -335,36 +417,124 @@ def on_start ( self, event ):
 self.client_receiver   = 
event.container.create_receiver(self.client_connection, None, dynamic=True)
 
 
+def on_sendable ( self, event ):
+if event.sender == self.sender :
+while event.sender.credit > 0 and self.n_sent < 
self.n_expected:
+# We send to server, and tell it how to reply to the 
client.
+reply_to_addr = self.client_receiver.remote_source.address
 
-def on_sendable(self, event):
-while event.sender.credit > 0 and self.n_sent < self.n_expected:
-# We send to server, and tell it how to reply to the client.
-reply_to_addr = self.client_receiver.remote_source.address
-
-request = Message ( body=self.n_sent,
-address=self.dest,
-reply_to = reply_to_addr )
-event.sender.send ( request )
-self.n_sent += 1
+request = Message ( body=self.n_sent,
+address=self.dest,
+reply_to = reply_to_addr )
+event.sender.send ( request )
+self.n_sent += 1
 
 
-def on_message(self, event):
+def on_message ( self, event ):
 # Server gets a request and responds to
 # the address that is embedded in the message.
 if event.receiver == self.server_receiver :
-self.server_sender.send ( 
Message(address=event.message.reply_to,
-  body="Reply hazy, try again later.") 
)
+# pdb.set_trace()
 self.received_by_server += 1
+msg = Message(address=event.message.reply_to, body="Reply 
hazy, try again later.")
+self.server_sender.send ( msg )
 
 # Client gets a response and counts it.
 elif event.receiver == self.client_receiver :
 self.received_by_client += 1
 if self.received_by_client == self.n_expected:
-self.timer.cancel()
-self.server_receiver.close()
-self.client_receiver.close()
-self.client_connection.close()
-self.server_connection.close()
+self.shutdown ( )
+
+
+def run(self):
+Container(self).run()
+
+
+
+
+
+class LinkRoute ( MessagingHandler ):
+
+"""
+Set up and use a link-route, to send a message this way:
+receiver <--- A <--- B <--- C <--- sender
+"""
+
+def __init__ ( self, addr_listening_for_route_container, 
linkroute_prefix, qdstat_address, send_address ):
+super(LinkRoute, self).__init__(prefetch=0)
+self.addr_listening_for_route_container = 
addr_listening_for_route_container
+self.send_address = send_address
+self.linkroute_prefix = linkroute_prefix
+self.qdstat_address = qdstat_address
+self.error  = None
+self.send_connection = None
+self.recv_connection = None
+self.false_statement = "This is not the message you are looking 
for."
+
+
+def timeout(self):
+self.error = "Timeout Expired"
+self.shutdown ( )
+
+
+def shutdown ( self ) :
+self.recv_connection.close()
+self.send_connection.close()
+self.timer.cancel()
+self.timer = None
+
+
+def on_start(self, event):
+# Iff this timer expires, the test fails.
+self.timer = event.reactor.schedule ( 5, Timeout(self) )
+
+# Create the receiver only at start time.
+# Sender-creation has to wait until we know that the address is 
available.
+self.recv_connection = event.container.connect ( 
self.addr_listening_for_route_container )
+self.receiver = event.container.create_receiver ( 
self.recv_connection, None, dynamic=True )
+
+
+def on_link_opening ( self, event ):
--- End diff --

When handing an unsolicited incoming link-attach, this handler must copy 
the addresses from the remote to the local.  If you trace the operation of this 
test, you will see that the returning 

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048254#comment-16048254
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/165#discussion_r121760200
  
--- Diff: tests/system_tests_three_routers.py ---
@@ -335,36 +417,124 @@ def on_start ( self, event ):
 self.client_receiver   = 
event.container.create_receiver(self.client_connection, None, dynamic=True)
 
 
+def on_sendable ( self, event ):
+if event.sender == self.sender :
+while event.sender.credit > 0 and self.n_sent < 
self.n_expected:
+# We send to server, and tell it how to reply to the 
client.
+reply_to_addr = self.client_receiver.remote_source.address
 
-def on_sendable(self, event):
-while event.sender.credit > 0 and self.n_sent < self.n_expected:
-# We send to server, and tell it how to reply to the client.
-reply_to_addr = self.client_receiver.remote_source.address
-
-request = Message ( body=self.n_sent,
-address=self.dest,
-reply_to = reply_to_addr )
-event.sender.send ( request )
-self.n_sent += 1
+request = Message ( body=self.n_sent,
+address=self.dest,
+reply_to = reply_to_addr )
+event.sender.send ( request )
+self.n_sent += 1
 
 
-def on_message(self, event):
+def on_message ( self, event ):
 # Server gets a request and responds to
 # the address that is embedded in the message.
 if event.receiver == self.server_receiver :
-self.server_sender.send ( 
Message(address=event.message.reply_to,
-  body="Reply hazy, try again later.") 
)
+# pdb.set_trace()
 self.received_by_server += 1
+msg = Message(address=event.message.reply_to, body="Reply 
hazy, try again later.")
+self.server_sender.send ( msg )
 
 # Client gets a response and counts it.
 elif event.receiver == self.client_receiver :
 self.received_by_client += 1
 if self.received_by_client == self.n_expected:
-self.timer.cancel()
-self.server_receiver.close()
-self.client_receiver.close()
-self.client_connection.close()
-self.server_connection.close()
+self.shutdown ( )
+
+
+def run(self):
+Container(self).run()
+
+
+
+
+
+class LinkRoute ( MessagingHandler ):
+
+"""
+Set up and use a link-route, to send a message this way:
+receiver <--- A <--- B <--- C <--- sender
+"""
+
+def __init__ ( self, addr_listening_for_route_container, 
linkroute_prefix, qdstat_address, send_address ):
+super(LinkRoute, self).__init__(prefetch=0)
+self.addr_listening_for_route_container = 
addr_listening_for_route_container
+self.send_address = send_address
+self.linkroute_prefix = linkroute_prefix
+self.qdstat_address = qdstat_address
+self.error  = None
+self.send_connection = None
+self.recv_connection = None
+self.false_statement = "This is not the message you are looking 
for."
--- End diff --

For anyone trying to understand how this test works, this text is 
misleading.


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048252#comment-16048252
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/165#discussion_r121760979
  
--- Diff: tests/system_tests_three_routers.py ---
@@ -335,36 +417,124 @@ def on_start ( self, event ):
 self.client_receiver   = 
event.container.create_receiver(self.client_connection, None, dynamic=True)
 
 
+def on_sendable ( self, event ):
+if event.sender == self.sender :
+while event.sender.credit > 0 and self.n_sent < 
self.n_expected:
+# We send to server, and tell it how to reply to the 
client.
+reply_to_addr = self.client_receiver.remote_source.address
 
-def on_sendable(self, event):
-while event.sender.credit > 0 and self.n_sent < self.n_expected:
-# We send to server, and tell it how to reply to the client.
-reply_to_addr = self.client_receiver.remote_source.address
-
-request = Message ( body=self.n_sent,
-address=self.dest,
-reply_to = reply_to_addr )
-event.sender.send ( request )
-self.n_sent += 1
+request = Message ( body=self.n_sent,
+address=self.dest,
+reply_to = reply_to_addr )
+event.sender.send ( request )
+self.n_sent += 1
 
 
-def on_message(self, event):
+def on_message ( self, event ):
 # Server gets a request and responds to
 # the address that is embedded in the message.
 if event.receiver == self.server_receiver :
-self.server_sender.send ( 
Message(address=event.message.reply_to,
-  body="Reply hazy, try again later.") 
)
+# pdb.set_trace()
 self.received_by_server += 1
+msg = Message(address=event.message.reply_to, body="Reply 
hazy, try again later.")
+self.server_sender.send ( msg )
 
 # Client gets a response and counts it.
 elif event.receiver == self.client_receiver :
 self.received_by_client += 1
 if self.received_by_client == self.n_expected:
-self.timer.cancel()
-self.server_receiver.close()
-self.client_receiver.close()
-self.client_connection.close()
-self.server_connection.close()
+self.shutdown ( )
+
+
+def run(self):
+Container(self).run()
+
+
+
+
+
+class LinkRoute ( MessagingHandler ):
+
+"""
+Set up and use a link-route, to send a message this way:
+receiver <--- A <--- B <--- C <--- sender
+"""
+
+def __init__ ( self, addr_listening_for_route_container, 
linkroute_prefix, qdstat_address, send_address ):
+super(LinkRoute, self).__init__(prefetch=0)
+self.addr_listening_for_route_container = 
addr_listening_for_route_container
+self.send_address = send_address
+self.linkroute_prefix = linkroute_prefix
+self.qdstat_address = qdstat_address
+self.error  = None
+self.send_connection = None
+self.recv_connection = None
+self.false_statement = "This is not the message you are looking 
for."
+
+
+def timeout(self):
+self.error = "Timeout Expired"
+self.shutdown ( )
+
+
+def shutdown ( self ) :
+self.recv_connection.close()
+self.send_connection.close()
+self.timer.cancel()
+self.timer = None
+
+
+def on_start(self, event):
+# Iff this timer expires, the test fails.
+self.timer = event.reactor.schedule ( 5, Timeout(self) )
+
+# Create the receiver only at start time.
+# Sender-creation has to wait until we know that the address is 
available.
+self.recv_connection = event.container.connect ( 
self.addr_listening_for_route_container )
+self.receiver = event.container.create_receiver ( 
self.recv_connection, None, dynamic=True )
--- End diff --

Why is this receiver here?  It serves no purpose in the test.


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: 

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048255#comment-16048255
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/165#discussion_r121759130
  
--- Diff: tests/system_tests_three_routers.py ---
@@ -96,10 +124,24 @@ def router ( name, connection_1, connection_2=None ):
  'port': inter_router_port_A,
  'verifyHostName': 'no'
}
+   ),
+   ( 'linkRoute',
+ { 'prefix': cls.linkroute_prefix,
+   'containerId': 'QDR.A',
--- End diff --

These containerId lines have no effect and are misleading.


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033008#comment-16033008
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish commented on the issue:

https://github.com/apache/qpid-dispatch/pull/165
  
WAIT

I just had a failure on my tests while running them in the context of a 
full "make check" -- investigating.


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031832#comment-16031832
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish commented on the issue:

https://github.com/apache/qpid-dispatch/pull/165
  
I had an 8-in-100 failure rate suddenly appear on test #3 -- so... I made 
on_sendable handling smarter and that gave me 4-in-100 failure rate -- all on 
teardown only.I then changed a little bit how all four tests shut down -- 
borrowing an interesting line from another test (null out the timer after 
clearing it) -- and now I have  0 failures in 400 iterations -- also no 
teardown failures.


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029957#comment-16029957
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/165

DISPATCH-209 : add a linear 3-router linkroute test

test #4 -- 3-router link-route 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/165.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #165


commit 06b24e87c77eb1136eb167d504d34424bf4d4e81
Author: mick goulish 
Date:   2017-05-30T19:02:29Z

DISPATCH-209 : add a linear 3-router linkroute test




> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
> Fix For: 1.0.0
>
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022908#comment-16022908
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/163


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022907#comment-16022907
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit 5fd599d4df3e0dfef377419636e5fffe9537b296 in qpid-dispatch's branch 
refs/heads/master from [~mgoulish]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=5fd599d ]

DISPATCH-209 -- three-router test #3 dynamic reply-to. This closes #163

(cherry picked from commit b66a5c7620409252287ae2e3993a17c56758beae)


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014537#comment-16014537
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/163

DISPATCH-209 -- three-router test #3 dynamic reply-to

New test for dynamic reply-to  -- simulation of request-response server and 
client.

test #3 survived a 1000-iteration run with 7 failures, all in teardown.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #163


commit a07122b349def57cd6d97f85f59bd7f5c8577cf3
Author: mick goulish 
Date:   2017-05-17T18:12:40Z

DISPATCH-209 -- three-router test #3 dynamic reply-to




> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012444#comment-16012444
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish commented on the issue:

https://github.com/apache/qpid-dispatch/pull/162
  
closing to replace with new PR containing 3rd test.


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012443#comment-16012443
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/162


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004693#comment-16004693
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/162

DISPATCH-209 -- revamp of second three-router test.

This new version of three-router test #2 survived a 1000-iteration test 
with no failures.

The main changes are

  1. handle on_sendable event and the sending of messages better.  (Before 
I was only sending 1 message per on_sendable event, instead of sending until 
credit exhausteed.)

  2. indirectly detect when the network is not yet ready for me to send (in 
spite of on_sendable event) and pause for 1 second to allow it to propagate 
endpoint info everywhere.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #162






> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799592#comment-15799592
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/134#discussion_r94681419
  
--- Diff: tests/system_tests_three_routers.py ---
@@ -220,6 +225,70 @@ def run(self):
 Container(self).run()
  
  
+class DynamicRequestResponseTest(MessagingHandler):
+def __init__(self, address1, address2):
+super(DynamicRequestResponseTest, self).__init__(prefetch=0)
+self.address1   = address1
+self.address2   = address2
+self.dest   = "closest.dynamicRequestResponse"
+self.error  = None
+self.sender = None
+self.server_receiver = None
+self.client_receiver = None
+self.n_expected = 10
+self.n_sent = 0
+self.n_received = 0
+self.n_accepted = 0
+ 
+def timeout(self):
+self.error = "Timeout Expired %d messages received." % 
self.n_received
+self.client_connection.close()
+self.server_connection.close()
+ 
+def on_released(self, event):
+self.n_sent -= 1
+time.sleep(0.1)
+
+def on_start(self, event):
+self.timer = event.reactor.schedule(5, Timeout(self))
+self.client_connection = event.container.connect(self.address1)
+self.server_connection = event.container.connect(self.address2)
+self.server_receiver = 
event.container.create_receiver(self.server_connection, self.dest)
+self.client_receiver = 
event.container.create_receiver(self.client_connection, None, dynamic=True)
+self.server_receiver.flow(self.n_expected)
+self.client_receiver.flow(self.n_expected)
+self.sender = 
event.container.create_sender(self.client_connection, None)
+ 
+def on_sendable(self, event):
+if self.n_sent < self.n_expected:
+# We send to server, and ask it to reply to client.
+request = Message(body=self.n_sent, address=self.dest, 
reply_to=self.client_receiver.remote_source.address)
+event.sender.send(request)
+self.n_sent += 1
+ 
+def on_accepted(self, event):
+self.n_accepted += 1
+ 
+def on_message(self, event):
+
+# Receiver gets a message and replies to client.
+if event.receiver == self.server_receiver :
+self.sender.send ( Message(address=event.message.reply_to, 
body="Reply hazy, try again later.") )
--- End diff --

The server is sending its responses on the client's sender!


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799589#comment-15799589
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/134#discussion_r94648607
  
--- Diff: tests/system_tests_three_routers.py ---
@@ -220,6 +225,70 @@ def run(self):
 Container(self).run()
  
  
+class DynamicRequestResponseTest(MessagingHandler):
+def __init__(self, address1, address2):
+super(DynamicRequestResponseTest, self).__init__(prefetch=0)
+self.address1   = address1
+self.address2   = address2
+self.dest   = "closest.dynamicRequestResponse"
+self.error  = None
+self.sender = None
+self.server_receiver = None
+self.client_receiver = None
+self.n_expected = 10
+self.n_sent = 0
+self.n_received = 0
+self.n_accepted = 0
+ 
+def timeout(self):
+self.error = "Timeout Expired %d messages received." % 
self.n_received
+self.client_connection.close()
+self.server_connection.close()
+ 
+def on_released(self, event):
+self.n_sent -= 1
+time.sleep(0.1)
+
+def on_start(self, event):
+self.timer = event.reactor.schedule(5, Timeout(self))
+self.client_connection = event.container.connect(self.address1)
+self.server_connection = event.container.connect(self.address2)
+self.server_receiver = 
event.container.create_receiver(self.server_connection, self.dest)
+self.client_receiver = 
event.container.create_receiver(self.client_connection, None, dynamic=True)
+self.server_receiver.flow(self.n_expected)
+self.client_receiver.flow(self.n_expected)
+self.sender = 
event.container.create_sender(self.client_connection, None)
+ 
+def on_sendable(self, event):
+if self.n_sent < self.n_expected:
+# We send to server, and ask it to reply to client.
+request = Message(body=self.n_sent, address=self.dest, 
reply_to=self.client_receiver.remote_source.address)
--- End diff --

There's a race condition here.  What if you get credit on the sender before 
the dynamic receiver is fully attached?


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799591#comment-15799591
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/134#discussion_r94648343
  
--- Diff: tests/system_tests_three_routers.py ---
@@ -220,6 +225,70 @@ def run(self):
 Container(self).run()
  
  
+class DynamicRequestResponseTest(MessagingHandler):
+def __init__(self, address1, address2):
+super(DynamicRequestResponseTest, self).__init__(prefetch=0)
+self.address1   = address1
+self.address2   = address2
+self.dest   = "closest.dynamicRequestResponse"
+self.error  = None
+self.sender = None
+self.server_receiver = None
+self.client_receiver = None
+self.n_expected = 10
+self.n_sent = 0
+self.n_received = 0
+self.n_accepted = 0
+ 
+def timeout(self):
+self.error = "Timeout Expired %d messages received." % 
self.n_received
--- End diff --

You should include all of the counters here.  If the test times out, you'll 
want as much information as you can get.


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799590#comment-15799590
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/134#discussion_r94648211
  
--- Diff: tests/system_tests_three_routers.py ---
@@ -90,6 +90,11 @@ def test_02_anonymous_sender(self):
 test.run()
 self.assertEqual(None, test.error)
 
+def test_03_dynamic_request_response(self):
--- End diff --

You can get multiple tests in one here just by replicating this test with 
different router addresses.  For example, you could have three tests:  0->0, 
0->1, 0->2.


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770076#comment-15770076
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/134#discussion_r93624041
  
--- Diff: tests/system_tests_three_routers.py ---
@@ -220,6 +225,71 @@ def run(self):
 Container(self).run()
  
  
+class DynamicRequestResponseTest(MessagingHandler):
+def __init__(self, address1, address2):
+super(DynamicRequestResponseTest, self).__init__(prefetch=0)
+self.address1   = address1
+self.address2   = address2
+self.dest   = "closest.whatever"
+self.error  = None
+self.sender = None
+self.server_receiver = None
+self.client_receiver = None
+self.n_expected = 10
+self.n_sent = 0
+self.n_received = 0
+self.n_accepted = 0
+ 
+def timeout(self):
+self.error = "Timeout Expired %d messages received." % 
self.n_received
+self.conn1.close()
+self.conn2.close()
+ 
+def on_released(self, event):
+self.n_sent -= 1
+time.sleep(0.1)
+
+def on_link_opened(self, event):
+if event.receiver:
+self.sender = event.container.create_sender(self.conn1, None)
--- End diff --

You are going to get two on_link_opened events for receivers.  This means 
you are creating the same sender twice.  This one sender is used for both 
client-send and server-send operations.


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770077#comment-15770077
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/134#discussion_r93624286
  
--- Diff: tests/system_tests_three_routers.py ---
@@ -220,6 +225,71 @@ def run(self):
 Container(self).run()
  
  
+class DynamicRequestResponseTest(MessagingHandler):
+def __init__(self, address1, address2):
+super(DynamicRequestResponseTest, self).__init__(prefetch=0)
+self.address1   = address1
+self.address2   = address2
+self.dest   = "closest.whatever"
+self.error  = None
+self.sender = None
+self.server_receiver = None
+self.client_receiver = None
+self.n_expected = 10
+self.n_sent = 0
+self.n_received = 0
+self.n_accepted = 0
+ 
+def timeout(self):
+self.error = "Timeout Expired %d messages received." % 
self.n_received
+self.conn1.close()
+self.conn2.close()
+ 
+def on_released(self, event):
+self.n_sent -= 1
+time.sleep(0.1)
+
+def on_link_opened(self, event):
+if event.receiver:
+self.sender = event.container.create_sender(self.conn1, None)
+
+def on_start(self, event):
+self.timer = event.reactor.schedule(5, Timeout(self))
+self.conn1 = event.container.connect(self.address1)
+self.conn2 = event.container.connect(self.address2)
+self.server_receiver = event.container.create_receiver(self.conn2, 
self.dest)
+self.client_receiver = event.container.create_receiver(self.conn2, 
None, dynamic=True)
--- End diff --

Both the client and server receivers are established on the same 
connection.  Is this what was intended?  I would think that one connection 
would be the client and the other the server.


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768108#comment-15768108
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/134

DISPATCH-209 : dynamic request response test

phew.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch DISPATCH-209-H

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #134


commit 19612e54caa329a7647389389d11a88c7c358853
Author: mick 
Date:   2016-12-21T20:38:30Z

DISPATCH-209 : dynamic request response test




> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761281#comment-15761281
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit 3086de102ff125fc9a218c15140db4f858210da9 in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=3086de1 ]

DISPATCH-209 - From Mick Goulish - Added anonymous sender for 3-router test.
This closes #126


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761282#comment-15761282
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/126


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748593#comment-15748593
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/126

DISPATCH-209 -- anonymous sender test.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch DISPATCH-209-C

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #126


commit 3218f125db05ef2850bf674541ecf91b0fea4912
Author: mick 
Date:   2016-12-14T15:12:59Z

DISPATCH-209 -- anonymous sender test.




> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15742851#comment-15742851
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish commented on the issue:

https://github.com/apache/qpid-dispatch/pull/123
  
This is not working like I thought.  It was using the address from the 
previous test.  When I corrected that, it no workee.   Looking into it...


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15742846#comment-15742846
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user mgoulish closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/123


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732431#comment-15732431
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/123

DISPATCH-209 : anonymous sender test

This test started working as I originally expected it to, after I recreated 
this branch from new upstream code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch DISPATCH-209-B

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #123


commit 6dcc97d086949e3f96b5a6948388e40b5491308b
Author: mick 
Date:   2016-12-07T22:21:49Z

DISPATCH-209 : anonymous sender test




> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729937#comment-15729937
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/121


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729936#comment-15729936
 ] 

ASF subversion and git services commented on DISPATCH-209:
--

Commit 49fe290d65a3517a9927586301420842df654f12 in qpid-dispatch's branch 
refs/heads/master from mick
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=49fe290 ]

DISPATCH-209 : targeted sender test


> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729920#comment-15729920
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-

GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/121

DISPATCH-209 : targeted sender test

second try -- deleted previous branch because it went mad and tried to take 
over world.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch DISPATCH-209-B

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #121


commit 49fe290d65a3517a9927586301420842df654f12
Author: mick 
Date:   2016-12-07T21:00:26Z

DISPATCH-209 : targeted sender test




> Three+ router test is needed in the system test suite.
> --
>
> Key: DISPATCH-209
> URL: https://issues.apache.org/jira/browse/DISPATCH-209
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Tests
>Reporter: Ted Ross
>Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org