[jira] [Commented] (DISPATCH-2328) c_unittests failing on RHEL 7
[
https://issues.apache.org/jira/browse/DISPATCH-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493579#comment-17493579
]
ASF subversion and git services commented on DISPATCH-2328:
---
Commit 50ee1d2e6a0ec9497b56024da41717e8423f11ad in qpid-dispatch's branch
refs/heads/dependabot/npm_and_yarn/console/react/react-scripts-5.0.0 from Jiri
Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=50ee1d2 ]
DISPATCH-2328: detect _FORTIFY_SOURCE in c_unittests and bail out (#1514)
> c_unittests failing on RHEL 7
> -
>
> Key: DISPATCH-2328
> URL: https://issues.apache.org/jira/browse/DISPATCH-2328
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
> {noformat}
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:42:
> TEST CASE: test_safe_snprintf
> vsnprintf failure (_STUB_)
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:94:
> ERROR: CHECK( 0 == len ) is NOT correct!
> values: CHECK( 0 == 9 )
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:95:
> ERROR: CHECK( '\0' == output[0] ) is NOT correct!
> values: CHECK( 0 == 115 ) {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2328) c_unittests failing on RHEL 7
[
https://issues.apache.org/jira/browse/DISPATCH-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490546#comment-17490546
]
ASF GitHub Bot commented on DISPATCH-2328:
--
jiridanek commented on a change in pull request #1514:
URL: https://github.com/apache/qpid-dispatch/pull/1514#discussion_r804152531
##
File path: tests/c_unittests/CMakeLists.txt
##
@@ -20,7 +20,7 @@
# -fno-inline: just to be extra sure, no particular reason so far
# -fno-builtin: GCC would optimize e.g. abs() and we would not be able to stub
# -fno-stack-protector:
https://stackoverflow.com/questions/12201625/disable-using-sprintf-chk
-# -D_FORTIFY_SOURCE=0: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
+# -U_FORTIFY_SOURCE: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_STANDARD_FLAGS} -fno-inline
-fno-builtin -fno-stack-protector -U_FORTIFY_SOURCE")
Review comment:
while I think that setting `_FORTIFY_SOURCE` to disable tests is silly
and such ideas should not be encouraged, you have a point saying that
undefining options the way it's there now is not a good practice.
Ubuntu forces that FORTIFY_SOURCE on me whenever I do -O1! I felt I had to
strike back.
thanks for looking it over, lets see what jenkins says
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> c_unittests failing on RHEL 7
> -
>
> Key: DISPATCH-2328
> URL: https://issues.apache.org/jira/browse/DISPATCH-2328
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:42:
> TEST CASE: test_safe_snprintf
> vsnprintf failure (_STUB_)
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:94:
> ERROR: CHECK( 0 == len ) is NOT correct!
> values: CHECK( 0 == 9 )
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:95:
> ERROR: CHECK( '\0' == output[0] ) is NOT correct!
> values: CHECK( 0 == 115 ) {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2328) c_unittests failing on RHEL 7
[
https://issues.apache.org/jira/browse/DISPATCH-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490547#comment-17490547
]
ASF subversion and git services commented on DISPATCH-2328:
---
Commit 50ee1d2e6a0ec9497b56024da41717e8423f11ad in qpid-dispatch's branch
refs/heads/main from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=50ee1d2 ]
DISPATCH-2328: detect _FORTIFY_SOURCE in c_unittests and bail out (#1514)
> c_unittests failing on RHEL 7
> -
>
> Key: DISPATCH-2328
> URL: https://issues.apache.org/jira/browse/DISPATCH-2328
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:42:
> TEST CASE: test_safe_snprintf
> vsnprintf failure (_STUB_)
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:94:
> ERROR: CHECK( 0 == len ) is NOT correct!
> values: CHECK( 0 == 9 )
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:95:
> ERROR: CHECK( '\0' == output[0] ) is NOT correct!
> values: CHECK( 0 == 115 ) {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2328) c_unittests failing on RHEL 7
[
https://issues.apache.org/jira/browse/DISPATCH-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490548#comment-17490548
]
ASF GitHub Bot commented on DISPATCH-2328:
--
jiridanek merged pull request #1514:
URL: https://github.com/apache/qpid-dispatch/pull/1514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> c_unittests failing on RHEL 7
> -
>
> Key: DISPATCH-2328
> URL: https://issues.apache.org/jira/browse/DISPATCH-2328
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:42:
> TEST CASE: test_safe_snprintf
> vsnprintf failure (_STUB_)
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:94:
> ERROR: CHECK( 0 == len ) is NOT correct!
> values: CHECK( 0 == 9 )
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:95:
> ERROR: CHECK( '\0' == output[0] ) is NOT correct!
> values: CHECK( 0 == 115 ) {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2328) c_unittests failing on RHEL 7
[
https://issues.apache.org/jira/browse/DISPATCH-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490535#comment-17490535
]
ASF GitHub Bot commented on DISPATCH-2328:
--
jiridanek commented on a change in pull request #1514:
URL: https://github.com/apache/qpid-dispatch/pull/1514#discussion_r804152531
##
File path: tests/c_unittests/CMakeLists.txt
##
@@ -20,7 +20,7 @@
# -fno-inline: just to be extra sure, no particular reason so far
# -fno-builtin: GCC would optimize e.g. abs() and we would not be able to stub
# -fno-stack-protector:
https://stackoverflow.com/questions/12201625/disable-using-sprintf-chk
-# -D_FORTIFY_SOURCE=0: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
+# -U_FORTIFY_SOURCE: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_STANDARD_FLAGS} -fno-inline
-fno-builtin -fno-stack-protector -U_FORTIFY_SOURCE")
Review comment:
while I think that setting `_FORTIFY_SOURCE` to disable tests is silly
and such ideas should not be encouraged, you have a point saying that
undefining options the way it's there now is not a good practice
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> c_unittests failing on RHEL 7
> -
>
> Key: DISPATCH-2328
> URL: https://issues.apache.org/jira/browse/DISPATCH-2328
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:42:
> TEST CASE: test_safe_snprintf
> vsnprintf failure (_STUB_)
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:94:
> ERROR: CHECK( 0 == len ) is NOT correct!
> values: CHECK( 0 == 9 )
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:95:
> ERROR: CHECK( '\0' == output[0] ) is NOT correct!
> values: CHECK( 0 == 115 ) {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2328) c_unittests failing on RHEL 7
[
https://issues.apache.org/jira/browse/DISPATCH-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490531#comment-17490531
]
ASF GitHub Bot commented on DISPATCH-2328:
--
ganeshmurthy commented on a change in pull request #1514:
URL: https://github.com/apache/qpid-dispatch/pull/1514#discussion_r804139929
##
File path: tests/c_unittests/CMakeLists.txt
##
@@ -20,7 +20,7 @@
# -fno-inline: just to be extra sure, no particular reason so far
# -fno-builtin: GCC would optimize e.g. abs() and we would not be able to stub
# -fno-stack-protector:
https://stackoverflow.com/questions/12201625/disable-using-sprintf-chk
-# -D_FORTIFY_SOURCE=0: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
+# -U_FORTIFY_SOURCE: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_STANDARD_FLAGS} -fno-inline
-fno-builtin -fno-stack-protector -U_FORTIFY_SOURCE")
Review comment:
ok sounds good. The only issue I have with the CMakeLists.txt code that
nullifies _FORTIFY_SOURCE is that someone might explicitly set
-D_FORTIFY_SOURCE with the intention of not running these tests and it is being
nullified by us and the tests will still run. Oh well, I think that is fine.
Approved !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> c_unittests failing on RHEL 7
> -
>
> Key: DISPATCH-2328
> URL: https://issues.apache.org/jira/browse/DISPATCH-2328
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:42:
> TEST CASE: test_safe_snprintf
> vsnprintf failure (_STUB_)
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:94:
> ERROR: CHECK( 0 == len ) is NOT correct!
> values: CHECK( 0 == 9 )
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:95:
> ERROR: CHECK( '\0' == output[0] ) is NOT correct!
> values: CHECK( 0 == 115 ) {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2328) c_unittests failing on RHEL 7
[
https://issues.apache.org/jira/browse/DISPATCH-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490527#comment-17490527
]
ASF GitHub Bot commented on DISPATCH-2328:
--
jiridanek commented on a change in pull request #1514:
URL: https://github.com/apache/qpid-dispatch/pull/1514#discussion_r804123563
##
File path: tests/c_unittests/CMakeLists.txt
##
@@ -20,7 +20,7 @@
# -fno-inline: just to be extra sure, no particular reason so far
# -fno-builtin: GCC would optimize e.g. abs() and we would not be able to stub
# -fno-stack-protector:
https://stackoverflow.com/questions/12201625/disable-using-sprintf-chk
-# -D_FORTIFY_SOURCE=0: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
+# -U_FORTIFY_SOURCE: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_STANDARD_FLAGS} -fno-inline
-fno-builtin -fno-stack-protector -U_FORTIFY_SOURCE")
Review comment:
> Don't you think that it is strange that the RHEL 7 compile line first
does -D_FORTIFY_SOURCE=2 and then later on does -U_FORTIFY_SOURCE.
That is the result of line 24 right here in
`[ests/c_unittests/CMakeLists.txt`. What I find strange is that the
_FORTIFY_SOURCE is actually not undefined by this. Maybe the `-Wp,` has some
strange powers?
> In any case, does any of the upstream CI builds use the
`-D_FORTIFY_SOURCE`?
Ubuntu in Travis CI, because Ubuntu enables _FORTIFY_SOURCE with -O1 or
higher by default, at least according to
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> c_unittests failing on RHEL 7
> -
>
> Key: DISPATCH-2328
> URL: https://issues.apache.org/jira/browse/DISPATCH-2328
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:42:
> TEST CASE: test_safe_snprintf
> vsnprintf failure (_STUB_)
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:94:
> ERROR: CHECK( 0 == len ) is NOT correct!
> values: CHECK( 0 == 9 )
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:95:
> ERROR: CHECK( '\0' == output[0] ) is NOT correct!
> values: CHECK( 0 == 115 ) {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2328) c_unittests failing on RHEL 7
[
https://issues.apache.org/jira/browse/DISPATCH-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490523#comment-17490523
]
ASF GitHub Bot commented on DISPATCH-2328:
--
ganeshmurthy commented on a change in pull request #1514:
URL: https://github.com/apache/qpid-dispatch/pull/1514#discussion_r804115507
##
File path: tests/c_unittests/CMakeLists.txt
##
@@ -20,7 +20,7 @@
# -fno-inline: just to be extra sure, no particular reason so far
# -fno-builtin: GCC would optimize e.g. abs() and we would not be able to stub
# -fno-stack-protector:
https://stackoverflow.com/questions/12201625/disable-using-sprintf-chk
-# -D_FORTIFY_SOURCE=0: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
+# -U_FORTIFY_SOURCE: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_STANDARD_FLAGS} -fno-inline
-fno-builtin -fno-stack-protector -U_FORTIFY_SOURCE")
Review comment:
Don't you think that it is strange that the RHEL 7 compile line first
does -D_FORTIFY_SOURCE=2 and then later on does -U_FORTIFY_SOURCE. It seems to
me that it tries to first set and then nullify _FORTIFY_SOURCE.
In any case, does any of the upstream CI builds use the -D_FORTIFY_SOURCE ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> c_unittests failing on RHEL 7
> -
>
> Key: DISPATCH-2328
> URL: https://issues.apache.org/jira/browse/DISPATCH-2328
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:42:
> TEST CASE: test_safe_snprintf
> vsnprintf failure (_STUB_)
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:94:
> ERROR: CHECK( 0 == len ) is NOT correct!
> values: CHECK( 0 == 9 )
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:95:
> ERROR: CHECK( '\0' == output[0] ) is NOT correct!
> values: CHECK( 0 == 115 ) {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2328) c_unittests failing on RHEL 7
[
https://issues.apache.org/jira/browse/DISPATCH-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490520#comment-17490520
]
ASF GitHub Bot commented on DISPATCH-2328:
--
jiridanek commented on a change in pull request #1514:
URL: https://github.com/apache/qpid-dispatch/pull/1514#discussion_r804108337
##
File path: tests/c_unittests/CMakeLists.txt
##
@@ -20,7 +20,7 @@
# -fno-inline: just to be extra sure, no particular reason so far
# -fno-builtin: GCC would optimize e.g. abs() and we would not be able to stub
# -fno-stack-protector:
https://stackoverflow.com/questions/12201625/disable-using-sprintf-chk
-# -D_FORTIFY_SOURCE=0: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
+# -U_FORTIFY_SOURCE: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_STANDARD_FLAGS} -fno-inline
-fno-builtin -fno-stack-protector -U_FORTIFY_SOURCE")
Review comment:
It tries to do that, for the test binary only. It worked for the Ubuntu
jobs here in the GHA, but it does not work for RHEL 7. Maybe because the
`rpmbuild` adds its flags in some very smart way? The compile line on RHEL 7 is
> cd /mnt/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests && /usr/bin/c++
-D__STDC_NO_ATOMICS__ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64
-mtune=generic -std=c++11 -fno-inline -fno-builtin -fno-stack-protector
-U_FORTIFY_SOURCE -O2 -g -DNDEBUG
-I/mnt/build/BUILD/qpid-dispatch-1.19.0/include -I/usr/include/python3.6m
-I/mnt/build/BUILD/qpid-dispatch-1.19.0/src
-I/mnt/build/BUILD/qpid-dispatch-1.19.0/tests/cpp-stub-Wall -Wextra -Werror
-Wpedantic -pedantic-errors -Wno-empty-body -Wno-implicit-fallthrough
-Wno-unused-parameter -Wno-ignored-qualifiers -Wno-missing-field-initializers
-Wno-sign-compare -Wno-type-limits -o
CMakeFiles/c_unittests.dir/test_listener_startup.cpp.o -c
/mnt/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_listener_startup.cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> c_unittests failing on RHEL 7
> -
>
> Key: DISPATCH-2328
> URL: https://issues.apache.org/jira/browse/DISPATCH-2328
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:42:
> TEST CASE: test_safe_snprintf
> vsnprintf failure (_STUB_)
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:94:
> ERROR: CHECK( 0 == len ) is NOT correct!
> values: CHECK( 0 == 9 )
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:95:
> ERROR: CHECK( '\0' == output[0] ) is NOT correct!
> values: CHECK( 0 == 115 ) {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2328) c_unittests failing on RHEL 7
[
https://issues.apache.org/jira/browse/DISPATCH-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490518#comment-17490518
]
ASF GitHub Bot commented on DISPATCH-2328:
--
ganeshmurthy commented on a change in pull request #1514:
URL: https://github.com/apache/qpid-dispatch/pull/1514#discussion_r804103572
##
File path: tests/c_unittests/CMakeLists.txt
##
@@ -20,7 +20,7 @@
# -fno-inline: just to be extra sure, no particular reason so far
# -fno-builtin: GCC would optimize e.g. abs() and we would not be able to stub
# -fno-stack-protector:
https://stackoverflow.com/questions/12201625/disable-using-sprintf-chk
-# -D_FORTIFY_SOURCE=0: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
+# -U_FORTIFY_SOURCE: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_STANDARD_FLAGS} -fno-inline
-fno-builtin -fno-stack-protector -U_FORTIFY_SOURCE")
Review comment:
What does the -U_FORTIFY_SOURCE do? Does it nullify _FORTIFY_SOURCE ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> c_unittests failing on RHEL 7
> -
>
> Key: DISPATCH-2328
> URL: https://issues.apache.org/jira/browse/DISPATCH-2328
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:42:
> TEST CASE: test_safe_snprintf
> vsnprintf failure (_STUB_)
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:94:
> ERROR: CHECK( 0 == len ) is NOT correct!
> values: CHECK( 0 == 9 )
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:95:
> ERROR: CHECK( '\0' == output[0] ) is NOT correct!
> values: CHECK( 0 == 115 ) {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2328) c_unittests failing on RHEL 7
[
https://issues.apache.org/jira/browse/DISPATCH-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490476#comment-17490476
]
Ganesh Murthy commented on DISPATCH-2328:
-
Could be caused because of the command line option
-D_FORTIFY_SOURCE
> c_unittests failing on RHEL 7
> -
>
> Key: DISPATCH-2328
> URL: https://issues.apache.org/jira/browse/DISPATCH-2328
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Jiri Daněk
>Priority: Major
>
> {noformat}
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:42:
> TEST CASE: test_safe_snprintf
> vsnprintf failure (_STUB_)
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:94:
> ERROR: CHECK( 0 == len ) is NOT correct!
> values: CHECK( 0 == 9 )
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:95:
> ERROR: CHECK( '\0' == output[0] ) is NOT correct!
> values: CHECK( 0 == 115 ) {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
