[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-04-05 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427263#comment-16427263
 ] 

ASF subversion and git services commented on DISPATCH-918:
--

Commit 627aae1ec779da1f3db9ec7f5add55b300a6 in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=627aae1 ]

DISPATCH-918: clear newly allocated structure to avoid segfaults


> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Management Agent
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.1.0
>
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-04-04 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426050#comment-16426050
 ] 

ASF subversion and git services commented on DISPATCH-918:
--

Commit ef9887cc75a89896c307712f72b41834e937f8c0 in qpid-dispatch's branch 
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=ef9887c ]

DISPATCH-918 - Renamed hostname to realm in authServicePlugin


> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Management Agent
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.1.0
>
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-04-04 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425935#comment-16425935
 ] 

ASF subversion and git services commented on DISPATCH-918:
--

Commit 7237d693072a366868469f85a96bdce3f47d76a5 in qpid-dispatch's branch 
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=7237d69 ]

DISPATCH-918 - Deprecated some attributes of the authServicePlugin entity and 
introduced replacements with clearer names. Also deprecated password of 
sslProfile attribute


> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Management Agent
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.1.0
>
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-04-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424798#comment-16424798
 ] 

ASF subversion and git services commented on DISPATCH-918:
--

Commit f36c90335c3fdaff49472ade1a7acd3077aaa56b in qpid-dispatch's branch 
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=f36c903 ]

DISPATCH-918 - Deprecated some attributes of the sslProfile entity and 
introduced replacement with clearer names


> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Management Agent
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.1.0
>
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-04-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424535#comment-16424535
 ] 

ASF subversion and git services commented on DISPATCH-918:
--

Commit 81fdd61fd2bf06884ce903055a1dce16dc91cf3d in qpid-dispatch's branch 
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=81fdd61 ]

DISPATCH-918 - Deprecated some attributes of the log entities and and 
introduced replacements with clearer names


> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Management Agent
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.1.0
>
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-04-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424317#comment-16424317
 ] 

ASF subversion and git services commented on DISPATCH-918:
--

Commit dcae1f4338d4beed3b0b5f1a03a0bd313ba84f6f in qpid-dispatch's branch 
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=dcae1f4 ]

DISPATCH-918 - Deprecated some listener/connector attributes and introduced 
replacements with much clearer names


> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Management Agent
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.1.0
>
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-04-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424055#comment-16424055
 ] 

ASF subversion and git services commented on DISPATCH-918:
--

Commit 535afa8dd1c910d6269efc2d320cd2abf3154d19 in qpid-dispatch's branch 
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=535afa8 ]

DISPATCH-918 - Deprecated some router attributes and introduced replacements 
with much clearer names


> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Management Agent
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.1.0
>
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-03-01 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382562#comment-16382562
 ] 

ASF subversion and git services commented on DISPATCH-918:
--

Commit 75d8b76631b96272f967cb613a05e109b883488f in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=75d8b76 ]

DISPATCH-918: Deprecate vhost:id in favor of vhost:hostname


> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-03-01 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382341#comment-16382341
 ] 

ASF subversion and git services commented on DISPATCH-918:
--

Commit bb0093e92ce9bf184dc7c42e241e2169a6f8383e in qpid-dispatch's branch 
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=bb0093e ]

DISPATCH-918 - Modified schema code to allow the 'dir' attribute of autoLink 
and linkRoute to be used from qdmanage


> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-03-01 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382044#comment-16382044
 ] 

ASF subversion and git services commented on DISPATCH-918:
--

Commit 7a306e7a60667db62b1fbf28b0b8c1462d54af91 in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=7a306e7 ]

DISPATCH-918: allow blank strings as legal values in deprecationName processing


> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-03-01 Thread Chuck Rolke (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382035#comment-16382035
 ] 

Chuck Rolke commented on DISPATCH-918:
--

Commit 257321d has an issue where the deprecated attribute names do not work 
with qdmanage commands. This issue kills backward compatibility.
{noformat}
> qdmanage -b anonymous@127.0.0.1:23039 CREATE --type=autoLink addr=xyz 
> direction=out phase=2
{
  "addr": "xyz", 
  "direction": "out", 
  "name": null, 
  "linkRef": null, 
  "type": "org.apache.qpid.dispatch.router.config.autoLink", 
  "operStatus": "inactive", 
  "connection": null, 
  "phase": 2, 
  "lastError": null, 
  "externalAddr": null, 
  "identity": "3", 
  "containerId": null
}

> qdmanage -b anonymous@127.0.0.1:23039 CREATE --type=autoLink addr=xyz2 
> dir=out phase=2
KeyError: u'dir'{noformat}

> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-02-27 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379373#comment-16379373
 ] 

ASF subversion and git services commented on DISPATCH-918:
--

Commit 257321d0f8d0d835df47eff2004ef8d4852f46fb in qpid-dispatch's branch 
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=257321d ]

DISPATCH-918 -  Initial modifications to Python schema code to introduce and 
use the deprecationName attribute. Also modified dir to direction in linkRoute 
and autoLink and they use the deprecationName attribute. This closes #261


> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-02-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379374#comment-16379374
 ] 

ASF GitHub Bot commented on DISPATCH-918:
-

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/261


> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-02-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378896#comment-16378896
 ] 

ASF GitHub Bot commented on DISPATCH-918:
-

Github user ganeshmurthy commented on the issue:

https://github.com/apache/qpid-dispatch/pull/261
  
Specifying the "dir" attribute only will generate a warning that will tell 
you that you are using a deprecated attribute. The warning will look something 
like this - 
2018-02-27 11:34:41.138705 -0500 AGENT (warning) Attribute 'dir' of entity 
'linkRoute' has been deprecated. Use 'direction' instead

The router will still start  

If both 'dir' and 'direction' attributes are specified, the router will 
display the following error and fail to start - 
2018-02-27 11:36:54.911916 -0500 MAIN (critical) Router start-up failed: 
Python: Exception: Cannot load configuration file test.conf: 
org.apache.qpid.dispatch.router.config.linkRoute: Both 'dir' and 'direction' 
cannot be specified for entity 'linkRoute'



> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-02-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378881#comment-16378881
 ] 

ASF GitHub Bot commented on DISPATCH-918:
-

Github user bhardesty commented on the issue:

https://github.com/apache/qpid-dispatch/pull/261
  
The "dir" -> "direction" doc updates look good.

If someone attempts to use a deprecated attribute, will the operation still 
succeed (in addition to the deprecation log warning)? Or will the operation 
fail? 


> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-02-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376996#comment-16376996
 ] 

ASF GitHub Bot commented on DISPATCH-918:
-

Github user ganeshmurthy commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/261#discussion_r170619984
  
--- Diff: tests/system_tests_autolinks.py ---
@@ -53,17 +53,18 @@ def setUpClass(cls):
 #
 # Create a pair of default auto-links for 'node.1'
 #
-('autoLink', {'addr': 'node.1', 'containerId': 'container.1', 
'dir': 'in'}),
-('autoLink', {'addr': 'node.1', 'containerId': 'container.1', 
'dir': 'out'}),
+('autoLink', {'addr': 'node.1', 'containerId': 'container.1', 
'direction': 'in'}),
+('autoLink', {'addr': 'node.1', 'containerId': 'container.1', 
'direction': 'out'}),
 
 #
 # Create a pair of auto-links on non-default phases for 
container-to-container transfers
 #
-('autoLink', {'addr': 'xfer.2', 'containerId': 'container.2', 
'dir': 'in',  'phase': '4'}),
-('autoLink', {'addr': 'xfer.2', 'containerId': 'container.3', 
'dir': 'out', 'phase': '4'}),
+('autoLink', {'addr': 'xfer.2', 'containerId': 'container.2', 
'direction': 'in',  'phase': '4'}),
+('autoLink', {'addr': 'xfer.2', 'containerId': 'container.3', 
'direction': 'out', 'phase': '4'}),
 
 #
 # Create a pair of auto-links with a different external address
+# Leave the direction as dir to test backward compatibility.
--- End diff --

No there is not such a test. Thanks for pointing that out. I will add such 
a test to this PR shortly.


> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-02-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376981#comment-16376981
 ] 

ASF GitHub Bot commented on DISPATCH-918:
-

Github user ChugR commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/261#discussion_r170614842
  
--- Diff: tests/system_tests_autolinks.py ---
@@ -53,17 +53,18 @@ def setUpClass(cls):
 #
 # Create a pair of default auto-links for 'node.1'
 #
-('autoLink', {'addr': 'node.1', 'containerId': 'container.1', 
'dir': 'in'}),
-('autoLink', {'addr': 'node.1', 'containerId': 'container.1', 
'dir': 'out'}),
+('autoLink', {'addr': 'node.1', 'containerId': 'container.1', 
'direction': 'in'}),
+('autoLink', {'addr': 'node.1', 'containerId': 'container.1', 
'direction': 'out'}),
 
 #
 # Create a pair of auto-links on non-default phases for 
container-to-container transfers
 #
-('autoLink', {'addr': 'xfer.2', 'containerId': 'container.2', 
'dir': 'in',  'phase': '4'}),
-('autoLink', {'addr': 'xfer.2', 'containerId': 'container.3', 
'dir': 'out', 'phase': '4'}),
+('autoLink', {'addr': 'xfer.2', 'containerId': 'container.2', 
'direction': 'in',  'phase': '4'}),
+('autoLink', {'addr': 'xfer.2', 'containerId': 'container.3', 
'direction': 'out', 'phase': '4'}),
 
 #
 # Create a pair of auto-links with a different external address
+# Leave the direction as dir to test backward compatibility.
--- End diff --

Is there a test that has both dir and direction specified to see that it 
fails?


> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-918) Improve router config consistency and metadata

2018-02-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374915#comment-16374915
 ] 

ASF GitHub Bot commented on DISPATCH-918:
-

GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/261

DISPATCH-918 -  Initial modifications to Python schema code to introd…

…uce and use the deprecationName attribute. Also modified dir to direction 
in linkRoute and autoLink and they use the deprecationName attribute

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch 
DISPATCH-918-DEPNAME

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #261


commit 0a9e962161c94725aa1a5b906dec95715b7987d7
Author: Ganesh Murthy 
Date:   2018-02-23T18:10:13Z

DISPATCH-918 -  Initial modifications to Python schema code to introduce 
and use the deprecationName attribute. Also modified dir to direction in 
linkRoute and autoLink and they use the deprecationName attribute




> Improve router config consistency and metadata
> --
>
> Key: DISPATCH-918
> URL: https://issues.apache.org/jira/browse/DISPATCH-918
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Reporter: Justin Ross
>Assignee: Ganesh Murthy
>Priority: Major
>
> Proposed changes from review.  The items marked PRIO1 are more important.  
> All changes must be backward-compatible.
> [https://docs.google.com/spreadsheets/d/14ugjxlc-ETYZXwN9eWD-D1YWrRAfydj9EJNmyUaZrD0/edit?usp=sharing]
> This also includes flags we'd like to get added to the metadata so we can 
> generate better docs from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org