[jira] [Commented] (PROTON-1619) C and C++ API clean up

2017-10-16 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205646#comment-16205646
 ] 

ASF subversion and git services commented on PROTON-1619:
-

Commit 1ad1e656f00333be9690995a8a8e45b83ce2a01c in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=1ad1e65 ]

PROTON-1619: restore pn_connection_driver_log functions, deprecated.

Preserve ABI compatibility with 0.17: restore but mark deprecated.


> C and C++ API clean up
> --
>
> Key: PROTON-1619
> URL: https://issues.apache.org/jira/browse/PROTON-1619
> Project: Qpid Proton
>  Issue Type: Task
>  Components: cpp-binding, proton-c
>Reporter: Justin Ross
>Assignee: Alan Conway
> Fix For: proton-c-0.18.0
>
>
> From our review.
> Use pni_ prefix
>  - pn_log_enabled
>  - pn_logf_impl
>  - pn_vlogf_impl
> Remove or don't export
>  - pn_message_get_extra
>  - pn_message_with_extra
>  - pn_connection_driver_logf
>  - pni_parse_url



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1619) C and C++ API clean up

2017-10-14 Thread Justin Ross (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204859#comment-16204859
 ] 

Justin Ross commented on PROTON-1619:
-

Removing the connection driver log functions breaks libqpid-proton-core ABI 
versus 0.17.0.  I think we should reinstate and deprecate them.

{noformat}
[jross@localhost qpid-proton-ssorj (ssorj-versions)]$ abigail 
/usr/lib64/libqpid-proton-core.so 
/tmp/tmp.nzVXqRTato/lib64/libqpid-proton-core.so
abigail: Calling 'nm --dynamic --demangle --defined-only 
/usr/lib64/libqpid-proton-core.so'
abigail: Calling 'nm --dynamic --demangle --defined-only 
/tmp/tmp.nzVXqRTato/lib64/libqpid-proton-core.so'
37 symbols added
2 symbols removed
Added: pn_collector_drain
Added: pn_connection_driver_release_connection
Added: pn_delivery_abort
[...]
Added: pnx_sasl_set_local_hostname
Added: pnx_sasl_set_selected_mechanism
Added: pnx_sasl_succeed_authentication
Removed: pn_connection_driver_log
Removed: pn_connection_driver_vlogf
{noformat}

> C and C++ API clean up
> --
>
> Key: PROTON-1619
> URL: https://issues.apache.org/jira/browse/PROTON-1619
> Project: Qpid Proton
>  Issue Type: Task
>  Components: cpp-binding, proton-c
>Reporter: Justin Ross
>Assignee: Alan Conway
> Fix For: proton-c-0.18.0
>
>
> From our review.
> Use pni_ prefix
>  - pn_log_enabled
>  - pn_logf_impl
>  - pn_vlogf_impl
> Remove or don't export
>  - pn_message_get_extra
>  - pn_message_with_extra
>  - pn_connection_driver_logf
>  - pni_parse_url



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1619) C and C++ API clean up

2017-10-12 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201891#comment-16201891
 ] 

ASF subversion and git services commented on PROTON-1619:
-

Commit 8a891c92b7a4f56d009e1e437d979c3379fe4a6f in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=8a891c9 ]

PROTON-1619: c rename/remove/un-export private functions

renamed as pni_*:
pn_log_enabled, pn_logf_impl, pn_vlogf_impl - still exported for 
libqpid-proton-proactor
pn_message_get_extra, pn_message_with_extra - still exported for 
libqpid-proton-cpp

removed: pn_connection_driver_log, pn_connection_driver_logf, 
pn_connection_driver_vlogf

unexported: pni_parse_url - now private in extras/url.c


> C and C++ API clean up
> --
>
> Key: PROTON-1619
> URL: https://issues.apache.org/jira/browse/PROTON-1619
> Project: Qpid Proton
>  Issue Type: Task
>  Components: cpp-binding, proton-c
>Reporter: Justin Ross
>Assignee: Alan Conway
> Fix For: proton-c-0.18.0
>
>
> From our review.
> Use pni_ prefix
>  - pn_log_enabled
>  - pn_logf_impl
>  - pn_vlogf_impl
> Remove or don't export
>  - pn_message_get_extra
>  - pn_message_with_extra
>  - pn_connection_driver_logf
>  - pni_parse_url



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1619) C and C++ API clean up

2017-10-12 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201904#comment-16201904
 ] 

ASF subversion and git services commented on PROTON-1619:
-

Commit 87bd8d97e497e6ff5654a5fa4dcbe78a5d001be0 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=87bd8d9 ]

PROTON-1619: remove pn_connection_driver_log definitions

removed definitions: pn_connection_driver_log, pn_connection_driver_logf, 
pn_connection_driver_vlogf


> C and C++ API clean up
> --
>
> Key: PROTON-1619
> URL: https://issues.apache.org/jira/browse/PROTON-1619
> Project: Qpid Proton
>  Issue Type: Task
>  Components: cpp-binding, proton-c
>Reporter: Justin Ross
>Assignee: Alan Conway
> Fix For: proton-c-0.18.0
>
>
> From our review.
> Use pni_ prefix
>  - pn_log_enabled
>  - pn_logf_impl
>  - pn_vlogf_impl
> Remove or don't export
>  - pn_message_get_extra
>  - pn_message_with_extra
>  - pn_connection_driver_logf
>  - pni_parse_url



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org