[jira] [Commented] (PROTON-1638) Need to improve proton-c build tree layout

2018-05-02 Thread Justin Ross (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461692#comment-16461692
 ] 

Justin Ross commented on PROTON-1638:
-

[~jdanek], regarding your comment above about C++ IDEs, would you double check 
as Andrew suggests, and if this remains an issue, raise it separately.  I'm 
going to close this one as a duplicate of PROTON-1728.

> Need to improve proton-c build tree layout
> --
>
> Key: PROTON-1638
> URL: https://issues.apache.org/jira/browse/PROTON-1638
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: proton-c-0.18.0
>Reporter: Andrew Stitcher
>Assignee: Justin Ross
>Priority: Major
> Fix For: proton-c-0.23.0
>
>
> The proton-c tree layout is annoying in a number of ways:
> * Since the split with proton-j there is a superfluous top level
> * CMake build flags don't propagate properly because examples are not in the 
> correct subtree
> ** Examples should be in the binding subtree that they are examples
> ** Otherwise the information for a particular binding and its examples are 
> split into 2 different parts of the proton-c tree.
> ** This means that the installation for a binding is split
> ** It is unatural in CMake to split build flags like this - CMake is 
> hierarchical



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1638) Need to improve proton-c build tree layout

2018-04-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427492#comment-16427492
 ] 

ASF GitHub Bot commented on PROTON-1638:


Github user ssorj closed the pull request at:

https://github.com/apache/qpid-proton/pull/140


> Need to improve proton-c build tree layout
> --
>
> Key: PROTON-1638
> URL: https://issues.apache.org/jira/browse/PROTON-1638
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: proton-c-0.18.0
>Reporter: Andrew Stitcher
>Assignee: Justin Ross
>Priority: Major
>
> The proton-c tree layout is annoying in a number of ways:
> * Since the split with proton-j there is a superfluous top level
> * CMake build flags don't propagate properly because examples are not in the 
> correct subtree
> ** Examples should be in the binding subtree that they are examples
> ** Otherwise the information for a particular binding and its examples are 
> split into 2 different parts of the proton-c tree.
> ** This means that the installation for a binding is split
> ** It is unatural in CMake to split build flags like this - CMake is 
> hierarchical



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1638) Need to improve proton-c build tree layout

2018-03-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395031#comment-16395031
 ] 

ASF GitHub Bot commented on PROTON-1638:


Github user gemmellr commented on the issue:

https://github.com/apache/qpid-proton/pull/140
  
I gave things a skim over, changes seemed reasonable from my 
doesnt-do-cmake-etc perspective.

Noting for later reference: this builds on / incorporates WIP from #136 and 
#138.


> Need to improve proton-c build tree layout
> --
>
> Key: PROTON-1638
> URL: https://issues.apache.org/jira/browse/PROTON-1638
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: proton-c-0.18.0
>Reporter: Andrew Stitcher
>Assignee: Justin Ross
>Priority: Major
>
> The proton-c tree layout is annoying in a number of ways:
> * Since the split with proton-j there is a superfluous top level
> * CMake build flags don't propagate properly because examples are not in the 
> correct subtree
> ** Examples should be in the binding subtree that they are examples
> ** Otherwise the information for a particular binding and its examples are 
> split into 2 different parts of the proton-c tree.
> ** This means that the installation for a binding is split
> ** It is unatural in CMake to split build flags like this - CMake is 
> hierarchical



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1638) Need to improve proton-c build tree layout

2018-03-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391527#comment-16391527
 ] 

ASF GitHub Bot commented on PROTON-1638:


GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/140

PROTON-1638, PROTON-1728: Reorganize the source tree

I plan to squash this on merge.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton 
ssorj-reorganize-the-source-tree

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #140


commit bb53a69334a88a0dbdb11550882b085660e765c7
Author: Justin Ross 
Date:   2017-12-21T14:32:50Z

Remove old docs; some of this content will be restored to new locations

commit 6a0801b08e47f888d5074def67eb65f237e8f884
Author: Justin Ross 
Date:   2017-12-21T17:39:06Z

Rename version.txt to VERSION.txt

commit 4dddef8019633f47f537645440c439d17102f349
Author: Justin Ross 
Date:   2017-12-21T18:00:14Z

Add a .txt extension to LICENSE and NOTICE, for nicer behavior on Windows

commit 654874b7ad62e3e850e4cc15fc7f6fb18d703690
Author: Justin Ross 
Date:   2017-12-21T18:21:29Z

Fixups for file name conventions

commit 7ce68cadcd25e718e87d8aa8241344f1f8ac81b7
Author: Justin Ross 
Date:   2017-12-21T18:29:48Z

Rename tools/py to tools/python to match the other python dirs

commit f36eba5aa4a988fe01432f19415c9878e6f5eec7
Author: Justin Ross 
Date:   2017-12-21T18:33:39Z

Make a space for ancillary files

commit 2beb5236ca6e0647c814a659db8d34bc4e3a1e94
Author: Justin Ross 
Date:   2017-12-21T18:46:30Z

Move the docs dir to the top level

commit 8a457c031132266014bc3b8f524c105d349495b6
Author: Justin Ross 
Date:   2017-12-21T19:06:23Z

Move mllib to live with other python tools

commit f0531db10070e9a37f049f4f629cbd8fbd906add
Author: Justin Ross 
Date:   2017-12-21T20:03:51Z

Move some includes and package configs to the top level

commit 9bc93610f183e26e8c8a0ab9ba3678b15cf110f6
Author: Justin Ross 
Date:   2017-12-21T21:45:08Z

Lift all of proton-c/* to the top level and adjust paths

commit d1b359473f8e4ed899ed564a110866f8437ac68e
Author: Justin Ross 
Date:   2017-12-21T22:29:34Z

Adjust some reacharound paths

commit 2d8f4b87e2a42dacdfe559a1b0530f7e21185398
Author: Justin Ross 
Date:   2017-12-21T22:33:49Z

xproton.py is no longer used

commit 6434aee3d7930555259deb498b1c3dadde16c526
Author: Justin Ross 
Date:   2017-12-21T22:44:03Z

Move env.py with the other scripts in bin/

commit 4117280ca6b0d5eff0e3e6a8ca2818a6ac3c270c
Author: Justin Ross 
Date:   2017-12-21T22:59:24Z

Move tox.ini to misc/

commit 53facd9b7a676c1967983fd1c3ebf693cda46fb8
Author: Justin Ross 
Date:   2017-12-21T23:14:13Z

Move the env config scripts to misc/; adjust the target for tox.ini.in

commit 066afffcdd596613033fb44a14307106df07d0d5
Author: Justin Ross 
Date:   2017-12-21T23:17:51Z

Move soak-check with the other scripts

commit 781e3c9a586f6295ee1d84e363373eb7d22625c7
Author: Justin Ross 
Date:   2017-12-21T23:27:23Z

Remove the C++ reactor app

commit 2baa52785d683b6c4e68e99fd463e96d5d8bec0d
Author: Justin Ross 
Date:   2017-12-21T23:42:29Z

Move the legacy test apps to tools/test-apps/

commit 3864ff36be56c603f556d69918eb0cd17390
Author: Justin Ross 
Date:   2017-12-21T23:46:30Z

Correct some paths I missed

commit 7345c8c9e3174dea64580111e3f6a2cac189d9a9
Author: Justin Ross 
Date:   2017-12-21T23:49:37Z

Rename appveyor.yml to .appveyor.yml

commit b368b2a2b3adb351dfb3264b2a3c495d835d4e9d
Author: Justin Ross 
Date:   2017-12-22T00:07:19Z

Fix a broken path

commit 82f3d53f93da9a53bf9c9b06e5e83fcadd1e056c
Author: Justin Ross 
Date:   2017-12-22T00:26:41Z

Move some of the less frequently used readme files to docs/

commit 4f87c3e5794b98ea0468593821070d2f433a3747
Author: Justin Ross 
Date:   2018-02-14T01:16:15Z

Remove the perl, php, node, and javascript bindings

commit a54afc17b38a4e4719afe286ffb55cc8e7c5e337
Author: Justin Ross 
Date:   2018-02-14T02:31:07Z

Remove the messenger docs

commit 4c7227bd906f4afb44ce61fff7c432df1fb1cd5d
Author: Justin Ross 
Date:   2018-02-14T02:34:40Z

Remove the python messenger API

commit 00e3f95bb83756230a468d67a98ea32c64cd276b
Author: Justin Ross 
Date:   2018-02-14T03:16:19Z

Remove the ruby messenger API

commit b931a410ba77bd49151cce52bbba69d15f1dd3d4

[jira] [Commented] (PROTON-1638) Need to improve proton-c build tree layout

2018-03-07 Thread Justin Ross (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389868#comment-16389868
 ] 

Justin Ross commented on PROTON-1638:
-

[~astitcher], yes it does.  Thanks.

> Need to improve proton-c build tree layout
> --
>
> Key: PROTON-1638
> URL: https://issues.apache.org/jira/browse/PROTON-1638
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: proton-c-0.18.0
>Reporter: Andrew Stitcher
>Assignee: Justin Ross
>Priority: Major
>
> The proton-c tree layout is annoying in a number of ways:
> * Since the split with proton-j there is a superfluous top level
> * CMake build flags don't propagate properly because examples are not in the 
> correct subtree
> ** Examples should be in the binding subtree that they are examples
> ** Otherwise the information for a particular binding and its examples are 
> split into 2 different parts of the proton-c tree.
> ** This means that the installation for a binding is split
> ** It is unatural in CMake to split build flags like this - CMake is 
> hierarchical



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1638) Need to improve proton-c build tree layout

2018-03-07 Thread Andrew Stitcher (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389835#comment-16389835
 ] 

Andrew Stitcher commented on PROTON-1638:
-

[~justi9] Assigned to you as it seems to be what you're working on presently.

> Need to improve proton-c build tree layout
> --
>
> Key: PROTON-1638
> URL: https://issues.apache.org/jira/browse/PROTON-1638
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: proton-c-0.18.0
>Reporter: Andrew Stitcher
>Assignee: Justin Ross
>Priority: Major
>
> The proton-c tree layout is annoying in a number of ways:
> * Since the split with proton-j there is a superfluous top level
> * CMake build flags don't propagate properly because examples are not in the 
> correct subtree
> ** Examples should be in the binding subtree that they are examples
> ** Otherwise the information for a particular binding and its examples are 
> split into 2 different parts of the proton-c tree.
> ** This means that the installation for a binding is split
> ** It is unatural in CMake to split build flags like this - CMake is 
> hierarchical



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1638) Need to improve proton-c build tree layout

2017-10-20 Thread Andrew Stitcher (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212661#comment-16212661
 ] 

Andrew Stitcher commented on PROTON-1638:
-

That's interesting - I use kdevelop on a daily basis and hadn't noticed any 
deficiency with the IDE. I'm certainly open to adding the header files though.

> Need to improve proton-c build tree layout
> --
>
> Key: PROTON-1638
> URL: https://issues.apache.org/jira/browse/PROTON-1638
> Project: Qpid Proton
>  Issue Type: Improvement
>Affects Versions: proton-c-0.18.0
>Reporter: Andrew Stitcher
>
> The proton-c tree layout is annoying in a number of ways:
> * Since the split with proton-j there is a superfluous top level
> * CMake build flags don't propagate properly because examples are not in the 
> correct subtree
> ** Examples should be in the binding subtree that they are examples
> ** Otherwise the information for a particular binding and its examples are 
> split into 2 different parts of the proton-c tree.
> ** This means that the installation for a binding is split
> ** It is unatural in CMake to split build flags like this - CMake is 
> hierarchical



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org