[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887859#comment-13887859
]
ASF subversion and git services commented on QPID-5485:
---
Commit 1563152 from [~astitcher] in branch 'qpid/trunk'
[ https://svn.apache.org/r1563152 ]
QPID-5485: Fixes to broken original checkin
- Fix signatures of dummy windows memory mapped file implementation
- Fix detecting no data dir
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Andrew Stitcher
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Attachments: QPID-5485-new.1.patch, QPID-5485-new.2.patch
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13888165#comment-13888165
]
ASF subversion and git services commented on QPID-5485:
---
Commit 1563256 from [~astitcher] in branch 'qpid/trunk'
[ https://svn.apache.org/r1563256 ]
QPID-5485: If no directory for paging file is enabled print warning (as if
memory mapped files were not supported) but still create a queue.
- Also improve DataDir const correctness.
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Andrew Stitcher
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Attachments: QPID-5485-new.1.patch, QPID-5485-new.2.patch
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887228#comment-13887228
]
ASF subversion and git services commented on QPID-5485:
---
Commit 1563012 from [~astitcher] in branch 'qpid/trunk'
[ https://svn.apache.org/r1563012 ]
QPID-5485: By default use a subdirectory of the data dir called pq for
page queue files. If neither data dir nor paging dir are set then error
on any attempt to create a paged queue.
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Andrew Stitcher
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Attachments: QPID-5485-new.1.patch, QPID-5485-new.2.patch
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885855#comment-13885855
]
Andrew Stitcher commented on QPID-5485:
---
Pavel
I've assigned this to myself as this is casuing us test failures and we'd like
to resolve it soon.
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Andrew Stitcher
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Attachments: QPID-5485-new.1.patch, QPID-5485-new.2.patch
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885891#comment-13885891
]
Andrew Stitcher commented on QPID-5485:
---
Review of my suggested patch is at:
https://reviews.apache.org/r/17511/
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Andrew Stitcher
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Attachments: QPID-5485-new.1.patch, QPID-5485-new.2.patch
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13884243#comment-13884243
]
Andrew Stitcher commented on QPID-5485:
---
Patch 2 is what I'd be thinking of.
Note you have left a debug log in there with your name in it:
+QPID_LOG(notice, PavelM: pagingDir= pagingDir);
Also in patch 2 you still need to change the open flags from O_EXCL to O_TRUNC
which isn't in the patch.
To avoid the lock file being created at all we could also add in the ::mkdir()
from patch 1 and stop the Broker class from trying to create the page file dir
at all.
(I can't see these bits in your patch though so it's hard to see exactly what
that change would be)
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Pavel Moravec
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Attachments: QPID-5485-new.1.patch, QPID-5485-new.2.patch
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879888#comment-13879888
]
Pavel Moravec commented on QPID-5485:
-
Andrew's proposal makes sense to me - I am about to write a patch for it and
post it for review. TBD withing few working days (depending on my load
meantime).
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Pavel Moravec
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876825#comment-13876825
]
Andrew Stitcher commented on QPID-5485:
---
I don't think the above scheme is necessary:
* If --paging-dir is specified then we use that directory.
* If not then we use a specified directory under the datadir.
The requirement is just that we never use the datadir or any directlry where
there might be files used for other purposes (unless the user has explicitly
told us to).
In either of these cases we use O_TRUNC not C_EXCL and we delete files only on
queue deletion.
This should give us one use case for the files; leave the files in place during
there use, so that the admins can see them; Delete the files in the usual case
of correct queue deletion. But on crash and restart just zero out the file and
start from scratch with no complaint.
We don't have to worry about any non queue file because we by definition use an
empty directory that only take paging files by default.
If the user specifies a paging directory themselves then it is their
responsibility to make sure it is onyl used to hold paging files, because there
is no way that qpid can ensure it.
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Pavel Moravec
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876011#comment-13876011
]
JAkub Scholz commented on QPID-5485:
Sounds fine for me as a user. But you will end up with two different
implementations which in ideal case should be tested, documented and
maintained.
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Pavel Moravec
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875608#comment-13875608
]
Pavel Moravec commented on QPID-5485:
-
FYI there is broker option --paging-dir available. Note that having approach
don't ulink after creating and prevent file overwrite can cause infinite
broker restart loop when:
1) broker abruptly died due to some reason, leaving the orphaned files
2) Broker set to automatically restart (i.e. due to rgmanager or whatever else
way), but its kick-off is terminated when durable paged queue is to be restored
So what about the approach:
1) if paging-dir is set:
- allow overwriting files (O_TRUNC), assuming the directory contains only
paged queue files
- don't ulink files just after created them (do so only when deleting the
queue)
2) if paging-dir is _not_ set:
- preventivelly disallow overwriting files (O_EXCL), to protect lock file,
sasldb or so
- ulink files just after created them - to prevent potential broker restart
infinite loop as above
First option is for those admins who likely see everything on their place, the
second option is for those who dont care (and want everything working somewhere
on (not visible) background).
Or is the idea too complicated? (and also I need to review the code how easy to
implement the is paging-dir set? test on the _right_ place)
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Pavel Moravec
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874759#comment-13874759
]
Pavel Moravec commented on QPID-5485:
-
So code like:
std::string MemoryMappedFile::open(const std::string name, const std::string
directory)
{
std::string path = getFileName(name, directory);
int flags = O_CREAT | O_EXCL | O_RDWR;
int fd = ::open(path.c_str(), flags, S_IRUSR | S_IWUSR);
if (fd == -1) throw qpid::Exception(QPID_MSG(Failed to open memory mapped
file path : qpid::sys::strError(errno) [flags= flags
]));
state-fd = fd;
::unlink(path.c_str());
return path;
}
void MemoryMappedFile::close(const std::string /*path*/)
{
::close(state-fd);
//::unlink(path.c_str());
}
is better? Checking it, I see no real file exists after creating PagedQueue as
paged queue:
$ qpid-send -a PagedQueue; {create:always, node: { x-declare: {arguments:
{'qpid.paging':'True' -m 1000
$ file /home/pmoravec/.qpidd/PagedQueue
/home/pmoravec/.qpidd/PagedQueue: ERROR: cannot open
`/home/pmoravec/.qpidd/PagedQueue' (No such file or directory)
$ lsof -p $(pgrep qpidd) | grep PagedQueue
qpidd 30992 pmoravec DEL REG 253,3 11407785
/home/pmoravec/.qpidd/PagedQueue
qpidd 30992 pmoravec 13u REG 253,3 131072 11407785
/home/pmoravec/.qpidd/PagedQueue (deleted)
$
All operations I tried with the queue seem to work fine..
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Pavel Moravec
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874849#comment-13874849
]
Andrew Stitcher commented on QPID-5485:
---
Yes, that is exactly what I mean. It is counter intuitive, but it is a central
design feature of Unix. The only potential problem with this kind of approach
is that the disk space will be used but there will be no actual file using it!
It also solves the problem of being able to somehow reopen an existing file,
because there is no file!
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Pavel Moravec
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874903#comment-13874903
]
JAkub Scholz commented on QPID-5485:
Hi Pavel, Andrew,
I understand that from some perspective, this is an elegant idea and it solves
the problem with deleting the files even in case of broker crash etc. But are
you sure that it is desired to have the broker using possibly many GBs of
invisible files? Because to me it doesn't seem really user friendly.
Regards
Jakub
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Pavel Moravec
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874914#comment-13874914
]
Andrew Stitcher commented on QPID-5485:
---
Jakub,
TBH honest I think that either we unlink the files immediately, in which case
we can be pretty sure that whenever we start a new broker any page queue files
that might exist correspond to an error that needs fixing, or we allow the
create paged queue operation to truncate any previous file that might exist.
Any other behaviour isn't really robust enough in the face of brokers that
crash and restart.
I agree that having hidden file usage is very admin unfriendly, but it is a
fact of life on Unix (isn't it?).
There is perhaps another approach to the combination of this issue and
QPID-5486: Put all the paged queue files in a subdirectory of the broker
directory, that would avoid the need to check for an existing file as the only
files that could overwritten would be a paged queue of the same name from a
previous run, which would not be a problem. It would also allow you to call you
paged queue lock or systemId etc.
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Pavel Moravec
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875007#comment-13875007
]
JAkub Scholz commented on QPID-5485:
I guess it can work in the same way as the legacystore - first create a
subdirectory in the paging-dir / data-dir and only there create the paging
files. That would to large extent resolve the QPID-5486 issue.
My personal preference would be to rather risk orphaned paging files after a
broker crash than have invisible files. But I admit that I might be motivated
that way because:
- we use a custom script to start the broker, where we can very easily wipe the
paging files manually
- we currently don't plan to use paging with non-durable queues, so I don't
expect so many orphaned paging files
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Pavel Moravec
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873399#comment-13873399
]
ASF subversion and git services commented on QPID-5485:
---
Commit 1558790 from [~pmoravec] in branch 'qpid/trunk'
[ https://svn.apache.org/r1558790 ]
QPID-5485 Deleting paged queue does not remove underlying file
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Pavel Moravec
Priority: Minor
Labels: easyfix, easytest, patch
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5485) Deleting paged queue does not remove underlying file
[
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873869#comment-13873869
]
Andrew Stitcher commented on QPID-5485:
---
A safer way to make sure that the paging files are not left around in the face
of things like processes being terminated roughly woudl be to unlink the file
immediately after opening it.
It is a feature of Unix like systems that files will hang around as long as any
programs have them open irrespective of whether the file is linked into a
directory or not.
So the paging file would be perfectly fine existing on disk until it was either
closed by deleting the queue or by the process exiting for whatever reason.
Deleting paged queue does not remove underlying file
-
Key: QPID-5485
URL: https://issues.apache.org/jira/browse/QPID-5485
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.24
Environment: (any posix system)
Reporter: Pavel Moravec
Assignee: Pavel Moravec
Priority: Minor
Labels: easyfix, easytest, patch
Fix For: 0.27
Description of problem:
When deleting a paged queue, the broker does not delete the underlying file
it created in /var/lib/qpidd directory.
Version-Release number of selected component (if applicable):
MRG-M 3.0 EA (qpid-cpp 0.22-29)
How reproducible:
100%
Steps to Reproduce:
0. service qpiddd restart
1. qpid-send -a PagedQueue; {create:always, delete:always, node: {
x-declare: {arguments: {'qpid.paging':'True'
2. file /var/lib/qpidd/PagedQueue
Actual results:
/var/lib/qpidd/PagedQueue: data
Expected results:
/var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such
file or directory)
Additional info:
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
