[jira] [Commented] (QPID-7832) Refactor store/protocol API using Collection
[ https://issues.apache.org/jira/browse/QPID-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217160#comment-16217160 ] ASF subversion and git services commented on QPID-7832: --- Commit e64e282688da8963133dc09c630482c686d8be7a in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=e64e282 ] QPID-7832: [Java Broker] Introduce QpidByteBuffer interface and split implementation into separate classes > Refactor store/protocol API using Collection > - > > Key: QPID-7832 > URL: https://issues.apache.org/jira/browse/QPID-7832 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.0.0 > > Attachments: > .0001-QPID-7832-Java-Broker-Small-performance-optimisation.patch.swp, > 0001-QPID-7832-Java-Broker-Refactor-store-protocol-API-us.patch, > 0002-QPID-7832-Java-Broker-Improve-performance-for-QpidBy.patch > > > Store/protocol APIs have gradually been evolving to accept/return message > content/message metadata in terms of an ordered list of QBBs. This has lead > to use of helper methods such as those in QBBUtils which read from a list of > buffers rather than a single one. > This would be better refactored. QpidByteBuffer should be an interface. > This would allow a concrete implementation CompositeQpidByteBuffer which is > backed by a list produced by the store or network IO. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7832) Refactor store/protocol API using Collection
[ https://issues.apache.org/jira/browse/QPID-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215334#comment-16215334 ] ASF subversion and git services commented on QPID-7832: --- Commit 2acc60129af8dff78d58a4cfeabdc85605ac0996 in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=2acc601 ] QPID-7832: [Java Broker] Optimise QpidByteBuffer > Refactor store/protocol API using Collection > - > > Key: QPID-7832 > URL: https://issues.apache.org/jira/browse/QPID-7832 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.0.0 > > Attachments: > .0001-QPID-7832-Java-Broker-Small-performance-optimisation.patch.swp, > 0001-QPID-7832-Java-Broker-Refactor-store-protocol-API-us.patch, > 0002-QPID-7832-Java-Broker-Improve-performance-for-QpidBy.patch > > > Store/protocol APIs have gradually been evolving to accept/return message > content/message metadata in terms of an ordered list of QBBs. This has lead > to use of helper methods such as those in QBBUtils which read from a list of > buffers rather than a single one. > This would be better refactored. QpidByteBuffer should be an interface. > This would allow a concrete implementation CompositeQpidByteBuffer which is > backed by a list produced by the store or network IO. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7832) Refactor store/protocol API using Collection
[ https://issues.apache.org/jira/browse/QPID-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212776#comment-16212776 ] ASF subversion and git services commented on QPID-7832: --- Commit 000228a5ac3a38043d5e6ddb153a45449fa5efdb in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=000228a ] QPID-7832: [Java Broker] Change type of QpidByteBuffer#_fragments from List to array > Refactor store/protocol API using Collection > - > > Key: QPID-7832 > URL: https://issues.apache.org/jira/browse/QPID-7832 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7832-Java-Broker-Refactor-store-protocol-API-us.patch > > > Store/protocol APIs have gradually been evolving to accept/return message > content/message metadata in terms of an ordered list of QBBs. This has lead > to use of helper methods such as those in QBBUtils which read from a list of > buffers rather than a single one. > This would be better refactored. QpidByteBuffer should be an interface. > This would allow a concrete implementation CompositeQpidByteBuffer which is > backed by a list produced by the store or network IO. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7832) Refactor store/protocol API using Collection
[ https://issues.apache.org/jira/browse/QPID-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212334#comment-16212334 ] Keith Wall commented on QPID-7832: -- Hi Rob, Sorry I overlooked the arrival of your comments. Yes, point taken, with hindsight that would have been a better way to proceed. That said, much of the size of the patch actually came from fixing of (existing and new for v7) QBB direct leaks (some new with v7, some existing with lots associated with the handling of buffers after error conditions) rather than the change directly. This contributed lots of try-with-resources noise. It would have been preferable if this was separated from the initial refactor. > Refactor store/protocol API using Collection > - > > Key: QPID-7832 > URL: https://issues.apache.org/jira/browse/QPID-7832 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7832-Java-Broker-Refactor-store-protocol-API-us.patch > > > Store/protocol APIs have gradually been evolving to accept/return message > content/message metadata in terms of an ordered list of QBBs. This has lead > to use of helper methods such as those in QBBUtils which read from a list of > buffers rather than a single one. > This would be better refactored. QpidByteBuffer should be an interface. > This would allow a concrete implementation CompositeQpidByteBuffer which is > backed by a list produced by the store or network IO. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7832) Refactor store/protocol API using Collection
[ https://issues.apache.org/jira/browse/QPID-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210939#comment-16210939 ] ASF subversion and git services commented on QPID-7832: --- Commit e9e0e74e7b23587fbc384aaf03250a3c3e0c7624 in qpid-broker-j's branch refs/heads/master from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=e9e0e74 ] QPID-7832: Fix infinite recursion when handling an AMQP1.0 message encoded in the version 0 format. Fixes regression introduced by 660c206deb352aca3694a6b31f5f7cf6fca70533 End to end test added. > Refactor store/protocol API using Collection > - > > Key: QPID-7832 > URL: https://issues.apache.org/jira/browse/QPID-7832 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7832-Java-Broker-Refactor-store-protocol-API-us.patch > > > Store/protocol APIs have gradually been evolving to accept/return message > content/message metadata in terms of an ordered list of QBBs. This has lead > to use of helper methods such as those in QBBUtils which read from a list of > buffers rather than a single one. > This would be better refactored. QpidByteBuffer should be an interface. > This would allow a concrete implementation CompositeQpidByteBuffer which is > backed by a list produced by the store or network IO. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7832) Refactor store/protocol API using Collection
[ https://issues.apache.org/jira/browse/QPID-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209628#comment-16209628 ] Rob Godfrey commented on QPID-7832: --- Ah - I see it has already been applied - but the commit message hasn't made it to JIRA yet :-) The general point about larger pieces of work still stands though I think > Refactor store/protocol API using Collection > - > > Key: QPID-7832 > URL: https://issues.apache.org/jira/browse/QPID-7832 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7832-Java-Broker-Refactor-store-protocol-API-us.patch > > > Store/protocol APIs have gradually been evolving to accept/return message > content/message metadata in terms of an ordered list of QBBs. This has lead > to use of helper methods such as those in QBBUtils which read from a list of > buffers rather than a single one. > This would be better refactored. QpidByteBuffer should be an interface. > This would allow a concrete implementation CompositeQpidByteBuffer which is > backed by a list produced by the store or network IO. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7832) Refactor store/protocol API using Collection
[ https://issues.apache.org/jira/browse/QPID-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209619#comment-16209619 ] Rob Godfrey commented on QPID-7832: --- This looks like it could be quite a substantial change - would it make sense to have this up as a branch / PR somewhere that people can see evolving? I guess this is a general process question for whenever people are working on larger changes > Refactor store/protocol API using Collection > - > > Key: QPID-7832 > URL: https://issues.apache.org/jira/browse/QPID-7832 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7832-Java-Broker-Refactor-store-protocol-API-us.patch > > > Store/protocol APIs have gradually been evolving to accept/return message > content/message metadata in terms of an ordered list of QBBs. This has lead > to use of helper methods such as those in QBBUtils which read from a list of > buffers rather than a single one. > This would be better refactored. QpidByteBuffer should be an interface. > This would allow a concrete implementation CompositeQpidByteBuffer which is > backed by a list produced by the store or network IO. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7832) Refactor store/protocol API using Collection
[ https://issues.apache.org/jira/browse/QPID-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209617#comment-16209617 ] Keith Wall commented on QPID-7832: -- Lorenz and I paired on this work. > Refactor store/protocol API using Collection > - > > Key: QPID-7832 > URL: https://issues.apache.org/jira/browse/QPID-7832 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7832-Java-Broker-Refactor-store-protocol-API-us.patch > > > Store/protocol APIs have gradually been evolving to accept/return message > content/message metadata in terms of an ordered list of QBBs. This has lead > to use of helper methods such as those in QBBUtils which read from a list of > buffers rather than a single one. > This would be better refactored. QpidByteBuffer should be an interface. > This would allow a concrete implementation CompositeQpidByteBuffer which is > backed by a list produced by the store or network IO. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
