[jira] [Commented] (QPIDJMS-402) Massive performance degradation in 0.34.0

2018-07-19 Thread Johan Stenberg (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549009#comment-16549009
 ] 

Johan Stenberg commented on QPIDJMS-402:


Addressed with 
https://github.com/apache/qpid-jms/commit/264a9a9b6c5d8d8c11a995b7b02289b2938d77ba
 

> Massive performance degradation in 0.34.0
> -
>
> Key: QPIDJMS-402
> URL: https://issues.apache.org/jira/browse/QPIDJMS-402
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.34.0
> Environment: Windows 7x64 + Oracle JDK 8u161x64
> Windows 7x64 + Open JDK 8u171x64
> CloudFoundry (Ubuntu Trusty) + Open JDK 8u172x64
>Reporter: Johan Stenberg
>Priority: Critical
> Fix For: 0.35.0
>
> Attachments: QpidJms402_PerfTest.java, 
> image-2018-07-13-16-39-19-707.png, qpidjms402.zip
>
>
> This is a followup issue for 
> [http://qpid.2158936.n2.nabble.com/qpid-jms-Severe-performance-issue-after-upgrading-from-0-33-0-to-0-34-0-td7678052.html]
> I am attaching a simple test case that shows the issue. When I use qpid jms 
> 0.33 I get 2000msg/s send + receive on my local machine. When I switch to 
> 0.34 the message rate drops to 20msg/s.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-402) Massive performance degradation in 0.34.0

2018-07-13 Thread Johan Stenberg (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543808#comment-16543808
 ] 

Johan Stenberg commented on QPIDJMS-402:


and this https://github.com/LMAX-Exchange/disruptor/issues/157

> Massive performance degradation in 0.34.0
> -
>
> Key: QPIDJMS-402
> URL: https://issues.apache.org/jira/browse/QPIDJMS-402
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.34.0
> Environment: Windows 7x64 + Oracle JDK 8u161x64
> Windows 7x64 + Open JDK 8u171x64
> CloudFoundry (Ubuntu Trusty) + Open JDK 8u172x64
>Reporter: Johan Stenberg
>Priority: Critical
> Attachments: QpidJms402_PerfTest.java, 
> image-2018-07-13-16-39-19-707.png, qpidjms402.zip
>
>
> This is a followup issue for 
> [http://qpid.2158936.n2.nabble.com/qpid-jms-Severe-performance-issue-after-upgrading-from-0-33-0-to-0-34-0-td7678052.html]
> I am attaching a simple test case that shows the issue. When I use qpid jms 
> 0.33 I get 2000msg/s send + receive on my local machine. When I switch to 
> 0.34 the message rate drops to 20msg/s.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-402) Massive performance degradation in 0.34.0

2018-07-13 Thread Johan Stenberg (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543804#comment-16543804
 ] 

Johan Stenberg commented on QPIDJMS-402:


I just came across this, maybe it helps 
http://vanillajava.blogspot.com/2012/04/yield-sleep0-wait01-and-parknanos1.html

> Massive performance degradation in 0.34.0
> -
>
> Key: QPIDJMS-402
> URL: https://issues.apache.org/jira/browse/QPIDJMS-402
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.34.0
> Environment: Windows 7x64 + Oracle JDK 8u161x64
> Windows 7x64 + Open JDK 8u171x64
> CloudFoundry (Ubuntu Trusty) + Open JDK 8u172x64
>Reporter: Johan Stenberg
>Priority: Critical
> Attachments: QpidJms402_PerfTest.java, 
> image-2018-07-13-16-39-19-707.png, qpidjms402.zip
>
>
> This is a followup issue for 
> [http://qpid.2158936.n2.nabble.com/qpid-jms-Severe-performance-issue-after-upgrading-from-0-33-0-to-0-34-0-td7678052.html]
> I am attaching a simple test case that shows the issue. When I use qpid jms 
> 0.33 I get 2000msg/s send + receive on my local machine. When I switch to 
> 0.34 the message rate drops to 20msg/s.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-402) Massive performance degradation in 0.34.0

2018-07-13 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543755#comment-16543755
 ] 

Robbie Gemmell commented on QPIDJMS-402:


>From the testing done so far we saw two things that slow things down on 
>Windows, but speed things up on Linux. Perhaps thats also in play on the OSX 
>side as well, at least somewhat. I'll probably ask you try try some things 
>next week. Tim's been working on some changes while I've been busy doing 
>proton-j releases, and we will pick up more on Monday to see what looks like 
>the way forward.

> Massive performance degradation in 0.34.0
> -
>
> Key: QPIDJMS-402
> URL: https://issues.apache.org/jira/browse/QPIDJMS-402
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.34.0
> Environment: Windows 7x64 + Oracle JDK 8u161x64
> Windows 7x64 + Open JDK 8u171x64
> CloudFoundry (Ubuntu Trusty) + Open JDK 8u172x64
>Reporter: Johan Stenberg
>Priority: Critical
> Attachments: QpidJms402_PerfTest.java, 
> image-2018-07-13-16-39-19-707.png, qpidjms402.zip
>
>
> This is a followup issue for 
> [http://qpid.2158936.n2.nabble.com/qpid-jms-Severe-performance-issue-after-upgrading-from-0-33-0-to-0-34-0-td7678052.html]
> I am attaching a simple test case that shows the issue. When I use qpid jms 
> 0.33 I get 2000msg/s send + receive on my local machine. When I switch to 
> 0.34 the message rate drops to 20msg/s.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-402) Massive performance degradation in 0.34.0

2018-07-13 Thread Rob Godfrey (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543700#comment-16543700
 ] 

Rob Godfrey commented on QPIDJMS-402:
-

[~gemmellr] so I've now tried two more Mac laptops.  On my 2017 15" MacBook Pro 
I saw 0.34 being faster than 0.33 (though nowhere near as dramatically as the 
improvement I saw on Fedora).  On my 2013 13" MacBook Pro I see numbers much 
closer to those from my 2018 12" MacBook (non-Pro) which I shared earlier.  
Unlike the first laptop, the 2013 13" has active cooling and so is not 
thermally throttled in "normal" operation, yet I get 11500msg/s on 0.33 and 
8800msg/s on 0.34 ... so I think the best we can say is that results on OS X 
are hardware dependant (all the laptops are running OS X 10.13).

> Massive performance degradation in 0.34.0
> -
>
> Key: QPIDJMS-402
> URL: https://issues.apache.org/jira/browse/QPIDJMS-402
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.34.0
> Environment: Windows 7x64 + Oracle JDK 8u161x64
> Windows 7x64 + Open JDK 8u171x64
> CloudFoundry (Ubuntu Trusty) + Open JDK 8u172x64
>Reporter: Johan Stenberg
>Priority: Critical
> Attachments: QpidJms402_PerfTest.java, 
> image-2018-07-13-16-39-19-707.png, qpidjms402.zip
>
>
> This is a followup issue for 
> [http://qpid.2158936.n2.nabble.com/qpid-jms-Severe-performance-issue-after-upgrading-from-0-33-0-to-0-34-0-td7678052.html]
> I am attaching a simple test case that shows the issue. When I use qpid jms 
> 0.33 I get 2000msg/s send + receive on my local machine. When I switch to 
> 0.34 the message rate drops to 20msg/s.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-402) Massive performance degradation in 0.34.0

2018-07-13 Thread Johan Stenberg (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543365#comment-16543365
 ] 

Johan Stenberg commented on QPIDJMS-402:


I'm relieved you can reproduce it too :) 

I also saw a (however not so dramatic) performance degradation on CloudFoundry 
managed Java containers running on AWS EC2 instances.

> Massive performance degradation in 0.34.0
> -
>
> Key: QPIDJMS-402
> URL: https://issues.apache.org/jira/browse/QPIDJMS-402
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.34.0
> Environment: Windows 7x64 + Oracle JDK 8u161x64
> Windows 7x64 + Open JDK 8u171x64
> CloudFoundry (Ubuntu Trusty) + Open JDK 8u172x64
>Reporter: Johan Stenberg
>Priority: Critical
> Attachments: QpidJms402_PerfTest.java, 
> image-2018-07-13-16-39-19-707.png, qpidjms402.zip
>
>
> This is a followup issue for 
> [http://qpid.2158936.n2.nabble.com/qpid-jms-Severe-performance-issue-after-upgrading-from-0-33-0-to-0-34-0-td7678052.html]
> I am attaching a simple test case that shows the issue. When I use qpid jms 
> 0.33 I get 2000msg/s send + receive on my local machine. When I switch to 
> 0.34 the message rate drops to 20msg/s.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-402) Massive performance degradation in 0.34.0

2018-07-13 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543344#comment-16543344
 ] 

Robbie Gemmell commented on QPIDJMS-402:


I did some tests in a Windows 10 env also and do see similar issue, numbers 
went from from ~38k average (peaks 43k / 42k) down to ~2.5k average (peaks 7.5k 
/ 5k). Some previous testing on Macs didn't show similar slowdown, though it 
was under Linux. I wonder if that might be thermal related on the laptop in 
question, but Rob is going to try another system to see how it behaves.

Your last comment is somehow in line with our thinking so far, that its getting 
in there and parking more than it does when not on Linux. [~tabish121] has one 
though on that I'm going to give a try out shortly.

> Massive performance degradation in 0.34.0
> -
>
> Key: QPIDJMS-402
> URL: https://issues.apache.org/jira/browse/QPIDJMS-402
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.34.0
> Environment: Windows 7x64 + Oracle JDK 8u161x64
> Windows 7x64 + Open JDK 8u171x64
> CloudFoundry (Ubuntu Trusty) + Open JDK 8u172x64
>Reporter: Johan Stenberg
>Priority: Critical
> Attachments: QpidJms402_PerfTest.java, 
> image-2018-07-13-16-39-19-707.png, qpidjms402.zip
>
>
> This is a followup issue for 
> [http://qpid.2158936.n2.nabble.com/qpid-jms-Severe-performance-issue-after-upgrading-from-0-33-0-to-0-34-0-td7678052.html]
> I am attaching a simple test case that shows the issue. When I use qpid jms 
> 0.33 I get 2000msg/s send + receive on my local machine. When I switch to 
> 0.34 the message rate drops to 20msg/s.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-402) Massive performance degradation in 0.34.0

2018-07-13 Thread Johan Stenberg (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543334#comment-16543334
 ] 

Johan Stenberg commented on QPIDJMS-402:


It looks like the new implementation tries to be too clever. The by far best 
results I by stripping down the sync method to this:

{code:java}
   public void sync() throws IOException {
  try {
 int idleCount = 0;

 while (true) {
if (isComplete()) {
   failOnError();
   return;
}

if (idleCount < SPIN_COUNT) {
   idleCount++;
} else if (idleCount < YIELD_COUNT) {
   Thread.yield();
   idleCount++;
} else {
   synchronized (this) {
  if (isComplete()) {
 failOnError();
 return;
  }

  waiting++;
  try {
 wait();
  } finally {
 waiting--;
  }
   }
}
 }
  } catch (final InterruptedException e) {
 Thread.interrupted();
 throw IOExceptionSupport.create(e);
  }
   }
{code}

If idleCount is > YIELD_COUNT it seems much more efficient to directly go into 
wait instead of doing the parkNanos magic first. Also I strongly believe the 
"if currentThread.isInterrupted()" check is unnecessary. Removing it gives me 
another good 8-10% higher throughput.

With this code change I get 45.000 msg/s with v0.34 compared to 32.958 msg/s 
with v0.33.0. Without that code change I get between 100 and 1000 msg/s with 
0.34.0.

> Massive performance degradation in 0.34.0
> -
>
> Key: QPIDJMS-402
> URL: https://issues.apache.org/jira/browse/QPIDJMS-402
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.34.0
> Environment: Windows 7x64 + Oracle JDK 8u161x64
> Windows 7x64 + Open JDK 8u171x64
> CloudFoundry (Ubuntu Trusty) + Open JDK 8u172x64
>Reporter: Johan Stenberg
>Priority: Critical
> Attachments: QpidJms402_PerfTest.java, 
> image-2018-07-13-16-39-19-707.png, qpidjms402.zip
>
>
> This is a followup issue for 
> [http://qpid.2158936.n2.nabble.com/qpid-jms-Severe-performance-issue-after-upgrading-from-0-33-0-to-0-34-0-td7678052.html]
> I am attaching a simple test case that shows the issue. When I use qpid jms 
> 0.33 I get 2000msg/s send + receive on my local machine. When I switch to 
> 0.34 the message rate drops to 20msg/s.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-402) Massive performance degradation in 0.34.0

2018-07-13 Thread Johan Stenberg (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543320#comment-16543320
 ] 

Johan Stenberg commented on QPIDJMS-402:


If I am commenting out these lines 
[https://github.com/apache/qpid-jms/blob/f29284c6ccf74c9186cea35302c8896cc8089ac5/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/ProviderFuture.java#L215]
 and 
[https://github.com/apache/qpid-jms/blob/f29284c6ccf74c9186cea35302c8896cc8089ac5/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/ProviderFuture.java#L218]
 performance is back to normal.

> Massive performance degradation in 0.34.0
> -
>
> Key: QPIDJMS-402
> URL: https://issues.apache.org/jira/browse/QPIDJMS-402
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.34.0
> Environment: Windows 7x64 + Oracle JDK 8u161x64
> Windows 7x64 + Open JDK 8u171x64
> CloudFoundry (Ubuntu Trusty) + Open JDK 8u172x64
>Reporter: Johan Stenberg
>Priority: Critical
> Attachments: QpidJms402_PerfTest.java, 
> image-2018-07-13-16-39-19-707.png, qpidjms402.zip
>
>
> This is a followup issue for 
> [http://qpid.2158936.n2.nabble.com/qpid-jms-Severe-performance-issue-after-upgrading-from-0-33-0-to-0-34-0-td7678052.html]
> I am attaching a simple test case that shows the issue. When I use qpid jms 
> 0.33 I get 2000msg/s send + receive on my local machine. When I switch to 
> 0.34 the message rate drops to 20msg/s.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-402) Massive performance degradation in 0.34.0

2018-07-13 Thread Johan Stenberg (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543285#comment-16543285
 ] 

Johan Stenberg commented on QPIDJMS-402:


On some test runs I also only get 70msg/s. I attached the VisualVM profiler and 
can see that on these extremly slow runs the ProviderFuture is spending most if 
its time doing LockSupport.parkNanos().

 

!image-2018-07-13-16-39-19-707.png!

> Massive performance degradation in 0.34.0
> -
>
> Key: QPIDJMS-402
> URL: https://issues.apache.org/jira/browse/QPIDJMS-402
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.34.0
> Environment: Windows 7x64 + Oracle JDK 8u161x64
> Windows 7x64 + Open JDK 8u171x64
> CloudFoundry (Ubuntu Trusty) + Open JDK 8u172x64
>Reporter: Johan Stenberg
>Priority: Critical
> Attachments: QpidJms402_PerfTest.java, 
> image-2018-07-13-16-39-19-707.png, qpidjms402.zip
>
>
> This is a followup issue for 
> [http://qpid.2158936.n2.nabble.com/qpid-jms-Severe-performance-issue-after-upgrading-from-0-33-0-to-0-34-0-td7678052.html]
> I am attaching a simple test case that shows the issue. When I use qpid jms 
> 0.33 I get 2000msg/s send + receive on my local machine. When I switch to 
> 0.34 the message rate drops to 20msg/s.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-402) Massive performance degradation in 0.34.0

2018-07-13 Thread Rob Godfrey (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543213#comment-16543213
 ] 

Rob Godfrey commented on QPIDJMS-402:
-

Testing on my machines, the machine/operating system certainly seems to 
influence which version is faster.  And on Win 10 I do see *really* poor 
performance.

On my Mac laptop, 0.33.0 was consistently faster:

0.33.0:

Sent: 13362 msg/s Received: 13140 msg/s
Sent: 13680 msg/s Received: 13513 msg/s
Sent: 12571 msg/s Received: 12692 msg/s
Sent: 11124 msg/s Received: 11283 msg/s

0.34.0:

Sent: 9360 msg/s Received: 9360 msg/s
Sent: 9246 msg/s Received: 9246 msg/s
Sent: 9975 msg/s Received: 9974 msg/s
Sent: 9859 msg/s Received: 9858 msg/s

However, on my Dell XPS 15, running Fedora I get

0.33.0:

Sent: 52921 msg/s Received: 49663 msg/s
Sent: 51995 msg/s Received: 50321 msg/s
Sent: 51277 msg/s Received: 48177 msg/s
Sent: 51958 msg/s Received: 48534 msg/s

0.34.0:

Sent: 72084 msg/s Received: 72077 msg/s
Sent: 72134 msg/s Received: 72123 msg/s
Sent: 72049 msg/s Received: 72063 msg/s
Sent: 70504 msg/s Received: 70497 msg/s

Switching over to running Windows 10 on that same Dell XPS 15:

0.33:

Sent: 43435 msg/s Received: 43434 msg/s
Sent: 41245 msg/s Received: 41246 msg/s
Sent: 42785 msg/s Received: 42786 msg/s
Sent: 42807 msg/s Received: 42807 msg/s

0.34:

Sent: 68 msg/s Received: 68 msg/s
Sent: 78 msg/s Received: 71 msg/s
Sent: 77 msg/s Received: 68 msg/s
Sent: 68 msg/s Received: 73 msg/s



> Massive performance degradation in 0.34.0
> -
>
> Key: QPIDJMS-402
> URL: https://issues.apache.org/jira/browse/QPIDJMS-402
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.34.0
> Environment: Windows 7x64 + Oracle JDK 8u161x64
> Windows 7x64 + Open JDK 8u171x64
> CloudFoundry (Ubuntu Trusty) + Open JDK 8u172x64
>Reporter: Johan Stenberg
>Priority: Critical
> Attachments: QpidJms402_PerfTest.java, qpidjms402.zip
>
>
> This is a followup issue for 
> [http://qpid.2158936.n2.nabble.com/qpid-jms-Severe-performance-issue-after-upgrading-from-0-33-0-to-0-34-0-td7678052.html]
> I am attaching a simple test case that shows the issue. When I use qpid jms 
> 0.33 I get 2000msg/s send + receive on my local machine. When I switch to 
> 0.34 the message rate drops to 20msg/s.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-402) Massive performance degradation in 0.34.0

2018-07-13 Thread Johan Stenberg (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543013#comment-16543013
 ] 

Johan Stenberg commented on QPIDJMS-402:


If I am using v0.33 and replace the org.apache.qpid.jms.provider.ProviderFuture 
class with the one from 0.34. Then I also see the performance degradation.

> Massive performance degradation in 0.34.0
> -
>
> Key: QPIDJMS-402
> URL: https://issues.apache.org/jira/browse/QPIDJMS-402
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.34.0
> Environment: Windows 7x64 + Oracle JDK 8u161x64
> Windows 7x64 + Open JDK 8u171x64
> CloudFoundry (Ubuntu Trusty) + Open JDK 8u172x64
>Reporter: Johan Stenberg
>Priority: Critical
> Attachments: QpidJms402_PerfTest.java, qpidjms402.zip
>
>
> This is a followup issue for 
> [http://qpid.2158936.n2.nabble.com/qpid-jms-Severe-performance-issue-after-upgrading-from-0-33-0-to-0-34-0-td7678052.html]
> I am attaching a simple test case that shows the issue. When I use qpid jms 
> 0.33 I get 2000msg/s send + receive on my local machine. When I switch to 
> 0.34 the message rate drops to 20msg/s.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-402) Massive performance degradation in 0.34.0

2018-07-13 Thread Johan Stenberg (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542950#comment-16542950
 ] 

Johan Stenberg commented on QPIDJMS-402:


Creating a new producer in each iteration was not on purpose but a mistake. I 
changed the code and removed the semaphores. Running the test case I now get 
these results:

v0.33.0:
 Sent: 33844 msg/s Received: 35829 msg/s
 Sent: 34337 msg/s Received: 35908 msg/s
 Sent: 33868 msg/s Received: 32684 msg/s
 Sent: 33907 msg/s Received: 35201 msg/s

v0.34.0:
 Sent: 1097 msg/s Received: 973 msg/s
 Sent: 1905 msg/s Received: 1582 msg/s
 Sent: 3066 msg/s Received: 1638 msg/s
 Sent: 2663 msg/s Received: 1666 msg/s

Still the new version is 10-30 times slower.

I now used openjdk 1.8.0u171 64bit on Windows 7 64bit (8core,16GB RAM).

I attached a maven project to reproduce the issue. You can now switch qpid jms 
version via the qpid-jms.version system property:
{noformat}
mvn test -Dqpid-jms.version=0.33.0
mvn test -Dqpid-jms.version=0.34.0
{noformat}
 

 

> Massive performance degradation in 0.34.0
> -
>
> Key: QPIDJMS-402
> URL: https://issues.apache.org/jira/browse/QPIDJMS-402
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.34.0
> Environment: Windows 7x64 + Oracle JDK 8u161x64
> Windows 7x64 + Open JDK 8u171x64
> CloudFoundry (Ubuntu Trusty) + Open JDK 8u172x64
>Reporter: Johan Stenberg
>Priority: Critical
> Attachments: QpidJms402_PerfTest.java, qpidjms402.zip
>
>
> This is a followup issue for 
> [http://qpid.2158936.n2.nabble.com/qpid-jms-Severe-performance-issue-after-upgrading-from-0-33-0-to-0-34-0-td7678052.html]
> I am attaching a simple test case that shows the issue. When I use qpid jms 
> 0.33 I get 2000msg/s send + receive on my local machine. When I switch to 
> 0.34 the message rate drops to 20msg/s.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPIDJMS-402) Massive performance degradation in 0.34.0

2018-07-13 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542876#comment-16542876
 ] 

Robbie Gemmell commented on QPIDJMS-402:


It would be more helpful if you gave a fully runnable reproducer (whether. a 
patch into the build or an entirely separate thing) and not just some code in 
isolation. That way know we are definitely doing the same thing in the same 
way, and folks can spend time looking into the issue rather than time figuring 
out what to do to get it running.

I didn't see the same when I eventually ran your reproducer. 0.34.0 was 
significantly faster than 0.33.0 in my runs. On my ageing laptop I saw around 
3000/s for 0.33.0, whereas for 0.34.0 I saw around 5000/s. Both our numbers 
seemed surprisingly low, so I then had a closer look at the reproducer code.

A new MessageProducer is created and closed for every message sent, capping 
performance from the outset since that adds two synchronous operations per 
message. The async send inbetween them avoids adding another, though. The 
Semaphore stuff seems essentially dead code given how it is[n't] used, though 
it wouldn't normally have any effect if it were in play given the send process 
is still governed by message credit which is rarely going to allow that large a 
window to actually form.

Changing the reproducer to re-use its sender, I got around 48,000/s with 0.33.0 
and then around 71,000/s with 0.34.0 on my laptop.

Robbie

> Massive performance degradation in 0.34.0
> -
>
> Key: QPIDJMS-402
> URL: https://issues.apache.org/jira/browse/QPIDJMS-402
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.34.0
> Environment: Windows 7x64 + Oracle JDK 8u161x64
> Windows 7x64 + Open JDK 8u171x64
> CloudFoundry (Ubuntu Trusty) + Open JDK 8u172x64
>Reporter: Johan Stenberg
>Priority: Critical
> Attachments: QpidJms402_PerfTest.java
>
>
> This is a followup issue for 
> [http://qpid.2158936.n2.nabble.com/qpid-jms-Severe-performance-issue-after-upgrading-from-0-33-0-to-0-34-0-td7678052.html]
> I am attaching a simple test case that shows the issue. When I use qpid jms 
> 0.33 I get 2000msg/s send + receive on my local machine. When I switch to 
> 0.34 the message rate drops to 20msg/s.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org