[GitHub] incubator-quickstep issue #163: Marked LIP as a non-default argument.

[zuyu]

Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/163
  
@jianqiao First, it is doable. Second, I will add a argument with default 
value, without worrying about the argument order in terms of coding style.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #163: Marked LIP as a non-default argument.

[jianqiao]

Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/163
  
LGTM. Is there some special reason for doing this change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #163: Marked LIP as a non-default argument.

[zuyu]

GitHub user zuyu opened a pull request:

https://github.com/apache/incubator-quickstep/pull/163

Marked LIP as a non-default argument.

Assigned to @jianqiao.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/incubator-quickstep lip-nullptr

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #163


commit ffe183b57dada6e862128e5326ec1ff492d7af93
Author: Zuyu Zhang 
Date:   2017-01-18T01:38:50Z

Marked LIP as a non-default argument.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: release: third_party/

[Harshad Deshmukh]

Hi all,

An update on the release and third party related issues. I have created 
a branch called "lean-third-party" (link: 
https://github.com/apache/incubator-quickstep/tree/lean-third-party). 
Some highlights -


1. I removed the source code for many libraries and added patches for 
some libraries.


2. There is a shell script that downloads the source code for the third 
party libraries and optionally applies patches. No more submodules for 
such libraries.


3. Each download link points to a release version of the library. There 
are some libraries for which there is no official release version yet, 
for such libraries I haven't modified the code and let it as is. 
Upgrading the version in the future will require minor modification in 
the shell script.


Can I have some volunteers for trying out this branch and ensuring that 
the scripts download the libraries and apply the patches correctly? Once 
we get green signals from few of the volunteers, I can create a pull 
request and update the master branch.


@Zuyu: We don't know what's the right version for protobuf that we need. 
Can you please let us know?


Thanks Julian for the inputs on cleaning up the third party library.

On 01/05/2017 01:03 PM, Jignesh Patel wrote:

I think it was Zuyu. Zuyu – can you comment?

Cheers,
Jignesh

On 1/5/17, 12:56 PM, "Harshad Deshmukh"  wrote:

 If I recall correctly, one of the Quickstep developers wrote the python
 script.
 
 
 On 01/05/2017 11:43 AM, Marc Spehlmann wrote:

 > That seems to be the repo with the LLVM code for implementing IWYU. I 
think
 > what we have in our repo is scripts ontop of that library. I'm wondering
 > where the scripts came from.
 >
 > Thanks,
 > Marc
 >
 > On Thu, Jan 5, 2017 at 10:50 AM, Harshad Deshmukh 
 > wrote:
 >
 >> Hi Marc,
 >>
 >> How about this one for IWYU?
 >>
 >> https://github.com/include-what-you-use/include-what-you-use
 >> /blob/master/LICENSE.TXT
 >>
 >>
 >> On 01/05/2017 10:43 AM, Marc Spehlmann wrote:
 >>
 >>> I double checked the libraries in thirdy_party. They adhere to Apache's
 >>> 3rd
 >>> party requirement as they are all apache 2 or opensourced by Google. 
The
 >>> only issue I saw was that IWYU has no documentation. Anyone know of its
 >>> source?
 >>>
 >>> Library
 >>>
 >>> Ver
 >>>
 >>> License
 >>>
 >>> Notes
 >>>
 >>> benchmark
 >>>
 >>> Apache 2.0
 >>>
 >>> cpplint
 >>>
 >>> Google
 >>>
 >>> Header states that reuse is unconditional so long as the copyright 
header
 >>> stays intact.
 >>>
 >>> Farmhash
 >>>
 >>> Google
 >>>
 >>> No restrictions so long as COPYING file is preserved. See COPYING
 >>>
 >>> gflags
 >>>
 >>> Google
 >>>
 >>> No restrictions so long as COPYING file is preserved. See COPYING
 >>>
 >>> glog
 >>>
 >>> Google
 >>>
 >>> No restrictions so long as COPYING file is preserved. See COPYING
 >>>
 >>> gtest
 >>>
 >>> Google
 >>>
 >>> No restrictions so long as COPYING file is preserved. See COPYING in
 >>> subprojects.
 >>>
 >>> gperftools
 >>>
 >>> Google
 >>>
 >>> No restrictions so long as COPYING file is preserved.
 >>>
 >>> iwyu
 >>>
 >>>
 >>> No license present
 >>>
 >>> linenoise
 >>>
 >>> Google
 >>>
 >>> No restrictions so long as LICENSE file is preserved.
 >>>
 >>> protobuf
 >>>
 >>> Google
 >>>
 >>> No restrictions so long as LICENSE file is preserved.
 >>>
 >>> RE2
 >>>
 >>> Google
 >>>
 >>> No restrictions so long as LICENSE file is preserved.
 >>>
 >>> tmb
 >>>
 >>> Apache 2.0
 >>>
 >>> README: TMB is part of the Quickstep project (copyright Pivotal 
Software,
 >>> Inc.) and is distributed under the same license terms.
 >>>
 >>>
 >> --
 >> Thanks,
 >> Harshad
 >>
 >>
 
 --

 Thanks,
 Harshad
 
 





--
Thanks,
Harshad

[GitHub] incubator-quickstep pull request #162: Added partition_id in RelationalOpera...

[zuyu]

GitHub user zuyu opened a pull request:

https://github.com/apache/incubator-quickstep/pull/162

Added partition_id in RelationalOperator::feedInputBlock.

As a part of adding partition support, this PR added an optional 
`partition_id` in `RelationalOperator::feedInputBlock`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/incubator-quickstep 
feedInputBlock-part-id

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #162


commit b553e0115fe4130fc54d9419d0a1e6ab3ccfbfc4
Author: Zuyu Zhang 
Date:   2017-01-16T03:53:54Z

Added partition_id in feedInputBlock.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #161: Removed the unused feedInputBlocks.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/161


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #160: Added optimizer support regarding hash parti...

[zuyu]

Github user zuyu commented on the issue:

https://github.com/apache/incubator-quickstep/pull/160
  
Fixed the comments. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #160: Added optimizer support regarding has...

[jianqiao]

Github user jianqiao commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/160#discussion_r96450595
  
--- Diff: query_optimizer/physical/CreateTable.hpp ---
@@ -107,8 +115,9 @@ class CreateTable : public Physical {
   static CreateTablePtr Create(
   const std::string _name,
   const std::vector ,
-  const std::shared_ptr 
_properties) {
-return CreateTablePtr(new CreateTable(relation_name, attributes, 
block_properties));
+  const std::shared_ptr 
_properties,
+  const std::shared_ptr 
_scheme_header_proto) {
+return CreateTablePtr(new CreateTable(relation_name, attributes, 
block_properties, partition_scheme_header_proto));
--- End diff --

Add a comment for `partition_scheme_header_proto` in method header.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep issue #160: Added optimizer support regarding hash parti...

[jianqiao]

Github user jianqiao commented on the issue:

https://github.com/apache/incubator-quickstep/pull/160
  
LGTM except some minor style issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #160: Added optimizer support regarding has...

[jianqiao]

Github user jianqiao commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/160#discussion_r96449905
  
--- Diff: query_optimizer/logical/CreateTable.hpp ---
@@ -100,8 +108,9 @@ class CreateTable : public Logical {
   static CreateTablePtr Create(
   const std::string _name,
   const std::vector ,
-  const std::shared_ptr 
_properties) {
-return CreateTablePtr(new CreateTable(relation_name, attributes, 
block_properties));
+  const std::shared_ptr 
_properties,
+  const std::shared_ptr 
_scheme_header_proto) {
--- End diff --

Add a comment for `partition_scheme_header_proto` in method header (and 
mention that `partition_scheme_header_proto` can be `nullptr` if not specified).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quickstep pull request #160: Added optimizer support regarding has...

[jianqiao]

Github user jianqiao commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/160#discussion_r96445324
  
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -478,9 +484,32 @@ L::LogicalPtr Resolver::resolveCreateTable(
   std::shared_ptr
   block_properties(resolveBlockProperties(create_table_statement));
 
-  return L::CreateTable::Create(relation_name, attributes, 
block_properties);
+  std::shared_ptr 
partition_scheme_header_proto(
+  resolvePartitionClause(create_table_statement));
+
+  return L::CreateTable::Create(relation_name, attributes, 
block_properties, partition_scheme_header_proto);
+}
+
+namespace {
+
+attribute_id GetAttributeIdFromName(const 
PtrList_definition_list,
--- End diff --

Need a space between type and parameter here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---