Re: [racket-dev] [plt] Push #23903: master branch updated
I don't think we want to change how the current url struct selectors work when applied to url structs. You could probably get away with changing the url struct if you could provide functions that act the way the old selectors used to work -- does that help? Robby On Wed, Nov 23, 2011 at 12:00 PM, j...@racket-lang.org wrote: jay has updated `master' from 6a99c93ebb to 9d8d36e568. http://git.racket-lang.org/plt/6a99c93ebb..9d8d36e568 7f9818b Jay McCarthy j...@racket-lang.org 2011-11-23 10:35 : | This fixes 10497 and potentially breaks programs that assume the query of a URL is always a list. I have fixed uses in the Web Server, which I expect is the major thing affected, but much more could be. Therefore I am skeptical this is a good idea just for the representation of ?. So, I'd like other people to review the change and let me know if they think I should revert it. : _ For list-related administrative tasks: http://lists.racket-lang.org/listinfo/dev
Re: [racket-dev] [plt] Push #23903: master branch updated
I thought about that too since there are few instances where people pattern match on the URL struct. What would be a good name for the new field... url-maybe-query? On Wed, Nov 23, 2011 at 11:02 AM, Robby Findler ro...@eecs.northwestern.edu wrote: I don't think we want to change how the current url struct selectors work when applied to url structs. You could probably get away with changing the url struct if you could provide functions that act the way the old selectors used to work -- does that help? Robby On Wed, Nov 23, 2011 at 12:00 PM, j...@racket-lang.org wrote: jay has updated `master' from 6a99c93ebb to 9d8d36e568. http://git.racket-lang.org/plt/6a99c93ebb..9d8d36e568 7f9818b Jay McCarthy j...@racket-lang.org 2011-11-23 10:35 : | This fixes 10497 and potentially breaks programs that assume the query of a URL is always a list. I have fixed uses in the Web Server, which I expect is the major thing affected, but much more could be. Therefore I am skeptical this is a good idea just for the representation of ?. So, I'd like other people to review the change and let me know if they think I should revert it. : _ For list-related administrative tasks: http://lists.racket-lang.org/listinfo/dev
Re: [racket-dev] [plt] Push #23903: master branch updated
Oh, right. Pattern matching on url structs. If we want to keep that working (which I think we do), then that ties our hands much more. I believe there are some other crufty things in net/url (having to do with encodings?). Does it make sense to have a new library that does all of this right from the start and then announce that we're going to stop supporting net/url in a year or so, in favor of the new library? I see there is no net/http. so we could also do a better job with the whole simple-script-for-downloading-a-file-over-http and perhaps other things along those lines? Robby On Wed, Nov 23, 2011 at 12:05 PM, Jay McCarthy j...@racket-lang.org wrote: I thought about that too since there are few instances where people pattern match on the URL struct. What would be a good name for the new field... url-maybe-query? On Wed, Nov 23, 2011 at 11:02 AM, Robby Findler ro...@eecs.northwestern.edu wrote: I don't think we want to change how the current url struct selectors work when applied to url structs. You could probably get away with changing the url struct if you could provide functions that act the way the old selectors used to work -- does that help? Robby On Wed, Nov 23, 2011 at 12:00 PM, j...@racket-lang.org wrote: jay has updated `master' from 6a99c93ebb to 9d8d36e568. http://git.racket-lang.org/plt/6a99c93ebb..9d8d36e568 7f9818b Jay McCarthy j...@racket-lang.org 2011-11-23 10:35 : | This fixes 10497 and potentially breaks programs that assume the query of a URL is always a list. I have fixed uses in the Web Server, which I expect is the major thing affected, but much more could be. Therefore I am skeptical this is a good idea just for the representation of ?. So, I'd like other people to review the change and let me know if they think I should revert it. : _ For list-related administrative tasks: http://lists.racket-lang.org/listinfo/dev
Re: [racket-dev] [plt] Push #23903: master branch updated
I seem to recall that this has been on Eli's mind more some time and that he has something rearing to go. I think that is probably a good idea and that this breakage here is a bit too dangerous. I'll revert the commit and put a new HTTP library on my list to code and discuss with Eli. Jay On Wed, Nov 23, 2011 at 11:08 AM, Robby Findler ro...@eecs.northwestern.edu wrote: Oh, right. Pattern matching on url structs. If we want to keep that working (which I think we do), then that ties our hands much more. I believe there are some other crufty things in net/url (having to do with encodings?). Does it make sense to have a new library that does all of this right from the start and then announce that we're going to stop supporting net/url in a year or so, in favor of the new library? I see there is no net/http. so we could also do a better job with the whole simple-script-for-downloading-a-file-over-http and perhaps other things along those lines? Robby On Wed, Nov 23, 2011 at 12:05 PM, Jay McCarthy j...@racket-lang.org wrote: I thought about that too since there are few instances where people pattern match on the URL struct. What would be a good name for the new field... url-maybe-query? On Wed, Nov 23, 2011 at 11:02 AM, Robby Findler ro...@eecs.northwestern.edu wrote: I don't think we want to change how the current url struct selectors work when applied to url structs. You could probably get away with changing the url struct if you could provide functions that act the way the old selectors used to work -- does that help? Robby On Wed, Nov 23, 2011 at 12:00 PM, j...@racket-lang.org wrote: jay has updated `master' from 6a99c93ebb to 9d8d36e568. http://git.racket-lang.org/plt/6a99c93ebb..9d8d36e568 7f9818b Jay McCarthy j...@racket-lang.org 2011-11-23 10:35 : | This fixes 10497 and potentially breaks programs that assume the query of a URL is always a list. I have fixed uses in the Web Server, which I expect is the major thing affected, but much more could be. Therefore I am skeptical this is a good idea just for the representation of ?. So, I'd like other people to review the change and let me know if they think I should revert it. : _ For list-related administrative tasks: http://lists.racket-lang.org/listinfo/dev
Re: [racket-dev] [plt] Push #23903: master branch updated
On Wed, Nov 23, 2011 at 1:12 PM, Jay McCarthy j...@racket-lang.org wrote: I'll revert the commit and put a new HTTP library on my list to code and discuss with Eli. I feel like we want to fix the bug that `string-url' and `url-string' don't round-trip properly. Could you store some data in a substructure to enable that while keeping the rest of the url structure the same? -- sam th sa...@ccs.neu.edu _ For list-related administrative tasks: http://lists.racket-lang.org/listinfo/dev
Re: [racket-dev] [plt] Push #23903: master branch updated
If the new url stuff were to come out this release, then I wouldn't mind not fixing that one. FWIW. Robby On Wed, Nov 23, 2011 at 12:30 PM, Sam Tobin-Hochstadt sa...@ccs.neu.edu wrote: On Wed, Nov 23, 2011 at 1:12 PM, Jay McCarthy j...@racket-lang.org wrote: I'll revert the commit and put a new HTTP library on my list to code and discuss with Eli. I feel like we want to fix the bug that `string-url' and `url-string' don't round-trip properly. Could you store some data in a substructure to enable that while keeping the rest of the url structure the same? -- sam th sa...@ccs.neu.edu _ For list-related administrative tasks: http://lists.racket-lang.org/listinfo/dev
Re: [racket-dev] [plt] Push #23903: master branch updated
I agree with that, but software and timelines have a way of not working together. :) On Wed, Nov 23, 2011 at 1:32 PM, Robby Findler ro...@eecs.northwestern.edu wrote: If the new url stuff were to come out this release, then I wouldn't mind not fixing that one. FWIW. Robby On Wed, Nov 23, 2011 at 12:30 PM, Sam Tobin-Hochstadt sa...@ccs.neu.edu wrote: On Wed, Nov 23, 2011 at 1:12 PM, Jay McCarthy j...@racket-lang.org wrote: I'll revert the commit and put a new HTTP library on my list to code and discuss with Eli. I feel like we want to fix the bug that `string-url' and `url-string' don't round-trip properly. Could you store some data in a substructure to enable that while keeping the rest of the url structure the same? -- sam th sa...@ccs.neu.edu -- sam th sa...@ccs.neu.edu _ For list-related administrative tasks: http://lists.racket-lang.org/listinfo/dev
Re: [racket-dev] [plt] Push #23903: master branch updated
string-url and url-string don't have to round trip because url-string uses canonical percent encodings where string-url removes all percent encodings. Jay On Wed, Nov 23, 2011 at 11:35 AM, Sam Tobin-Hochstadt sa...@ccs.neu.eduwrote: I agree with that, but software and timelines have a way of not working together. :) On Wed, Nov 23, 2011 at 1:32 PM, Robby Findler ro...@eecs.northwestern.edu wrote: If the new url stuff were to come out this release, then I wouldn't mind not fixing that one. FWIW. Robby On Wed, Nov 23, 2011 at 12:30 PM, Sam Tobin-Hochstadt sa...@ccs.neu.edu wrote: On Wed, Nov 23, 2011 at 1:12 PM, Jay McCarthy j...@racket-lang.org wrote: I'll revert the commit and put a new HTTP library on my list to code and discuss with Eli. I feel like we want to fix the bug that `string-url' and `url-string' don't round-trip properly. Could you store some data in a substructure to enable that while keeping the rest of the url structure the same? -- sam th sa...@ccs.neu.edu -- sam th sa...@ccs.neu.edu _ For list-related administrative tasks: http://lists.racket-lang.org/listinfo/dev
Re: [racket-dev] [plt] Push #23903: master branch updated
Hello, On Wed, Nov 23, 2011 at 16:08, Robby Findler ro...@eecs.northwestern.eduwrote: Oh, right. Pattern matching on url structs. If we want to keep that working (which I think we do), then that ties our hands much more. I believe there are some other crufty things in net/url (having to do with encodings?). I've reported some time ago that I had problems with non-UTF8 encodings, such as uri-decode etc calling /utf8 functions instead of using byte-strings. If time would permit I'd implement supplementary versions of those functions to work on byte-string and make no assumptions on encoding. But in case a new library is in the way, then I think it can be made so that it doesn't assume any particular encoding. []'s Rodolfo Carvalho _ For list-related administrative tasks: http://lists.racket-lang.org/listinfo/dev
Re: [racket-dev] [plt] Push #23903: master branch updated
Definitely that's one of the things it would do. Thanks for the reminder. On Wed, Nov 23, 2011 at 3:21 PM, Rodolfo Carvalho rhcarva...@gmail.comwrote: Hello, On Wed, Nov 23, 2011 at 16:08, Robby Findler ro...@eecs.northwestern.eduwrote: Oh, right. Pattern matching on url structs. If we want to keep that working (which I think we do), then that ties our hands much more. I believe there are some other crufty things in net/url (having to do with encodings?). I've reported some time ago that I had problems with non-UTF8 encodings, such as uri-decode etc calling /utf8 functions instead of using byte-strings. If time would permit I'd implement supplementary versions of those functions to work on byte-string and make no assumptions on encoding. But in case a new library is in the way, then I think it can be made so that it doesn't assume any particular encoding. []'s Rodolfo Carvalho _ For list-related administrative tasks: http://lists.racket-lang.org/listinfo/dev
