Re: [racket-dev] dependencies for `racket-test` package
I'm pretty sure that racket-test needs to be split up. (For the initial cut, I just put the whole tests collection there.) I'm not sure about compiling tests for the purposes of dependency checking. It sounds ok, but I have a feeling that I'm forgetting some reason that we disabled compilation for tests. At Tue, 2 Jul 2013 12:20:57 -0400, Sam Tobin-Hochstadt wrote: Currently, the `racket-test` package has very few declared dependencies, but this is wrong. The checking in 'raco setup' doesn't catch this because the files aren't compiled, but at a minimum it depends on `unstable/debug` (currently a hidden part of `typed-racket-lib`) and some portions of htdp that aren't declared. This brings up (at least) 3 questions - What is it ok for `racket-test` to depend on? I'd like this set to be small, so we can test the core without needing to build everything. - Should we compile the contents of `racket-test` so that we get dependency checking? - Should parts of `racket-test` be split up? I'd like to figure this out, but I don't have answers yet. Sam _ Racket Developers list: http://lists.racket-lang.org/dev _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] dependencies for `racket-test` package
I believe the reason we disabled compilation was that tests weren't constrained to depend only on the core. Some tests may use planet packages, etc. Originally, this was mostly for rackunit, which was a planet package. This suggests to me that we should (a) remove the test packages from the default distribution, and (b) re-enable compilation for them. That way the dependencies will be computed properly. It also suggests that if they aren't already included, perhaps we should add planet packages to the list of things we consider among dependencies? Carl Eastlund On Tue, Jul 2, 2013 at 12:42 PM, Matthew Flatt mfl...@cs.utah.edu wrote: I'm pretty sure that racket-test needs to be split up. (For the initial cut, I just put the whole tests collection there.) I'm not sure about compiling tests for the purposes of dependency checking. It sounds ok, but I have a feeling that I'm forgetting some reason that we disabled compilation for tests. At Tue, 2 Jul 2013 12:20:57 -0400, Sam Tobin-Hochstadt wrote: Currently, the `racket-test` package has very few declared dependencies, but this is wrong. The checking in 'raco setup' doesn't catch this because the files aren't compiled, but at a minimum it depends on `unstable/debug` (currently a hidden part of `typed-racket-lib`) and some portions of htdp that aren't declared. This brings up (at least) 3 questions - What is it ok for `racket-test` to depend on? I'd like this set to be small, so we can test the core without needing to build everything. - Should we compile the contents of `racket-test` so that we get dependency checking? - Should parts of `racket-test` be split up? I'd like to figure this out, but I don't have answers yet. Sam _ Racket Developers list: http://lists.racket-lang.org/dev _ Racket Developers list: http://lists.racket-lang.org/dev _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] dependencies for `racket-test` package
On Jul 2, 2013 12:42 PM, Matthew Flatt mfl...@cs.utah.edu wrote: I'm pretty sure that racket-test needs to be split up. (For the initial cut, I just put the whole tests collection there.) Sorry, I should have been more specific; 'tests/racket/stx.rktl' depends on htdp. I expect that the tests in that directory depend on other packages as well, such as sandbox and compiler. I'm not sure about compiling tests for the purposes of dependency checking. It sounds ok, but I have a feeling that I'm forgetting some reason that we disabled compilation for tests. At Tue, 2 Jul 2013 12:20:57 -0400, Sam Tobin-Hochstadt wrote: Currently, the `racket-test` package has very few declared dependencies, but this is wrong. The checking in 'raco setup' doesn't catch this because the files aren't compiled, but at a minimum it depends on `unstable/debug` (currently a hidden part of `typed-racket-lib`) and some portions of htdp that aren't declared. This brings up (at least) 3 questions - What is it ok for `racket-test` to depend on? I'd like this set to be small, so we can test the core without needing to build everything. - Should we compile the contents of `racket-test` so that we get dependency checking? - Should parts of `racket-test` be split up? I'd like to figure this out, but I don't have answers yet. Sam _ Racket Developers list: http://lists.racket-lang.org/dev _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] dependencies for `racket-test` package
At Tue, 2 Jul 2013 12:53:02 -0400, Sam Tobin-Hochstadt wrote: On Jul 2, 2013 12:42 PM, Matthew Flatt mfl...@cs.utah.edu wrote: I'm pretty sure that racket-test needs to be split up. (For the initial cut, I just put the whole tests collection there.) Sorry, I should have been more specific; 'tests/racket/stx.rktl' depends on htdp. I expect that the tests in that directory depend on other packages as well, such as sandbox and compiler. Depending on sandbox and compiler seems ok, while the tests that depend on htdp can be changed to use different modules. _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] dependencies for `racket-test` package
On Tue, Jul 2, 2013 at 12:01 PM, Matthew Flatt mfl...@cs.utah.edu wrote: At Tue, 2 Jul 2013 12:53:02 -0400, Sam Tobin-Hochstadt wrote: On Jul 2, 2013 12:42 PM, Matthew Flatt mfl...@cs.utah.edu wrote: I'm pretty sure that racket-test needs to be split up. (For the initial cut, I just put the whole tests collection there.) Sorry, I should have been more specific; 'tests/racket/stx.rktl' depends on htdp. I expect that the tests in that directory depend on other packages as well, such as sandbox and compiler. Depending on sandbox and compiler seems ok, while the tests that depend on htdp can be changed to use different modules. Or maybe, if they are actually testing htdp, move into the htdp pkg. But another issue we're forgetting here is that many of the tests are not in #lang but are load-based. Robby _ Racket Developers list: http://lists.racket-lang.org/dev
Re: [racket-dev] dependencies for `racket-test` package
On Tue, Jul 2, 2013 at 6:15 PM, Robby Findler ro...@eecs.northwestern.edu wrote: On Tue, Jul 2, 2013 at 12:01 PM, Matthew Flatt mfl...@cs.utah.edu wrote: At Tue, 2 Jul 2013 12:53:02 -0400, Sam Tobin-Hochstadt wrote: On Jul 2, 2013 12:42 PM, Matthew Flatt mfl...@cs.utah.edu wrote: I'm pretty sure that racket-test needs to be split up. (For the initial cut, I just put the whole tests collection there.) Sorry, I should have been more specific; 'tests/racket/stx.rktl' depends on htdp. I expect that the tests in that directory depend on other packages as well, such as sandbox and compiler. Depending on sandbox and compiler seems ok, while the tests that depend on htdp can be changed to use different modules. Or maybe, if they are actually testing htdp, move into the htdp pkg. The tests I was looking were testing the syntax system, so I've modified them. But another issue we're forgetting here is that many of the tests are not in #lang but are load-based. Right, those tests can't be compiled. There are lots of tests in `racket-test` (for, eg, json and pkg and xml) that are thankfully not load-based, so we should decide what to do with them. Sam _ Racket Developers list: http://lists.racket-lang.org/dev