Re: Review Request 58697: RANGER-1542:Exceptions occured when I test connection during create a new service for atlas-plugin

2017-04-27 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58697/
---

(Updated 四月 28, 2017, 1:21 a.m.)


Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, 
and Velmurugan Periasamy.


Bugs: RANGER-1542
https://issues.apache.org/jira/browse/RANGER-1542


Repository: ranger


Description (updated)
---

there is a bug, as follows:

try {
decryptedPwd = PasswordUtils.decryptPassword(password);
} catch (Exception ex) {
LOG.info("Password decryption failed; trying Atlas connection with 
received password string");
decryptedPwd = null;
} finally {
if (decryptedPwd == null) {
decryptedPwd = password;
}
}
formData.add("j_password", PasswordUtils.decryptPassword(password));

we should change the code 'formData.add("j_password", 
PasswordUtils.decryptPassword(password));'
to 'formData.add("j_password", decryptedPwd);'.


Error message poped out as below:
2017-04-25 07:02:20,358 [timed-executor-pool-0] ERROR 
org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:127) - Unable 
to decrypt password due to error
javax.crypto.BadPaddingException: Given final block not properly padded
at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:811)
at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:676)
at com.sun.crypto.provider.PBECipherCore.doFinal(PBECipherCore.java:422)
at 
com.sun.crypto.provider.PBEWithMD5AndDESCipher.engineDoFinal(PBEWithMD5AndDESCipher.java:316)
at javax.crypto.Cipher.doFinal(Cipher.java:2131)
at 
org.apache.ranger.plugin.util.PasswordUtils.decryptPassword(PasswordUtils.java:112)
at 
org.apache.ranger.services.atlas.client.AtlasClient.getStatusResponse(AtlasClient.java:183)
at 
org.apache.ranger.services.atlas.client.AtlasClient.connectionTestResource(AtlasClient.java:227)
at 
org.apache.ranger.services.atlas.client.AtlasClient$1$1.run(AtlasClient.java:123)
at 
org.apache.ranger.services.atlas.client.AtlasClient$1$1.run(AtlasClient.java:114)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:356)
at 
org.apache.ranger.services.atlas.client.AtlasClient$1.call(AtlasClient.java:114)
at 
org.apache.ranger.services.atlas.client.AtlasClient$1.call(AtlasClient.java:107)
at 
org.apache.ranger.services.atlas.client.AtlasClient.timedTask(AtlasClient.java:692)
at 
org.apache.ranger.services.atlas.client.AtlasClient.getResourceList(AtlasClient.java:161)
at 
org.apache.ranger.services.atlas.client.AtlasClient.getAtlasResource(AtlasClient.java:673)
at 
org.apache.ranger.services.atlas.client.AtlasClient.connectionTest(AtlasClient.java:619)
at 
org.apache.ranger.services.atlas.client.AtlasResourceMgr.validateConfig(AtlasResourceMgr.java:40)
at 
org.apache.ranger.services.atlas.RangerServiceAtlas.validateConfig(RangerServiceAtlas.java:58)
at 
org.apache.ranger.biz.ServiceMgr$ValidateCallable.actualCall(ServiceMgr.java:563)
at 
org.apache.ranger.biz.ServiceMgr$ValidateCallable.actualCall(ServiceMgr.java:550)
at 
org.apache.ranger.biz.ServiceMgr$TimedCallable.call(ServiceMgr.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
2017-04-25 07:02:20,358 [timed-executor-pool-0] INFO  
apache.ranger.services.atlas.client.AtlasClient (AtlasClient.java:185) - 
Password decryption failed; trying Atlas connection with received password 
string
2017-04-25 07:02:20,359 [timed-executor-pool-0] ERROR 
org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:127) - Unable 
to decrypt password due to error
javax.crypto.BadPaddingException: Given final block not properly padded
at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:811)
at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:676)
at com.sun.crypto.provider.PBECipherCore.doFinal(PBECipherCore.java:422)
at 
com.sun.crypto.provider.PBEWithMD5AndDESCipher.engineDoFinal(PBEWithMD5AndDESCipher.java:316)
at javax.crypto.Cipher.doFinal(Cipher.java:2131)
at 
org.apache.ranger.plugin.util.PasswordUtils.decryptPassword(PasswordUtils.java:112)
at 
org.apache.ranger.services.atlas.client.AtlasClient.getStatusResponse(AtlasClient.java:192)
at 
org.apache.ranger.services.atlas.client.AtlasClient.connectionTestResource(AtlasClient.java:227)

Re: Review Request 58745: RANGER-1544: Misaligned input boxes and cleanup on Reports Search

2017-04-27 Thread Gautam Borad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58745/#review173268
---


Ship it!




Ship It!

- Gautam Borad


On April 27, 2017, 9:25 p.m., Anna Shaverdian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58745/
> ---
> 
> (Updated April 27, 2017, 9:25 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1544
> https://issues.apache.org/jira/browse/RANGER-1544
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-1544
> On the Ranger Admin > User Access Report page, the input boxes for Policy 
> Type and Resource will overlap the other text boxes when resizing the window. 
> Also UserAccessLayout_tmpl.html has some typos (ie searchInfoUserAccss) and 
> needs to reformat the indentation.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/styles/xa.css 7a5ec2e 
>   
> security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html
>  31252af 
>   security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 
> f428f3a 
> 
> 
> Diff: https://reviews.apache.org/r/58745/diff/1/
> 
> 
> Testing
> ---
> 
> Cosmetic UI testing done on chrome, firefox, safari, UI boxes. 
> Corrected typos and indentation
> 
> 
> Thanks,
> 
> Anna Shaverdian
> 
>

Re: Review Request 58745: RANGER-1544: Misaligned input boxes and cleanup on Reports Search

2017-04-27 Thread Anna Shaverdian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58745/
---

(Updated April 27, 2017, 9:25 p.m.)


Review request for ranger.


Summary (updated)
-

RANGER-1544:  Misaligned input boxes and cleanup on Reports Search


Bugs: RANGER-1544
https://issues.apache.org/jira/browse/RANGER-1544


Repository: ranger


Description
---

RANGER-1544
On the Ranger Admin > User Access Report page, the input boxes for Policy Type 
and Resource will overlap the other text boxes when resizing the window. Also 
UserAccessLayout_tmpl.html has some typos (ie searchInfoUserAccss) and needs to 
reformat the indentation.


Diffs
-

  security-admin/src/main/webapp/styles/xa.css 7a5ec2e 
  
security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html 
31252af 
  security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 
f428f3a 


Diff: https://reviews.apache.org/r/58745/diff/1/


Testing
---

Cosmetic UI testing done on chrome, firefox, safari, UI boxes. 
Corrected typos and indentation


Thanks,

Anna Shaverdian

Re: Review Request 58154: Policy engine updates to support tag-based masking policies

2017-04-27 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58154/
---

(Updated April 27, 2017, 8:40 p.m.)


Review request for ranger and Madhan Neethiraj.


Changes
---

Addressed review comments


Bugs: RANGER-1493
https://issues.apache.org/jira/browse/RANGER-1493


Repository: ranger


Description
---

The policy engine is enhanced to support tag-based policies for masking as well 
i.e. evalDataMaskPolicies()


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEvaluatorForTag.java
 PRE-CREATION 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java
 904fc86 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java
 06c7d16 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
 508ef93 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
 0793a6a 


Diff: https://reviews.apache.org/r/58154/diff/3/

Changes: https://reviews.apache.org/r/58154/diff/2-3/


Testing
---

Updated Tag-Service-Definition with dataMaskDef section for hive component, 
created a tag policy for data-masking; tagged a hive column with a tag and used 
beeline to test data-masking for that column.


Thanks,

Abhay Kulkarni

[jira] [Commented] (RANGER-1499) Upgrade Tomcat version

2017-04-27 Thread Gautam Borad (JIRA) 

[ 
https://issues.apache.org/jira/browse/RANGER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987531#comment-15987531
 ] 

Gautam Borad commented on RANGER-1499:
--

Committed to master: 45f30336fd885a7bda5bb3700821ea237fb13b31
Committed to 0.7: 0a5265a54a0c12aaa5c399a3c3153b5e794783b7

> Upgrade Tomcat version
> --
>
> Key: RANGER-1499
> URL: https://issues.apache.org/jira/browse/RANGER-1499
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Velmurugan Periasamy
>Assignee: bhavik patel
> Fix For: 0.6.4, 1.0.0, 0.7.1
>
> Attachments: RANGER-1499.patch
>
>
> Tomcat version used by Ranger & Ranger KMS is 7.0.68.
> Need to upgrade to 7.0.73



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1546) Code Improvement To Follow Best Practices

2017-04-27 Thread Gautam Borad (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gautam Borad updated RANGER-1546:
-
Fix Version/s: 1.0.0

> Code Improvement To Follow Best Practices
> -
>
> Key: RANGER-1546
> URL: https://issues.apache.org/jira/browse/RANGER-1546
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: bhavik patel
>Assignee: bhavik patel
> Fix For: 1.0.0, 0.7.1
>
> Attachments: RANGER-1546-07-1.patch, RANGER-1546-master-1.patch, 
> RANGER-1546-master.patch
>
>
> Code improvement to follow best practices.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RANGER-1522) Update consolidated db schema script for SQLServer DB flavor to reduce execution time

2017-04-27 Thread Gautam Borad (JIRA) 

[ 
https://issues.apache.org/jira/browse/RANGER-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987454#comment-15987454
 ] 

Gautam Borad commented on RANGER-1522:
--

Committed to master : c01d01f54622286de7ef17b302ae0a734664a9d1
Committed to 0.7 : a7bb8e732b840bbcdcf48c49b21a8e17ea97293c

> Update consolidated db schema script for SQLServer DB flavor to reduce 
> execution time
> -
>
> Key: RANGER-1522
> URL: https://issues.apache.org/jira/browse/RANGER-1522
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 1.0.0, 0.7.1
>Reporter: Pradeep Agrawal
>Assignee: Pradeep Agrawal
> Fix For: 1.0.0, 0.7.1
>
> Attachments: RANGER-1522-0.7-branch.patch, 
> RANGER-1522-master-branch.patch
>
>
> Modify the schema file to exclude the GO statements or use the minimum number 
> of GO Statement.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58154: Policy engine updates to support tag-based masking policies

2017-04-27 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58154/#review173229
---




agents-common/src/main/java/org/apache/ranger/plugin/policyengine/DataMaskOrRowFilterEvaluator.java
Lines 31 (patched)


Since 'DataMaskOrRowFilterEvaluator' class is not specific to DataMask or 
RowFilter policies, consider renaming to 'PolicyEvaluatorForTag'.



agents-common/src/main/java/org/apache/ranger/plugin/policyengine/DataMaskOrRowFilterEvaluator.java
Lines 43 (patched)


Instead of sending a boolean argument, consider sending 
List, as below:

return getPolicyEvaluators(tags, tagPolicyRepository, 
tagPolicyRepository.getDataMaskPolicyEvaluators());

Same applies for getDataMaskOrRowFilterEvaluators() as well.

Also, consider moving these methods to RangerPolicyRepository:

  getDataMaskPolicyEvaluators(Set tags)
  getRowFilterPolicyEvaluators(Set tags)


- Madhan Neethiraj


On April 26, 2017, 11:14 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58154/
> ---
> 
> (Updated April 26, 2017, 11:14 p.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-1493
> https://issues.apache.org/jira/browse/RANGER-1493
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> The policy engine is enhanced to support tag-based policies for masking as 
> well i.e. evalDataMaskPolicies()
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/DataMaskOrRowFilterEvaluator.java
>  PRE-CREATION 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.java
>  9d8a651 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java
>  904fc86 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java
>  06c7d16 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
>  508ef93 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
>  0793a6a 
> 
> 
> Diff: https://reviews.apache.org/r/58154/diff/2/
> 
> 
> Testing
> ---
> 
> Updated Tag-Service-Definition with dataMaskDef section for hive component, 
> created a tag policy for data-masking; tagged a hive column with a tag and 
> used beeline to test data-masking for that column.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

[jira] [Updated] (RANGER-1471) Remember filters on all tabs of Ranger Audits page

2017-04-27 Thread Gautam Borad (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gautam Borad updated RANGER-1471:
-
Fix Version/s: master

> Remember filters on all tabs of Ranger Audits page
> --
>
> Key: RANGER-1471
> URL: https://issues.apache.org/jira/browse/RANGER-1471
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Affects Versions: 0.7.1
>Reporter: bhavik patel
>Assignee: bhavik patel
> Fix For: master, 0.7.1
>
> Attachments: RANGER-1471-07.patch, RANGER-1471-1.patch, 
> RANGER-1471-2.patch, RANGER-1471-master.patch, RANGER-1471.patch
>
>
> Currently, when we apply filter for anything in Ranger Audit page for any of 
> the tabs. It resets the filter on change of tab or if we move to any other 
> page in Ranger.
> Planning to add feature of remembering latest filters on all Tabs of Audits 
> page. That will help users to stay focused on what they are looking for in 
> audits tab and users will not have to apply for filters again and again to 
> check audit events of a particular service.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RANGER-1471) Remember filters on all tabs of Ranger Audits page

2017-04-27 Thread Gautam Borad (JIRA) 

[ 
https://issues.apache.org/jira/browse/RANGER-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987094#comment-15987094
 ] 

Gautam Borad commented on RANGER-1471:
--

Committed to master : c7784876173bc9eafd1c47def7f45bad3b5010ac
Committed to 0.7 : 1a461ecfb7b4c0e8005d06e8d9d2dfb7c65a1497

> Remember filters on all tabs of Ranger Audits page
> --
>
> Key: RANGER-1471
> URL: https://issues.apache.org/jira/browse/RANGER-1471
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Affects Versions: 0.7.1
>Reporter: bhavik patel
>Assignee: bhavik patel
> Fix For: 0.7.1
>
> Attachments: RANGER-1471-07.patch, RANGER-1471-1.patch, 
> RANGER-1471-2.patch, RANGER-1471-master.patch, RANGER-1471.patch
>
>
> Currently, when we apply filter for anything in Ranger Audit page for any of 
> the tabs. It resets the filter on change of tab or if we move to any other 
> page in Ranger.
> Planning to add feature of remembering latest filters on all Tabs of Audits 
> page. That will help users to stay focused on what they are looking for in 
> audits tab and users will not have to apply for filters again and again to 
> check audit events of a particular service.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 58804: RANGER-1549 - Add COMPONENT_INSTALL_DIR_NAME to the Storm install.properties

2017-04-27 Thread Colm O hEigeartaigh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58804/
---

Review request for ranger.


Bugs: RANGER-1549
https://issues.apache.org/jira/browse/RANGER-1549


Repository: ranger


Description
---

Add COMPONENT_INSTALL_DIR_NAME to the Storm install.properties as per the other 
plugins.


Diffs
-

  storm-agent/scripts/install.properties 7aaa32f4 


Diff: https://reviews.apache.org/r/58804/diff/1/


Testing
---


Thanks,

Colm O hEigeartaigh

[jira] [Updated] (RANGER-1549) Add COMPONENT_INSTALL_DIR_NAME to the Storm install.properties

2017-04-27 Thread Colm O hEigeartaigh (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated RANGER-1549:

Attachment: 0001-RANGER-1549-Add-COMPONENT_INSTALL_DIR_NAME-to-the-St.patch

> Add COMPONENT_INSTALL_DIR_NAME to the Storm install.properties
> --
>
> Key: RANGER-1549
> URL: https://issues.apache.org/jira/browse/RANGER-1549
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Reporter: Colm O hEigeartaigh
>Assignee: Colm O hEigeartaigh
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-1549-Add-COMPONENT_INSTALL_DIR_NAME-to-the-St.patch
>
>
> Add COMPONENT_INSTALL_DIR_NAME to the Storm install.properties as per the 
> other plugins.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RANGER-1549) Add COMPONENT_INSTALL_DIR_NAME to the Storm install.properties

2017-04-27 Thread Colm O hEigeartaigh (JIRA) 
Colm O hEigeartaigh created RANGER-1549:
---

 Summary: Add COMPONENT_INSTALL_DIR_NAME to the Storm 
install.properties
 Key: RANGER-1549
 URL: https://issues.apache.org/jira/browse/RANGER-1549
 Project: Ranger
  Issue Type: Improvement
  Components: plugins
Reporter: Colm O hEigeartaigh
Assignee: Colm O hEigeartaigh
 Fix For: 1.0.0


Add COMPONENT_INSTALL_DIR_NAME to the Storm install.properties as per the other 
plugins.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57837: Remember filters on all tabs of Ranger Audits page

2017-04-27 Thread Gautam Borad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57837/#review173218
---


Ship it!




Ship It!

- Gautam Borad


On April 26, 2017, 4:41 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57837/
> ---
> 
> (Updated April 26, 2017, 4:41 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1471
> https://issues.apache.org/jira/browse/RANGER-1471
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently, when we apply filter for anything in Ranger Audit page for any of 
> the tabs. It resets the filter on change of tab or if we move to any other 
> page in Ranger.
> Planning to add feature of remembering latest filters on all Tabs of Audits 
> page. That will help users to stay focused on what they are looking for in 
> audits tab and users will not have to apply for filters again and again to 
> check audit events of a particular service.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java 
> fe253ef 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java ed34525 
>   security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 0776021 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java 0a30cf6 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> 4a153bf 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 480c515 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 1277334 
>   security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js 
> 6f1069d 
>   security-admin/src/main/webapp/styles/xa.css 7a5ec2e 
>   
> security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html
>  ea2f198 
>   security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 
> 028fdbf 
>   
> security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html 
> ddd6e3d 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java 
> c544832 
> 
> 
> Diff: https://reviews.apache.org/r/57837/diff/4/
> 
> 
> Testing
> ---
> 
> 1. Tested multiple search is working correctly in "Audit" tab.
> 2. Tested search remains the same when we navigate from one tab to other.
> 3. Tested search is working correctly for different user role.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 58781: RANGER-1546 : Code Improvement To Follow Best Practice

2017-04-27 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58781/#review173206
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 27, 2017, 7 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58781/
> ---
> 
> (Updated April 27, 2017, 7 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1546
> https://issues.apache.org/jira/browse/RANGER-1546
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Code improvement to follow best practices.
> 
> 
> Diffs
> -
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java 
> 1485c0f 
>   
> agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java
>  a2c5193 
>   
> knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java
>  ec08ae8 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 
> 5521ae8 
> 
> 
> Diff: https://reviews.apache.org/r/58781/diff/1/
> 
> 
> Testing
> ---
> 
> 1.Verified Ranger Admin & Ranger KMS on kerberized & SSL enabled environment.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 58526: RANGER-1522 : (Ranger-0.7 branch) Update consolidated db schema script for SQLServer DB flavor to reduce execution time

2017-04-27 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58526/#review173203
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 26, 2017, 5:06 p.m., Pradeep Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58526/
> ---
> 
> (Updated April 26, 2017, 5:06 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1522
> https://issues.apache.org/jira/browse/RANGER-1522
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> **Problem Statement:** Script created for RANGER-1401 need to be created for 
> RANGER 0.7 version and script should be updated without or minimum number of 
> GO statements. 
> 
> **Proposed Solution :** Create script for Ranger-0.7.0 version in 
> security-admin/db/sqlserver/optimized/0.7.0 location and 
> security-admin/db/sqlserver/optimized/current location.
> 
> 
> Diffs
> -
> 
>   security-admin/db/sqlserver/optimized/0.7.0/ranger_core_db_sqlserver.sql 
> 13be7da 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58526/diff/2/
> 
> 
> Testing
> ---
> 
> 1) Executed DBA Setup and ensured that ranger-admin database and ranger-admin 
> DB user are created.
> 2) From a MSSQL Client tool executed 
> security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> file on database created in previous step.
> 3) Executed DB setup and java patches execution command.
> 
> **Expected Behaviour :** Ranger setup process should skip the DB schema 
> creation and java patch execution. Ranger UI should work properly after 
> starting Ranger admin.
> **Actual Behaviour :** DB schema creation and java patch execution was 
> skipped and patches were marked executed in x_db_version_h table. After 
> Starting Ranger admin, I was able to do crud operations related to users and 
> policy.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>

Re: Review Request 58733: RANGER-1471 : Remember filters on all tabs of Ranger Audits page

2017-04-27 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58733/#review173202
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 26, 2017, 9:41 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58733/
> ---
> 
> (Updated April 26, 2017, 9:41 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1471
> https://issues.apache.org/jira/browse/RANGER-1471
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently, when we apply filter for anything in Ranger Audit page for any of 
> the tabs. It resets the filter on change of tab or if we move to any other 
> page in Ranger.
> Planning to add feature of remembering latest filters on all Tabs of Audits 
> page. That will help users to stay focused on what they are looking for in 
> audits tab and users will not have to apply for filters again and again to 
> check audit events of a particular service.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java 
> f4fcfb2 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java ed34525 
>   security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 0776021 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java fc58c7d 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> 3eda870 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 7a35ce3 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 1277334 
>   security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js 
> 6f1069d 
>   security-admin/src/main/webapp/styles/xa.css 7a5ec2e 
>   
> security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html
>  ea2f198 
>   security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 
> 028fdbf 
>   
> security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html 
> ddd6e3d 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java 
> c544832 
> 
> 
> Diff: https://reviews.apache.org/r/58733/diff/1/
> 
> 
> Testing
> ---
> 
> Tested multiple search is working correctly in "Audit" tab.
> Tested search remains the same when we navigate from one tab to other.
> Tested search is working correctly for different user role.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 58734: RANGER-1546 : Code Improvement To Follow Best Practices

2017-04-27 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58734/#review173200
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 27, 2017, 5:21 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58734/
> ---
> 
> (Updated April 27, 2017, 5:21 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1546
> https://issues.apache.org/jira/browse/RANGER-1546
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Code improvement to follow best practices.
> 
> 
> Diffs
> -
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java 
> 1485c0f 
>   
> agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java
>  a2c5193 
>   
> knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java
>  ec08ae8 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 
> efc308a 
> 
> 
> Diff: https://reviews.apache.org/r/58734/diff/2/
> 
> 
> Testing
> ---
> 
> 1.Verified Ranger Admin & Ranger KMS on kerberized & SSL enabled environment.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 58730: RANGER-1499 : Upgrade Tomcat version

2017-04-27 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58730/#review173199
---


Fix it, then Ship it!




Revise the patch for ranger-0.7


pom.xml
Line 212 (original), 212 (patched)


This patch does not apply in ranger-0.7 branch. Please revise the patch for 
ranger-0.7. Master branch looks fine.


- Velmurugan Periasamy


On April 26, 2017, 8:41 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58730/
> ---
> 
> (Updated April 26, 2017, 8:41 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1499
> https://issues.apache.org/jira/browse/RANGER-1499
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Tomcat version used by Ranger & Ranger KMS is 7.0.68.
> It's better to upgrade it to 7.0.77
> 
> 
> Diffs
> -
> 
>   pom.xml 0953cbc 
> 
> 
> Diff: https://reviews.apache.org/r/58730/diff/1/
> 
> 
> Testing
> ---
> 
> 1.Verifeid REST calls on simple, kerberized & SSL enabled environment for 
> Ranger Admin (from UI as well as from curl).
> 2.Verifeid REST calls on simple, kerberized & SSL enabled environment for 
> Ranger KMS (from UI as well as from curl).
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 57837: Remember filters on all tabs of Ranger Audits page

2017-04-27 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57837/#review173197
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 26, 2017, 4:41 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57837/
> ---
> 
> (Updated April 26, 2017, 4:41 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1471
> https://issues.apache.org/jira/browse/RANGER-1471
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently, when we apply filter for anything in Ranger Audit page for any of 
> the tabs. It resets the filter on change of tab or if we move to any other 
> page in Ranger.
> Planning to add feature of remembering latest filters on all Tabs of Audits 
> page. That will help users to stay focused on what they are looking for in 
> audits tab and users will not have to apply for filters again and again to 
> check audit events of a particular service.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java 
> fe253ef 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java ed34525 
>   security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 0776021 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java 0a30cf6 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> 4a153bf 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 480c515 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 1277334 
>   security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js 
> 6f1069d 
>   security-admin/src/main/webapp/styles/xa.css 7a5ec2e 
>   
> security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html
>  ea2f198 
>   security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 
> 028fdbf 
>   
> security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html 
> ddd6e3d 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java 
> c544832 
> 
> 
> Diff: https://reviews.apache.org/r/57837/diff/4/
> 
> 
> Testing
> ---
> 
> 1. Tested multiple search is working correctly in "Audit" tab.
> 2. Tested search remains the same when we navigate from one tab to other.
> 3. Tested search is working correctly for different user role.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Review Request 58791: RANGER-1543:Fix the spelling in RangerBaseUdf

2017-04-27 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58791/
---

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-1543
https://issues.apache.org/jira/browse/RANGER-1543


Repository: ranger


Description
---

Should be 'Initialize' instead of 'Initialzie'.


Diffs
-

  
ranger-hive-utils/src/main/java/org/apache/ranger/authorization/hive/udf/RangerBaseUdf.java
 89552da 


Diff: https://reviews.apache.org/r/58791/diff/1/


Testing
---


Thanks,

Qiang Zhang

Review Request 58787: Display detailed error messages in Ranger for Audit store issues

2017-04-27 Thread Ankita Sinha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58787/
---

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja 
Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1548
https://issues.apache.org/jira/browse/RANGER-1548


Repository: ranger


Description
---

Actual :
When audit store is not configured properly or if audit store is down, Ranger 
UI shows 
"Unable to connect to Audit store !!"

Expected : 
To show more informative message if audit store has some issues.


Diffs
-

  security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java 049985c 


Diff: https://reviews.apache.org/r/58787/diff/1/


Testing
---

1. Tested on simple cluster with different audit store combination.
2. Tested on secure cluster with different audit store combination.

Some combination are as follows : 
1.If audit to solr is enabled and solr is down
2. Solr doesn't have collection to which Ranger is pointing.


Thanks,

Ankita Sinha

Review Request 58787: Display detailed error messages in Ranger for Audit store issues

2017-04-27 Thread Ankita Sinha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58787/
---

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja 
Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1548
https://issues.apache.org/jira/browse/RANGER-1548


Repository: ranger


Description
---

Actual :
When audit store is not configured properly or if audit store is down, Ranger 
UI shows 
"Unable to connect to Audit store !!"

Expected : 
To show more informative message if audit store has some issues.


Diffs
-

  security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java 049985c 


Diff: https://reviews.apache.org/r/58787/diff/1/


Testing
---

1. Tested on simple cluster with different audit store combination.
2. Tested on secure cluster with different audit store combination.

Some combination are as follows : 
1.If audit to solr is enabled and solr is down
2. Solr doesn't have collection to which Ranger is pointing.


Thanks,

Ankita Sinha

[jira] [Updated] (RANGER-1548) Display detailed error messages in Ranger for Audit store issues

2017-04-27 Thread Ankita Sinha (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankita Sinha updated RANGER-1548:
-
Attachment: RANGER-1548_07.patch

> Display detailed error messages in Ranger for Audit store issues
> 
>
> Key: RANGER-1548
> URL: https://issues.apache.org/jira/browse/RANGER-1548
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 0.7.1
>Reporter: Ankita Sinha
>Assignee: Ankita Sinha
> Fix For: 0.7.1
>
> Attachments: RANGER-1548_07.patch, RANGER-1548.patch
>
>
> Actual :
> When audit store is not configured properly or if audit store is down, Ranger 
> UI shows 
> "Unable to connect to Audit store !!"
> Expected : 
> To show more informative message if audit store has some issues.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58219: Support administration of Tag-based masking policies

2017-04-27 Thread Colm O hEigeartaigh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58219/#review173179
---



There are several instances where you are creating an Iterator which is just 
debug logging, meaning that if debug logging is turned off we are doing a load 
of empty iterations, e.g.:

+   for (RangerServiceDef.RangerDataMaskTypeDef maskTypeDef 
: maskTypesToAdd) {
+   if (LOG.isDebugEnabled()) {
+   LOG.debug("maskTypeDef-to-add:[" + 
maskTypeDef + "]");
+   }
+   }
+

Much better to instead put the if statement outside the for loop.

- Colm O hEigeartaigh


On April 21, 2017, 9:23 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58219/
> ---
> 
> (Updated April 21, 2017, 9:23 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Nitin Galave.
> 
> 
> Bugs: RANGER-1494
> https://issues.apache.org/jira/browse/RANGER-1494
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Supported modification of tag servicedef to reflect changes to non-tag based 
> service definition.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java
>  7b3bd95 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
>  0793a6a 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java
>  1702dec 
> 
> 
> Diff: https://reviews.apache.org/r/58219/diff/2/
> 
> 
> Testing
> ---
> 
> Created/Deleted/Updated non-tag service-def with dataMaskDef modifications. 
> Ensured they are correctly reflected in the tag service-def.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Re: Review Request 58781: RANGER-1546 : Code Improvement To Follow Best Practice

2017-04-27 Thread Colm O hEigeartaigh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58781/#review173175
---


Ship it!




Ship It!

- Colm O hEigeartaigh


On April 27, 2017, 7 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58781/
> ---
> 
> (Updated April 27, 2017, 7 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1546
> https://issues.apache.org/jira/browse/RANGER-1546
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Code improvement to follow best practices.
> 
> 
> Diffs
> -
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java 
> 1485c0f 
>   
> agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java
>  a2c5193 
>   
> knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java
>  ec08ae8 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 
> 5521ae8 
> 
> 
> Diff: https://reviews.apache.org/r/58781/diff/1/
> 
> 
> Testing
> ---
> 
> 1.Verified Ranger Admin & Ranger KMS on kerberized & SSL enabled environment.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

[jira] [Commented] (RANGER-1531) Good coding practice while parsing XML documents in Ranger

2017-04-27 Thread Colm O hEigeartaigh (JIRA) 

[ 
https://issues.apache.org/jira/browse/RANGER-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986209#comment-15986209
 ] 

Colm O hEigeartaigh commented on RANGER-1531:
-

Please mark the review requests as "resolved" as well when you resolve the JIRA.

Colm.

> Good coding practice while parsing XML documents in Ranger
> --
>
> Key: RANGER-1531
> URL: https://issues.apache.org/jira/browse/RANGER-1531
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger, usersync
>Affects Versions: 0.7.0
>Reporter: Sailaja Polavarapu
>Assignee: Sailaja Polavarapu
> Fix For: 1.0.0, 0.7.1
>
> Attachments: 
> 0001-RANGER-1531-added-code-to-not-allow-external-entitie (1).patch, 
> 0001-RANGER-1531-added-code-to-not-allow-external-entitie.patch, 
> 0001-RANGER-1531-Good-coding-practice-while-parsing-XML-d.patch
>
>
> Implement good coding practices while parsing XML documents in Ranger



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RANGER-1535) Add tag attributes to audit log record

2017-04-27 Thread Colm O hEigeartaigh (JIRA) 

[ 
https://issues.apache.org/jira/browse/RANGER-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986193#comment-15986193
 ] 

Colm O hEigeartaigh commented on RANGER-1535:
-

Please close + mark as submitted the review requests when you resolve the JIRA 
as well.

Colm.

> Add tag attributes to audit log record
> --
>
> Key: RANGER-1535
> URL: https://issues.apache.org/jira/browse/RANGER-1535
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 1.0.0
>Reporter: Abhay Kulkarni
>Assignee: Abhay Kulkarni
> Fix For: 1.0.0
>
>
> Currently, in the access audit log record, the tags column is populated when 
> the accessed resource has any tags associated with it. However, if a tag has 
> any attributes, their values are not shown in the audit log record. As 
> authorization decision may be based on the attribute-value(s) as well as 
> tag-type (such as in the case of expiry_date attribute’s value for EXPIRES_ON 
> tag-type), they too need to be populated and displayed on audit log record. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1543) Fix the spelling in RangerBaseUdf

2017-04-27 Thread Qiang Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-1543:

Attachment: 0001-RANGER-1543-Fix-the-spelling-in-RangerBaseUdf.patch

> Fix the spelling in RangerBaseUdf
> -
>
> Key: RANGER-1543
> URL: https://issues.apache.org/jira/browse/RANGER-1543
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Affects Versions: 1.0.0
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Trivial
> Fix For: 1.0.0
>
> Attachments: 0001-RANGER-1543-Fix-the-spelling-in-RangerBaseUdf.patch
>
>
> Should be 'Initialize' instead of 'Initialzie'.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (RANGER-1546) Code Improvement To Follow Best Practices

2017-04-27 Thread bhavik patel (JIRA) 

[ 
https://issues.apache.org/jira/browse/RANGER-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984582#comment-15984582
 ] 

bhavik patel edited comment on RANGER-1546 at 4/27/17 7:01 AM:
---

Review Link for master branch : https://reviews.apache.org/r/58734/
Review Link for ranger-0.7 branch : https://reviews.apache.org/r/58781/


was (Author: bpatel):
Review Link : https://reviews.apache.org/r/58734/

> Code Improvement To Follow Best Practices
> -
>
> Key: RANGER-1546
> URL: https://issues.apache.org/jira/browse/RANGER-1546
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: bhavik patel
>Assignee: bhavik patel
> Fix For: 0.7.1
>
> Attachments: RANGER-1546-07-1.patch, RANGER-1546-master-1.patch, 
> RANGER-1546-master.patch
>
>
> Code improvement to follow best practices.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 58781: RANGER-1546 : Code Improvement To Follow Best Practice

2017-04-27 Thread bhavik patel 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58781/
---

Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
and Velmurugan Periasamy.


Bugs: RANGER-1546
https://issues.apache.org/jira/browse/RANGER-1546


Repository: ranger


Description
---

Code improvement to follow best practices.


Diffs
-

  agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java 
1485c0f 
  
agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java
 a2c5193 
  
knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java 
ec08ae8 
  security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 5521ae8 


Diff: https://reviews.apache.org/r/58781/diff/1/


Testing
---

1.Verified Ranger Admin & Ranger KMS on kerberized & SSL enabled environment.


Thanks,

bhavik patel

[jira] [Updated] (RANGER-1548) Display detailed error messages in Ranger for Audit store issues

2017-04-27 Thread Ankita Sinha (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankita Sinha updated RANGER-1548:
-
Attachment: RANGER-1548.patch

> Display detailed error messages in Ranger for Audit store issues
> 
>
> Key: RANGER-1548
> URL: https://issues.apache.org/jira/browse/RANGER-1548
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 0.7.1
>Reporter: Ankita Sinha
>Assignee: Ankita Sinha
> Fix For: 0.7.1
>
> Attachments: RANGER-1548.patch
>
>
> Actual :
> When audit store is not configured properly or if audit store is down, Ranger 
> UI shows 
> "Unable to connect to Audit store !!"
> Expected : 
> To show more informative message if audit store has some issues.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RANGER-1548) Display detailed error messages in Ranger for Audit store issues

2017-04-27 Thread Ankita Sinha (JIRA) 
Ankita Sinha created RANGER-1548:


 Summary: Display detailed error messages in Ranger for Audit store 
issues
 Key: RANGER-1548
 URL: https://issues.apache.org/jira/browse/RANGER-1548
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Affects Versions: 0.7.1
Reporter: Ankita Sinha
Assignee: Ankita Sinha
 Fix For: 0.7.1


Actual :
When audit store is not configured properly or if audit store is down, Ranger 
UI shows 
"Unable to connect to Audit store !!"

Expected : 
To show more informative message if audit store has some issues.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1546) Code Improvement To Follow Best Practices

2017-04-27 Thread bhavik patel (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bhavik patel updated RANGER-1546:
-
Attachment: RANGER-1546-07-1.patch

> Code Improvement To Follow Best Practices
> -
>
> Key: RANGER-1546
> URL: https://issues.apache.org/jira/browse/RANGER-1546
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: bhavik patel
>Assignee: bhavik patel
> Fix For: 0.7.1
>
> Attachments: RANGER-1546-07-1.patch, RANGER-1546-master-1.patch, 
> RANGER-1546-master.patch
>
>
> Code improvement to follow best practices.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)