[jira] [Resolved] (RANGER-1585) Do some code improvement for the error logs in RangerBasePlugin.java
[ https://issues.apache.org/jira/browse/RANGER-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang resolved RANGER-1585. - Resolution: Fixed Fix Version/s: 1.0.0 > Do some code improvement for the error logs in RangerBasePlugin.java > > > Key: RANGER-1585 > URL: https://issues.apache.org/jira/browse/RANGER-1585 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Qiang Zhang >Assignee: Qiang Zhang >Priority: Minor > Labels: patch > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1585-Do-some-code-improvement-for-the-error-l.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 59296: Ranger plugins need to support additional date formats for tag attribute values
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59296/
---
(Updated May 18, 2017, 1:35 a.m.)
Review request for ranger and Madhan Neethiraj.
Changes
---
If multiple date-format strings are used, ensure that the format-string that
matches the most number of characters is used for parsing date-string into Java
Date object
Bugs: RANGER-1581
https://issues.apache.org/jira/browse/RANGER-1581
Repository: ranger
Description
---
Ranger plugins interpret tag attributes of type 'date' using an internal Ranger
date-format string. Now, in addition to the internal Ranger date-format string
("/MM/dd"), plugins also support a comma-separated list of data-format
strings, based on the value of the plugin configuration parameter
"ranger.plugin.tag.attr.additional.date.formats". A special value string
"ATLAS_DATE_FORMAT" is supported to refer to default date-format used by Atlas.
Diffs (updated)
-
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java
c46f527
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
e556f16
agents-common/src/test/resources/policyengine/test_policyengine_tag_hive.json
34ccaac
Diff: https://reviews.apache.org/r/59296/diff/4/
Changes: https://reviews.apache.org/r/59296/diff/3-4/
Testing
---
Developed a unit test for testing specification and use of
"ranger.plugin.tag.attr.additional.date.formats" configuration variable.
Thanks,
Abhay Kulkarni
[jira] [Updated] (RANGER-1411) Permissions tab pages display are not reasonable
[ https://issues.apache.org/jira/browse/RANGER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haihui Xu updated RANGER-1411: -- Attachment: 0001-RANGER-1411-Page-show-should-be-Modules.patch > Permissions tab pages display are not reasonable > > > Key: RANGER-1411 > URL: https://issues.apache.org/jira/browse/RANGER-1411 > Project: Ranger > Issue Type: Bug > Components: admin, Ranger >Affects Versions: 0.6.3 >Reporter: Haihui Xu >Assignee: Haihui Xu > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1411-Page-show-should-be-Modules.patch, > RANGER-1411-1.jpg > > > 1.Navigate to Ranger Web UI's Settings Permissions tab, the permissions > table header is Permissions,Groups,Users,Action. But the first column in the > table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So > the table header should be Modules,Groups,Users,Action. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1411) Permissions tab pages display are not reasonable
[ https://issues.apache.org/jira/browse/RANGER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haihui Xu updated RANGER-1411: -- Attachment: (was: 0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch) > Permissions tab pages display are not reasonable > > > Key: RANGER-1411 > URL: https://issues.apache.org/jira/browse/RANGER-1411 > Project: Ranger > Issue Type: Bug > Components: admin, Ranger >Affects Versions: 0.6.3 >Reporter: Haihui Xu >Assignee: Haihui Xu > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1411-Page-show-should-be-Modules.patch, > RANGER-1411-1.jpg > > > 1.Navigate to Ranger Web UI's Settings Permissions tab, the permissions > table header is Permissions,Groups,Users,Action. But the first column in the > table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So > the table header should be Modules,Groups,Users,Action. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 57868: Permissions tab pages display are not reasonable.https://issues.apache.org/jira/browse/RANGER-1411
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57868/ --- (Updated 五月 18, 2017, 1:26 a.m.) Review request for ranger. Bugs: RANGER-1411 https://issues.apache.org/jira/browse/RANGER-1411 Repository: ranger Description --- Navigate to Ranger Web UI's Settings Permissions tab, the permissions table header is Permissions,Groups,Users,Action. But the first column in the table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table header should be Modules,Groups,Users,Action. Diffs (updated) - security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 49d0323 security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 92c07c7 Diff: https://reviews.apache.org/r/57868/diff/2/ Changes: https://reviews.apache.org/r/57868/diff/1-2/ Testing --- Page Display, test ok. File Attachments 0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch https://reviews.apache.org/media/uploaded/files/2017/05/17/2ad83ef8-56bf-4922-83f6-8d254bdd673e__0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch Thanks, Haihui Xu
Re: Review Request 59296: Ranger plugins need to support additional date formats for tag attribute values
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59296/#review175318
---
Ship it!
Ship It!
- Madhan Neethiraj
On May 17, 2017, 9:33 p.m., Abhay Kulkarni wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59296/
> ---
>
> (Updated May 17, 2017, 9:33 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-1581
> https://issues.apache.org/jira/browse/RANGER-1581
>
>
> Repository: ranger
>
>
> Description
> ---
>
> Ranger plugins interpret tag attributes of type 'date' using an internal
> Ranger date-format string. Now, in addition to the internal Ranger
> date-format string ("/MM/dd"), plugins also support a comma-separated
> list of data-format strings, based on the value of the plugin configuration
> parameter "ranger.plugin.tag.attr.additional.date.formats". A special value
> string "ATLAS_DATE_FORMAT" is supported to refer to default date-format used
> by Atlas.
>
>
> Diffs
> -
>
>
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java
> c46f527
>
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
> e556f16
>
>
> Diff: https://reviews.apache.org/r/59296/diff/3/
>
>
> Testing
> ---
>
> Developed a unit test for testing specification and use of
> "ranger.plugin.tag.attr.additional.date.formats" configuration variable.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 59296: Ranger plugins need to support additional date formats for tag attribute values
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59296/
---
(Updated May 17, 2017, 9:33 p.m.)
Review request for ranger and Madhan Neethiraj.
Changes
---
Added Atlas's date-format string as one of the default formats, changed format
strings separator string to somewhat uncommon combination
Bugs: RANGER-1581
https://issues.apache.org/jira/browse/RANGER-1581
Repository: ranger
Description
---
Ranger plugins interpret tag attributes of type 'date' using an internal Ranger
date-format string. Now, in addition to the internal Ranger date-format string
("/MM/dd"), plugins also support a comma-separated list of data-format
strings, based on the value of the plugin configuration parameter
"ranger.plugin.tag.attr.additional.date.formats". A special value string
"ATLAS_DATE_FORMAT" is supported to refer to default date-format used by Atlas.
Diffs (updated)
-
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java
c46f527
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
e556f16
Diff: https://reviews.apache.org/r/59296/diff/3/
Changes: https://reviews.apache.org/r/59296/diff/2-3/
Testing
---
Developed a unit test for testing specification and use of
"ranger.plugin.tag.attr.additional.date.formats" configuration variable.
Thanks,
Abhay Kulkarni
[jira] [Commented] (RANGER-1584) Allow tagsync to support log directory from Ambari configuration
[ https://issues.apache.org/jira/browse/RANGER-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014437#comment-16014437 ] Yujie Li commented on RANGER-1584: -- [~coheigea] Hi, can you please assign this to me as well? I sent a note to dev@ranger.apache.org but still no response yet. > Allow tagsync to support log directory from Ambari configuration > > > Key: RANGER-1584 > URL: https://issues.apache.org/jira/browse/RANGER-1584 > Project: Ranger > Issue Type: Bug > Components: tagsync >Affects Versions: master, 0.7.1 >Reporter: Yujie Li >Priority: Minor > Attachments: > 0001-RANGER-1584-Allow-tagsync-to-support-log-directory-f.patch > > > Currently Tagsync hardcodes the log directory as /var/log/ranger/tagsync. It > doesn't support customization setting for log location from Ambari side. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Review Request 59339: RANGER-1587 - Cleanup Ranger KMS service dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59339/ --- Review request for ranger. Bugs: RANGER-1587 https://issues.apache.org/jira/browse/RANGER-1587 Repository: ranger Description --- The Ranger KMS service pom is a bit of a mess, with a large number of dependencies listed - most of which can be imported via Hadoop. I've made the following changes (and verified that the jars in the KMS distribution are the exact same as before): Removed: commons-digester 1.8 (comes from commons-configuration 1.6) commons-configuration 1.6 (comes from Hadoop 2.7.1) javax.activation 1.1 (comes from jaxb-api 2.2.2) jaxb-api 2.2.2 (comes from jaxb-impl 2.2.3-1) eclipselink + javax.persistence (comes from ranger-plugins-audit) commons-beanutils 1.7.0 (comes from commons-digester 1.8) commons-beanutils-core 1.8.0 (comes from commons-configuration 1.6) commons-compress 1.4.1 (comes from hadoop 2.7.1) commons-math3 3.1.1 (comes from hadoop 2.7.1) commons-net 3.1 (comes from hadoop 2.7.1) apacheds-i18n 2.0.0-M15 (comes from apacheds-kerberos-codec 2.0.0-M15) api-asn1-api 1.0.0-M20 (comes from apacheds-kerberos-codec 2.0.0-M15) api-util 1.0.0-M20 (comes from apacheds-kerberos-codec 2.0.0-M15) apacheds-i18n 2.0.0-M15 (comes from apacheds-kerberos-codec 2.0.0-M15) apacheds-kerberos-codec 2.0.0-M15 (comes from hadoop-auth 2.7.1) avro 1.7.4 (comes from hadoop-common 2.7.1) commons-cli 1.2 (comes from hadoop-common 2.7.1) commons-io 2.4 (comes from hadoop-common 2.7.1) commons-codec 1.4 (comes from hadoop-common 2.7.1) gson 2.2.4 (comes from hadoop-common 2.7.1) hadoop-annotations 2.7.1 (comes from hadoop-common 2.7.1) htrace 3.1.0-incubating (comes from hadoop-common 2.7.1) jaxb-impl:jar:2.2.3-1 (comes from jersey-json 1.19.3) jettison 1.1 (comes from jersey-json 1.19.3) jsch 0.1.42 (comes from hadoop-common 2.7.1) paranamer 2.3 (comes from avro 1.7.4) protobuf-java 2.5.0 (comes from hadoop-common 2.7.1) snappy-java 1.0.4.1 (comes from avro 1.7.4) xmlenc 0.52 (comes from hadoop-common 2.7.1) xz 1.0 (comes from commons-compress 1.4.1) noggit 0.6 (comes from solrj 5.5.1) Diffs - agents-audit/pom.xml 10daa694 kms/pom.xml 46dc3c48 pom.xml 19ceca85 Diff: https://reviews.apache.org/r/59339/diff/1/ Testing --- Tested that the KMS dist has the same jars as before. Thanks, Colm O hEigeartaigh
[jira] [Updated] (RANGER-1587) Cleanup Ranger KMS service dependencies
[ https://issues.apache.org/jira/browse/RANGER-1587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated RANGER-1587: Attachment: 0001-RANGER-1587-Cleanup-Ranger-KMS-service-dependencies.patch > Cleanup Ranger KMS service dependencies > --- > > Key: RANGER-1587 > URL: https://issues.apache.org/jira/browse/RANGER-1587 > Project: Ranger > Issue Type: Improvement > Components: kms >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1587-Cleanup-Ranger-KMS-service-dependencies.patch > > > The Ranger KMS service pom is a bit of a mess, with a large number of > dependencies listed - most of which can be imported via Hadoop. I've made the > following changes (and verified that the jars in the KMS distribution are the > exact same as before): > Removed: > commons-digester 1.8 (comes from commons-configuration 1.6) > commons-configuration 1.6 (comes from Hadoop 2.7.1) > javax.activation 1.1 (comes from jaxb-api 2.2.2) > jaxb-api 2.2.2 (comes from jaxb-impl 2.2.3-1) > eclipselink + javax.persistence (comes from ranger-plugins-audit) > commons-beanutils 1.7.0 (comes from commons-digester 1.8) > commons-beanutils-core 1.8.0 (comes from commons-configuration 1.6) > commons-compress 1.4.1 (comes from hadoop 2.7.1) > commons-math3 3.1.1 (comes from hadoop 2.7.1) > commons-net 3.1 (comes from hadoop 2.7.1) > apacheds-i18n 2.0.0-M15 (comes from apacheds-kerberos-codec 2.0.0-M15) > api-asn1-api 1.0.0-M20 (comes from apacheds-kerberos-codec 2.0.0-M15) > api-util 1.0.0-M20 (comes from apacheds-kerberos-codec 2.0.0-M15) > apacheds-i18n 2.0.0-M15 (comes from apacheds-kerberos-codec 2.0.0-M15) > apacheds-kerberos-codec 2.0.0-M15 (comes from hadoop-auth 2.7.1) > avro 1.7.4 (comes from hadoop-common 2.7.1) > commons-cli 1.2 (comes from hadoop-common 2.7.1) > commons-io 2.4 (comes from hadoop-common 2.7.1) > commons-codec 1.4 (comes from hadoop-common 2.7.1) > gson 2.2.4 (comes from hadoop-common 2.7.1) > hadoop-annotations 2.7.1 (comes from hadoop-common 2.7.1) > htrace 3.1.0-incubating (comes from hadoop-common 2.7.1) > jaxb-impl:jar:2.2.3-1 (comes from jersey-json 1.19.3) > jettison 1.1 (comes from jersey-json 1.19.3) > jsch 0.1.42 (comes from hadoop-common 2.7.1) > paranamer 2.3 (comes from avro 1.7.4) > protobuf-java 2.5.0 (comes from hadoop-common 2.7.1) > snappy-java 1.0.4.1 (comes from avro 1.7.4) > xmlenc 0.52 (comes from hadoop-common 2.7.1) > xz 1.0 (comes from commons-compress 1.4.1) > noggit 0.6 (comes from solrj 5.5.1) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (RANGER-1587) Cleanup Ranger KMS service dependencies
Colm O hEigeartaigh created RANGER-1587: --- Summary: Cleanup Ranger KMS service dependencies Key: RANGER-1587 URL: https://issues.apache.org/jira/browse/RANGER-1587 Project: Ranger Issue Type: Improvement Components: kms Reporter: Colm O hEigeartaigh Assignee: Colm O hEigeartaigh Fix For: 1.0.0 The Ranger KMS service pom is a bit of a mess, with a large number of dependencies listed - most of which can be imported via Hadoop. I've made the following changes (and verified that the jars in the KMS distribution are the exact same as before): Removed: commons-digester 1.8 (comes from commons-configuration 1.6) commons-configuration 1.6 (comes from Hadoop 2.7.1) javax.activation 1.1 (comes from jaxb-api 2.2.2) jaxb-api 2.2.2 (comes from jaxb-impl 2.2.3-1) eclipselink + javax.persistence (comes from ranger-plugins-audit) commons-beanutils 1.7.0 (comes from commons-digester 1.8) commons-beanutils-core 1.8.0 (comes from commons-configuration 1.6) commons-compress 1.4.1 (comes from hadoop 2.7.1) commons-math3 3.1.1 (comes from hadoop 2.7.1) commons-net 3.1 (comes from hadoop 2.7.1) apacheds-i18n 2.0.0-M15 (comes from apacheds-kerberos-codec 2.0.0-M15) api-asn1-api 1.0.0-M20 (comes from apacheds-kerberos-codec 2.0.0-M15) api-util 1.0.0-M20 (comes from apacheds-kerberos-codec 2.0.0-M15) apacheds-i18n 2.0.0-M15 (comes from apacheds-kerberos-codec 2.0.0-M15) apacheds-kerberos-codec 2.0.0-M15 (comes from hadoop-auth 2.7.1) avro 1.7.4 (comes from hadoop-common 2.7.1) commons-cli 1.2 (comes from hadoop-common 2.7.1) commons-io 2.4 (comes from hadoop-common 2.7.1) commons-codec 1.4 (comes from hadoop-common 2.7.1) gson 2.2.4 (comes from hadoop-common 2.7.1) hadoop-annotations 2.7.1 (comes from hadoop-common 2.7.1) htrace 3.1.0-incubating (comes from hadoop-common 2.7.1) jaxb-impl:jar:2.2.3-1 (comes from jersey-json 1.19.3) jettison 1.1 (comes from jersey-json 1.19.3) jsch 0.1.42 (comes from hadoop-common 2.7.1) paranamer 2.3 (comes from avro 1.7.4) protobuf-java 2.5.0 (comes from hadoop-common 2.7.1) snappy-java 1.0.4.1 (comes from avro 1.7.4) xmlenc 0.52 (comes from hadoop-common 2.7.1) xz 1.0 (comes from commons-compress 1.4.1) noggit 0.6 (comes from solrj 5.5.1) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade
> On May 17, 2017, 11:12 a.m., Colm O hEigeartaigh wrote: > > Why is the iteration count now "17"? > > bhavik patel wrote: > For previous version this iteration count was 17 so to support backwards > compatibility we have kept this count as 17, once the upgrade is successful > the user can change the value in xml file. > For fresh install whatever the user want they can configure accordingly. > > Colm O hEigeartaigh wrote: > OK thanks. For a new major release like 1.0.0 though, would it not be > better to default to "1000" and any user who is upgrading can change it to > "17"? Yes, user can do that but if we set default to "1000" then test connection & resource-lookup will not work for old repo's those created in minor version; so we have set it to "17". - bhavik --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59335/#review175228 --- On May 17, 2017, 11:05 a.m., bhavik patel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59335/ > --- > > (Updated May 17, 2017, 11:05 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, > and Velmurugan Periasamy. > > > Bugs: RANGER-1583 > https://issues.apache.org/jira/browse/RANGER-1583 > > > Repository: ranger > > > Description > --- > > After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing > for plugins. > Below error is shown in xa_portal.log: > ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - > Unable to decrypt password due to error > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java > 3759b8d > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > a44aa46 > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > 4f5f1d3 > > > Diff: https://reviews.apache.org/r/59335/diff/1/ > > > Testing > --- > > 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins > test-connections & resource-lookup. > > > Thanks, > > bhavik patel > >
Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade
> On May 17, 2017, 11:12 a.m., Colm O hEigeartaigh wrote: > > Why is the iteration count now "17"? > > bhavik patel wrote: > For previous version this iteration count was 17 so to support backwards > compatibility we have kept this count as 17, once the upgrade is successful > the user can change the value in xml file. > For fresh install whatever the user want they can configure accordingly. OK thanks. For a new major release like 1.0.0 though, would it not be better to default to "1000" and any user who is upgrading can change it to "17"? - Colm --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59335/#review175228 --- On May 17, 2017, 11:05 a.m., bhavik patel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59335/ > --- > > (Updated May 17, 2017, 11:05 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, > and Velmurugan Periasamy. > > > Bugs: RANGER-1583 > https://issues.apache.org/jira/browse/RANGER-1583 > > > Repository: ranger > > > Description > --- > > After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing > for plugins. > Below error is shown in xa_portal.log: > ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - > Unable to decrypt password due to error > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java > 3759b8d > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > a44aa46 > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > 4f5f1d3 > > > Diff: https://reviews.apache.org/r/59335/diff/1/ > > > Testing > --- > > 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins > test-connections & resource-lookup. > > > Thanks, > > bhavik patel > >
Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade
> On May 17, 2017, 11:12 a.m., Colm O hEigeartaigh wrote: > > Why is the iteration count now "17"? For previous version this iteration count was 17 so to support backwards compatibility we have kept this count as 17, once the upgrade is successful the user can change the value in xml file. For fresh install whatever the user want they can configure accordingly. - bhavik --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59335/#review175228 --- On May 17, 2017, 11:05 a.m., bhavik patel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59335/ > --- > > (Updated May 17, 2017, 11:05 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, > and Velmurugan Periasamy. > > > Bugs: RANGER-1583 > https://issues.apache.org/jira/browse/RANGER-1583 > > > Repository: ranger > > > Description > --- > > After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing > for plugins. > Below error is shown in xa_portal.log: > ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - > Unable to decrypt password due to error > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java > 3759b8d > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > a44aa46 > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > 4f5f1d3 > > > Diff: https://reviews.apache.org/r/59335/diff/1/ > > > Testing > --- > > 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins > test-connections & resource-lookup. > > > Thanks, > > bhavik patel > >
Re: Review Request 57868: Permissions tab pages display are not reasonable.https://issues.apache.org/jira/browse/RANGER-1411
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57868/#review175231 --- There is a comma ',' missing after 'Modules' in security-admin/src/main/webapp/scripts/modules/globalize/message/en.js. By the way you can just update the diff rather than add files to the review request. - Colm O hEigeartaigh On May 17, 2017, 8:35 a.m., Haihui Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57868/ > --- > > (Updated May 17, 2017, 8:35 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-1411 > https://issues.apache.org/jira/browse/RANGER-1411 > > > Repository: ranger > > > Description > --- > > Navigate to Ranger Web UI's Settings Permissions tab, the permissions table > header is Permissions,Groups,Users,Action. But the first column in the table > is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the > table header should be Modules,Groups,Users,Action. > > > Diffs > - > > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > 7a4b82c > > security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js > 92c07c7 > > security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html > 909d2fc > > > Diff: https://reviews.apache.org/r/57868/diff/1/ > > > Testing > --- > > Page Display, test ok. > > > File Attachments > > > RANGER-1411.patch > > https://reviews.apache.org/media/uploaded/files/2017/05/16/5ef6eb5a-42c7-4aa7-8c54-7deace5ce158__RANGER-1411.patch > 0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch > > https://reviews.apache.org/media/uploaded/files/2017/05/17/2ad83ef8-56bf-4922-83f6-8d254bdd673e__0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch > > > Thanks, > > Haihui Xu > >
[jira] [Resolved] (RANGER-1586) There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient class.
[ https://issues.apache.org/jira/browse/RANGER-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh resolved RANGER-1586. - Resolution: Fixed > There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient > class. > > > Key: RANGER-1586 > URL: https://issues.apache.org/jira/browse/RANGER-1586 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: 1.0.0 >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Trivial > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1586-There-is-cannot-resolve-symbol-serviceNa.patch > > > There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient > class. > I deleted it to resolve the issue and keep the code consistent. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 59332: RANGER-1586:There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59332/#review175229 --- Ship it! Ship It! - Colm O hEigeartaigh On May 17, 2017, 8:36 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59332/ > --- > > (Updated May 17, 2017, 8:36 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1586 > https://issues.apache.org/jira/browse/RANGER-1586 > > > Repository: ranger > > > Description > --- > > There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient > class. > I deleted it to resolve the issue and keep the code consistent. > > > Diffs > - > > > plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java > bc5fdd0 > > > Diff: https://reviews.apache.org/r/59332/diff/1/ > > > Testing > --- > > > Thanks, > > pengjianhua > >
Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59335/ --- Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. Bugs: RANGER-1583 https://issues.apache.org/jira/browse/RANGER-1583 Repository: ranger Description --- After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing for plugins. Below error is shown in xa_portal.log: ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - Unable to decrypt password due to error Diffs - agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 3759b8d security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a44aa46 security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 4f5f1d3 Diff: https://reviews.apache.org/r/59335/diff/1/ Testing --- 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins test-connections & resource-lookup. Thanks, bhavik patel
[jira] [Commented] (RANGER-1584) Allow tagsync to support log directory from Ambari configuration
[ https://issues.apache.org/jira/browse/RANGER-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013851#comment-16013851 ] Colm O hEigeartaigh commented on RANGER-1584: - Please create a review request as well for this patch. > Allow tagsync to support log directory from Ambari configuration > > > Key: RANGER-1584 > URL: https://issues.apache.org/jira/browse/RANGER-1584 > Project: Ranger > Issue Type: Bug > Components: tagsync >Affects Versions: master, 0.7.1 >Reporter: Yujie Li >Priority: Minor > Attachments: > 0001-RANGER-1584-Allow-tagsync-to-support-log-directory-f.patch > > > Currently Tagsync hardcodes the log directory as /var/log/ranger/tagsync. It > doesn't support customization setting for log location from Ambari side. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1583) Test connections are failing for plugins after upgrade
[ https://issues.apache.org/jira/browse/RANGER-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bhavik patel updated RANGER-1583: - Attachment: RANGER-1583-07.patch RANGER-1583-master.patch > Test connections are failing for plugins after upgrade > -- > > Key: RANGER-1583 > URL: https://issues.apache.org/jira/browse/RANGER-1583 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: bhavik patel >Assignee: bhavik patel > Fix For: 0.7.1 > > Attachments: RANGER-1583-07.patch, RANGER-1583-master.patch > > > After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing > for plugins. > Below error is shown in xa_portal.log: > ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - > Unable to decrypt password due to error -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1583) Test connections are failing for plugins after upgrade
[ https://issues.apache.org/jira/browse/RANGER-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bhavik patel updated RANGER-1583: - Affects Version/s: (was: 0.7.1) > Test connections are failing for plugins after upgrade > -- > > Key: RANGER-1583 > URL: https://issues.apache.org/jira/browse/RANGER-1583 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: bhavik patel >Assignee: bhavik patel > Fix For: 0.7.1 > > > After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing > for plugins. > Below error is shown in xa_portal.log: > ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - > Unable to decrypt password due to error -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 57868: Permissions tab pages display are not reasonable.https://issues.apache.org/jira/browse/RANGER-1411
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57868/ --- (Updated 五月 17, 2017, 8:35 a.m.) Review request for ranger. Bugs: RANGER-1411 https://issues.apache.org/jira/browse/RANGER-1411 Repository: ranger Description --- Navigate to Ranger Web UI's Settings Permissions tab, the permissions table header is Permissions,Groups,Users,Action. But the first column in the table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table header should be Modules,Groups,Users,Action. Diffs - security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 7a4b82c security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 92c07c7 security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html 909d2fc Diff: https://reviews.apache.org/r/57868/diff/1/ Testing --- Page Display, test ok. File Attachments (updated) RANGER-1411.patch https://reviews.apache.org/media/uploaded/files/2017/05/16/5ef6eb5a-42c7-4aa7-8c54-7deace5ce158__RANGER-1411.patch 0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch https://reviews.apache.org/media/uploaded/files/2017/05/17/2ad83ef8-56bf-4922-83f6-8d254bdd673e__0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch Thanks, Haihui Xu
[jira] [Updated] (RANGER-1586) There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient class.
[ https://issues.apache.org/jira/browse/RANGER-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated RANGER-1586: - Attachment: 0001-RANGER-1586-There-is-cannot-resolve-symbol-serviceNa.patch > There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient > class. > > > Key: RANGER-1586 > URL: https://issues.apache.org/jira/browse/RANGER-1586 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: 1.0.0 >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Trivial > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1586-There-is-cannot-resolve-symbol-serviceNa.patch > > > There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient > class. > I deleted it to resolve the issue and keep the code consistent. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1411) Permissions tab pages display are not reasonable
[ https://issues.apache.org/jira/browse/RANGER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haihui Xu updated RANGER-1411: -- Attachment: (was: RANGER-1411.patch) > Permissions tab pages display are not reasonable > > > Key: RANGER-1411 > URL: https://issues.apache.org/jira/browse/RANGER-1411 > Project: Ranger > Issue Type: Bug > Components: admin, Ranger >Affects Versions: 0.6.3 >Reporter: Haihui Xu >Assignee: Haihui Xu > Fix For: 1.0.0 > > Attachments: RANGER-1411-1.jpg > > > 1.Navigate to Ranger Web UI's Settings Permissions tab, the permissions > table header is Permissions,Groups,Users,Action. But the first column in the > table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So > the table header should be Modules,Groups,Users,Action. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1586) There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient class.
[ https://issues.apache.org/jira/browse/RANGER-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated RANGER-1586: - Description: There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient class. I deleted it to keep the code consistent. was:There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient class. > There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient > class. > > > Key: RANGER-1586 > URL: https://issues.apache.org/jira/browse/RANGER-1586 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: 1.0.0 >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Trivial > Fix For: 1.0.0 > > > There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient > class. > I deleted it to keep the code consistent. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (RANGER-1586) There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient class.
peng.jianhua created RANGER-1586: Summary: There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient class. Key: RANGER-1586 URL: https://issues.apache.org/jira/browse/RANGER-1586 Project: Ranger Issue Type: Bug Components: plugins Affects Versions: 1.0.0 Reporter: peng.jianhua Assignee: peng.jianhua Priority: Trivial Fix For: 1.0.0 There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient class. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
