[jira] [Created] (RANGER-1604) DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused su

[Qiang Zhang (JIRA)]

Qiang Zhang created RANGER-1604:
---

 Summary: DB based auditing had been removed in RANGER-900. But 
some configurations and codes are not removed accordingly in Ranger Admin. It 
often makes the user feel confused such as RANGER-1286.
 Key: RANGER-1604
 URL: https://issues.apache.org/jira/browse/RANGER-1604
 Project: Ranger
  Issue Type: Bug
  Components: admin
Affects Versions: 1.0.0
Reporter: Qiang Zhang
Assignee: Qiang Zhang
Priority: Minor
 Fix For: 1.0.0


DB based auditing had been removed in RANGER-900. But some configurations and 
codes are not removed accordingly in Ranger Admin. It often makes the user feel 
confused such as RANGER-1286. We should do the following modification:
1. Add description information to configuration file.
2. Remove invalid code to eliminate misunderstanding.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1602) Include / Exclude toggle not working for same level resources

[Nitin Galave (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitin Galave updated RANGER-1602:
-
Fix Version/s: 0.7.1
   1.0.0

> Include / Exclude toggle not working for same level resources
> -
>
> Key: RANGER-1602
> URL: https://issues.apache.org/jira/browse/RANGER-1602
> Project: Ranger
>  Issue Type: Bug
>  Components: admin, Ranger
>Affects Versions: 0.7.0, 1.0.0
>Reporter: Gautam Borad
>Assignee: Nitin Galave
> Fix For: 1.0.0, 0.7.1
>
> Attachments: RANGER-1602.patch
>
>
> Include / Exclude toggle is shown on the UI even if one of the resource at 
> the same level contains excludesSupported flag as true in service def.
> Ideally, it should honor the flag and show the toggle only if its set to true.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 59479: RangerUI: Include / Exclude toggle not working for same level resources.

[Nitin Galave]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59479/
---

Review request for ranger, Ankita Sinha, Gautam Borad, Ramesh Mani, and 
Velmurugan Periasamy.


Bugs: RANGER-1602
https://issues.apache.org/jira/browse/RANGER-1602


Repository: ranger


Description
---

Include / Exclude toggle is shown on the UI even if one of the resource at the 
same level contains excludeSupport flag as true in service def.
Ideally, it should honor the flag and show the toggle only if its set to true.


Diffs
-

  security-admin/src/main/webapp/scripts/modules/XAOverrides.js fb2f67b 


Diff: https://reviews.apache.org/r/59479/diff/1/


Testing
---

1. Include/exclude option not available when the user tried to create a policy 
using URL resource as per service def.
2. Include/exclude option is available when the user tries to create a policy 
using database resource.
3. All components policy screens showing/hiding include/exclude toggle as per 
service def.
4. Policy CRUD is working fine.


Thanks,

Nitin Galave

[jira] [Updated] (RANGER-1602) Include / Exclude toggle not working for same level resources

[Nitin Galave (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitin Galave updated RANGER-1602:
-
Description: 
Include / Exclude toggle is shown on the UI even if one of the resource at the 
same level contains excludesSupported flag as true in service def.

Ideally, it should honor the flag and show the toggle only if its set to true.

  was:
Include / Exclude toggle is shown on the UI even if one of the resource at the 
same level contains isExclude as true.

Ideally, it should honor the flag and shoe the toggle only if its set to true.


> Include / Exclude toggle not working for same level resources
> -
>
> Key: RANGER-1602
> URL: https://issues.apache.org/jira/browse/RANGER-1602
> Project: Ranger
>  Issue Type: Bug
>  Components: admin, Ranger
>Affects Versions: 0.7.0, 1.0.0
>Reporter: Gautam Borad
>Assignee: Nitin Galave
> Attachments: RANGER-1602.patch
>
>
> Include / Exclude toggle is shown on the UI even if one of the resource at 
> the same level contains excludesSupported flag as true in service def.
> Ideally, it should honor the flag and show the toggle only if its set to true.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1602) Include / Exclude toggle not working for same level resources

[Nitin Galave (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitin Galave updated RANGER-1602:
-
Attachment: RANGER-1602.patch

> Include / Exclude toggle not working for same level resources
> -
>
> Key: RANGER-1602
> URL: https://issues.apache.org/jira/browse/RANGER-1602
> Project: Ranger
>  Issue Type: Bug
>  Components: admin, Ranger
>Affects Versions: 0.7.0, 1.0.0
>Reporter: Gautam Borad
>Assignee: Nitin Galave
> Attachments: RANGER-1602.patch
>
>
> Include / Exclude toggle is shown on the UI even if one of the resource at 
> the same level contains isExclude as true.
> Ideally, it should honor the flag and shoe the toggle only if its set to true.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (RANGER-1602) Include / Exclude toggle not working for same level resources

[Nitin Galave (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitin Galave reassigned RANGER-1602:


Assignee: Nitin Galave  (was: Gautam Borad)

> Include / Exclude toggle not working for same level resources
> -
>
> Key: RANGER-1602
> URL: https://issues.apache.org/jira/browse/RANGER-1602
> Project: Ranger
>  Issue Type: Bug
>  Components: admin, Ranger
>Affects Versions: 0.7.0, 1.0.0
>Reporter: Gautam Borad
>Assignee: Nitin Galave
>
> Include / Exclude toggle is shown on the UI even if one of the resource at 
> the same level contains isExclude as true.
> Ideally, it should honor the flag and shoe the toggle only if its set to true.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59255: Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install a

[pengjianhua]

> On 五月 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote:
> > embeddedwebserver/scripts/ranger-admin-services.sh
> > Lines 71 (patched)
> > 
> >
> > Users can set RANGER_PID_DIR_PATH if they don't want to use default 
> > path. So what is the need for an additional variable?
> 
> pengjianhua wrote:
> This function is perfect if user independently use our ranger. 
> There is defect for ranger when they integrate Ranger into the big data 
> platform or business systems to uniform install and run Ranger. These systems 
> require services to support multiple instances, that is, the same service can 
> been run multiple instances in the same node. These systems need to 
> dynamically change the pid file path to avoid conflicts when they run 
> service. They hope that ranger also has the ability to dynamically change the 
> pid path at startup. 
> We should meet this need by minor modifications without affecting the 
> current function and logic.
> 
> Colm O hEigeartaigh wrote:
> I think it would be better if we kept the functionality of 
> RANGER_PID_DIR_PATH as it is, but instead used RANGER_ADMIN_PID_NAME or 
> something which would default to "rangeradmin.pid". So if you want to 
> customise it you can change the path via RANGER_PID_DIR_PATH and the filename 
> via RANGER_ADMIN_PID_NAME.
> 
> Gautam Borad wrote:
> +1 for Colm's suggestions.
> 
> Qiang Zhang wrote:
> +1 for Colm's suggestions.
> 
> pengjianhua wrote:
> The RANGER_PID_DIR_PATH variable was set when installing Ranger Admin. So 
> the value for RANGER_PID_DIR_PATH variable can not be changed after install 
> Ranger Admin. The user can only change the pid name and can not change the 
> path according to Colm's opinion.
> 1. The value for RANGER_PID_DIR_PATH was writed to 
> ./ews/webapp/WEB-INF/classes/conf/ranger-admin-env-piddir.sh file when 
> installing Ranger Admin.
> 2. Get the value for RANGER_PID_DIR_PATH through following code when run 
> Ranger Admin service.
> for custom_env_script in `find 
> ${XAPOLICYMGR_DIR}/ews/webapp/WEB-INF/classes/conf/ -name 
> "ranger-admin-env*"`; do
> if [ -f $custom_env_script ]; then
> . $custom_env_script
> fi
> done
> 
> Hi Colm, Do you have better opinion? Thanks!
> 
> Qiang Zhang wrote:
> Hi Colm, I think that pengjianhua's modification logic is also very 
> reasonable. In the case of meeting new needs, his logic is very well 
> compatible with the existing logic and does not introduce new problems.
> About your opinion and his logic, do you think which is more appropriate 
> to submit this issue? I tend to his logic after reading his explanation.
> 
> Colm O hEigeartaigh wrote:
> Is it possible to modify the logic of the "for custom_env_script" above 
> so that it only sets e.g. RANGER_PID_DIR_PATH if there isn't a user (runtime) 
> defined value for it already?
> 
> Qiang Zhang wrote:
> Ok. These methods are able to achieve this function. This issue can be 
> finished based on your opinion.
> 
> pengjianhua wrote:
> I will rebuild the patch according your opinion.

I updated the patch according to your review.


- pengjianhua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
---


On 五月 23, 2017, 4:07 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> ---
> 
> (Updated 五月 23, 2017, 4:07 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Some users hope that the pid file of the Ranger Admin can be unified 
> management when they integrate Ranger into the big data platform or business 
> systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. 
> When running ranger, users can set the pid file to meet their own needs.
> 
> We will explicitly document this change in the next release.
> 
> 
> Diffs
> -
> 
>   embeddedwebserver/scripts/ranger-admin-services.sh a81219b 
> 
> 
> Diff: https://reviews.apache.org/r/59255/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59255: Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install a

[pengjianhua]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/
---

(Updated 五月 23, 2017, 4:07 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1575
https://issues.apache.org/jira/browse/RANGER-1575


Repository: ranger


Description
---

Some users hope that the pid file of the Ranger Admin can be unified management 
when they integrate Ranger into the big data platform or business systems to 
uniform install and run Ranger.
We should support the need in the case of compatibility with existing logic. 
When running ranger, users can set the pid file to meet their own needs.

We will explicitly document this change in the next release.


Diffs (updated)
-

  embeddedwebserver/scripts/ranger-admin-services.sh a81219b 


Diff: https://reviews.apache.org/r/59255/diff/2/

Changes: https://reviews.apache.org/r/59255/diff/1-2/


Testing
---


Thanks,

pengjianhua

Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during inst

[pengjianhua]

> On 五月 22, 2017, 9:58 a.m., Colm O hEigeartaigh wrote:
> > The comment "# The new code will be compatible with the original code 
> > logic." is a bit unnecessary. After the patch is applied it might confuse 
> > someone looking at the code.

Ok. I deleted the comment and updated the patch.


- pengjianhua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59436/#review175619
---


On 五月 22, 2017, 7:49 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59436/
> ---
> 
> (Updated 五月 22, 2017, 7:49 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1600
> https://issues.apache.org/jira/browse/RANGER-1600
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> In install.properties, I configured the testusr user and the testgroup groups 
> that not exist in system. The error “chown: invalid user: testusr:testgroup” 
> occured during installed the hbase plugin.
> The enable script judges whether the user and the user group are empty to 
> determine whether they are available. This logic is flawed.
> 
> 
> Diffs
> -
> 
>   agents-common/scripts/enable-agent.sh 76ba8f0 
> 
> 
> Diff: https://reviews.apache.org/r/59436/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during inst

[pengjianhua]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59436/
---

(Updated 五月 23, 2017, 2:13 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1600
https://issues.apache.org/jira/browse/RANGER-1600


Repository: ranger


Description
---

In install.properties, I configured the testusr user and the testgroup groups 
that not exist in system. The error “chown: invalid user: testusr:testgroup” 
occured during installed the hbase plugin.
The enable script judges whether the user and the user group are empty to 
determine whether they are available. This logic is flawed.


Diffs (updated)
-

  agents-common/scripts/enable-agent.sh 76ba8f0 


Diff: https://reviews.apache.org/r/59436/diff/2/

Changes: https://reviews.apache.org/r/59436/diff/1-2/


Testing
---


Thanks,

pengjianhua

[jira] [Resolved] (RANGER-1597) The log is inconsistent with the code in RangerServiceDefHelper class,update it to ensure their consistency.

[peng.jianhua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua resolved RANGER-1597.
--
   Resolution: Fixed
Fix Version/s: 1.0.0

> The log is inconsistent with the code in RangerServiceDefHelper class,update 
> it to ensure their consistency.
> 
>
> Key: RANGER-1597
> URL: https://issues.apache.org/jira/browse/RANGER-1597
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Affects Versions: 1.0.0
> Environment: The log is inconsistent with the code in 
> RangerServiceDefHelper class,update it to ensure their consistency.
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Trivial
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-1597-The-log-is-inconsistent-with-the-code-in.patch
>
>
> The log is inconsistent with the code in RangerServiceDefHelper class,update 
> it to ensure their consistency.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (RANGER-1599) Different developers use different log directories in the Ranger Admin installation script. Its processing logic is chaotic. We should optimize this logic.

[Qiang Zhang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang resolved RANGER-1599.
-
   Resolution: Fixed
Fix Version/s: 1.0.0

> Different developers use different log directories in the Ranger Admin 
> installation script. Its processing logic is chaotic. We should  optimize 
> this logic.
> 
>
> Key: RANGER-1599
> URL: https://issues.apache.org/jira/browse/RANGER-1599
> Project: Ranger
>  Issue Type: Bug
>  Components: admin
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-1599-Different-developers-use-different-log-d.patch
>
>
> Different developers use different log directories in the Ranger Admin 
> installation script. Its processing logic is chaotic. In fact, this log file 
> does not need to be created separately. When the echo "${prefix} $@" >> 
> $LOGFILE command is used, the log file will be created automatically if it 
> does not exist.
> We should  optimize this logic.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1603) Code improvement as recommended by good coding practices

[Abhay Kulkarni (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhay Kulkarni updated RANGER-1603:
---
   Affects Version/s: 0.6.2
  0.6.3
Request participants:   (was: )
   Fix Version/s: 0.6.4

> Code improvement as recommended by good coding practices
> 
>
> Key: RANGER-1603
> URL: https://issues.apache.org/jira/browse/RANGER-1603
> Project: Ranger
>  Issue Type: Bug
>  Components: plugins
>Affects Versions: 0.7.0, 0.6.2, 0.6.3, 1.0.0
>Reporter: Abhay Kulkarni
>Assignee: Abhay Kulkarni
> Fix For: 0.6.4, 1.0.0, 0.7.1
>
>
> Refactor resource-matcher for clarity/readability and adherence to good 
> coding practices.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (RANGER-1601) The log name is incorrect in ValuePrinter.java

[Qiang Zhang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang resolved RANGER-1601.
-
   Resolution: Fixed
Fix Version/s: 1.0.0

> The log name is incorrect in ValuePrinter.java
> --
>
> Key: RANGER-1601
> URL: https://issues.apache.org/jira/browse/RANGER-1601
> Project: Ranger
>  Issue Type: Bug
>  Components: plugins
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Trivial
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-1601-The-log-name-is-incorrect-in-ValuePrinte.patch
>
>
> The log name should use 'ValuePrinter.class' instead of 
> 'RangerGeolocationDatabase.class' in ValuePrinter.java.
> Change from 'private static final Log LOG = 
> LogFactory.getLog(RangerGeolocationDatabase.class);' to 'private static final 
> Log LOG = LogFactory.getLog(ValuePrinter.class);'



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (RANGER-1598) make the tips of group and user consistent with others in en.js

[Qiang Zhang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang resolved RANGER-1598.
-
   Resolution: Fixed
Fix Version/s: 1.0.0

>  make the  tips of group and user consistent with others in en.js 
> --
>
> Key: RANGER-1598
> URL: https://issues.apache.org/jira/browse/RANGER-1598
> Project: Ranger
>  Issue Type: Improvement
>  Components: admin
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Minor
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-1598-make-the-tips-of-group-and-user-consiste.patch, 
> permisson-user.jpg
>
>
> In service webpage of Ranger-Admin  to select group and user if we didn't 
> select group and user will show the tips :
> Please add permission(s) for the selected User, else User will not be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (RANGER-1592) Do code improvement for static fields and Log in the AtlasClient.java

[Qiang Zhang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang resolved RANGER-1592.
-
   Resolution: Fixed
Fix Version/s: 1.0.0

> Do code improvement for static  fields and Log  in the  AtlasClient.java
> 
>
> Key: RANGER-1592
> URL: https://issues.apache.org/jira/browse/RANGER-1592
> Project: Ranger
>  Issue Type: Bug
>  Components: plugins
>Affects Versions: master
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Minor
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-1592-Do-code-improvement-for-static-fields-an.patch
>
>
> Do code improvement for static  fields and Log  in the  AtlasClient.java 
> change from  private static final String ATLAS_ENTITY_lIST_API_ENDPOINT = 
> "/api/atlas/v1/entities";
> to  private static final String ATLAS_ENTITY_LIST_API_ENDPOINT = 
> "/api/atlas/v1/entities";
> And alter:
> if (LOG.isDebugEnabled()) {
>   
> LOG.debug("getEntityResource():Adding existsResource "
>   
> + responseResource);



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59469: Code improvement as recommended by good coding practices

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59469/#review175727
---


Ship it!




Ship It!

- Madhan Neethiraj


On May 22, 2017, 11:12 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59469/
> ---
> 
> (Updated May 22, 2017, 11:12 p.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-1603
> https://issues.apache.org/jira/browse/RANGER-1603
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Refactored resource-matcher for clarity/readability and adherence to good 
> coding practices. Added more unit tests.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java
>  8c47df2 
>   
> agents-common/src/test/resources/resourcematcher/test_resourcematcher_path.json
>  86da28c 
> 
> 
> Diff: https://reviews.apache.org/r/59469/diff/1/
> 
> 
> Testing
> ---
> 
> Compiled, ran and passed all unit tests.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Review Request 59469: Code improvement as recommended by good coding practices

[Abhay Kulkarni]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59469/
---

Review request for ranger and Madhan Neethiraj.


Bugs: RANGER-1603
https://issues.apache.org/jira/browse/RANGER-1603


Repository: ranger


Description
---

Refactored resource-matcher for clarity/readability and adherence to good 
coding practices. Added more unit tests.


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java
 8c47df2 
  
agents-common/src/test/resources/resourcematcher/test_resourcematcher_path.json 
86da28c 


Diff: https://reviews.apache.org/r/59469/diff/1/


Testing
---

Compiled, ran and passed all unit tests.


Thanks,

Abhay Kulkarni

[jira] [Created] (RANGER-1603) Code improvement as recommended by good coding practices

[Abhay Kulkarni (JIRA)]

Abhay Kulkarni created RANGER-1603:
--

 Summary: Code improvement as recommended by good coding practices
 Key: RANGER-1603
 URL: https://issues.apache.org/jira/browse/RANGER-1603
 Project: Ranger
  Issue Type: Bug
  Components: plugins
Affects Versions: 0.7.0, 1.0.0
Reporter: Abhay Kulkarni
Assignee: Abhay Kulkarni
 Fix For: 1.0.0, 0.7.1


Refactor resource-matcher for clarity/readability and adherence to good coding 
practices.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RANGER-1584) Allow tagsync to support log directory from Ambari configuration

[Yujie Li (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019961#comment-16019961
 ] 

Yujie Li commented on RANGER-1584:
--

[~coheigea] 
Hi, I have created the review request but got no responses yet.

> Allow tagsync to support log directory from Ambari configuration
> 
>
> Key: RANGER-1584
> URL: https://issues.apache.org/jira/browse/RANGER-1584
> Project: Ranger
>  Issue Type: Bug
>  Components: tagsync
>Affects Versions: master, 0.7.1
>Reporter: Yujie Li
>Assignee: Yujie Li
>Priority: Minor
> Fix For: 0.7.1
>
> Attachments: 
> 0001-RANGER-1584-Allow-tagsync-to-support-log-directory-f.patch
>
>
> Currently Tagsync hardcodes the log directory as /var/log/ranger/tagsync. It 
> doesn't support customization setting for log location from Ambari side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (RANGER-1595) conf directory is missing

[Nishit Jain (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nishit Jain resolved RANGER-1595.
-
Resolution: Not A Bug

User error

> conf directory is missing
> -
>
> Key: RANGER-1595
> URL: https://issues.apache.org/jira/browse/RANGER-1595
> Project: Ranger
>  Issue Type: Bug
>  Components: admin
>Affects Versions: 0.7.0
>Reporter: Nishit Jain
>
> I pulled 0.7.0 release from http://ranger.apache.org/download.html
> Built it and found that was not conf folder:
> ranger-0.7.0-admin/ews/webapp/WEB-INF/classes -> ls
> META-INF db_message_bundle.properties org 
>  resourcenamemap.properties
> conf.distlog4jdbc.properties  ranger-plugins
> As a result of that when I run ranger-admin-services.sh start I am getting:
> find: `/data/ranger/ews/webapp/WEB-INF/classes/conf/': No such file or 
> directory
> Starting Apache Ranger Admin Service
> Apache Ranger Admin Service failed to start!



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RANGER-1595) conf directory is missing

[Nishit Jain (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019800#comment-16019800
 ] 

Nishit Jain commented on RANGER-1595:
-

 You were stop on. I was running into some quirks of Docker and saw issues in 
executing setup.sh. I am passed that now. Thanks y'all!

> conf directory is missing
> -
>
> Key: RANGER-1595
> URL: https://issues.apache.org/jira/browse/RANGER-1595
> Project: Ranger
>  Issue Type: Bug
>  Components: admin
>Affects Versions: 0.7.0
>Reporter: Nishit Jain
>
> I pulled 0.7.0 release from http://ranger.apache.org/download.html
> Built it and found that was not conf folder:
> ranger-0.7.0-admin/ews/webapp/WEB-INF/classes -> ls
> META-INF db_message_bundle.properties org 
>  resourcenamemap.properties
> conf.distlog4jdbc.properties  ranger-plugins
> As a result of that when I run ranger-admin-services.sh start I am getting:
> find: `/data/ranger/ews/webapp/WEB-INF/classes/conf/': No such file or 
> directory
> Starting Apache Ranger Admin Service
> Apache Ranger Admin Service failed to start!



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RANGER-1446) Ranger Solr Plugin does not work when the collection list in the request is empty

[Colm O hEigeartaigh (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019788#comment-16019788
 ] 

Colm O hEigeartaigh commented on RANGER-1446:
-

Hi [~yzhou2001],

I'm wondering if the RangerSolrAuthorizer..createRequest logic should be 
modified after this change (to default to "true"). If no collection name is 
specified then it will not attempt any authorization. I'm not sure if this 
could arise in practise or not. It would seem safer to default to "*" if no 
collection name is specified and to perform the authorization. Would this 
change break your tests?

Colm.

> Ranger Solr Plugin does not work when the collection list in the request is 
> empty
> -
>
> Key: RANGER-1446
> URL: https://issues.apache.org/jira/browse/RANGER-1446
> Project: Ranger
>  Issue Type: Bug
>  Components: plugins
>Affects Versions: 0.7.0, 0.6.1, 0.6.2, 0.6.3
>Reporter: Yan
>Assignee: Yan
>Priority: Critical
> Fix For: 1.0.0, 0.7.1
>
> Attachments: 
> 0001-Ranger-1446-Ranger-Solr-Plugin-does-not-work-when-th.patch
>
>
> The fix of Ranger-1095 set the initial value of "denied" to "true" from the 
> previous "false". One impact of this change is that, when 
> context.getCollectionRequests() is empty which could be the case in many 
> invocations Solr makes to Ranger on authorization per client request, the 
> permission is plainly denied without going to Ranger policy engine. So the 
> fix changed the default behavior related "denied".
> A proper fix of Ranger-1095 IMO should be just to set the "denied" to "true" 
> in the catch block without changing the initial value of the variable.
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59392: Do code improvement for static fields and Log in the AtlasClient.java

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59392/#review175634
---


Ship it!




Ship It!

- Colm O hEigeartaigh


On May 22, 2017, 11:42 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59392/
> ---
> 
> (Updated May 22, 2017, 11:42 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1592
> https://issues.apache.org/jira/browse/RANGER-1592
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Do code improvement for static fields and Log in the AtlasClient.java 
> change from private static final String ATLAS_ENTITY_lIST_API_ENDPOINT = 
> "/api/atlas/v1/entities";
> to private static final String ATLAS_ENTITY_LIST_API_ENDPOINT = 
> "/api/atlas/v1/entities";
> And alter:if (LOG.isDebugEnabled()) {
> LOG.debug("getEntityResource():Adding existsResource "
> + responseResource);
> 
> 
> Diffs
> -
> 
>   
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java
>  e686c4d 
> 
> 
> Diff: https://reviews.apache.org/r/59392/diff/2/
> 
> 
> Testing
> ---
> 
> tested it
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

[jira] [Created] (RANGER-1602) Include / Exclude toggle not working for same level resources

[Gautam Borad (JIRA)]

Gautam Borad created RANGER-1602:


 Summary: Include / Exclude toggle not working for same level 
resources
 Key: RANGER-1602
 URL: https://issues.apache.org/jira/browse/RANGER-1602
 Project: Ranger
  Issue Type: Bug
  Components: admin, Ranger
Affects Versions: 0.7.0, 1.0.0
Reporter: Gautam Borad
Assignee: Gautam Borad


Include / Exclude toggle is shown on the UI even if one of the resource at the 
same level contains isExclude as true.

Ideally, it should honor the flag and shoe the toggle only if its set to true.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59447: RANGER-1601 The log name is incorrect in ValuePrinter.java

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59447/#review175633
---


Ship it!




Ship It!

- Colm O hEigeartaigh


On May 22, 2017, 11:43 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59447/
> ---
> 
> (Updated May 22, 2017, 11:43 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1601
> https://issues.apache.org/jira/browse/RANGER-1601
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> The log name should use 'ValuePrinter.class' instead of 
> 'RangerGeolocationDatabase.class' in ValuePrinter.java.
> Change from 'private static final Log LOG = 
> LogFactory.getLog(RangerGeolocationDatabase.class);' to 'private static final 
> Log LOG = LogFactory.getLog(ValuePrinter.class);'
> 
> 
> Diffs
> -
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/geo/ValuePrinter.java 
> 89bb0b40 
> 
> 
> Diff: https://reviews.apache.org/r/59447/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59432: make the tips of group and user consistent with others in en.js

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59432/#review175632
---


Ship it!




Ship It!

- Colm O hEigeartaigh


On May 22, 2017, 11:24 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59432/
> ---
> 
> (Updated May 22, 2017, 11:24 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1598
> https://issues.apache.org/jira/browse/RANGER-1598
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> In service webpage of Ranger-Admin to select group and user if we didn't 
> select group and user will show the tips :
> Please add permission(s) for the selected User, else User will not be added.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> 8f7d5d9 
> 
> 
> Diff: https://reviews.apache.org/r/59432/diff/2/
> 
> 
> Testing
> ---
> 
> tested it
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 59392: Do code improvement for static fields and Log in the AtlasClient.java

[Qiang Zhang]

> On 五月 22, 2017, 9:51 a.m., Colm O hEigeartaigh wrote:
> > Change "Adding exists Resource" to "Adding existing Resource".

Thanks for your reminder ,I have update the patch.


- Qiang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59392/#review175617
---


On 五月 22, 2017, 11:42 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59392/
> ---
> 
> (Updated 五月 22, 2017, 11:42 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1592
> https://issues.apache.org/jira/browse/RANGER-1592
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Do code improvement for static fields and Log in the AtlasClient.java 
> change from private static final String ATLAS_ENTITY_lIST_API_ENDPOINT = 
> "/api/atlas/v1/entities";
> to private static final String ATLAS_ENTITY_LIST_API_ENDPOINT = 
> "/api/atlas/v1/entities";
> And alter:if (LOG.isDebugEnabled()) {
> LOG.debug("getEntityResource():Adding existsResource "
> + responseResource);
> 
> 
> Diffs
> -
> 
>   
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java
>  e686c4d 
> 
> 
> Diff: https://reviews.apache.org/r/59392/diff/2/
> 
> 
> Testing
> ---
> 
> tested it
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Review Request 59447: RANGER-1601 The log name is incorrect in ValuePrinter.java

[pengjianhua]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59447/
---

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1601
https://issues.apache.org/jira/browse/RANGER-1601


Repository: ranger


Description
---

The log name should use 'ValuePrinter.class' instead of 
'RangerGeolocationDatabase.class' in ValuePrinter.java.
Change from 'private static final Log LOG = 
LogFactory.getLog(RangerGeolocationDatabase.class);' to 'private static final 
Log LOG = LogFactory.getLog(ValuePrinter.class);'


Diffs
-

  agents-common/src/main/java/org/apache/ranger/plugin/geo/ValuePrinter.java 
89bb0b40 


Diff: https://reviews.apache.org/r/59447/diff/1/


Testing
---


Thanks,

pengjianhua

Re: Review Request 59392: Do code improvement for static fields and Log in the AtlasClient.java

[Qiang Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59392/
---

(Updated 五月 22, 2017, 11:42 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, and Velmurugan Periasamy.


Changes
---

update patch


Bugs: RANGER-1592
https://issues.apache.org/jira/browse/RANGER-1592


Repository: ranger


Description
---

Do code improvement for static fields and Log in the AtlasClient.java 
change from private static final String ATLAS_ENTITY_lIST_API_ENDPOINT = 
"/api/atlas/v1/entities";
to private static final String ATLAS_ENTITY_LIST_API_ENDPOINT = 
"/api/atlas/v1/entities";
And alter:  if (LOG.isDebugEnabled()) {
LOG.debug("getEntityResource():Adding existsResource "
+ responseResource);


Diffs (updated)
-

  
plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java
 e686c4d 


Diff: https://reviews.apache.org/r/59392/diff/2/

Changes: https://reviews.apache.org/r/59392/diff/1-2/


Testing
---

tested it


Thanks,

Qiang Zhang

[jira] [Updated] (RANGER-1592) Do code improvement for static fields and Log in the AtlasClient.java

[Qiang Zhang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-1592:

Attachment: 0001-RANGER-1592-Do-code-improvement-for-static-fields-an.patch

> Do code improvement for static  fields and Log  in the  AtlasClient.java
> 
>
> Key: RANGER-1592
> URL: https://issues.apache.org/jira/browse/RANGER-1592
> Project: Ranger
>  Issue Type: Bug
>  Components: plugins
>Affects Versions: master
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Minor
> Attachments: 
> 0001-RANGER-1592-Do-code-improvement-for-static-fields-an.patch
>
>
> Do code improvement for static  fields and Log  in the  AtlasClient.java 
> change from  private static final String ATLAS_ENTITY_lIST_API_ENDPOINT = 
> "/api/atlas/v1/entities";
> to  private static final String ATLAS_ENTITY_LIST_API_ENDPOINT = 
> "/api/atlas/v1/entities";
> And alter:
> if (LOG.isDebugEnabled()) {
>   
> LOG.debug("getEntityResource():Adding existsResource "
>   
> + responseResource);



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1601) The log name is incorrect in ValuePrinter.java

[peng.jianhua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1601:
-
Attachment: 0001-RANGER-1601-The-log-name-is-incorrect-in-ValuePrinte.patch

> The log name is incorrect in ValuePrinter.java
> --
>
> Key: RANGER-1601
> URL: https://issues.apache.org/jira/browse/RANGER-1601
> Project: Ranger
>  Issue Type: Bug
>  Components: plugins
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Trivial
> Attachments: 
> 0001-RANGER-1601-The-log-name-is-incorrect-in-ValuePrinte.patch
>
>
> The log name should use 'ValuePrinter.class' instead of 
> 'RangerGeolocationDatabase.class' in ValuePrinter.java.
> Change from 'private static final Log LOG = 
> LogFactory.getLog(RangerGeolocationDatabase.class);' to 'private static final 
> Log LOG = LogFactory.getLog(ValuePrinter.class);'



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RANGER-1601) The log name is incorrect in ValuePrinter.java

[peng.jianhua (JIRA)]

peng.jianhua created RANGER-1601:


 Summary: The log name is incorrect in ValuePrinter.java
 Key: RANGER-1601
 URL: https://issues.apache.org/jira/browse/RANGER-1601
 Project: Ranger
  Issue Type: Bug
  Components: plugins
Reporter: peng.jianhua
Assignee: peng.jianhua
Priority: Trivial
 Attachments: 
0001-RANGER-1601-The-log-name-is-incorrect-in-ValuePrinte.patch

The log name should use 'ValuePrinter.class' instead of 
'RangerGeolocationDatabase.class' in ValuePrinter.java.
Change from 'private static final Log LOG = 
LogFactory.getLog(RangerGeolocationDatabase.class);' to 'private static final 
Log LOG = LogFactory.getLog(ValuePrinter.class);'



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59432: make the tips of group and user consistent with others in en.js

[Qiang Zhang]

> On 五月 22, 2017, 9:55 a.m., Colm O hEigeartaigh wrote:
> > Looks fine, but there is another typo just below which you could fix - 
> > "alteast" -> "at least"

Perfect? I have update the patch.


- Qiang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59432/#review175618
---


On 五月 22, 2017, 11:24 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59432/
> ---
> 
> (Updated 五月 22, 2017, 11:24 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1598
> https://issues.apache.org/jira/browse/RANGER-1598
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> In service webpage of Ranger-Admin to select group and user if we didn't 
> select group and user will show the tips :
> Please add permission(s) for the selected User, else User will not be added.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> 8f7d5d9 
> 
> 
> Diff: https://reviews.apache.org/r/59432/diff/2/
> 
> 
> Testing
> ---
> 
> tested it
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

[jira] [Updated] (RANGER-1598) make the tips of group and user consistent with others in en.js

[Qiang Zhang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-1598:

Attachment: (was: 
0001-RANGER-1598-make-the-tips-of-group-and-user-consiste.patch)

>  make the  tips of group and user consistent with others in en.js 
> --
>
> Key: RANGER-1598
> URL: https://issues.apache.org/jira/browse/RANGER-1598
> Project: Ranger
>  Issue Type: Improvement
>  Components: admin
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Minor
> Attachments: 
> 0001-RANGER-1598-make-the-tips-of-group-and-user-consiste.patch, 
> permisson-user.jpg
>
>
> In service webpage of Ranger-Admin  to select group and user if we didn't 
> select group and user will show the tips :
> Please add permission(s) for the selected User, else User will not be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59432: make the tips of group and user consistent with others in en.js

[Qiang Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59432/
---

(Updated 五月 22, 2017, 11:24 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, and Velmurugan Periasamy.


Changes
---

update patch


Bugs: RANGER-1598
https://issues.apache.org/jira/browse/RANGER-1598


Repository: ranger


Description
---

In service webpage of Ranger-Admin to select group and user if we didn't select 
group and user will show the tips :
Please add permission(s) for the selected User, else User will not be added.


Diffs (updated)
-

  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
8f7d5d9 


Diff: https://reviews.apache.org/r/59432/diff/2/

Changes: https://reviews.apache.org/r/59432/diff/1-2/


Testing
---

tested it


Thanks,

Qiang Zhang

[jira] [Updated] (RANGER-1598) make the tips of group and user consistent with others in en.js

[Qiang Zhang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-1598:

Attachment: 0001-RANGER-1598-make-the-tips-of-group-and-user-consiste.patch

>  make the  tips of group and user consistent with others in en.js 
> --
>
> Key: RANGER-1598
> URL: https://issues.apache.org/jira/browse/RANGER-1598
> Project: Ranger
>  Issue Type: Improvement
>  Components: admin
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Minor
> Attachments: 
> 0001-RANGER-1598-make-the-tips-of-group-and-user-consiste.patch, 
> permisson-user.jpg
>
>
> In service webpage of Ranger-Admin  to select group and user if we didn't 
> select group and user will show the tips :
> Please add permission(s) for the selected User, else User will not be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59435: Different developers use different log directories in the Ranger Admin installation script. Its processing logic is chaotic. We should optimize this logic.

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59435/#review175620
---


Ship it!




Ship It!

- Colm O hEigeartaigh


On May 22, 2017, 7:14 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59435/
> ---
> 
> (Updated May 22, 2017, 7:14 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1599
> https://issues.apache.org/jira/browse/RANGER-1599
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Different developers use different log directories in the Ranger Admin 
> installation script. Its processing logic is chaotic. In fact, this log file 
> does not need to be created separately. When the echo "${prefix} $@" >> 
> $LOGFILE command is used, the log file will be created automatically if it 
> does not exist.
> 
> We should  optimize this logic.
> 
> 
> Diffs
> -
> 
>   security-admin/scripts/setup.sh 3b259a02 
> 
> 
> Diff: https://reviews.apache.org/r/59435/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during inst

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59436/#review175619
---



The comment "# The new code will be compatible with the original code logic." 
is a bit unnecessary. After the patch is applied it might confuse someone 
looking at the code.

- Colm O hEigeartaigh


On May 22, 2017, 7:49 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59436/
> ---
> 
> (Updated May 22, 2017, 7:49 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1600
> https://issues.apache.org/jira/browse/RANGER-1600
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> In install.properties, I configured the testusr user and the testgroup groups 
> that not exist in system. The error “chown: invalid user: testusr:testgroup” 
> occured during installed the hbase plugin.
> The enable script judges whether the user and the user group are empty to 
> determine whether they are available. This logic is flawed.
> 
> 
> Diffs
> -
> 
>   agents-common/scripts/enable-agent.sh 76ba8f0 
> 
> 
> Diff: https://reviews.apache.org/r/59436/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59432: make the tips of group and user consistent with others in en.js

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59432/#review175618
---



Looks fine, but there is another typo just below which you could fix - 
"alteast" -> "at least"

- Colm O hEigeartaigh


On May 22, 2017, 6:47 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59432/
> ---
> 
> (Updated May 22, 2017, 6:47 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1598
> https://issues.apache.org/jira/browse/RANGER-1598
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> In service webpage of Ranger-Admin to select group and user if we didn't 
> select group and user will show the tips :
> Please add permission(s) for the selected User, else User will not be added.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> 8f7d5d9 
> 
> 
> Diff: https://reviews.apache.org/r/59432/diff/1/
> 
> 
> Testing
> ---
> 
> tested it
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 59392: Do code improvement for static fields and Log in the AtlasClient.java

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59392/#review175617
---



Change "Adding exists Resource" to "Adding existing Resource".

- Colm O hEigeartaigh


On May 22, 2017, 6:48 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59392/
> ---
> 
> (Updated May 22, 2017, 6:48 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1592
> https://issues.apache.org/jira/browse/RANGER-1592
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Do code improvement for static fields and Log in the AtlasClient.java 
> change from private static final String ATLAS_ENTITY_lIST_API_ENDPOINT = 
> "/api/atlas/v1/entities";
> to private static final String ATLAS_ENTITY_LIST_API_ENDPOINT = 
> "/api/atlas/v1/entities";
> And alter:if (LOG.isDebugEnabled()) {
> LOG.debug("getEntityResource():Adding existsResource "
> + responseResource);
> 
> 
> Diffs
> -
> 
>   
> plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java
>  62b67dc 
> 
> 
> Diff: https://reviews.apache.org/r/59392/diff/1/
> 
> 
> Testing
> ---
> 
> tested it
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 59433: RANGER-1597:The log is inconsistent with the code in RangerServiceDefHelper class, update it to ensure their consistency.

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59433/#review175616
---


Ship it!




Ship It!

- Colm O hEigeartaigh


On May 22, 2017, 3:09 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59433/
> ---
> 
> (Updated May 22, 2017, 3:09 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1597
> https://issues.apache.org/jira/browse/RANGER-1597
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> The log is inconsistent with the code in RangerServiceDefHelper class,update 
> it to ensure their consistency.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java
>  159ee1a 
> 
> 
> Diff: https://reviews.apache.org/r/59433/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

[jira] [Updated] (RANGER-1593) Avoid Classloading default AtlasResourceMappers

[Colm O hEigeartaigh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated RANGER-1593:

Attachment: (was: 
0001-RANGER-1593-Avoid-Classloading-default-AtlasResource.patch)

> Avoid Classloading default AtlasResourceMappers
> ---
>
> Key: RANGER-1593
> URL: https://issues.apache.org/jira/browse/RANGER-1593
> Project: Ranger
>  Issue Type: Improvement
>  Components: tagsync
>Reporter: Colm O hEigeartaigh
>Assignee: Colm O hEigeartaigh
>Priority: Minor
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-1593-Avoid-Classloading-default-AtlasResource.patch
>
>
> In AtlasResourceMapperUtil we classload both the default AtlasResourceMappers 
> and then the custom ones. This is unnecessary - we should just instantiate 
> the default ones and classload the custom ones.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1593) Avoid Classloading default AtlasResourceMappers

[Colm O hEigeartaigh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated RANGER-1593:

Attachment: 0001-RANGER-1593-Avoid-Classloading-default-AtlasResource.patch

Fixing whitespace issues.

> Avoid Classloading default AtlasResourceMappers
> ---
>
> Key: RANGER-1593
> URL: https://issues.apache.org/jira/browse/RANGER-1593
> Project: Ranger
>  Issue Type: Improvement
>  Components: tagsync
>Reporter: Colm O hEigeartaigh
>Assignee: Colm O hEigeartaigh
>Priority: Minor
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-1593-Avoid-Classloading-default-AtlasResource.patch
>
>
> In AtlasResourceMapperUtil we classload both the default AtlasResourceMappers 
> and then the custom ones. This is unnecessary - we should just instantiate 
> the default ones and classload the custom ones.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59395: RANGER-1593 - Avoid Classloading default AtlasResourceMappers

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59395/
---

(Updated May 22, 2017, 9:46 a.m.)


Review request for ranger.


Changes
---

Fixing whitespace


Bugs: RANGER-1593
https://issues.apache.org/jira/browse/RANGER-1593


Repository: ranger


Description
---

In AtlasResourceMapperUtil we classload both the default AtlasResourceMappers 
and then the custom ones. This is unnecessary - we should just instantiate the 
default ones and classload the custom ones.


Diffs (updated)
-

  
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java
 5227d8c3 


Diff: https://reviews.apache.org/r/59395/diff/2/

Changes: https://reviews.apache.org/r/59395/diff/1-2/


Testing
---


Thanks,

Colm O hEigeartaigh

Re: Review Request 59363: RANGER-1588 - Simplify Storm Test config

[Qiang Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59363/#review175613
---


Ship it!




Ship It!

- Qiang Zhang


On 五月 19, 2017, 8:55 a.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59363/
> ---
> 
> (Updated 五月 19, 2017, 8:55 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1588
> https://issues.apache.org/jira/browse/RANGER-1588
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> The Storm test config has way too many un-needed properties defined.
> 
> 
> Diffs
> -
> 
>   storm-agent/src/test/resources/storm.yaml a3069663 
> 
> 
> Diff: https://reviews.apache.org/r/59363/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 59399: RANGER-1594 - Fix HBase tests to work with HBase 1.2.x

[Qiang Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59399/#review175612
---


Ship it!




Ship It!

- Qiang Zhang


On 五月 19, 2017, 1:41 p.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59399/
> ---
> 
> (Updated 五月 19, 2017, 1:41 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1594
> https://issues.apache.org/jira/browse/RANGER-1594
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently, the HBase tests in Ranger fail on an upgrade to 1.2.x. This task 
> is to fix the tests so that when we upgrade everything works.
> 
> 
> Diffs
> -
> 
>   
> hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java
>  2a46709a 
> 
> 
> Diff: https://reviews.apache.org/r/59399/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 59395: RANGER-1593 - Avoid Classloading default AtlasResourceMappers

[Qiang Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59395/#review175611
---



Please rebuild the patch to fixed the following message.
.git/rebase-apply/patch:13: trailing whitespace.

.git/rebase-apply/patch:44: trailing whitespace.

.git/rebase-apply/patch:67: space before tab in indent.
try {
.git/rebase-apply/patch:68: space before tab in indent.
Class clazz = 
Class.forName(customMapperName);
.git/rebase-apply/patch:69: space before tab in indent.
AtlasResourceMapper resourceMapper = 
(AtlasResourceMapper) clazz.newInstance();
warning: squelched 7 whitespace errors
warning: 12 lines add whitespace errors.

- Qiang Zhang


On 五月 19, 2017, 10:42 a.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59395/
> ---
> 
> (Updated 五月 19, 2017, 10:42 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1593
> https://issues.apache.org/jira/browse/RANGER-1593
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> In AtlasResourceMapperUtil we classload both the default AtlasResourceMappers 
> and then the custom ones. This is unnecessary - we should just instantiate 
> the default ones and classload the custom ones.
> 
> 
> Diffs
> -
> 
>   
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java
>  5227d8c3 
> 
> 
> Diff: https://reviews.apache.org/r/59395/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

[jira] [Commented] (RANGER-1580) Update Kafka tests to work with 0.10.1.1

[peng.jianhua (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019264#comment-16019264
 ] 

peng.jianhua commented on RANGER-1580:
--

Can you create a RR?

> Update Kafka tests to work with 0.10.1.1
> 
>
> Key: RANGER-1580
> URL: https://issues.apache.org/jira/browse/RANGER-1580
> Project: Ranger
>  Issue Type: Test
>  Components: plugins
>Reporter: Colm O hEigeartaigh
>Assignee: Colm O hEigeartaigh
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-1580-Update-Kafka-tests-to-work-with-0.10.1.1.patch
>
>
> Right now, the Ranger Kafka tests hang with 0.10.1.1, as the authorizer needs 
> the "describe" policy for the given principal + topic, even when the 
> principal is not authorized to read the topic. Merging this update will 
> smooth future migration.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during inst

[Qiang Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59436/#review175609
---


Ship it!




Ship It!

- Qiang Zhang


On 五月 22, 2017, 7:49 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59436/
> ---
> 
> (Updated 五月 22, 2017, 7:49 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1600
> https://issues.apache.org/jira/browse/RANGER-1600
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> In install.properties, I configured the testusr user and the testgroup groups 
> that not exist in system. The error “chown: invalid user: testusr:testgroup” 
> occured during installed the hbase plugin.
> The enable script judges whether the user and the user group are empty to 
> determine whether they are available. This logic is flawed.
> 
> 
> Diffs
> -
> 
>   agents-common/scripts/enable-agent.sh 76ba8f0 
> 
> 
> Diff: https://reviews.apache.org/r/59436/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

[jira] [Resolved] (RANGER-1596) The log name is incorrect in Log4JAuditDestination.java.

[Qiang Zhang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang resolved RANGER-1596.
-
   Resolution: Fixed
Fix Version/s: 1.0.0

> The log name is incorrect in Log4JAuditDestination.java.
> 
>
> Key: RANGER-1596
> URL: https://issues.apache.org/jira/browse/RANGER-1596
> Project: Ranger
>  Issue Type: Bug
>  Components: audit
>Affects Versions: master
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Minor
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-1596-The-log-name-is-incorrect-in-Log4JAuditD.patch
>
>
> The log name should use 'Log4JAuditDestination.class' instead of 
> 'FileAuditDestination.class' in Log4JAuditDestination.java.
> Change from 'private static final Log logger = 
> LogFactory.getLog(FileAuditDestination.class);' to 'private static final Log 
> logger = LogFactory.getLog(Log4JAuditDestination.class);'



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installe

[pengjianhua]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59436/
---

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1600
https://issues.apache.org/jira/browse/RANGER-1600


Repository: ranger


Description
---

In install.properties, I configured the testusr user and the testgroup groups 
that not exist in system. The error “chown: invalid user: testusr:testgroup” 
occured during installed the hbase plugin.
The enable script judges whether the user and the user group are empty to 
determine whether they are available. This logic is flawed.


Diffs
-

  agents-common/scripts/enable-agent.sh 76ba8f0 


Diff: https://reviews.apache.org/r/59436/diff/1/


Testing
---


Thanks,

pengjianhua

[jira] [Updated] (RANGER-1600) In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during

[peng.jianhua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1600:
-
Attachment: 0001-RANGER-1600-In-install.properties-I-configured-the-t.patch

> In install.properties, I configured the testusr user and the testgroup groups 
> that not exist in system. The error “chown: invalid user: testusr:testgroup” 
> occured during installed the hbase plugin.
> -
>
> Key: RANGER-1600
> URL: https://issues.apache.org/jira/browse/RANGER-1600
> Project: Ranger
>  Issue Type: Bug
>  Components: plugins
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>  Labels: patch
> Attachments: 
> 0001-RANGER-1600-In-install.properties-I-configured-the-t.patch
>
>
> In install.properties, I configured the testusr user and the testgroup groups 
> that not exist in system. The error “chown: invalid user: testusr:testgroup” 
> occured during installed the hbase plugin.
> The enable script judges whether the user and the user group are empty to 
> determine whether they are available. This logic is flawed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59435: Different developers use different log directories in the Ranger Admin installation script. Its processing logic is chaotic. We should optimize this logic.

[Qiang Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59435/#review175606
---


Ship it!




Ship It!

- Qiang Zhang


On 五月 22, 2017, 7:14 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59435/
> ---
> 
> (Updated 五月 22, 2017, 7:14 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1599
> https://issues.apache.org/jira/browse/RANGER-1599
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Different developers use different log directories in the Ranger Admin 
> installation script. Its processing logic is chaotic. In fact, this log file 
> does not need to be created separately. When the echo "${prefix} $@" >> 
> $LOGFILE command is used, the log file will be created automatically if it 
> does not exist.
> 
> We should  optimize this logic.
> 
> 
> Diffs
> -
> 
>   security-admin/scripts/setup.sh 3b259a02 
> 
> 
> Diff: https://reviews.apache.org/r/59435/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Review Request 59435: Different developers use different log directories in the Ranger Admin installation script. Its processing logic is chaotic. We should optimize this logic.

[pengjianhua]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59435/
---

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1599
https://issues.apache.org/jira/browse/RANGER-1599


Repository: ranger


Description
---

Different developers use different log directories in the Ranger Admin 
installation script. Its processing logic is chaotic. In fact, this log file 
does not need to be created separately. When the echo "${prefix} $@" >> 
$LOGFILE command is used, the log file will be created automatically if it does 
not exist.

We should  optimize this logic.


Diffs
-

  security-admin/scripts/setup.sh 3b259a02 


Diff: https://reviews.apache.org/r/59435/diff/1/


Testing
---


Thanks,

pengjianhua

[jira] [Updated] (RANGER-1599) Different developers use different log directories in the Ranger Admin installation script. Its processing logic is chaotic. We should optimize this logic.

[peng.jianhua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1599:
-
Attachment: 0001-RANGER-1599-Different-developers-use-different-log-d.patch

> Different developers use different log directories in the Ranger Admin 
> installation script. Its processing logic is chaotic. We should  optimize 
> this logic.
> 
>
> Key: RANGER-1599
> URL: https://issues.apache.org/jira/browse/RANGER-1599
> Project: Ranger
>  Issue Type: Bug
>  Components: admin
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>Priority: Minor
>  Labels: patch
> Attachments: 
> 0001-RANGER-1599-Different-developers-use-different-log-d.patch
>
>
> Different developers use different log directories in the Ranger Admin 
> installation script. Its processing logic is chaotic. In fact, this log file 
> does not need to be created separately. When the echo "${prefix} $@" >> 
> $LOGFILE command is used, the log file will be created automatically if it 
> does not exist.
> We should  optimize this logic.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)