> On 五月 22, 2017, 9:58 a.m., Colm O hEigeartaigh wrote: > > The comment "# The new code will be compatible with the original code > > logic." is a bit unnecessary. After the patch is applied it might confuse > > someone looking at the code.
Ok. I deleted the comment and updated the patch. - pengjianhua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59436/#review175619 ----------------------------------------------------------- On 五月 22, 2017, 7:49 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59436/ > ----------------------------------------------------------- > > (Updated 五月 22, 2017, 7:49 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1600 > https://issues.apache.org/jira/browse/RANGER-1600 > > > Repository: ranger > > > Description > ------- > > In install.properties, I configured the testusr user and the testgroup groups > that not exist in system. The error “chown: invalid user: testusr:testgroup” > occured during installed the hbase plugin. > The enable script judges whether the user and the user group are empty to > determine whether they are available. This logic is flawed. > > > Diffs > ----- > > agents-common/scripts/enable-agent.sh 76ba8f0 > > > Diff: https://reviews.apache.org/r/59436/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
