Re: Review Request 70394: Presto Plugin

2019-05-02 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70394/#review215006
---




pom.xml
Line 180 (original), 181 (patched)


could you please update the patch? 

```
$ git apply --check -v ~/Downloads/0001-Add-Presto-plugin.patch
Checking patch agents-common/scripts/enable-agent.sh...
Checking patch 
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java...
Checking patch 
agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json...
Checking patch plugin-presto/conf/ranger-policymgr-ssl-changes.cfg...
Checking patch plugin-presto/conf/ranger-policymgr-ssl.xml...
Checking patch plugin-presto/conf/ranger-presto-audit-changes.cfg...
Checking patch plugin-presto/conf/ranger-presto-audit.xml...
Checking patch plugin-presto/conf/ranger-presto-security-changes.cfg...
Checking patch plugin-presto/conf/ranger-presto-security.xml...
Checking patch plugin-presto/pom.xml...
Checking patch plugin-presto/scripts/install.properties...
Checking patch 
plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java...
Checking patch 
plugin-presto/src/main/java/org/apache/ranger/services/presto/RangerServicePresto.java...
Checking patch 
plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoClient.java...
Checking patch 
plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoConnectionManager.java...
Checking patch 
plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java...
Checking patch pom.xml...
error: while searching for:

3.1.4
5.0.3
2.9.8




error: patch failed: pom.xml:181
error: pom.xml: patch does not apply
Checking patch ranger-presto-plugin-shim/pom.xml...
Checking patch 
ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/PrestoRangerPlugin.java...
Checking patch 
ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerConfig.java...
Checking patch 
ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java...
Checking patch 
ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlFactory.java...
Checking patch 
ranger-presto-plugin-shim/src/main/resources/META-INF/services/io.prestosql.spi.Plugin...
Checking patch src/main/assembly/admin-web.xml...
Hunk #1 succeeded at 403 (offset 3 lines).
Checking patch src/main/assembly/plugin-presto.xml...
```


- Velmurugan Periasamy


On April 18, 2019, 7:04 p.m., Bolke de Bruin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70394/
> ---
> 
> (Updated April 18, 2019, 7:04 p.m.)
> 
> 
> Review request for ranger and Abhay Kulkarni.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/RANGER-2395
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-2395
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Presto Plugin for Ranger.
> 
> 
> Diffs
> -
> 
>   agents-common/scripts/enable-agent.sh b4194a736 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
>  cbfd649c9 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json 
> PRE-CREATION 
>   plugin-presto/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION 
>   plugin-presto/conf/ranger-policymgr-ssl.xml PRE-CREATION 
>   plugin-presto/conf/ranger-presto-audit-changes.cfg PRE-CREATION 
>   plugin-presto/conf/ranger-presto-audit.xml PRE-CREATION 
>   plugin-presto/conf/ranger-presto-security-changes.cfg PRE-CREATION 
>   plugin-presto/conf/ranger-presto-security.xml PRE-CREATION 
>   plugin-presto/pom.xml PRE-CREATION 
>   plugin-presto/scripts/install.properties PRE-CREATION 
>   
> plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java
>  PRE-CREATION 
>   
> plugin-presto/src/main/java/org/apache/ranger/services/presto/RangerServicePresto.java
>  PRE-CREATION 
>   
> plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoClient.java
>  PRE-CREATION 
>   
> plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoConnectionManager.java
>  PRE-CREATION 
>   
> plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java
>

Re: Review Request 70565: RANGER-2411 : Restrict Admin role user to create Zone for KMS service

2019-05-02 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70565/#review215005
---




security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java
Line 80 (original), 85 (patched)


please update the patch.

```
$ git apply --check -v /Users/vperiasamy/Downloads/RANGER-2411.patch
Checking patch 
security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java...
Hunk #1 succeeded at 43 (offset 2 lines).
Hunk #2 succeeded at 57 (offset 2 lines).
error: while searching for:
@Autowired
RangerBizUtil bizUtil;

@POST
@Path("/zones")
public RangerSecurityZone createSecurityZone(RangerSecurityZone 
securityZone) {

error: patch failed: 
security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java:85
error: 
security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java: 
patch does not apply
Checking patch 
security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java...
```


- Velmurugan Periasamy


On April 29, 2019, 8:11 a.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70565/
> ---
> 
> (Updated April 29, 2019, 8:11 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
> Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2411
> https://issues.apache.org/jira/browse/RANGER-2411
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Restrict Admin role user to create Zone for KMS service
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
> 6ce5365 
>   
> security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java 
> edb3102 
> 
> 
> Diff: https://reviews.apache.org/r/70565/diff/1/
> 
> 
> Testing
> ---
> 
> Tested if Admin user is not able to create zone for KMS service.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

[jira] [Commented] (RANGER-2128) Implement SparkSQL plugin

2019-05-02 Thread Srikanth Venkat (JIRA) 


[ 
https://issues.apache.org/jira/browse/RANGER-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831868#comment-16831868
 ] 

Srikanth Venkat commented on RANGER-2128:
-

I have several questions on this:

1) What is the use case we are trying to solve here? Is it using the Spark 
catalog with Ranger AuthZ? Or is this for the use case where there is no Hive 
metastore and Spark has its own catalog (I believe this is the case with Hive3+ 
and in the more recent Spark2.3+ if I remember correctly)

2) Where is this plugin deployed? Will it work on kerberized clusters?

3) What specifically are differences in what is supported between this plugin 
and the current Ranger-Hive Authorizer? What versions of Spark, Hive and Ranger 
will this require?

4) There are pointers to another github project 
[https://github.com/yaooqinn/kyuubi] in the thread above which appears to be an 
enhanced version of SparkThrift Server. It would be good to understand whether 
that has Apache 2 compatible licenses and whether kyuubi has to be included 
into an existing Spark deployment directly or via external dependencies for 
this Spark SQL Ranger plugin to work? If there is a requirement to have Kyuubi 
vesion deployed in a cluster on top of Spark2 then does anyone know whether 
there is any plan to add this directly into Spark2 project first class? It 
becomes more difficult to certify against such clones of core services in 
another Apache project if the mainstream Spark2 project is not supporting this 
enhanced version.

Can we clarify the above items these please?

 

 

> Implement SparkSQL plugin
> -
>
> Key: RANGER-2128
> URL: https://issues.apache.org/jira/browse/RANGER-2128
> Project: Ranger
>  Issue Type: New Feature
>  Components: plugins, Ranger
>Affects Versions: 1.1.0
>Reporter: t oo
>Assignee: Kent Yao
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: support_ranger11.tgz
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Implement SparkSQL plugin



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RANGER-2128) Implement SparkSQL plugin

2019-05-02 Thread Velmurugan Periasamy (JIRA) 


[ 
https://issues.apache.org/jira/browse/RANGER-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831709#comment-16831709
 ] 

Velmurugan Periasamy commented on RANGER-2128:
--

[~Qin Yao] - could you please post your patch to review board - 
[https://reviews.apache.org/groups/ranger/]? Thanks. 

> Implement SparkSQL plugin
> -
>
> Key: RANGER-2128
> URL: https://issues.apache.org/jira/browse/RANGER-2128
> Project: Ranger
>  Issue Type: New Feature
>  Components: plugins, Ranger
>Affects Versions: 1.1.0
>Reporter: t oo
>Assignee: Kent Yao
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: support_ranger11.tgz
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Implement SparkSQL plugin



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)