Re: Review Request 73633: RANGER-3421: Avoid logging key details in RangerMasterKey.java

2021-10-07 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73633/#review223589
---




kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java
Line 223 (original), 219 (patched)


Please review this change. Can it simply be as follows? 

if (savedKey != null && !savedKey.trim().equals("")) {
if (logger.isDebugEnabled()) {
logger.debug("Master Key Created with id = " + savedKey);
}
}


- Abhay Kulkarni


On Oct. 7, 2021, 1:04 a.m., Abhishek  Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73633/
> ---
> 
> (Updated Oct. 7, 2021, 1:04 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Abhay Kulkarni, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3421
> https://issues.apache.org/jira/browse/RANGER-3421
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Avoiding logging key details and code refactoring.
> 
> 
> Diffs
> -
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> adb2c2604 
> 
> 
> Diff: https://reviews.apache.org/r/73633/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Abhishek  Kumar
> 
>

Review Request 73636: RANGER-3418 : Rotated Ranger admin access logs aren't getting removed

2021-10-07 Thread Vishal Suvagia via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73636/
---

Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam 
Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, 
Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan 
Periasamy.


Bugs: RANGER-3418
https://issues.apache.org/jira/browse/RANGER-3418


Repository: ranger


Description
---

Ranger admin access logs in the configured log directory aren't removed and 
keeps up utilizing unused space. Need to have access logs configurable to have 
older logs purged.


Diffs
-

  
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
 62a188b95233eb5d07e253030819819cc50d4565 


Diff: https://reviews.apache.org/r/73636/diff/1/


Testing
---

Validated the changes locally.


Thanks,

Vishal Suvagia

[jira] [Updated] (RANGER-3418) Rotated Ranger admin access logs aren't getting removed

2021-10-07 Thread Vishal Suvagia (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vishal Suvagia updated RANGER-3418:
---
Attachment: RANGER-3418.patch

> Rotated Ranger admin access logs aren't getting removed
> ---
>
> Key: RANGER-3418
> URL: https://issues.apache.org/jira/browse/RANGER-3418
> Project: Ranger
>  Issue Type: Improvement
>  Components: admin, Ranger
>Affects Versions: 3.0.0, 2.1.1
>Reporter: Vishal Suvagia
>Assignee: Vishal Suvagia
>Priority: Major
> Attachments: RANGER-3418.patch
>
>
> {color:#172b4d}Ranger admin access logs in the configured log directory 
> aren't removed and keeps up utilizing unused space. Need to have access logs 
> configurable to have older logs purged.
> {color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (RANGER-3469) Off-By-One Error in XUser Syncing

2021-10-07 Thread David Mollitor (Jira) 


[ 
https://issues.apache.org/jira/browse/RANGER-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17425683#comment-17425683
 ] 

David Mollitor commented on RANGER-3469:


I will attempt a patch shortly.

> Off-By-One Error in XUser Syncing
> -
>
> Key: RANGER-3469
> URL: https://issues.apache.org/jira/browse/RANGER-3469
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: David Mollitor
>Priority: Minor
>
> {code:java|title=PolicyMgrUserGroupBuilder.java}
> int uploadedCount = -1;
> int pageSize = Integer.valueOf(recordsToPullPerCall);
> while (uploadedCount < totalCount) {
>   ...
>   GetXGroupListResponse pagedXGroupList = new GetXGroupListResponse();
>   int pagedXGroupListLen = uploadedCount+pageSize;
>   
> pagedXGroupList.setXgroupInfoList(xGroupList.getXgroupInfoList().subList(uploadedCount+1,pagedXGroupListLen>totalCount?totalCount:pagedXGroupListLen));
> {code}
> The size of the first batch of users to sync is:
> {code:java}
> int uploadedCount = -1;
> // default in value is 1000
> int pageSize = Integer.valueOf(recordsToPullPerCall);
> // value is 1000 + -1 = 999
> int pagedXGroupListLen = uploadedCount+pageSize;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (RANGER-3469) Off-By-One Error in XUser Syncing

2021-10-07 Thread David Mollitor (Jira) 
David Mollitor created RANGER-3469:
--

 Summary: Off-By-One Error in XUser Syncing
 Key: RANGER-3469
 URL: https://issues.apache.org/jira/browse/RANGER-3469
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Reporter: David Mollitor


{code:java|title=PolicyMgrUserGroupBuilder.java}
int uploadedCount = -1;
int pageSize = Integer.valueOf(recordsToPullPerCall);
while (uploadedCount < totalCount) {
...
GetXGroupListResponse pagedXGroupList = new GetXGroupListResponse();
int pagedXGroupListLen = uploadedCount+pageSize;

pagedXGroupList.setXgroupInfoList(xGroupList.getXgroupInfoList().subList(uploadedCount+1,pagedXGroupListLen>totalCount?totalCount:pagedXGroupListLen));
{code}
The size of the first batch of users to sync is:
{code:java}
int uploadedCount = -1;
// default in value is 1000
int pageSize = Integer.valueOf(recordsToPullPerCall);

// value is 1000 + -1 = 999
int pagedXGroupListLen = uploadedCount+pageSize;
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73469: RANGER-3314: Importing atlas policy with old schema displays incorrect permissions on UI

2021-10-07 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73469/#review223587
---




agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java
Lines 1071 (patched)


'restrictions' will include accessTypeRestrictions specified for all 
resource-types referenced in the policy. This does not look correct. 
AccessTypeRestrictions specified for only the leaf-resource-type referenced in 
the policy should be allowed. Please review.

Consider the following service-def:
 resource-type=database; accessTypeRestrictions=[create, alter, drop]
 resource-type=table;accessTypeRestrictions=[create, alter, drop, 
insert, update, select]
 resource-type=column;   accessTypeRestrictions=[insert, update, select]

Policies:
 1. resource={database=db1}: this can only reference access types [create, 
alter, drop]
 2. resource={database=db1, table=t1}: this can only reference access types 
[create, alter, drop, insert, update, select]
 3. resource={database=db1, table=t1, column=c1}: this can only reference 
access types [insert, update, select]
note that [create, alter, drop] are not valid for this policy.



agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java
Lines 1075 (patched)


In addition to policy.getPolicyItems(), other policy item list 
(deny/allow-exceptions/deny-exceptions/data-mask/row-filter) should be 
validated as well.

Also, data-mask and row-filter policy-items can have different set of 
access-types than access items. Please review and update.


- Madhan Neethiraj


On July 29, 2021, 1:03 p.m., Mahesh Bandal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73469/
> ---
> 
> (Updated July 29, 2021, 1:03 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, 
> Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul 
> Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-3314
> https://issues.apache.org/jira/browse/RANGER-3314
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> This is with respect to RANGER-3195 where we have moved the Add/Update/Remove 
> classification permissions to a new classification resource.
> 
> When old atlas policy json is imported, it adds permissions like 
> "entity-add-classification", "entity-update-classification", 
> "entity-remove-classification" in the permission list where the resource is 
> “entity”. These permissions are not valid for resourceType=entity
> 
> Ranger should validate accessTypeRestrictions for each resource during 
> policyImport.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java
>  0ba1fb918 
> 
> 
> Diff: https://reviews.apache.org/r/73469/diff/1/
> 
> 
> Testing
> ---
> 
> Performed policy import for all service types.
> 
> 
> Thanks,
> 
> Mahesh Bandal
> 
>

[jira] [Updated] (RANGER-3466) Support co-routines - async/await in Ranger Python Client

2021-10-07 Thread Zeashan Pappa (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-3466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zeashan Pappa updated RANGER-3466:
--
Description: 
*Background*
 In order to support more modern tooling with Apache Ranger, add configuration 
and necessary interface changes within the Ranger Python Client to support 
async/await, specified within 
[PEP-0492.|https://www.python.org/dev/peps/pep-0492/]

*Implementation* 

**Use asyncio and aiohttp to implement this, and provide existing synchronous 
implementations using request for backwards compatibility.

*Additional Information*

A write up on the performance gains to be had when using aiohttp and 
async/await vs standard synchronous calls through the requests module.

[https://betterprogramming.pub/making-api-requests-in-python-aiohttp-client-vs-requests-26a7025c39a6]

  was:
*Background*
In order to support more modern tooling with Apache Ranger, add configuration 
and necessary interface changes within the Ranger Python Client to support 
async/await, specified within 
[PEP-0492.|https://www.python.org/dev/peps/pep-0492/]

 

*Implementation* 

**Use asyncio and aiohttp to implement this, and provide synchronous interfaces 
for backwards compatibility.

*Additional Information*

A write up on the performance gains to be had when using aiohttp and 
async/await vs standard synchronous calls through the requests module.

https://betterprogramming.pub/making-api-requests-in-python-aiohttp-client-vs-requests-26a7025c39a6


> Support co-routines - async/await in Ranger Python Client
> -
>
> Key: RANGER-3466
> URL: https://issues.apache.org/jira/browse/RANGER-3466
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Zeashan Pappa
>Assignee: Zeashan Pappa
>Priority: Major
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> *Background*
>  In order to support more modern tooling with Apache Ranger, add 
> configuration and necessary interface changes within the Ranger Python Client 
> to support async/await, specified within 
> [PEP-0492.|https://www.python.org/dev/peps/pep-0492/]
> *Implementation* 
> **Use asyncio and aiohttp to implement this, and provide existing synchronous 
> implementations using request for backwards compatibility.
> *Additional Information*
> A write up on the performance gains to be had when using aiohttp and 
> async/await vs standard synchronous calls through the requests module.
> [https://betterprogramming.pub/making-api-requests-in-python-aiohttp-client-vs-requests-26a7025c39a6]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (RANGER-3468) When multiple Ranger tabs are opened, Some tabs are not redirecting to Knox Logout page

2021-10-07 Thread Sailaja Polavarapu (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sailaja Polavarapu reassigned RANGER-3468:
--

Assignee: Sailaja Polavarapu

> When multiple Ranger tabs are opened, Some tabs are not redirecting to Knox 
> Logout page 
> 
>
> Key: RANGER-3468
> URL: https://issues.apache.org/jira/browse/RANGER-3468
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Sailaja Polavarapu
>Assignee: Sailaja Polavarapu
>Priority: Major
>
> When multiple Ranger tabs are open and session timeout happens some tabs are 
> not getting redirected to Knox logout page but we see new session has been 
> created
> Steps
> 1.Open 3 tabs of Ranger
> 2.Wait for idle session timeout
> 3.When checked all the tabs some tabs are not redirected to knox logout page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (RANGER-3468) When multiple Ranger tabs are opened, Some tabs are not redirecting to Knox Logout page

2021-10-07 Thread Sailaja Polavarapu (Jira) 
Sailaja Polavarapu created RANGER-3468:
--

 Summary: When multiple Ranger tabs are opened, Some tabs are not 
redirecting to Knox Logout page 
 Key: RANGER-3468
 URL: https://issues.apache.org/jira/browse/RANGER-3468
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: Sailaja Polavarapu


When multiple Ranger tabs are open and session timeout happens some tabs are 
not getting redirected to Knox logout page but we see new session has been 
created

Steps
1.Open 3 tabs of Ranger
2.Wait for idle session timeout
3.When checked all the tabs some tabs are not redirected to knox logout page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73634: RANGER-3463 : Use apt logger to log messages

2021-10-07 Thread Dhaval Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73634/#review223586
---


Ship it!




Ship It!

- Dhaval Shah


On Oct. 7, 2021, 7:30 a.m., Mateen Mansoori wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73634/
> ---
> 
> (Updated Oct. 7, 2021, 7:30 a.m.)
> 
> 
> Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul 
> Parikh, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3463
> https://issues.apache.org/jira/browse/RANGER-3463
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 
> 98, 104.
> 
> 
> Diffs
> -
> 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 
> 925d2c76f 
> 
> 
> Diff: https://reviews.apache.org/r/73634/diff/2/
> 
> 
> Testing
> ---
> 
> Tested on local VM.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>

Re: Review Request 73469: RANGER-3314: Importing atlas policy with old schema displays incorrect permissions on UI

2021-10-07 Thread Kishor Gollapalliwar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73469/#review223585
---


Ship it!




Ship It!

- Kishor Gollapalliwar


On July 29, 2021, 1:03 p.m., Mahesh Bandal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73469/
> ---
> 
> (Updated July 29, 2021, 1:03 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, 
> Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul 
> Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-3314
> https://issues.apache.org/jira/browse/RANGER-3314
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> This is with respect to RANGER-3195 where we have moved the Add/Update/Remove 
> classification permissions to a new classification resource.
> 
> When old atlas policy json is imported, it adds permissions like 
> "entity-add-classification", "entity-update-classification", 
> "entity-remove-classification" in the permission list where the resource is 
> “entity”. These permissions are not valid for resourceType=entity
> 
> Ranger should validate accessTypeRestrictions for each resource during 
> policyImport.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java
>  0ba1fb918 
> 
> 
> Diff: https://reviews.apache.org/r/73469/diff/1/
> 
> 
> Testing
> ---
> 
> Performed policy import for all service types.
> 
> 
> Thanks,
> 
> Mahesh Bandal
> 
>

Re: Review Request 73634: RANGER-3463 : Use apt logger to log messages

2021-10-07 Thread Kishor Gollapalliwar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73634/#review223583
---


Ship it!




Ship It!

- Kishor Gollapalliwar


On Oct. 7, 2021, 7:30 a.m., Mateen Mansoori wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73634/
> ---
> 
> (Updated Oct. 7, 2021, 7:30 a.m.)
> 
> 
> Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul 
> Parikh, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3463
> https://issues.apache.org/jira/browse/RANGER-3463
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 
> 98, 104.
> 
> 
> Diffs
> -
> 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 
> 925d2c76f 
> 
> 
> Diff: https://reviews.apache.org/r/73634/diff/2/
> 
> 
> Testing
> ---
> 
> Tested on local VM.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>

Re: Review Request 73634: RANGER-3463 : Use apt logger to log messages

2021-10-07 Thread Mateen Mansoori 


> On Oct. 7, 2021, 7:07 a.m., Kishor Gollapalliwar wrote:
> > kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
> > Lines 120 (patched)
> > 
> >
> > Please consider restricting scope of this variable by declaring it 
> > inside IF block.

Here 'jsonEncKeyByAlgo' variable is required in outer if block as we are using 
the same in that block.


- Mateen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73634/#review223581
---


On Oct. 7, 2021, 7:30 a.m., Mateen Mansoori wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73634/
> ---
> 
> (Updated Oct. 7, 2021, 7:30 a.m.)
> 
> 
> Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul 
> Parikh, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3463
> https://issues.apache.org/jira/browse/RANGER-3463
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 
> 98, 104.
> 
> 
> Diffs
> -
> 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 
> 925d2c76f 
> 
> 
> Diff: https://reviews.apache.org/r/73634/diff/2/
> 
> 
> Testing
> ---
> 
> Tested on local VM.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>

Re: Review Request 73634: RANGER-3463 : Use apt logger to log messages

2021-10-07 Thread Mateen Mansoori 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73634/
---

(Updated Oct. 7, 2021, 7:30 a.m.)


Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul 
Parikh, Ramesh Mani, and Velmurugan Periasamy.


Changes
---

Handled review comments.


Bugs: RANGER-3463
https://issues.apache.org/jira/browse/RANGER-3463


Repository: ranger


Description
---

Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 
98, 104.


Diffs (updated)
-

  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 
925d2c76f 


Diff: https://reviews.apache.org/r/73634/diff/2/

Changes: https://reviews.apache.org/r/73634/diff/1-2/


Testing
---

Tested on local VM.


Thanks,

Mateen Mansoori

Re: Review Request 73634: RANGER-3463 : Use apt logger to log messages

2021-10-07 Thread Kishor Gollapalliwar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73634/#review223581
---




kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
Lines 67 (patched)


Please consider restricting scope of this variable by declaring it inside 
IF block.



kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
Lines 89 (patched)


Please consider restricting scope of this variable by declaring it inside 
IF block.



kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
Lines 120 (patched)


Please consider restricting scope of this variable by declaring it inside 
IF block.


- Kishor Gollapalliwar


On Oct. 7, 2021, 5:07 a.m., Mateen Mansoori wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73634/
> ---
> 
> (Updated Oct. 7, 2021, 5:07 a.m.)
> 
> 
> Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul 
> Parikh, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3463
> https://issues.apache.org/jira/browse/RANGER-3463
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 
> 98, 104.
> 
> 
> Diffs
> -
> 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 
> 925d2c76f 
> 
> 
> Diff: https://reviews.apache.org/r/73634/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local VM.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>

Re: Review Request 73634: RANGER-3463 : Use apt logger to log messages

2021-10-07 Thread Kishor Gollapalliwar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73634/#review223580
---




kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
Line 35 (original), 35 (patched)


Please consider removing un-necessary spaces.



kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
Line 123 (original), 124 (patched)


Please consider removing un-necessary spaces.



kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
Line 137 (original), 137 (patched)


Please consider removing un-necessary spaces.


- Kishor Gollapalliwar


On Oct. 7, 2021, 5:07 a.m., Mateen Mansoori wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73634/
> ---
> 
> (Updated Oct. 7, 2021, 5:07 a.m.)
> 
> 
> Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul 
> Parikh, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3463
> https://issues.apache.org/jira/browse/RANGER-3463
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 
> 98, 104.
> 
> 
> Diffs
> -
> 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 
> 925d2c76f 
> 
> 
> Diff: https://reviews.apache.org/r/73634/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local VM.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>